@windyroad/itil 0.61.1 → 0.61.2

package/scripts/test/update-references-section-sibling-helpers.bats

@@ -1,80 +0,0 @@
-#!/usr/bin/env bats
-
-# P170 / Phase 2 Slice 2b — sanity bats for the 3 sibling helpers
-# (update-rfc-references-section.sh, update-jtbd-references-section.sh,
-# update-story-references-section.sh). Behavioural coverage of the
-# polymorphism is asserted by the comprehensive Slice 2a bats fixture
-# at update-problem-references-section.bats; this fixture asserts
-# existence + executable + arg-validation + structural no-branching
-# guard for the 3 siblings, deferring full behavioural coverage to
-# follow-on slice when the siblings are wired into consumer skills.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  RFC_HELPER="$REPO_ROOT/packages/itil/scripts/update-rfc-references-section.sh"
-  JTBD_HELPER="$REPO_ROOT/packages/itil/scripts/update-jtbd-references-section.sh"
-  STORY_HELPER="$REPO_ROOT/packages/itil/scripts/update-story-references-section.sh"
-}
-
-@test "rfc-helper: exists and is executable" {
-  [ -x "$RFC_HELPER" ]
-}
-
-@test "rfc-helper: requires rfc-file arg" {
-  run bash "$RFC_HELPER"
-  [ "$status" -ne 0 ]
-}
-
-@test "rfc-helper: requires section-name arg" {
-  local tmp
-  tmp="$(mktemp)"
-  run bash "$RFC_HELPER" "$tmp"
-  [ "$status" -ne 0 ]
-  rm -f "$tmp"
-}
-
-@test "rfc-helper: body has no per-section-name branch" {
-  ! grep -E 'case[[:space:]]+"\$\{?section[_-]?name\}?"|if[[:space:]]+\[[[:space:]]+"\$\{?section[_-]?name\}?"[[:space:]]+=' "$RFC_HELPER"
-}
-
-@test "jtbd-helper: exists and is executable" {
-  [ -x "$JTBD_HELPER" ]
-}
-
-@test "jtbd-helper: requires jtbd-file arg" {
-  run bash "$JTBD_HELPER"
-  [ "$status" -ne 0 ]
-}
-
-@test "jtbd-helper: requires section-name arg" {
-  local tmp
-  tmp="$(mktemp)"
-  run bash "$JTBD_HELPER" "$tmp"
-  [ "$status" -ne 0 ]
-  rm -f "$tmp"
-}
-
-@test "jtbd-helper: body has no per-section-name branch" {
-  ! grep -E 'case[[:space:]]+"\$\{?section[_-]?name\}?"|if[[:space:]]+\[[[:space:]]+"\$\{?section[_-]?name\}?"[[:space:]]+=' "$JTBD_HELPER"
-}
-
-@test "story-helper: exists and is executable" {
-  [ -x "$STORY_HELPER" ]
-}
-
-@test "story-helper: requires story-file arg" {
-  run bash "$STORY_HELPER"
-  [ "$status" -ne 0 ]
-}
-
-@test "story-helper: requires section-name arg" {
-  local tmp
-  tmp="$(mktemp)"
-  run bash "$STORY_HELPER" "$tmp"
-  [ "$status" -ne 0 ]
-  rm -f "$tmp"
-}
-
-@test "story-helper: body has no per-section-name branch" {
-  ! grep -E 'case[[:space:]]+"\$\{?section[_-]?name\}?"|if[[:space:]]+\[[[:space:]]+"\$\{?section[_-]?name\}?"[[:space:]]+=' "$STORY_HELPER"
-}

package/scripts/test/update-rfc-commits-section.bats

@@ -1,77 +0,0 @@
-#!/usr/bin/env bats
-
-# P378/RFC-030 Piece 1 (ADR-085): update-rfc-commits-section.sh renders the RFC
-# `## Commits` section as a derived view from `git log --grep "Refs: RFC-NNN"`.
-# Behavioural — exercises the renderer against a throwaway git repo.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  HELPER="$REPO_ROOT/packages/itil/scripts/update-rfc-commits-section.sh"
-  DIR="$(mktemp -d)"
-  cd "$DIR"
-  git init -q
-  git config user.email t@e.x; git config user.name t
-  mkdir -p docs/rfcs
-  cat > docs/rfcs/RFC-201-thing.proposed.md <<'EOF'
-# RFC-201: thing
-
-## Commits
-
-(placeholder)
-
-## Related
-
-x
-EOF
-  git add -A && git commit -qm "chore: seed"
-}
-teardown() { cd /; rm -rf "$DIR"; }
-
-@test "renders commits carrying the Refs: RFC-NNN trailer, newest first" {
-  echo a > a; git add a; git commit -qm "$(printf 'feat: a\n\nRefs: RFC-201')"
-  echo b > b; git add b; git commit -qm "$(printf 'fix: b\n\nRefs: RFC-201')"
-  run bash "$HELPER" docs/rfcs/RFC-201-thing.proposed.md
-  [ "$status" -eq 0 ]
-  run sed -n '/## Commits/,/## Related/p' docs/rfcs/RFC-201-thing.proposed.md
-  [[ "$output" == *"fix: b"* ]]
-  [[ "$output" == *"feat: a"* ]]
-  # newest first: fix: b appears before feat: a
-  [[ "$output" == *"fix: b"*"feat: a"* ]]
-  # placeholder body is gone
-  [[ "$output" != *"(placeholder)"* ]]
-}
-
-@test "does NOT include commits without the trailer" {
-  echo a > a; git add a; git commit -qm "$(printf 'feat: tagged\n\nRefs: RFC-201')"
-  echo b > b; git add b; git commit -qm "chore: untagged"
-  run bash "$HELPER" docs/rfcs/RFC-201-thing.proposed.md
-  run sed -n '/## Commits/,/## Related/p' docs/rfcs/RFC-201-thing.proposed.md
-  [[ "$output" == *"feat: tagged"* ]]
-  [[ "$output" != *"chore: untagged"* ]]
-}
-
-@test "no trailer-bearing commits → renders a self-describing placeholder, not a false claim" {
-  run bash "$HELPER" docs/rfcs/RFC-201-thing.proposed.md
-  [ "$status" -eq 0 ]
-  run sed -n '/## Commits/,/## Related/p' docs/rfcs/RFC-201-thing.proposed.md
-  [[ "$output" == *"rendered from"* ]] && [[ "$output" == *"git log"* ]]
-  [[ "$output" != *"maintained automatically"* ]]
-}
-
-@test "idempotent — second render is a byte-stable no-op" {
-  echo a > a; git add a; git commit -qm "$(printf 'feat: a\n\nRefs: RFC-201')"
-  bash "$HELPER" docs/rfcs/RFC-201-thing.proposed.md
-  h1=$(shasum docs/rfcs/RFC-201-thing.proposed.md | cut -d' ' -f1)
-  bash "$HELPER" docs/rfcs/RFC-201-thing.proposed.md
-  h2=$(shasum docs/rfcs/RFC-201-thing.proposed.md | cut -d' ' -f1)
-  [ "$h1" = "$h2" ]
-}
-
-@test "preserves sections after ## Commits (## Related survives)" {
-  echo a > a; git add a; git commit -qm "$(printf 'feat: a\n\nRefs: RFC-201')"
-  bash "$HELPER" docs/rfcs/RFC-201-thing.proposed.md
-  run grep -c "## Related" docs/rfcs/RFC-201-thing.proposed.md
-  [ "$output" -eq 1 ]
-  run grep -c "^x$" docs/rfcs/RFC-201-thing.proposed.md
-  [ "$output" -eq 1 ]
-}

package/scripts/test/verify-iter-summary.bats

@@ -1,196 +0,0 @@
-#!/usr/bin/env bats
-
-# @problem P335 — AFK iter subprocess over-claims completion in
-# ITERATION_SUMMARY notes / commit message while on-disk Confirmation
-# checkboxes remain `[ ]`. Step 6.75 currently runs `git status --porcelain`
-# only — catches commit-didn't-land but not commit-landed-with-false-claim.
-# This verifier closes the gap.
-#
-# Contract: `verify-iter-summary.sh` (or PATH shim
-# `wr-itil-verify-iter-summary`) reads:
-#   $1 = commit_sha (the iter's landed commit)
-#   $2 = path to a file containing the ITERATION_SUMMARY notes field
-#   $3 = repo root (optional; defaults to `git rev-parse --show-toplevel`)
-#
-# Mechanism:
-#   1. Extract `ADR-NNN` identifiers from the commit message
-#      (`git log -1 --format=%B <sha>`) AND the notes file.
-#   2. For each identifier, resolve to `docs/decisions/<NNN>-*.md` (any
-#      status suffix — `.proposed.md` / `.accepted.md` / etc).
-#   3. Detect completion-claim signal in commit message OR notes (regex
-#      family: `all .*(green|complete|done|checked|ticked)`,
-#      `\([a-z]\)\s*[-–]\s*\([a-z]\)\s+(green|complete|all)`,
-#      `all\s+Confirmation\s+items`).
-#   4. When signal present AND any `- [ ]` item exists in the cited ADR's
-#      `## Confirmation` section → emit `OVER-CLAIM:` line and exit 1.
-#   5. Otherwise exit 0.
-#
-# Exit codes:
-#   0 = OK (no signal, or signal-and-all-items-checked, or no ADR referenced)
-#   1 = OVER-CLAIM detected
-#   2 = invocation error (missing args, bad sha, etc)
-#
-# @adr ADR-032 (subprocess-boundary trust contract — orchestrator decides
-#               trust boundary; verifier is the policy-authorised silent check)
-# @adr ADR-049 (Plugin-bundled scripts ship as bin/ PATH shims;
-#               wr-itil-verify-iter-summary is the shim name)
-# @adr ADR-052 (Behavioural tests for skill testing; this bats covers
-#               the OVER-CLAIM detection behaviour, not script structure)
-# @jtbd JTBD-006 (Progress the Backlog While I'm Away — orchestrator-side
-#                 verification keeps AFK loop integrity intact when iter
-#                 self-certification fails)
-
-setup() {
-  SCRIPTS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SCRIPT="$SCRIPTS_DIR/verify-iter-summary.sh"
-  FIXTURE_DIR="$(mktemp -d)"
-  cd "$FIXTURE_DIR"
-  git init -q
-  git config user.email test@example.com
-  git config user.name "Test"
-  mkdir -p docs/decisions
-}
-
-teardown() {
-  cd /
-  rm -rf "$FIXTURE_DIR"
-}
-
-# Helper: create a fake ADR with the given Confirmation-section body.
-_make_adr() {
-  local num="$1" status="$2" confirmation_body="$3"
-  cat > "docs/decisions/${num}-fake-adr.${status}.md" <<EOF
-# ${num}. Fake ADR
-
-## Status
-${status}
-
-## Confirmation
-${confirmation_body}
-EOF
-}
-
-# Helper: commit a file with the given message; return the SHA via stdout.
-_commit_with_message() {
-  local message="$1"
-  echo "dummy" > dummy.txt
-  git add dummy.txt
-  git commit -q -m "$message"
-  git log -1 --format=%H
-}
-
-# ── Existence + executable ──────────────────────────────────────────────────
-
-@test "verify-iter-summary: script exists" {
-  [ -f "$SCRIPT" ]
-}
-
-@test "verify-iter-summary: script is executable" {
-  [ -x "$SCRIPT" ]
-}
-
-# ── Exit 0: no completion-claim signal ──────────────────────────────────────
-
-@test "verify-iter-summary: notes mention ADR but no completion-claim signal → OK" {
-  _make_adr 077 proposed "- [ ] **(a) Item A**
-- [ ] **(b) Item B**"
-  local sha; sha=$(_commit_with_message "feat(architect): ADR-077 Slice 1 partial work")
-  echo "P327 progressed; partial slice landed; further work needed for Confirmation items (a)+(b)." > notes.txt
-
-  run "$SCRIPT" "$sha" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-}
-
-@test "verify-iter-summary: no ADR referenced at all → OK" {
-  local sha; sha=$(_commit_with_message "fix(itil): rename helper variable")
-  echo "Bugfix; no governance impact." > notes.txt
-
-  run "$SCRIPT" "$sha" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-}
-
-# ── Exit 0: signal present but all items checked ────────────────────────────
-
-@test "verify-iter-summary: completion-claim signal AND all items checked → OK" {
-  _make_adr 077 proposed "- [x] **(a) Item A**
-- [x] **(b) Item B**"
-  local sha; sha=$(_commit_with_message "feat(architect): ADR-077 — all Confirmation items complete")
-  echo "All ADR-077 Confirmation items green." > notes.txt
-
-  run "$SCRIPT" "$sha" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-}
-
-# ── Exit 1: P335 witness shape — claim "all green" + unchecked items ────────
-
-@test "verify-iter-summary: claim 'all green at source' + unchecked items → OVER-CLAIM" {
-  # The P335 session 8 iter 1 witness shape: commit message claims (a)–(j)
-  # green; all 10 boxes are `[ ]`.
-  _make_adr 077 proposed "- [ ] **(a) Agent prompt amendment**
-- [ ] **(b) Generator script**
-- [ ] **(c) Initial compendium**
-- [ ] **(d) create-adr integration**
-- [ ] **(e) capture-adr integration**
-- [ ] **(f) review-decisions integration**
-- [ ] **(g) CI drift bats**
-- [ ] **(h) Pre-commit hook**
-- [ ] **(i) ADR-031 assertion**
-- [ ] **(j) No silent regression**"
-  local sha; sha=$(_commit_with_message "feat(architect): ADR-077 Slice 3 — all (a)-(j) green at source")
-  echo "ADR-077 Slice 3 — Confirmation items (a)-(j) all green at source." > notes.txt
-
-  run "$SCRIPT" "$sha" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 1 ]
-  echo "$output" | grep -q "OVER-CLAIM"
-  echo "$output" | grep -q "ADR-077"
-}
-
-@test "verify-iter-summary: claim 'all Confirmation items complete' + unchecked → OVER-CLAIM" {
-  _make_adr 100 accepted "- [x] **(a) Done**
-- [ ] **(b) Still pending**"
-  local sha; sha=$(_commit_with_message "feat: ADR-100 — all Confirmation items complete")
-  echo "Implementation finished." > notes.txt
-
-  run "$SCRIPT" "$sha" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 1 ]
-  echo "$output" | grep -q "OVER-CLAIM"
-}
-
-@test "verify-iter-summary: signal only in notes (not commit msg) + unchecked → OVER-CLAIM" {
-  _make_adr 200 proposed "- [ ] **(a) Missing**"
-  local sha; sha=$(_commit_with_message "feat: ADR-200 progress")
-  # Note completion signal lives in notes, not the commit subject.
-  echo "All Confirmation items ticked for ADR-200." > notes.txt
-
-  run "$SCRIPT" "$sha" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 1 ]
-  echo "$output" | grep -q "OVER-CLAIM"
-  echo "$output" | grep -q "ADR-200"
-}
-
-# ── Invocation errors ───────────────────────────────────────────────────────
-
-@test "verify-iter-summary: missing notes file → invocation error" {
-  local sha; sha=$(_commit_with_message "init")
-  run "$SCRIPT" "$sha" /nonexistent/notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 2 ]
-}
-
-@test "verify-iter-summary: missing sha → invocation error" {
-  echo "" > notes.txt
-  run "$SCRIPT" "" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 2 ]
-}
-
-# ── Multi-ADR case ──────────────────────────────────────────────────────────
-
-@test "verify-iter-summary: two ADRs cited — one clean, one over-claim → OVER-CLAIM only on the bad one" {
-  _make_adr 050 accepted "- [x] **(a) Clean**"
-  _make_adr 060 proposed "- [ ] **(a) Dirty**"
-  local sha; sha=$(_commit_with_message "feat: ADR-050 + ADR-060 — all green")
-  echo "Both ADRs progressed; all items green." > notes.txt
-
-  run "$SCRIPT" "$sha" notes.txt "$FIXTURE_DIR"
-  [ "$status" -eq 1 ]
-  echo "$output" | grep -q "ADR-060"
-}

package/scripts/test/working-the-problem-traversal.bats

@@ -1,116 +0,0 @@
-#!/usr/bin/env bats
-# Behavioural fixtures for the Phase 2 working-the-problem traversal
-# rewrite (P170 Phase 2 Slice 13 — ADR-060 lines 300-320).
-#
-# Per ADR-052: behavioural assertions on observable artefact + skill
-# contract state. The load-bearing surfaces under test are:
-#   1. manage-problem § Working a Problem → Known Error subsection names
-#      the four traversal steps (Fix Strategy → RFCs → stories: array →
-#      pick first not-done) + the two fallback paths (atomic-RFC empty
-#      stories: [], legacy no-RFC Fix Strategy).
-#   2. work-problem § Step 3 Known Error case names the same traversal
-#      and forward-points to manage-problem as the contract owner.
-#   3. The single-trailer vocabulary holds — `Refs: STORY-NNN` for
-#      story-decomposed work, `Refs: RFC-NNN` for atomic-RFC fallback,
-#      `Refs: P<NNN>` for legacy direct work (single trailer verb per
-#      ADR-060 line 307).
-#   4. Story auto-transition triggers are named: draft → in-progress
-#      on first non-capture commit; in-progress → done on
-#      all-criteria-ticked + linked RFC closed.
-#
-# @problem P170
-# @jtbd JTBD-008 (Decompose a Fix Into Coordinated Changes — traversal
-#                  operationalises the "first-class entity" Desired
-#                  Outcome at implementation time)
-# @jtbd JTBD-101 (atomic-fix-adopter friction guard — empty stories: []
-#                  falls back to per-RFC dispatch without friction)
-# @adr  ADR-060  (Problem-RFC-Story framework — working-the-problem
-#                  flow lines 300-320 + amendment 2026-05-10 nitpick N2
-#                  single-trailer vocabulary)
-# @adr  ADR-052  (Behavioural-tests-default)
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  MANAGE_PROBLEM="${REPO_ROOT}/packages/itil/skills/manage-problem/SKILL.md"
-  WORK_PROBLEM="${REPO_ROOT}/packages/itil/skills/work-problem/SKILL.md"
-}
-
-# ---------------------------------------------------------------------------
-# Surface 1: manage-problem § Working a Problem → Known Error names the
-# 4-step traversal (Fix Strategy → RFCs → stories: → pick first not-done)
-# ---------------------------------------------------------------------------
-
-@test "traversal: manage-problem names the Fix Strategy section extraction step" {
-  run grep -E 'Read the problem.*\#\# Fix Strategy.*RFC' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-@test "traversal: manage-problem names the RFC frontmatter stories: array read step" {
-  run grep -E 'frontmatter stories:.*ORDERED|stories:.*array.*execution sequence' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-@test "traversal: manage-problem names the pick-first-not-done filter (accepted or in-progress)" {
-  run grep -E 'accepted.*in-progress.*done.*draft|first story whose.*status is.*accepted' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-# ---------------------------------------------------------------------------
-# Surface 2: manage-problem — empty stories: [] is a legacy/back-fill state,
-# NOT a legitimate atomic fallback (ADR-089: every RFC has >=1 story). The old
-# JTBD-101-friction-guard atomic-RFC-empty-stories fallback is removed; the
-# legacy no-RFC direct-implementation fallback (a distinct path) stays.
-# ---------------------------------------------------------------------------
-
-@test "traversal: manage-problem treats empty stories: [] as legacy/back-fill, not a legitimate atomic fallback (ADR-089)" {
-  # Positive: the ADR-089 model (>=1 story; back-fill the legacy empty-stories RFC) is named.
-  run grep -iE 'ADR-089|back-fill' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-  # Negative: the old atomic-RFC empty-stories fallback legitimation is gone.
-  run grep -iE 'atomic-RFC fallback|atomic RFC.*JTBD-101.*friction guard' "$MANAGE_PROBLEM"
-  [ "$status" -ne 0 ]
-}
-
-@test "traversal: manage-problem names the legacy no-RFC direct-implementation fallback" {
-  run grep -iE 'legacy direct-implementation|no-RFC.*legacy|no RFCs.*direct' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-# ---------------------------------------------------------------------------
-# Surface 3: work-problem § Step 3 Known Error case forwards to manage-problem
-# ---------------------------------------------------------------------------
-
-@test "traversal: work-problem Step 3 Known Error case names the traversal chain" {
-  # The traversal description must include all four chain elements:
-  # Fix Strategy, RFCs, stories: array, pick first not-done.
-  run grep -iE 'Fix Strategy.*stories:.*pick first|traverse.*Fix Strategy.*RFC.*stories' "$WORK_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-# ---------------------------------------------------------------------------
-# Surface 4: Single-trailer vocabulary (per ADR-060 line 307 + N2 amendment)
-# ---------------------------------------------------------------------------
-
-@test "traversal: manage-problem names Refs: STORY-NNN trailer for story-decomposed work" {
-  run grep -E 'Refs: STORY-' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-@test "traversal: manage-problem names Refs: RFC-NNN trailer for cross-cutting RFC work (no single story)" {
-  run grep -E 'Refs: RFC-' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-# ---------------------------------------------------------------------------
-# Surface 5: Story auto-transition triggers
-# ---------------------------------------------------------------------------
-
-@test "traversal: manage-problem names the story draft → in-progress auto-transition trigger" {
-  run grep -iE 'draft.*in-progress.*first.*commit|auto-transitions.*draft.*in-progress' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}
-
-@test "traversal: manage-problem names the in-progress → done auto-transition trigger (criteria ticked + RFC closed)" {
-  run grep -iE 'in-progress.*done.*acceptance-criteria.*ticked|ALL acceptance-criteria.*RFC reaches.*closed' "$MANAGE_PROBLEM"
-  [ "$status" -eq 0 ]
-}