@windyroad/itil 0.61.1 → 0.61.2

package/scripts/test/dual-tolerant-glob-rfc-002-t2.bats

@@ -1,309 +0,0 @@
-#!/usr/bin/env bats
-
-# @rfc RFC-002 T2 — Dual-tolerant SKILL.md glob updates
-# @adr ADR-031 (Problem-ticket directory layout)
-# @adr ADR-051 (load-bearing-from-the-start — the dual-tolerant glob
-#   contract ships with a behavioural enforcement test, not later by
-#   graceful drift)
-# @adr ADR-052 (behavioural-bats default — this test exercises the
-#   glob shape against synthetic fixtures and asserts observable
-#   enumeration behaviour; it does NOT structurally grep SKILL.md
-#   prose for the dual-pattern string, which would be P081-class
-#   structural-test-disguised-as-behavioural)
-# @adr ADR-014 (single-purpose: one mechanical contract — dual-glob
-#   enumeration parity across both layouts)
-# @problem P069 (driving — flat layout unskimmable; the migration this
-#   contract guards is the relief)
-# @problem P081 (no structural-grep on SKILL.md content — this test
-#   is the behavioural alternative)
-# @jtbd JTBD-001 (extended scope — multi-commit RFC-grain coordinated
-#   change; the test is the cross-skill invariant the SKILL.md edits
-#   share)
-# @jtbd JTBD-006 (work-backlog-AFK — dual-tolerant globs preserve
-#   AFK-loop continuity across the migration window; without this
-#   contract, mid-migration loop iterations silently miss tickets in
-#   the un-migrated layout)
-#
-# Contract: SKILL.md enumeration globs of `docs/problems/<state>/...`
-# during the RFC-002 migration window MUST match BOTH the flat layout
-# (`docs/problems/<NNN>-<title>.<state>.md`) AND the per-state subdir
-# layout (`docs/problems/<state>/<NNN>-<title>.md`). The dual-tolerant
-# pattern shape is:
-#
-#   ls docs/problems/*.<state>.md docs/problems/<state>/*.md 2>/dev/null
-#
-# (with `2>/dev/null` swallowing the no-match error from whichever
-# half of the OR currently has zero matches.)
-#
-# This test exercises the canonical dual-tolerant pattern shapes (state-
-# filtered enumeration, ID-anchored lookup, all-state-all-tickets) on
-# synthetic fixtures of three shapes (flat-only, per-state-only, mixed).
-# Each cross-product asserts non-empty enumeration of every present
-# ticket and zero false-positive enumeration of absent tickets.
-#
-# CONTRACT NOTE: when one half of the dual-glob has zero matches in the
-# current fixture (single-layout fixtures), `ls X Y 2>/dev/null` exits
-# nonzero — the unmatched literal pathname propagates to ls's argv and
-# `2>/dev/null` only suppresses the stderr noise, not the exit code.
-# This is CORRECT behaviour — SKILL.md call sites MUST treat STDOUT
-# emptiness as the canonical "no tickets" signal, NOT exit code zero.
-# Test assertions therefore probe stdout content, not `$status`, except
-# in the empty-fixture and missing-ID cases where nonzero exit is the
-# intended contract.
-#
-# T6 (post-T5 verification) drops the flat-layout half. This test
-# updates at T6 to single-pattern, NOT removed — the contract becomes
-# "per-state layout enumerates correctly" but remains behavioural.
-
-setup() {
-  REPO_ROOT="$(mktemp -d)"
-  cd "$REPO_ROOT"
-  mkdir -p docs/problems
-}
-
-teardown() {
-  cd /
-  rm -rf "$REPO_ROOT"
-}
-
-# ── fixture builders ─────────────────────────────────────────────────────────
-
-build_flat_layout() {
-  cat > docs/problems/100-foo.open.md <<'EOF'
-# Problem 100: Foo
-**Status**: Open
-EOF
-  cat > docs/problems/101-bar.known-error.md <<'EOF'
-# Problem 101: Bar
-**Status**: Known Error
-EOF
-  cat > docs/problems/102-baz.verifying.md <<'EOF'
-# Problem 102: Baz
-**Status**: Verification Pending
-EOF
-  cat > docs/problems/103-qux.parked.md <<'EOF'
-# Problem 103: Qux
-**Status**: Parked
-EOF
-  cat > docs/problems/104-quux.closed.md <<'EOF'
-# Problem 104: Quux
-**Status**: Closed
-EOF
-}
-
-build_per_state_layout() {
-  mkdir -p docs/problems/open docs/problems/known-error docs/problems/verifying docs/problems/parked docs/problems/closed
-  cat > docs/problems/open/200-foo2.md <<'EOF'
-# Problem 200: Foo2
-**Status**: Open
-EOF
-  cat > docs/problems/known-error/201-bar2.md <<'EOF'
-# Problem 201: Bar2
-**Status**: Known Error
-EOF
-  cat > docs/problems/verifying/202-baz2.md <<'EOF'
-# Problem 202: Baz2
-**Status**: Verification Pending
-EOF
-  cat > docs/problems/parked/203-qux2.md <<'EOF'
-# Problem 203: Qux2
-**Status**: Parked
-EOF
-  cat > docs/problems/closed/204-quux2.md <<'EOF'
-# Problem 204: Quux2
-**Status**: Closed
-EOF
-}
-
-build_mixed_layout() {
-  build_flat_layout
-  build_per_state_layout
-}
-
-# ── Pattern A: state-filtered enumeration ────────────────────────────────────
-
-@test "dual-tolerant state-filtered glob: flat-only fixture enumerates open ticket" {
-  build_flat_layout
-  run bash -c 'ls docs/problems/*.open.md docs/problems/open/*.md 2>/dev/null'
-  # ls exits nonzero because the per-state half has no match — stdout
-  # content is the canonical signal, not exit code.
-  [[ "$output" == *"100-foo.open.md"* ]]
-}
-
-@test "dual-tolerant state-filtered glob: per-state-only fixture enumerates open ticket" {
-  build_per_state_layout
-  run bash -c 'ls docs/problems/*.open.md docs/problems/open/*.md 2>/dev/null'
-  [[ "$output" == *"open/200-foo2.md"* ]]
-}
-
-@test "dual-tolerant state-filtered glob: mixed fixture enumerates BOTH layouts simultaneously" {
-  build_mixed_layout
-  run bash -c 'ls docs/problems/*.open.md docs/problems/open/*.md 2>/dev/null'
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"100-foo.open.md"* ]]
-  [[ "$output" == *"open/200-foo2.md"* ]]
-}
-
-@test "dual-tolerant state-filtered glob: mixed fixture, known-error" {
-  build_mixed_layout
-  run bash -c 'ls docs/problems/*.known-error.md docs/problems/known-error/*.md 2>/dev/null'
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"101-bar.known-error.md"* ]]
-  [[ "$output" == *"known-error/201-bar2.md"* ]]
-}
-
-@test "dual-tolerant state-filtered glob: mixed fixture, verifying" {
-  build_mixed_layout
-  run bash -c 'ls docs/problems/*.verifying.md docs/problems/verifying/*.md 2>/dev/null'
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"102-baz.verifying.md"* ]]
-  [[ "$output" == *"verifying/202-baz2.md"* ]]
-}
-
-@test "dual-tolerant state-filtered glob: mixed fixture, parked" {
-  build_mixed_layout
-  run bash -c 'ls docs/problems/*.parked.md docs/problems/parked/*.md 2>/dev/null'
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"103-qux.parked.md"* ]]
-  [[ "$output" == *"parked/203-qux2.md"* ]]
-}
-
-@test "dual-tolerant state-filtered glob: state filter excludes other-state tickets in flat layout" {
-  build_flat_layout
-  run bash -c 'ls docs/problems/*.open.md docs/problems/open/*.md 2>/dev/null'
-  [[ "$output" != *"known-error"* ]]
-  [[ "$output" != *"verifying"* ]]
-  [[ "$output" != *"parked"* ]]
-  [[ "$output" != *"closed"* ]]
-}
-
-@test "dual-tolerant state-filtered glob: state filter excludes other-state subdirs in per-state layout" {
-  build_per_state_layout
-  run bash -c 'ls docs/problems/*.open.md docs/problems/open/*.md 2>/dev/null'
-  # No known-error/, verifying/, parked/, closed/ subdir contents leak into open enumeration.
-  [[ "$output" != *"201-bar2.md"* ]]
-  [[ "$output" != *"202-baz2.md"* ]]
-  [[ "$output" != *"203-qux2.md"* ]]
-  [[ "$output" != *"204-quux2.md"* ]]
-}
-
-# ── Pattern B: ID-anchored lookup (any state) ────────────────────────────────
-
-@test "dual-tolerant ID-anchored glob: flat-only fixture finds ticket by ID" {
-  build_flat_layout
-  run bash -c 'ls docs/problems/100-*.md docs/problems/*/100-*.md 2>/dev/null'
-  # Single-layout fixture: ls exits nonzero on the unmatched half;
-  # stdout content is the contract signal.
-  [[ "$output" == *"100-foo.open.md"* ]]
-}
-
-@test "dual-tolerant ID-anchored glob: per-state-only fixture finds ticket by ID" {
-  build_per_state_layout
-  run bash -c 'ls docs/problems/200-*.md docs/problems/*/200-*.md 2>/dev/null'
-  [[ "$output" == *"open/200-foo2.md"* ]]
-}
-
-@test "dual-tolerant ID-anchored glob: mixed fixture finds tickets across both layouts" {
-  build_mixed_layout
-  run bash -c 'ls docs/problems/100-*.md docs/problems/*/100-*.md 2>/dev/null'
-  [[ "$output" == *"100-foo.open.md"* ]]
-  run bash -c 'ls docs/problems/200-*.md docs/problems/*/200-*.md 2>/dev/null'
-  [[ "$output" == *"open/200-foo2.md"* ]]
-}
-
-@test "dual-tolerant ID-anchored glob: missing ID returns empty (status nonzero from ls)" {
-  build_flat_layout
-  set +e
-  result=$(ls docs/problems/999-*.md docs/problems/*/999-*.md 2>/dev/null)
-  rc=$?
-  set -e
-  [ -z "$result" ]
-  [ "$rc" -ne 0 ]
-}
-
-# ── Pattern C: all-states-all-tickets (next-ID compute, count) ───────────────
-
-@test "dual-tolerant all-tickets glob: flat-only enumerates every ticket regardless of state" {
-  build_flat_layout
-  run bash -c 'ls docs/problems/*.md docs/problems/*/*.md 2>/dev/null'
-  # Single-layout fixture: stdout is contract signal, not $status.
-  [[ "$output" == *"100-foo.open.md"* ]]
-  [[ "$output" == *"101-bar.known-error.md"* ]]
-  [[ "$output" == *"102-baz.verifying.md"* ]]
-  [[ "$output" == *"103-qux.parked.md"* ]]
-  [[ "$output" == *"104-quux.closed.md"* ]]
-}
-
-@test "dual-tolerant all-tickets glob: per-state-only enumerates every ticket regardless of state" {
-  build_per_state_layout
-  run bash -c 'ls docs/problems/*.md docs/problems/*/*.md 2>/dev/null'
-  [[ "$output" == *"open/200-foo2.md"* ]]
-  [[ "$output" == *"known-error/201-bar2.md"* ]]
-  [[ "$output" == *"verifying/202-baz2.md"* ]]
-  [[ "$output" == *"parked/203-qux2.md"* ]]
-  [[ "$output" == *"closed/204-quux2.md"* ]]
-}
-
-@test "dual-tolerant all-tickets glob: mixed fixture enumerates ALL tickets in BOTH layouts" {
-  build_mixed_layout
-  run bash -c 'ls docs/problems/*.md docs/problems/*/*.md 2>/dev/null'
-  [ "$status" -eq 0 ]
-  for ticket in 100-foo.open.md 101-bar.known-error.md 102-baz.verifying.md 103-qux.parked.md 104-quux.closed.md \
-                open/200-foo2.md known-error/201-bar2.md verifying/202-baz2.md parked/203-qux2.md closed/204-quux2.md; do
-    [[ "$output" == *"${ticket}"* ]]
-  done
-}
-
-@test "dual-tolerant all-tickets next-ID compute: highest ID across both layouts" {
-  # Critical for capture-problem next-ID compute (architect finding 2):
-  # the next-ID surface MUST recurse so flat-layout 104 and per-state 204
-  # both contribute to max-ID; missing the per-state half re-allocates
-  # already-taken IDs.
-  build_mixed_layout
-  result=$(ls docs/problems/*.md docs/problems/*/*.md 2>/dev/null \
-    | sed 's/.*\///' \
-    | grep -oE '^[0-9]+' \
-    | sort -n \
-    | tail -1)
-  [ "$result" = "204" ]
-}
-
-# ── Pattern D: pathspec-pair shell-glob equivalence ──────────────────────────
-# git log accepts multiple pathspecs; the dual-tolerant filter is two
-# pathspecs side-by-side. We validate this against the working-tree
-# semantics that git uses (the same shell-glob shape).
-
-@test "dual-tolerant pathspec pair: each pathspec enumerates its layout half independently" {
-  build_mixed_layout
-  flat_count=$(ls docs/problems/*.md 2>/dev/null | wc -l | tr -d ' ')
-  subdir_count=$(ls docs/problems/*/*.md 2>/dev/null | wc -l | tr -d ' ')
-  [ "$flat_count" -ge 5 ]
-  [ "$subdir_count" -ge 5 ]
-}
-
-# ── Pattern E: brace-expansion ID + state-set (report-upstream) ──────────────
-
-@test "dual-tolerant ID + state-set lookup: flat brace expansion + per-state lookup" {
-  build_mixed_layout
-  # Old shape: ls docs/problems/${ID}-*.{open,known-error,verifying,closed}.md
-  # Dual-tolerant: add docs/problems/*/${ID}-*.md as a sibling pathspec.
-  run bash -c 'ls docs/problems/100-*.{open,known-error,verifying,closed}.md docs/problems/*/100-*.md 2>/dev/null'
-  [[ "$output" == *"100-foo.open.md"* ]]
-  run bash -c 'ls docs/problems/200-*.{open,known-error,verifying,closed}.md docs/problems/*/200-*.md 2>/dev/null'
-  [[ "$output" == *"open/200-foo2.md"* ]]
-}
-
-# ── Composition: empty-tree fixture exit-code semantics ──────────────────────
-
-@test "dual-tolerant glob: empty fixture produces empty output and ls exits nonzero" {
-  # Critical for null-safe `2>/dev/null` semantics — `ls` on a
-  # non-matching glob exits nonzero. SKILL.md call sites must rely on
-  # `2>/dev/null` to suppress the stderr noise but still treat empty
-  # stdout as the canonical "no tickets" signal.
-  set +e
-  result=$(ls docs/problems/*.open.md docs/problems/open/*.md 2>/dev/null)
-  rc=$?
-  set -e
-  [ -z "$result" ]
-  [ "$rc" -ne 0 ]
-}

package/scripts/test/effort-tally.bats

@@ -1,170 +0,0 @@
-#!/usr/bin/env bats
-
-# ADR-067 / P248: effort-tally.sh attributes .afk-run-state/iter*.json actuals
-# back to their source ticket (pNNN filename token) and emits the per-ticket
-# tally. Behavioural — exercises the script against fixture iter-JSON trees.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  SCRIPT="$REPO_ROOT/packages/itil/scripts/effort-tally.sh"
-  DIR="$(mktemp -d)"
-  mkdir -p "$DIR/.afk-run-state"
-}
-
-teardown() { rm -rf "$DIR"; }
-
-mk_iter() { # mk_iter <filename> <cost> <duration_ms> <input_tokens>
-  cat > "$DIR/.afk-run-state/$1" <<EOF
-{"total_cost_usd": $2, "duration_ms": $3, "usage": {"input_tokens": $4, "output_tokens": 0, "cache_creation_input_tokens": 0, "cache_read_input_tokens": 0}}
-EOF
-}
-
-@test "attributes a single iter to its ticket via the pNNN filename token" {
-  mk_iter "iter1-p087.json" 12.50 600000 1000000
-  run bash "$SCRIPT" "$DIR/.afk-run-state"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"P087"* ]]
-  [[ "$output" == *"cost_usd=12.50"* ]]
-  [[ "$output" == *"minutes=10.0"* ]]
-}
-
-@test "sums multiple iters for the same ticket" {
-  mk_iter "iter1-p087.json" 10.00 300000 500000
-  mk_iter "iter2-p087.json" 5.00 300000 500000
-  run bash "$SCRIPT" "$DIR/.afk-run-state"
-  [[ "$output" == *"P087 | iters=2 | cost_usd=15.00"* ]]
-}
-
-@test "authoritative cost comes from total_cost_usd; tokens flagged best-effort with ~" {
-  mk_iter "iter1-p100.json" 7.00 60000 2000000
-  run bash "$SCRIPT" "$DIR/.afk-run-state"
-  [[ "$output" == *"cost_usd=7.00"* ]]
-  [[ "$output" == *"tokens=~2.0M"* ]]
-}
-
-@test "tickets are sorted by descending cost" {
-  mk_iter "iter1-p010.json" 3.00 60000 100000
-  mk_iter "iter1-p020.json" 30.00 60000 100000
-  run bash "$SCRIPT" "$DIR/.afk-run-state"
-  # P020 (30.00) must appear before P010 (3.00)
-  [[ "$(echo "$output" | grep -n P020 | cut -d: -f1)" -lt "$(echo "$output" | grep -n P010 | cut -d: -f1)" ]]
-}
-
-@test "handles JSON-array (event-stream) shape, not just a single object" {
-  cat > "$DIR/.afk-run-state/iter1-p050.json" <<'EOF'
-[{"type":"system"},{"type":"result","total_cost_usd":9.00,"duration_ms":120000,"usage":{"input_tokens":3000000,"output_tokens":0,"cache_creation_input_tokens":0,"cache_read_input_tokens":0}}]
-EOF
-  run bash "$SCRIPT" "$DIR/.afk-run-state"
-  [[ "$output" == *"P050"* ]]
-  [[ "$output" == *"cost_usd=9.00"* ]]
-}
-
-@test "files without a pNNN token are ignored" {
-  mk_iter "drain-push.json" 99.00 60000 100000
-  cp "$DIR/.afk-run-state/drain-push.json" "$DIR/.afk-run-state/work-problems-session-totals.json"
-  run bash "$SCRIPT" "$DIR/.afk-run-state"
-  [ -z "$output" ]
-}
-
-@test "files without total_cost_usd are skipped" {
-  echo '{"pid": 1234, "start": 999}' > "$DIR/.afk-run-state/iter1-p077.json"
-  run bash "$SCRIPT" "$DIR/.afk-run-state"
-  [ -z "$output" ]
-}
-
-@test "missing afk dir exits 0 with no output" {
-  run bash "$SCRIPT" "$DIR/nonexistent"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-# --- render / write modes (ADR-067 item 2 + 2a source flag) ---
-
-mk_ticket() { # mk_ticket <filename> <status>   e.g. mk_ticket 087-foo.md Open
-  cat > "$DIR/$1" <<EOF
-# Problem 087: Example
-
-**Status**: $2
-**Priority**: 6 (Medium)
-**Effort**: M
-
-## Description
-
-Body.
-
-## Related
-
-- none
-EOF
-}
-
-@test "--render prints an Effort Tally section with authoritative cost + best-effort tokens" {
-  mk_ticket "087-foo.md" Open
-  mk_iter "iter1-p087.json" 12.50 600000 2000000
-  run bash "$SCRIPT" --render "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"## Effort Tally"* ]]
-  [[ "$output" == *"AUTO-GENERATED"* ]]
-  [[ "$output" == *'$12.50'* ]]
-  [[ "$output" == *"~2.0M"* ]]
-}
-
-@test "--render buckets an Open ticket under RCA" {
-  mk_ticket "087-foo.md" Open
-  mk_iter "iter1-p087.json" 5.00 60000 100000
-  run bash "$SCRIPT" --render "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  [[ "$output" == *"RCA"* ]]
-  [[ "$output" != *"| RFC |"* ]]
-}
-
-@test "--render buckets a Known Error ticket under RFC" {
-  mk_ticket "087-foo.md" "Known Error"
-  mk_iter "iter1-p087.json" 5.00 60000 100000
-  run bash "$SCRIPT" --render "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  [[ "$output" == *"RFC"* ]]
-  [[ "$output" != *"| RCA |"* ]]
-}
-
-@test "--render defaults source to afk-backfill; --source live-iter flips it" {
-  mk_ticket "087-foo.md" Open
-  mk_iter "iter1-p087.json" 5.00 60000 100000
-  run bash "$SCRIPT" --render "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  [[ "$output" == *"source: afk-backfill"* ]]
-  run bash "$SCRIPT" --render --source live-iter "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  [[ "$output" == *"source: live-iter"* ]]
-}
-
-@test "--write injects the section into the ticket and is idempotent" {
-  mk_ticket "087-foo.md" Open
-  mk_iter "iter1-p087.json" 5.00 60000 100000
-  run bash "$SCRIPT" --write "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  [ "$status" -eq 0 ]
-  grep -q "## Effort Tally" "$DIR/087-foo.md"
-  # original body preserved
-  grep -q "^## Description" "$DIR/087-foo.md"
-  # idempotent: second run produces no diff
-  cp "$DIR/087-foo.md" "$DIR/087-foo.before"
-  run bash "$SCRIPT" --write "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  run diff "$DIR/087-foo.before" "$DIR/087-foo.md"
-  [ "$status" -eq 0 ]
-  # exactly one section (no duplication)
-  [ "$(grep -c '^## Effort Tally' "$DIR/087-foo.md")" -eq 1 ]
-}
-
-@test "--write lazy-empties: a ticket with zero iters gets no section" {
-  mk_ticket "099-bar.md" Open
-  run bash "$SCRIPT" --write "$DIR/099-bar.md" "$DIR/.afk-run-state"
-  [ "$status" -eq 0 ]
-  ! grep -q "## Effort Tally" "$DIR/099-bar.md"
-}
-
-@test "--write removes a stale section when iters disappear (lazy-empty on re-run)" {
-  mk_ticket "087-foo.md" Open
-  mk_iter "iter1-p087.json" 5.00 60000 100000
-  bash "$SCRIPT" --write "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  grep -q "## Effort Tally" "$DIR/087-foo.md"
-  rm "$DIR/.afk-run-state/iter1-p087.json"
-  run bash "$SCRIPT" --write "$DIR/087-foo.md" "$DIR/.afk-run-state"
-  [ "$status" -eq 0 ]
-  ! grep -q "## Effort Tally" "$DIR/087-foo.md"
-}