@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -1,4 +1,13 @@
1
- import { useState, useCallback, useEffect, useMemo, useRef, createContext, useContext } from 'react';
1
+ import {
2
+ useState,
3
+ useCallback,
4
+ useEffect,
5
+ useMemo,
6
+ useRef,
7
+ createContext,
8
+ useContext,
9
+ type ReactNode,
10
+ } from 'react';
2
11
  import {
3
12
  ChevronRight,
4
13
  FilePlus,
@@ -15,30 +24,71 @@ import {
15
24
  Pin,
16
25
  PinOff,
17
26
  Users,
27
+ Undo2,
18
28
  } from 'lucide-react';
19
- import type { FileTreeEntry, PullRequestSummary } from '@bevel-software/platform-shared';
29
+ import type { FileTreeEntry } from '@bevel-software/platform-shared';
20
30
  import {
31
+ isProtectedBranch,
21
32
  validateFilename,
22
33
  KNOWLEDGE_BASE_DIR,
23
34
  DATA_DIR,
24
35
  PLUGINS_DIR,
36
+ SKILLS_DIR,
25
37
  AGENTS_DIR,
26
38
  PIPELINES_DIR,
27
39
  } from '@bevel-software/platform-shared';
28
- import { useWorkspace, type PendingEntry } from '../state/workspace.context';
29
- import { mergePendingIntoTree, pathExistsInTree, findKbRoot, KB_ROOT_DIRS } from '../utils/fileTree';
40
+ import {
41
+ KNOWLEDGE_UPLOAD_TARGET,
42
+ useWorkspace,
43
+ type UploadInput,
44
+ type UploadTarget,
45
+ } from '../state/workspace.context';
46
+ import { rootAnchoredPath } from '../utils/pasteLink';
47
+ import {
48
+ checkoutRoot,
49
+ KB_ROOT_DIRS,
50
+ pathExistsInTree,
51
+ subtreeHasVisibleEntries,
52
+ subtreeWithheld,
53
+ treeHasVisibleEntries,
54
+ } from '../utils/fileTree';
55
+ import { uploadErrorNextStep } from '../utils/uploadError';
56
+ import { useMergedWorkspaceTree } from '../hooks/useMergedWorkspaceTree';
30
57
  import { ChangeRequestDialog } from '../../change-requests/components/ChangeRequestDialog';
31
- import { PR_STALE_EVENT } from '../../../core/events';
58
+ import { PR_STALE_EVENT, SUGGESTIONS_RETRACTED_EVENT } from '../../../core/events';
59
+ import {
60
+ listChangeRequestsUnderFolder,
61
+ removeFolderFromChangeRequests,
62
+ } from '../../change-requests/services/change-requests.api';
63
+ import { cancelPullRequest } from '../../pr/services/pr-cancel.api';
32
64
  import { snapshotEntries } from '../utils/readDroppedEntries';
33
- import { useFileNav } from '../routing/kb-routes';
65
+ import { useSearchParams } from 'react-router-dom';
66
+ import { CR_FILE_PARAM, CR_PARAM, useFileNav } from '../routing/kb-routes';
67
+ import { rawFileUrl } from '../services/workspace.api';
34
68
  import { downloadViaBlob } from './renderers/downloadFile';
35
69
  import { cn } from '../../../lib/utils';
36
- import { MenuPanel, MenuItem, TextField, IconButton } from '../../../shared/components';
70
+ import { Banner, MenuPanel, MenuItem, TextField, IconButton } from '../../../shared/components';
37
71
  import { useDismissableMenu, usePointerMenuPosition } from '../../../shared/components';
38
72
  import { useOpenChangeRequests } from '../hooks/useOpenChangeRequests';
39
- import { PullRequestsForMe } from '../../git/components/PullRequestsForMe';
73
+ import { AdminContext } from '../../admin/state/admin.context';
40
74
  import { ManageAccessDialog } from '../../access/components/ManageAccessDialog';
75
+ import { offersManageAccess } from '../../access/manage-access-affordance';
41
76
  import { useAppRegistry } from '../../../core/registry';
77
+ import { fetchFileAccess, fetchProspectiveAccess } from '../../access/api';
78
+ import {
79
+ TreeActionConfirmDialog,
80
+ type DeleteMode,
81
+ type FolderProposals,
82
+ type MoveAccessChange,
83
+ type TreeConfirmRequest,
84
+ } from './TreeActionConfirm';
85
+ import {
86
+ ACCESS_LOOKUP_TIMEOUT_MS,
87
+ accessChangeOf,
88
+ moveWarnings,
89
+ platformFileDragRefusal,
90
+ platformFileMoveRefusal,
91
+ } from '../utils/treeConfirm';
42
92
 
43
93
  /**
44
94
  * The tree row — the prototype's `.trow` (proto:684-693), and token for token
@@ -60,9 +110,10 @@ const ROW_TONE = (current: boolean) =>
60
110
  const indentFor = (depth: number) => 10 + depth * 13;
61
111
 
62
112
  /**
63
- * The caret's slot — 13px wide, and rendered EMPTY for a file and for a
64
- * childless folder. It is what keeps a file's name in line with its siblings'
65
- * once the icons are gone: the indent is the tree, so it has to survive them
113
+ * The caret's slot — 13px wide, and rendered EMPTY for a file. Every folder
114
+ * shows the caret, an empty one included: without it a folder reads as a file.
115
+ * The slot is what keeps a file's name in line with its siblings' once the
116
+ * icons are gone: the indent is the tree, so it has to survive them
66
117
  * (proto:3571-3572).
67
118
  */
68
119
  function CaretSlot({ open, show }: { open?: boolean; show: boolean }) {
@@ -78,6 +129,37 @@ function CaretSlot({ open, show }: { open?: boolean; show: boolean }) {
78
129
  );
79
130
  }
80
131
 
132
+ /** How many trailing characters of a file name always stay on screen. */
133
+ const FILE_NAME_TAIL = 8;
134
+
135
+ /**
136
+ * A file's name, truncated in the MIDDLE when it does not fit: the lead is
137
+ * shortened with an ellipsis and the last `FILE_NAME_TAIL` characters stay —
138
+ * for an ordinary name that is the extension, the part that says what the
139
+ * file is. A name that fits reads exactly as before, because the two halves
140
+ * sit flush against each other.
141
+ *
142
+ * The split halves are a picture, so they are hidden from assistive tech; the
143
+ * whole name is carried once, unsplit, in a visually hidden span. A folder has
144
+ * no extension to protect and keeps the plain end truncation.
145
+ */
146
+ function FileName({ name }: { name: string }) {
147
+ // By code point, so the split never lands inside a surrogate pair.
148
+ const chars = Array.from(name);
149
+ if (chars.length <= FILE_NAME_TAIL) return <span className="truncate">{name}</span>;
150
+ return (
151
+ <span className="flex min-w-0" data-file-name>
152
+ <span className="sr-only">{name}</span>
153
+ <span aria-hidden className="truncate" data-name-lead>
154
+ {chars.slice(0, -FILE_NAME_TAIL).join('')}
155
+ </span>
156
+ <span aria-hidden className="flex-none whitespace-pre" data-name-tail>
157
+ {chars.slice(-FILE_NAME_TAIL).join('')}
158
+ </span>
159
+ </span>
160
+ );
161
+ }
162
+
81
163
  // ── Pinned folders (client-side, localStorage) ──
82
164
 
83
165
  const PINNED_STORAGE_KEY = 'bevel-pinned-folders';
@@ -94,16 +176,24 @@ function readPinnedPaths(): string[] {
94
176
  }
95
177
 
96
178
  interface PinnedController {
179
+ /**
180
+ * Whether this tree offers pinning at all. Only the Knowledge explorer has
181
+ * a Company Context section to pin INTO; a tree without one hides the item
182
+ * rather than offering a verb that lands nowhere.
183
+ */
184
+ available: boolean;
97
185
  isPinned: (path: string) => boolean;
98
186
  togglePin: (path: string) => void;
99
187
  }
100
188
 
101
189
  // Default no-op so a ContextMenu rendered outside the provider (e.g. in a unit
102
190
  // test) never throws — the real controller is supplied by FileExplorer.
103
- const PinnedContext = createContext<PinnedController>({
191
+ const NO_PINNING: PinnedController = {
192
+ available: false,
104
193
  isPinned: () => false,
105
194
  togglePin: () => {},
106
- });
195
+ };
196
+ const PinnedContext = createContext<PinnedController>(NO_PINNING);
107
197
  const usePinned = () => useContext(PinnedContext);
108
198
 
109
199
  // Lets the deep right-click menu open the Manage access sheet without prop
@@ -128,13 +218,107 @@ interface SuggestionsController {
128
218
  crFor(path: string): number | null;
129
219
  /** Open the shared change-request dialog on the request this path belongs to. */
130
220
  open(path: string, crNumber: number): void;
221
+ /**
222
+ * The caller AUTHORED this request, so they may take it back.
223
+ *
224
+ * Every suggestion row is the caller's own today — the map they are
225
+ * synthesized from is `/mine`. The menu asks anyway, because the answer is
226
+ * what the offer means: an owner looking at someone else's proposal must
227
+ * never be shown a Withdraw (their "no" is Decline, in the dialog), and
228
+ * this predicate is already right for the day those rows appear here.
229
+ */
230
+ mine(crNumber: number): boolean;
231
+ /**
232
+ * Every file the request carries — a multi-file drop is ONE request, and
233
+ * withdrawing it withdraws all of them, which the confirmation says out loud.
234
+ * Empty when the request has not arrived in the shared list yet.
235
+ */
236
+ filesOf(path: string, crNumber: number): string[];
237
+ /**
238
+ * Cancel the request down the author-cancel path — the same call the file
239
+ * page's change box makes — and tell the app its request list changed, so
240
+ * the rows go without a reload.
241
+ */
242
+ withdraw(crNumber: number): Promise<void>;
131
243
  }
132
244
  const SuggestionsContext = createContext<SuggestionsController>({
133
245
  crFor: () => null,
134
246
  open: () => {},
247
+ mine: () => false,
248
+ filesOf: () => [],
249
+ withdraw: async () => {},
135
250
  });
136
251
  const useSuggestions = () => useContext(SuggestionsContext);
137
252
 
253
+ /**
254
+ * Which row is current, and where a row's click goes.
255
+ *
256
+ * Context, for the same reason as the three above — and because the SAME rows
257
+ * serve two navs. The Knowledge explorer opens a file in the pane workspace
258
+ * on the checked-out branch; the Library's Skills tree opens a skill on its
259
+ * own page, on the default branch, whatever is checked out. The rows know
260
+ * neither: they report the path they hold and read which one is active.
261
+ */
262
+ export interface TreeNav {
263
+ /** The workspace-relative path the surface is showing — lights its row, reveals its folders. */
264
+ activePath: string | null;
265
+ open(path: string): void;
266
+ /**
267
+ * Extra items for a row's context menu, decided by the SURFACE for the
268
+ * entry at hand — injected, so the one tree serves every nav without
269
+ * growing a verb per caller. Rendered after the tree's own create items,
270
+ * in the order given; absent or empty, the menu is the tree's alone.
271
+ * (The Library's Plugins tree adds "New plugin" on folders this way.)
272
+ */
273
+ menuItems?(entry: FileTreeEntry): TreeMenuItem[];
274
+ }
275
+
276
+ /** One injected context-menu item — see `TreeNav.menuItems`. */
277
+ export interface TreeMenuItem {
278
+ /** Stable within one menu; keys the rendered item. */
279
+ id: string;
280
+ label: string;
281
+ icon?: ReactNode;
282
+ onSelect(): void;
283
+ }
284
+ const TreeNavContext = createContext<TreeNav>({ activePath: null, open: () => {} });
285
+
286
+ /**
287
+ * Which tree this is, for the upload banners — see `UploadTarget`. Every drop
288
+ * inside a `TreeChrome` carries it into `dispatchUpload`, and the
289
+ * `UploadNotices` inside the same chrome renders only the banners that come
290
+ * back with it. One page can hold two of these trees (the Library sidebar
291
+ * holds `Skills/` and `Plugins/`); before they were told apart, one drop
292
+ * painted its notice in both.
293
+ */
294
+ const UploadTargetContext = createContext<UploadTarget>(KNOWLEDGE_UPLOAD_TARGET);
295
+
296
+ /** The tree the surrounding `TreeChrome` is, for a drop or a banner. */
297
+ const useUploadTarget = () => useContext(UploadTargetContext);
298
+
299
+ /**
300
+ * Ask before a delete or a move — see `TreeActionConfirm`. `TreeChrome` holds
301
+ * the one open request and renders its dialog; a row outside any chrome has
302
+ * no one to ask, so the default runs the operation as it always did.
303
+ */
304
+ const TreeConfirmContext = createContext<(request: TreeConfirmRequest) => void>((request) => {
305
+ void request.run();
306
+ });
307
+ const useTreeConfirm = () => useContext(TreeConfirmContext);
308
+
309
+ /**
310
+ * The row button for a path, found in the DOM. A move is dropped on ANOTHER
311
+ * row, so the dragged row's ref is not in hand where the drop lands; the path
312
+ * is. (A pinned folder renders twice — the first match is the one to return to.)
313
+ */
314
+ function rowForPath(path: string): HTMLElement | null {
315
+ for (const el of document.querySelectorAll<HTMLElement>('[data-tree-path]')) {
316
+ if (el.dataset.treePath === path) return el;
317
+ }
318
+ return null;
319
+ }
320
+ const useTreeNav = () => useContext(TreeNavContext);
321
+
138
322
  /** Depth-first lookup of a tree entry by its exact relativePath. */
139
323
  function findEntryByPath(node: FileTreeEntry, path: string): FileTreeEntry | null {
140
324
  if (node.relativePath === path) return node;
@@ -146,6 +330,63 @@ function findEntryByPath(node: FileTreeEntry, path: string): FileTreeEntry | nul
146
330
  return null;
147
331
  }
148
332
 
333
+ // ── Download permission ──
334
+
335
+ /**
336
+ * The tooltip on a Download the caller may not use, and the reason a late
337
+ * refusal gives. One string, because the menu and the 403 notice are two
338
+ * views of the SAME verdict and must not drift.
339
+ */
340
+ export const DOWNLOAD_DENIED_MESSAGE = "You don't have download permission for this item";
341
+
342
+ /**
343
+ * The entry's `download:` verdict, asked ONCE — the menu mounts when it
344
+ * opens and unmounts when it closes, so the request is per menu open, never
345
+ * per tree render (one request per row was the alternative, and it is why
346
+ * this lives here and not on the row).
347
+ *
348
+ * `null` means "not known": the lookup is in flight, there is nothing to ask
349
+ * about, or it failed. The item stays ENABLED on null — a flash of disabled
350
+ * on every menu open would be worse than the 403 this preflight exists to
351
+ * avoid, and the backend's own gate is authoritative either way.
352
+ *
353
+ * The path goes to the server workspace-relative, exactly as the download
354
+ * URLs send it: the access route strips `<kbDirName>/` itself, with the same
355
+ * strip the download gate applies, so the preflight asks the question the
356
+ * gate will answer. A path the route refuses outright (the tree root's `.`)
357
+ * throws and leaves the verdict unknown, which is the enabled-as-today case.
358
+ */
359
+ function useDownloadVerdict(entry: FileTreeEntry | null): boolean | null {
360
+ const { workspaceId } = useWorkspace();
361
+ const path = entry?.relativePath ?? null;
362
+ const kind = entry?.type === 'directory' ? 'folder' : 'file';
363
+ // The verdict is stored WITH the question it answers, and read back only
364
+ // while that question still stands. Keying it — rather than clearing it
365
+ // when a new lookup starts — is what makes an answer about a PREVIOUS
366
+ // entry unreadable as this one's: a stale `false` would disable a Download
367
+ // the caller does have, and would stay disabled for good if the new lookup
368
+ // failed, because the failure path deliberately leaves the verdict alone.
369
+ // Keying also costs no extra render, so there is no flash of a wrong state.
370
+ const key = workspaceId && path !== null ? `${workspaceId}\u0000${path}\u0000${kind}` : null;
371
+ const [answered, setAnswered] = useState<{ key: string; verdict: boolean } | null>(null);
372
+ useEffect(() => {
373
+ if (!workspaceId || path === null || key === null) return;
374
+ let cancelled = false;
375
+ fetchFileAccess(workspaceId, path, kind)
376
+ .then((res) => {
377
+ if (!cancelled) setAnswered({ key, verdict: res.canDownload });
378
+ })
379
+ .catch(() => {
380
+ // Default-allow, as `useFileAccess` does: a transient lookup failure
381
+ // must not take an action away from someone who has it.
382
+ });
383
+ return () => {
384
+ cancelled = true;
385
+ };
386
+ }, [key, workspaceId, path, kind]);
387
+ return answered !== null && answered.key === key ? answered.verdict : null;
388
+ }
389
+
149
390
  // ── Context Menu ──
150
391
 
151
392
  function ContextMenu({
@@ -157,26 +398,60 @@ function ContextMenu({
157
398
  onCreateFile,
158
399
  onCreateFolder,
159
400
  onRename,
401
+ renameRefusal = null,
160
402
  onDownload,
403
+ onWithdraw,
161
404
  returnFocusTo,
405
+ deletable = true,
406
+ extraItems = [],
407
+ proposed = false,
162
408
  }: {
163
409
  x: number;
164
410
  y: number;
165
411
  entry: FileTreeEntry;
166
412
  isRoot: boolean;
413
+ /**
414
+ * The entry exists only on a change request's branch. Nothing that acts on
415
+ * THIS branch's copy applies (there is none), so only the path and Manage
416
+ * access — which follows the file to the proposal — are offered.
417
+ */
418
+ proposed?: boolean;
419
+ /** False for a folder the platform owns (a reserved root): no Delete. */
420
+ deletable?: boolean;
167
421
  onClose: () => void;
168
422
  onCreateFile?: () => void;
169
423
  onCreateFolder?: () => void;
170
424
  onRename?: () => void;
425
+ /**
426
+ * Why Rename is not on offer for this row — a platform file stays in its
427
+ * folder, and a rename is a move. The item is still drawn and still
428
+ * reachable: an affordance that vanishes teaches nobody why.
429
+ */
430
+ renameRefusal?: string | null;
171
431
  onDownload?: () => void;
432
+ /**
433
+ * Take this suggestion back. Supplied ONLY by a proposed row whose change
434
+ * request the caller authored — its absence is what keeps Withdraw off an
435
+ * owner's view of someone else's proposal, the same way `onRename`'s
436
+ * absence keeps Rename off a row that cannot be renamed.
437
+ */
438
+ onWithdraw?: () => void;
439
+ /** The surface's own items for this entry — see `TreeNav.menuItems`. */
440
+ extraItems?: TreeMenuItem[];
172
441
  /** The row this menu was opened from — Escape hands focus back to it. */
173
442
  returnFocusTo?: React.RefObject<HTMLElement | null>;
174
443
  }) {
175
- const { deleteEntry, unzipHere } = useWorkspace();
176
- const { isPinned, togglePin } = usePinned();
444
+ const { deleteEntry, unzipHere, kbDirName, fileTree } = useWorkspace();
445
+ const suggestions = useSuggestions();
446
+ const { isPinned, togglePin, available: pinning } = usePinned();
177
447
  const openManageAccess = useManageAccess();
448
+ const confirm = useTreeConfirm();
178
449
  const pinned = isPinned(entry.relativePath);
179
450
  const [unzipping, setUnzipping] = useState(false);
451
+ // Asked only where a Download is on offer — a proposed row or an absent
452
+ // folder has none, and must not spend a request finding that out.
453
+ const canDownload = useDownloadVerdict(onDownload ? entry : null);
454
+ const downloadDenied = canDownload === false;
180
455
  // Outside-click, Escape, and focus return — none of which `MenuPanel`
181
456
  // provides (it is presentation only, by design).
182
457
  const ref = useDismissableMenu<HTMLDivElement>({ open: true, onClose, returnFocusTo });
@@ -190,34 +465,97 @@ function ContextMenu({
190
465
  // Only files whose name ends with `.zip` (case-insensitive) get the
191
466
  // extraction affordance — matches the OS shell-extension behavior users
192
467
  // already know from Windows Explorer / macOS Finder.
193
- const isZip = entry.type === 'file' && /\.zip$/i.test(entry.name);
468
+ const isZip = !proposed && entry.type === 'file' && /\.zip$/i.test(entry.name);
194
469
 
195
470
  // The one prototype context-menu item the platform has never had
196
- // (proto:3948). The page-level `⋯ → Copy path` does not cover it: that only
471
+ // (proto:3948). The page-level Share `⌄ → Copy path` does not cover it: that only
197
472
  // ever reaches the file you have open, never a folder row or an unopened
198
473
  // one. A clipboard write can be refused outright (a non-secure origin), and
199
474
  // a silent no-op is the worst possible answer to "copy this" — so a refusal
200
475
  // surfaces the same way every other failure in this tree does.
476
+ // The ROOT-ANCHORED form: pasted into a Markdown link it resolves from any
477
+ // folder, where the bare `knowledge-base/…` resolved against the linking
478
+ // file's own folder and landed on File not found.
201
479
  const handleCopyPath = async () => {
480
+ const copied = rootAnchoredPath(entry.relativePath);
202
481
  try {
203
- await navigator.clipboard.writeText(entry.relativePath);
482
+ await navigator.clipboard.writeText(copied);
204
483
  onClose();
205
484
  } catch (err) {
206
485
  console.error('Failed to copy path:', err);
207
486
  onClose();
208
- alert(`Couldn't copy the path to the clipboard.\n\n${entry.relativePath}`);
487
+ alert(`Couldn't copy the path to the clipboard.\n\n${copied}`);
209
488
  }
210
489
  };
211
490
 
212
- const handleDelete = async () => {
491
+ // Delete asks first; Confirm runs the delete exactly as the menu used to.
492
+ // A KB folder can also hold proposed files — the dialog then offers to take
493
+ // them out of their change requests as well (`runWithProposals`).
494
+ const repoFolder =
495
+ entry.type === 'directory' && kbDirName && entry.relativePath.startsWith(`${kbDirName}/`)
496
+ ? entry.relativePath.slice(kbDirName.length + 1)
497
+ : null;
498
+ const handleDelete = () => {
213
499
  onClose();
214
- try {
215
- await deleteEntry(entry.relativePath);
216
- } catch (err) {
217
- console.error('Failed to delete entry:', err);
218
- const msg = err instanceof Error ? err.message : String(err);
219
- alert(`Failed to delete ${entry.relativePath}:\n${msg}`);
220
- }
500
+ const deleteOnBranch = async (): Promise<boolean> => {
501
+ // A folder only proposed files put in the tree is not on this branch:
502
+ // nothing to delete here, and asking the server would only queue a
503
+ // commit for a path that does not exist.
504
+ if (fileTree && !pathExistsInTree(fileTree, entry.relativePath)) return true;
505
+ try {
506
+ return (await deleteEntry(entry.relativePath)) !== false;
507
+ } catch (err) {
508
+ console.error('Failed to delete entry:', err);
509
+ const msg = err instanceof Error ? err.message : String(err);
510
+ alert(`Failed to delete ${entry.relativePath}:\n${msg}`);
511
+ return false;
512
+ }
513
+ };
514
+ confirm({
515
+ kind: 'delete',
516
+ entry,
517
+ returnFocusTo: () => returnFocusTo?.current ?? null,
518
+ // The folder it was in — the row itself is gone once the delete lands.
519
+ focusAfterRun: () => rowForPath(entry.relativePath.split('/').slice(0, -1).join('/')),
520
+ isProposed: (path) => suggestions.crFor(path) !== null,
521
+ // Entries under THIS folder the caller's read rules kept out: the
522
+ // delete then takes files the tree cannot count, and the question says
523
+ // so instead of naming a number that is too small.
524
+ partial: (entry.withheld ?? 0) > 0,
525
+ run: async () => {
526
+ await deleteOnBranch();
527
+ },
528
+ ...(repoFolder !== null && {
529
+ runWithProposals: async () => {
530
+ // The branch first: a delete that failed (or was called off over
531
+ // unsaved tabs) must not have already emptied the proposals.
532
+ if (!(await deleteOnBranch())) return;
533
+ let leftovers: string[];
534
+ try {
535
+ // What the removal could not take out, said rather than left to
536
+ // reappear unexplained in the tree once the refetch lands.
537
+ leftovers = (await removeFolderFromChangeRequests(repoFolder)).flatMap((r) => [
538
+ ...(r.stillProposed.length > 0
539
+ ? [`#${r.number} still proposes ${r.stillProposed.join(', ')} — added while the folder was being deleted.`]
540
+ : []),
541
+ ...(r.keptForSaves ? [`#${r.number} stays open: a save to it was still landing.`] : []),
542
+ ]);
543
+ } catch (err) {
544
+ console.error('Failed to remove proposed changes:', err);
545
+ const msg = err instanceof Error ? err.message : String(err);
546
+ alert(`Deleted ${entry.name}, but couldn't remove its proposed changes:\n${msg}`);
547
+ window.dispatchEvent(new Event(PR_STALE_EVENT));
548
+ return;
549
+ }
550
+ // The rows and dots go now; the refetch confirms it.
551
+ window.dispatchEvent(new CustomEvent(SUGGESTIONS_RETRACTED_EVENT, { detail: { folder: repoFolder } }));
552
+ window.dispatchEvent(new Event(PR_STALE_EVENT));
553
+ if (leftovers.length > 0) {
554
+ alert(`Deleted ${entry.name} and its proposed changes, except:\n${leftovers.join('\n')}`);
555
+ }
556
+ },
557
+ }),
558
+ });
221
559
  };
222
560
 
223
561
  const handleUnzip = async () => {
@@ -270,6 +608,13 @@ function ContextMenu({
270
608
  <span className="flex items-center gap-2"><FolderPlus size={14} />New folder</span>
271
609
  </MenuItem>
272
610
  )}
611
+ {/* The surface's own verbs for this entry, after the tree's create
612
+ items — a "make a thing here" reads with the other two. */}
613
+ {extraItems.map((item) => (
614
+ <MenuItem key={item.id} role="menuitem" onClick={() => { item.onSelect(); onClose(); }}>
615
+ <span className="flex items-center gap-2">{item.icon}{item.label}</span>
616
+ </MenuItem>
617
+ ))}
273
618
  {isZip && (
274
619
  <MenuItem role="menuitem" onClick={handleUnzip} disabled={unzipping}>
275
620
  <span className="flex items-center gap-2">
@@ -279,17 +624,33 @@ function ContextMenu({
279
624
  </MenuItem>
280
625
  )}
281
626
  {onDownload && (
282
- <MenuItem role="menuitem" onClick={() => { onDownload(); onClose(); }}>
627
+ <MenuItem
628
+ role="menuitem"
629
+ // `aria-disabled`, not `disabled`: the item keeps its tooltip and
630
+ // its place in the tab order, so the reason is reachable by mouse
631
+ // AND by keyboard. Activation is refused here instead — which is
632
+ // what stops Enter and Space on the focused item, not just a click.
633
+ aria-disabled={downloadDenied || undefined}
634
+ title={downloadDenied ? DOWNLOAD_DENIED_MESSAGE : undefined}
635
+ onClick={() => {
636
+ if (downloadDenied) return;
637
+ onDownload();
638
+ onClose();
639
+ }}
640
+ >
283
641
  <span className="flex items-center gap-2">
284
642
  <Download size={14} />
285
643
  {entry.type === 'directory' ? 'Download as zip' : 'Download'}
286
644
  </span>
287
645
  </MenuItem>
288
646
  )}
289
- <MenuItem role="menuitem" onClick={handleCopyPath}>
290
- <span className="flex items-center gap-2"><Link2 size={14} />Copy path</span>
291
- </MenuItem>
647
+ {/* The workspace root has no path worth linking: it would copy `/.`. */}
292
648
  {!isRoot && (
649
+ <MenuItem role="menuitem" onClick={handleCopyPath}>
650
+ <span className="flex items-center gap-2"><Link2 size={14} />Copy path</span>
651
+ </MenuItem>
652
+ )}
653
+ {offersManageAccess(entry) && (
293
654
  <>
294
655
  <div className="my-1 border-t border-line" />
295
656
  <MenuItem role="menuitem" onClick={() => { openManageAccess(entry); onClose(); }}>
@@ -297,7 +658,7 @@ function ContextMenu({
297
658
  </MenuItem>
298
659
  </>
299
660
  )}
300
- {entry.type === 'directory' && !isRoot && (
661
+ {entry.type === 'directory' && !isRoot && pinning && (
301
662
  <MenuItem role="menuitem" onClick={() => { togglePin(entry.relativePath); onClose(); }}>
302
663
  <span className="flex items-center gap-2">
303
664
  {pinned ? <PinOff size={14} /> : <Pin size={14} />}
@@ -306,16 +667,36 @@ function ContextMenu({
306
667
  </MenuItem>
307
668
  )}
308
669
  {!isRoot && onRename && (
309
- <MenuItem role="menuitem" onClick={() => { onRename(); onClose(); }}>
670
+ <MenuItem
671
+ role="menuitem"
672
+ // Same shape as a denied Download: `aria-disabled`, so the reason
673
+ // stays reachable by mouse AND keyboard, with activation refused
674
+ // here rather than by taking the item out of the tab order.
675
+ aria-disabled={renameRefusal ? true : undefined}
676
+ title={renameRefusal ?? undefined}
677
+ onClick={() => {
678
+ if (renameRefusal) return;
679
+ onRename();
680
+ onClose();
681
+ }}
682
+ >
310
683
  <span className="flex items-center gap-2"><Pencil size={14} />Rename</span>
311
684
  </MenuItem>
312
685
  )}
313
- {!isRoot && (
686
+ {!isRoot && deletable && (
314
687
  // Danger tone comes from the primitive, not from a hand-written red.
315
688
  <MenuItem role="menuitem" tone="danger" onClick={handleDelete}>
316
689
  <span className="flex items-center gap-2"><Trash2 size={14} />Delete</span>
317
690
  </MenuItem>
318
691
  )}
692
+ {onWithdraw && (
693
+ // Last, in danger tone, exactly where Delete sits on a row that has
694
+ // one: it is the same shape of act — what the row points at stops
695
+ // existing — and a proposed row never has a Delete to collide with.
696
+ <MenuItem role="menuitem" tone="danger" onClick={() => { onWithdraw(); onClose(); }}>
697
+ <span className="flex items-center gap-2"><Undo2 size={14} />Withdraw suggestion</span>
698
+ </MenuItem>
699
+ )}
319
700
  </MenuPanel>
320
701
  </div>
321
702
  );
@@ -367,6 +748,16 @@ function InlineInput({
367
748
 
368
749
  // ── Rename Input ──
369
750
 
751
+ /**
752
+ * `onSubmit` answers with the refusal to show, or null once the rename
753
+ * landed. A refused rename KEEPS THE BOX OPEN with the sentence under it —
754
+ * the name the user typed is still there to fix, which is the whole point of
755
+ * being told "A file named Notes.md already exists in Sales." The box used to
756
+ * close first and report through `alert()`, which was the only way to avoid
757
+ * the create flow's popup loop (the alert blurs the still-mounted input,
758
+ * whose onBlur re-submits); an inline sentence steals no focus, so the loop
759
+ * cannot start.
760
+ */
370
761
  function RenameInput({
371
762
  currentName,
372
763
  isFile,
@@ -375,17 +766,34 @@ function RenameInput({
375
766
  }: {
376
767
  currentName: string;
377
768
  isFile: boolean;
378
- onSubmit: (value: string) => void;
769
+ onSubmit: (value: string) => Promise<string | null>;
379
770
  onCancel: () => void;
380
771
  }) {
381
772
  const [value, setValue] = useState(currentName);
773
+ // The server's answer to the last name submitted. Cleared on every edit, so
774
+ // a name that has been changed since is submitted again rather than read as
775
+ // still-refused.
776
+ const [refusal, setRefusal] = useState<string | null>(null);
777
+ const [submitting, setSubmitting] = useState(false);
382
778
  const trimmed = value.trim();
383
- const error = trimmed.length === 0 ? null : validateFilename(trimmed);
384
- const valid = trimmed.length > 0 && error === null;
779
+ const nameError = trimmed.length === 0 ? null : validateFilename(trimmed);
780
+ const error = nameError ?? refusal;
781
+ const valid = trimmed.length > 0 && nameError === null;
385
782
 
386
783
  const submit = () => {
387
- if (valid && trimmed !== currentName) onSubmit(trimmed);
388
- else onCancel();
784
+ if (submitting) return;
785
+ if (!valid || trimmed === currentName) { onCancel(); return; }
786
+ setSubmitting(true);
787
+ void onSubmit(trimmed)
788
+ // `onSubmit` answers rather than throws; a rejection anyway must still
789
+ // free the box, or it would be stuck refusing to submit again.
790
+ .catch((err: unknown) => (err instanceof Error ? err.message : String(err)))
791
+ .then((answer) => {
792
+ setSubmitting(false);
793
+ // On success the row unmounts this input; only a refusal has anywhere
794
+ // to land.
795
+ setRefusal(answer);
796
+ });
389
797
  };
390
798
 
391
799
  return (
@@ -396,12 +804,24 @@ function RenameInput({
396
804
  value={value}
397
805
  onClick={(e) => e.stopPropagation()}
398
806
  onMouseDown={(e) => e.stopPropagation()}
399
- onChange={(e) => setValue(e.target.value)}
807
+ // Frozen while the rename is in flight: an edit made in that window
808
+ // would be discarded by the row unmounting on success, and a refusal
809
+ // coming back would land under a name it was never about. `readOnly`
810
+ // rather than `disabled` so the box keeps focus and the caret.
811
+ readOnly={submitting}
812
+ onChange={(e) => {
813
+ if (submitting) return;
814
+ setValue(e.target.value);
815
+ setRefusal(null);
816
+ }}
400
817
  onKeyDown={(e) => {
401
818
  if (e.key === 'Enter') submit();
402
819
  if (e.key === 'Escape') onCancel();
403
820
  }}
404
- onBlur={submit}
821
+ // A name the server has already refused is not sent again on the way
822
+ // out: clicking away from a refusal closes the box, it does not retry
823
+ // a rename that cannot land.
824
+ onBlur={() => { if (refusal !== null) onCancel(); else submit(); }}
405
825
  onFocus={(e) => {
406
826
  if (isFile) {
407
827
  // Select name without extension for files
@@ -415,20 +835,73 @@ function RenameInput({
415
835
  title={error ?? undefined}
416
836
  aria-invalid={error ? true : undefined}
417
837
  />
418
- {error && <div className="mt-0.5 px-1 text-meta text-danger">{error}</div>}
838
+ {error && (
839
+ <div role="alert" data-testid="rename-error" className="mt-0.5 px-1 text-meta text-danger">
840
+ {error}
841
+ </div>
842
+ )}
419
843
  </div>
420
844
  );
421
845
  }
422
846
 
847
+ // ── Row Notice ──
848
+
849
+ /**
850
+ * One row's own bad news — a refused download, a refused drop — drawn under
851
+ * the row at the row's indent, with a Dismiss. Never an `alert()`: a modal
852
+ * popup stops the whole app to say something the tree can say in place, and
853
+ * (the create flow learned this the hard way) it steals focus from whatever
854
+ * input is still mounted.
855
+ */
856
+ function RowNotice({
857
+ message,
858
+ testId,
859
+ dismissLabel,
860
+ paddingLeft,
861
+ onDismiss,
862
+ }: {
863
+ message: string;
864
+ testId: string;
865
+ dismissLabel: string;
866
+ paddingLeft: number;
867
+ onDismiss: () => void;
868
+ }) {
869
+ return (
870
+ <Banner
871
+ role="alert"
872
+ tone="danger"
873
+ data-testid={testId}
874
+ className="items-center gap-1 rounded-none px-2 py-1 text-xs"
875
+ style={{ paddingLeft }}
876
+ >
877
+ <span className="flex items-start gap-1">
878
+ <span className="flex-1">{message}</span>
879
+ <IconButton size={18} tone="danger" title="Dismiss" aria-label={dismissLabel} onClick={onDismiss}>
880
+ <X size={12} />
881
+ </IconButton>
882
+ </span>
883
+ </Banner>
884
+ );
885
+ }
886
+
423
887
  // ── Tree Node ──
424
888
 
425
889
  const DRAG_MIME = 'application/x-workspace-path';
890
+ /**
891
+ * What kind of row is being dragged — `directory` or `file`. The path alone
892
+ * does not say (a folder may be named like a file), and the move dialog asks
893
+ * a file-only access question, so the kind travels with the path.
894
+ */
895
+ const DRAG_KIND_MIME = 'application/x-workspace-kind';
426
896
 
427
- function FileTreeNode({
897
+ export function FileTreeNode({
428
898
  entry,
429
899
  depth,
430
900
  initiallyExpanded,
431
901
  collapseChildren,
902
+ reserved = false,
903
+ absent = false,
904
+ root,
432
905
  }: {
433
906
  entry: FileTreeEntry;
434
907
  depth: number;
@@ -439,37 +912,115 @@ function FileTreeNode({
439
912
  // When set, this node's direct children start collapsed (so opening Knowledge
440
913
  // reveals the ontologies without cascading them all open).
441
914
  collapseChildren?: boolean;
915
+ /**
916
+ * The folder is a root the platform owns (`Skills/` in the Library). It is
917
+ * an ordinary collapsible folder row — the same row Knowledge and Data get
918
+ * at the top of the explorer: it takes drops, offers the create buttons,
919
+ * opens the folder's menu on right-click — minus what a reserved root must
920
+ * not do: be renamed, deleted, dragged, or pinned.
921
+ */
922
+ reserved?: boolean;
923
+ /**
924
+ * The folder is not on disk yet — a reserved root drawn before the
925
+ * knowledge base has it, so the way to create it is on screen. Everything
926
+ * that WRITES works (each write creates its parents); what READS the folder
927
+ * is withheld: no Download, which would ask the server for a zip of nothing.
928
+ */
929
+ absent?: boolean;
930
+ /**
931
+ * This row IS the tree — the folder everything below it hangs off. It gets
932
+ * the root's affordances (the Add files / Add folder pickers) and none of
933
+ * the ones that would move the tree out from under itself (drag, rename,
934
+ * delete, Copy path). Defaults to the `.` workspace-root node, which is
935
+ * what a tree rooted at the literal root hands down; the Knowledge
936
+ * explorer sets it on the CHECKOUT folder, which is its root even though
937
+ * the workspace directory above it is not.
938
+ */
939
+ root?: boolean;
442
940
  }) {
443
- const { openFilePath, createFile, createDirectory, dispatchUpload, isUploading, moveEntry, workspaceId, pendingUploads } = useWorkspace();
444
- const { openFile } = useFileNav();
941
+ const { createFile, createDirectory, dispatchUpload, isUploading, moveEntry, workspaceId, kbDirName, pendingUploads } = useWorkspace();
942
+ const nav = useTreeNav();
943
+ /**
944
+ * Why this row cannot be renamed, or null when it can. A platform file is
945
+ * refused here with the sentence the server refuses with — the tree says it
946
+ * without a round trip, and says the same thing.
947
+ */
948
+ const platformRefusal = platformFileMoveRefusal(entry.relativePath, kbDirName);
949
+ /**
950
+ * Why it cannot be DRAGGED — the same, minus an admin's one repair (see
951
+ * `platformFileDragRefusal`). Read through the context rather than
952
+ * `useAdmin()` so a tree rendered without an `AdminProvider` — a host app's,
953
+ * a test's — still draws: no provider is simply nobody's admin, which is the
954
+ * refusal this row had before the exception existed.
955
+ */
956
+ const isAdmin = useContext(AdminContext)?.isAdmin ?? false;
957
+ const dragRefusal = platformFileDragRefusal(entry.relativePath, kbDirName, isAdmin);
958
+ const confirm = useTreeConfirm();
959
+ // Which tree this row belongs to, so an upload's banners land here and not
960
+ // in the other tree on the same page.
961
+ const uploadTarget = useUploadTarget();
445
962
  // One shared fetch behind this — see `OpenChangeRequestsProvider`.
446
963
  const openChangeRequests = useOpenChangeRequests();
447
964
  const suggestions = useSuggestions();
448
965
 
966
+ /**
967
+ * A refused download, said in place under the row. Never an `alert()`: the
968
+ * menu's preflight already turns the KNOWN refusal into a disabled item, so
969
+ * what reaches here is the rare late one — permission changed while the
970
+ * menu was open — and a modal popup for it stops the whole app to report
971
+ * something the row itself can say.
972
+ */
973
+ const [downloadError, setDownloadError] = useState<string | null>(null);
974
+ /**
975
+ * A refused drop, said in place under the row it was dropped on — the same
976
+ * treatment a refused download gets, and for the same reason. It used to be
977
+ * an `alert()`, which stops the app to report something the tree can say;
978
+ * the sentence the server sends ("A file named Notes.md already exists in
979
+ * Sales.") is the whole message, so it is shown verbatim.
980
+ */
981
+ const [moveError, setMoveError] = useState<string | null>(null);
982
+ /**
983
+ * Which download the notice is allowed to speak for. The menu closes on
984
+ * click but the ROW does not, so a second Download can be started (reopen,
985
+ * click again) while the first is still in flight — and the two can land
986
+ * out of order. Only the latest may write `downloadError`: without this, a
987
+ * slow refusal arriving after a fast success reports a failed download the
988
+ * user just watched succeed.
989
+ */
990
+ const downloadSeq = useRef(0);
991
+
449
992
  const handleDownload = useCallback(async () => {
450
993
  if (!workspaceId) return;
451
994
  // Files hit /file/raw; folders hit /folder/zip and arrive as <name>.zip.
452
995
  // Both endpoints share the same per-path `download:` access gate, the
453
996
  // same `?download=1` flag shape, and the same Content-Disposition
454
997
  // handling on the backend — branching here just picks the URL.
455
- // No preflight: a 403 surfaces in the alert below.
998
+ // The menu preflights the gate's verdict (`useDownloadVerdict`); a 403
999
+ // still reaching here is a permission that changed since it opened.
456
1000
  const isFolder = entry.type === 'directory';
457
1001
  const url = isFolder
458
1002
  ? `/api/workspace/${workspaceId}/folder/zip?path=${encodeURIComponent(entry.relativePath)}&download=1`
459
- : `/api/workspace/${workspaceId}/file/raw?path=${encodeURIComponent(entry.relativePath)}&download=1`;
1003
+ : rawFileUrl(workspaceId, entry.relativePath, { download: true });
460
1004
  const savedAs = isFolder ? `${entry.name}.zip` : entry.name;
1005
+ const seq = ++downloadSeq.current;
1006
+ setDownloadError(null);
461
1007
  try {
462
1008
  const outcome = await downloadViaBlob(url, savedAs);
1009
+ // Superseded: a later download for this row has already spoken.
1010
+ if (seq !== downloadSeq.current) return;
463
1011
  if (!outcome.ok) {
464
- alert(
465
- `Failed to download ${entry.name} (HTTP ${outcome.status})${outcome.body ? `: ${outcome.body}` : ''}`,
1012
+ setDownloadError(
1013
+ outcome.status === 403
1014
+ ? `Couldn't download ${entry.name}. ${DOWNLOAD_DENIED_MESSAGE}.`
1015
+ : `Couldn't download ${entry.name} (HTTP ${outcome.status})${outcome.body ? `: ${outcome.body}` : ''}`,
466
1016
  );
467
1017
  return;
468
1018
  }
469
1019
  } catch (err) {
470
1020
  console.error('Failed to download:', err);
1021
+ if (seq !== downloadSeq.current) return;
471
1022
  const msg = err instanceof Error ? err.message : String(err);
472
- alert(`Failed to download ${entry.name}:\n${msg}`);
1023
+ setDownloadError(`Couldn't download ${entry.name}: ${msg}`);
473
1024
  }
474
1025
  }, [workspaceId, entry.relativePath, entry.name, entry.type]);
475
1026
  // `null` = no explicit user intent; fall through to the auto-expand / depth
@@ -494,13 +1045,30 @@ function FileTreeNode({
494
1045
  rootFolderInputRef.current?.click();
495
1046
  }, []);
496
1047
 
1048
+ /**
1049
+ * Every upload into this row goes through here. Nothing is asked first: an
1050
+ * upload into a folder the caller cannot read is refused by the server's
1051
+ * read-before-write gate, and the refusal shows in this tree's banner.
1052
+ */
1053
+ const uploadAfterGate = useCallback(
1054
+ (input: UploadInput, targetDir: string) => {
1055
+ void dispatchUpload(input, targetDir, uploadTarget);
1056
+ },
1057
+ [dispatchUpload, uploadTarget],
1058
+ );
1059
+
1060
+ // Where this row's own writes go. Keyed to the PATH, not to `isRoot`: the
1061
+ // checkout folder is a root row with a real path of its own, and a write
1062
+ // into it is addressed like any other folder's. Only the literal `.`
1063
+ // workspace root has no path to give, and `''` is how the server hears it.
1064
+ const pickTarget = entry.relativePath === '.' ? '' : entry.relativePath;
497
1065
  // Resetting `value` after dispatch lets users re-select the same file and
498
1066
  // still get an `onChange` event the second time around.
499
1067
  const handleRootFileChange = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
500
1068
  const files = Array.from(e.target.files ?? []);
501
1069
  e.target.value = '';
502
- if (files.length > 0) dispatchUpload({ kind: 'files', files }, '');
503
- }, [dispatchUpload]);
1070
+ if (files.length > 0) uploadAfterGate({ kind: 'files', files }, pickTarget);
1071
+ }, [uploadAfterGate, pickTarget]);
504
1072
 
505
1073
  // Folder picker: each File carries a `webkitRelativePath` like
506
1074
  // "foldername/sub/file.txt" — we feed those straight into the upload
@@ -516,17 +1084,17 @@ function FileTreeNode({
516
1084
  file,
517
1085
  relativePath: file.webkitRelativePath || file.name,
518
1086
  }));
519
- dispatchUpload({ kind: 'paths', items }, '');
520
- }, [dispatchUpload]);
1087
+ uploadAfterGate({ kind: 'paths', items }, pickTarget);
1088
+ }, [uploadAfterGate, pickTarget]);
521
1089
  const [dragging, setDragging] = useState(false);
522
1090
  const [contextMenu, setContextMenu] = useState<{ x: number; y: number } | null>(null);
523
1091
 
524
1092
  const paddingLeft = indentFor(depth);
525
- const isRoot = entry.relativePath === '.';
1093
+ const isRoot = root ?? entry.relativePath === '.';
526
1094
  const isPending = pendingUploads.has(entry.relativePath);
527
- // A folder with nothing in it doesn't get a caret, because there is nothing
528
- // to open (proto:3565).
529
- const hasChildren = (entry.children?.length ?? 0) > 0;
1095
+ // A folder with nothing in it still gets its caret — without one it reads
1096
+ // as a file — and opening it says so with a muted "Empty" row.
1097
+ const isEmpty = (entry.children?.length ?? 0) === 0;
530
1098
  // Escape inside the context menu hands focus back to the row it came from.
531
1099
  const rowRef = useRef<HTMLButtonElement>(null);
532
1100
 
@@ -534,15 +1102,15 @@ function FileTreeNode({
534
1102
  // deep-link URLs reveal the file's row in the tree) or while files
535
1103
  // dropped under it are still uploading (so the user can watch them
536
1104
  // fill in).
537
- const isOpenFileAncestor = entry.type === 'directory' && !!openFilePath && (
538
- isRoot || openFilePath.startsWith(entry.relativePath + '/')
1105
+ const isOpenFileAncestor = entry.type === 'directory' && !!nav.activePath && (
1106
+ isRoot || nav.activePath.startsWith(entry.relativePath + '/')
539
1107
  );
540
1108
  const autoExpanded = entry.type === 'directory' && (isPending || isOpenFileAncestor);
541
1109
 
542
1110
  // Fingerprint of what currently drives auto-expand. When it transitions
543
1111
  // (different file opened, upload starts), the user's prior collapse intent
544
1112
  // is stale — reset so deep-links / new uploads can re-reveal the folder.
545
- const autoTrigger = `${isPending ? 'P' : ''}|${isOpenFileAncestor ? openFilePath : ''}`;
1113
+ const autoTrigger = `${isPending ? 'P' : ''}|${isOpenFileAncestor ? nav.activePath : ''}`;
546
1114
  const prevAutoTriggerRef = useRef(autoTrigger);
547
1115
  useEffect(() => {
548
1116
  if (prevAutoTriggerRef.current !== autoTrigger) {
@@ -559,13 +1127,57 @@ function FileTreeNode({
559
1127
  setContextMenu({ x: e.clientX, y: e.clientY });
560
1128
  }, []);
561
1129
 
1130
+ // Rendered directly under the row it belongs to, at the row's own indent,
1131
+ // so the failure is attached to the file it is about — the sidebar shows
1132
+ // many rows and a banner at the top would name one of them in prose.
1133
+ const downloadNotice = downloadError && (
1134
+ <RowNotice
1135
+ message={downloadError}
1136
+ testId="tree-download-error"
1137
+ dismissLabel="Dismiss download error"
1138
+ paddingLeft={paddingLeft}
1139
+ onDismiss={() => setDownloadError(null)}
1140
+ />
1141
+ );
1142
+ const moveNotice = moveError && (
1143
+ <RowNotice
1144
+ message={moveError}
1145
+ testId="tree-move-error"
1146
+ dismissLabel="Dismiss move error"
1147
+ paddingLeft={paddingLeft}
1148
+ onDismiss={() => setMoveError(null)}
1149
+ />
1150
+ );
1151
+
1152
+ /**
1153
+ * The rename box's submit: move this entry to `newName` beside itself.
1154
+ * Answers with the sentence to show IN the box — "A file named Notes.md
1155
+ * already exists in Sales." — or null once the rename landed, which is the
1156
+ * only case that closes the box. A refused rename leaves the name the user
1157
+ * typed on screen to fix; it is never reported through `alert()`, which
1158
+ * would say it somewhere the user has to dismiss and, by stealing focus
1159
+ * from the still-mounted input, re-submit the same doomed rename.
1160
+ */
1161
+ const renameTo = useCallback(async (newName: string): Promise<string | null> => {
1162
+ const parentDir = entry.relativePath.substring(0, entry.relativePath.lastIndexOf('/'));
1163
+ const newPath = parentDir ? `${parentDir}/${newName}` : newName;
1164
+ try {
1165
+ await moveEntry(entry.relativePath, newPath);
1166
+ } catch (err) {
1167
+ return err instanceof Error ? err.message : String(err);
1168
+ }
1169
+ setRenaming(false);
1170
+ return null;
1171
+ }, [entry.relativePath, moveEntry]);
1172
+
562
1173
  // ── Drag source (internal reorder) ──
563
1174
  const handleDragStart = useCallback((e: React.DragEvent) => {
564
- if (isRoot) { e.preventDefault(); return; }
1175
+ if (isRoot || reserved || dragRefusal) { e.preventDefault(); return; }
565
1176
  e.dataTransfer.setData(DRAG_MIME, entry.relativePath);
1177
+ e.dataTransfer.setData(DRAG_KIND_MIME, entry.type);
566
1178
  e.dataTransfer.effectAllowed = 'move';
567
1179
  setDragging(true);
568
- }, [entry.relativePath, isRoot]);
1180
+ }, [entry.relativePath, entry.type, isRoot, reserved, dragRefusal]);
569
1181
 
570
1182
  const handleDragEnd = useCallback(() => {
571
1183
  setDragging(false);
@@ -581,9 +1193,23 @@ function FileTreeNode({
581
1193
  // Internal move (reorder)
582
1194
  const sourcePath = e.dataTransfer.getData(DRAG_MIME);
583
1195
  if (sourcePath) {
584
- const targetDir = entry.type === 'directory'
1196
+ const droppedOn = entry.type === 'directory'
585
1197
  ? (isRoot ? '' : entry.relativePath)
586
1198
  : '';
1199
+ // "The top level" is the top of the tree the dragged row lives in —
1200
+ // the KB clone's own root — not the workspace folder the clone sits
1201
+ // in. In the split layout the explorer draws the clone's roots
1202
+ // (Knowledge, Data, …) and its loose files but no row for the clone
1203
+ // itself, so a drop that resolves to no folder is how the clone's
1204
+ // root is reached at all: it is where an admin drops a misplaced
1205
+ // `roles.yaml` to put it back. Left bare, that move would send the
1206
+ // file to `roles.yaml` BESIDE the clone — out of the repository,
1207
+ // where nothing reads it and git never sees it again.
1208
+ const kbPrefix = kbDirName ? `${kbDirName}/` : null;
1209
+ const targetDir =
1210
+ droppedOn === '' && kbPrefix !== null && sourcePath.startsWith(kbPrefix)
1211
+ ? kbDirName!
1212
+ : droppedOn;
587
1213
  const name = sourcePath.split('/').pop()!;
588
1214
  const newPath = targetDir ? `${targetDir}/${name}` : name;
589
1215
  // Skip no-op or nesting a directory inside itself
@@ -594,7 +1220,42 @@ function FileTreeNode({
594
1220
  ) {
595
1221
  return;
596
1222
  }
597
- moveEntry(sourcePath, newPath);
1223
+ // The dragged row is a platform file: refused here, with the server's
1224
+ // sentence, and nothing is sent. The row itself is not draggable, so
1225
+ // this catches a drag begun before the tree knew the path's shape
1226
+ // (a drop is the last moment the answer is still cheap).
1227
+ const refusal = platformFileDragRefusal(sourcePath, kbDirName, isAdmin);
1228
+ if (refusal) {
1229
+ alert(refusal);
1230
+ return;
1231
+ }
1232
+ // Every cross-folder move is an access change, so it asks first;
1233
+ // nothing is sent until Confirm.
1234
+ confirm({
1235
+ kind: 'move',
1236
+ sourcePath,
1237
+ sourceIsDirectory: e.dataTransfer.getData(DRAG_KIND_MIME) === 'directory',
1238
+ targetDir,
1239
+ // Named after the row that was dropped on, so a drop that resolved
1240
+ // to the clone's root still reads as "the top level".
1241
+ destinationLabel: droppedOn ? entry.name : 'the top level',
1242
+ returnFocusTo: () => rowForPath(sourcePath),
1243
+ // The row it was dropped on stays put; the source row moves away.
1244
+ focusAfterRun: () => rowForPath(entry.relativePath),
1245
+ run: async () => {
1246
+ try {
1247
+ setMoveError(null);
1248
+ await moveEntry(sourcePath, newPath);
1249
+ } catch (err) {
1250
+ // Same surfacing as rename — a refused move (a name already
1251
+ // taken here, a folder the caller may not write) must not read
1252
+ // as one that silently reverted. Both entries stay where they
1253
+ // are: the server moved nothing.
1254
+ const msg = err instanceof Error ? err.message : String(err);
1255
+ setMoveError(msg);
1256
+ }
1257
+ },
1258
+ });
598
1259
  return;
599
1260
  }
600
1261
 
@@ -605,15 +1266,15 @@ function FileTreeNode({
605
1266
  const targetDir = dir === '.' ? '' : dir;
606
1267
  const entries = e.dataTransfer.items ? snapshotEntries(e.dataTransfer.items) : [];
607
1268
  if (entries.length > 0) {
608
- dispatchUpload({ kind: 'items', entries }, targetDir);
1269
+ uploadAfterGate({ kind: 'items', entries }, targetDir);
609
1270
  return;
610
1271
  }
611
1272
  // Fallback for older browsers / non-entry drops: use the flat FileList.
612
1273
  const files = Array.from(e.dataTransfer.files);
613
1274
  if (files.length === 0) return;
614
- dispatchUpload({ kind: 'files', files }, targetDir);
1275
+ uploadAfterGate({ kind: 'files', files }, targetDir);
615
1276
  },
616
- [entry, isRoot, dispatchUpload, moveEntry],
1277
+ [entry, isRoot, uploadAfterGate, moveEntry, confirm, kbDirName, isAdmin],
617
1278
  );
618
1279
 
619
1280
  const handleDragOver = useCallback((e: React.DragEvent) => {
@@ -632,7 +1293,76 @@ function FileTreeNode({
632
1293
  }, []);
633
1294
 
634
1295
  if (entry.type === 'directory') {
635
- const dirPath = isRoot ? '' : entry.relativePath;
1296
+ const dirPath = pickTarget;
1297
+ const createButtons = (
1298
+ <>
1299
+ <IconButton
1300
+ size={18}
1301
+ title="New file"
1302
+ aria-label={`New file in ${entry.name}`}
1303
+ onClick={(e) => {
1304
+ e.stopPropagation();
1305
+ setUserIntent(true);
1306
+ setCreating('file');
1307
+ }}
1308
+ >
1309
+ <FilePlus size={13} />
1310
+ </IconButton>
1311
+ <IconButton
1312
+ size={18}
1313
+ title="New folder"
1314
+ aria-label={`New folder in ${entry.name}`}
1315
+ onClick={(e) => {
1316
+ e.stopPropagation();
1317
+ setUserIntent(true);
1318
+ setCreating('directory');
1319
+ }}
1320
+ >
1321
+ <FolderPlus size={13} />
1322
+ </IconButton>
1323
+ </>
1324
+ );
1325
+ const pickerButtons = (
1326
+ <>
1327
+ <IconButton
1328
+ size={18}
1329
+ title="Add files"
1330
+ aria-label="Add files"
1331
+ disabled={isUploading}
1332
+ onClick={handleRootUploadClick}
1333
+ >
1334
+ <Upload size={13} />
1335
+ </IconButton>
1336
+ <input
1337
+ ref={rootFileInputRef}
1338
+ type="file"
1339
+ multiple
1340
+ hidden
1341
+ aria-hidden="true"
1342
+ data-testid="file-explorer-file-input"
1343
+ onChange={handleRootFileChange}
1344
+ />
1345
+ <IconButton
1346
+ size={18}
1347
+ title="Add folder"
1348
+ aria-label="Add folder"
1349
+ disabled={isUploading}
1350
+ onClick={handleRootFolderClick}
1351
+ >
1352
+ <FolderUp size={13} />
1353
+ </IconButton>
1354
+ <input
1355
+ ref={rootFolderInputRef}
1356
+ type="file"
1357
+ multiple
1358
+ webkitdirectory=""
1359
+ hidden
1360
+ aria-hidden="true"
1361
+ data-testid="file-explorer-folder-input"
1362
+ onChange={handleRootFolderChange}
1363
+ />
1364
+ </>
1365
+ );
636
1366
  return (
637
1367
  <div>
638
1368
  <div
@@ -643,7 +1373,7 @@ function FileTreeNode({
643
1373
  dragOver && 'bg-hover text-ink ring-1 ring-accent/40',
644
1374
  )}
645
1375
  style={{ paddingLeft, opacity: dragging ? 0.5 : isPending ? 0.6 : 1 }}
646
- draggable={!isRoot && !renaming && !isPending}
1376
+ draggable={!isRoot && !reserved && !renaming && !isPending && !dragRefusal}
647
1377
  onDragStart={handleDragStart}
648
1378
  onDragEnd={handleDragEnd}
649
1379
  onDrop={handleDrop}
@@ -654,31 +1384,17 @@ function FileTreeNode({
654
1384
  <button
655
1385
  ref={rowRef}
656
1386
  type="button"
1387
+ data-tree-path={entry.relativePath}
657
1388
  aria-expanded={isExpanded}
658
1389
  className="flex min-w-0 flex-1 items-center gap-1.5 text-left"
659
- onClick={() => { if (hasChildren) setUserIntent(!isExpanded); }}
1390
+ onClick={() => setUserIntent(!isExpanded)}
660
1391
  >
661
- <CaretSlot open={isExpanded} show={hasChildren} />
1392
+ <CaretSlot open={isExpanded} show />
662
1393
  {renaming ? (
663
1394
  <RenameInput
664
1395
  currentName={entry.name}
665
1396
  isFile={false}
666
- onSubmit={async (newName) => {
667
- const parentDir = entry.relativePath.substring(0, entry.relativePath.lastIndexOf('/'));
668
- const newPath = parentDir ? `${parentDir}/${newName}` : newName;
669
- // Close the input BEFORE the fallible move — see the create
670
- // flow: on error the alert() blurs the still-mounted input,
671
- // whose onBlur re-fires this onSubmit, looping the popup.
672
- setRenaming(false);
673
- try {
674
- await moveEntry(entry.relativePath, newPath);
675
- } catch (err) {
676
- // Same surfacing as the create flow above — a silent failure
677
- // reads as the rename being accepted and then reverting.
678
- const msg = err instanceof Error ? err.message : String(err);
679
- alert(`Failed to rename ${entry.name}:\n${msg}`);
680
- }
681
- }}
1397
+ onSubmit={renameTo}
682
1398
  onCancel={() => setRenaming(false)}
683
1399
  />
684
1400
  ) : (
@@ -686,73 +1402,12 @@ function FileTreeNode({
686
1402
  )}
687
1403
  </button>
688
1404
  <div className="hidden shrink-0 items-center gap-0.5 group-hover:flex group-focus-within:flex">
689
- <IconButton
690
- size={18}
691
- title="New file"
692
- aria-label={`New file in ${entry.name}`}
693
- onClick={(e) => {
694
- e.stopPropagation();
695
- setUserIntent(true);
696
- setCreating('file');
697
- }}
698
- >
699
- <FilePlus size={13} />
700
- </IconButton>
701
- <IconButton
702
- size={18}
703
- title="New folder"
704
- aria-label={`New folder in ${entry.name}`}
705
- onClick={(e) => {
706
- e.stopPropagation();
707
- setUserIntent(true);
708
- setCreating('directory');
709
- }}
710
- >
711
- <FolderPlus size={13} />
712
- </IconButton>
1405
+ {createButtons}
713
1406
  </div>
714
- {isRoot && (
715
- <>
716
- <IconButton
717
- size={18}
718
- title="Add files"
719
- aria-label="Add files"
720
- disabled={isUploading}
721
- onClick={handleRootUploadClick}
722
- >
723
- <Upload size={13} />
724
- </IconButton>
725
- <input
726
- ref={rootFileInputRef}
727
- type="file"
728
- multiple
729
- hidden
730
- aria-hidden="true"
731
- data-testid="file-explorer-file-input"
732
- onChange={handleRootFileChange}
733
- />
734
- <IconButton
735
- size={18}
736
- title="Add folder"
737
- aria-label="Add folder"
738
- disabled={isUploading}
739
- onClick={handleRootFolderClick}
740
- >
741
- <FolderUp size={13} />
742
- </IconButton>
743
- <input
744
- ref={rootFolderInputRef}
745
- type="file"
746
- multiple
747
- webkitdirectory=""
748
- hidden
749
- aria-hidden="true"
750
- data-testid="file-explorer-folder-input"
751
- onChange={handleRootFolderChange}
752
- />
753
- </>
754
- )}
1407
+ {isRoot && pickerButtons}
755
1408
  </div>
1409
+ {downloadNotice}
1410
+ {moveNotice}
756
1411
  {isExpanded && (
757
1412
  <div>
758
1413
  {creating && (
@@ -776,10 +1431,11 @@ function FileTreeNode({
776
1431
  if (kind === 'file') await createFile(fullPath);
777
1432
  else await createDirectory(fullPath);
778
1433
  } catch (err) {
779
- // Surface the refusal (e.g. a protected branch's write
780
- // gate: "You don't have permission to write to …") —
781
- // otherwise the input clears and nothing appears, which
782
- // reads as the file silently vanishing.
1434
+ // Surface the refusal (a protected branch's write gate,
1435
+ // or the read-before-write gate: "You don't have
1436
+ // permission to write to …") — otherwise the input
1437
+ // clears and nothing appears, which reads as the file
1438
+ // silently vanishing.
783
1439
  const msg = err instanceof Error ? err.message : String(err);
784
1440
  alert(`Failed to create ${name}:\n${msg}`);
785
1441
  }
@@ -788,6 +1444,19 @@ function FileTreeNode({
788
1444
  />
789
1445
  </div>
790
1446
  )}
1447
+ {isEmpty && !creating && (
1448
+ // Not a row anyone acts on — no path, no focus, no menu — so
1449
+ // keyboard navigation and the context menu never meet it. It
1450
+ // sits where a first child would, name column included.
1451
+ <div
1452
+ data-tree-empty
1453
+ className={cn(ROW_CLASS, 'text-ink-faint')}
1454
+ style={{ paddingLeft: indentFor(depth + 1) }}
1455
+ >
1456
+ <CaretSlot show={false} />
1457
+ <span className="truncate">Empty</span>
1458
+ </div>
1459
+ )}
791
1460
  {entry.children?.map((child) => (
792
1461
  <FileTreeNode
793
1462
  key={child.relativePath}
@@ -807,8 +1476,18 @@ function FileTreeNode({
807
1476
  onClose={() => setContextMenu(null)}
808
1477
  onCreateFile={() => { setUserIntent(true); setCreating('file'); }}
809
1478
  onCreateFolder={() => { setUserIntent(true); setCreating('directory'); }}
810
- onRename={() => setRenaming(true)}
811
- onDownload={handleDownload}
1479
+ // A reserved root is the platform's: no rename, no delete. (No pin
1480
+ // either, but that needs no gate: only the Knowledge explorer
1481
+ // offers pinning, and its roots are not reserved.)
1482
+ onRename={reserved ? undefined : () => setRenaming(true)}
1483
+ // A folder NAMED like a platform file (`access.md/`) meets the same
1484
+ // rule: the server reads the path, not the kind, and refuses to
1485
+ // move it. Without this the row refused the drag and offered the
1486
+ // rename, which opened an editor only to fail on the round trip.
1487
+ renameRefusal={platformRefusal}
1488
+ deletable={!reserved}
1489
+ onDownload={absent ? undefined : handleDownload}
1490
+ extraItems={nav.menuItems?.(entry)}
812
1491
  returnFocusTo={rowRef}
813
1492
  />
814
1493
  )}
@@ -819,40 +1498,99 @@ function FileTreeNode({
819
1498
  // A file from the caller's own open change request that does not exist on
820
1499
  // this branch. Its row is a LINK to the request, not a file: there is no
821
1500
  // content here to show, so clicking opens the change-request view, and none
822
- // of the file affordances (rename, drag, download, context menu) apply —
823
- // they would all 404 against a path this branch has never heard of. The
824
- // accent colour is the tell that this is proposed, not present.
1501
+ // of the file affordances (rename, drag, download) apply — they would all
1502
+ // 404 against a path this branch has never heard of. The context menu keeps
1503
+ // only what makes sense for a proposal: the path, and Manage access, which
1504
+ // the chrome points at the change request's branch. The accent colour is
1505
+ // the tell that this is proposed, not present.
825
1506
  const suggestedCr = suggestions.crFor(entry.relativePath);
826
1507
  if (suggestedCr !== null) {
1508
+ // The one thing the author can DO to a proposal from here: take it back.
1509
+ // The reporter of this had uploaded a file into a folder they cannot
1510
+ // write, watched it turn into an accent-coloured row, and concluded there
1511
+ // was no way to undo it — the Withdraw that already existed was on the
1512
+ // file page and in the dialog, neither of which the row leads to.
1513
+ //
1514
+ // `undefined` for anyone else's request, which is what keeps the item off
1515
+ // the menu entirely; an owner's "no" is Decline, and it stays in the dialog.
1516
+ const withdraw = suggestions.mine(suggestedCr)
1517
+ ? () => {
1518
+ // The request may not be in the shared list yet (the broad fetch
1519
+ // trails a just-made suggestion). Naming the row's own file is then
1520
+ // both true and the least surprising thing to say.
1521
+ const carried = suggestions.filesOf(entry.relativePath, suggestedCr);
1522
+ confirm({
1523
+ kind: 'withdraw',
1524
+ crNumber: suggestedCr,
1525
+ files: carried.length > 0 ? carried : [entry.relativePath],
1526
+ returnFocusTo: () => rowRef.current,
1527
+ // The row leaves the tree with the request it stood for, so focus
1528
+ // goes to the folder that held it — as a delete's does.
1529
+ focusAfterRun: () => rowForPath(entry.relativePath.split('/').slice(0, -1).join('/')),
1530
+ run: async () => {
1531
+ try {
1532
+ await suggestions.withdraw(suggestedCr);
1533
+ } catch (err) {
1534
+ // Already applied, or declined meanwhile: the same surfacing
1535
+ // every other refused tree operation gets. The rows refresh
1536
+ // either way (see the controller), so what the user sees next
1537
+ // is the truth from the server rather than a stale row.
1538
+ console.error('Failed to withdraw suggestion:', err);
1539
+ const msg = err instanceof Error ? err.message : String(err);
1540
+ alert(`Couldn't withdraw ${entry.name}:\n${msg}`);
1541
+ }
1542
+ },
1543
+ });
1544
+ }
1545
+ : undefined;
827
1546
  return (
828
- <button
829
- type="button"
830
- className={cn(
831
- ROW_CLASS,
832
- 'text-accent hover:bg-hover hover:text-accent-hover',
833
- 'focus-visible:outline-2 focus-visible:-outline-offset-1 focus-visible:outline-ink-muted',
1547
+ <>
1548
+ <button
1549
+ ref={rowRef}
1550
+ type="button"
1551
+ data-tree-path={entry.relativePath}
1552
+ className={cn(
1553
+ ROW_CLASS,
1554
+ 'text-accent hover:bg-hover hover:text-accent-hover',
1555
+ 'focus-visible:outline-2 focus-visible:-outline-offset-1 focus-visible:outline-ink-muted',
1556
+ )}
1557
+ style={{ paddingLeft }}
1558
+ onClick={() => suggestions.open(entry.relativePath, suggestedCr)}
1559
+ onContextMenu={handleContextMenu}
1560
+ title="Proposed by you: opens the change request"
1561
+ >
1562
+ <CaretSlot show={false} />
1563
+ <FileName name={entry.name} />
1564
+ <span
1565
+ aria-hidden
1566
+ className="ml-auto h-1.5 w-1.5 flex-none rounded-full bg-accent"
1567
+ />
1568
+ </button>
1569
+ {contextMenu && (
1570
+ <ContextMenu
1571
+ x={contextMenu.x}
1572
+ y={contextMenu.y}
1573
+ entry={entry}
1574
+ isRoot={false}
1575
+ proposed
1576
+ deletable={false}
1577
+ onWithdraw={withdraw}
1578
+ onClose={() => setContextMenu(null)}
1579
+ returnFocusTo={rowRef}
1580
+ />
834
1581
  )}
835
- style={{ paddingLeft }}
836
- onClick={() => suggestions.open(entry.relativePath, suggestedCr)}
837
- title="Proposed by you: opens the change request"
838
- >
839
- <CaretSlot show={false} />
840
- <span className="truncate">{entry.name}</span>
841
- <span
842
- aria-hidden
843
- className="ml-auto h-1.5 w-1.5 flex-none rounded-full bg-accent"
844
- />
845
- </button>
1582
+ </>
846
1583
  );
847
1584
  }
848
1585
 
849
- const isActive = entry.relativePath === openFilePath;
1586
+ const isActive = entry.relativePath === nav.activePath;
850
1587
 
851
1588
  return (
852
1589
  <>
853
1590
  <button
854
1591
  ref={rowRef}
855
1592
  type="button"
1593
+ data-tree-path={entry.relativePath}
856
1594
  aria-current={isActive}
857
1595
  className={cn(
858
1596
  ROW_CLASS,
@@ -861,10 +1599,10 @@ function FileTreeNode({
861
1599
  isPending && 'cursor-progress',
862
1600
  )}
863
1601
  style={{ paddingLeft, opacity: dragging ? 0.5 : isPending ? 0.6 : 1 }}
864
- draggable={!renaming && !isPending}
1602
+ draggable={!renaming && !isPending && !dragRefusal}
865
1603
  onDragStart={handleDragStart}
866
1604
  onDragEnd={handleDragEnd}
867
- onClick={() => { if (!renaming && !isPending) openFile(entry.relativePath); }}
1605
+ onClick={() => { if (!renaming && !isPending) nav.open(entry.relativePath); }}
868
1606
  onContextMenu={handleContextMenu}
869
1607
  title={isPending ? 'Adding…' : undefined}
870
1608
  >
@@ -882,26 +1620,11 @@ function FileTreeNode({
882
1620
  <RenameInput
883
1621
  currentName={entry.name}
884
1622
  isFile={true}
885
- onSubmit={async (newName) => {
886
- const parentDir = entry.relativePath.substring(0, entry.relativePath.lastIndexOf('/'));
887
- const newPath = parentDir ? `${parentDir}/${newName}` : newName;
888
- // Close the input BEFORE the fallible move — see the create
889
- // flow: on error the alert() blurs the still-mounted input,
890
- // whose onBlur re-fires this onSubmit, looping the popup.
891
- setRenaming(false);
892
- try {
893
- await moveEntry(entry.relativePath, newPath);
894
- } catch (err) {
895
- // Same surfacing as the create flow — a silent failure reads
896
- // as the rename being accepted and then reverting.
897
- const msg = err instanceof Error ? err.message : String(err);
898
- alert(`Failed to rename ${entry.name}:\n${msg}`);
899
- }
900
- }}
1623
+ onSubmit={renameTo}
901
1624
  onCancel={() => setRenaming(false)}
902
1625
  />
903
1626
  ) : (
904
- <span className="truncate">{entry.name}</span>
1627
+ <FileName name={entry.name} />
905
1628
  )}
906
1629
  {/* News about a file you are not looking at (proto:692). Amber, not
907
1630
  the tab dot's accent: on a tab the dot marks the file you have
@@ -913,6 +1636,8 @@ function FileTreeNode({
913
1636
  />
914
1637
  )}
915
1638
  </button>
1639
+ {downloadNotice}
1640
+ {moveNotice}
916
1641
  {contextMenu && (
917
1642
  <ContextMenu
918
1643
  x={contextMenu.x}
@@ -921,7 +1646,9 @@ function FileTreeNode({
921
1646
  isRoot={false}
922
1647
  onClose={() => setContextMenu(null)}
923
1648
  onRename={() => setRenaming(true)}
1649
+ renameRefusal={platformRefusal}
924
1650
  onDownload={handleDownload}
1651
+ extraItems={nav.menuItems?.(entry)}
925
1652
  returnFocusTo={rowRef}
926
1653
  />
927
1654
  )}
@@ -932,97 +1659,561 @@ function FileTreeNode({
932
1659
  // ── Explorer Root ──
933
1660
 
934
1661
  /**
935
- * Walk down to the node that actually holds the KB content. The file tree roots
936
- * at the per-branch workspace dir and wraps the KB clone a level or two deep
937
- * (`<branch>/<kbDir>/{KnowledgeBase,Data,Agents,Pipelines,Skills,Tools,…}`), so
938
- * the split lives below the visible root. Returns the first node whose children
939
- * include one of those well-known root directories, or null when there's no
940
- * such split (legacy clones).
1662
+ * Everything a tree of `FileTreeNode`s needs AROUND it, and nothing about
1663
+ * where it sits: the navigation (which row is current, where a click goes),
1664
+ * the suggestion rows' change-request dialog, the right-click menu's Manage
1665
+ * access sheet, and — for the one tree that has somewhere to pin into — a pin
1666
+ * controller. The Knowledge explorer and the Library's Skills tree both render
1667
+ * inside one of these, which is why their rows cannot drift: the rows are one
1668
+ * component and so are their surroundings.
941
1669
  */
942
- // (`findKbRoot` lives in `../utils/fileTree` — shared with registry-
943
- // contributed explorer items.)
944
-
945
- export function FileExplorer() {
946
- const {
947
- fileTree,
948
- kbDirName,
949
- dispatchUpload,
950
- uploadError,
951
- clearUploadError,
952
- uploadNotice,
953
- clearUploadNotice,
954
- pendingUploads,
955
- } = useWorkspace();
956
- const [dragOver, setDragOver] = useState(false);
957
- // Download is now a per-path permission (resolved server-side from the
958
- // access tree's `download:` verb), so there's no global preflight gate
959
- // here anymore. The menu items always render; if the user clicks on a
960
- // file they don't have download permission for, the backend returns 403
961
- // and `handleDownload` shows the error.
962
- // Optimistic overlay: every dropped/picked file shows up in the tree
963
- // within a frame, even before its commit echoes back from the server.
964
- const serverTree = useMemo(
965
- () => (fileTree ? mergePendingIntoTree(fileTree, pendingUploads) : null),
966
- [fileTree, pendingUploads],
967
- );
968
-
969
- // The caller's own proposed files that do NOT exist on this branch — they
970
- // live only on the personal suggestions branch behind an open change
971
- // request. The tree shows them beside the branch's real files (synthesized
972
- // below), coloured differently, and clicking one opens the request.
1670
+ export function TreeChrome({
1671
+ nav,
1672
+ suggestionOnlyPaths,
1673
+ pinned,
1674
+ uploadTarget = KNOWLEDGE_UPLOAD_TARGET,
1675
+ children,
1676
+ }: {
1677
+ nav: TreeNav;
1678
+ suggestionOnlyPaths: ReadonlyMap<string, number>;
1679
+ pinned?: PinnedController;
1680
+ /**
1681
+ * Which tree this is, for the upload banners — see `UploadTarget`. Two
1682
+ * trees on one page (the Library sidebar's `Skills/` and `Plugins/`) must
1683
+ * name themselves differently, or one drop's notice appears in both.
1684
+ */
1685
+ uploadTarget?: UploadTarget;
1686
+ children: ReactNode;
1687
+ }) {
973
1688
  const openChangeRequests = useOpenChangeRequests();
974
- const suggestionOnlyPaths = useMemo(() => {
975
- const map = new Map<string, number>();
976
- if (!serverTree) return map;
977
- /**
978
- * "Not in the tree" has TWO causes, and only one earns a row: the file is
979
- * new on the suggestions branch — or the server FILTERED it (.bevelignore,
980
- * read gates). The client cannot evaluate those rules itself, but it can
981
- * read their verdict off the tree: if the path's top-level folder under
982
- * the repo root is absent, the whole subtree is hidden (a skill proposal
983
- * under a bevelignored `Plugins/` was the observed leak), so the overlay
984
- * must not resurrect it. The known cost: a proposal that CREATES a new
985
- * top-level root folder shows no row until it merges.
986
- */
987
- const hiddenRoot = (path: string): boolean => {
988
- const prefix = kbDirName && path.startsWith(`${kbDirName}/`) ? `${kbDirName}/` : '';
989
- const segments = path.slice(prefix.length).split('/');
990
- if (segments.length < 2) return false; // directly under the repo root
991
- return !pathExistsInTree(serverTree, `${prefix}${segments[0]}`);
992
- };
993
- for (const [path, crNumber] of openChangeRequests.minePaths) {
994
- if (!pathExistsInTree(serverTree, path) && !hiddenRoot(path)) {
995
- map.set(path, crNumber);
996
- }
997
- }
998
- return map;
999
- }, [serverTree, openChangeRequests, kbDirName]);
1000
-
1001
- const mergedTree = useMemo(() => {
1002
- if (!serverTree || suggestionOnlyPaths.size === 0) return serverTree;
1003
- // Reuses the pending-upload synthesizer: same parent-directory creation,
1004
- // same sort order, and a real entry always wins over a synthesized one.
1005
- const asEntries = new Map<string, PendingEntry>();
1006
- for (const path of suggestionOnlyPaths.keys()) {
1007
- asEntries.set(path, { fullPath: path, type: 'file' });
1008
- }
1009
- return mergePendingIntoTree(serverTree, asEntries);
1010
- }, [serverTree, suggestionOnlyPaths]);
1011
-
1012
- // A clicked suggestion row opens the SHARED change-request dialog on the
1013
- // request the path belongs to — the row is a link to the request, and the
1014
- // dialog is the one change-request view the app has.
1015
- const [openSuggestionCr, setOpenSuggestionCr] = useState<PullRequestSummary | null>(null);
1689
+ const { workspaceId, kbDirName } = useWorkspace();
1690
+ // The move dialog's denied-destination warning reads this: the one move a
1691
+ // denied destination still takes is an admin's platform-file restore, and
1692
+ // for anyone else the refusal it predicts is the right prediction. Read
1693
+ // through the context so a tree drawn without an `AdminProvider` still
1694
+ // draws — see `FileTreeNode`.
1695
+ const isAdmin = useContext(AdminContext)?.isAdmin ?? false;
1696
+ /**
1697
+ * A clicked suggestion row opens the SHARED change-request dialog on the
1698
+ * request the path belongs to, AT that file — the row is a link to the
1699
+ * request's view of one file, and arriving at some other file (the
1700
+ * request's first) is arriving somewhere the user did not click.
1701
+ *
1702
+ * The open dialog lives in the URL (`?cr=12&file=Sales/brief.pdf`), not in
1703
+ * component state, so a reload — or a link pasted to a colleague — lands
1704
+ * back on the same file of the same request instead of on the bare tree.
1705
+ * Everything below DERIVES from the query: there is one source of truth for
1706
+ * what is open, and no effect to keep it in step with.
1707
+ */
1708
+ const [searchParams, setSearchParams] = useSearchParams();
1709
+ const openSuggestion = useMemo(() => {
1710
+ const number = Number(searchParams.get(CR_PARAM));
1711
+ const path = searchParams.get(CR_FILE_PARAM);
1712
+ if (!Number.isInteger(number) || number <= 0 || !path) return null;
1713
+ const cr = openChangeRequests.forPath(path).find((c) => c.number === number) ?? null;
1714
+ // Not (yet) a request this viewer has: the list may still be loading, so
1715
+ // nothing opens and the query stands — the dialog appears when it lands.
1716
+ if (!cr) return null;
1717
+ // The query is in the TREE's path space; the change request's files are
1718
+ // repo-relative. One conversion, here, at the hand-over.
1719
+ const prefix = kbDirName ? `${kbDirName}/` : null;
1720
+ return { cr, path, file: prefix && path.startsWith(prefix) ? path.slice(prefix.length) : path };
1721
+ }, [searchParams, kbDirName, openChangeRequests]);
1722
+ const setOpenSuggestion = useCallback(
1723
+ (open: { number: number; path: string } | null) => {
1724
+ setSearchParams(
1725
+ (prev) => {
1726
+ const next = new URLSearchParams(prev);
1727
+ if (open) {
1728
+ next.set(CR_PARAM, String(open.number));
1729
+ next.set(CR_FILE_PARAM, open.path);
1730
+ } else {
1731
+ next.delete(CR_PARAM);
1732
+ next.delete(CR_FILE_PARAM);
1733
+ }
1734
+ return next;
1735
+ },
1736
+ // Opening a request is a place you can come back from; closing it
1737
+ // again should not leave two entries to press Back through.
1738
+ { replace: !open },
1739
+ );
1740
+ },
1741
+ [setSearchParams],
1742
+ );
1016
1743
  const suggestionsController = useMemo<SuggestionsController>(
1017
1744
  () => ({
1018
1745
  crFor: (path) => suggestionOnlyPaths.get(path) ?? null,
1019
- open: (path, crNumber) => {
1020
- const cr = openChangeRequests.forPath(path).find((c) => c.number === crNumber) ?? null;
1021
- setOpenSuggestionCr(cr);
1746
+ open: (path, crNumber) => setOpenSuggestion({ number: crNumber, path }),
1747
+ mine: (crNumber) => openChangeRequests.mineNumbers.has(crNumber),
1748
+ filesOf: (path, crNumber) =>
1749
+ openChangeRequests.forPath(path).find((c) => c.number === crNumber)?.touchedNodePaths ?? [],
1750
+ withdraw: async (crNumber) => {
1751
+ try {
1752
+ await cancelPullRequest(crNumber);
1753
+ } finally {
1754
+ // On BOTH paths. A cancel that succeeded has removed the request,
1755
+ // and one that was refused (applied or declined meanwhile) means
1756
+ // the row was already describing something that is no longer open —
1757
+ // either way the next thing on screen should come from the server.
1758
+ window.dispatchEvent(new Event(PR_STALE_EVENT));
1759
+ }
1022
1760
  },
1023
1761
  }),
1024
- [suggestionOnlyPaths, openChangeRequests],
1762
+ [suggestionOnlyPaths, setOpenSuggestion, openChangeRequests],
1763
+ );
1764
+ // Right-click → Manage access opens this sheet for the chosen entry.
1765
+ const [accessTarget, setAccessTarget] = useState<FileTreeEntry | null>(null);
1766
+ // `Manage <folder> →` from a proposed file's sheet keeps that file's change
1767
+ // request: the inherited grant it retargets from was read on the request's
1768
+ // branch, so the folder's rules are edited there too — not on the viewed
1769
+ // branch, which the folder path alone would resolve to.
1770
+ const [inheritedProposal, setInheritedProposal] = useState<
1771
+ { number: number; branch: string | null } | undefined
1772
+ >(undefined);
1773
+ const openAccess = useCallback((entry: FileTreeEntry) => {
1774
+ setInheritedProposal(undefined);
1775
+ setAccessTarget(entry);
1776
+ }, []);
1777
+ // A proposed-only file does not exist on the branch being viewed, so its
1778
+ // access can only be edited where it lives: the change request's branch.
1779
+ // Everything else — including a file a request merely modifies, which is a
1780
+ // real row here — keeps the ambient workspace. The branch is null when the
1781
+ // request cannot be resolved; the dialog refuses rather than falling back
1782
+ // to a workspace the file is not on.
1783
+ const accessProposal = useMemo(() => {
1784
+ if (!accessTarget) return undefined;
1785
+ if (inheritedProposal) return inheritedProposal;
1786
+ const crNumber = suggestionOnlyPaths.get(accessTarget.relativePath);
1787
+ if (crNumber === undefined) return undefined;
1788
+ const cr = openChangeRequests
1789
+ .forPath(accessTarget.relativePath)
1790
+ .find((c) => c.number === crNumber);
1791
+ return { number: crNumber, branch: cr?.branch ?? null };
1792
+ }, [accessTarget, inheritedProposal, suggestionOnlyPaths, openChangeRequests]);
1793
+
1794
+ // The one open delete/move confirmation for this tree, stamped with the
1795
+ // workspace it was asked in: its `run` closes over that workspace's
1796
+ // operations, so a switch while it is open drops it rather than letting
1797
+ // Confirm act on a branch the dialog never described.
1798
+ const [openConfirm, setOpenConfirm] = useState<
1799
+ { request: TreeConfirmRequest; workspaceId: string | null } | null
1800
+ >(null);
1801
+ const confirmRequest =
1802
+ openConfirm && openConfirm.workspaceId === workspaceId ? openConfirm.request : null;
1803
+ const askConfirm = useCallback(
1804
+ (request: TreeConfirmRequest) => setOpenConfirm({ request, workspaceId }),
1805
+ [workspaceId],
1806
+ );
1807
+ // Dropped outright, so switching back does not bring it back either.
1808
+ useEffect(() => {
1809
+ setOpenConfirm((open) => (open && open.workspaceId !== workspaceId ? null : open));
1810
+ }, [workspaceId]);
1811
+ // Whether the caller may write the move's destination: null until known.
1812
+ // The same three short-circuits as `useFileAccess` (and the upload's
1813
+ // suggestion routing): drafts and paths outside the KB are writable
1814
+ // without asking, and a failed lookup warns about nothing — the server
1815
+ // is the gate either way, and the dialog never waits on this.
1816
+ // Keyed by the request it answers, so a stale answer never reaches the next one.
1817
+ const [writableAnswer, setWritableAnswer] = useState<
1818
+ { request: TreeConfirmRequest; canWrite: boolean } | null
1819
+ >(null);
1820
+ const destinationWritable =
1821
+ writableAnswer && writableAnswer.request === confirmRequest ? writableAnswer.canWrite : null;
1822
+ const focusAfterConfirm = useRef<(() => HTMLElement | null) | null>(null);
1823
+ useEffect(() => {
1824
+ if (confirmRequest?.kind !== 'move' || !workspaceId || !kbDirName) return;
1825
+ if (!isProtectedBranch(decodeURIComponent(workspaceId))) return;
1826
+ const prefix = `${kbDirName}/`;
1827
+ if (!confirmRequest.targetDir.startsWith(prefix)) return;
1828
+ let cancelled = false;
1829
+ fetchFileAccess(workspaceId, confirmRequest.targetDir.slice(prefix.length), 'folder')
1830
+ .then((res) => { if (!cancelled) setWritableAnswer({ request: confirmRequest, canWrite: res.canWrite }); })
1831
+ .catch(() => {});
1832
+ return () => { cancelled = true; };
1833
+ }, [confirmRequest, workspaceId, kbDirName]);
1834
+ // Who the move costs access and who it gains it for. The dialog opens at
1835
+ // once and fills this in: the answer describes the move, it does not gate
1836
+ // it, and Move is enabled the whole time. Keyed by the request it answers,
1837
+ // so a late answer never decorates the next move.
1838
+ const [accessAnswer, setAccessAnswer] = useState<
1839
+ { request: TreeConfirmRequest; change: MoveAccessChange } | null
1840
+ >(null);
1841
+ const moveRequest = confirmRequest?.kind === 'move' ? confirmRequest : null;
1842
+ // Both ends have to sit inside the KB clone for the access tree to govern
1843
+ // them; outside it there are no rules to compare, and the dialog says
1844
+ // nothing about access it cannot resolve. `kbDirName` alone is the KB root.
1845
+ const insideKb = (path: string) =>
1846
+ !!kbDirName && (path === kbDirName || path.startsWith(`${kbDirName}/`));
1847
+ const accessLookup =
1848
+ moveRequest && workspaceId && kbDirName
1849
+ && !moveRequest.sourceIsDirectory
1850
+ && moveRequest.sourcePath.startsWith(`${kbDirName}/`)
1851
+ && insideKb(moveRequest.targetDir)
1852
+ ? moveRequest
1853
+ : null;
1854
+ const moveAccessChange: MoveAccessChange = !accessLookup
1855
+ ? { status: 'unavailable' }
1856
+ : accessAnswer?.request === accessLookup
1857
+ ? accessAnswer.change
1858
+ : { status: 'loading' };
1859
+ useEffect(() => {
1860
+ if (!accessLookup || !workspaceId || !kbDirName) return;
1861
+ const prefix = `${kbDirName}/`;
1862
+ const controller = new AbortController();
1863
+ // Two seconds is the whole budget; past it the answer is no longer wanted
1864
+ // and the dialog falls back to saying it could not work the change out.
1865
+ const timer = setTimeout(() => controller.abort(), ACCESS_LOOKUP_TIMEOUT_MS);
1866
+ let cancelled = false;
1867
+ fetchProspectiveAccess(
1868
+ workspaceId,
1869
+ accessLookup.sourcePath.slice(prefix.length),
1870
+ accessLookup.targetDir === kbDirName ? '' : accessLookup.targetDir.slice(prefix.length),
1871
+ controller.signal,
1872
+ )
1873
+ .then((access) => {
1874
+ if (cancelled) return;
1875
+ setAccessAnswer({
1876
+ request: accessLookup,
1877
+ change: { status: 'ready', ...accessChangeOf(access) },
1878
+ });
1879
+ })
1880
+ .catch((err) => {
1881
+ if (cancelled) return;
1882
+ // Running out of the two seconds is a designed outcome, not a fault:
1883
+ // the abort is ours, and the dialog already says what it means. Only
1884
+ // a genuine failure is worth a line in the console.
1885
+ if ((err as { name?: string } | null)?.name !== 'AbortError') {
1886
+ console.warn('[FileExplorer] prospective access:', err);
1887
+ }
1888
+ setAccessAnswer({ request: accessLookup, change: { status: 'failed' } });
1889
+ })
1890
+ .finally(() => clearTimeout(timer));
1891
+ return () => {
1892
+ cancelled = true;
1893
+ clearTimeout(timer);
1894
+ controller.abort();
1895
+ };
1896
+ }, [accessLookup, workspaceId, kbDirName]);
1897
+ // A folder delete asks which open change requests propose files in the
1898
+ // folder. It asks for EVERY knowledge-base folder: the shared list may still
1899
+ // be loading, or have failed, and its silence is not "no proposals". A
1900
+ // folder the list shows no proposals under opens the plain dialog at once
1901
+ // (its Delete is "Delete current content only") and switches to the three-way one
1902
+ // if the answer names requests. Keyed by the request it answers.
1903
+ const [proposalsAnswer, setProposalsAnswer] = useState<
1904
+ { request: TreeConfirmRequest; proposals: FolderProposals } | null
1905
+ >(null);
1906
+ const deleteFolder =
1907
+ confirmRequest?.kind === 'delete' && confirmRequest.entry.type === 'directory' && kbDirName
1908
+ && confirmRequest.entry.relativePath.startsWith(`${kbDirName}/`)
1909
+ ? confirmRequest
1910
+ : null;
1911
+ const folderHasProposals =
1912
+ deleteFolder !== null
1913
+ && [...openChangeRequests.paths].some((p) => p.startsWith(`${deleteFolder.entry.relativePath}/`));
1914
+ const answered = proposalsAnswer && proposalsAnswer.request === confirmRequest ? proposalsAnswer.proposals : null;
1915
+ const folderProposals: FolderProposals = folderHasProposals
1916
+ ? (answered ?? { status: 'loading' })
1917
+ // With no proposals in the list, only an answer that names requests
1918
+ // changes the dialog; a failed check has nothing to warn about.
1919
+ : answered?.status === 'ready' && answered.requests.length > 0
1920
+ ? answered
1921
+ : { status: 'none' };
1922
+ useEffect(() => {
1923
+ if (!deleteFolder || !kbDirName) return;
1924
+ let cancelled = false;
1925
+ listChangeRequestsUnderFolder(deleteFolder.entry.relativePath.slice(kbDirName.length + 1))
1926
+ .then((requests) => {
1927
+ if (!cancelled) setProposalsAnswer({ request: deleteFolder, proposals: { status: 'ready', requests } });
1928
+ })
1929
+ .catch((err) => {
1930
+ console.warn('[FileExplorer] change requests under folder:', err);
1931
+ if (!cancelled) setProposalsAnswer({ request: deleteFolder, proposals: { status: 'failed' } });
1932
+ });
1933
+ return () => { cancelled = true; };
1934
+ }, [deleteFolder, kbDirName]);
1935
+ const closeConfirm = (andRun: boolean, mode: DeleteMode = 'folder-only') => {
1936
+ if (!confirmRequest) return;
1937
+ focusAfterConfirm.current = andRun ? confirmRequest.focusAfterRun : confirmRequest.returnFocusTo;
1938
+ setOpenConfirm(null);
1939
+ if (!andRun) return;
1940
+ if (mode === 'with-proposals' && confirmRequest.kind === 'delete' && confirmRequest.runWithProposals) {
1941
+ void confirmRequest.runWithProposals();
1942
+ } else {
1943
+ void confirmRequest.run();
1944
+ }
1945
+ };
1946
+ // Focus goes back to the row once the dialog has unmounted — after the
1947
+ // Dialog's own restore, which would otherwise hand it to the (gone) menu.
1948
+ useEffect(() => {
1949
+ if (confirmRequest || !focusAfterConfirm.current) return;
1950
+ focusAfterConfirm.current()?.focus();
1951
+ focusAfterConfirm.current = null;
1952
+ }, [confirmRequest]);
1953
+
1954
+ return (
1955
+ <>
1956
+ <TreeConfirmContext.Provider value={askConfirm}>
1957
+ <TreeNavContext.Provider value={nav}>
1958
+ <UploadTargetContext.Provider value={uploadTarget}>
1959
+ <PinnedContext.Provider value={pinned ?? NO_PINNING}>
1960
+ <ManageAccessContext.Provider value={openAccess}>
1961
+ <SuggestionsContext.Provider value={suggestionsController}>
1962
+ {children}
1963
+ </SuggestionsContext.Provider>
1964
+ </ManageAccessContext.Provider>
1965
+ </PinnedContext.Provider>
1966
+ </UploadTargetContext.Provider>
1967
+ </TreeNavContext.Provider>
1968
+ </TreeConfirmContext.Provider>
1969
+ {confirmRequest && (
1970
+ <TreeActionConfirmDialog
1971
+ request={confirmRequest}
1972
+ warnings={
1973
+ confirmRequest.kind === 'move'
1974
+ ? moveWarnings({ ...confirmRequest, kbDirName, canWrite: destinationWritable, isAdmin })
1975
+ : []
1976
+ }
1977
+ accessChange={moveAccessChange}
1978
+ proposals={folderProposals}
1979
+ onCancel={() => closeConfirm(false)}
1980
+ onConfirm={(mode) => closeConfirm(true, mode)}
1981
+ />
1982
+ )}
1983
+ {openSuggestion && (
1984
+ <ChangeRequestDialog
1985
+ // Remounted when the query names a different file, so the seeded
1986
+ // selection below is re-read instead of being a one-time landing.
1987
+ key={`${openSuggestion.cr.number}:${openSuggestion.file}`}
1988
+ cr={openSuggestion.cr}
1989
+ initialPath={openSuggestion.file}
1990
+ onClose={() => setOpenSuggestion(null)}
1991
+ onResolved={() => {
1992
+ setOpenSuggestion(null);
1993
+ window.dispatchEvent(new Event(PR_STALE_EVENT));
1994
+ }}
1995
+ />
1996
+ )}
1997
+ {accessTarget && (
1998
+ <ManageAccessDialog
1999
+ key={`${accessTarget.relativePath}@${accessProposal?.branch ?? ''}`}
2000
+ entry={accessTarget}
2001
+ proposal={accessProposal}
2002
+ // The dialog is keyed on the path, so pointing it at a parent remounts
2003
+ // it against that folder, on the same branch the grant was read on.
2004
+ onManageAncestor={(ancestor) => {
2005
+ setInheritedProposal(accessProposal);
2006
+ setAccessTarget(ancestor);
2007
+ }}
2008
+ onClose={() => {
2009
+ setInheritedProposal(undefined);
2010
+ setAccessTarget(null);
2011
+ }}
2012
+ />
2013
+ )}
2014
+ </>
1025
2015
  );
2016
+ }
2017
+
2018
+ /** Shown when the read filter kept entries out and none are left on screen. */
2019
+ export const NOTHING_SHARED_MESSAGE = 'Nothing here is shared with you yet. Ask an admin to grant you access.';
2020
+ /** Shown when the knowledge base has nothing in it at all. */
2021
+ export const KB_EMPTY_MESSAGE = 'This knowledge base is empty.';
2022
+ /**
2023
+ * Shown when `<kbDirName>/` is not in the workspace tree at all. Not the same
2024
+ * emptiness as the one above: the knowledge base is not empty, it is not
2025
+ * THERE, and the next step is an operator's (the clone failed, or the
2026
+ * deployment names a folder that was never checked out) rather than a
2027
+ * writer's. Before this existed the sidebars guessed a root instead, and
2028
+ * rendered whatever directory happened to sit beside the missing one.
2029
+ */
2030
+ export const CHECKOUT_MISSING_MESSAGE = 'Nothing to show here: the repository checkout is missing.';
2031
+
2032
+ /**
2033
+ * Why a tree has nothing in it, when it has nothing in it. Read is
2034
+ * default-deny, so an empty sidebar has two causes that look identical and
2035
+ * call for different next steps: the caller may read none of what exists
2036
+ * (ask an admin), or nothing exists yet (make something — said only to a
2037
+ * caller who may write at `rootPath`, the surface's root folder).
2038
+ *
2039
+ * Renders nothing while the tree loads and once a single entry is visible.
2040
+ * The Knowledge explorer and the Library's trees both render it, from the
2041
+ * same merged listing, so they give the same answer — each for what IT shows.
2042
+ * Knowledge shows the knowledge base (`scope: 'tree'`, the default: the
2043
+ * reserved roots aside, an entry anywhere counts, because a stray top-level
2044
+ * folder is folded into Knowledge). A Library tree shows one root
2045
+ * (`scope: 'root'`): it is empty when that root is, whatever the notes
2046
+ * beside it hold.
2047
+ */
2048
+ export function EmptyTreeNotice({ rootPath, scope = 'tree' }: { rootPath: string | null; scope?: 'tree' | 'root' }) {
2049
+ const { kbDirName } = useWorkspace();
2050
+ const { tree, withheld: listingWithheld } = useMergedWorkspaceTree();
2051
+ const oneRoot = scope === 'root' && rootPath !== null;
2052
+ const empty = tree !== null && (oneRoot ? !subtreeHasVisibleEntries(tree, rootPath) : !treeHasVisibleEntries(tree, kbDirName));
2053
+ // What was kept out of what THIS notice covers: one root's own count, or
2054
+ // the listing's — a Skills tree emptied by the rules says so; a Skills tree
2055
+ // that is simply empty beside a withheld Knowledge does not.
2056
+ const withheld = oneRoot ? subtreeWithheld(tree, rootPath) : listingWithheld;
2057
+ // Asked only when the message would carry the hint: a withheld tree never does.
2058
+ const canWrite = useCanWriteFolder(empty && withheld === 0 ? rootPath : null);
2059
+ if (!empty) return null;
2060
+ if (withheld > 0) {
2061
+ return (
2062
+ <div data-testid="tree-empty-notice" role="status" className="px-3 py-2 text-xs text-ink-muted">
2063
+ {NOTHING_SHARED_MESSAGE}
2064
+ </div>
2065
+ );
2066
+ }
2067
+ // After the withheld check, not before: a reader who may open nothing sees
2068
+ // a tree the filter emptied, and "the checkout is missing" would be a
2069
+ // diagnosis of the wrong thing. Only a tree nothing was kept out of can
2070
+ // say the folder is genuinely not there.
2071
+ if (checkoutRoot(tree, kbDirName) === null) {
2072
+ return (
2073
+ <div data-testid="tree-empty-notice" role="status" className="px-3 py-2 text-xs text-ink-muted">
2074
+ {CHECKOUT_MISSING_MESSAGE}
2075
+ </div>
2076
+ );
2077
+ }
2078
+ return (
2079
+ <div data-testid="tree-empty-notice" role="status" className="px-3 py-2 text-xs text-ink-muted">
2080
+ {KB_EMPTY_MESSAGE}
2081
+ {canWrite && (
2082
+ <>
2083
+ {' '}
2084
+ <span data-testid="tree-empty-create-hint">
2085
+ Use New file or New folder on the folder above, or drop files here.
2086
+ </span>
2087
+ </>
2088
+ )}
2089
+ </div>
2090
+ );
2091
+ }
2092
+
2093
+ /**
2094
+ * Whether the caller may write into a workspace-relative folder; false until
2095
+ * known, and on a failed lookup — it decides a hint, never a gate. The same
2096
+ * short-circuits as `useFileAccess`: a path outside the KB and a draft branch
2097
+ * are writable without asking.
2098
+ */
2099
+ function useCanWriteFolder(workspacePath: string | null): boolean {
2100
+ const { workspaceId, kbDirName } = useWorkspace();
2101
+ const [answer, setAnswer] = useState<{ key: string; canWrite: boolean } | null>(null);
2102
+ const prefix = kbDirName ? `${kbDirName}/` : null;
2103
+ const key = workspacePath && workspaceId && prefix ? `${workspaceId}|${workspacePath}` : null;
2104
+ // The KB clone's own folder (a tree that predates the split) is the repo
2105
+ // root: inside the KB, and sent as-is — the server reads a bare kbDirName as ''.
2106
+ const isKbRoot = workspacePath !== null && workspacePath === kbDirName;
2107
+ const shortCircuit =
2108
+ key !== null &&
2109
+ ((!isKbRoot && !workspacePath!.startsWith(prefix!)) || !isProtectedBranch(decodeURIComponent(workspaceId!)));
2110
+ useEffect(() => {
2111
+ if (key === null || shortCircuit) return;
2112
+ let cancelled = false;
2113
+ fetchFileAccess(workspaceId!, isKbRoot ? workspacePath! : workspacePath!.slice(prefix!.length), 'folder')
2114
+ .then((res) => { if (!cancelled) setAnswer({ key, canWrite: res.canWrite }); })
2115
+ .catch(() => { if (!cancelled) setAnswer({ key, canWrite: false }); });
2116
+ return () => { cancelled = true; };
2117
+ }, [key, shortCircuit, isKbRoot, workspaceId, workspacePath, prefix]);
2118
+ if (key === null) return false;
2119
+ if (shortCircuit) return true;
2120
+ return answer?.key === key && answer.canWrite;
2121
+ }
2122
+
2123
+ /**
2124
+ * The upload banners for THIS tree: the last upload's error, or its one
2125
+ * non-error notice (the upload is under way, or it landed on the suggestions
2126
+ * branch). Every tree that can upload renders a pair, because the state is
2127
+ * the workspace's and a drop into a tree with no banner would fail — or
2128
+ * succeed elsewhere — in silence. Each pair shows only the banners stamped
2129
+ * with its own `uploadTarget`, which is what keeps one drop from painting
2130
+ * the same notice in both of the Library sidebar's trees.
2131
+ *
2132
+ * The error says everything in the banner, on as many lines as it takes:
2133
+ * the file's name, the server's reason in full, and what to do next. It used
2134
+ * to be one `truncate`d line with the reason in a `title` — a tooltip nobody
2135
+ * on a touch device could open, over text that had already cut the reason off.
2136
+ */
2137
+ export function UploadNotices() {
2138
+ const { uploadErrors, clearUploadError, uploadNotices, clearUploadNotice } = useWorkspace();
2139
+ const target = useUploadTarget();
2140
+ const error = uploadErrors.get(target) ?? null;
2141
+ const notice = uploadNotices.get(target) ?? null;
2142
+ return (
2143
+ <>
2144
+ {error && (
2145
+ <div
2146
+ role="alert"
2147
+ className="flex items-start gap-1 px-2 py-1 text-xs text-danger bg-danger-soft border-b border-danger/30 shrink-0"
2148
+ >
2149
+ <div className="flex-1 min-w-0 space-y-0.5 whitespace-pre-wrap break-words">
2150
+ <div className="font-medium">Couldn't add {error.filename}</div>
2151
+ <div>{error.reason}</div>
2152
+ <div className="text-ink-muted">{uploadErrorNextStep(error.status)}</div>
2153
+ </div>
2154
+ <IconButton
2155
+ size={18}
2156
+ tone="danger"
2157
+ title="Dismiss"
2158
+ aria-label="Dismiss upload error"
2159
+ onClick={() => clearUploadError(target)}
2160
+ >
2161
+ <X size={12} />
2162
+ </IconButton>
2163
+ </div>
2164
+ )}
2165
+ {/* Either "this is happening" or "it LANDED, on the suggestions
2166
+ branch". Both are load-bearing: a suggestion-routed upload puts
2167
+ nothing in the tree where the user dropped the files, and silence
2168
+ there reads as a failed upload. */}
2169
+ {notice && (
2170
+ <div
2171
+ role="status"
2172
+ data-testid="upload-notice"
2173
+ className="flex items-start gap-1 px-2 py-1 text-xs text-ink bg-wait-soft border-b border-line shrink-0"
2174
+ >
2175
+ <span className="flex-1 min-w-0 whitespace-pre-wrap break-words">{notice.message}</span>
2176
+ {/* Nothing to dismiss about an upload still running — it clears
2177
+ itself the moment it has a result to show instead. */}
2178
+ {notice.kind !== 'progress' && (
2179
+ <IconButton
2180
+ size={18}
2181
+ title="Dismiss"
2182
+ aria-label="Dismiss upload notice"
2183
+ onClick={() => clearUploadNotice(target)}
2184
+ >
2185
+ <X size={12} />
2186
+ </IconButton>
2187
+ )}
2188
+ </div>
2189
+ )}
2190
+ </>
2191
+ );
2192
+ }
2193
+
2194
+ // (`checkoutRoot` lives in `../utils/fileTree` — the one lookup every
2195
+ // surface that reads the workspace tree goes through.)
2196
+
2197
+ export function FileExplorer() {
2198
+ const { openFilePath, dispatchUpload, kbDirName } = useWorkspace();
2199
+ const { openFile } = useFileNav();
2200
+ const [dragOver, setDragOver] = useState(false);
2201
+ // Download is a per-path permission (resolved server-side from the access
2202
+ // tree's `download:` verb), so there is no global gate here: the menu asks
2203
+ // about the entry it was opened on (`useDownloadVerdict`) and disables the
2204
+ // item with the reason. A 403 that still lands — the permission changed
2205
+ // while the menu was open — becomes the row's own inline notice.
2206
+ const { tree: mergedTree, suggestionOnlyPaths } = useMergedWorkspaceTree();
2207
+ // THE root, for every row this explorer draws: the repository checkout, by
2208
+ // the name the deployment gave it. Nothing beside it in the workspace — a
2209
+ // stray `KnowledgeBase/`, a loose upload, another clone — is reachable from
2210
+ // anything below, because nothing above the checkout is ever read. Null
2211
+ // when the workspace holds no checkout, which is its own empty state
2212
+ // rather than a cue to go looking for a root that looks about right.
2213
+ const checkout = useMemo(() => checkoutRoot(mergedTree, kbDirName), [mergedTree, kbDirName]);
2214
+ // The pane workspace's own navigation: the open tab is the current row, and
2215
+ // a click opens the file on the checked-out branch.
2216
+ const nav = useMemo<TreeNav>(() => ({ activePath: openFilePath, open: openFile }), [openFilePath, openFile]);
1026
2217
 
1027
2218
  // Pinned folders — a personal, client-side shortcut list surfaced at the top
1028
2219
  // of the explorer. Stored as relativePaths in localStorage; toggled from the
@@ -1040,19 +2231,22 @@ export function FileExplorer() {
1040
2231
  });
1041
2232
  }, []);
1042
2233
  const pinnedController = useMemo<PinnedController>(
1043
- () => ({ isPinned: (path) => pinnedPaths.includes(path), togglePin }),
2234
+ () => ({ available: true, isPinned: (path) => pinnedPaths.includes(path), togglePin }),
1044
2235
  [pinnedPaths, togglePin],
1045
2236
  );
1046
2237
  // Resolve pinned paths to live tree entries, dropping any that no longer
1047
2238
  // exist on this branch (a folder pinned elsewhere may be absent here).
2239
+ // Resolved from the CHECKOUT, not the workspace root, for the same reason
2240
+ // the sections are: a pin is a shortcut into the repository, and a path
2241
+ // that lands beside it resolves to nothing rather than to a row.
1048
2242
  const pinnedEntries = useMemo(
1049
2243
  () =>
1050
- mergedTree
2244
+ checkout
1051
2245
  ? pinnedPaths
1052
- .map((p) => findEntryByPath(mergedTree, p))
2246
+ .map((p) => findEntryByPath(checkout, p))
1053
2247
  .filter((e): e is FileTreeEntry => e != null)
1054
2248
  : [],
1055
- [mergedTree, pinnedPaths],
2249
+ [checkout, pinnedPaths],
1056
2250
  );
1057
2251
 
1058
2252
  // Registry-contributed rows for the Pinned section (rendered below the
@@ -1061,9 +2255,6 @@ export function FileExplorer() {
1061
2255
  // ships none of its own.
1062
2256
  const { explorerItems } = useAppRegistry();
1063
2257
 
1064
- // Right-click → Manage access opens this sheet for the chosen entry.
1065
- const [accessTarget, setAccessTarget] = useState<FileTreeEntry | null>(null);
1066
-
1067
2258
  // KB content splits into separate top-level folders; surface them as labelled
1068
2259
  // sections rather than a single flat root. The Knowledge section hoists
1069
2260
  // `KnowledgeBase/`'s children and folds in any other top-level content folder
@@ -1079,13 +2270,15 @@ export function FileExplorer() {
1079
2270
  // from the plugin page. Deep links into a plugin file still resolve; the
1080
2271
  // folder just is not a browsing destination in Knowledge.
1081
2272
  //
2273
+ // `Skills/` neither: the Skills & Tools sidebar renders that root as its
2274
+ // own tree (`SkillsTree`), with these same rows, and a skill file opens on
2275
+ // its skill page there.
2276
+ //
1082
2277
  // `Data/`, `Agents/` and `Pipelines/` are rendered when PRESENT but never
1083
2278
  // created by core (see `CORE_REQUIRED_DIRS`) — a deployment that owns the
1084
2279
  // agentic execution layer seeds them, and this reads whatever is there.
1085
2280
  const sections = useMemo(() => {
1086
- // Descend past the workspace / KB-clone wrapper levels to the node that
1087
- // actually holds the well-known root dirs, then split that level.
1088
- const kids = findKbRoot(mergedTree)?.children;
2281
+ const kids = checkout?.children;
1089
2282
  if (!kids) return null;
1090
2283
  const findDir = (name: string) =>
1091
2284
  kids.find((c) => c.type === 'directory' && c.name === name);
@@ -1098,7 +2291,9 @@ export function FileExplorer() {
1098
2291
  // without it a KB whose only root is Plugins would fail this check, fall
1099
2292
  // back to the flat tree, and show the folder that way instead.
1100
2293
  const plugins = findDir(PLUGINS_DIR);
1101
- if (!knowledgeBase && !data && !agents && !pipelines && !plugins) return null;
2294
+ // Same for Skills: the Library surface renders it, not this explorer.
2295
+ const skills = findDir(SKILLS_DIR);
2296
+ if (!knowledgeBase && !data && !agents && !pipelines && !plugins && !skills) return null;
1102
2297
  // Any other top-level content folder (e.g. a stray `Legal/`) folds into Knowledge.
1103
2298
  const otherDirs = kids.filter(
1104
2299
  (c) => c.type === 'directory' && !KB_ROOT_DIRS.has(c.name),
@@ -1128,27 +2323,37 @@ export function FileExplorer() {
1128
2323
  pipelines: pipelinesRoot,
1129
2324
  looseFiles: kids.filter((c) => c.type === 'file'),
1130
2325
  };
1131
- }, [mergedTree]);
2326
+ }, [checkout]);
1132
2327
 
1133
2328
  const handleDrop = useCallback(
1134
2329
  (e: React.DragEvent) => {
2330
+ // Nothing to drop INTO: the tree below renders no row and says the
2331
+ // checkout is missing, and this drop used to be sent with an empty
2332
+ // target — the workspace root, beside the missing folder, where
2333
+ // nothing this sidebar shows can ever live. Refused before
2334
+ // `preventDefault`, so the browser's own cursor says "not here".
2335
+ if (!checkout) return;
1135
2336
  e.preventDefault();
1136
2337
  setDragOver(false);
1137
2338
  // Only handle external file/folder drops at the root level.
1138
2339
  if (e.dataTransfer.getData(DRAG_MIME)) return;
2340
+ // The background of the tree is the tree's ROOT — the checkout — not
2341
+ // the workspace directory that happens to contain it.
2342
+ const target = checkout.relativePath;
1139
2343
  const entries = e.dataTransfer.items ? snapshotEntries(e.dataTransfer.items) : [];
1140
2344
  if (entries.length > 0) {
1141
- dispatchUpload({ kind: 'items', entries }, '');
2345
+ // Outside the `TreeChrome` below, so this one names the tree itself.
2346
+ dispatchUpload({ kind: 'items', entries }, target, KNOWLEDGE_UPLOAD_TARGET);
1142
2347
  return;
1143
2348
  }
1144
2349
  const files = Array.from(e.dataTransfer.files);
1145
- if (files.length > 0) dispatchUpload({ kind: 'files', files }, '');
2350
+ if (files.length > 0) dispatchUpload({ kind: 'files', files }, target, KNOWLEDGE_UPLOAD_TARGET);
1146
2351
  },
1147
- [dispatchUpload],
2352
+ [checkout, dispatchUpload],
1148
2353
  );
1149
2354
 
1150
2355
  return (
1151
- <>
2356
+ <TreeChrome nav={nav} suggestionOnlyPaths={suggestionOnlyPaths} pinned={pinnedController}>
1152
2357
  {/* No background, no border, no width: this is the CONTENTS of the app's
1153
2358
  one sidebar, and `SidebarFrame` is the sidebar. It used to be
1154
2359
  `bg-white` against the Library's `bg-sidebar`, which is how two navs in
@@ -1164,6 +2369,9 @@ export function FileExplorer() {
1164
2369
  }`}
1165
2370
  onDrop={handleDrop}
1166
2371
  onDragOver={(e) => {
2372
+ // Same refusal as the drop: no checkout, no drop target, so no
2373
+ // highlight promising one.
2374
+ if (!checkout) return;
1167
2375
  e.preventDefault();
1168
2376
  setDragOver(true);
1169
2377
  }}
@@ -1172,49 +2380,7 @@ export function FileExplorer() {
1172
2380
  setDragOver(false);
1173
2381
  }}
1174
2382
  >
1175
- {uploadError && (
1176
- <div
1177
- role="alert"
1178
- className="flex items-start gap-1 px-2 py-1 text-xs text-danger bg-danger-soft border-b border-danger/30 shrink-0"
1179
- >
1180
- <span className="flex-1 truncate" title={uploadError.reason}>
1181
- Couldn't add {uploadError.filename}: {uploadError.reason}
1182
- </span>
1183
- <IconButton
1184
- size={18}
1185
- tone="danger"
1186
- title="Dismiss"
1187
- aria-label="Dismiss upload error"
1188
- onClick={clearUploadError}
1189
- >
1190
- <X size={12} />
1191
- </IconButton>
1192
- </div>
1193
- )}
1194
- {/* Not an error: the upload LANDED, on the suggestions branch. Saying
1195
- so is load-bearing — nothing appears in the tree where the user
1196
- dropped the files, and silence there reads as a failed upload. */}
1197
- {uploadNotice && (
1198
- <div
1199
- role="status"
1200
- className="flex items-start gap-1 px-2 py-1 text-xs text-ink bg-wait-soft border-b border-line shrink-0"
1201
- >
1202
- <span className="flex-1" title={uploadNotice}>
1203
- {uploadNotice}
1204
- </span>
1205
- <IconButton
1206
- size={18}
1207
- title="Dismiss"
1208
- aria-label="Dismiss upload notice"
1209
- onClick={clearUploadNotice}
1210
- >
1211
- <X size={12} />
1212
- </IconButton>
1213
- </div>
1214
- )}
1215
- <PinnedContext.Provider value={pinnedController}>
1216
- <ManageAccessContext.Provider value={setAccessTarget}>
1217
- <SuggestionsContext.Provider value={suggestionsController}>
2383
+ <UploadNotices />
1218
2384
  <div className="flex-1 overflow-y-auto min-h-0">
1219
2385
  {/* "Company Context", not "Pinned". The mechanism is pinning; the
1220
2386
  SECTION is the handful of places this company actually works out
@@ -1233,6 +2399,10 @@ export function FileExplorer() {
1233
2399
  <div className="mx-3 my-2 border-t border-line" />
1234
2400
  {!mergedTree ? (
1235
2401
  <div className="px-3 py-4 text-xs text-ink-muted">Loading...</div>
2402
+ ) : !checkout ? (
2403
+ // No checkout in the workspace: no tree, and no guessing at one
2404
+ // from whatever else is there. `EmptyTreeNotice` below says why.
2405
+ null
1236
2406
  ) : sections ? (
1237
2407
  <>
1238
2408
  {sections.knowledge && (
@@ -1257,34 +2427,24 @@ export function FileExplorer() {
1257
2427
  )}
1258
2428
  </>
1259
2429
  ) : (
1260
- <FileTreeNode entry={mergedTree} depth={0} />
2430
+ // A clone that predates the split: no named roots to section by, so
2431
+ // the checkout folder itself is the tree. Still the checkout — the
2432
+ // fallback is a different SHAPE, never a different directory — and
2433
+ // it is the ROOT row, not a folder inside one: the workspace
2434
+ // directory above it is not something this explorer shows.
2435
+ <FileTreeNode entry={checkout} depth={0} root />
1261
2436
  )}
2437
+ {/* Under the (empty) roots, so the hint's "folder above" is on
2438
+ screen: Knowledge's own folder is where a first page goes. A tree
2439
+ that predates the split has no Knowledge section, so the checkout
2440
+ folder itself is where a first page goes — and when there is no
2441
+ checkout at all the notice says THAT instead, and there is no
2442
+ folder to offer. */}
2443
+ <EmptyTreeNotice
2444
+ rootPath={sections ? sections.knowledge?.relativePath ?? null : checkout?.relativePath ?? null}
2445
+ />
1262
2446
  </div>
1263
- </SuggestionsContext.Provider>
1264
- </ManageAccessContext.Provider>
1265
- </PinnedContext.Provider>
1266
- <PullRequestsForMe />
1267
2447
  </div>
1268
- {openSuggestionCr && (
1269
- <ChangeRequestDialog
1270
- cr={openSuggestionCr}
1271
- onClose={() => setOpenSuggestionCr(null)}
1272
- onResolved={() => {
1273
- setOpenSuggestionCr(null);
1274
- window.dispatchEvent(new Event(PR_STALE_EVENT));
1275
- }}
1276
- />
1277
- )}
1278
- {accessTarget && (
1279
- <ManageAccessDialog
1280
- key={accessTarget.relativePath}
1281
- entry={accessTarget}
1282
- // The dialog is keyed on the path, so pointing it at a parent remounts
1283
- // it against that folder — the whole retarget is this one setter.
1284
- onManageAncestor={setAccessTarget}
1285
- onClose={() => setAccessTarget(null)}
1286
- />
1287
- )}
1288
- </>
2448
+ </TreeChrome>
1289
2449
  );
1290
2450
  }