@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -5,7 +5,12 @@ import {
5
5
  listOpenChangeRequests,
6
6
  } from '../../change-requests/services/change-requests.api';
7
7
  import { useWorkspace } from './workspace.context';
8
- import { PR_STALE_EVENT, SUGGESTIONS_OPTIMISTIC_EVENT } from '../../../core/events';
8
+ import {
9
+ PR_STALE_FALLBACK_MS,
10
+ SUGGESTIONS_OPTIMISTIC_EVENT,
11
+ SUGGESTIONS_RETRACTED_EVENT,
12
+ subscribePrStale,
13
+ } from '../../../core/events';
9
14
  import {
10
15
  NO_CHANGE_REQUESTS,
11
16
  OpenChangeRequestsContext,
@@ -62,10 +67,45 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
62
67
  * moment it exists.
63
68
  */
64
69
  const [announced, setAnnounced] = useState<{ cr: PullRequestSummary; at: number }[]>([]);
70
+ /**
71
+ * The other direction: folders whose proposed files the client just took
72
+ * out of every request (a folder delete). Paths under one are hidden until
73
+ * BOTH lists have answered from a fetch that started after the retraction —
74
+ * `answeredFrom` holds each list's latest answered start. Ordered by a
75
+ * counter, not the clock: the retraction and its refetch happen in the same
76
+ * tick, and two equal `Date.now()` stamps would keep the folder hidden
77
+ * after the refetch answered. (The server has finished removing the files
78
+ * before the event fires, so any fetch that starts later is the truth.) A
79
+ * failed fetch answers too: it empties its list, so nothing stale is left
80
+ * to hide, and a token that outlived its refetch would hide proposals made
81
+ * under the folder later.
82
+ */
83
+ const [retracted, setRetracted] = useState<{ prefix: string; at: number }[]>([]);
84
+ const [answeredFrom, setAnsweredFrom] = useState({ all: 0, mine: 0 });
65
85
 
66
86
  useEffect(() => {
67
87
  let cancelled = false;
88
+ /** Strictly increasing order of retractions and fetch starts. */
89
+ let order = 0;
90
+ /**
91
+ * The latest fetch start each list has applied. Loads overlap — the
92
+ * fallback poll, a stale event, a tab coming back into view, a
93
+ * retraction — and an answer from an older fetch that lands after a newer
94
+ * one is dropped: it would put an applied request's markers back in the
95
+ * tree, or predate a retraction whose hide token the newer answer already
96
+ * lifted and bring the removed proposals back. Per list, since the two
97
+ * requests settle apart.
98
+ */
99
+ const applied = { all: 0, mine: 0 };
100
+ const supersedes = (list: 'all' | 'mine', startedOrder: number) => {
101
+ if (cancelled || startedOrder < applied[list]) return false;
102
+ applied[list] = startedOrder;
103
+ return true;
104
+ };
105
+ const answer = (list: 'all' | 'mine', startedOrder: number) =>
106
+ setAnsweredFrom((prev) => ({ ...prev, [list]: Math.max(prev[list], startedOrder) }));
68
107
  const load = (opts: { fresh?: boolean } = {}) => {
108
+ const startedOrder = ++order;
69
109
  // When THIS fetch left the building — only a fetch that STARTED after
70
110
  // an announcement may declare its request gone. The announce and the
71
111
  // stale event fire in the same tick, so a same-tick fresh fetch can
@@ -74,19 +114,24 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
74
114
  const startedAt = Date.now();
75
115
  listOpenChangeRequests(opts)
76
116
  .then((data) => {
77
- if (!cancelled) setRequests(data);
117
+ if (!supersedes('all', startedOrder)) return;
118
+ setRequests(data);
119
+ answer('all', startedOrder);
78
120
  })
79
121
  .catch((err) => {
80
122
  // A queue that cannot load is not an error state on a page about a
81
123
  // document. The dots and the banner simply do not appear.
82
124
  console.warn('[OpenChangeRequests] load failed:', err);
83
- if (!cancelled) setRequests([]);
125
+ if (!supersedes('all', startedOrder)) return;
126
+ setRequests([]);
127
+ answer('all', startedOrder);
84
128
  });
85
129
  listMyChangeRequests(opts)
86
130
  .then((data) => {
87
- if (cancelled) return;
131
+ if (!supersedes('mine', startedOrder)) return;
88
132
  const open = data.filter((c) => c.state === 'open');
89
133
  setMine(open);
134
+ answer('mine', startedOrder);
90
135
  // Reconcile: an announced entry whose every path the real list now
91
136
  // carries has been overtaken; one whose request is GONE (declined,
92
137
  // merged, withdrawn elsewhere) must not haunt the tree either — but
@@ -104,7 +149,9 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
104
149
  .catch((err) => {
105
150
  // Same degradation contract: no suggestion rows, not an error page.
106
151
  console.warn('[OpenChangeRequests] mine load failed:', err);
107
- if (!cancelled) setMine([]);
152
+ if (!supersedes('mine', startedOrder)) return;
153
+ setMine([]);
154
+ answer('mine', startedOrder);
108
155
  });
109
156
  };
110
157
  load();
@@ -114,8 +161,23 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
114
161
  // the event fires because the sender KNOWS the list changed, and a cached
115
162
  // answer would hide exactly the change it is announcing (the suggestion
116
163
  // rows for a just-uploaded file would sit invisible until the TTL).
117
- const onStale = () => load({ fresh: true });
118
- window.addEventListener(PR_STALE_EVENT, onStale);
164
+ // Coalesced: one action can raise the event more than once (see
165
+ // `subscribePrStale`), and each used to be its own fresh request.
166
+ const offStale = subscribePrStale(() => load({ fresh: true }));
167
+ // The fallback for a stale event that never came. Stale events now follow
168
+ // the bus's merge / reject / apply-failed broadcasts, so a dropped bus
169
+ // event would otherwise leave an applied request's markers in this tree
170
+ // until a reload. Cached reads (a merge, a recorded refusal and a cleared
171
+ // one all evict the server's list cache, so the first read after any of
172
+ // them is already true), and only while visible — a
173
+ // hidden tab catches up the moment it is shown instead.
174
+ const reconcile = setInterval(() => {
175
+ if (!document.hidden) load();
176
+ }, PR_STALE_FALLBACK_MS);
177
+ const onVisible = () => {
178
+ if (!document.hidden) load();
179
+ };
180
+ document.addEventListener('visibilitychange', onVisible);
119
181
  const onAnnounce = (e: Event) => {
120
182
  const cr = (e as CustomEvent<PullRequestSummary>).detail;
121
183
  if (!cr || typeof cr.number !== 'number') return;
@@ -125,18 +187,44 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
125
187
  ]);
126
188
  };
127
189
  window.addEventListener(SUGGESTIONS_OPTIMISTIC_EVENT, onAnnounce);
190
+ const onRetract = (e: Event) => {
191
+ const folder = (e as CustomEvent<{ folder?: unknown }>).detail?.folder;
192
+ if (typeof folder !== 'string' || !folder) return;
193
+ const prefix = `${folder.replace(/\/+$/, '')}/`;
194
+ const at = ++order;
195
+ setRetracted((prev) => [...prev.filter((r) => r.prefix !== prefix), { prefix, at }]);
196
+ // An announced proposal under the folder is gone too.
197
+ setAnnounced((prev) =>
198
+ prev.map((a) => ({
199
+ ...a,
200
+ cr: { ...a.cr, touchedNodePaths: a.cr.touchedNodePaths.filter((p) => !p.startsWith(prefix)) },
201
+ })),
202
+ );
203
+ load({ fresh: true });
204
+ };
205
+ window.addEventListener(SUGGESTIONS_RETRACTED_EVENT, onRetract);
128
206
  return () => {
129
207
  cancelled = true;
130
- window.removeEventListener(PR_STALE_EVENT, onStale);
208
+ clearInterval(reconcile);
209
+ document.removeEventListener('visibilitychange', onVisible);
210
+ offStale();
131
211
  window.removeEventListener(SUGGESTIONS_OPTIMISTIC_EVENT, onAnnounce);
212
+ window.removeEventListener(SUGGESTIONS_RETRACTED_EVENT, onRetract);
132
213
  };
133
214
  }, []);
134
215
 
135
216
  const value = useMemo<OpenChangeRequests>(() => {
136
217
  if (!kbDirName) return NO_CHANGE_REQUESTS;
218
+ // A retraction stays in force until both lists answered from after it.
219
+ const answered = Math.min(answeredFrom.all, answeredFrom.mine);
220
+ const hidden = retracted.filter((r) => r.at > answered).map((r) => r.prefix);
221
+ const touched = (pr: PullRequestSummary) =>
222
+ hidden.length === 0
223
+ ? pr.touchedNodePaths
224
+ : pr.touchedNodePaths.filter((p) => !hidden.some((prefix) => p.startsWith(prefix)));
137
225
  const byPath = new Map<string, PullRequestSummary[]>();
138
226
  for (const pr of requests) {
139
- for (const repoRelative of pr.touchedNodePaths) {
227
+ for (const repoRelative of touched(pr)) {
140
228
  const workspaceRelative = `${kbDirName}/${repoRelative}`;
141
229
  const list = byPath.get(workspaceRelative);
142
230
  if (list) list.push(pr);
@@ -151,7 +239,7 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
151
239
  // fetch) would otherwise produce a row whose click does nothing.
152
240
  const announcedCrs = announced.map((a) => a.cr);
153
241
  for (const pr of [...mine, ...announcedCrs]) {
154
- for (const repoRelative of pr.touchedNodePaths) {
242
+ for (const repoRelative of touched(pr)) {
155
243
  const workspaceRelative = `${kbDirName}/${repoRelative}`;
156
244
  const list = byPath.get(workspaceRelative);
157
245
  if (!list) byPath.set(workspaceRelative, [pr]);
@@ -164,7 +252,7 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
164
252
  // untangle, so the row just links to the older one.
165
253
  const minePaths = new Map<string, number>();
166
254
  for (const pr of [...mine, ...announcedCrs]) {
167
- for (const repoRelative of pr.touchedNodePaths) {
255
+ for (const repoRelative of touched(pr)) {
168
256
  const workspaceRelative = `${kbDirName}/${repoRelative}`;
169
257
  if (!minePaths.has(workspaceRelative)) minePaths.set(workspaceRelative, pr.number);
170
258
  }
@@ -175,7 +263,7 @@ export function OpenChangeRequestsProvider({ children }: { children: ReactNode }
175
263
  minePaths,
176
264
  mineNumbers: new Set([...mine, ...announcedCrs].map((pr) => pr.number)),
177
265
  };
178
- }, [requests, mine, announced, kbDirName]);
266
+ }, [requests, mine, announced, retracted, answeredFrom, kbDirName]);
179
267
 
180
268
  return (
181
269
  <OpenChangeRequestsContext.Provider value={value}>
@@ -1,9 +1,61 @@
1
1
  import { createContext, useContext } from 'react';
2
2
  import type { FileTreeEntry } from '@bevel-software/platform-shared';
3
3
 
4
+ /**
5
+ * Which tree a drop landed in, so its banners can be shown THERE and only
6
+ * there. Every tree that accepts uploads declares one (`TreeChrome`'s
7
+ * `uploadTarget`) and hands it to `dispatchUpload`; `UploadNotices` renders
8
+ * only the banners carrying its own. The Library sidebar holds two of these
9
+ * trees (`Skills/` and `Plugins/`) and Knowledge holds one — over one shared
10
+ * piece of state an untargeted banner appeared once per tree, which is how
11
+ * the same "upload became a suggestion" notice showed up twice on one page.
12
+ */
13
+ export type UploadTarget = string;
14
+
15
+ /** The tree the Knowledge explorer is, and the default for any other caller. */
16
+ export const KNOWLEDGE_UPLOAD_TARGET: UploadTarget = 'knowledge';
17
+
18
+ /**
19
+ * The name of one of the Library sidebar's trees (`Skills/`, `Plugins/`).
20
+ * The `library:` prefix is a protocol between the tree that renders the
21
+ * banners and the dispatch that stamps them, so it is spelled once, here,
22
+ * rather than re-typed by every tree and every test: a tree that spelled it
23
+ * differently would draw no banners at all, which is the silent upload this
24
+ * whole module exists to prevent.
25
+ */
26
+ export function libraryUploadTarget(dir: string): UploadTarget {
27
+ return `library:${dir}`;
28
+ }
29
+
4
30
  export interface UploadError {
31
+ /** The file's NAME — what the user dropped, not its full workspace path. */
5
32
  filename: string;
33
+ /** The server's own words, shown in full rather than behind a tooltip. */
6
34
  reason: string;
35
+ /**
36
+ * HTTP status of the refusal, when it came from one — the discriminator
37
+ * `uploadErrorNextStep` uses to pick what to tell the user to do. Absent
38
+ * for failures that never reached a response (network, the folder walker),
39
+ * which get the generic next step.
40
+ */
41
+ status?: number;
42
+ }
43
+
44
+ /**
45
+ * The non-error news about an upload.
46
+ *
47
+ * `progress` is set the instant a drop is dispatched, BEFORE the suggestion
48
+ * routing round-trips (an ACL read, and on a first suggestion the branch
49
+ * creation plus its workspace clone). Without it the first suggestion-routed
50
+ * upload of a session is completely silent for as long as all that takes —
51
+ * and there are no optimistic rows either, because a suggestion-routed upload
52
+ * deliberately draws no overlay. That silence is what "I dropped a file and
53
+ * nothing happened" was. It is replaced by `suggestion`, or cleared, once the
54
+ * upload settles.
55
+ */
56
+ export interface UploadNotice {
57
+ kind: 'progress' | 'suggestion';
58
+ message: string;
7
59
  }
8
60
 
9
61
  /**
@@ -48,6 +100,25 @@ export interface OpenTab {
48
100
  pendingFileContent: string | null;
49
101
  }
50
102
 
103
+ /** What a `hydrateTabs` call read, and whether its result reached the strip. */
104
+ export interface HydrateResult {
105
+ /** Paths that were read successfully. */
106
+ surviving: string[];
107
+ /** Paths that 404'd — no longer on this branch. */
108
+ dropped: string[];
109
+ /** Paths that 403'd — the user may not read them. */
110
+ denied: string[];
111
+ /**
112
+ * True when this restore never took ownership of the tab strip: the
113
+ * workspace moved to another branch, or a newer restore started, while its
114
+ * reads were in flight. The paths above still describe what was read (so a
115
+ * deeplink can be classified), but nothing was applied — a caller tracking
116
+ * "this (workspace, branch) has been hydrated" must NOT record this one, or
117
+ * the branch's tabs are never restored and never persisted again.
118
+ */
119
+ superseded: boolean;
120
+ }
121
+
51
122
  export interface WorkspaceContextValue {
52
123
  workspaceId: string | null;
53
124
  /**
@@ -59,6 +130,30 @@ export interface WorkspaceContextValue {
59
130
  */
60
131
  kbDirName: string | null;
61
132
  fileTree: FileTreeEntry | null;
133
+ /**
134
+ * Why the last workspace bootstrap failed, or null. A bootstrap that fails
135
+ * leaves `workspaceId` on whatever it was, so without this a route could
136
+ * only wait forever; `status` is the HTTP status the bootstrap answered
137
+ * (404: no branch by that name; 410: the branch no longer exists on the git
138
+ * host), 0 for a transport failure, and `message` is what the failure said,
139
+ * so a screen can name it rather than only naming the branch. Cleared by
140
+ * the next successful bootstrap and by `retryBootstrap`.
141
+ */
142
+ bootstrapError: { branch: string; status: number; message: string } | null;
143
+ /**
144
+ * The branch `workspaceId` actually is, or null before the first bootstrap
145
+ * lands. Distinct from the branch a route is NAVIGATING to: mid-switch, the
146
+ * URL names the destination and this still names the workspace on screen.
147
+ * Anything keyed "per branch" off the live workspace (tab persistence) must
148
+ * use this, or it crosses one branch's content with another's key.
149
+ */
150
+ workspaceBranch: string | null;
151
+ /**
152
+ * Re-run the bootstrap for the branch currently asked for. Clears
153
+ * `bootstrapError` and starts again — the recovery behind the file page's
154
+ * Retry, so a 500 or a dropped connection doesn't need a page reload.
155
+ */
156
+ retryBootstrap: () => void;
62
157
 
63
158
  /** All tabs currently open in the editor strip. */
64
159
  openTabs: OpenTab[];
@@ -105,20 +200,26 @@ export interface WorkspaceContextValue {
105
200
  */
106
201
  fsRevision: number;
107
202
  /**
108
- * Most recent upload error, surfaced inline in the file explorer for both
109
- * the toolbar button and drag-drop. Cleared on the next successful dispatch
110
- * or via `clearUploadError`.
203
+ * The last upload error in each tree, keyed by the tree that received the
204
+ * drop — see {@link UploadTarget}. Surfaced inline in that tree for both
205
+ * the toolbar button and drag-drop. A tree's entry is replaced on its next
206
+ * dispatch, or removed via `clearUploadError`. Keyed rather than a single
207
+ * slot because two of these trees share one sidebar: with one slot, a drop
208
+ * into `Plugins/` wiped the banner `Skills/` was still showing.
111
209
  */
112
- uploadError: UploadError | null;
210
+ uploadErrors: ReadonlyMap<UploadTarget, UploadError>;
113
211
  /**
114
- * Non-error news about the last upload — currently one message: the upload
115
- * went to the caller's suggestions branch because they cannot write the
116
- * target folder, and the files are now a change request, not tree content.
117
- * Without this the outcome is indistinguishable from a silently failed
118
- * upload: nothing appears where the user dropped the files.
212
+ * Non-error news about the last upload in each tree, keyed the same way as
213
+ * {@link WorkspaceContextValue.uploadErrors}: that it is under way, or that
214
+ * it went to the caller's suggestions branch because they cannot write the
215
+ * target folder and the files are now a change request rather than tree
216
+ * content. Without this the outcome is indistinguishable from a silently
217
+ * failed upload: nothing appears where the user dropped the files. Keyed,
218
+ * so one tree's drop settling never blanks the news another tree's drop is
219
+ * still waiting on.
119
220
  */
120
- uploadNotice: string | null;
121
- clearUploadNotice: () => void;
221
+ uploadNotices: ReadonlyMap<UploadTarget, UploadNotice>;
222
+ clearUploadNotice: (target: UploadTarget) => void;
122
223
  /** True while a `dispatchUpload` call is in flight; gates the toolbar button. */
123
224
  isUploading: boolean;
124
225
  /**
@@ -180,7 +281,7 @@ export interface WorkspaceContextValue {
180
281
  hydrateTabs: (
181
282
  paths: string[],
182
283
  activePath: string | null,
183
- ) => Promise<{ surviving: string[]; dropped: string[]; denied: string[] }>;
284
+ ) => Promise<HydrateResult>;
184
285
 
185
286
  createFile: (relativePath: string, content?: string) => Promise<void>;
186
287
  createDirectory: (relativePath: string) => Promise<void>;
@@ -201,15 +302,28 @@ export interface WorkspaceContextValue {
201
302
  uploadFiles: (files: File[], targetDirectory: string) => Promise<void>;
202
303
  /**
203
304
  * UI-facing entry point for uploads from drag-drop and file/folder pickers.
204
- * Captures errors into `uploadError`, toggles `isUploading`, drives
305
+ * Captures errors into `uploadErrors`, toggles `isUploading`, drives
205
306
  * `pendingUploads` for optimistic rendering, and (for `kind: 'items'`)
206
307
  * lazily walks dropped FileSystemEntries so uploads start before
207
308
  * enumeration finishes. Preserves empty subdirectories from folder drops
208
309
  * by creating them server-side after the file upload pass.
209
310
  */
210
- dispatchUpload: (input: UploadInput, targetDirectory: string) => Promise<void>;
211
- clearUploadError: () => void;
212
- deleteEntry: (relativePath: string) => Promise<void>;
311
+ dispatchUpload: (
312
+ input: UploadInput,
313
+ targetDirectory: string,
314
+ /**
315
+ * The tree the drop came from, so its banners appear beside the rows they
316
+ * explain — see {@link UploadTarget}. Omitted means the Knowledge
317
+ * explorer.
318
+ */
319
+ uploadTarget?: UploadTarget,
320
+ ) => Promise<void>;
321
+ clearUploadError: (target: UploadTarget) => void;
322
+ /**
323
+ * Delete this branch's copy of a file or folder. Resolves `false` when
324
+ * nothing was deleted because the user kept their unsaved tabs.
325
+ */
326
+ deleteEntry: (relativePath: string) => Promise<void | false>;
213
327
  moveEntry: (oldPath: string, newPath: string) => Promise<void>;
214
328
  saveFile: (relativePath: string, content: string) => Promise<void>;
215
329
  /**
@@ -0,0 +1,73 @@
1
+ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
2
+ import {
3
+ FILE_TRACE_STORAGE_KEY,
4
+ isFileTraceEnabled,
5
+ syncFileTraceFlag,
6
+ traceFiles,
7
+ } from '../file-trace';
8
+
9
+ beforeEach(() => {
10
+ sessionStorage.clear();
11
+ });
12
+
13
+ afterEach(() => {
14
+ vi.restoreAllMocks();
15
+ });
16
+
17
+ describe('file trace flag', () => {
18
+ it('is off by default and logs nothing', () => {
19
+ const info = vi.spyOn(console, 'info').mockImplementation(() => {});
20
+ expect(syncFileTraceFlag('')).toBe(false);
21
+ traceFiles('hydrate:start', { branchFromUrl: 'main' });
22
+ expect(info).not.toHaveBeenCalled();
23
+ });
24
+
25
+ it('turns on from ?trace=files and stays on for URLs without the query, as a tree click produces', () => {
26
+ expect(syncFileTraceFlag('?trace=files')).toBe(true);
27
+ expect(sessionStorage.getItem(FILE_TRACE_STORAGE_KEY)).toBe('1');
28
+ expect(syncFileTraceFlag('')).toBe(true);
29
+ expect(isFileTraceEnabled()).toBe(true);
30
+ });
31
+
32
+ it('turns off from ?trace=off', () => {
33
+ syncFileTraceFlag('?trace=files');
34
+ expect(syncFileTraceFlag('?trace=off')).toBe(false);
35
+ expect(isFileTraceEnabled()).toBe(false);
36
+ });
37
+
38
+ it('ignores other trace values', () => {
39
+ expect(syncFileTraceFlag('?trace=everything')).toBe(false);
40
+ });
41
+
42
+ it('stays on for the page load and still logs when sessionStorage is unavailable', () => {
43
+ const info = vi.spyOn(console, 'info').mockImplementation(() => {});
44
+ const unavailable = () => {
45
+ throw new DOMException('denied', 'SecurityError');
46
+ };
47
+ vi.spyOn(Storage.prototype, 'getItem').mockImplementation(unavailable);
48
+ vi.spyOn(Storage.prototype, 'setItem').mockImplementation(unavailable);
49
+ vi.spyOn(Storage.prototype, 'removeItem').mockImplementation(unavailable);
50
+ try {
51
+ expect(syncFileTraceFlag('?trace=files')).toBe(true);
52
+ expect(syncFileTraceFlag('')).toBe(true);
53
+ traceFiles('hydrate:start', { branchFromUrl: 'main' });
54
+ expect(info).toHaveBeenCalledTimes(1);
55
+ expect(syncFileTraceFlag('?trace=off')).toBe(false);
56
+ } finally {
57
+ // The in-memory flag outlives the spies; clear it for the next test.
58
+ syncFileTraceFlag('?trace=off');
59
+ }
60
+ });
61
+
62
+ it('logs the event and its fields under one prefix when on', () => {
63
+ const info = vi.spyOn(console, 'info').mockImplementation(() => {});
64
+ syncFileTraceFlag('?trace=files');
65
+ traceFiles('wait:branch-mismatch', { branchFromUrl: 'main', gitStatusBranch: 'alice/draft' });
66
+ expect(info).toHaveBeenCalledTimes(1);
67
+ const [prefix, event, fields] = info.mock.calls[0];
68
+ expect(prefix).toBe('[trace:files]');
69
+ expect(event).toBe('wait:branch-mismatch');
70
+ expect(fields).toMatchObject({ branchFromUrl: 'main', gitStatusBranch: 'alice/draft' });
71
+ expect(typeof (fields as { at: unknown }).at).toBe('number');
72
+ });
73
+ });