@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -1,6 +1,6 @@
1
1
  import { describe, it, expect, vi, beforeEach } from 'vitest';
2
2
  import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
3
- import { render, screen, act, fireEvent, waitFor } from '@testing-library/react';
3
+ import { render, screen, act, fireEvent, waitFor, within } from '@testing-library/react';
4
4
  import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
5
5
  import type { ReactNode } from 'react';
6
6
  import {
@@ -28,6 +28,8 @@ const pluginsMock = vi.hoisted(() => ({
28
28
  listJoinRequests: vi.fn(),
29
29
  reconcileJoinRequest: vi.fn(),
30
30
  requestPluginAccess: vi.fn(),
31
+ unlinkSkill: vi.fn(),
32
+ renamePlugin: vi.fn(),
31
33
  }));
32
34
  const libApiMock = vi.hoisted(() => ({ removeLibraryItem: vi.fn() }));
33
35
  vi.mock('../services/library.api', async (importOriginal) => ({
@@ -35,11 +37,14 @@ vi.mock('../services/library.api', async (importOriginal) => ({
35
37
  removeLibraryItem: libApiMock.removeLibraryItem,
36
38
  }));
37
39
 
40
+ vi.mock('../services/teams.api', () => ({ listTeams: vi.fn().mockResolvedValue([]) }));
38
41
  vi.mock('../services/plugins.api', () => ({
39
42
  listPlugins: pluginsMock.listPlugins,
40
43
  listJoinRequests: pluginsMock.listJoinRequests,
41
44
  reconcileJoinRequest: pluginsMock.reconcileJoinRequest,
42
45
  requestPluginAccess: pluginsMock.requestPluginAccess,
46
+ unlinkSkill: pluginsMock.unlinkSkill,
47
+ renamePlugin: pluginsMock.renamePlugin,
43
48
  AlreadyReadableError: class AlreadyReadableError extends Error {},
44
49
  }));
45
50
 
@@ -52,12 +57,37 @@ vi.mock('../services/plugins.api', () => ({
52
57
  vi.mock('../../access/components/ManageAccessDialog', () => ({
53
58
  ManageAccessDialog: ({
54
59
  entry,
60
+ workspaceId,
61
+ onManageAncestor,
55
62
  onClose,
56
63
  }: {
57
64
  entry: { relativePath: string; type: string };
65
+ workspaceId?: string;
66
+ onManageAncestor?(entry: { name: string; relativePath: string; type: string }): void;
58
67
  onClose(): void;
59
68
  }) => (
60
- <div role="dialog" aria-label={`Manage access ${entry.type} ${entry.relativePath}`}>
69
+ // The branch and the ancestor walk are the page's to hand over, so the
70
+ // stub surfaces both: which branch the rules are read and written on, and
71
+ // whether an inherited grant can be managed where it actually lives.
72
+ <div
73
+ role="dialog"
74
+ aria-label={`Manage access ${entry.type} ${entry.relativePath}`}
75
+ data-workspace={workspaceId}
76
+ >
77
+ {onManageAncestor && (
78
+ <button
79
+ type="button"
80
+ onClick={() =>
81
+ onManageAncestor({
82
+ name: 'GTM',
83
+ relativePath: 'knowledge-base/Plugins/GTM',
84
+ type: 'directory',
85
+ })
86
+ }
87
+ >
88
+ Manage GTM →
89
+ </button>
90
+ )}
61
91
  <button type="button" onClick={onClose}>
62
92
  Close access
63
93
  </button>
@@ -126,8 +156,11 @@ const CATALOG: LibraryData = {
126
156
  { name: 'roadmap', description: 'Keeps the roadmap.', path: 'Plugins/Product/roadmap' },
127
157
  ],
128
158
  pendingSkills: [],
159
+ pendingTools: [],
129
160
  tools: [connectedTool()],
130
161
  ownedSkills: new Set(['outreach']),
162
+ writableSkills: new Set(['outreach']),
163
+ ownedTools: new Set(),
131
164
  allowedToolsBySkill: new Map(),
132
165
  crs: [],
133
166
  myCrNumbers: new Set<number>(),
@@ -159,11 +192,18 @@ function LocationProbe() {
159
192
  return <div aria-label="href">{location.pathname + location.search}</div>;
160
193
  }
161
194
 
162
- function renderPlugin(name: string, children?: ReactNode, admin: AdminContextValue = nonAdmin) {
195
+ function renderPlugin(
196
+ name: string,
197
+ children?: ReactNode,
198
+ admin: AdminContextValue = nonAdmin,
199
+ // The branch the app happens to have OPEN. It is the default one in every
200
+ // case but the access test, which is about the page not following it.
201
+ ambient: WorkspaceContextValue = workspace,
202
+ ) {
163
203
  return render(
164
204
  <MemoryRouter initialEntries={[`/skills-and-tools/plugins/${encodeURIComponent(name)}`]}>
165
205
  <AdminContext.Provider value={admin}>
166
- <WorkspaceContext.Provider value={workspace}>
206
+ <WorkspaceContext.Provider value={ambient}>
167
207
  <LibraryToastProvider>
168
208
  <LibraryProvider>
169
209
  {withAuth(
@@ -193,6 +233,7 @@ describe('PluginPage', () => {
193
233
  pluginsMock.listJoinRequests.mockResolvedValue([]);
194
234
  pluginsMock.reconcileJoinRequest.mockResolvedValue(false);
195
235
  pluginsMock.requestPluginAccess.mockResolvedValue(undefined);
236
+ pluginsMock.renamePlugin.mockReset();
196
237
  });
197
238
 
198
239
  it('lets a plugin MANAGER remove a skill, behind a confirm that says who loses it', async () => {
@@ -212,6 +253,54 @@ describe('PluginPage', () => {
212
253
  expect(await screen.findByText(/Removed outreach from GTM/)).toBeInTheDocument();
213
254
  });
214
255
 
256
+ it('removing a LINKED skill unlinks it — the skill stays where it lives', async () => {
257
+ dataMock.useLibraryData.mockReturnValue({
258
+ ...CATALOG,
259
+ skills: [
260
+ ...CATALOG.skills,
261
+ {
262
+ name: 'deploy',
263
+ description: 'Ships it.',
264
+ path: 'Skills/Eng/deploy',
265
+ plugins: [{ name: 'GTM', linked: true, granted: true }],
266
+ },
267
+ ],
268
+ });
269
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ canWrite: true })]);
270
+ pluginsMock.unlinkSkill.mockResolvedValue({ root: 'Skills/Eng/deploy', revoked: true });
271
+ libApiMock.removeLibraryItem.mockClear();
272
+ renderPlugin('GTM');
273
+
274
+ fireEvent.click(await screen.findByRole('button', { name: 'Remove deploy' }));
275
+ expect(await screen.findByText(/removes the link from GTM/)).toBeInTheDocument();
276
+ fireEvent.click(screen.getByRole('button', { name: 'Unlink' }));
277
+
278
+ await waitFor(() => expect(pluginsMock.unlinkSkill).toHaveBeenCalledWith('GTM', 'Skills/Eng/deploy'));
279
+ // Never the delete path: the shared skill is not this plugin's to delete.
280
+ expect(libApiMock.removeLibraryItem).not.toHaveBeenCalled();
281
+ expect(await screen.findByText(/Unlinked deploy from GTM/)).toBeInTheDocument();
282
+ });
283
+
284
+ it('offers no remove for a LINK into a plugin whose links live in an external format', async () => {
285
+ dataMock.useLibraryData.mockReturnValue({
286
+ ...CATALOG,
287
+ skills: [
288
+ ...CATALOG.skills,
289
+ {
290
+ name: 'deploy',
291
+ description: 'Ships it.',
292
+ path: 'Skills/Eng/deploy',
293
+ plugins: [{ name: 'GTM', linked: true, granted: true }],
294
+ },
295
+ ],
296
+ });
297
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ canWrite: true, linksAreManaged: false })]);
298
+ renderPlugin('GTM');
299
+ // The inline skill can still be removed; the link cannot be undone here.
300
+ await screen.findByRole('button', { name: 'Remove outreach' });
301
+ expect(screen.queryByRole('button', { name: 'Remove deploy' })).toBeNull();
302
+ });
303
+
215
304
  it('offers no remove affordance to a non-manager', async () => {
216
305
  renderPlugin('GTM'); // gtm() defaults to canWrite: false
217
306
  await screen.findByText('outreach');
@@ -229,6 +318,109 @@ describe('PluginPage', () => {
229
318
  expect(screen.getByRole('heading', { name: 'Tools' })).toBeInTheDocument();
230
319
  });
231
320
 
321
+ it('is titled by the display name with the folder beneath it, and found by its identity', async () => {
322
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'gtm', displayName: 'Go To Market' })]);
323
+ renderPlugin('gtm');
324
+ expect(await screen.findByRole('heading', { name: 'Go To Market', level: 1 })).toBeInTheDocument();
325
+ expect(screen.getByText('Plugins/GTM')).toBeInTheDocument();
326
+ // The folder's skill files under the identity, not under the folder name.
327
+ expect(screen.getByTestId('library-card-skill-outreach')).toBeInTheDocument();
328
+ });
329
+
330
+ it('offers Rename plugin to a MANAGER, and moves to the new identity once the rename lands', async () => {
331
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'gtm', displayName: 'GTM', canWrite: true })]);
332
+ pluginsMock.renamePlugin.mockResolvedValue({ name: 'go-to-market', displayName: 'GTM', rewritten: [] });
333
+ renderPlugin('gtm');
334
+
335
+ fireEvent.click(await screen.findByRole('button', { name: 'More actions' }));
336
+ fireEvent.click(await screen.findByRole('menuitem', { name: 'Rename plugin' }));
337
+ const dialog = await screen.findByRole('dialog', { name: 'Rename GTM' });
338
+ fireEvent.change(within(dialog).getByLabelText('Identifier'), { target: { value: 'go-to-market' } });
339
+ // Changing the identifier is a rename of a principal — the dialog says so before the click.
340
+ expect(within(dialog).getByText(/Every grant of/)).toBeInTheDocument();
341
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Rename' }));
342
+
343
+ await waitFor(() =>
344
+ expect(pluginsMock.renamePlugin).toHaveBeenCalledWith('gtm', { name: 'go-to-market', displayName: 'GTM' }),
345
+ );
346
+ // The identity is the URL: the page moves to the plugin's new address.
347
+ await waitFor(() => expect(href()).toBe('/skills-and-tools/plugins/go-to-market'));
348
+ });
349
+
350
+ it('refuses an identifier that is not kebab-case before asking the server', async () => {
351
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'gtm', displayName: 'GTM', canWrite: true })]);
352
+ renderPlugin('gtm');
353
+ fireEvent.click(await screen.findByRole('button', { name: 'More actions' }));
354
+ fireEvent.click(await screen.findByRole('menuitem', { name: 'Rename plugin' }));
355
+ const dialog = await screen.findByRole('dialog', { name: 'Rename GTM' });
356
+ fireEvent.change(within(dialog).getByLabelText('Identifier'), { target: { value: 'Go To Market' } });
357
+ expect(within(dialog).getByText(/Lowercase letters, digits and single hyphens/)).toBeInTheDocument();
358
+ expect(within(dialog).getByRole('button', { name: 'Rename' })).toBeDisabled();
359
+ expect(pluginsMock.renamePlugin).not.toHaveBeenCalled();
360
+ });
361
+
362
+ it('refuses the reserved personal prefix before asking the server', async () => {
363
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'gtm', displayName: 'GTM', canWrite: true })]);
364
+ renderPlugin('gtm');
365
+ fireEvent.click(await screen.findByRole('button', { name: 'More actions' }));
366
+ fireEvent.click(await screen.findByRole('menuitem', { name: 'Rename plugin' }));
367
+ const dialog = await screen.findByRole('dialog', { name: 'Rename GTM' });
368
+ fireEvent.change(within(dialog).getByLabelText('Identifier'), { target: { value: 'personal-gtm' } });
369
+ expect(within(dialog).getByText(/reserved for personal folders/)).toBeInTheDocument();
370
+ expect(within(dialog).getByRole('button', { name: 'Rename' })).toBeDisabled();
371
+ });
372
+
373
+ it('refuses an identifier longer than the slug the marketplace keys on, before asking the server', async () => {
374
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'gtm', displayName: 'GTM', canWrite: true })]);
375
+ renderPlugin('gtm');
376
+ fireEvent.click(await screen.findByRole('button', { name: 'More actions' }));
377
+ fireEvent.click(await screen.findByRole('menuitem', { name: 'Rename plugin' }));
378
+ const dialog = await screen.findByRole('dialog', { name: 'Rename GTM' });
379
+ fireEvent.change(within(dialog).getByLabelText('Identifier'), { target: { value: `${'a'.repeat(60)}-${'b'.repeat(10)}` } });
380
+ expect(within(dialog).getByText(/at most 64 characters/)).toBeInTheDocument();
381
+ expect(within(dialog).getByRole('button', { name: 'Rename' })).toBeDisabled();
382
+ expect(pluginsMock.renamePlugin).not.toHaveBeenCalled();
383
+ });
384
+
385
+ it('lets a plugin whose identifier already wears the reserved prefix change its display name', async () => {
386
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'personal-legacy', displayName: 'Legacy', canWrite: true })]);
387
+ pluginsMock.renamePlugin.mockResolvedValue({ name: 'personal-legacy', displayName: 'Legacy Team', rewritten: [] });
388
+ renderPlugin('personal-legacy');
389
+ fireEvent.click(await screen.findByRole('button', { name: 'More actions' }));
390
+ fireEvent.click(await screen.findByRole('menuitem', { name: 'Rename plugin' }));
391
+ const dialog = await screen.findByRole('dialog', { name: 'Rename Legacy' });
392
+ fireEvent.change(within(dialog).getByLabelText('Display name'), { target: { value: 'Legacy Team' } });
393
+ expect(within(dialog).queryByText(/reserved for personal folders/)).toBeNull();
394
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Rename' }));
395
+ await waitFor(() =>
396
+ expect(pluginsMock.renamePlugin).toHaveBeenCalledWith('personal-legacy', { displayName: 'Legacy Team' }),
397
+ );
398
+ });
399
+
400
+ it('offers no Rename plugin for a plugin read from an external format — its repository owns the name', async () => {
401
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'gtm', canWrite: true, linksAreManaged: false })]);
402
+ renderPlugin('gtm');
403
+ fireEvent.click(await screen.findByRole('button', { name: 'More actions' }));
404
+ await screen.findByRole('menu');
405
+ expect(screen.queryByRole('menuitem', { name: 'Rename plugin' })).toBeNull();
406
+ });
407
+
408
+ it('opens the manifest at the plugin FOLDER, which is not its identity', async () => {
409
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ name: 'go-to-market', displayName: 'GTM', canWrite: true })]);
410
+ renderPlugin('go-to-market');
411
+ fireEvent.click(await screen.findByRole('button', { name: 'Manifest' }));
412
+ await waitFor(() =>
413
+ expect(href()).toBe(`/workspace/${DEFAULT_BRANCH}/knowledge-base/Plugins/GTM/plugin.json`),
414
+ );
415
+ });
416
+
417
+ it('shows no Rename plugin to a non-manager', async () => {
418
+ renderPlugin('GTM'); // gtm() defaults to canWrite: false
419
+ fireEvent.click(await screen.findByRole('button', { name: 'More actions' }));
420
+ await screen.findByRole('menu');
421
+ expect(screen.queryByRole('menuitem', { name: 'Rename plugin' })).toBeNull();
422
+ });
423
+
232
424
  it('opens an mcp-declared tool card at its `?server=` URL, not the bare file URL', async () => {
233
425
  // Several servers share one declaring mcp.json, so the bare file URL is
234
426
  // ambiguous — navigating there bounced the click straight back to this
@@ -278,7 +470,11 @@ describe('PluginPage', () => {
278
470
  expect(
279
471
  await screen.findByRole('heading', { name: 'Add a skill or tool to GTM' }),
280
472
  ).toBeInTheDocument();
281
- expect(screen.getByText(/No review step/)).toBeInTheDocument();
473
+ // The clause is on both the Skills prompt and the hidden Tools one, so
474
+ // this reads the panel on screen.
475
+ expect(
476
+ within(screen.getByRole('tabpanel')).getByText(/No review step/),
477
+ ).toBeInTheDocument();
282
478
  expect(screen.queryByText('Start an empty SKILL.md')).not.toBeInTheDocument();
283
479
  });
284
480
 
@@ -313,6 +509,63 @@ describe('PluginPage', () => {
313
509
  await waitFor(() => expect(href()).toBe('/connect'));
314
510
  });
315
511
 
512
+ it('names a linked skill the members cannot read, above the integrations banner', async () => {
513
+ dataMock.useLibraryData.mockReturnValue({
514
+ ...CATALOG,
515
+ tools: [connectedTool(), unsetTool()],
516
+ skills: [
517
+ ...CATALOG.skills,
518
+ {
519
+ name: 'deploy',
520
+ description: 'Ships it.',
521
+ path: 'Skills/Eng/deploy',
522
+ plugins: [{ name: 'GTM', linked: true, granted: false }],
523
+ },
524
+ ],
525
+ });
526
+ renderPlugin('GTM');
527
+ const urgent = await screen.findByText(
528
+ /1 linked skill can't be read by GTM's members: its access rules no longer name them\. Repair the link from the skill page\./,
529
+ );
530
+ expect(urgent.closest('[role="status"]')).toHaveClass('bg-urgent-soft');
531
+ // The tools banner still counts only the tools: the broken link is not
532
+ // an integration to connect.
533
+ const tools = screen.getByText("1 integration needs setup: connect it to unblock this plugin's skills.");
534
+ expect(urgent.compareDocumentPosition(tools) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
535
+ });
536
+
537
+ it("lists what the plugin's definition left out, in the server's words, and counts it as attention", async () => {
538
+ dataMock.useLibraryData.mockReturnValue({ ...CATALOG, tools: [connectedTool()] });
539
+ pluginsMock.listPlugins.mockResolvedValue([
540
+ gtm({
541
+ canWrite: true,
542
+ warnings: [
543
+ 'registry.json: profile "global" selects server "docs", which was left out — args must be a list of strings',
544
+ 'sourceSkillRoots entry "../escape" is not a folder path — ignored',
545
+ ],
546
+ }),
547
+ ]);
548
+ renderPlugin('GTM');
549
+ expect(await screen.findByText("2 things in this plugin's definition were left out:")).toBeInTheDocument();
550
+ expect(screen.getByText(/selects server "docs", which was left out/)).toBeInTheDocument();
551
+ expect(screen.getByText(/sourceSkillRoots entry/)).toBeInTheDocument();
552
+ // Not an integration to set up: that banner stays down.
553
+ expect(screen.queryByText(/integrations? needs? setup/)).not.toBeInTheDocument();
554
+ });
555
+
556
+ it("warns about a broken link even when the caller cannot read that skill — the server's count wins", async () => {
557
+ // The manager the missing grant locks out: the skill is NOT in their
558
+ // catalog, so nothing in `items` could say a link is broken. The summary
559
+ // carries the index's own count.
560
+ dataMock.useLibraryData.mockReturnValue({ ...CATALOG, tools: [connectedTool()] });
561
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ canWrite: true, brokenLinks: 2 })]);
562
+ renderPlugin('GTM');
563
+ expect(
564
+ await screen.findByText(/2 linked skills can't be read by GTM's members: their access rules no longer name them\. Repair the links from the skill pages\./),
565
+ ).toBeInTheDocument();
566
+ expect(screen.queryByText(/integrations? needs? setup/)).not.toBeInTheDocument();
567
+ });
568
+
316
569
  it('pluralises the attention banner', async () => {
317
570
  dataMock.useLibraryData.mockReturnValue({
318
571
  ...CATALOG,
@@ -418,6 +671,96 @@ describe('PluginPage', () => {
418
671
  ).toBeInTheDocument();
419
672
  });
420
673
 
674
+ /**
675
+ * The gap a business-user tester fell into: they were standing on a plugin's
676
+ * page looking at a skill, and the only Share on screen was the plugin's. A
677
+ * skill card carries its own now, and it opens the SKILL's folder — the
678
+ * thing the card is about — not the plugin's.
679
+ */
680
+ it("a skill card's menu shares that skill's own folder, not the plugin's", async () => {
681
+ renderPlugin('GTM');
682
+
683
+ fireEvent.click(await screen.findByRole('button', { name: 'Actions for outreach' }));
684
+ expect(
685
+ within(screen.getByRole('menu'))
686
+ .getAllByRole('menuitem')
687
+ .map((i) => i.textContent),
688
+ ).toEqual(['Open', 'Share']);
689
+
690
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Share' }));
691
+ expect(
692
+ await screen.findByRole('dialog', {
693
+ name: 'Manage access directory knowledge-base/Plugins/GTM/outreach',
694
+ }),
695
+ ).toBeInTheDocument();
696
+ });
697
+
698
+ /**
699
+ * A skill in a plugin usually has NO rules of its own — it reads the ones the
700
+ * plugin folder above it sets. The skill page answers that with the dialog's
701
+ * `Manage <Folder> →`, and a card's Share is the same Share: without the
702
+ * walk, the grant it lands on is read-only here and editable one click away,
703
+ * which is the same dialog disagreeing with itself.
704
+ */
705
+ it("a card's Share can walk up to the folder the skill inherits from", async () => {
706
+ renderPlugin('GTM');
707
+
708
+ fireEvent.click(await screen.findByRole('button', { name: 'Actions for outreach' }));
709
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Share' }));
710
+ fireEvent.click(await screen.findByRole('button', { name: 'Manage GTM →' }));
711
+
712
+ expect(
713
+ await screen.findByRole('dialog', {
714
+ name: 'Manage access directory knowledge-base/Plugins/GTM',
715
+ }),
716
+ ).toBeInTheDocument();
717
+ });
718
+
719
+ /**
720
+ * The Library lists the DEFAULT branch, so the rules it shares are edited
721
+ * where it read them. The ambient workspace here is a different branch on
722
+ * purpose: without the page pinning it, a grant would be spliced into an
723
+ * `access.md` on whatever branch happened to be open — a rule nobody merges,
724
+ * which looks like it worked.
725
+ */
726
+ it("edits access on the branch the catalog was read from, not the one that's open", async () => {
727
+ renderPlugin('GTM', undefined, nonAdmin, {
728
+ ...workspace,
729
+ workspaceId: 'a-change-request-branch',
730
+ } as WorkspaceContextValue);
731
+
732
+ fireEvent.click(await screen.findByRole('button', { name: 'Share' }));
733
+ const dialog = await screen.findByRole('dialog');
734
+ expect(dialog.getAttribute('data-workspace')).toBe(encodeURIComponent(DEFAULT_BRANCH));
735
+ expect(dialog.getAttribute('data-workspace')).not.toBe('a-change-request-branch');
736
+ });
737
+
738
+ /**
739
+ * Both are corner controls on the same card, and the manager view is the one
740
+ * place they meet. Neither may sit on top of the other.
741
+ */
742
+ it('gives a manager the card menu AND Remove, on separate targets', async () => {
743
+ pluginsMock.listPlugins.mockResolvedValue([gtm({ canWrite: true })]);
744
+ renderPlugin('GTM');
745
+
746
+ const remove = await screen.findByRole('button', { name: 'Remove outreach' });
747
+ const dots = screen.getByRole('button', { name: 'Actions for outreach' });
748
+ expect(remove).not.toBe(dots);
749
+ // The `…` keeps the corner every menu in this product lives in; Remove
750
+ // steps left of it rather than under it.
751
+ expect(dots.className).toContain('right-1.5');
752
+ expect(remove.className).toContain('right-8');
753
+ expect(remove.className).not.toContain('right-1.5');
754
+ });
755
+
756
+ it('leaves a TOOL card alone — access to a tool is decided at its plugin', async () => {
757
+ renderPlugin('GTM');
758
+
759
+ expect(await screen.findByRole('button', { name: 'Actions for outreach' })).toBeInTheDocument();
760
+ // `connectedTool()` is in this plugin and renders a card beside the skill.
761
+ expect(screen.queryByRole('button', { name: /^Actions for (?!outreach)/ })).toBeNull();
762
+ });
763
+
421
764
  it('an UNDISCOVERABLE plugin renders exactly like one that does not exist', async () => {
422
765
  // Fail-closed: the endpoint omits plugins with no verdict at all, so the
423
766
  // page cannot tell "hidden from you" apart from "absent" — the point.
@@ -434,7 +777,7 @@ describe('PluginPage', () => {
434
777
  ]);
435
778
  renderPlugin('Finance');
436
779
  expect(
437
- await screen.findByRole('button', { name: 'Subscribe to its skills and tools' }),
780
+ await screen.findByRole('button', { name: 'Subscribe to this plugin' }),
438
781
  ).toBeInTheDocument();
439
782
  expect(screen.queryByRole('heading', { name: 'Skills' })).not.toBeInTheDocument();
440
783
  // A locked plugin offers no way in at all — not an add door, not a propose one.
@@ -467,7 +810,7 @@ describe('PluginPage', () => {
467
810
  it('says so when the plugin does not exist', async () => {
468
811
  renderPlugin('Nope');
469
812
  expect(await screen.findByText("This plugin doesn't exist yet.")).toBeInTheDocument();
470
- expect(screen.getByRole('link', { name: 'All plugins' })).toHaveAttribute(
813
+ expect(screen.getByRole('link', { name: 'Everything' })).toHaveAttribute(
471
814
  'href',
472
815
  '/skills-and-tools',
473
816
  );
@@ -596,4 +939,107 @@ describe('PluginPage', () => {
596
939
  expect(screen.queryByText('Last updated just now')).not.toBeInTheDocument();
597
940
  });
598
941
  });
942
+
943
+ /**
944
+ * The Linked pill: which of a plugin's cards live somewhere else.
945
+ *
946
+ * The complaint behind it was a skill on the plugin's page that the Advanced
947
+ * tree did not list under the plugin's folder. Both were right — the skill is
948
+ * linked, the tree shows the disk — and the page was the one saying nothing.
949
+ * The pill is that missing sentence, and its tooltip is what reconciles the
950
+ * two views by naming where the item actually lives.
951
+ */
952
+ describe('the Linked pill', () => {
953
+ /** A shared skill the plugin links, and a tool sitting under a linked root. */
954
+ const LINKED_CATALOG: LibraryData = {
955
+ ...CATALOG,
956
+ skills: [
957
+ ...CATALOG.skills,
958
+ {
959
+ name: 'test-shared-linking',
960
+ description: 'Shared across plugins.',
961
+ path: 'Skills/Testing/test-shared-linking',
962
+ plugins: [{ name: 'GTM', linked: true, granted: true }],
963
+ },
964
+ ],
965
+ tools: [
966
+ connectedTool(),
967
+ connectedTool({ slug: 'grafana', name: 'grafana', path: 'Plugins/Shared/observability/grafana.tool' }),
968
+ ],
969
+ };
970
+ /** The roots GTM's manifest points at — the skill's, and the tool's. */
971
+ const linking = gtm({
972
+ linkedRoots: ['Skills/Testing', 'Plugins/Shared/observability'],
973
+ skillCount: 2,
974
+ toolCount: 2,
975
+ });
976
+
977
+ const pillOn = (testId: string) => within(screen.getByTestId(testId)).queryByText('Linked');
978
+
979
+ beforeEach(() => {
980
+ dataMock.useLibraryData.mockReturnValue(LINKED_CATALOG);
981
+ pluginsMock.listPlugins.mockResolvedValue([linking]);
982
+ });
983
+
984
+ it('marks a LINKED skill and names where it lives; an inline skill wears none', async () => {
985
+ renderPlugin('GTM');
986
+ await screen.findByTestId('library-card-skill-test-shared-linking');
987
+
988
+ expect(pillOn('library-card-skill-test-shared-linking')).toHaveAttribute(
989
+ 'title',
990
+ "Lives in Skills/Testing; linked from this plugin's manifest",
991
+ );
992
+ // The skill inside the plugin's own folder is simply here — nothing to say.
993
+ expect(pillOn('library-card-skill-outreach')).toBeNull();
994
+ });
995
+
996
+ // A manifest can link ONE skill folder rather than the shelf holding it.
997
+ // The tooltip names the root that was linked, not its parent: `Skills/Testing`
998
+ // here would point at a shelf this plugin was never given.
999
+ it('names the skill folder itself when the manifest links it outright', async () => {
1000
+ pluginsMock.listPlugins.mockResolvedValue([
1001
+ { ...linking, linkedRoots: ['Skills/Testing/test-shared-linking', 'Plugins/Shared/observability'] },
1002
+ ]);
1003
+ renderPlugin('GTM');
1004
+ await screen.findByTestId('library-card-skill-test-shared-linking');
1005
+
1006
+ expect(pillOn('library-card-skill-test-shared-linking')).toHaveAttribute(
1007
+ 'title',
1008
+ "Lives in Skills/Testing/test-shared-linking; linked from this plugin's manifest",
1009
+ );
1010
+ });
1011
+
1012
+ it('marks a TOOL that reaches the plugin through a linked root, and leaves the inline one alone', async () => {
1013
+ renderPlugin('GTM');
1014
+ await screen.findByTestId('library-card-integration-grafana');
1015
+
1016
+ expect(pillOn('library-card-integration-grafana')).toHaveAttribute(
1017
+ 'title',
1018
+ "Lives in Plugins/Shared/observability; linked from this plugin's manifest",
1019
+ );
1020
+ expect(pillOn('library-card-integration-heyreach')).toBeNull();
1021
+ });
1022
+
1023
+ it('is scoped to the page it is on: another plugin neither lists the linked items nor pills its own', async () => {
1024
+ // The pill says "linked from THIS plugin's manifest", so it is only ever
1025
+ // decided against the plugin whose page the card is on.
1026
+ renderPlugin('Product');
1027
+ await screen.findByTestId('library-card-skill-roadmap');
1028
+ expect(screen.queryByTestId('library-card-skill-test-shared-linking')).toBeNull();
1029
+ expect(screen.queryByTestId('library-card-integration-grafana')).toBeNull();
1030
+ expect(pillOn('library-card-skill-roadmap')).toBeNull();
1031
+ });
1032
+
1033
+ it('offers a manager no Remove on a tool reached by link — it is removed where it lives', async () => {
1034
+ pluginsMock.listPlugins.mockResolvedValue([{ ...linking, canWrite: true }]);
1035
+ renderPlugin('GTM');
1036
+
1037
+ // The tool in the plugin's own folder is still the manager's to remove.
1038
+ await screen.findByRole('button', { name: 'Remove heyreach' });
1039
+ expect(screen.queryByRole('button', { name: 'Remove grafana' })).toBeNull();
1040
+ // The linked SKILL keeps its verb: unlinking is a manifest edit this
1041
+ // plugin's manager owns.
1042
+ expect(screen.getByRole('button', { name: 'Remove test-shared-linking' })).toBeInTheDocument();
1043
+ });
1044
+ });
599
1045
  });