@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -0,0 +1,266 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, waitFor, within } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import { ConnectionKeysPage } from '../components/ConnectionKeysPage';
5
+ import { groupByAccount } from '../components/connection-keys-grouping';
6
+ import { AdminContext } from '../state/admin.context';
7
+ import {
8
+ listConnectionKeys,
9
+ revokeConnectionKey,
10
+ type AdminConnectionKey,
11
+ } from '../services/connection-keys.api';
12
+
13
+ vi.mock('../services/connection-keys.api', () => ({
14
+ listConnectionKeys: vi.fn(),
15
+ revokeConnectionKey: vi.fn(),
16
+ }));
17
+
18
+ const ALICE = { id: 'u-alice', email: 'alice@example.com', name: 'Alice' };
19
+ const BOB = { id: 'u-bob', email: 'bob@example.com', name: 'Bob' };
20
+
21
+ const DAY = 24 * 60 * 60 * 1000;
22
+ const NOW = Date.now();
23
+
24
+ const ALICE_CI: AdminConnectionKey = {
25
+ id: 'k-ci',
26
+ label: 'CI pipeline',
27
+ kind: 'key',
28
+ createdAt: NOW - 10 * DAY,
29
+ lastUsedAt: NOW - 2 * 60 * 60 * 1000,
30
+ revokedAt: null,
31
+ revokedBy: null,
32
+ user: ALICE,
33
+ };
34
+ const ALICE_LAPTOP: AdminConnectionKey = {
35
+ id: 'k-laptop',
36
+ label: 'Laptop',
37
+ kind: 'key',
38
+ createdAt: NOW - 3 * DAY,
39
+ lastUsedAt: null,
40
+ revokedAt: null,
41
+ revokedBy: null,
42
+ user: ALICE,
43
+ };
44
+ const BOB_OLD: AdminConnectionKey = {
45
+ id: 'k-old',
46
+ label: 'Old script',
47
+ kind: 'key',
48
+ createdAt: NOW - 40 * DAY,
49
+ lastUsedAt: NOW - 30 * DAY,
50
+ revokedAt: NOW - 20 * DAY,
51
+ revokedBy: 'owner',
52
+ user: BOB,
53
+ };
54
+ const BOB_LINK: AdminConnectionKey = {
55
+ id: 'k-link',
56
+ label: 'Claude',
57
+ kind: 'github-link',
58
+ createdAt: NOW - 1 * DAY,
59
+ lastUsedAt: NOW - 60 * 1000,
60
+ revokedAt: null,
61
+ revokedBy: null,
62
+ user: BOB,
63
+ };
64
+
65
+ function renderPage(opts: { isAdmin?: boolean } = {}) {
66
+ return render(
67
+ <AdminContext.Provider
68
+ value={{
69
+ isAdmin: opts.isAdmin ?? true,
70
+ unreadCount: 0,
71
+ lastSeen: null,
72
+ markSeen: () => {},
73
+ refresh: () => {},
74
+ rolesConfigCorrupted: false,
75
+ rolesConfigErrors: [],
76
+ runRolesRecovery: async () => {},
77
+ }}
78
+ >
79
+ <ConnectionKeysPage />
80
+ </AdminContext.Provider>,
81
+ );
82
+ }
83
+
84
+ beforeEach(() => {
85
+ vi.mocked(listConnectionKeys)
86
+ .mockReset()
87
+ .mockResolvedValue([ALICE_LAPTOP, ALICE_CI, BOB_OLD, BOB_LINK]);
88
+ vi.mocked(revokeConnectionKey).mockReset().mockResolvedValue(undefined);
89
+ });
90
+
91
+ describe('groupByAccount', () => {
92
+ it('groups in server order, live keys first, most recently used at the top', () => {
93
+ const groups = groupByAccount([ALICE_LAPTOP, ALICE_CI, BOB_OLD, BOB_LINK], true);
94
+ expect(groups.map((g) => g.user.id)).toEqual(['u-alice', 'u-bob']);
95
+ // Alice: CI was used, Laptop never → CI first despite Laptop being newer.
96
+ expect(groups[0].keys.map((k) => k.id)).toEqual(['k-ci', 'k-laptop']);
97
+ // Bob: the live link outranks the revoked key.
98
+ expect(groups[1].keys.map((k) => k.id)).toEqual(['k-link', 'k-old']);
99
+ });
100
+
101
+ it('drops revoked keys (and accounts left empty) when they are hidden', () => {
102
+ const groups = groupByAccount([BOB_OLD, ALICE_CI], false);
103
+ expect(groups.map((g) => g.user.id)).toEqual(['u-alice']);
104
+ });
105
+ });
106
+
107
+ describe('ConnectionKeysPage', () => {
108
+ it('shows the admins-only state (and never loads) for non-admins', () => {
109
+ renderPage({ isAdmin: false });
110
+ expect(screen.getByText(/Admins only/)).toBeInTheDocument();
111
+ expect(listConnectionKeys).not.toHaveBeenCalled();
112
+ });
113
+
114
+ it('lists live keys per account with created / last used, hiding disconnected ones by default', async () => {
115
+ renderPage();
116
+ await waitFor(() => expect(screen.getByText('CI pipeline')).toBeInTheDocument());
117
+
118
+ const alice = screen.getByRole('region', { name: 'Keys for alice@example.com' });
119
+ expect(within(alice).getByText('Alice')).toBeInTheDocument();
120
+ expect(within(alice).getByText('Created 1w ago')).toBeInTheDocument();
121
+ expect(within(alice).getByText('Last used 2h ago')).toBeInTheDocument();
122
+ expect(within(alice).getByText('Created 3d ago')).toBeInTheDocument();
123
+ expect(within(alice).getByText('Last used never')).toBeInTheDocument();
124
+ expect(
125
+ within(alice).getByRole('button', { name: 'Revoke CI pipeline for alice@example.com' }),
126
+ ).toBeInTheDocument();
127
+
128
+ const bob = screen.getByRole('region', { name: 'Keys for bob@example.com' });
129
+ expect(within(bob).getByText('Claude link')).toBeInTheDocument();
130
+ expect(within(bob).queryByText('Old script')).not.toBeInTheDocument();
131
+
132
+ expect(screen.getByText(/3 live keys · 1 disconnected/)).toBeInTheDocument();
133
+ });
134
+
135
+ it('reveals disconnected keys, without a revoke button, when toggled', async () => {
136
+ renderPage();
137
+ await waitFor(() => expect(screen.getByText('CI pipeline')).toBeInTheDocument());
138
+
139
+ await userEvent.click(screen.getByRole('checkbox', { name: 'Show disconnected keys' }));
140
+
141
+ const bob = screen.getByRole('region', { name: 'Keys for bob@example.com' });
142
+ expect(within(bob).getByText('Old script')).toBeInTheDocument();
143
+ expect(within(bob).getByText(/Disconnected by owner 2w ago/)).toBeInTheDocument();
144
+ expect(
145
+ within(bob).queryByRole('button', { name: 'Revoke Old script for bob@example.com' }),
146
+ ).not.toBeInTheDocument();
147
+ });
148
+
149
+ it('revokes after confirmation and reloads the list', async () => {
150
+ renderPage();
151
+ await waitFor(() => expect(screen.getByText('CI pipeline')).toBeInTheDocument());
152
+
153
+ await userEvent.click(
154
+ screen.getByRole('button', { name: 'Revoke CI pipeline for alice@example.com' }),
155
+ );
156
+ const dialog = await screen.findByRole('dialog');
157
+ expect(within(dialog).getByText(/Alice \(alice@example.com\)/)).toBeInTheDocument();
158
+ expect(revokeConnectionKey).not.toHaveBeenCalled();
159
+
160
+ await userEvent.click(within(dialog).getByRole('button', { name: 'Revoke key' }));
161
+
162
+ await waitFor(() => expect(revokeConnectionKey).toHaveBeenCalledWith('k-ci'));
163
+ await waitFor(() => expect(listConnectionKeys).toHaveBeenCalledTimes(2));
164
+ });
165
+
166
+ it('cancelling the confirm revokes nothing', async () => {
167
+ renderPage();
168
+ await waitFor(() => expect(screen.getByText('CI pipeline')).toBeInTheDocument());
169
+
170
+ await userEvent.click(
171
+ screen.getByRole('button', { name: 'Revoke CI pipeline for alice@example.com' }),
172
+ );
173
+ const dialog = await screen.findByRole('dialog');
174
+ await userEvent.click(within(dialog).getByRole('button', { name: 'Cancel' }));
175
+
176
+ expect(revokeConnectionKey).not.toHaveBeenCalled();
177
+ expect(listConnectionKeys).toHaveBeenCalledTimes(1);
178
+ });
179
+
180
+ it('surfaces a failed revoke inline and keeps the rows it had', async () => {
181
+ renderPage();
182
+ await waitFor(() => expect(screen.getByText('CI pipeline')).toBeInTheDocument());
183
+ vi.mocked(revokeConnectionKey).mockRejectedValueOnce(new Error('Token not found'));
184
+
185
+ await userEvent.click(
186
+ screen.getByRole('button', { name: 'Revoke CI pipeline for alice@example.com' }),
187
+ );
188
+ await userEvent.click(
189
+ within(await screen.findByRole('dialog')).getByRole('button', { name: 'Revoke key' }),
190
+ );
191
+
192
+ expect(await screen.findByRole('alert')).toHaveTextContent('Token not found');
193
+ expect(screen.getByText('CI pipeline')).toBeInTheDocument();
194
+ });
195
+
196
+ it('keeps a revoked key disconnected when the reload after revoking fails', async () => {
197
+ renderPage();
198
+ await waitFor(() => expect(screen.getByText('CI pipeline')).toBeInTheDocument());
199
+ vi.mocked(listConnectionKeys).mockRejectedValueOnce(new Error('Could not load connection keys'));
200
+
201
+ await userEvent.click(
202
+ screen.getByRole('button', { name: 'Revoke CI pipeline for alice@example.com' }),
203
+ );
204
+ await userEvent.click(
205
+ within(await screen.findByRole('dialog')).getByRole('button', { name: 'Revoke key' }),
206
+ );
207
+
208
+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load connection keys');
209
+ // The server said yes, so the row is disconnected regardless of the reload:
210
+ // hidden with the other disconnected keys, and never offering Revoke again.
211
+ expect(
212
+ screen.queryByRole('button', { name: 'Revoke CI pipeline for alice@example.com' }),
213
+ ).not.toBeInTheDocument();
214
+ await userEvent.click(screen.getByRole('checkbox', { name: 'Show disconnected keys' }));
215
+ expect(screen.getByText('CI pipeline')).toBeInTheDocument();
216
+ expect(screen.getByText(/2 live keys · 2 disconnected/)).toBeInTheDocument();
217
+ });
218
+
219
+ it('ignores a stale list response that lands after a newer one', async () => {
220
+ // Two revokes back to back: the reload from the FIRST resolves last, still
221
+ // showing the second key as live. It must not win over the newer reload.
222
+ const deferred = () => {
223
+ let resolve!: (rows: AdminConnectionKey[]) => void;
224
+ const promise = new Promise<AdminConnectionKey[]>((r) => (resolve = r));
225
+ return { promise, resolve };
226
+ };
227
+ const first = deferred();
228
+ const second = deferred();
229
+ vi.mocked(listConnectionKeys)
230
+ .mockReset()
231
+ .mockResolvedValueOnce([ALICE_CI, ALICE_LAPTOP])
232
+ .mockReturnValueOnce(first.promise)
233
+ .mockReturnValueOnce(second.promise);
234
+ renderPage();
235
+ await waitFor(() => expect(screen.getByText('CI pipeline')).toBeInTheDocument());
236
+
237
+ const revoke = async (name: string) => {
238
+ await userEvent.click(screen.getByRole('button', { name }));
239
+ await userEvent.click(
240
+ within(await screen.findByRole('dialog')).getByRole('button', { name: 'Revoke key' }),
241
+ );
242
+ };
243
+ await revoke('Revoke CI pipeline for alice@example.com');
244
+ await revoke('Revoke Laptop for alice@example.com');
245
+ await waitFor(() => expect(listConnectionKeys).toHaveBeenCalledTimes(3));
246
+
247
+ const ciRevoked = { ...ALICE_CI, revokedAt: NOW };
248
+ second.resolve([ciRevoked, { ...ALICE_LAPTOP, revokedAt: NOW }]);
249
+ await waitFor(() => expect(screen.getByText(/0 live keys · 2 disconnected/)).toBeInTheDocument());
250
+
251
+ // The stale reload: taken at face value, Laptop would come back to life.
252
+ first.resolve([ciRevoked, ALICE_LAPTOP]);
253
+ await new Promise((r) => setTimeout(r, 0));
254
+ expect(screen.getByText(/0 live keys · 2 disconnected/)).toBeInTheDocument();
255
+ expect(
256
+ screen.queryByRole('button', { name: 'Revoke Laptop for alice@example.com' }),
257
+ ).not.toBeInTheDocument();
258
+ });
259
+
260
+ it('shows the load error and no empty state when the first load fails', async () => {
261
+ vi.mocked(listConnectionKeys).mockRejectedValueOnce(new Error('Could not load connection keys'));
262
+ renderPage();
263
+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load connection keys');
264
+ expect(screen.queryByText(/No connection keys/)).not.toBeInTheDocument();
265
+ });
266
+ });
@@ -0,0 +1,182 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, waitFor, within } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import { MemoryRouter } from 'react-router-dom';
5
+ import { DirectoryGroupsPage } from '../components/DirectoryGroupsPage';
6
+ import { SUGGEST_DEBOUNCE_MS } from '../components/AddMemberInput';
7
+ import { AdminContext } from '../state/admin.context';
8
+ import { AppRegistryContext, EMPTY_REGISTRY } from '../../../core/registry';
9
+ import { addGroupMember, getGroupsRoster, type GroupsRoster } from '../services/groups.api';
10
+ import { suggestPrincipals, type SuggestResponse } from '../../access/api';
11
+
12
+ vi.mock('../services/groups.api', async (importOriginal) => {
13
+ const actual = await importOriginal<typeof import('../services/groups.api')>();
14
+ return { ...actual, getGroupsRoster: vi.fn(), addGroupMember: vi.fn() };
15
+ });
16
+ vi.mock('../../access/api', async (importOriginal) => {
17
+ const actual = await importOriginal<typeof import('../../access/api')>();
18
+ return { ...actual, suggestPrincipals: vi.fn() };
19
+ });
20
+
21
+ /**
22
+ * How long "no request" has to hold: the component's own debounce plus slack,
23
+ * derived from the component so raising the debounce cannot leave this test
24
+ * asserting over a window the request has not been scheduled in yet.
25
+ */
26
+ const PAST_DEBOUNCE_MS = SUGGEST_DEBOUNCE_MS + 150;
27
+
28
+ const ALICE = { name: 'Alice Green', email: 'alice@example.com' };
29
+ const PAT = { name: 'Pat Kim', email: 'pat@example.com' };
30
+
31
+ function people(...list: { name: string; email: string }[]): SuggestResponse {
32
+ return { roles: [], groups: [], people: list, peopleWithheld: false };
33
+ }
34
+
35
+ const MANUAL_ROSTER: GroupsRoster = {
36
+ mode: 'manual',
37
+ groups: [
38
+ {
39
+ canonical: 'product',
40
+ displayName: 'Product',
41
+ members: ['pat@example.com'],
42
+ referencedBy: [],
43
+ assignedToRoles: [],
44
+ },
45
+ {
46
+ canonical: 'design',
47
+ displayName: 'Design',
48
+ members: [],
49
+ referencedBy: [],
50
+ assignedToRoles: [],
51
+ },
52
+ ],
53
+ groupsHealth: { ok: true },
54
+ };
55
+
56
+ function renderPage() {
57
+ return render(
58
+ <AppRegistryContext.Provider value={EMPTY_REGISTRY}>
59
+ <AdminContext.Provider
60
+ value={{
61
+ isAdmin: true,
62
+ unreadCount: 0,
63
+ lastSeen: null,
64
+ markSeen: () => {},
65
+ refresh: () => {},
66
+ rolesConfigCorrupted: false,
67
+ rolesConfigErrors: [],
68
+ runRolesRecovery: async () => {},
69
+ }}
70
+ >
71
+ <MemoryRouter initialEntries={['/directory-groups']}>
72
+ <DirectoryGroupsPage />
73
+ </MemoryRouter>
74
+ </AdminContext.Provider>
75
+ </AppRegistryContext.Provider>,
76
+ );
77
+ }
78
+
79
+ /** The Add button belonging to a member input's row. */
80
+ function addButtonFor(input: HTMLElement) {
81
+ return within(input.closest('div')!.parentElement!).getByRole('button', { name: 'Add' });
82
+ }
83
+
84
+ beforeEach(() => {
85
+ vi.mocked(getGroupsRoster).mockReset().mockResolvedValue(MANUAL_ROSTER);
86
+ vi.mocked(addGroupMember).mockReset().mockResolvedValue(MANUAL_ROSTER);
87
+ vi.mocked(suggestPrincipals).mockReset().mockResolvedValue(people(ALICE));
88
+ });
89
+
90
+ describe('DirectoryGroupsPage: add-member people suggestions', () => {
91
+ it('suggests people by name and email, from the same source the roles page uses', async () => {
92
+ renderPage();
93
+ const input = await screen.findByRole('combobox', { name: 'Add member to Design' });
94
+ await userEvent.type(input, 'al');
95
+
96
+ expect(await screen.findByText('Alice Green')).toBeInTheDocument();
97
+ expect(screen.getByText('alice@example.com')).toBeInTheDocument();
98
+ // The access suggest endpoint on the default-branch workspace — exactly
99
+ // what Roles & Members and the access dialog ask.
100
+ expect(suggestPrincipals).toHaveBeenCalledWith('target-company-state', 'al');
101
+ });
102
+
103
+ it("excludes the group's current members from the suggestions", async () => {
104
+ vi.mocked(suggestPrincipals).mockResolvedValue(people(PAT, ALICE));
105
+ renderPage();
106
+ // Product already has pat@example.com — suggesting him would offer a no-op.
107
+ const input = await screen.findByRole('combobox', { name: 'Add member to Product' });
108
+ await userEvent.type(input, 'ex');
109
+
110
+ expect(await screen.findByText('Alice Green')).toBeInTheDocument();
111
+ expect(screen.queryByText('Pat Kim')).not.toBeInTheDocument();
112
+ });
113
+
114
+ it('choosing a suggestion adds the person exactly as typing the email would', async () => {
115
+ renderPage();
116
+ const input = await screen.findByRole('combobox', { name: 'Add member to Design' });
117
+ await userEvent.type(input, 'ali');
118
+ await userEvent.click(await screen.findByText('Alice Green'));
119
+
120
+ await waitFor(() =>
121
+ expect(addGroupMember).toHaveBeenCalledWith('design', 'alice@example.com'),
122
+ );
123
+ // The input is cleared, as after any successful add.
124
+ await waitFor(() => expect(input).toHaveValue(''));
125
+
126
+ // The typed path lands on the identical request.
127
+ vi.mocked(addGroupMember).mockClear();
128
+ await userEvent.type(input, 'alice@example.com{Enter}');
129
+ await waitFor(() =>
130
+ expect(addGroupMember).toHaveBeenCalledWith('design', 'alice@example.com'),
131
+ );
132
+ });
133
+
134
+ it('a full email that is not among the suggestions is still added', async () => {
135
+ // Suggestions only ever know people the deployment has seen; a colleague
136
+ // who has never signed in must still be addable.
137
+ renderPage();
138
+ const input = await screen.findByRole('combobox', { name: 'Add member to Design' });
139
+ await userEvent.type(input, 'newcomer@example.com');
140
+ await userEvent.click(addButtonFor(input));
141
+
142
+ await waitFor(() =>
143
+ expect(addGroupMember).toHaveBeenCalledWith('design', 'newcomer@example.com'),
144
+ );
145
+ });
146
+
147
+ it('a failed suggest request never blocks adding a valid email', async () => {
148
+ vi.mocked(suggestPrincipals).mockRejectedValue(new Error('suggest is down'));
149
+ renderPage();
150
+ const input = await screen.findByRole('combobox', { name: 'Add member to Design' });
151
+ await userEvent.type(input, 'dana@example.com');
152
+ await waitFor(() => expect(suggestPrincipals).toHaveBeenCalled());
153
+
154
+ // The suggestion feature degrades; the form does not. No error banner, and
155
+ // the add goes through unchanged.
156
+ expect(screen.queryByText(/suggest is down/)).not.toBeInTheDocument();
157
+ await userEvent.click(addButtonFor(input));
158
+ await waitFor(() => expect(addGroupMember).toHaveBeenCalledWith('design', 'dana@example.com'));
159
+ });
160
+
161
+ it('makes no suggestion request below two characters', async () => {
162
+ renderPage();
163
+ const input = await screen.findByRole('combobox', { name: 'Add member to Design' });
164
+ await userEvent.type(input, 'a');
165
+ await new Promise((resolve) => setTimeout(resolve, PAST_DEBOUNCE_MS));
166
+
167
+ expect(suggestPrincipals).not.toHaveBeenCalled();
168
+ expect(screen.queryByText('Alice Green')).not.toBeInTheDocument();
169
+ });
170
+
171
+ it('an IdP-synced group still has no member input at all', async () => {
172
+ vi.mocked(getGroupsRoster).mockResolvedValue({
173
+ ...MANUAL_ROSTER,
174
+ mode: 'idp',
175
+ });
176
+ renderPage();
177
+ expect(await screen.findByText('Product')).toBeInTheDocument();
178
+ // Membership is managed in the directory — nothing to suggest into.
179
+ expect(screen.queryByRole('combobox', { name: /Add member/ })).not.toBeInTheDocument();
180
+ expect(suggestPrincipals).not.toHaveBeenCalled();
181
+ });
182
+ });