@bevel-software/platform-core-frontend 0.14.0 → 0.19.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/THIRD-PARTY-NOTICES.md +2 -2
- package/package.json +3 -3
- package/src/core/CoreAppShell.tsx +34 -26
- package/src/core/__tests__/AppChrome.test.tsx +0 -3
- package/src/core/__tests__/bootstrap.test.ts +33 -1
- package/src/core/__tests__/events.test.ts +43 -0
- package/src/core/bootstrap.ts +38 -1
- package/src/core/events.ts +85 -3
- package/src/core/registry.ts +1 -1
- package/src/lib/__tests__/api.test.ts +38 -0
- package/src/lib/__tests__/email.test.ts +44 -0
- package/src/lib/api.ts +19 -2
- package/src/lib/email.ts +37 -1
- package/src/lib/utils.ts +2 -0
- package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
- package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
- package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
- package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
- package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
- package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
- package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
- package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
- package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
- package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
- package/src/modules/access/api.ts +192 -10
- package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
- package/src/modules/access/manage-access-affordance.ts +17 -0
- package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
- package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
- package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
- package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
- package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
- package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
- package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
- package/src/modules/admin/components/AddMemberInput.tsx +268 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
- package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
- package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
- package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
- package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
- package/src/modules/admin/components/group-members-path.ts +32 -0
- package/src/modules/admin/services/connection-keys.api.ts +47 -0
- package/src/modules/admin/services/roles.api.ts +12 -1
- package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
- package/src/modules/auth/components/AccountPage.tsx +73 -54
- package/src/modules/auth/components/LoginScreen.tsx +1 -0
- package/src/modules/auth/services/account.api.ts +78 -4
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
- package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
- package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
- package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
- package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
- package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
- package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
- package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
- package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
- package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
- package/src/modules/change-requests/services/change-requests.api.ts +57 -1
- package/src/modules/change-requests/services/denied-file.api.ts +53 -0
- package/src/modules/change-requests/services/propose.api.ts +97 -8
- package/src/modules/change-requests/utils/approval.ts +15 -0
- package/src/modules/change-requests/utils/author.ts +32 -0
- package/src/modules/change-requests/utils/readFailure.ts +110 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
- package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
- package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
- package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
- package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
- package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
- package/src/modules/git/services/error-messages.ts +12 -0
- package/src/modules/git/services/pr-prompts.ts +5 -5
- package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
- package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
- package/src/modules/layout/components/AppLayout.tsx +2 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
- package/src/modules/layout/components/SidebarFrame.tsx +109 -4
- package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
- package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
- package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
- package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
- package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
- package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
- package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
- package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
- package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
- package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
- package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
- package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
- package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
- package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
- package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
- package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
- package/src/modules/library/__tests__/auth-harness.tsx +9 -9
- package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
- package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
- package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
- package/src/modules/library/__tests__/library-data.test.ts +7 -0
- package/src/modules/library/__tests__/library-paths.test.ts +75 -0
- package/src/modules/library/__tests__/link-membership.test.ts +129 -0
- package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
- package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
- package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
- package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
- package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
- package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
- package/src/modules/library/__tests__/status.test.ts +82 -2
- package/src/modules/library/__tests__/tools.api.test.ts +44 -1
- package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
- package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
- package/src/modules/library/components/AddDialogTabs.tsx +103 -0
- package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
- package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
- package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
- package/src/modules/library/components/LibraryCard.tsx +149 -34
- package/src/modules/library/components/LibraryLayout.tsx +120 -247
- package/src/modules/library/components/LibraryPage.tsx +172 -39
- package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
- package/src/modules/library/components/LockedPluginView.tsx +63 -35
- package/src/modules/library/components/NameWithBadges.tsx +164 -0
- package/src/modules/library/components/NewPluginDialog.tsx +19 -5
- package/src/modules/library/components/PageActions.tsx +31 -9
- package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
- package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
- package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
- package/src/modules/library/components/PluginExtras.tsx +143 -18
- package/src/modules/library/components/PluginIndexRow.tsx +47 -12
- package/src/modules/library/components/PluginPage.tsx +234 -38
- package/src/modules/library/components/PluginRows.tsx +286 -0
- package/src/modules/library/components/PluginsSidebar.tsx +271 -238
- package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
- package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
- package/src/modules/library/components/ShareButton.tsx +17 -0
- package/src/modules/library/components/SkillsTree.tsx +204 -0
- package/src/modules/library/components/StatusDot.tsx +1 -0
- package/src/modules/library/components/TeamRoute.tsx +15 -0
- package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
- package/src/modules/library/components/plugin-page-parts.tsx +132 -23
- package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
- package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
- package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
- package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
- package/src/modules/library/hooks/useJoinRequests.ts +48 -18
- package/src/modules/library/hooks/useLibraryData.ts +92 -19
- package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
- package/src/modules/library/routes/library-paths.ts +46 -35
- package/src/modules/library/services/library.api.ts +89 -17
- package/src/modules/library/services/plugins.api.ts +161 -9
- package/src/modules/library/services/teams.api.ts +15 -0
- package/src/modules/library/services/tools.api.ts +78 -0
- package/src/modules/library/state/library-data.tsx +268 -37
- package/src/modules/library/utils/personal-plugin.ts +13 -15
- package/src/modules/library/utils/plugin-entries.ts +134 -0
- package/src/modules/library/utils/plugin-summary.ts +102 -0
- package/src/modules/library/utils/status.ts +204 -35
- package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
- package/src/modules/onboarding/agent-clients.ts +55 -23
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
- package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
- package/src/modules/pr/services/pr-merge.api.ts +2 -1
- package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
- package/src/modules/review/components/ReviewPanel.tsx +15 -17
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
- package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
- package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
- package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
- package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
- package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
- package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
- package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
- package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
- package/src/modules/secrets-vault/services/connect.api.ts +36 -5
- package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
- package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
- package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
- package/src/modules/settings/components/DeploymentPage.tsx +16 -22
- package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
- package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
- package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
- package/src/modules/settings/services/github-facade.api.ts +66 -0
- package/src/modules/settings/settings-nav-items.tsx +10 -2
- package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
- package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
- package/src/modules/setup/__tests__/setup.test.tsx +615 -4
- package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
- package/src/modules/setup/components/SetupGate.tsx +16 -16
- package/src/modules/setup/components/SetupScreen.tsx +711 -40
- package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
- package/src/modules/setup/services/setup.api.ts +218 -3
- package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
- package/src/modules/setup/utils/root-folders.ts +46 -0
- package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
- package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
- package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
- package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
- package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
- package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
- package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
- package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
- package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
- package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
- package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
- package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
- package/src/modules/toolbar/components/deployment-address.ts +29 -0
- package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
- package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
- package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
- package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
- package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
- package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
- package/src/modules/workflow/state/event-bus.context.ts +10 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
- package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
- package/src/modules/workspace/components/FileRoute.tsx +376 -22
- package/src/modules/workspace/components/FileViewer.tsx +166 -45
- package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
- package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
- package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
- package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
- package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
- package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
- package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
- package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
- package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
- package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
- package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
- package/src/modules/workspace/components/renderers/index.ts +53 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
- package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
- package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
- package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
- package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
- package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
- package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
- package/src/modules/workspace/routing/kb-routes.ts +207 -30
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
- package/src/modules/workspace/services/workspace.api.ts +57 -4
- package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
- package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
- package/src/modules/workspace/state/open-change-requests.tsx +100 -12
- package/src/modules/workspace/state/workspace.context.ts +130 -16
- package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
- package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
- package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
- package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
- package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
- package/src/modules/workspace/utils/file-trace.ts +50 -0
- package/src/modules/workspace/utils/fileTree.ts +126 -52
- package/src/modules/workspace/utils/frontmatter.ts +8 -4
- package/src/modules/workspace/utils/pasteLink.ts +90 -0
- package/src/modules/workspace/utils/treeConfirm.ts +338 -0
- package/src/modules/workspace/utils/uploadError.ts +29 -0
- package/src/shared/__tests__/marketplace-url.test.ts +59 -0
- package/src/shared/components/Badge.tsx +3 -1
- package/src/shared/components/Banner.tsx +5 -1
- package/src/shared/components/Button.tsx +16 -2
- package/src/shared/components/Dialog.tsx +27 -11
- package/src/shared/components/Menu.tsx +13 -1
- package/src/shared/components/PageShell.tsx +13 -8
- package/src/shared/components/__tests__/primitives.test.tsx +116 -2
- package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
- package/src/shared/components/index.ts +2 -0
- package/src/shared/components/useDismissableMenu.ts +32 -10
- package/src/shared/components/useFocusHandoff.ts +51 -0
- package/src/shared/components/useLatestRef.ts +28 -0
- package/src/shared/markdown/Markdown.tsx +12 -3
- package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
- package/src/shared/markdown/hrefs.ts +50 -0
- package/src/shared/marketplace-url.ts +118 -0
- package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
- package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
- package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
- package/src/shared/mcp/connect-snippets.ts +14 -9
- package/src/shared/mcp/index.ts +1 -1
- package/src/shared/theme/__tests__/header-band.test.ts +197 -0
- package/src/shared/theme/header.ts +75 -0
- package/src/shared/theme/measure.ts +7 -4
- package/src/shared/theme/tokens.css +34 -0
- package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
- package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
- package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
- package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
- package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
- package/src/modules/update-check/services/update-check.api.ts +0 -24
|
@@ -0,0 +1,160 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { render, screen, waitFor, within } from '@testing-library/react';
|
|
3
|
+
import userEvent from '@testing-library/user-event';
|
|
4
|
+
import type { FileTreeEntry } from '@bevel-software/platform-shared';
|
|
5
|
+
import type { AccessResponse } from '../api';
|
|
6
|
+
|
|
7
|
+
/**
|
|
8
|
+
* THE ROW A WRITE JUST CHANGED STAYS ON SCREEN.
|
|
9
|
+
*
|
|
10
|
+
* Razvan, on the deployed sheet: Alice had edit from this folder and read from
|
|
11
|
+
* a parent; picking Can read revoked the local edit — correctly — and Alice
|
|
12
|
+
* vanished. Not removed: with only the parent's read left she files under
|
|
13
|
+
* "People invited to <parent>", which is collapsed. The person being edited
|
|
14
|
+
* must not disappear mid-edit, so the section the row lands in opens itself.
|
|
15
|
+
*/
|
|
16
|
+
|
|
17
|
+
const api = vi.hoisted(() => ({
|
|
18
|
+
fetchFileAccess: vi.fn(),
|
|
19
|
+
grantAccess: vi.fn(),
|
|
20
|
+
revokeAccess: vi.fn(),
|
|
21
|
+
suggestPrincipals: vi.fn(),
|
|
22
|
+
}));
|
|
23
|
+
vi.mock('../api', async (importOriginal) => {
|
|
24
|
+
const actual = await importOriginal<typeof import('../api')>();
|
|
25
|
+
return { ...actual, ...api };
|
|
26
|
+
});
|
|
27
|
+
vi.mock('../../workspace/state/workspace.context', () => ({
|
|
28
|
+
useWorkspace: () => ({ workspaceId: 'ws-1', kbDirName: 'knowledge-base' }),
|
|
29
|
+
}));
|
|
30
|
+
vi.mock('../../auth/state/auth.context', () => ({
|
|
31
|
+
useAuth: () => ({ user: { email: 'me@x.com', name: 'Me' } }),
|
|
32
|
+
}));
|
|
33
|
+
|
|
34
|
+
import { ManageAccessDialog } from '../components/ManageAccessDialog';
|
|
35
|
+
|
|
36
|
+
const FOLDER: FileTreeEntry = {
|
|
37
|
+
name: 'Deals',
|
|
38
|
+
relativePath: 'knowledge-base/Sales/Deals',
|
|
39
|
+
type: 'directory',
|
|
40
|
+
} as unknown as FileTreeEntry;
|
|
41
|
+
const ALICE = { name: 'Alice', email: 'alice@x.com' };
|
|
42
|
+
const PARENT = 'Sales/access.md';
|
|
43
|
+
|
|
44
|
+
const BLANK = {
|
|
45
|
+
canRead: true,
|
|
46
|
+
canWrite: true,
|
|
47
|
+
canDownload: true,
|
|
48
|
+
canOwner: true,
|
|
49
|
+
eligible: { principals: [], roles: [], users: [] },
|
|
50
|
+
readers: { restricted: true, principals: [], roles: [], users: [] },
|
|
51
|
+
owners: { principals: [], roles: [], users: [] },
|
|
52
|
+
downloaders: { principals: [], roles: [], users: [] },
|
|
53
|
+
sources: {},
|
|
54
|
+
denials: {},
|
|
55
|
+
deniedHere: { principals: [], users: [] },
|
|
56
|
+
} as unknown as AccessResponse;
|
|
57
|
+
|
|
58
|
+
/** Alice: edit granted HERE, read from the parent as well — a row of this folder. */
|
|
59
|
+
const EDIT_HERE_READ_FROM_PARENT = {
|
|
60
|
+
...BLANK,
|
|
61
|
+
eligible: { principals: [], roles: [], users: [ALICE] },
|
|
62
|
+
readers: { restricted: true, principals: [], roles: [], users: [ALICE] },
|
|
63
|
+
sources: {
|
|
64
|
+
'u:alice@x.com': {
|
|
65
|
+
write: [{ kind: 'direct' }],
|
|
66
|
+
read: [{ kind: 'direct' }, { kind: 'ancestor', path: PARENT }],
|
|
67
|
+
},
|
|
68
|
+
},
|
|
69
|
+
} as unknown as AccessResponse;
|
|
70
|
+
|
|
71
|
+
/** After the local edit is revoked: only the parent's read remains — an inherited row. */
|
|
72
|
+
const READ_FROM_PARENT_ONLY = {
|
|
73
|
+
...BLANK,
|
|
74
|
+
readers: { restricted: true, principals: [], roles: [], users: [ALICE] },
|
|
75
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'ancestor', path: PARENT }] } },
|
|
76
|
+
} as unknown as AccessResponse;
|
|
77
|
+
|
|
78
|
+
function parentSection(): HTMLElement {
|
|
79
|
+
return screen.getByRole('button', { name: /People invited to Sales/ });
|
|
80
|
+
}
|
|
81
|
+
|
|
82
|
+
beforeEach(() => {
|
|
83
|
+
vi.clearAllMocks();
|
|
84
|
+
api.suggestPrincipals.mockResolvedValue({ roles: [], groups: [], people: [], peopleWithheld: false });
|
|
85
|
+
});
|
|
86
|
+
|
|
87
|
+
describe('ManageAccessDialog: the edited row stays on screen', () => {
|
|
88
|
+
it('a row that moves under a parent after a menu pick opens that parent\'s section', async () => {
|
|
89
|
+
const user = userEvent.setup();
|
|
90
|
+
api.fetchFileAccess.mockResolvedValue(EDIT_HERE_READ_FROM_PARENT);
|
|
91
|
+
api.revokeAccess.mockResolvedValue(READ_FROM_PARENT_ONLY);
|
|
92
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
93
|
+
await screen.findByText('Alice');
|
|
94
|
+
// Before: she is a row of this folder, and no parent section is open.
|
|
95
|
+
expect(screen.queryByRole('button', { name: /People invited to Sales/ })).toBeNull();
|
|
96
|
+
|
|
97
|
+
const triggers = await screen.findAllByRole('button', { name: /^can edit$/i });
|
|
98
|
+
await user.click(triggers[triggers.length - 1]);
|
|
99
|
+
const menu = screen.getAllByRole('button', { name: /^deny$/i }).slice(-1)[0]
|
|
100
|
+
.parentElement as HTMLElement;
|
|
101
|
+
await user.click(within(menu).getByRole('button', { name: /^can read$/i }));
|
|
102
|
+
|
|
103
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
104
|
+
// After: the parent's section exists AND is open, with Alice inside it —
|
|
105
|
+
// nobody had to find and click it.
|
|
106
|
+
await waitFor(() => expect(parentSection()).toHaveAttribute('aria-expanded', 'true'));
|
|
107
|
+
expect(screen.getByText('Alice')).toBeInTheDocument();
|
|
108
|
+
// And she is no longer listed as a row of this folder.
|
|
109
|
+
expect(screen.getByText(/No one is granted directly here/i)).toBeInTheDocument();
|
|
110
|
+
});
|
|
111
|
+
|
|
112
|
+
it('a row that moves under a parent after Remove is revealed too, behind the "Remove from parent?" prompt', async () => {
|
|
113
|
+
const user = userEvent.setup();
|
|
114
|
+
api.fetchFileAccess.mockResolvedValue(EDIT_HERE_READ_FROM_PARENT);
|
|
115
|
+
api.revokeAccess.mockResolvedValue(READ_FROM_PARENT_ONLY);
|
|
116
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
117
|
+
await screen.findByText('Alice');
|
|
118
|
+
|
|
119
|
+
await user.click(screen.getByRole('button', { name: 'Remove access' }));
|
|
120
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
121
|
+
// The chained prompt offers to finish the job; declining it must not leave
|
|
122
|
+
// her hidden in a closed section.
|
|
123
|
+
const prompt = await screen.findByRole('heading', { name: /remove from parent folder\?/i });
|
|
124
|
+
expect(prompt).toBeInTheDocument();
|
|
125
|
+
await user.click(screen.getByRole('button', { name: /^cancel$/i }));
|
|
126
|
+
expect(parentSection()).toHaveAttribute('aria-expanded', 'true');
|
|
127
|
+
expect(screen.getByText('Alice')).toBeInTheDocument();
|
|
128
|
+
});
|
|
129
|
+
|
|
130
|
+
it('a row that stays on this folder leaves the sections as they were', async () => {
|
|
131
|
+
const user = userEvent.setup();
|
|
132
|
+
api.fetchFileAccess.mockResolvedValue(EDIT_HERE_READ_FROM_PARENT);
|
|
133
|
+
// Granting owner keeps her a row of this folder.
|
|
134
|
+
api.grantAccess.mockResolvedValue({
|
|
135
|
+
...EDIT_HERE_READ_FROM_PARENT,
|
|
136
|
+
owners: { principals: [], roles: [], users: [ALICE] },
|
|
137
|
+
downloaders: { principals: [], roles: [], users: [ALICE] },
|
|
138
|
+
sources: {
|
|
139
|
+
'u:alice@x.com': {
|
|
140
|
+
owner: [{ kind: 'direct' }],
|
|
141
|
+
write: [{ kind: 'direct' }],
|
|
142
|
+
download: [{ kind: 'direct' }],
|
|
143
|
+
read: [{ kind: 'direct' }, { kind: 'ancestor', path: PARENT }],
|
|
144
|
+
},
|
|
145
|
+
},
|
|
146
|
+
} as unknown as AccessResponse);
|
|
147
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
148
|
+
await screen.findByText('Alice');
|
|
149
|
+
|
|
150
|
+
const triggers = await screen.findAllByRole('button', { name: /^can edit$/i });
|
|
151
|
+
await user.click(triggers[triggers.length - 1]);
|
|
152
|
+
const menu = screen.getAllByRole('button', { name: /^deny$/i }).slice(-1)[0]
|
|
153
|
+
.parentElement as HTMLElement;
|
|
154
|
+
await user.click(within(menu).getByRole('button', { name: /^owner$/i }));
|
|
155
|
+
|
|
156
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
|
|
157
|
+
expect(await screen.findByRole('button', { name: /^owner, can download$/i })).toBeInTheDocument();
|
|
158
|
+
expect(screen.queryByRole('button', { name: /People invited to Sales/ })).toBeNull();
|
|
159
|
+
});
|
|
160
|
+
});
|
|
@@ -182,7 +182,7 @@ async function openAliceMenu(
|
|
|
182
182
|
await user.click(trigger);
|
|
183
183
|
|
|
184
184
|
const panel = screen
|
|
185
|
-
.getByRole('button', { name:
|
|
185
|
+
.getByRole('button', { name: /^can download$/i })
|
|
186
186
|
.closest('div.fixed') as HTMLElement;
|
|
187
187
|
return { anchorEl, panel };
|
|
188
188
|
}
|
|
@@ -192,7 +192,7 @@ async function openAliceMenu(
|
|
|
192
192
|
*
|
|
193
193
|
* `Dialog` renders its body inside `overflow-y-auto`, which clips an
|
|
194
194
|
* absolutely positioned menu: opening the verb menu on a low grantee row cut
|
|
195
|
-
* everything past the first item or two — "
|
|
195
|
+
* everything past the first item or two — "Can download" included — off at
|
|
196
196
|
* the body's edge, unreachable without scrolling the list out from under the
|
|
197
197
|
* menu. The menus are `fixed` now, which means the placement is computed
|
|
198
198
|
* rather than inherited, and has to keep up with everything that moves it.
|
|
@@ -0,0 +1,166 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { render, screen, waitFor } from '@testing-library/react';
|
|
3
|
+
import userEvent from '@testing-library/user-event';
|
|
4
|
+
import type { FileTreeEntry } from '@bevel-software/platform-shared';
|
|
5
|
+
import type { AccessResponse } from '../api';
|
|
6
|
+
|
|
7
|
+
const api = vi.hoisted(() => ({
|
|
8
|
+
fetchFileAccess: vi.fn(),
|
|
9
|
+
grantAccess: vi.fn(),
|
|
10
|
+
revokeAccess: vi.fn(),
|
|
11
|
+
suggestPrincipals: vi.fn(),
|
|
12
|
+
}));
|
|
13
|
+
vi.mock('../api', async (importOriginal) => {
|
|
14
|
+
const actual = await importOriginal<typeof import('../api')>();
|
|
15
|
+
return { ...actual, ...api };
|
|
16
|
+
});
|
|
17
|
+
vi.mock('../../workspace/state/workspace.context', () => ({
|
|
18
|
+
useWorkspace: () => ({ workspaceId: 'main', kbDirName: 'knowledge-base' }),
|
|
19
|
+
}));
|
|
20
|
+
vi.mock('../../auth/state/auth.context', () => ({
|
|
21
|
+
useAuth: () => ({ user: { email: 'me@x.com', name: 'Me' } }),
|
|
22
|
+
}));
|
|
23
|
+
|
|
24
|
+
import { ManageAccessDialog } from '../components/ManageAccessDialog';
|
|
25
|
+
|
|
26
|
+
/**
|
|
27
|
+
* A file that exists only on an open change request's branch. Its access is
|
|
28
|
+
* edited THERE — the rules land in the proposed file and merge with it — and
|
|
29
|
+
* the sheet says so. Every other target keeps the ambient workspace and shows
|
|
30
|
+
* no notice.
|
|
31
|
+
*/
|
|
32
|
+
|
|
33
|
+
const ENTRY: FileTreeEntry = {
|
|
34
|
+
name: 'New.md',
|
|
35
|
+
relativePath: 'knowledge-base/Sales/New.md',
|
|
36
|
+
type: 'file',
|
|
37
|
+
} as unknown as FileTreeEntry;
|
|
38
|
+
const BRANCH = 'suggestions/me/knowledge';
|
|
39
|
+
const BRANCH_WS = encodeURIComponent(BRANCH);
|
|
40
|
+
const PROPOSAL = { number: 12, branch: BRANCH };
|
|
41
|
+
const NOTICE = /editing access on change request #12\. It takes effect when the request merges/i;
|
|
42
|
+
const A = { name: 'Alice', email: 'alice@x.com' };
|
|
43
|
+
|
|
44
|
+
/** Alice, granted `write` directly on the file. */
|
|
45
|
+
const VIEW = {
|
|
46
|
+
canRead: true,
|
|
47
|
+
canWrite: true,
|
|
48
|
+
canDownload: false,
|
|
49
|
+
canOwner: false,
|
|
50
|
+
eligible: { roles: [], users: [A] },
|
|
51
|
+
readers: { restricted: true, roles: [], users: [A] },
|
|
52
|
+
owners: { roles: [], users: [] },
|
|
53
|
+
downloaders: { roles: [], users: [] },
|
|
54
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'direct' }], write: [{ kind: 'direct' }] } },
|
|
55
|
+
} as AccessResponse;
|
|
56
|
+
|
|
57
|
+
async function checkDownloadOnAlice(user: ReturnType<typeof userEvent.setup>) {
|
|
58
|
+
const triggers = await screen.findAllByRole('button', { name: /^can edit$/i });
|
|
59
|
+
await user.click(triggers[triggers.length - 1]);
|
|
60
|
+
await user.click(await screen.findByRole('button', { name: /^can download$/i }));
|
|
61
|
+
}
|
|
62
|
+
|
|
63
|
+
describe('ManageAccessDialog: a proposed-only file', () => {
|
|
64
|
+
beforeEach(() => {
|
|
65
|
+
vi.clearAllMocks();
|
|
66
|
+
api.suggestPrincipals.mockResolvedValue({ roles: [], groups: [], people: [], peopleWithheld: false });
|
|
67
|
+
api.fetchFileAccess.mockResolvedValue(VIEW);
|
|
68
|
+
api.grantAccess.mockResolvedValue(VIEW);
|
|
69
|
+
api.revokeAccess.mockResolvedValue(VIEW);
|
|
70
|
+
});
|
|
71
|
+
|
|
72
|
+
it('reads access from the proposal branch and shows the notice', async () => {
|
|
73
|
+
render(<ManageAccessDialog entry={ENTRY} proposal={PROPOSAL} onClose={() => {}} />);
|
|
74
|
+
|
|
75
|
+
await waitFor(() =>
|
|
76
|
+
expect(api.fetchFileAccess).toHaveBeenCalledWith(BRANCH_WS, 'Sales/New.md', 'file'),
|
|
77
|
+
);
|
|
78
|
+
expect(api.fetchFileAccess).not.toHaveBeenCalledWith('main', expect.anything(), expect.anything());
|
|
79
|
+
expect(screen.getByText(NOTICE)).toBeInTheDocument();
|
|
80
|
+
});
|
|
81
|
+
|
|
82
|
+
it('wins over a pinned workspace: the file is not on any other branch', async () => {
|
|
83
|
+
render(
|
|
84
|
+
<ManageAccessDialog entry={ENTRY} workspaceId="main" proposal={PROPOSAL} onClose={() => {}} />,
|
|
85
|
+
);
|
|
86
|
+
await waitFor(() =>
|
|
87
|
+
expect(api.fetchFileAccess).toHaveBeenCalledWith(BRANCH_WS, 'Sales/New.md', 'file'),
|
|
88
|
+
);
|
|
89
|
+
});
|
|
90
|
+
|
|
91
|
+
it('grants on the proposal branch', async () => {
|
|
92
|
+
const user = userEvent.setup();
|
|
93
|
+
render(<ManageAccessDialog entry={ENTRY} proposal={PROPOSAL} onClose={() => {}} />);
|
|
94
|
+
await checkDownloadOnAlice(user);
|
|
95
|
+
|
|
96
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
|
|
97
|
+
expect(api.grantAccess).toHaveBeenCalledWith(
|
|
98
|
+
BRANCH_WS,
|
|
99
|
+
expect.objectContaining({ path: ENTRY.relativePath, kind: 'file', verb: 'download' }),
|
|
100
|
+
);
|
|
101
|
+
});
|
|
102
|
+
|
|
103
|
+
it('revokes on the proposal branch — symmetric with grant', async () => {
|
|
104
|
+
const user = userEvent.setup();
|
|
105
|
+
render(<ManageAccessDialog entry={ENTRY} proposal={PROPOSAL} onClose={() => {}} />);
|
|
106
|
+
// Remove sits beside the row's verb control, not inside its menu.
|
|
107
|
+
await user.click(await screen.findByRole('button', { name: 'Remove access' }));
|
|
108
|
+
|
|
109
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
110
|
+
expect(api.revokeAccess).toHaveBeenCalledWith(
|
|
111
|
+
BRANCH_WS,
|
|
112
|
+
expect.objectContaining({
|
|
113
|
+
path: ENTRY.relativePath,
|
|
114
|
+
principal: expect.objectContaining({ email: 'alice@x.com' }),
|
|
115
|
+
}),
|
|
116
|
+
);
|
|
117
|
+
});
|
|
118
|
+
|
|
119
|
+
it('surfaces a gate refusal from the proposal branch — never a silent success', async () => {
|
|
120
|
+
const user = userEvent.setup();
|
|
121
|
+
const { GitApiError } = await import('../../git/services/git.api');
|
|
122
|
+
api.grantAccess.mockRejectedValue(
|
|
123
|
+
new GitApiError(403, 'You need write access to Sales/New.md to change who can access it.', {}),
|
|
124
|
+
);
|
|
125
|
+
render(<ManageAccessDialog entry={ENTRY} proposal={PROPOSAL} onClose={() => {}} />);
|
|
126
|
+
await checkDownloadOnAlice(user);
|
|
127
|
+
|
|
128
|
+
expect(
|
|
129
|
+
await screen.findByText(/You need write access to Sales\/New\.md/i),
|
|
130
|
+
).toBeInTheDocument();
|
|
131
|
+
expect(api.grantAccess).toHaveBeenCalledWith(BRANCH_WS, expect.anything());
|
|
132
|
+
});
|
|
133
|
+
|
|
134
|
+
it('refuses to load when the request branch cannot be resolved, instead of editing another branch', async () => {
|
|
135
|
+
render(
|
|
136
|
+
<ManageAccessDialog entry={ENTRY} proposal={{ number: 12, branch: null }} onClose={() => {}} />,
|
|
137
|
+
);
|
|
138
|
+
expect(await screen.findByText(/branch of change request #12 could not be found/i)).toBeInTheDocument();
|
|
139
|
+
expect(screen.getByText(NOTICE)).toBeInTheDocument();
|
|
140
|
+
expect(api.fetchFileAccess).not.toHaveBeenCalled();
|
|
141
|
+
expect(screen.queryByRole('button', { name: /^share$/i })).toBeNull();
|
|
142
|
+
});
|
|
143
|
+
});
|
|
144
|
+
|
|
145
|
+
describe('ManageAccessDialog: an ordinary file (regression)', () => {
|
|
146
|
+
beforeEach(() => {
|
|
147
|
+
vi.clearAllMocks();
|
|
148
|
+
api.suggestPrincipals.mockResolvedValue({ roles: [], groups: [], people: [], peopleWithheld: false });
|
|
149
|
+
api.fetchFileAccess.mockResolvedValue(VIEW);
|
|
150
|
+
api.grantAccess.mockResolvedValue(VIEW);
|
|
151
|
+
});
|
|
152
|
+
|
|
153
|
+
it('keeps the ambient workspace and shows no proposal notice', async () => {
|
|
154
|
+
const user = userEvent.setup();
|
|
155
|
+
render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
|
|
156
|
+
|
|
157
|
+
await waitFor(() =>
|
|
158
|
+
expect(api.fetchFileAccess).toHaveBeenCalledWith('main', 'Sales/New.md', 'file'),
|
|
159
|
+
);
|
|
160
|
+
expect(screen.queryByText(/editing access on change request/i)).toBeNull();
|
|
161
|
+
|
|
162
|
+
await checkDownloadOnAlice(user);
|
|
163
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
|
|
164
|
+
expect(api.grantAccess).toHaveBeenCalledWith('main', expect.anything());
|
|
165
|
+
});
|
|
166
|
+
});
|