@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -9,9 +9,8 @@ import { PluginsSidebar, type PluginsSidebarProps } from '../components/PluginsS
9
9
  *
10
10
  * The sidebar itself only REPORTS the click: it suppresses the browser menu,
11
11
  * reads the pointer and the row synchronously, and hands both up. Everything
12
- * about which verbs are true for a given row lives in `LibraryLayout`, because
13
- * that is where the plugin summaries are — so that is where those assertions
14
- * live too.
12
+ * about which verbs are true for a given row lives in `LibraryLayout`, so that
13
+ * is where those assertions live too.
15
14
  */
16
15
 
17
16
  function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
@@ -20,21 +19,14 @@ function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
20
19
  const props: PluginsSidebarProps = {
21
20
  filter: { kind: 'all' },
22
21
  onSelect,
23
- plugins: [
24
- { plugin: 'Engineering', count: 4, attention: 0 },
25
- { plugin: 'GTM', count: 3, attention: 2 },
26
- ],
27
- lockedPlugins: ['Finance'],
28
22
  ownedCount: 2,
29
23
  ownedAttention: 0,
30
- personalPluginLabel: "Juan's Plugin",
31
- ungroupedCount: 1,
32
- attentionCount: 2,
33
- onFinishSetup: vi.fn(),
24
+ teams: [
25
+ { name: 'Engineering', count: 4, urgent: 0 },
26
+ { name: 'GTM', count: 3, urgent: 2 },
27
+ ],
34
28
  onCreatePlugin: vi.fn(),
35
29
  canCreatePlugin: true,
36
- pluginsIndexActive: false,
37
- onOpenPluginsIndex: vi.fn(),
38
30
  onContextMenu,
39
31
  ...over,
40
32
  };
@@ -42,19 +34,19 @@ function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
42
34
  return { onContextMenu, onSelect };
43
35
  }
44
36
 
45
- const nav = () => screen.getByRole('navigation', { name: 'Library plugins' });
37
+ const nav = () => screen.getByRole('navigation', { name: 'Library navigation' });
46
38
  const rightClick = (el: Element, at = { clientX: 120, clientY: 240 }) =>
47
39
  fireEvent.contextMenu(el, at);
48
40
 
49
41
  describe('PluginsSidebar: right-click', () => {
50
- it('reports a plugin row with its filter, its name and the pointer', () => {
42
+ it('reports a team row with its filter, its name and the pointer', () => {
51
43
  const { onContextMenu } = renderSidebar();
52
44
  const gtm = screen.getByRole('button', { name: /^GTM/ });
53
45
  rightClick(gtm, { clientX: 88, clientY: 310 });
54
46
 
55
47
  expect(onContextMenu).toHaveBeenCalledTimes(1);
56
48
  expect(onContextMenu).toHaveBeenCalledWith({
57
- filter: { kind: 'group', plugin: 'GTM' },
49
+ filter: { kind: 'team', group: 'GTM' },
58
50
  label: 'GTM',
59
51
  x: 88,
60
52
  y: 310,
@@ -71,42 +63,10 @@ describe('PluginsSidebar: right-click', () => {
71
63
  label: 'Owned by me',
72
64
  });
73
65
 
74
- rightClick(screen.getByRole('button', { name: /^Juan's Plugin/ }));
66
+ rightClick(screen.getByRole('button', { name: /^Everything/ }));
75
67
  expect(onContextMenu.mock.calls[1][0]).toMatchObject({
76
- filter: { kind: 'ungrouped' },
77
- label: "Juan's Plugin",
78
- });
79
- });
80
-
81
- /**
82
- * A locked row emits the same `{ kind: 'group' }` target a readable one does,
83
- * for the same reason its CLICK does: a plugin you are not in is still a place.
84
- * The label drops the "(locked)" suffix — that is the accessible name, not the
85
- * plugin's name, and the menu titles itself with the latter.
86
- */
87
- it('reports a locked row exactly like a readable plugin', () => {
88
- const { onContextMenu } = renderSidebar();
89
- rightClick(screen.getByRole('button', { name: 'Finance (locked)' }));
90
- expect(onContextMenu.mock.calls[0][0]).toMatchObject({
91
- filter: { kind: 'group', plugin: 'Finance' },
92
- label: 'Finance',
93
- });
94
- });
95
-
96
- /**
97
- * The home row has no `LibraryFilter` behind it — the index lists places, not
98
- * a slice of the catalog — so it reports `null` and gets the nav's own menu:
99
- * create a plugin, and none of the verbs that need a folder to point at.
100
- */
101
- it('reports the All plugins row with no filter, but with its own row and name', () => {
102
- const { onContextMenu } = renderSidebar();
103
- const home = screen.getByRole('button', { name: 'All plugins' });
104
- rightClick(home);
105
- expect(onContextMenu).toHaveBeenCalledTimes(1);
106
- expect(onContextMenu.mock.calls[0][0]).toMatchObject({
107
- filter: null,
108
- label: 'All plugins',
109
- row: home,
68
+ filter: { kind: 'all' },
69
+ label: 'Everything',
110
70
  });
111
71
  });
112
72
 
@@ -124,14 +84,14 @@ describe('PluginsSidebar: right-click', () => {
124
84
 
125
85
  /**
126
86
  * The nav wraps every row, so without `stopPropagation` a right-click on a
127
- * plugin would report the plugin AND then the empty space — and the layout
128
- * would render the empty-space menu, since the last call wins.
87
+ * row would report the row AND then the empty space — and the layout would
88
+ * render the empty-space menu, since the last call wins.
129
89
  */
130
90
  it('does not also report the nav when the click landed on a row', () => {
131
91
  const { onContextMenu } = renderSidebar();
132
92
  rightClick(screen.getByRole('button', { name: /^Engineering/ }));
133
93
  expect(onContextMenu).toHaveBeenCalledTimes(1);
134
- expect(onContextMenu.mock.calls[0][0].filter).toEqual({ kind: 'group', plugin: 'Engineering' });
94
+ expect(onContextMenu.mock.calls[0][0].filter).toEqual({ kind: 'team', group: 'Engineering' });
135
95
  });
136
96
 
137
97
  it('suppresses the browser menu when the click is being handled', () => {
@@ -157,12 +117,12 @@ describe('PluginsSidebar: right-click', () => {
157
117
  it('still navigates on a left click. The menu changes nothing about selection', () => {
158
118
  const { onSelect, onContextMenu } = renderSidebar();
159
119
  fireEvent.click(screen.getByRole('button', { name: /^GTM/ }));
160
- expect(onSelect).toHaveBeenCalledWith({ kind: 'group', plugin: 'GTM' });
120
+ expect(onSelect).toHaveBeenCalledWith({ kind: 'team', group: 'GTM' });
161
121
  expect(onContextMenu).not.toHaveBeenCalled();
162
122
  });
163
123
 
164
124
  it('marks the current row from the target it navigates to', () => {
165
- renderSidebar({ filter: { kind: 'group', plugin: 'GTM' } });
125
+ renderSidebar({ filter: { kind: 'team', group: 'GTM' } });
166
126
  expect(screen.getByRole('button', { name: /^GTM/ })).toHaveAttribute('aria-current', 'true');
167
127
  expect(screen.getByRole('button', { name: /^Engineering/ })).toHaveAttribute(
168
128
  'aria-current',
@@ -1,139 +1,181 @@
1
- import { describe, it, expect, vi, type Mock } from 'vitest';
2
- import { render, screen, fireEvent, cleanup } from '@testing-library/react';
1
+ import { describe, it, expect, vi, beforeEach, type Mock } from 'vitest';
2
+ import { render, screen, fireEvent, cleanup, within } from '@testing-library/react';
3
3
  import { PluginsSidebar, type PluginsSidebarProps } from '../components/PluginsSidebar';
4
4
  import type { LibraryFilter } from '../utils/status';
5
5
 
6
6
  /**
7
- * The sidebar as a pure view: given a filter and counts, which row is current,
8
- * what its count slot says, and which intent a click emits. It owns no state
9
- * and no navigation, so nothing here needs a router.
7
+ * The Library nav: two lenses, the groups as the server lists them, the two
8
+ * roots as trees. A pure view of the URL — `filter` in, intents out.
10
9
  */
11
10
 
12
11
  function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
13
12
  const onSelect = vi.fn();
14
- const onFinishSetup = vi.fn();
15
13
  const props: PluginsSidebarProps = {
16
14
  filter: { kind: 'all' },
17
15
  onSelect,
18
- plugins: [
19
- { plugin: 'Engineering', count: 4, attention: 0 },
20
- { plugin: 'GTM', count: 3, attention: 2 },
21
- { plugin: 'Product', count: 0, attention: 0 },
22
- ],
23
- lockedPlugins: [],
24
16
  ownedCount: 2,
25
17
  ownedAttention: 0,
26
- personalPluginLabel: "Juan's Plugin",
27
- ungroupedCount: 1,
28
- attentionCount: 2,
29
- onFinishSetup,
18
+ teams: [
19
+ { name: 'Engineering', count: 4, urgent: 0 },
20
+ { name: 'GTM', count: 3, urgent: 2 },
21
+ { name: 'Product', count: 0, urgent: 0 },
22
+ ],
30
23
  onCreatePlugin: vi.fn(),
31
- canCreatePlugin: true,
32
- pluginsIndexActive: false,
33
- onOpenPluginsIndex: vi.fn(),
34
-
24
+ canCreatePlugin: false,
35
25
  ...over,
36
26
  };
37
27
  render(<PluginsSidebar {...props} />);
38
28
  return {
39
29
  onSelect,
40
- onFinishSetup,
41
30
  onCreatePlugin: props.onCreatePlugin as Mock,
42
- onOpenPluginsIndex: props.onOpenPluginsIndex as Mock,
43
31
  };
44
32
  }
45
33
 
46
34
  const row = (name: RegExp | string) => screen.getByRole('button', { name });
47
35
 
48
36
  describe('PluginsSidebar', () => {
49
- it('leads with All plugins. The Library opens there, so the nav starts there', () => {
50
- const { onOpenPluginsIndex } = renderSidebar();
51
- const rows = screen.getAllByRole('button');
52
- expect(rows[0]).toHaveAccessibleName('All plugins');
53
- fireEvent.click(rows[0]);
54
- expect(onOpenPluginsIndex).toHaveBeenCalledTimes(1);
55
- });
56
-
57
- it('marks All plugins current on the index, and nothing else', () => {
58
- renderSidebar({ filter: null, pluginsIndexActive: true });
59
- expect(row(/^All plugins/)).toHaveAttribute('aria-current', 'true');
60
- expect(row(/^Everything/)).toHaveAttribute('aria-current', 'false');
61
- expect(row(/^Owned by me/)).toHaveAttribute('aria-current', 'false');
62
- });
37
+ // The remembered view is per-browser state; each test starts from a browser
38
+ // that remembers nothing.
39
+ beforeEach(() => window.localStorage.removeItem('bevel-library-sidebar-view'));
63
40
 
64
- it('keeps Everything as a lens of its own, since the root is the index now', () => {
41
+ it('leads with Everything, the Library home, and marks it current on the root', () => {
65
42
  renderSidebar({ filter: { kind: 'all' } });
43
+ const rows = screen.getAllByRole('button');
44
+ expect(rows[0]).toHaveAccessibleName('Everything');
66
45
  expect(row(/^Everything/)).toHaveAttribute('aria-current', 'true');
67
- expect(row(/^All plugins/)).toHaveAttribute('aria-current', 'false');
68
- });
69
-
70
- it('heads the plugin rows with what the list is: the set in your MCP', () => {
71
- renderSidebar();
72
- expect(screen.getByText('Included in your MCP')).toBeInTheDocument();
73
- });
74
-
75
- it("leads the plugins with the caller's own space", () => {
76
- renderSidebar({ filter: { kind: 'ungrouped' } });
77
- expect(row(/^Juan's Plugin/)).toHaveAttribute('aria-current', 'true');
78
46
  expect(row(/^Owned by me/)).toHaveAttribute('aria-current', 'false');
79
47
  });
80
48
 
81
- it('offers a way to make a plugin', () => {
82
- const { onCreatePlugin } = renderSidebar();
83
- fireEvent.click(screen.getByRole('button', { name: 'New plugin' }));
84
- expect(onCreatePlugin).toHaveBeenCalledTimes(1);
85
- });
86
-
87
- it('spells out Create a plugin while the MCP list is empty — the `+` alone is hover-hidden', () => {
88
- const { onCreatePlugin } = renderSidebar({ plugins: [] });
89
- fireEvent.click(screen.getByRole('button', { name: 'Create a plugin' }));
90
- expect(onCreatePlugin).toHaveBeenCalledTimes(1);
91
- });
92
-
93
- it('stands the create CTA down once a real plugin exists', () => {
94
- renderSidebar(); // default fixture has three plugins
95
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
96
- });
97
-
98
- it('stands the create CTA down when only locked plugins exist — someone already created them', () => {
99
- renderSidebar({ plugins: [], lockedPlugins: ['Ops'] });
100
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
49
+ it('lights no row on a page with no filter — an item page, a plugin page', () => {
50
+ renderSidebar({ filter: null });
51
+ for (const button of screen.getAllByRole('button')) {
52
+ expect(button).not.toHaveAttribute('aria-current', 'true');
53
+ }
101
54
  });
102
55
 
103
- it('stands the create CTA down for a non-admin, empty workspace or not', () => {
104
- renderSidebar({ plugins: [], lockedPlugins: [], canCreatePlugin: false });
105
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
56
+ it('offers two views under the lenses — Teams by default — and lists no plugins of its own', () => {
57
+ renderSidebar();
58
+ const tabs = screen.getByRole('tablist', { name: 'Sidebar view' });
59
+ expect(within(tabs).getByRole('tab', { name: 'Groups' })).toHaveAttribute('aria-selected', 'true');
60
+ expect(within(tabs).getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-selected', 'false');
61
+ expect(screen.getByRole('tabpanel', { name: 'Groups' })).toBeInTheDocument();
62
+ expect(screen.queryByText('Plugins')).not.toBeInTheDocument();
63
+ expect(screen.queryByText('All plugins')).not.toBeInTheDocument();
64
+ expect(screen.queryByText('Library')).not.toBeInTheDocument();
106
65
  });
107
66
 
108
- it('says nothing about creating when the prop is omitted — the nav a host app already had', () => {
109
- // `canCreatePlugin` is optional so this public props type survives the
110
- // upgrade. Omitted must mean OFF, which is the nav exactly as it shipped.
111
- renderSidebar({ plugins: [], lockedPlugins: [], canCreatePlugin: undefined });
112
- expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
67
+ it("lists the groups in the server's order and nothing else — your own space is not a group", () => {
68
+ renderSidebar({ filter: { kind: 'ungrouped' } });
69
+ const panel = screen.getByRole('tabpanel', { name: 'Groups' });
70
+ expect(within(panel).getAllByRole('button').map((b) => b.textContent)).toEqual([
71
+ 'Engineering4',
72
+ 'GTM2',
73
+ 'Product',
74
+ ]);
75
+ // The own-space page lights no row: it is reached from Everything, not from here.
76
+ expect(within(panel).queryByRole('button', { current: true })).toBeNull();
77
+ });
78
+
79
+ it('switches to the Advanced view, which holds the two trees — Skills before Plugins — and no team rows', () => {
80
+ renderSidebar({
81
+ skillsTree: <div data-testid="skills-tree">skills</div>,
82
+ pluginsTree: <div data-testid="plugins-tree">plugins</div>,
83
+ });
84
+ // The other view stays MOUNTED and hidden — the trees keep their state
85
+ // across a switch, and every tab's `aria-controls` names a real panel.
86
+ expect(screen.getByTestId('skills-tree')).not.toBeVisible();
87
+ expect(screen.getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-controls', 'library-view-advanced');
88
+ expect(document.getElementById('library-view-advanced')).not.toBeNull();
89
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
90
+ expect(screen.getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-selected', 'true');
91
+ const panel = screen.getByRole('tabpanel', { name: 'Advanced' });
92
+ const skills = within(panel).getByTestId('skills-tree');
93
+ const plugins = within(panel).getByTestId('plugins-tree');
94
+ expect(skills.compareDocumentPosition(plugins) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
95
+ // No heading over the trees: the tab already names the view.
96
+ expect(within(panel).queryByText('Files on disk')).toBeNull();
97
+ expect(screen.queryByRole('button', { name: /^Engineering/ })).toBeNull();
98
+ // The lenses belong to neither view and stay put.
99
+ expect(row(/^Everything/)).toBeInTheDocument();
100
+ expect(row(/^Owned by me/)).toBeInTheDocument();
101
+ });
102
+
103
+ it('remembers the view in the browser, and defaults to Teams when the browser remembers nothing', () => {
104
+ renderSidebar();
105
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
106
+ expect(window.localStorage.getItem('bevel-library-sidebar-view')).toBe('advanced');
107
+ cleanup();
108
+ renderSidebar();
109
+ expect(screen.getByRole('tab', { name: 'Advanced' })).toHaveAttribute('aria-selected', 'true');
110
+ window.localStorage.removeItem('bevel-library-sidebar-view');
111
+ cleanup();
112
+ renderSidebar();
113
+ expect(screen.getByRole('tab', { name: 'Groups' })).toHaveAttribute('aria-selected', 'true');
113
114
  });
114
115
 
115
- it('marks the selected plugin current and leaves the others alone', () => {
116
- renderSidebar({ filter: { kind: 'group', plugin: 'GTM' } });
116
+ it('is one tab stop: the arrows move between the views and choose as they go, Home and End go to the ends', () => {
117
+ renderSidebar();
118
+ const teams = screen.getByRole('tab', { name: 'Groups' });
119
+ const advanced = screen.getByRole('tab', { name: 'Advanced' });
120
+ // Roving tabIndex: only the chosen tab is in the Tab order.
121
+ expect(teams).toHaveAttribute('tabindex', '0');
122
+ expect(advanced).toHaveAttribute('tabindex', '-1');
123
+
124
+ teams.focus();
125
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'ArrowRight' });
126
+ expect(advanced).toHaveAttribute('aria-selected', 'true');
127
+ expect(document.activeElement).toBe(advanced);
128
+ expect(advanced).toHaveAttribute('tabindex', '0');
129
+ expect(teams).toHaveAttribute('tabindex', '-1');
130
+
131
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'ArrowRight' });
132
+ expect(teams).toHaveAttribute('aria-selected', 'true'); // wraps
133
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'End' });
134
+ expect(advanced).toHaveAttribute('aria-selected', 'true');
135
+ fireEvent.keyDown(screen.getByRole('tablist', { name: 'Sidebar view' }), { key: 'Home' });
136
+ expect(teams).toHaveAttribute('aria-selected', 'true');
137
+ expect(document.activeElement).toBe(teams);
138
+ });
139
+
140
+ it('answers a right-click on the switch with nothing — it is a control, not empty nav space', () => {
141
+ const onContextMenu = vi.fn();
142
+ renderSidebar({ onContextMenu });
143
+ fireEvent.contextMenu(screen.getByRole('tab', { name: 'Advanced' }));
144
+ fireEvent.contextMenu(screen.getByRole('tablist', { name: 'Sidebar view' }));
145
+ expect(onContextMenu).not.toHaveBeenCalled();
146
+ });
147
+
148
+ it('marks the selected team current and leaves the others alone', () => {
149
+ renderSidebar({ filter: { kind: 'team', group: 'GTM' } });
117
150
  expect(row(/^GTM/)).toHaveAttribute('aria-current', 'true');
118
151
  expect(row(/^Engineering/)).toHaveAttribute('aria-current', 'false');
152
+ expect(row(/^Everything/)).toHaveAttribute('aria-current', 'false');
119
153
  });
120
154
 
121
- it('shows the attention count instead of the item count when something needs setup', () => {
155
+ it("shows how much a team can use, in grey — and nothing at all for a team that can use nothing", () => {
122
156
  renderSidebar();
123
- // GTM: 3 items but 2 integrations need setup — amber wins the slot.
124
- expect(row(/^GTM/)).toHaveAccessibleName('GTM 2');
125
157
  expect(row(/^Engineering/)).toHaveAccessibleName('Engineering 4');
126
- // Never a grey 0: an empty plugin shows no count at all.
158
+ expect(within(row(/^Engineering/)).getByText('4')).toHaveClass('text-ink-faint');
159
+ // Never a grey 0.
127
160
  expect(row(/^Product/)).toHaveAccessibleName('Product');
128
161
  });
129
162
 
163
+ it("turns a team's count orange when its plugins lock its members out of a skill", () => {
164
+ renderSidebar();
165
+ // GTM can use 3 things, but 2 links are broken for its members: orange
166
+ // wins the slot — other people's problem outranks the inventory.
167
+ expect(row(/^GTM/)).toHaveAccessibleName('GTM 2');
168
+ const badge = within(row(/^GTM/)).getByText('2');
169
+ expect(badge).toHaveClass('text-urgent');
170
+ expect(badge).not.toHaveClass('text-wait');
171
+ });
172
+
130
173
  it('emits the right LibraryFilter per row', () => {
131
174
  const { onSelect } = renderSidebar();
132
175
  const expected: [RegExp, LibraryFilter][] = [
133
176
  [/^Everything/, { kind: 'all' }],
134
177
  [/^Owned by me/, { kind: 'owned' }],
135
- [/^GTM/, { kind: 'group', plugin: 'GTM' }],
136
- [/^Juan's Plugin/, { kind: 'ungrouped' }],
178
+ [/^GTM/, { kind: 'team', group: 'GTM' }],
137
179
  ];
138
180
  for (const [name, filter] of expected) {
139
181
  onSelect.mockClear();
@@ -142,11 +184,28 @@ describe('PluginsSidebar', () => {
142
184
  }
143
185
  });
144
186
 
145
- it("keeps the caller's own plugin listed even when it is empty", () => {
146
- // It is a PLACE, not a filtered view: a plugin you are always in does not
147
- // vanish because you have not put anything in it yet.
148
- renderSidebar({ ungroupedCount: 0 });
149
- expect(row(/^Juan's Plugin/)).toBeInTheDocument();
187
+ it('two teams may not share a name, but a team may share one with a lens — rows stay distinct', () => {
188
+ renderSidebar({ teams: [{ name: 'Everything', count: 1, urgent: 0 }] });
189
+ const rows = screen.getAllByRole('button', { name: /^Everything/ });
190
+ expect(rows).toHaveLength(2);
191
+ });
192
+
193
+ it('spells out Create a plugin in the Advanced view when told the workspace is untouched — the `+` alone is hover-hidden', () => {
194
+ const { onCreatePlugin } = renderSidebar({ canCreatePlugin: true });
195
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
196
+ fireEvent.click(screen.getByRole('button', { name: 'Create a plugin' }));
197
+ expect(onCreatePlugin).toHaveBeenCalledTimes(1);
198
+ });
199
+
200
+ it('says nothing about creating unless told to — the verdict is the layout\'s, and omitted means off', () => {
201
+ renderSidebar({ canCreatePlugin: false });
202
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
203
+ expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
204
+ cleanup();
205
+ window.localStorage.removeItem('bevel-library-sidebar-view');
206
+ renderSidebar({ canCreatePlugin: undefined });
207
+ fireEvent.click(screen.getByRole('tab', { name: 'Advanced' }));
208
+ expect(screen.queryByRole('button', { name: 'Create a plugin' })).not.toBeInTheDocument();
150
209
  });
151
210
 
152
211
  it('shows the owned count in grey, and amber only when something waits on you', () => {
@@ -156,16 +215,21 @@ describe('PluginsSidebar', () => {
156
215
  cleanup();
157
216
  renderSidebar({ ownedCount: 26, ownedAttention: 1 });
158
217
  expect(row(/^Owned by me/)).toHaveAccessibleName('Owned by me 1');
218
+ expect(within(row(/^Owned by me/)).getByText('1')).toHaveClass('text-wait');
159
219
  });
160
220
 
161
- it('sends the setup footer to Connect', () => {
162
- const { onFinishSetup } = renderSidebar();
163
- fireEvent.click(row(/integrations need setup/));
164
- expect(onFinishSetup).toHaveBeenCalledTimes(1);
165
- });
166
-
167
- it('hides the setup footer when nothing needs setup', () => {
168
- renderSidebar({ attentionCount: 0 });
221
+ /**
222
+ * The setup reminder is no longer the nav's last row — it is a footer row
223
+ * the layout passes to the frame (`IntegrationsSetupReminder`), which is
224
+ * what puts it on the same grid as the change-request dock beneath it.
225
+ * What this file has to hold is that the nav does NOT place it any more;
226
+ * the row itself is covered in `IntegrationsSetupReminder.test.tsx`.
227
+ */
228
+ it('is the nav and nothing else — no row of its own below it', () => {
229
+ renderSidebar();
169
230
  expect(screen.queryByRole('button', { name: /needs? setup/ })).not.toBeInTheDocument();
231
+ expect(screen.queryByText(/Finish now/)).not.toBeInTheDocument();
232
+ const nav = screen.getByRole('navigation', { name: 'Library navigation' });
233
+ expect(nav.parentElement?.childElementCount).toBe(1);
170
234
  });
171
235
  });
@@ -140,3 +140,19 @@ describe('PluginsSidebarMenu', () => {
140
140
  row.remove();
141
141
  });
142
142
  });
143
+
144
+ describe('PluginsSidebarMenu: Manage members', () => {
145
+ it('is absent unless the caller passes it', () => {
146
+ renderMenu();
147
+ expect(screen.queryByRole('menuitem', { name: 'Manage members' })).toBeNull();
148
+ });
149
+
150
+ it('comes last when present, and closes the menu when chosen', () => {
151
+ const onManageMembers = vi.fn();
152
+ const { onClose } = renderMenu({ onAdd: undefined, onManageAccess: undefined, onManageMembers });
153
+ expect(items()).toEqual(['New plugin', 'Copy link', 'Manage members']);
154
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Manage members' }));
155
+ expect(onManageMembers).toHaveBeenCalledTimes(1);
156
+ expect(onClose).toHaveBeenCalledTimes(1);
157
+ });
158
+ });
@@ -0,0 +1,106 @@
1
+ import { describe, it, expect, vi } from 'vitest';
2
+ import { render, screen, fireEvent } from '@testing-library/react';
3
+ import { MemoryRouter } from 'react-router-dom';
4
+ import { LibraryContext } from '../state/library-context';
5
+ import type { LibraryContextValue, LibraryItem } from '../state/library-data';
6
+ import type { PluginMembership } from '../services/library.api';
7
+ import { SharedViaPlugins } from '../components/skill-page/SharedViaPlugins';
8
+
9
+ /**
10
+ * The skill page's "In plugins" section, on the one question this ticket
11
+ * settles: who may be shared onward.
12
+ *
13
+ * The section used to read `metadata.lifecycle` off the catalog item and offer
14
+ * a retired skill nothing — the chooser went empty because the link API would
15
+ * have refused every choice. The API no longer refuses, so neither does this:
16
+ * a skill is offered every plugin the caller manages, whatever its frontmatter
17
+ * still declares.
18
+ */
19
+
20
+ const OK = { state: 'ok' as const, text: 'Ready' };
21
+
22
+ function pluginSummary(name: string) {
23
+ return {
24
+ name,
25
+ folders: [`Plugins/${name}`],
26
+ canRead: true,
27
+ canWrite: true,
28
+ } as LibraryContextValue['pluginSummaries'][number];
29
+ }
30
+
31
+ function lib(items: LibraryItem[]): LibraryContextValue {
32
+ return {
33
+ loading: false,
34
+ error: null,
35
+ skills: [],
36
+ pendingSkills: [],
37
+ pendingTools: [],
38
+ tools: [],
39
+ ownedSkills: new Set(),
40
+ writableSkills: new Set(),
41
+ ownedTools: new Set(),
42
+ allowedToolsBySkill: new Map(),
43
+ crs: [],
44
+ myCrNumbers: new Set(),
45
+ reload: vi.fn(),
46
+ items,
47
+ pluginSummaries: [pluginSummary('GTM')],
48
+ pluginsLoading: false,
49
+ pluginsError: null,
50
+ teams: [],
51
+ teamsLoading: false,
52
+ teamsError: null,
53
+ reloadPlugins: vi.fn(),
54
+ };
55
+ }
56
+
57
+ function renderSection(items: LibraryItem[], memberships: PluginMembership[] = []) {
58
+ render(
59
+ <MemoryRouter>
60
+ <LibraryContext.Provider value={lib(items)}>
61
+ <SharedViaPlugins
62
+ skillName="legacy"
63
+ skillPath="Skills/Eng/legacy"
64
+ memberships={memberships}
65
+ canWrite
66
+ onChanged={vi.fn()}
67
+ />
68
+ </LibraryContext.Provider>
69
+ </MemoryRouter>,
70
+ );
71
+ }
72
+
73
+ // The cast is the point: `lifecycle` is no longer part of `LibraryItem`, so a
74
+ // server still sending the key — from a SKILL.md that still declares it — is
75
+ // exactly the case that must change nothing here.
76
+ const legacy = {
77
+ kind: 'skill',
78
+ id: 'legacy',
79
+ name: 'legacy',
80
+ description: 'Old but readable.',
81
+ owned: true,
82
+ canWrite: true,
83
+ plugin: null,
84
+ shared: true,
85
+ plugins: [],
86
+ path: 'Skills/Eng/legacy',
87
+ status: OK,
88
+ lifecycle: 'retired',
89
+ } as LibraryItem;
90
+
91
+ describe('SharedViaPlugins', () => {
92
+ it('offers the plugins the caller manages to a skill whose frontmatter still says retired', async () => {
93
+ renderSection([legacy]);
94
+ fireEvent.click(screen.getByRole('button', { name: 'Add to plugin…' }));
95
+ expect(await screen.findByRole('option', { name: 'GTM' })).toBeInTheDocument();
96
+ });
97
+
98
+ it('leaves out only the plugins the skill is already in', () => {
99
+ renderSection([legacy], [{ name: 'GTM', linked: true, granted: true }]);
100
+ // The one managed plugin already holds it, so there is nothing to add —
101
+ // an absent chooser, not an empty one, and for a reason that is about
102
+ // membership rather than about the skill's declared lifecycle.
103
+ expect(screen.queryByRole('button', { name: 'Add to plugin…' })).not.toBeInTheDocument();
104
+ expect(screen.getByText('GTM')).toBeInTheDocument();
105
+ });
106
+ });