@bevel-software/platform-core-frontend 0.14.0 → 0.19.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/THIRD-PARTY-NOTICES.md +2 -2
- package/package.json +3 -3
- package/src/core/CoreAppShell.tsx +34 -26
- package/src/core/__tests__/AppChrome.test.tsx +0 -3
- package/src/core/__tests__/bootstrap.test.ts +33 -1
- package/src/core/__tests__/events.test.ts +43 -0
- package/src/core/bootstrap.ts +38 -1
- package/src/core/events.ts +85 -3
- package/src/core/registry.ts +1 -1
- package/src/lib/__tests__/api.test.ts +38 -0
- package/src/lib/__tests__/email.test.ts +44 -0
- package/src/lib/api.ts +19 -2
- package/src/lib/email.ts +37 -1
- package/src/lib/utils.ts +2 -0
- package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
- package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
- package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
- package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
- package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
- package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
- package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
- package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
- package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
- package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
- package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
- package/src/modules/access/api.ts +192 -10
- package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
- package/src/modules/access/manage-access-affordance.ts +17 -0
- package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
- package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
- package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
- package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
- package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
- package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
- package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
- package/src/modules/admin/components/AddMemberInput.tsx +268 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
- package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
- package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
- package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
- package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
- package/src/modules/admin/components/group-members-path.ts +32 -0
- package/src/modules/admin/services/connection-keys.api.ts +47 -0
- package/src/modules/admin/services/roles.api.ts +12 -1
- package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
- package/src/modules/auth/components/AccountPage.tsx +73 -54
- package/src/modules/auth/components/LoginScreen.tsx +1 -0
- package/src/modules/auth/services/account.api.ts +78 -4
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
- package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
- package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
- package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
- package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
- package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
- package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
- package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
- package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
- package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
- package/src/modules/change-requests/services/change-requests.api.ts +57 -1
- package/src/modules/change-requests/services/denied-file.api.ts +53 -0
- package/src/modules/change-requests/services/propose.api.ts +97 -8
- package/src/modules/change-requests/utils/approval.ts +15 -0
- package/src/modules/change-requests/utils/author.ts +32 -0
- package/src/modules/change-requests/utils/readFailure.ts +110 -0
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
- package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
- package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
- package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
- package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
- package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
- package/src/modules/git/services/error-messages.ts +12 -0
- package/src/modules/git/services/pr-prompts.ts +5 -5
- package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
- package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
- package/src/modules/layout/components/AppLayout.tsx +2 -0
- package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
- package/src/modules/layout/components/SidebarFrame.tsx +109 -4
- package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
- package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
- package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
- package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
- package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
- package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
- package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
- package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
- package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
- package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
- package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
- package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
- package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
- package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
- package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
- package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
- package/src/modules/library/__tests__/auth-harness.tsx +9 -9
- package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
- package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
- package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
- package/src/modules/library/__tests__/library-data.test.ts +7 -0
- package/src/modules/library/__tests__/library-paths.test.ts +75 -0
- package/src/modules/library/__tests__/link-membership.test.ts +129 -0
- package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
- package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
- package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
- package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
- package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
- package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
- package/src/modules/library/__tests__/status.test.ts +82 -2
- package/src/modules/library/__tests__/tools.api.test.ts +44 -1
- package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
- package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
- package/src/modules/library/components/AddDialogTabs.tsx +103 -0
- package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
- package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
- package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
- package/src/modules/library/components/LibraryCard.tsx +149 -34
- package/src/modules/library/components/LibraryLayout.tsx +120 -247
- package/src/modules/library/components/LibraryPage.tsx +172 -39
- package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
- package/src/modules/library/components/LockedPluginView.tsx +63 -35
- package/src/modules/library/components/NameWithBadges.tsx +164 -0
- package/src/modules/library/components/NewPluginDialog.tsx +19 -5
- package/src/modules/library/components/PageActions.tsx +31 -9
- package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
- package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
- package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
- package/src/modules/library/components/PluginExtras.tsx +143 -18
- package/src/modules/library/components/PluginIndexRow.tsx +47 -12
- package/src/modules/library/components/PluginPage.tsx +234 -38
- package/src/modules/library/components/PluginRows.tsx +286 -0
- package/src/modules/library/components/PluginsSidebar.tsx +271 -238
- package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
- package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
- package/src/modules/library/components/ShareButton.tsx +17 -0
- package/src/modules/library/components/SkillsTree.tsx +204 -0
- package/src/modules/library/components/StatusDot.tsx +1 -0
- package/src/modules/library/components/TeamRoute.tsx +15 -0
- package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
- package/src/modules/library/components/plugin-page-parts.tsx +132 -23
- package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
- package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
- package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
- package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
- package/src/modules/library/hooks/useJoinRequests.ts +48 -18
- package/src/modules/library/hooks/useLibraryData.ts +92 -19
- package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
- package/src/modules/library/routes/library-paths.ts +46 -35
- package/src/modules/library/services/library.api.ts +89 -17
- package/src/modules/library/services/plugins.api.ts +161 -9
- package/src/modules/library/services/teams.api.ts +15 -0
- package/src/modules/library/services/tools.api.ts +78 -0
- package/src/modules/library/state/library-data.tsx +268 -37
- package/src/modules/library/utils/personal-plugin.ts +13 -15
- package/src/modules/library/utils/plugin-entries.ts +134 -0
- package/src/modules/library/utils/plugin-summary.ts +102 -0
- package/src/modules/library/utils/status.ts +204 -35
- package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
- package/src/modules/onboarding/agent-clients.ts +55 -23
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
- package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
- package/src/modules/pr/services/pr-merge.api.ts +2 -1
- package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
- package/src/modules/review/components/ReviewPanel.tsx +15 -17
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
- package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
- package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
- package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
- package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
- package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
- package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
- package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
- package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
- package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
- package/src/modules/secrets-vault/services/connect.api.ts +36 -5
- package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
- package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
- package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
- package/src/modules/settings/components/DeploymentPage.tsx +16 -22
- package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
- package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
- package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
- package/src/modules/settings/services/github-facade.api.ts +66 -0
- package/src/modules/settings/settings-nav-items.tsx +10 -2
- package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
- package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
- package/src/modules/setup/__tests__/setup.test.tsx +615 -4
- package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
- package/src/modules/setup/components/SetupGate.tsx +16 -16
- package/src/modules/setup/components/SetupScreen.tsx +711 -40
- package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
- package/src/modules/setup/services/setup.api.ts +218 -3
- package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
- package/src/modules/setup/utils/root-folders.ts +46 -0
- package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
- package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
- package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
- package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
- package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
- package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
- package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
- package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
- package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
- package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
- package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
- package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
- package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
- package/src/modules/toolbar/components/deployment-address.ts +29 -0
- package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
- package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
- package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
- package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
- package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
- package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
- package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
- package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
- package/src/modules/workflow/state/event-bus.context.ts +10 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
- package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
- package/src/modules/workspace/components/FileRoute.tsx +376 -22
- package/src/modules/workspace/components/FileViewer.tsx +166 -45
- package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
- package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
- package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
- package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
- package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
- package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
- package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
- package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
- package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
- package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
- package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
- package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
- package/src/modules/workspace/components/renderers/index.ts +53 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
- package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
- package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
- package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
- package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
- package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
- package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
- package/src/modules/workspace/routing/kb-routes.ts +207 -30
- package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
- package/src/modules/workspace/services/workspace.api.ts +57 -4
- package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
- package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
- package/src/modules/workspace/state/open-change-requests.tsx +100 -12
- package/src/modules/workspace/state/workspace.context.ts +130 -16
- package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
- package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
- package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
- package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
- package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
- package/src/modules/workspace/utils/file-trace.ts +50 -0
- package/src/modules/workspace/utils/fileTree.ts +126 -52
- package/src/modules/workspace/utils/frontmatter.ts +8 -4
- package/src/modules/workspace/utils/pasteLink.ts +90 -0
- package/src/modules/workspace/utils/treeConfirm.ts +338 -0
- package/src/modules/workspace/utils/uploadError.ts +29 -0
- package/src/shared/__tests__/marketplace-url.test.ts +59 -0
- package/src/shared/components/Badge.tsx +3 -1
- package/src/shared/components/Banner.tsx +5 -1
- package/src/shared/components/Button.tsx +16 -2
- package/src/shared/components/Dialog.tsx +27 -11
- package/src/shared/components/Menu.tsx +13 -1
- package/src/shared/components/PageShell.tsx +13 -8
- package/src/shared/components/__tests__/primitives.test.tsx +116 -2
- package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
- package/src/shared/components/index.ts +2 -0
- package/src/shared/components/useDismissableMenu.ts +32 -10
- package/src/shared/components/useFocusHandoff.ts +51 -0
- package/src/shared/components/useLatestRef.ts +28 -0
- package/src/shared/markdown/Markdown.tsx +12 -3
- package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
- package/src/shared/markdown/hrefs.ts +50 -0
- package/src/shared/marketplace-url.ts +118 -0
- package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
- package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
- package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
- package/src/shared/mcp/connect-snippets.ts +14 -9
- package/src/shared/mcp/index.ts +1 -1
- package/src/shared/theme/__tests__/header-band.test.ts +197 -0
- package/src/shared/theme/header.ts +75 -0
- package/src/shared/theme/measure.ts +7 -4
- package/src/shared/theme/tokens.css +34 -0
- package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
- package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
- package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
- package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
- package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
- package/src/modules/update-check/services/update-check.api.ts +0 -24
|
@@ -0,0 +1,510 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
|
+
import { render, screen, waitFor, within } from '@testing-library/react';
|
|
3
|
+
import userEvent from '@testing-library/user-event';
|
|
4
|
+
import type { FileTreeEntry } from '@bevel-software/platform-shared';
|
|
5
|
+
import type { AccessResponse } from '../api';
|
|
6
|
+
|
|
7
|
+
/**
|
|
8
|
+
* ONE MENU PER ROW, AND A RESTRICTION KEEPS THE PERSON VISIBLE.
|
|
9
|
+
*
|
|
10
|
+
* The tester unticked "Can edit" for someone whose edit came from a parent
|
|
11
|
+
* folder, chose "Restrict just this folder", and watched them vanish. The
|
|
12
|
+
* restriction itself was right — a verb-scoped `deny write` here, with the read
|
|
13
|
+
* their parent grant implies left standing — but the sheet built its "on this
|
|
14
|
+
* folder" list from LOCAL GRANTS, and a person whose only local entry is a
|
|
15
|
+
* DENIAL has none. They fell into the collapsed inherited section and read as
|
|
16
|
+
* gone.
|
|
17
|
+
*
|
|
18
|
+
* Two things change, and these tests hold both:
|
|
19
|
+
* - the row is decided by local ENTRIES, grant or denial, so a restriction
|
|
20
|
+
* keeps the person on this folder, saying per verb where each one stands;
|
|
21
|
+
* - the prompt is gone. Every row carries the same menu — the four sets, then
|
|
22
|
+
* Deny — and picking one writes whatever difference it implies, in the
|
|
23
|
+
* background. Below the parent that means denials; back up again it means
|
|
24
|
+
* lifting them.
|
|
25
|
+
*/
|
|
26
|
+
|
|
27
|
+
const api = vi.hoisted(() => ({
|
|
28
|
+
fetchFileAccess: vi.fn(),
|
|
29
|
+
grantAccess: vi.fn(),
|
|
30
|
+
revokeAccess: vi.fn(),
|
|
31
|
+
suggestPrincipals: vi.fn(),
|
|
32
|
+
}));
|
|
33
|
+
vi.mock('../api', async (importOriginal) => {
|
|
34
|
+
const actual = await importOriginal<typeof import('../api')>();
|
|
35
|
+
return { ...actual, ...api };
|
|
36
|
+
});
|
|
37
|
+
vi.mock('../../workspace/state/workspace.context', () => ({
|
|
38
|
+
useWorkspace: () => ({ workspaceId: 'ws-1', kbDirName: 'knowledge-base' }),
|
|
39
|
+
}));
|
|
40
|
+
vi.mock('../../auth/state/auth.context', () => ({
|
|
41
|
+
useAuth: () => ({ user: { email: 'me@x.com', name: 'Me' } }),
|
|
42
|
+
}));
|
|
43
|
+
|
|
44
|
+
import { ManageAccessDialog } from '../components/ManageAccessDialog';
|
|
45
|
+
|
|
46
|
+
const KB = 'knowledge-base';
|
|
47
|
+
/** A FOLDER target: restrictions here are written into its own `access.md`. */
|
|
48
|
+
const FOLDER: FileTreeEntry = {
|
|
49
|
+
name: 'Deals',
|
|
50
|
+
relativePath: `${KB}/Sales/Deals`,
|
|
51
|
+
type: 'directory',
|
|
52
|
+
} as unknown as FileTreeEntry;
|
|
53
|
+
const ALICE = { name: 'Alice', email: 'alice@x.com' };
|
|
54
|
+
const PARENT = 'Sales/access.md';
|
|
55
|
+
|
|
56
|
+
/** The shell every view below fills in: nobody, nothing, caller can manage. */
|
|
57
|
+
const BLANK = {
|
|
58
|
+
canRead: true,
|
|
59
|
+
canWrite: true,
|
|
60
|
+
canDownload: true,
|
|
61
|
+
canOwner: true,
|
|
62
|
+
eligible: { principals: [], roles: [], users: [] },
|
|
63
|
+
readers: { restricted: true, principals: [], roles: [], users: [] },
|
|
64
|
+
owners: { principals: [], roles: [], users: [] },
|
|
65
|
+
downloaders: { principals: [], roles: [], users: [] },
|
|
66
|
+
sources: {},
|
|
67
|
+
denials: {},
|
|
68
|
+
deniedHere: { principals: [], users: [] },
|
|
69
|
+
} as unknown as AccessResponse;
|
|
70
|
+
|
|
71
|
+
/** Alice holds EDIT (and the read it implies) from the parent folder — nothing here. */
|
|
72
|
+
const EDIT_FROM_PARENT = {
|
|
73
|
+
...BLANK,
|
|
74
|
+
eligible: { principals: [], roles: [], users: [ALICE] },
|
|
75
|
+
readers: { restricted: true, principals: [], roles: [], users: [ALICE] },
|
|
76
|
+
sources: {
|
|
77
|
+
'u:alice@x.com': {
|
|
78
|
+
read: [{ kind: 'ancestor', path: PARENT }],
|
|
79
|
+
write: [{ kind: 'ancestor', path: PARENT }],
|
|
80
|
+
},
|
|
81
|
+
},
|
|
82
|
+
} as unknown as AccessResponse;
|
|
83
|
+
|
|
84
|
+
/**
|
|
85
|
+
* After `deny write` is written here: Alice keeps the read her parent EDIT
|
|
86
|
+
* grant implies (denials do not fold the way grants do), and the restriction is
|
|
87
|
+
* reported as a local denial — the entry that keeps her row on this folder.
|
|
88
|
+
*/
|
|
89
|
+
const WRITE_RESTRICTED_HERE = {
|
|
90
|
+
...BLANK,
|
|
91
|
+
readers: { restricted: true, principals: [], roles: [], users: [ALICE] },
|
|
92
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'ancestor', path: PARENT }] } },
|
|
93
|
+
denials: { 'u:alice@x.com': { write: [{ kind: 'direct' }] } },
|
|
94
|
+
deniedHere: { principals: [], users: [ALICE] },
|
|
95
|
+
} as unknown as AccessResponse;
|
|
96
|
+
|
|
97
|
+
/** After Deny: every verb denied here, so Alice is in no eligible list at all. */
|
|
98
|
+
const DENIED_HERE = {
|
|
99
|
+
...BLANK,
|
|
100
|
+
denials: {
|
|
101
|
+
'u:alice@x.com': {
|
|
102
|
+
read: [{ kind: 'direct' }],
|
|
103
|
+
write: [{ kind: 'direct' }],
|
|
104
|
+
download: [{ kind: 'direct' }],
|
|
105
|
+
owner: [{ kind: 'direct' }],
|
|
106
|
+
},
|
|
107
|
+
},
|
|
108
|
+
deniedHere: { principals: [], users: [ALICE] },
|
|
109
|
+
} as unknown as AccessResponse;
|
|
110
|
+
|
|
111
|
+
/**
|
|
112
|
+
* Expand the "People invited to Sales" disclosure.
|
|
113
|
+
*
|
|
114
|
+
* A row with no entry on this folder at all still belongs to the parent's
|
|
115
|
+
* section — that part is unchanged, and correct. What this ticket fixes is the
|
|
116
|
+
* row that DOES have an entry here (a denial), which must not be filed there.
|
|
117
|
+
*/
|
|
118
|
+
async function expandParentSection(user: ReturnType<typeof userEvent.setup>) {
|
|
119
|
+
await user.click(await screen.findByRole('button', { name: /People invited to Sales/ }));
|
|
120
|
+
}
|
|
121
|
+
|
|
122
|
+
/** Open a grantee row's verb menu and return the panel holding its items. */
|
|
123
|
+
async function openRowMenu(
|
|
124
|
+
user: ReturnType<typeof userEvent.setup>,
|
|
125
|
+
summary: RegExp,
|
|
126
|
+
): Promise<HTMLElement> {
|
|
127
|
+
const triggers = await screen.findAllByRole('button', { name: summary });
|
|
128
|
+
// The add-row selector can read the same words; a row's trigger is the later one.
|
|
129
|
+
await user.click(triggers[triggers.length - 1]);
|
|
130
|
+
return screen.getAllByRole('button', { name: /^deny$/i }).slice(-1)[0]
|
|
131
|
+
.parentElement as HTMLElement;
|
|
132
|
+
}
|
|
133
|
+
|
|
134
|
+
/** The row-menu item for one set. */
|
|
135
|
+
function setItem(menu: HTMLElement, label: RegExp): HTMLElement {
|
|
136
|
+
return within(menu).getByRole('button', { name: label });
|
|
137
|
+
}
|
|
138
|
+
|
|
139
|
+
beforeEach(() => {
|
|
140
|
+
vi.clearAllMocks();
|
|
141
|
+
api.suggestPrincipals.mockResolvedValue({
|
|
142
|
+
roles: [],
|
|
143
|
+
groups: [],
|
|
144
|
+
people: [],
|
|
145
|
+
peopleWithheld: false,
|
|
146
|
+
});
|
|
147
|
+
});
|
|
148
|
+
|
|
149
|
+
describe('ManageAccessDialog: lowering an inherited set by one verb', () => {
|
|
150
|
+
it('picking Can read on a parent-granted editor writes a verb-scoped deny here, with no prompt', async () => {
|
|
151
|
+
const user = userEvent.setup();
|
|
152
|
+
api.fetchFileAccess.mockResolvedValue(EDIT_FROM_PARENT);
|
|
153
|
+
api.revokeAccess.mockResolvedValue(WRITE_RESTRICTED_HERE);
|
|
154
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
155
|
+
await expandParentSection(user);
|
|
156
|
+
await screen.findByText("Alice");
|
|
157
|
+
|
|
158
|
+
const menu = await openRowMenu(user, /^can edit$/i);
|
|
159
|
+
await user.click(setItem(menu, /^can read$/i));
|
|
160
|
+
|
|
161
|
+
// ONE write: a deny of `write` at this folder. Read is untouched — the
|
|
162
|
+
// grammar leaves the parent's implied read standing, which is the whole
|
|
163
|
+
// reason a verb-scoped denial is the right instrument.
|
|
164
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
165
|
+
expect(api.revokeAccess).toHaveBeenCalledWith('ws-1', {
|
|
166
|
+
path: FOLDER.relativePath,
|
|
167
|
+
kind: 'folder',
|
|
168
|
+
principal: { kind: 'user', email: 'alice@x.com', displayName: 'Alice' },
|
|
169
|
+
mode: 'deny-here',
|
|
170
|
+
verb: 'write',
|
|
171
|
+
});
|
|
172
|
+
expect(api.grantAccess).not.toHaveBeenCalled();
|
|
173
|
+
// No detour: the restriction is written straight from the row.
|
|
174
|
+
expect(screen.queryByRole('heading', { name: /remove from parent folder\?/i })).toBeNull();
|
|
175
|
+
expect(screen.queryByRole('heading', { name: /restrict access here\?/i })).toBeNull();
|
|
176
|
+
});
|
|
177
|
+
|
|
178
|
+
it('the restricted person STAYS on this folder, with each verb explained', async () => {
|
|
179
|
+
const user = userEvent.setup();
|
|
180
|
+
api.fetchFileAccess.mockResolvedValue(WRITE_RESTRICTED_HERE);
|
|
181
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
182
|
+
|
|
183
|
+
// The bug: her only local entry is a denial, so a sections-by-local-GRANT
|
|
184
|
+
// rule filed her under the collapsed parent section and she looked removed.
|
|
185
|
+
const heading = await screen.findByRole('heading', { name: /on this folder/i });
|
|
186
|
+
expect(heading).toBeInTheDocument();
|
|
187
|
+
expect(screen.queryByRole('button', { name: /People invited to Sales/ })).toBeNull();
|
|
188
|
+
expect(screen.getByText('Alice')).toBeInTheDocument();
|
|
189
|
+
|
|
190
|
+
// And the row says, verb by verb, where each one stands.
|
|
191
|
+
const menu = await openRowMenu(user, /^can read$/i);
|
|
192
|
+
expect(setItem(menu, /^can edit$/i)).toHaveAttribute('aria-description', 'restricted here');
|
|
193
|
+
expect(setItem(menu, /^can read$/i)).toHaveAttribute('aria-description', 'from Sales');
|
|
194
|
+
});
|
|
195
|
+
|
|
196
|
+
it('a GROUP with download from the parent: unticking Can download denies download for the group', async () => {
|
|
197
|
+
const user = userEvent.setup();
|
|
198
|
+
const GTM = { name: 'GTM Team', kind: 'group' as const };
|
|
199
|
+
api.fetchFileAccess.mockResolvedValue({
|
|
200
|
+
...BLANK,
|
|
201
|
+
readers: { restricted: true, principals: [GTM], roles: ['GTM Team'], users: [] },
|
|
202
|
+
downloaders: { principals: [GTM], roles: ['GTM Team'], users: [] },
|
|
203
|
+
sources: {
|
|
204
|
+
'g:gtm team': {
|
|
205
|
+
read: [{ kind: 'ancestor', path: PARENT }],
|
|
206
|
+
download: [{ kind: 'ancestor', path: PARENT }],
|
|
207
|
+
},
|
|
208
|
+
},
|
|
209
|
+
} as unknown as AccessResponse);
|
|
210
|
+
api.revokeAccess.mockResolvedValue({
|
|
211
|
+
...BLANK,
|
|
212
|
+
readers: { restricted: true, principals: [GTM], roles: ['GTM Team'], users: [] },
|
|
213
|
+
sources: { 'g:gtm team': { read: [{ kind: 'ancestor', path: PARENT }] } },
|
|
214
|
+
denials: { 'g:gtm team': { download: [{ kind: 'direct' }] } },
|
|
215
|
+
deniedHere: { principals: [GTM], users: [] },
|
|
216
|
+
} as unknown as AccessResponse);
|
|
217
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
218
|
+
await expandParentSection(user);
|
|
219
|
+
await screen.findByText("GTM Team");
|
|
220
|
+
|
|
221
|
+
const menu = await openRowMenu(user, /^can read, can download$/i);
|
|
222
|
+
// Download is its own axis: the checked item is the one that takes it
|
|
223
|
+
// away. Can read is the tier the group already sits at, with nothing
|
|
224
|
+
// below it, so it is not the instrument here.
|
|
225
|
+
await user.click(setItem(menu, /^can download$/i));
|
|
226
|
+
|
|
227
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
228
|
+
expect(api.revokeAccess).toHaveBeenCalledWith(
|
|
229
|
+
'ws-1',
|
|
230
|
+
// The GROUP kind round-trips: a bare token, not a `role/` one.
|
|
231
|
+
expect.objectContaining({
|
|
232
|
+
mode: 'deny-here',
|
|
233
|
+
verb: 'download',
|
|
234
|
+
principal: { kind: 'group', group: 'GTM Team' },
|
|
235
|
+
}),
|
|
236
|
+
);
|
|
237
|
+
});
|
|
238
|
+
});
|
|
239
|
+
|
|
240
|
+
describe('ManageAccessDialog: raising a lowered set back', () => {
|
|
241
|
+
it('picking Can edit again lifts the local deny and grants nothing — the parent already gives it', async () => {
|
|
242
|
+
const user = userEvent.setup();
|
|
243
|
+
api.fetchFileAccess.mockResolvedValue(WRITE_RESTRICTED_HERE);
|
|
244
|
+
// Lifting the denial restores what the parent grants, and the fresh view
|
|
245
|
+
// says so: write is hers again, from Sales.
|
|
246
|
+
api.revokeAccess.mockResolvedValue(EDIT_FROM_PARENT);
|
|
247
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
248
|
+
await screen.findByText("Alice");
|
|
249
|
+
|
|
250
|
+
const menu = await openRowMenu(user, /^can read$/i);
|
|
251
|
+
await user.click(setItem(menu, /^can edit$/i));
|
|
252
|
+
|
|
253
|
+
// A plain verb-scoped revoke — which strips the `deny write` line, denials
|
|
254
|
+
// and grants being removed by the same splice.
|
|
255
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
256
|
+
expect(api.revokeAccess).toHaveBeenCalledWith('ws-1', {
|
|
257
|
+
path: FOLDER.relativePath,
|
|
258
|
+
kind: 'folder',
|
|
259
|
+
principal: { kind: 'user', email: 'alice@x.com', displayName: 'Alice' },
|
|
260
|
+
verb: 'write',
|
|
261
|
+
});
|
|
262
|
+
// Nothing granted: the parent's grant is back the moment the denial is gone.
|
|
263
|
+
expect(api.grantAccess).not.toHaveBeenCalled();
|
|
264
|
+
});
|
|
265
|
+
|
|
266
|
+
it('picking a set ABOVE the parent lifts the denial AND grants the part the parent does not give', async () => {
|
|
267
|
+
const user = userEvent.setup();
|
|
268
|
+
api.fetchFileAccess.mockResolvedValue(WRITE_RESTRICTED_HERE);
|
|
269
|
+
// Lifting `deny owner` (there is none) is skipped; lifting `deny write`
|
|
270
|
+
// restores edit from the parent, but owner is nobody's grant — so it is
|
|
271
|
+
// written here.
|
|
272
|
+
api.revokeAccess.mockResolvedValue(EDIT_FROM_PARENT);
|
|
273
|
+
api.grantAccess.mockResolvedValue(EDIT_FROM_PARENT);
|
|
274
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
275
|
+
await screen.findByText("Alice");
|
|
276
|
+
|
|
277
|
+
const menu = await openRowMenu(user, /^can read$/i);
|
|
278
|
+
await user.click(setItem(menu, /^owner$/i));
|
|
279
|
+
|
|
280
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
|
|
281
|
+
// Exactly one grant line, the highest tier: owner carries write, download
|
|
282
|
+
// and read, so no redundant second grant is written under it.
|
|
283
|
+
expect(api.grantAccess).toHaveBeenCalledWith(
|
|
284
|
+
'ws-1',
|
|
285
|
+
expect.objectContaining({ verb: 'owner' }),
|
|
286
|
+
);
|
|
287
|
+
// And the denial the new set no longer needs was lifted first.
|
|
288
|
+
expect(api.revokeAccess).toHaveBeenCalledWith(
|
|
289
|
+
'ws-1',
|
|
290
|
+
expect.objectContaining({ verb: 'write' }),
|
|
291
|
+
);
|
|
292
|
+
expect(api.revokeAccess).not.toHaveBeenCalledWith(
|
|
293
|
+
'ws-1',
|
|
294
|
+
expect.objectContaining({ mode: 'deny-here' }),
|
|
295
|
+
);
|
|
296
|
+
});
|
|
297
|
+
});
|
|
298
|
+
|
|
299
|
+
describe('ManageAccessDialog: Deny, and re-granting after it', () => {
|
|
300
|
+
it('Deny denies every verb here in one write, and the row stays, marked Denied here', async () => {
|
|
301
|
+
const user = userEvent.setup();
|
|
302
|
+
api.fetchFileAccess.mockResolvedValue(EDIT_FROM_PARENT);
|
|
303
|
+
api.revokeAccess.mockResolvedValue(DENIED_HERE);
|
|
304
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
305
|
+
await expandParentSection(user);
|
|
306
|
+
await screen.findByText("Alice");
|
|
307
|
+
|
|
308
|
+
const menu = await openRowMenu(user, /^can edit$/i);
|
|
309
|
+
await user.click(setItem(menu, /^deny$/i));
|
|
310
|
+
|
|
311
|
+
// One verb-less deny-here: the server strips every local grant and denies
|
|
312
|
+
// all four verbs, READ INCLUDED — which is what makes Deny different from
|
|
313
|
+
// picking the lowest set.
|
|
314
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
315
|
+
expect(api.revokeAccess).toHaveBeenCalledWith('ws-1', {
|
|
316
|
+
path: FOLDER.relativePath,
|
|
317
|
+
kind: 'folder',
|
|
318
|
+
principal: { kind: 'user', email: 'alice@x.com', displayName: 'Alice' },
|
|
319
|
+
mode: 'deny-here',
|
|
320
|
+
});
|
|
321
|
+
// She holds nothing, so no eligible list carries her — and yet the row is
|
|
322
|
+
// still here, saying what was decided rather than silently disappearing.
|
|
323
|
+
expect(screen.getByText('Alice')).toBeInTheDocument();
|
|
324
|
+
expect(await screen.findByRole('button', { name: /^denied here$/i })).toBeInTheDocument();
|
|
325
|
+
expect(screen.queryByRole('button', { name: /^no access$/i })).toBeNull();
|
|
326
|
+
});
|
|
327
|
+
|
|
328
|
+
it('a denied row keeps its menu, and picking a set from it lifts the denial and applies the set', async () => {
|
|
329
|
+
const user = userEvent.setup();
|
|
330
|
+
api.fetchFileAccess.mockResolvedValue(DENIED_HERE);
|
|
331
|
+
api.revokeAccess.mockResolvedValue(BLANK);
|
|
332
|
+
api.grantAccess.mockResolvedValue(BLANK);
|
|
333
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
334
|
+
await screen.findByText("Alice");
|
|
335
|
+
|
|
336
|
+
const menu = await openRowMenu(user, /^denied here$/i);
|
|
337
|
+
await user.click(setItem(menu, /^can read$/i));
|
|
338
|
+
|
|
339
|
+
// The read denial is lifted, then read is granted here: with every verb
|
|
340
|
+
// denied there was no parent grant left to fall back on.
|
|
341
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
|
|
342
|
+
expect(api.revokeAccess).toHaveBeenCalledWith(
|
|
343
|
+
'ws-1',
|
|
344
|
+
expect.objectContaining({ verb: 'read' }),
|
|
345
|
+
);
|
|
346
|
+
expect(api.grantAccess).toHaveBeenCalledWith(
|
|
347
|
+
'ws-1',
|
|
348
|
+
expect.objectContaining({ verb: 'read' }),
|
|
349
|
+
);
|
|
350
|
+
// Only the denials the new set needs gone are lifted — edit, download and
|
|
351
|
+
// owner stay denied, because "Can read" is what was asked for.
|
|
352
|
+
for (const verb of ['write', 'download', 'owner']) {
|
|
353
|
+
expect(api.revokeAccess).not.toHaveBeenCalledWith(
|
|
354
|
+
'ws-1',
|
|
355
|
+
expect.objectContaining({ verb }),
|
|
356
|
+
);
|
|
357
|
+
}
|
|
358
|
+
});
|
|
359
|
+
});
|
|
360
|
+
|
|
361
|
+
describe('ManageAccessDialog: every row has the same controls', () => {
|
|
362
|
+
it('an inherited row carries the verb menu and Deny, not read-only text', async () => {
|
|
363
|
+
const user = userEvent.setup();
|
|
364
|
+
api.fetchFileAccess.mockResolvedValue(EDIT_FROM_PARENT);
|
|
365
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
366
|
+
await expandParentSection(user);
|
|
367
|
+
await screen.findByText("Alice");
|
|
368
|
+
|
|
369
|
+
const menu = await openRowMenu(user, /^can edit$/i);
|
|
370
|
+
// The four sets, then Deny. Matched by ACCESSIBLE NAME and compared as
|
|
371
|
+
// elements, so the assertion is about the items and their order — not about
|
|
372
|
+
// how the trailing note happens to be glued onto `textContent` (it is
|
|
373
|
+
// aria-hidden there, and reaches assistive tech as `aria-description`).
|
|
374
|
+
expect(within(menu).getAllByRole('button')).toEqual([
|
|
375
|
+
setItem(menu, /^owner$/i),
|
|
376
|
+
setItem(menu, /^can edit$/i),
|
|
377
|
+
setItem(menu, /^can read$/i),
|
|
378
|
+
setItem(menu, /^can download$/i),
|
|
379
|
+
setItem(menu, /^deny$/i),
|
|
380
|
+
]);
|
|
381
|
+
// And the provenance rides along as a description, on exactly the verbs she
|
|
382
|
+
// holds: edit from the parent, and the read it implies.
|
|
383
|
+
expect(setItem(menu, /^can edit$/i)).toHaveAttribute('aria-description', 'from Sales');
|
|
384
|
+
expect(setItem(menu, /^can read$/i)).toHaveAttribute('aria-description', 'from Sales');
|
|
385
|
+
expect(setItem(menu, /^owner$/i)).not.toHaveAttribute('aria-description');
|
|
386
|
+
expect(setItem(menu, /^can download$/i)).not.toHaveAttribute('aria-description');
|
|
387
|
+
// Nothing is disabled: picking a set BELOW what is held is the point.
|
|
388
|
+
for (const item of within(menu).getAllByRole('button')) expect(item).not.toBeDisabled();
|
|
389
|
+
});
|
|
390
|
+
|
|
391
|
+
it('a row restricted here is not "No access" — it names the decision', async () => {
|
|
392
|
+
api.fetchFileAccess.mockResolvedValue(DENIED_HERE);
|
|
393
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
394
|
+
expect(await screen.findByRole('button', { name: /^denied here$/i })).toBeInTheDocument();
|
|
395
|
+
});
|
|
396
|
+
|
|
397
|
+
it('the x on an INHERITED row still offers remove-at-parent or restrict-here', async () => {
|
|
398
|
+
const user = userEvent.setup();
|
|
399
|
+
api.fetchFileAccess.mockResolvedValue(EDIT_FROM_PARENT);
|
|
400
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
401
|
+
await expandParentSection(user);
|
|
402
|
+
await screen.findByText("Alice");
|
|
403
|
+
|
|
404
|
+
await user.click(screen.getByRole('button', { name: 'Remove' }));
|
|
405
|
+
|
|
406
|
+
// Unchanged by this ticket: the whole-row removal is still a choice between
|
|
407
|
+
// two different acts, and it still asks which.
|
|
408
|
+
expect(
|
|
409
|
+
await screen.findByRole('heading', { name: /remove from parent folder\?/i }),
|
|
410
|
+
).toBeInTheDocument();
|
|
411
|
+
expect(api.revokeAccess).not.toHaveBeenCalled();
|
|
412
|
+
});
|
|
413
|
+
|
|
414
|
+
it('the x on a DIRECT row revokes here, with no question asked', async () => {
|
|
415
|
+
const user = userEvent.setup();
|
|
416
|
+
api.fetchFileAccess.mockResolvedValue({
|
|
417
|
+
...BLANK,
|
|
418
|
+
eligible: { principals: [], roles: [], users: [ALICE] },
|
|
419
|
+
readers: { restricted: true, principals: [], roles: [], users: [ALICE] },
|
|
420
|
+
sources: { 'u:alice@x.com': { read: [{ kind: 'direct' }], write: [{ kind: 'direct' }] } },
|
|
421
|
+
} as unknown as AccessResponse);
|
|
422
|
+
api.revokeAccess.mockResolvedValue(BLANK);
|
|
423
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
424
|
+
await screen.findByText("Alice");
|
|
425
|
+
|
|
426
|
+
await user.click(screen.getByRole('button', { name: 'Remove access' }));
|
|
427
|
+
|
|
428
|
+
await waitFor(() => expect(api.revokeAccess).toHaveBeenCalledTimes(1));
|
|
429
|
+
expect(api.revokeAccess).toHaveBeenCalledWith(
|
|
430
|
+
'ws-1',
|
|
431
|
+
expect.objectContaining({
|
|
432
|
+
principal: { kind: 'user', email: 'alice@x.com', displayName: 'Alice' },
|
|
433
|
+
}),
|
|
434
|
+
);
|
|
435
|
+
expect(screen.queryByRole('heading', { name: /remove from parent/i })).toBeNull();
|
|
436
|
+
});
|
|
437
|
+
|
|
438
|
+
it('the x on a row a PARENT restricts offers restrict-here, never "remove from" that parent', async () => {
|
|
439
|
+
const user = userEvent.setup();
|
|
440
|
+
// Alice reads through a role (no grant entry of her own anywhere), and the
|
|
441
|
+
// parent folder denies her edit. Her only ancestor ENTRY is that denial.
|
|
442
|
+
api.fetchFileAccess.mockResolvedValue({
|
|
443
|
+
...BLANK,
|
|
444
|
+
eligible: { principals: [], roles: [], users: [ALICE] },
|
|
445
|
+
readers: { restricted: true, principals: [], roles: [], users: [ALICE] },
|
|
446
|
+
sources: {},
|
|
447
|
+
denials: { 'u:alice@x.com': { write: [{ kind: 'ancestor', path: PARENT }] } },
|
|
448
|
+
} as unknown as AccessResponse);
|
|
449
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
450
|
+
// The denial still files her under the folder holding it — that is where
|
|
451
|
+
// the rule lives, and the row says so.
|
|
452
|
+
await expandParentSection(user);
|
|
453
|
+
await screen.findByText('Alice');
|
|
454
|
+
|
|
455
|
+
await user.click(screen.getByRole('button', { name: 'Remove' }));
|
|
456
|
+
|
|
457
|
+
// "Remove from Sales" would delete the parent's RESTRICTION — more access,
|
|
458
|
+
// from a click that asked for less. The only act offered is restricting here.
|
|
459
|
+
expect(await screen.findByRole('heading', { name: /restrict access here\?/i })).toBeInTheDocument();
|
|
460
|
+
expect(screen.queryByRole('button', { name: /^remove from /i })).toBeNull();
|
|
461
|
+
expect(screen.getByRole('button', { name: /restrict just this folder/i })).toBeInTheDocument();
|
|
462
|
+
expect(api.revokeAccess).not.toHaveBeenCalled();
|
|
463
|
+
});
|
|
464
|
+
});
|
|
465
|
+
|
|
466
|
+
describe('ManageAccessDialog: lowering a grant written here', () => {
|
|
467
|
+
it('a purely local grant is revoked, not denied — no dead deny line is left behind', async () => {
|
|
468
|
+
const user = userEvent.setup();
|
|
469
|
+
// Alice is an owner by a grant on this folder; nothing above names her.
|
|
470
|
+
api.fetchFileAccess.mockResolvedValue({
|
|
471
|
+
...BLANK,
|
|
472
|
+
owners: { principals: [], roles: [], users: [ALICE] },
|
|
473
|
+
eligible: { principals: [], roles: [], users: [ALICE] },
|
|
474
|
+
readers: { restricted: true, principals: [], roles: [], users: [ALICE] },
|
|
475
|
+
downloaders: { principals: [], roles: [], users: [ALICE] },
|
|
476
|
+
sources: {
|
|
477
|
+
'u:alice@x.com': {
|
|
478
|
+
owner: [{ kind: 'direct' }],
|
|
479
|
+
write: [{ kind: 'direct' }],
|
|
480
|
+
read: [{ kind: 'direct' }],
|
|
481
|
+
download: [{ kind: 'direct' }],
|
|
482
|
+
},
|
|
483
|
+
},
|
|
484
|
+
} as unknown as AccessResponse);
|
|
485
|
+
api.revokeAccess.mockResolvedValue(BLANK);
|
|
486
|
+
api.grantAccess.mockResolvedValue(BLANK);
|
|
487
|
+
render(<ManageAccessDialog entry={FOLDER} onClose={() => {}} />);
|
|
488
|
+
await screen.findByText("Alice");
|
|
489
|
+
|
|
490
|
+
const menu = await openRowMenu(user, /^owner, can download$/i);
|
|
491
|
+
await user.click(setItem(menu, /^can read$/i));
|
|
492
|
+
|
|
493
|
+
await waitFor(() => expect(api.grantAccess).toHaveBeenCalled());
|
|
494
|
+
// Owner comes off first — a grant folds downward inside one scope, so
|
|
495
|
+
// denying write under a live `owner:` here would be refused as ineffective.
|
|
496
|
+
const verbs = api.revokeAccess.mock.calls.map((c) => (c[1] as { verb?: string }).verb);
|
|
497
|
+
expect(verbs[0]).toBe('owner');
|
|
498
|
+
// Every removal is a plain revoke: the grants were all written here, so
|
|
499
|
+
// there is nothing above to shadow with a denial.
|
|
500
|
+
for (const call of api.revokeAccess.mock.calls) {
|
|
501
|
+
expect((call[1] as { mode?: string }).mode).toBeUndefined();
|
|
502
|
+
}
|
|
503
|
+
// Read was hers by a grant here that the owner revoke took with it, so it is
|
|
504
|
+
// written back.
|
|
505
|
+
expect(api.grantAccess).toHaveBeenCalledWith(
|
|
506
|
+
'ws-1',
|
|
507
|
+
expect.objectContaining({ verb: 'read' }),
|
|
508
|
+
);
|
|
509
|
+
});
|
|
510
|
+
});
|