@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -0,0 +1,141 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, within } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import type { FileTreeEntry } from '@bevel-software/platform-shared';
5
+ import type { AccessResponse } from '../api';
6
+
7
+ /**
8
+ * PICKING SEVERAL PRINCIPALS IN A ROW.
9
+ *
10
+ * Customer feedback on the Manage access add row: after picking a group from
11
+ * the list you had to click back into the field to type the next one, and a
12
+ * group you had already picked was offered again as you typed. Two small
13
+ * things, both in the way of the common case — sharing with a few groups at
14
+ * once — and both fixed here: a pick puts the caret back in the field, and the
15
+ * list offers only what is not already a chip.
16
+ */
17
+
18
+ const api = vi.hoisted(() => ({
19
+ fetchFileAccess: vi.fn(),
20
+ grantAccess: vi.fn(),
21
+ revokeAccess: vi.fn(),
22
+ suggestPrincipals: vi.fn(),
23
+ }));
24
+ vi.mock('../api', async (importOriginal) => {
25
+ const actual = await importOriginal<typeof import('../api')>();
26
+ return { ...actual, ...api };
27
+ });
28
+ vi.mock('../../workspace/state/workspace.context', () => ({
29
+ useWorkspace: () => ({ workspaceId: 'ws-1', kbDirName: 'knowledge-base' }),
30
+ }));
31
+ vi.mock('../../auth/state/auth.context', () => ({
32
+ useAuth: () => ({ user: { email: 'me@x.com', name: 'Me' } }),
33
+ }));
34
+
35
+ import { ManageAccessDialog } from '../components/ManageAccessDialog';
36
+
37
+ const ENTRY: FileTreeEntry = {
38
+ name: 'Deal.md',
39
+ relativePath: 'knowledge-base/Sales/Deal.md',
40
+ type: 'file',
41
+ } as unknown as FileTreeEntry;
42
+
43
+ const EMPTY = {
44
+ canRead: true,
45
+ canWrite: true,
46
+ canDownload: true,
47
+ canOwner: true,
48
+ eligible: { roles: [], users: [] },
49
+ readers: { restricted: true, roles: [], users: [] },
50
+ owners: { roles: [], users: [] },
51
+ downloaders: { roles: [], users: [] },
52
+ sources: {},
53
+ } as unknown as AccessResponse;
54
+
55
+ const FIELD = 'Add people, groups, roles or plugins…';
56
+
57
+ /** The suggestion list (debounced, so awaited), located from an item that must be in it. */
58
+ async function listHolding(label: RegExp): Promise<HTMLElement> {
59
+ return (await screen.findByRole('button', { name: label })).parentElement as HTMLElement;
60
+ }
61
+
62
+ beforeEach(() => {
63
+ vi.clearAllMocks();
64
+ api.fetchFileAccess.mockResolvedValue(EMPTY);
65
+ api.grantAccess.mockResolvedValue(EMPTY);
66
+ // The server answers every query with BOTH teams: it does not know what
67
+ // the dialog already holds as a chip, and it must not need to.
68
+ api.suggestPrincipals.mockResolvedValue({
69
+ roles: [],
70
+ groups: ['GTM Team', 'Sales Team'],
71
+ people: [{ name: 'Ana', email: 'ana@x.io' }],
72
+ peopleWithheld: false,
73
+ });
74
+ });
75
+
76
+ describe('ManageAccessDialog add row: picking several in a row', () => {
77
+ it('a pick from the list puts the caret back in the field', async () => {
78
+ const user = userEvent.setup();
79
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
80
+ const field = await screen.findByPlaceholderText(FIELD);
81
+
82
+ await user.type(field, 'team');
83
+ await user.click(await screen.findByRole('button', { name: /GTM Team/ }));
84
+
85
+ // The chip is up, the query is cleared, and the NEXT name can be typed
86
+ // without clicking into the white space first.
87
+ expect(screen.getByRole('button', { name: 'Remove GTM Team' })).toBeInTheDocument();
88
+ expect(field).toHaveValue('');
89
+ expect(field).toHaveFocus();
90
+ });
91
+
92
+ it('a principal already picked is not offered again, whatever the server returns', async () => {
93
+ const user = userEvent.setup();
94
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
95
+ const field = await screen.findByPlaceholderText(FIELD);
96
+
97
+ await user.type(field, 'team');
98
+ await user.click(await screen.findByRole('button', { name: /GTM Team/ }));
99
+ await user.type(field, 'team');
100
+
101
+ const list = await listHolding(/Sales Team/);
102
+ expect(within(list).getByText('Sales Team')).toBeInTheDocument();
103
+ expect(within(list).getByText('Ana')).toBeInTheDocument();
104
+ expect(within(list).queryByText('GTM Team')).toBeNull();
105
+ });
106
+
107
+ it('removing the chip offers the principal again', async () => {
108
+ const user = userEvent.setup();
109
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
110
+ const field = await screen.findByPlaceholderText(FIELD);
111
+
112
+ await user.type(field, 'team');
113
+ await user.click(await screen.findByRole('button', { name: /GTM Team/ }));
114
+ await user.click(screen.getByRole('button', { name: 'Remove GTM Team' }));
115
+
116
+ await user.type(field, 'team');
117
+ const list = await listHolding(/Sales Team/);
118
+ expect(within(list).getByText('GTM Team')).toBeInTheDocument();
119
+ });
120
+
121
+ it('when everything the server offers is already picked, no list opens', async () => {
122
+ const user = userEvent.setup();
123
+ api.suggestPrincipals.mockResolvedValue({
124
+ roles: [],
125
+ groups: ['GTM Team'],
126
+ people: [],
127
+ peopleWithheld: false,
128
+ });
129
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
130
+ const field = await screen.findByPlaceholderText(FIELD);
131
+
132
+ await user.type(field, 'gtm');
133
+ await user.click(await screen.findByRole('button', { name: /GTM Team/ }));
134
+ await user.type(field, 'gtm');
135
+
136
+ // The only match is the chip already in the field; an empty list would
137
+ // be a box with nothing in it.
138
+ expect(screen.queryByRole('button', { name: /^GT GTM Team/ })).toBeNull();
139
+ expect(screen.getAllByRole('button', { name: /GTM Team/ })).toHaveLength(1); // the chip's Remove
140
+ });
141
+ });
@@ -0,0 +1,204 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import type { FileTreeEntry } from '@bevel-software/platform-shared';
5
+ import type { AccessResponse } from '../api';
6
+ import { declarationsOf } from './tailwindDeclarations';
7
+
8
+ // --- Mock the API module ----------------------------------------------------
9
+ const api = vi.hoisted(() => ({
10
+ fetchFileAccess: vi.fn(),
11
+ grantAccess: vi.fn(),
12
+ revokeAccess: vi.fn(),
13
+ suggestPrincipals: vi.fn(),
14
+ }));
15
+ vi.mock('../api', async (importOriginal) => {
16
+ const actual = await importOriginal<typeof import('../api')>();
17
+ return { ...actual, ...api };
18
+ });
19
+
20
+ // --- Mock the context hooks the dialog reads --------------------------------
21
+ vi.mock('../../workspace/state/workspace.context', () => ({
22
+ useWorkspace: () => ({ workspaceId: 'ws-1', kbDirName: 'knowledge-base' }),
23
+ }));
24
+ vi.mock('../../auth/state/auth.context', () => ({
25
+ useAuth: () => ({ user: { email: 'me@x.com', name: 'Me' } }),
26
+ }));
27
+
28
+ import { ManageAccessDialog } from '../components/ManageAccessDialog';
29
+
30
+ const KB = 'knowledge-base';
31
+ const ENTRY: FileTreeEntry = {
32
+ name: 'Deal.md',
33
+ relativePath: `${KB}/Sales/Deal.md`,
34
+ type: 'file',
35
+ } as unknown as FileTreeEntry;
36
+
37
+ /** Nothing granted yet — the sheet opens on an empty, manageable file. */
38
+ const VIEW = {
39
+ canRead: true,
40
+ canWrite: true,
41
+ canDownload: false,
42
+ canOwner: false,
43
+ eligible: { roles: [], users: [] },
44
+ readers: { restricted: true, roles: [], users: [] },
45
+ owners: { roles: [], users: [] },
46
+ downloaders: { roles: [], users: [] },
47
+ sources: {},
48
+ } as AccessResponse;
49
+
50
+ /** The address from the tester's report: one unbroken run, wider than the field. */
51
+ const LONG_EMAIL = 'agent-interaction-test-user@example.invalid';
52
+ /** A group name long enough to overflow, and with no space to wrap on either. */
53
+ const LONG_GROUP = 'KnowledgeBasePlatformReliabilityWorkingGroupEurope';
54
+
55
+ /**
56
+ * The chip is the element the remove button sits in — found from the button so
57
+ * the test never depends on where in the tree the field puts it.
58
+ */
59
+ function chipFor(label: string): HTMLElement {
60
+ const remove = screen.getByRole('button', { name: `Remove ${label}` });
61
+ const chip = remove.parentElement;
62
+ if (!chip) throw new Error(`chip for ${label} has no parent`);
63
+ return chip;
64
+ }
65
+
66
+ describe('ManageAccessDialog: a picked chip is bounded by the field it sits in', () => {
67
+ beforeEach(() => {
68
+ vi.clearAllMocks();
69
+ api.fetchFileAccess.mockResolvedValue(VIEW);
70
+ api.grantAccess.mockResolvedValue(VIEW);
71
+ });
72
+
73
+ /**
74
+ * happy-dom runs no layout engine, so a width read here would only ever be 0
75
+ * — pixels are the visual check's job. What is checkable without a renderer
76
+ * is the CSS the browser is handed, and that is what these assert: the
77
+ * declarations come from compiling the app's own `index.css` with the app's
78
+ * own Tailwind (see `declarationsOf`), so a purged or renamed utility, a
79
+ * Tailwind upgrade that changes the generated CSS, or a broken CSS build
80
+ * fails the test instead of leaving it green while the chip overflows again.
81
+ * Reading declarations rather than class names also means restyling the chip
82
+ * is free: any class that yields the same CSS keeps these passing.
83
+ */
84
+ async function pickAndAssertChip(label: string) {
85
+ const chip = chipFor(label);
86
+ // 1. The chip can never be wider than the field it is laid out in, and it
87
+ // is allowed to shrink below its own content.
88
+ const chipCss = await declarationsOf(chip);
89
+ expect(chipCss['max-width']).toBe('100%');
90
+ expect(chipCss['min-width']).toBe('0px');
91
+
92
+ // 2. The label is the part that truncates, and it carries the full name as
93
+ // its tooltip.
94
+ const labelEl = chip.querySelector('[title]');
95
+ expect(labelEl).not.toBeNull();
96
+ expect(labelEl).toHaveTextContent(label);
97
+ expect(labelEl).toHaveAttribute('title', label);
98
+ const labelCss = await declarationsOf(labelEl as Element);
99
+ expect(labelCss).toMatchObject({
100
+ overflow: 'hidden',
101
+ 'text-overflow': 'ellipsis',
102
+ 'white-space': 'nowrap',
103
+ 'min-width': '0px',
104
+ });
105
+
106
+ // 3. The remove button keeps its full size at the end of the chip, and its
107
+ // accessible name is the whole untruncated label.
108
+ const remove = screen.getByRole('button', { name: `Remove ${label}` });
109
+ expect((await declarationsOf(remove))['flex-shrink']).toBe('0');
110
+ // Last child: visibly at the end, after the label, in reading order too.
111
+ expect(chip.lastElementChild).toBe(remove);
112
+
113
+ // 4. The chip's bound is a percentage of the field (asserted above) and
114
+ // nothing inside it is pinned to a pixel width, so zooming to 200%
115
+ // scales the chip and the field together instead of bursting one out of
116
+ // the other.
117
+ expect(chip.getAttribute('style')).toBeNull();
118
+ expect(remove.getAttribute('style')).toBeNull();
119
+ for (const css of [chipCss, labelCss]) {
120
+ // Any px width pins a size zoom cannot scale. `min-width: 0px` is the one
121
+ // exception — it is the absence of a floor, not a size. `width: 0px` and
122
+ // `max-width: 0px` are real pins (they would collapse the chip), so they
123
+ // are not exempt.
124
+ const pinned = (['width', 'max-width', 'min-width'] as const)
125
+ .map((property) => [property, css[property]] as const)
126
+ .filter(
127
+ ([property, value]) =>
128
+ value !== undefined &&
129
+ value.endsWith('px') &&
130
+ !(property === 'min-width' && value === '0px'),
131
+ );
132
+ expect(pinned).toEqual([]);
133
+ }
134
+ }
135
+
136
+ it('a long email picked from the suggestions truncates in its chip, tooltip and remove intact', async () => {
137
+ const user = userEvent.setup();
138
+ api.suggestPrincipals.mockResolvedValue({
139
+ roles: [],
140
+ groups: [],
141
+ // No display name: the label the chip renders IS the long address.
142
+ people: [{ name: '', email: LONG_EMAIL }],
143
+ peopleWithheld: false,
144
+ });
145
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
146
+
147
+ await user.type(
148
+ await screen.findByPlaceholderText('Add people, groups, roles or plugins…'),
149
+ 'agent',
150
+ );
151
+ await user.click(await screen.findByRole('button', { name: new RegExp(LONG_EMAIL) }));
152
+
153
+ await pickAndAssertChip(LONG_EMAIL);
154
+ });
155
+
156
+ it('a long unbroken group name truncates the same way', async () => {
157
+ const user = userEvent.setup();
158
+ api.suggestPrincipals.mockResolvedValue({
159
+ roles: [],
160
+ groups: [LONG_GROUP],
161
+ people: [],
162
+ peopleWithheld: false,
163
+ });
164
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
165
+
166
+ await user.type(
167
+ await screen.findByPlaceholderText('Add people, groups, roles or plugins…'),
168
+ 'knowledge',
169
+ );
170
+ await user.click(await screen.findByRole('button', { name: new RegExp(LONG_GROUP) }));
171
+
172
+ await pickAndAssertChip(LONG_GROUP);
173
+ });
174
+
175
+ it('two long chips stay inside the one field, which wraps them rather than stretching', async () => {
176
+ const user = userEvent.setup();
177
+ api.suggestPrincipals.mockResolvedValue({
178
+ roles: [],
179
+ groups: [LONG_GROUP],
180
+ people: [{ name: '', email: LONG_EMAIL }],
181
+ peopleWithheld: false,
182
+ });
183
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
184
+
185
+ const input = await screen.findByPlaceholderText('Add people, groups, roles or plugins…');
186
+ await user.type(input, 'long');
187
+ await user.click(await screen.findByRole('button', { name: new RegExp(LONG_GROUP) }));
188
+ await user.type(input, 'long');
189
+ await user.click(await screen.findByRole('button', { name: new RegExp(LONG_EMAIL) }));
190
+
191
+ await pickAndAssertChip(LONG_GROUP);
192
+ await pickAndAssertChip(LONG_EMAIL);
193
+
194
+ // Both chips share one field box, and that box wraps: a second long chip
195
+ // goes onto a new line inside the border instead of widening it.
196
+ const field = chipFor(LONG_GROUP).parentElement as HTMLElement;
197
+ expect(chipFor(LONG_EMAIL).parentElement).toBe(field);
198
+ expect(await declarationsOf(field)).toMatchObject({
199
+ display: 'flex',
200
+ 'flex-wrap': 'wrap',
201
+ width: '100%',
202
+ });
203
+ });
204
+ });
@@ -0,0 +1,234 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, waitFor, within } from '@testing-library/react';
3
+ import userEvent from '@testing-library/user-event';
4
+ import type { FileTreeEntry } from '@bevel-software/platform-shared';
5
+ import type { AccessResponse } from '../api';
6
+
7
+ /**
8
+ * Download implies read, and the dialog says so.
9
+ *
10
+ * The resolver folds a `download:` grant into `read` server-side, so the two
11
+ * boxes can never disagree in the file — the dialog has to render Read as
12
+ * checked-and-implied under Download, the way it already does under Edit, and
13
+ * must not write a redundant second `read:` line for a grant that already
14
+ * carries one.
15
+ */
16
+
17
+ const api = vi.hoisted(() => ({
18
+ fetchFileAccess: vi.fn(),
19
+ grantAccess: vi.fn(),
20
+ revokeAccess: vi.fn(),
21
+ suggestPrincipals: vi.fn(),
22
+ }));
23
+ vi.mock('../api', async (importOriginal) => {
24
+ const actual = await importOriginal<typeof import('../api')>();
25
+ return { ...actual, ...api };
26
+ });
27
+ vi.mock('../../workspace/state/workspace.context', () => ({
28
+ useWorkspace: () => ({ workspaceId: 'ws-1', kbDirName: 'knowledge-base' }),
29
+ }));
30
+ vi.mock('../../auth/state/auth.context', () => ({
31
+ useAuth: () => ({ user: { email: 'me@x.com', name: 'Me' } }),
32
+ }));
33
+
34
+ import { ManageAccessDialog } from '../components/ManageAccessDialog';
35
+
36
+ const KB = 'knowledge-base';
37
+ const ENTRY: FileTreeEntry = {
38
+ name: 'Deal.md',
39
+ relativePath: `${KB}/Sales/Deal.md`,
40
+ type: 'file',
41
+ } as unknown as FileTreeEntry;
42
+ const A = { name: 'Alice', email: 'alice@x.com' };
43
+
44
+ const EMPTY: AccessResponse = {
45
+ canRead: true,
46
+ canWrite: true,
47
+ canDownload: true,
48
+ canOwner: true,
49
+ eligible: { roles: [], users: [] },
50
+ readers: { restricted: true, roles: [], users: [] },
51
+ owners: { roles: [], users: [] },
52
+ downloaders: { roles: [], users: [] },
53
+ sources: {},
54
+ } as unknown as AccessResponse;
55
+
56
+ /** The add-row verb menu, opened from its summary trigger. */
57
+ async function openNewGrantMenu(user: ReturnType<typeof userEvent.setup>): Promise<HTMLElement> {
58
+ const trigger = await screen.findByRole('button', { name: /^can edit$/i });
59
+ await user.click(trigger);
60
+ return screen.getByRole('button', { name: /^can download$/i }).parentElement as HTMLElement;
61
+ }
62
+
63
+ describe('ManageAccessDialog: Download carries Read', () => {
64
+ beforeEach(() => {
65
+ vi.clearAllMocks();
66
+ api.suggestPrincipals.mockResolvedValue({
67
+ roles: [],
68
+ groups: ['GTM Team'],
69
+ people: [],
70
+ peopleWithheld: false,
71
+ });
72
+ api.fetchFileAccess.mockResolvedValue(EMPTY);
73
+ api.grantAccess.mockResolvedValue(EMPTY);
74
+ });
75
+
76
+ it('on a NEW grant: ticking Can download checks Can read and greys it, and the summary says both', async () => {
77
+ const user = userEvent.setup();
78
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
79
+
80
+ const menu = await openNewGrantMenu(user);
81
+ // Start from nothing selected, so nothing but Download can be what checks
82
+ // Read: Edit (the default) off leaves Read selected in its own right, so
83
+ // Read is turned off too.
84
+ await user.click(within(menu).getByRole('button', { name: /^can edit$/i }));
85
+ await user.click(within(menu).getByRole('button', { name: /^can read$/i }));
86
+ expect(within(menu).getByRole('button', { name: /^can read$/i })).toHaveAttribute(
87
+ 'aria-pressed',
88
+ 'false',
89
+ );
90
+ await user.click(within(menu).getByRole('button', { name: /^can download$/i }));
91
+
92
+ const readItem = within(menu).getByRole('button', { name: /^can read$/i });
93
+ expect(readItem).toHaveAttribute('aria-pressed', 'true');
94
+ expect(readItem).toBeDisabled();
95
+
96
+ await user.keyboard('{Escape}');
97
+ expect(
98
+ await screen.findByRole('button', { name: /^can read, can download$/i }),
99
+ ).toBeInTheDocument();
100
+ });
101
+
102
+ it('on a NEW grant: unticking Can edit leaves Can read selected, and Share grants read', async () => {
103
+ const user = userEvent.setup();
104
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
105
+
106
+ const menu = await openNewGrantMenu(user);
107
+ // Read was checked only because Edit implied it; turning Edit off used to
108
+ // clear both and dim Share. Less than edit is read, not nothing.
109
+ await user.click(within(menu).getByRole('button', { name: /^can edit$/i }));
110
+ const readItem = within(menu).getByRole('button', { name: /^can read$/i });
111
+ expect(readItem).toHaveAttribute('aria-pressed', 'true');
112
+ expect(readItem).not.toBeDisabled();
113
+ expect(within(menu).getByRole('button', { name: /^can edit$/i })).toHaveAttribute(
114
+ 'aria-pressed',
115
+ 'false',
116
+ );
117
+ await user.keyboard('{Escape}');
118
+ expect(await screen.findByRole('button', { name: /^can read$/i })).toBeInTheDocument();
119
+
120
+ await user.type(
121
+ await screen.findByPlaceholderText('Add people, groups, roles or plugins…'),
122
+ 'gtm',
123
+ );
124
+ await user.click(await screen.findByRole('button', { name: /GTM Team/ }));
125
+ await user.click(screen.getByRole('button', { name: /^Share$/ }));
126
+
127
+ await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
128
+ expect(api.grantAccess).toHaveBeenCalledWith(
129
+ 'ws-1',
130
+ expect.objectContaining({ verb: 'read', principal: { kind: 'group', group: 'GTM Team' } }),
131
+ );
132
+ });
133
+
134
+ it('on a NEW grant: unticking Can download likewise keeps Can read', async () => {
135
+ const user = userEvent.setup();
136
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
137
+
138
+ const menu = await openNewGrantMenu(user);
139
+ await user.click(within(menu).getByRole('button', { name: /^can edit$/i }));
140
+ await user.click(within(menu).getByRole('button', { name: /^can read$/i }));
141
+ await user.click(within(menu).getByRole('button', { name: /^can download$/i }));
142
+ await user.click(within(menu).getByRole('button', { name: /^can download$/i }));
143
+ const readItem = within(menu).getByRole('button', { name: /^can read$/i });
144
+ expect(readItem).toHaveAttribute('aria-pressed', 'true');
145
+ expect(readItem).not.toBeDisabled();
146
+ });
147
+
148
+ it('grants Download alone — no redundant second read grant, since download carries it', async () => {
149
+ const user = userEvent.setup();
150
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
151
+
152
+ const menu = await openNewGrantMenu(user);
153
+ await user.click(within(menu).getByRole('button', { name: /^can edit$/i }));
154
+ await user.click(within(menu).getByRole('button', { name: /^can download$/i }));
155
+ await user.keyboard('{Escape}');
156
+
157
+ await user.type(
158
+ await screen.findByPlaceholderText('Add people, groups, roles or plugins…'),
159
+ 'gtm',
160
+ );
161
+ await user.click(await screen.findByRole('button', { name: /GTM Team/ }));
162
+ await user.click(screen.getByRole('button', { name: /^Share$/ }));
163
+
164
+ await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
165
+ expect(api.grantAccess).toHaveBeenCalledWith(
166
+ 'ws-1',
167
+ expect.objectContaining({ verb: 'download', principal: { kind: 'group', group: 'GTM Team' } }),
168
+ );
169
+ });
170
+
171
+ it('Everyone picked with Can download alone: one public read grant, no failure', async () => {
172
+ const user = userEvent.setup();
173
+ // `everyone` is public-read only (the backend refuses any other verb), so
174
+ // the dialog clamps it to read and says so plainly, up front, while the
175
+ // chip is up. Download-only used to be the one pick that clamped to
176
+ // NOTHING and failed after the fact; now that Download carries Read it
177
+ // clamps like every other pick.
178
+ api.suggestPrincipals.mockResolvedValue({
179
+ roles: ['everyone'],
180
+ groups: [],
181
+ people: [],
182
+ peopleWithheld: false,
183
+ });
184
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
185
+
186
+ const menu = await openNewGrantMenu(user);
187
+ await user.click(within(menu).getByRole('button', { name: /^can edit$/i }));
188
+ await user.click(within(menu).getByRole('button', { name: /^can download$/i }));
189
+ await user.keyboard('{Escape}');
190
+
191
+ await user.type(
192
+ await screen.findByPlaceholderText('Add people, groups, roles or plugins…'),
193
+ 'every',
194
+ );
195
+ await user.click(await screen.findByRole('button', { name: /everyone/i }));
196
+ await user.click(screen.getByRole('button', { name: /^Share$/ }));
197
+
198
+ await waitFor(() => expect(api.grantAccess).toHaveBeenCalledTimes(1));
199
+ expect(api.grantAccess).toHaveBeenCalledWith(
200
+ 'ws-1',
201
+ expect.objectContaining({ verb: 'read', principal: { kind: 'role', role: 'everyone' } }),
202
+ );
203
+ expect(screen.queryByRole('alert')).toBeNull();
204
+ });
205
+
206
+ it('on an EXISTING row whose only grant is download: Read reads as checked, and Download stays the live toggle', async () => {
207
+ const user = userEvent.setup();
208
+ // A server that has not folded yet (`readers` empty): the row must still
209
+ // show Read, because the grant the file holds confers it.
210
+ api.fetchFileAccess.mockResolvedValue({
211
+ ...EMPTY,
212
+ downloaders: { roles: [], users: [A] },
213
+ sources: { 'u:alice@x.com': { download: [{ kind: 'direct' }], read: [{ kind: 'direct' }] } },
214
+ } as unknown as AccessResponse);
215
+ render(<ManageAccessDialog entry={ENTRY} onClose={() => {}} />);
216
+ await screen.findByText('Alice');
217
+
218
+ const rowTrigger = await screen.findByRole('button', { name: /^can read, can download$/i });
219
+ await user.click(rowTrigger);
220
+ const menu = screen.getAllByRole('button', { name: /^can download$/i }).slice(-1)[0]
221
+ .parentElement as HTMLElement;
222
+ // The summary says both, and both items read as checked.
223
+ const readItem = within(menu).getByRole('button', { name: /^can read$/i });
224
+ const downloadItem = within(menu).getByRole('button', { name: /^can download$/i });
225
+ expect(readItem).toHaveClass('font-medium');
226
+ expect(downloadItem).toHaveClass('font-medium');
227
+ // Read is the tier this row sits at, and there is none below it: the item
228
+ // is checked and off (Remove and Deny are how read is taken away). The
229
+ // download grant is taken back on its OWN axis — the checked Download
230
+ // item, which stays live.
231
+ expect(readItem).toBeDisabled();
232
+ expect(downloadItem).not.toBeDisabled();
233
+ });
234
+ });