@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -0,0 +1,75 @@
1
+ /**
2
+ * The header band — ONE row height for the two headers that sit side by side.
3
+ *
4
+ * Under the toolbar the app shows two rows at once: the sidebar's header row
5
+ * on the left, and the page's title bar on the right. They are laid out by
6
+ * different files (`layout/components/SidebarFrame` and each surface's page
7
+ * header), and until this constant existed each of them arrived at its own
8
+ * height by accident — the frame's column padding plus whatever its header
9
+ * slot happened to be tall, against a page column's top padding plus an
10
+ * `<h1>`'s line box. The two answers were about 20px apart, and the seam
11
+ * between them is the first thing anyone sees below the toolbar.
12
+ *
13
+ * So the height is a TOKEN (`--spacing-header` in `./tokens.css`, which
14
+ * Tailwind compiles into `.h-header`) and this is the one class string that
15
+ * spends it. A header row wears `HEADER_BAND` and nothing else about its
16
+ * height; a page that writes its own `h-[…]`, `py-…` or `mt-…` to make a
17
+ * title bar "look right" has re-created the bug, which is why
18
+ * `__tests__/header-band.test.ts` checks that every page title bar comes
19
+ * through here.
20
+ *
21
+ * It lives in `shared/theme` rather than beside either header for the reason
22
+ * `./measure.ts` does: the band belongs to neither of the two files that
23
+ * render it, and a change to it has to move both or it is not a fix.
24
+ *
25
+ * `items-center` is what puts the two texts on one line. The band's contents
26
+ * differ in size — a 13px nav row on one side, a 26px title on the other —
27
+ * so centring them in an identical box is the only rule that survives either
28
+ * one changing. `flex-none` keeps the band its own height inside the
29
+ * sidebar's flex column, where a `flex-1` sibling would otherwise squeeze it.
30
+ */
31
+ export const HEADER_BAND = 'flex h-header flex-none items-center';
32
+
33
+ /**
34
+ * The air above the band, for every column that shows one.
35
+ *
36
+ * The band's TOP edge is the seam, not just its height, so a column that
37
+ * starts its band lower than its neighbour breaks the alignment however well
38
+ * the two heights agree. This was the actual bug: the Library's column opened
39
+ * on 34px of padding ("Skills opens on a heading and keeps the roomier
40
+ * default", `./measure.ts`) while Knowledge opened on 12px and the sidebar on
41
+ * 16px — three numbers, three files, one seam.
42
+ *
43
+ * 12px is Knowledge's, kept: the toolbar already separates the column from
44
+ * the window, so this only has to keep the band off the bar
45
+ * (`.wrap.kb`, proto:695-699). The prototype's 34px `.wrap` padding is no
46
+ * longer used by any column — under a toolbar the window edge it was written
47
+ * for does not exist.
48
+ */
49
+ export const HEADER_COLUMN_TOP = 'pt-3';
50
+
51
+ /**
52
+ * The wrapper for a quiet `size="sm"` Button that LEADS a band — the `‹ Back`
53
+ * link on the skill and tool pages.
54
+ *
55
+ * The negative margin is not a nudge. `Button`'s quiet `sm` size carries
56
+ * `px-2` (`QUIET_SIZE.sm` in `shared/components/Button.tsx`), so a button
57
+ * placed at the band's leading edge starts its TEXT 8px inside that edge,
58
+ * while every other page's title starts on it — and a back link that hangs
59
+ * 8px right of the heading below it is the same kind of not-quite-aligned
60
+ * this whole band exists to remove. `-ml-2` cancels exactly that padding, so
61
+ * the label's left edge is the column's left edge; the button's hover
62
+ * background still covers its own padding, which is what the padding is for.
63
+ *
64
+ * It is a constant, and it says the number it is cancelling, because the
65
+ * coupling runs the wrong way: this file cannot see `QUIET_SIZE`, so a change
66
+ * to that padding silently moves the link. One place to fix beats two, and a
67
+ * named constant is a thing a reader can grep for from `Button.tsx`.
68
+ */
69
+ export const HEADER_BAND_LEAD = '-ml-2 flex-none';
70
+
71
+ /** The sidebar's header row, for the layout test that measures the seam. */
72
+ export const SIDEBAR_HEADER_TESTID = 'sidebar-header-row';
73
+
74
+ /** A page's title bar — the band on the other side of the seam. */
75
+ export const PAGE_HEADER_TESTID = 'page-header-row';
@@ -17,10 +17,13 @@
17
17
  * rather than moving the column. That is deliberate: hiding the nav should buy
18
18
  * margin, not line length.
19
19
  *
20
- * TOP padding is deliberately NOT here. It is the one measure the two surfaces
21
- * do not share: Knowledge opens on a tab strip and starts high (12px), Skills
22
- * opens on a heading and keeps the roomier default (34px). See
23
- * `plans/05-knowledge-ui.md` §1. Set it at the call site.
20
+ * TOP padding is NOT here either, but it is no longer the measure the two
21
+ * surfaces disagree about. It used to be — Knowledge opened on a tab strip at
22
+ * 12px, Skills on a heading at 34px (`plans/05-knowledge-ui.md` §1) — and
23
+ * those 22px were the reported seam: the Library's title bar sat a fifth of an
24
+ * inch below the sidebar header row beside it. Both columns now open on
25
+ * `HEADER_COLUMN_TOP` from `./header.ts`, which is where the shared band's
26
+ * geometry lives. Take it from there rather than restating a number here.
24
27
  */
25
28
 
26
29
  /** The default column: an 880px measure, centred. */
@@ -70,10 +70,19 @@
70
70
  --color-ok: #337b58;
71
71
  --color-wait: #c79100;
72
72
  --color-wait-dot: #f2c100;
73
+ /* `urgent` sits between wait and danger: something that needs a person,
74
+ like wait, but is blocking OTHER people right now — a plugin's members
75
+ who cannot read a skill it ships — rather than only the reader's own
76
+ setup. Orange, so it ranks above amber at a glance without borrowing
77
+ red's "broken" claim. 5.1:1 on `urgent-soft`, 5.8:1 on white — it is
78
+ used as ink on both, unlike `wait`, which is too light for text on its
79
+ own soft ground. */
80
+ --color-urgent: #b8390a;
73
81
  --color-danger: #b3261e;
74
82
 
75
83
  --color-ok-soft: #ebf5ee;
76
84
  --color-wait-soft: #fef8dc;
85
+ --color-urgent-soft: #fdeee4;
77
86
  --color-danger-soft: #fdedeb;
78
87
 
79
88
  /* word-level diff marks inside a document */
@@ -84,6 +93,31 @@
84
93
  seven of these at three different alphas. */
85
94
  --color-scrim: rgba(55, 53, 47, 0.28);
86
95
 
96
+ /* ── layout ─────────────────────────────────────────────────────────
97
+ ONE header height, for the two rows that sit side by side under the
98
+ toolbar: the sidebar's header row and a page's title bar.
99
+
100
+ Before this token each side owned its own arithmetic — the sidebar
101
+ frame's column padding plus whatever its header slot happened to be
102
+ tall, against the page column's top padding plus an `<h1>`'s line box —
103
+ and the two answers were about 20px apart. The seam between them is the
104
+ first thing anyone sees below the toolbar, so "close enough, twice"
105
+ reads as a broken layout.
106
+
107
+ Tailwind compiles this into `.h-header { height: var(--spacing-header) }`,
108
+ which is the rule `shared/theme/header.ts` hands to both call sites. Do
109
+ NOT write a height on either header row directly: a second number is the
110
+ drift this token exists to prevent, and `__tests__/header-band.test.ts`
111
+ fails if one appears.
112
+
113
+ 48px is the smallest 4px step that holds BOTH sides at their present
114
+ size, which is why the fix moves the page title bar onto the sidebar's
115
+ line rather than either side onto a new one. The sidebar's pill is
116
+ 31.5px (`py-1.5` over `--text-ui` 13px at a 1.5 line height); a page's
117
+ `--text-display` heading is 29.9px (26px at 1.15). The band centres the
118
+ taller of the two with 9px of air above and below. */
119
+ --spacing-header: 48px;
120
+
87
121
  /* ── radii ────────────────────────────────────────────────────────────
88
122
  Six ROLES, collapsed from the prototype's 16 hand-tuned values:
89
123
  xs tags, inline code
@@ -1,363 +0,0 @@
1
- import { describe, it, expect, vi, beforeEach } from 'vitest';
2
- import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
- import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
4
- import type { LibraryData } from '../hooks/useLibraryData';
5
- import type { ToolSecrets } from '../../secrets-vault/services/tool-secrets.api';
6
- import type { PluginSummary } from '../services/plugins.api';
7
-
8
- /**
9
- * The all-plugins index: which section a plugin lands in, what each row says, and
10
- * where it goes. The locked section is the reason this page exists, so most of
11
- * what is asserted here is about plugins the caller cannot enter.
12
- */
13
-
14
- const dataMock = vi.hoisted(() => ({ useLibraryData: vi.fn() }));
15
- vi.mock('../hooks/useLibraryData', () => ({ useLibraryData: dataMock.useLibraryData }));
16
-
17
- const pluginsMock = vi.hoisted(() => ({ listPlugins: vi.fn(), listJoinRequests: vi.fn() }));
18
- vi.mock('../services/plugins.api', () => ({
19
- listPlugins: pluginsMock.listPlugins,
20
- // The page carries the managers' join-request banners now — it is where the
21
- // Library lands, so it is where an unanswered request is certain to be seen.
22
- listJoinRequests: pluginsMock.listJoinRequests,
23
- reconcileJoinRequest: vi.fn(),
24
- }));
25
-
26
- import { LibraryProvider } from '../state/library-data';
27
- import {
28
- WorkspaceContext,
29
- type WorkspaceContextValue,
30
- } from '../../workspace/state/workspace.context';
31
- import { AdminContext, type AdminContextValue } from '../../admin/state/admin.context';
32
- import { PluginsIndexPage } from '../components/PluginsIndexPage';
33
- import { withAuth, TEST_PERSONAL_GROUP } from './auth-harness';
34
-
35
- const tool = (over: Partial<ToolSecrets> = {}): ToolSecrets => ({
36
- slug: 'heyreach',
37
- name: 'heyreach',
38
- path: 'Plugins/GTM/heyreach.tool',
39
- type: 'inline',
40
- setup: null,
41
- canWrite: false,
42
- variables: [],
43
- ...over,
44
- });
45
-
46
- const CATALOG: LibraryData = {
47
- loading: false,
48
- error: null,
49
- skills: [
50
- { name: 'outreach', description: '', path: 'Plugins/GTM/outreach' },
51
- { name: 'scratch', description: '', path: 'Skills/scratch' },
52
- ],
53
- pendingSkills: [],
54
- tools: [
55
- tool(),
56
- // An ungrouped sign-in — `Tools/slack.tool` is two segments, so no plugin.
57
- tool({
58
- slug: 'slack',
59
- name: 'slack',
60
- path: 'Tools/slack.tool',
61
- variables: [
62
- {
63
- name: 'API_KEY',
64
- scope: 'user',
65
- label: null,
66
- key: 'slack_API_KEY',
67
- adminConfigured: false,
68
- userConfigured: false,
69
- },
70
- ],
71
- }),
72
- ],
73
- ownedSkills: new Set(['outreach']),
74
- allowedToolsBySkill: new Map(),
75
- crs: [],
76
- myCrNumbers: new Set<number>(),
77
- reload: vi.fn(),
78
- };
79
-
80
- const summary = (over: Partial<PluginSummary> = {}): PluginSummary => ({
81
- name: 'GTM',
82
- folders: ['Plugins/GTM'],
83
- canRead: true,
84
- canWrite: false,
85
- isOwner: false,
86
- skillCount: 4,
87
- toolCount: 2,
88
- owners: { roles: [], users: [{ name: 'Olga Ivanova', email: 'olga@bevel.software' }] },
89
- writers: { roles: ['Admin'], users: [] },
90
- readers: { restricted: true, roles: ['GTM Team'], users: [] },
91
- hasRequested: false,
92
- requestNumber: null,
93
- ...over,
94
- });
95
-
96
- function LocationProbe() {
97
- const location = useLocation();
98
- return <div aria-label="href">{location.pathname + location.search}</div>;
99
- }
100
-
101
- /** `kbDirName` is what the request banners' Manage-access affordance needs. */
102
- const WORKSPACE = {
103
- workspaceId: 'target-company-state',
104
- kbDirName: 'knowledge-base',
105
- } as unknown as WorkspaceContextValue;
106
-
107
- const nonAdmin: AdminContextValue = {
108
- isAdmin: false,
109
- unreadCount: 0,
110
- lastSeen: null,
111
- markSeen: vi.fn(),
112
- refresh: vi.fn(),
113
- rolesConfigCorrupted: false,
114
- rolesConfigErrors: [],
115
- runRolesRecovery: vi.fn(),
116
- };
117
-
118
- /** The same caller with the admin bit set — the empty index's CTA is theirs. */
119
- const asAdmin: AdminContextValue = { ...nonAdmin, isAdmin: true };
120
-
121
- function renderIndex(admin: AdminContextValue = nonAdmin) {
122
- return render(
123
- <MemoryRouter initialEntries={['/skills-and-tools']}>
124
- {withAuth(
125
- <AdminContext.Provider value={admin}>
126
- <WorkspaceContext.Provider value={WORKSPACE}>
127
- <LibraryProvider>
128
- <Routes>
129
- <Route path="/skills-and-tools" element={<PluginsIndexPage />} />
130
- <Route path="*" element={<div />} />
131
- </Routes>
132
- <LocationProbe />
133
- </LibraryProvider>
134
- </WorkspaceContext.Provider>
135
- </AdminContext.Provider>,
136
- )}
137
- </MemoryRouter>,
138
- );
139
- }
140
-
141
- const href = () => screen.getByLabelText('href').textContent;
142
- const row = (name: RegExp | string) => screen.getByRole('button', { name });
143
-
144
- describe('PluginsIndexPage', () => {
145
- beforeEach(() => {
146
- dataMock.useLibraryData.mockReturnValue(CATALOG);
147
- pluginsMock.listPlugins.mockResolvedValue([summary()]);
148
- pluginsMock.listJoinRequests.mockResolvedValue([]);
149
- });
150
-
151
- it('names itself and its two sections', async () => {
152
- renderIndex();
153
- expect(await screen.findByRole('heading', { name: 'All plugins', level: 1 })).toBeInTheDocument();
154
- expect(
155
- screen.getByText('A plugin carries skills and tools for the people in it.'),
156
- ).toBeInTheDocument();
157
- expect(screen.getByRole('heading', { name: 'Yours' })).toBeInTheDocument();
158
- expect(await screen.findByRole('heading', { name: "Your plugins" })).toBeInTheDocument();
159
- });
160
-
161
- it("offers the caller's own plugin under Yours, and opens it", async () => {
162
- renderIndex();
163
- expect(
164
- await screen.findByText('Your sign-ins and the skills no plugin carries'),
165
- ).toBeInTheDocument();
166
- // The lens is gone from this page — it lives in the sidebar.
167
- expect(screen.queryByText('The skills you answer for')).not.toBeInTheDocument();
168
- fireEvent.click(row(new RegExp(`^${TEST_PERSONAL_GROUP}`)));
169
- await waitFor(() => expect(href()).toBe('/skills-and-tools/yours'));
170
- });
171
-
172
- it("keeps the caller's own plugin listed even when nothing sits outside a plugin", async () => {
173
- dataMock.useLibraryData.mockReturnValue({
174
- ...CATALOG,
175
- skills: [{ name: 'outreach', description: '', path: 'Plugins/GTM/outreach' }],
176
- tools: [tool()],
177
- });
178
- renderIndex();
179
- await screen.findByRole('heading', { name: 'All plugins', level: 1 });
180
- expect(screen.getByRole('button', { name: new RegExp(`^${TEST_PERSONAL_GROUP}`) })).toBeInTheDocument();
181
- // And never the lens: "Owned by me" is a view across plugins, not a plugin.
182
- expect(screen.queryByRole('button', { name: /^Owned by me/ })).not.toBeInTheDocument();
183
- });
184
-
185
- it("puts a readable plugin under Your plugins, with its run-by line and totals", async () => {
186
- renderIndex();
187
- const gtm = await screen.findByRole('button', { name: /^GTM/ });
188
- expect(gtm).toHaveAccessibleName('GTM Run by Olga Ivanova 4 skills · 2 tools');
189
- fireEvent.click(gtm);
190
- await waitFor(() => expect(href()).toBe('/skills-and-tools/plugins/GTM'));
191
- });
192
-
193
- it('marks a plugin the caller can change with an Owner badge', async () => {
194
- pluginsMock.listPlugins.mockResolvedValue([summary({ canWrite: true })]);
195
- renderIndex();
196
- expect(await screen.findByRole('button', { name: /^GTM Owner/ })).toBeInTheDocument();
197
- });
198
-
199
- it('shows the amber count when a plugin has integrations to set up', async () => {
200
- pluginsMock.listPlugins.mockResolvedValue([
201
- summary({
202
- name: 'Yours',
203
- folders: ['Plugins/Yours'],
204
- }),
205
- summary(),
206
- ]);
207
- dataMock.useLibraryData.mockReturnValue({
208
- ...CATALOG,
209
- tools: [
210
- tool({
211
- variables: [
212
- {
213
- name: 'API_KEY',
214
- scope: 'user',
215
- label: null,
216
- key: 'heyreach_API_KEY',
217
- adminConfigured: false,
218
- userConfigured: false,
219
- },
220
- ],
221
- }),
222
- ],
223
- });
224
- renderIndex();
225
- expect(await screen.findByRole('button', { name: /^GTM .* 1$/ })).toBeInTheDocument();
226
- });
227
-
228
- it('lists a DISCOVERABLE locked plugin under Request access, Locked or Requested', async () => {
229
- pluginsMock.listPlugins.mockResolvedValue([
230
- summary(),
231
- summary({ name: 'Finance', folders: ['Plugins/Finance'], canRead: false, canWrite: false }),
232
- ]);
233
- renderIndex();
234
- expect(await screen.findByRole('heading', { name: 'Request access' })).toBeInTheDocument();
235
- expect(screen.getByRole('button', { name: /^Finance/ })).toBeInTheDocument();
236
- expect(screen.getByTitle('Locked')).toBeInTheDocument();
237
-
238
- // Once the caller's join request is open, the chip says THAT instead —
239
- // the one thing the row can tell you that you did not already know.
240
- pluginsMock.listPlugins.mockResolvedValue([
241
- summary({
242
- name: 'Finance',
243
- folders: ['Plugins/Finance'],
244
- canRead: false,
245
- canWrite: false,
246
- hasRequested: true,
247
- requestNumber: 9,
248
- }),
249
- ]);
250
- renderIndex();
251
- expect(await screen.findByTitle('Requested')).toBeInTheDocument();
252
- });
253
-
254
- it('never lists a plugin the endpoint omitted (fail-closed: absent = invisible)', async () => {
255
- // The backend only returns accessible plugins, and this page adds nothing
256
- // on top: a plugin the caller cannot access has no row, no name, no counts.
257
- pluginsMock.listPlugins.mockResolvedValue([summary()]);
258
- renderIndex();
259
- await screen.findByRole('button', { name: /^GTM/ });
260
- expect(screen.queryByRole('button', { name: /^Finance/ })).not.toBeInTheDocument();
261
- expect(screen.queryByRole('heading', { name: 'Request access' })).not.toBeInTheDocument();
262
- });
263
-
264
- it('lists a plugin an item grant reaches inside, even without a summary', async () => {
265
- dataMock.useLibraryData.mockReturnValue({
266
- ...CATALOG,
267
- skills: [{ name: 'budget', description: '', path: 'Plugins/Finance/budget' }],
268
- });
269
- renderIndex();
270
- expect(await screen.findByRole('button', { name: /^Finance/ })).toBeInTheDocument();
271
- });
272
-
273
- it('lists a catalog-derived plugin with counts alone when no summary vouches for it', async () => {
274
- pluginsMock.listPlugins.mockResolvedValue([]);
275
- renderIndex();
276
- // One skill and one tool in Plugins/GTM, and nothing claiming to know who
277
- // runs it — so the row states what it can count, not what it cannot.
278
- expect(await screen.findByRole('button', { name: 'GTM 1 skills · 1 tools' })).toBeInTheDocument();
279
- });
280
-
281
- /** An untouched workspace: no summaries, and only unfiled items. */
282
- function untouchedWorkspace() {
283
- pluginsMock.listPlugins.mockResolvedValue([]);
284
- dataMock.useLibraryData.mockReturnValue({
285
- ...CATALOG,
286
- skills: [{ name: 'scratch', description: '', path: 'Skills/scratch' }],
287
- tools: [
288
- tool({ slug: 'slack', name: 'slack', path: 'Tools/slack.tool' }),
289
- ],
290
- });
291
- }
292
-
293
- it('turns an untouched index into a create CTA for an admin, and the CTA into the dialog', async () => {
294
- untouchedWorkspace();
295
- renderIndex(asAdmin);
296
-
297
- fireEvent.click(await screen.findByRole('button', { name: 'Create the first plugin' }));
298
- expect(await screen.findByRole('textbox', { name: 'Plugin name' })).toBeInTheDocument();
299
- });
300
-
301
- it('never offers the first plugin to a non-admin — that call is not theirs to make', async () => {
302
- untouchedWorkspace();
303
- renderIndex();
304
- await screen.findByText('Your plugins');
305
- expect(
306
- screen.queryByRole('button', { name: 'Create the first plugin' }),
307
- ).not.toBeInTheDocument();
308
- });
309
-
310
- it('keeps the create CTA out of the way once the caller is in a plugin', async () => {
311
- renderIndex(asAdmin); // default fixture: member of GTM
312
- await screen.findByRole('button', { name: /^GTM/ });
313
- expect(
314
- screen.queryByRole('button', { name: 'Create the first plugin' }),
315
- ).not.toBeInTheDocument();
316
- });
317
-
318
- it('stands the CTA down when plugins exist that the admin is simply not in', async () => {
319
- // Locked entries are plugins too: "the first plugin" would be a lie here,
320
- // even though `Your plugins` is empty.
321
- pluginsMock.listPlugins.mockResolvedValue([
322
- summary({ name: 'Finance', folders: ['Plugins/Finance'], canRead: false, canWrite: false }),
323
- ]);
324
- dataMock.useLibraryData.mockReturnValue({ ...CATALOG, skills: [], tools: [] });
325
- renderIndex(asAdmin);
326
- await screen.findByRole('button', { name: /^Finance/ });
327
- expect(
328
- screen.queryByRole('button', { name: 'Create the first plugin' }),
329
- ).not.toBeInTheDocument();
330
- });
331
-
332
- it('does not promise the first plugin while the catalog is still loading', async () => {
333
- // The initial empty `items` is an unanswered question, not an untouched
334
- // workspace: a catalog-derived plugin may still be on its way in.
335
- pluginsMock.listPlugins.mockResolvedValue([]);
336
- dataMock.useLibraryData.mockReturnValue({ ...CATALOG, loading: true, skills: [], tools: [] });
337
- renderIndex(asAdmin);
338
- await screen.findByText('Your plugins');
339
- expect(
340
- screen.queryByRole('button', { name: 'Create the first plugin' }),
341
- ).not.toBeInTheDocument();
342
- });
343
-
344
- it('offers a retry when the plugins endpoint fails, and keeps Yours', async () => {
345
- pluginsMock.listPlugins.mockRejectedValue(new Error("Couldn't load plugins."));
346
- renderIndex();
347
- const banner = await screen.findByRole('alert');
348
- expect(banner).toHaveTextContent("Couldn't load plugins.");
349
- expect(screen.getByRole('button', { name: new RegExp(`^${TEST_PERSONAL_GROUP}`) })).toBeInTheDocument();
350
- expect(screen.queryByRole('heading', { name: "Your plugins" })).not.toBeInTheDocument();
351
-
352
- pluginsMock.listPlugins.mockResolvedValue([summary()]);
353
- fireEvent.click(screen.getByRole('button', { name: 'Try again' }));
354
- expect(await screen.findByRole('button', { name: /^GTM/ })).toBeInTheDocument();
355
- });
356
-
357
- it('says it is loading before the first plugin index arrives', () => {
358
- pluginsMock.listPlugins.mockReturnValue(new Promise(() => {}));
359
- renderIndex();
360
- expect(screen.getByText('Loading plugins…')).toBeInTheDocument();
361
- expect(screen.getByRole('button', { name: new RegExp(`^${TEST_PERSONAL_GROUP}`) })).toBeInTheDocument();
362
- });
363
- });
@@ -1,97 +0,0 @@
1
- import { describe, it, expect, vi } from 'vitest';
2
- import { render, screen, fireEvent, within } from '@testing-library/react';
3
- import { PluginsSidebar, type PluginsSidebarProps } from '../components/PluginsSidebar';
4
-
5
- /**
6
- * The locked half of the nav: plugins the caller cannot read still appear, below
7
- * a break, with a lock where a count would be.
8
- *
9
- * Locked selection is a URL like any other — a locked row emits the SAME
10
- * `{ kind: 'group' }` intent as a readable one, and the plugin page decides which
11
- * view the caller gets. That is deliberate: one route per plugin means a locked
12
- * plugin can be linked to and bookmarked, and unlocking one changes nothing about
13
- * where it lives.
14
- */
15
-
16
- function renderSidebar(over: Partial<PluginsSidebarProps> = {}) {
17
- const onSelect = vi.fn();
18
- const props: PluginsSidebarProps = {
19
- filter: { kind: 'all' },
20
- onSelect,
21
- plugins: [
22
- { plugin: 'Engineering', count: 4, attention: 0 },
23
- { plugin: 'GTM', count: 3, attention: 2 },
24
- ],
25
- lockedPlugins: ['Finance', 'Legal'],
26
- ownedCount: 2,
27
- ownedAttention: 0,
28
- personalPluginLabel: "Juan's Plugin",
29
- ungroupedCount: 1,
30
- attentionCount: 2,
31
- onFinishSetup: vi.fn(),
32
- onCreatePlugin: vi.fn(),
33
- canCreatePlugin: true,
34
- pluginsIndexActive: false,
35
- onOpenPluginsIndex: vi.fn(),
36
-
37
- ...over,
38
- };
39
- render(<PluginsSidebar {...props} />);
40
- return { onSelect };
41
- }
42
-
43
- const nav = () => screen.getByRole('navigation', { name: 'Library plugins' });
44
-
45
- describe('PluginsSidebar: locked plugins', () => {
46
- it('names a locked row by its state, with no count in it', () => {
47
- renderSidebar();
48
- const finance = screen.getByRole('button', { name: 'Finance (locked)' });
49
- expect(finance).toBeInTheDocument();
50
- // A non-member cannot see inside to count anything, and never gets the
51
- // amber attention badge — there is nothing they could fix.
52
- expect(finance.textContent).toBe('Finance');
53
- });
54
-
55
- it('puts the locked rows last, after every plugin the caller is in', () => {
56
- renderSidebar();
57
- const labels = within(nav())
58
- .getAllByRole('button')
59
- .map((b) => b.getAttribute('aria-label') ?? b.textContent);
60
- expect(labels).toEqual([
61
- 'All plugins',
62
- 'Everything',
63
- 'Owned by me2',
64
- 'New plugin',
65
- // Your own space leads the plugins; the ones you cannot enter trail them.
66
- "Juan's Plugin1",
67
- 'Engineering4',
68
- 'GTM2',
69
- 'Finance (locked)',
70
- 'Legal (locked)',
71
- ]);
72
- });
73
-
74
- it('navigates to the plugin route on click, exactly like a readable plugin', () => {
75
- const { onSelect } = renderSidebar();
76
- fireEvent.click(screen.getByRole('button', { name: 'Finance (locked)' }));
77
- expect(onSelect).toHaveBeenCalledWith({ kind: 'group', plugin: 'Finance' });
78
- });
79
-
80
- it('marks the locked row current when its plugin is the route', () => {
81
- renderSidebar({ filter: { kind: 'group', plugin: 'Finance' } });
82
- expect(screen.getByRole('button', { name: 'Finance (locked)' })).toHaveAttribute(
83
- 'aria-current',
84
- 'true',
85
- );
86
- expect(screen.getByRole('button', { name: 'Legal (locked)' })).toHaveAttribute(
87
- 'aria-current',
88
- 'false',
89
- );
90
- });
91
-
92
- it('renders no locked section at all when nothing is locked', () => {
93
- renderSidebar({ lockedPlugins: [] });
94
- expect(screen.queryByRole('button', { name: /\(locked\)$/ })).not.toBeInTheDocument();
95
- expect(screen.getByRole('button', { name: /^GTM/ })).toBeInTheDocument();
96
- });
97
- });