@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -0,0 +1,134 @@
1
+ import { attentionOf, type LibraryItem } from '../state/library-data';
2
+ import type { PluginSummary } from '../services/plugins.api';
3
+ import { pluginLabel } from './plugin-summary';
4
+ import { filterLibraryItems, isInPlugin, pluginsOfItem, type LibraryFilter, type TeamAccess } from './status';
5
+
6
+ /**
7
+ * One plugin row of a gallery page — the Library's plugin renderer takes
8
+ * these (see `PluginRows`). Built from BOTH witnesses, as the all-plugins
9
+ * index built its rows: the summaries (the server's list, with verdicts and
10
+ * counts) and the catalog (an item whose path or link names a plugin the
11
+ * summaries missed still proves the plugin is there).
12
+ */
13
+ export interface PluginEntry {
14
+ /** Identity — what the row navigates by. `null` for the caller's own space. */
15
+ name: string | null;
16
+ label: string;
17
+ summary: PluginSummary | null;
18
+ skillCount: number;
19
+ toolCount: number;
20
+ attention: number;
21
+ urgent: boolean;
22
+ /** The caller can READ it — the server says so, or an item of it is in their catalog. */
23
+ member: boolean;
24
+ }
25
+
26
+ /**
27
+ * The "Owned by me" nav row's numbers, from the two slices its page lists —
28
+ * the owned cards and the owned plugin rows — so the count is the pilled
29
+ * items and cannot drift into a different meaning of "owned". `attention` is
30
+ * the owned cards that need a person.
31
+ */
32
+ export function ownedLensOf(
33
+ items: readonly LibraryItem[],
34
+ summaries: readonly PluginSummary[],
35
+ teams: readonly TeamAccess[],
36
+ personalLabel: string,
37
+ ): { count: number; attention: number } {
38
+ const filter: LibraryFilter = { kind: 'owned' };
39
+ const cards = filterLibraryItems(items, filter, '', teams);
40
+ const plugins = pluginEntriesFor(items, summaries, filter, teams, '', personalLabel);
41
+ return {
42
+ count: cards.length + plugins.length,
43
+ attention: cards.filter((i) => i.status.state !== 'ok').length,
44
+ };
45
+ }
46
+
47
+ /**
48
+ * The plugin rows a gallery filter shows.
49
+ *
50
+ * - Everything: the caller's own space, then every plugin the index lists,
51
+ * members' and locked alike — locked ones are still places on the map.
52
+ * - Owned by me: the plugins the caller owns (`isOwner`), own space first.
53
+ * - A team: the plugins the team can read, as the server named them; the
54
+ * counts on those rows are the TEAM's — how many of the plugin's skills
55
+ * and tools are in the team's slice — so a row never claims more than
56
+ * the cards beneath it show.
57
+ * - A plugin's own page and the personal page list items, not plugins.
58
+ *
59
+ * `query` matches the label, so a search narrows plugins with the cards.
60
+ */
61
+ export function pluginEntriesFor(
62
+ items: readonly LibraryItem[],
63
+ summaries: readonly PluginSummary[],
64
+ filter: LibraryFilter,
65
+ teams: readonly TeamAccess[],
66
+ query: string,
67
+ personalLabel: string,
68
+ ): PluginEntry[] {
69
+ if (filter.kind === 'group' || filter.kind === 'ungrouped') return [];
70
+ const q = query.trim().toLowerCase();
71
+ const matches = (label: string) => !q || label.toLowerCase().includes(q);
72
+
73
+ // Both witnesses: the index, and every plugin an item belongs to — by
74
+ // folder or by link. A plugin the caller reaches only through a shared
75
+ // skill it links has no folder item to name it, and must still be a row.
76
+ const names = new Set<string>(summaries.map((g) => g.name));
77
+ for (const item of items) for (const name of pluginsOfItem(item)) names.add(name);
78
+ const team = filter.kind === 'team' ? teams.find((t) => t.name === filter.group) : undefined;
79
+ const teamItems = filter.kind === 'team' ? filterLibraryItems(items, filter, '', teams) : null;
80
+
81
+ const entries: PluginEntry[] = [];
82
+ if (filter.kind !== 'team') {
83
+ entries.push({
84
+ name: null,
85
+ label: personalLabel,
86
+ summary: null,
87
+ skillCount: countKind(items, null, 'skill'),
88
+ toolCount: countKind(items, null, 'integration'),
89
+ attention: 0,
90
+ urgent: false,
91
+ member: true,
92
+ });
93
+ }
94
+ for (const name of [...names].sort((a, b) => a.localeCompare(b))) {
95
+ const summary = summaries.find((g) => g.name === name) ?? null;
96
+ const derivedSkills = countKind(items, name, 'skill');
97
+ const derivedTools = countKind(items, name, 'integration');
98
+ const hasItems = derivedSkills + derivedTools > 0;
99
+ const attention = attentionOf(items, name, summaries);
100
+ // Membership is READ, never write: an admin rescued into a plugin's
101
+ // rules can manage a folder they cannot open, and that row is locked.
102
+ const member = summary ? summary.canRead || hasItems : hasItems;
103
+ // Ownership, not management: the same `isOwner` the row's Owner pill shows.
104
+ if (filter.kind === 'owned' && !summary?.isOwner) continue;
105
+ if (filter.kind === 'team' && !team?.plugins.includes(name)) continue;
106
+ entries.push({
107
+ name,
108
+ label: pluginLabel(name, summaries),
109
+ summary,
110
+ skillCount: teamItems ? countKind(teamItems, name, 'skill') : summary ? summary.skillCount : derivedSkills,
111
+ toolCount: teamItems ? countKind(teamItems, name, 'integration') : summary ? summary.toolCount : derivedTools,
112
+ attention: attention.total,
113
+ urgent: attention.brokenLinks > 0,
114
+ member,
115
+ });
116
+ }
117
+ return entries.filter((e) => matches(e.label));
118
+ }
119
+
120
+ /**
121
+ * How many of a plugin's items the catalog holds — by folder OR by link,
122
+ * the way the plugin page lists them. `null` is the caller's own space: in
123
+ * no plugin folder and not a shared skill — a shared skill is nobody's
124
+ * alone, however it is linked.
125
+ */
126
+ export function countKind(
127
+ items: readonly LibraryItem[],
128
+ plugin: string | null,
129
+ kind: LibraryItem['kind'],
130
+ ): number {
131
+ return items.filter(
132
+ (i) => i.kind === kind && (plugin === null ? i.plugin === null && !i.shared : isInPlugin(i, plugin)),
133
+ ).length;
134
+ }
@@ -1,5 +1,91 @@
1
+ import { isPersonalPluginFolder, pluginOfPath, skillUnderRoot } from '@bevel-software/platform-shared';
2
+ import type { PluginMembership } from '../services/library.api';
1
3
  import type { PluginPrincipals, PluginSummary } from '../services/plugins.api';
2
4
 
5
+ /**
6
+ * The plugin a repository path sits in, by IDENTITY: the summary whose
7
+ * folder holds the path (deepest wins, so a nested plugin beats the scope
8
+ * around it). Before the summaries have loaded — or for a path under a
9
+ * folder the catalog does not list — the folder name stands in, which is
10
+ * what every plugin was called before the manifest became the identity. A
11
+ * personal folder is a place, not a plugin: null.
12
+ */
13
+ export function pluginNameForPath(
14
+ repoPath: string,
15
+ summaries: readonly Pick<PluginSummary, 'name' | 'folders'>[],
16
+ ): string | null {
17
+ const folder = pluginOfPath(repoPath);
18
+ if (folder === null) return null;
19
+ // The catalog is the authority: whatever folder it lists as holding the
20
+ // path names the plugin. Only a path no listed folder holds falls back to
21
+ // the folder name — and a personal shelf, which the catalog never lists,
22
+ // to null.
23
+ const held = pluginHoldingPath(repoPath, summaries);
24
+ if (held) return held.name;
25
+ return isPersonalPluginFolder(folder) ? null : folder;
26
+ }
27
+
28
+ /**
29
+ * The listed plugin whose folder holds `repoPath` — the folder itself or
30
+ * anything beneath it, deepest first, so a nested plugin beats the scope
31
+ * around it. Whole segments only: a sibling folder sharing a prefix never
32
+ * claims the path. Null when no listed plugin holds it (a path outside
33
+ * every plugin, or inside one the catalog does not list for this caller).
34
+ * The one place the rule lives, for every surface that asks which plugin
35
+ * a path is in.
36
+ */
37
+ export function pluginHoldingPath<S extends Pick<PluginSummary, 'folders'>>(
38
+ repoPath: string,
39
+ summaries: readonly S[],
40
+ ): S | null {
41
+ let best: { plugin: S; depth: number } | null = null;
42
+ for (const plugin of summaries) {
43
+ for (const folder of plugin.folders) {
44
+ if (repoPath !== folder && !repoPath.startsWith(`${folder}/`)) continue;
45
+ if (!best || folder.length > best.depth) best = { plugin, depth: folder.length };
46
+ }
47
+ }
48
+ return best?.plugin ?? null;
49
+ }
50
+
51
+ /**
52
+ * Which plugins hold a TOOL, in the shape a skill's memberships arrive in.
53
+ *
54
+ * The server sends none: a `.tool` manual and an `mcp.json` server are not
55
+ * linked one by one the way a skill is, they are REACHED. So the membership
56
+ * is derived from the two facts the browser already holds — where the file
57
+ * is, and which roots each plugin's manifest points at:
58
+ *
59
+ * - INLINE in the plugin whose folder holds the file (deepest wins, as
60
+ * everywhere else a path is attributed to a plugin);
61
+ * - LINKED into every other plugin one of whose linked roots holds it — the
62
+ * tool sits beside the skills that root brought in, and arrives with them.
63
+ *
64
+ * `granted` is always true: the grant a link needs is an access rule on a
65
+ * SKILL's folder, and a tool has none to lose or repair.
66
+ */
67
+ export function pluginsHoldingTool(
68
+ repoPath: string,
69
+ summaries: readonly Pick<PluginSummary, 'name' | 'folders' | 'linkedRoots'>[],
70
+ ): PluginMembership[] {
71
+ const inline = pluginHoldingPath(repoPath, summaries);
72
+ const memberships: PluginMembership[] = [];
73
+ if (inline) memberships.push({ name: inline.name, linked: false, granted: true });
74
+ for (const summary of summaries) {
75
+ if (summary === inline) continue;
76
+ // `skillUnderRoot` is the one containment rule for a linked root, not a
77
+ // rule about skills — a tool under the root is under it the same way.
78
+ if (!(summary.linkedRoots ?? []).some((root) => skillUnderRoot(repoPath, root))) continue;
79
+ memberships.push({ name: summary.name, linked: true, granted: true });
80
+ }
81
+ return memberships;
82
+ }
83
+
84
+ /** What a plugin is called on screen — its display name, else its identity. */
85
+ export function pluginLabel(name: string, summaries: readonly Pick<PluginSummary, 'name' | 'displayName'>[]): string {
86
+ return summaries.find((s) => s.name === name)?.displayName || name;
87
+ }
88
+
3
89
  /**
4
90
  * How a plugin describes its membership in prose.
5
91
  *
@@ -47,6 +133,22 @@ export function ownersTextOf(summary: Pick<PluginSummary, 'owners' | 'writers'>)
47
133
  return 'the workspace admins';
48
134
  }
49
135
 
136
+ /**
137
+ * The people `ownersTextOf` names, as a list.
138
+ *
139
+ * Mirrors that helper's chain exactly — owners, else writers, else nobody — so
140
+ * the sentence and the count of subjects in it can never disagree. It is a
141
+ * separate function only because a "we asked them" toast needs the NAMES (to
142
+ * take first names) while the verb beside them needs the COUNT, and prose
143
+ * gives back neither. Shared by the locked plugin page and the index row's
144
+ * Subscribe, which say the same thing after the same call.
145
+ */
146
+ export function adminNamesOf(summary: Pick<PluginSummary, 'owners' | 'writers'>): string[] {
147
+ const owners = usersThenRoles(summary.owners);
148
+ if (owners.length > 0) return owners;
149
+ return usersThenRoles(summary.writers);
150
+ }
151
+
50
152
  /**
51
153
  * Who the plugin is shared with, or `null` when there is nothing honest to say
52
154
  * — either the reader list was withheld (the caller cannot read the plugin, and
@@ -1,4 +1,5 @@
1
- import { formatRelativeTime } from '../../../lib/utils';
1
+ import { skillUnderRoot } from '@bevel-software/platform-shared';
2
+ import { probeWords } from '../../secrets-vault/probe/probe-verdict';
2
3
  import type { ProbeVerdict, ToolSecrets, ToolVarStatus } from '../../secrets-vault/services/tool-secrets.api';
3
4
 
4
5
  /**
@@ -12,15 +13,20 @@ import type { ProbeVerdict, ToolSecrets, ToolVarStatus } from '../../secrets-vau
12
13
  */
13
14
 
14
15
  /**
15
- * Three states, and no fourth.
16
+ * Four states, and no fifth.
16
17
  *
17
18
  * There used to be an `off` — "not set up yet", drawn in grey. Grey reads as
18
19
  * *disabled*, or as *not your problem*: an unconfigured integration looked like
19
20
  * furniture next to the amber ones, when in fact it is the state that most
20
21
  * needs somebody. Anything that needs a person is amber; anything that was
21
22
  * working and stopped is red. Nothing that needs a person is grey.
23
+ *
24
+ * `urgent` sits between the two: it needs a person, like amber, but it is
25
+ * blocking OTHER people right now — a plugin's members locked out of a skill
26
+ * it ships — where amber blocks only the reader's own use. Orange, the same
27
+ * colour the sidebar count turns for it, so the card and the count agree.
22
28
  */
23
- export type GemState = 'ok' | 'warn' | 'err';
29
+ export type GemState = 'ok' | 'warn' | 'urgent' | 'err';
24
30
 
25
31
  export interface AttentionStatus {
26
32
  state: GemState;
@@ -37,14 +43,6 @@ export interface AttentionStatus {
37
43
  hint?: string;
38
44
  }
39
45
 
40
- /**
41
- * Stored, and PROVEN to work by a real call.
42
- *
43
- * Reachable ONLY from a passing probe verdict. Nothing derived from what is
44
- * merely stored may return this — that inference is the entire bug.
45
- */
46
- const OK: AttentionStatus = { state: 'ok', text: 'Connected' };
47
-
48
46
  /**
49
47
  * In place, and untested — all a STORED value can ever support.
50
48
  *
@@ -55,7 +53,7 @@ const SIGNED_IN: AttentionStatus = { state: 'ok', text: 'Signed in' };
55
53
  const KEY_SAVED: AttentionStatus = { state: 'ok', text: 'Key saved' };
56
54
 
57
55
  /** Severity order for aggregation: broken sign-in beats anything merely unset. */
58
- const RANK: Record<GemState, number> = { ok: 0, warn: 1, err: 2 };
56
+ const RANK: Record<GemState, number> = { ok: 0, warn: 1, urgent: 2, err: 3 };
59
57
 
60
58
  /**
61
59
  * What ONE variable is: in place, or `Needs <the thing>`.
@@ -94,10 +92,17 @@ function varStatus(v: ToolVarStatus, canWrite: boolean): AttentionStatus {
94
92
  * The word for a tool that is fully SET UP, decided by whether the credential
95
93
  * has actually been tested.
96
94
  *
97
- * Three outcomes, and the reason there are three: `Connected` is a claim we can
98
- * back — something called the provider and it answered. `Key saved` is the
99
- * narrower claim we can back when nothing tested it: a value is stored, and
100
- * that is genuinely all we know. `Not working` is the provider's own verdict.
95
+ * Four outcomes, and the reason there are four: `Connected` is a claim we can
96
+ * back — something called the provider and it answered. `Not working` is the
97
+ * provider's own verdict. `Unverified` is what a probe that reached no verdict
98
+ * leaves behind — most often a manual that defines no health check, so there
99
+ * is nothing to call. `Key saved` is the narrower claim for a tool NOTHING has
100
+ * probed at all: a value is stored, and that is genuinely all we know.
101
+ *
102
+ * The first three are `probeWords`, shared verbatim with the Connect page and
103
+ * the vault, which probe after their own saves now. The fourth is this
104
+ * module's alone, because it is the one a list of cards can reach — no verdict
105
+ * was ever asked for there.
101
106
  *
102
107
  * `Key saved` stays GREEN. It is a complete, true statement about a tool that
103
108
  * needs nothing from anybody, and painting it amber would put a permanent
@@ -109,18 +114,16 @@ function varStatus(v: ToolVarStatus, canWrite: boolean): AttentionStatus {
109
114
  * lie in a component whose entire job is to stop telling small lies.
110
115
  */
111
116
  function healthStatus(tool: ToolSecrets, verdict?: ProbeVerdict | null): AttentionStatus {
112
- if (verdict?.status === 'ok') {
113
- // The app's one relative-time formatter, not a local dialect of it. A
114
- // verdict with no usable timestamp still just happened — it cannot outlive
115
- // the component holding it — so "just now" is the honest fallback.
116
- return { ...OK, hint: `Checked ${formatRelativeTime(verdict.checkedAt) || 'just now'}.` };
117
- }
118
- if (verdict?.status === 'failed') {
119
- return {
120
- state: 'err',
121
- text: 'Not working',
122
- hint: verdict.detail ?? 'The provider rejected this credential.',
123
- };
117
+ // A verdict exists: the probe's own vocabulary wins outright, and it is the
118
+ // SAME vocabulary the Connect page and the vault render — `probeWords` is
119
+ // the single place those sentences are written, so one provider rejection
120
+ // cannot come out as two different complaints depending on where the key was
121
+ // typed. `Unverified` included: a manual with no health check has nothing to
122
+ // prove "Key saved" with either, and saying the narrower true thing is the
123
+ // rule this module is built on.
124
+ if (verdict) {
125
+ const { tone, text, hint } = probeWords(verdict);
126
+ return { state: tone, text, hint };
124
127
  }
125
128
  // The word has to match what the user actually did. A tool with no variables
126
129
  // asked nothing of them, so "Key saved" would name a key that does not exist;
@@ -132,7 +135,7 @@ function healthStatus(tool: ToolSecrets, verdict?: ProbeVerdict | null): Attenti
132
135
  return {
133
136
  state: 'ok',
134
137
  text,
135
- hint: verdict?.detail ?? "Not verified — this tool hasn't been tested yet.",
138
+ hint: "Not verified — this tool hasn't been tested yet.",
136
139
  };
137
140
  }
138
141
 
@@ -213,9 +216,35 @@ export type LibraryFilter =
213
216
  | { kind: 'all' }
214
217
  | { kind: 'owned' }
215
218
  | { kind: 'group'; plugin: string }
219
+ /**
220
+ * A team from the active group source: what being in it lets a person
221
+ * use. The slice is the server's (`TeamAccess`), not a property of the
222
+ * items — see `filterLibraryItems`'s `teams` argument.
223
+ */
224
+ | { kind: 'team'; group: string }
216
225
  /** Owned by someone, in no plugin — the prototype calls these "yours alone". */
217
226
  | { kind: 'ungrouped' };
218
227
 
228
+ /**
229
+ * What one team can use, by id — `GET /api/teams`, one entry per group.
230
+ * Ids only: the names are the catalog's, and the slice is applied to it.
231
+ * The server opens the list with `EVERYONE_TEAM` — not a group but the
232
+ * built-in org-wide principal: what a person in no group at all can use.
233
+ */
234
+ export interface TeamAccess {
235
+ name: string;
236
+ plugins: string[];
237
+ skills: string[];
238
+ tools: string[];
239
+ }
240
+
241
+ /**
242
+ * The org-wide entry's name, as the server spells it. No group can take
243
+ * it — `everyone` is a reserved name in the access rules — so a team of
244
+ * this name IS the organisation, and the page says so.
245
+ */
246
+ export const EVERYONE_TEAM = 'Everyone';
247
+
219
248
  /**
220
249
  * What an empty view says.
221
250
  *
@@ -231,25 +260,162 @@ export type LibraryFilter =
231
260
  export function emptyMessageFor(filter: LibraryFilter, query: string): string {
232
261
  if (query.trim()) return 'Nothing here matches yet.';
233
262
  if (filter.kind === 'owned') return "You're not responsible for changes in any skills yet.";
263
+ if (filter.kind === 'team' && filter.group === EVERYONE_TEAM) return 'Nothing is shared with everyone yet.';
264
+ if (filter.kind === 'team') return `${filter.group} can't use anything you can see yet.`;
234
265
  return 'Nothing here matches yet.';
235
266
  }
236
267
 
237
268
  export interface LibraryFilterable {
238
269
  kind: 'skill' | 'integration';
270
+ /**
271
+ * The catalog id a team slice names — a skill's name, a tool's slug. The
272
+ * team lens fails closed without it: an item that cannot be named cannot
273
+ * be in a team's slice.
274
+ */
275
+ id?: string;
239
276
  name: string;
240
277
  description: string;
278
+ /** Named in the item's `owner:` grant — "Owned by me" lists exactly these. */
241
279
  owned: boolean;
242
280
  /** Folder plugin from the item's KB path, or null when it sits in none. */
243
281
  plugin: string | null;
282
+ /**
283
+ * Lives under the shared `Skills/` root rather than in a plugin folder.
284
+ * Such an item has no folder plugin, but it is not "yours alone" either —
285
+ * it is owned by a scope and shared into plugins by link — so the
286
+ * ungrouped view leaves it out and only the catalog-wide view lists it.
287
+ */
288
+ shared?: boolean;
289
+ /**
290
+ * Every plugin the item belongs to, inline or by link. `plugin` above is the
291
+ * FOLDER plugin only (routing, "yours alone"); this is what the plugin
292
+ * page and the sidebar counts go by.
293
+ */
294
+ plugins?: { name: string }[];
295
+ }
296
+
297
+ /**
298
+ * "Yours alone": in no plugin folder, not a shared skill, and in no plugin
299
+ * by link either — a tool under a root a plugin links arrives on that
300
+ * plugin's page with the skills beside it, so it is not alone.
301
+ */
302
+ export function isUngrouped(item: Pick<LibraryFilterable, 'plugin' | 'shared' | 'plugins'>): boolean {
303
+ return item.plugin === null && !item.shared && !(item.plugins?.length ?? 0);
304
+ }
305
+
306
+ /** Whether an item belongs to `plugin` — by folder, or by a link from the plugin's manifest. */
307
+ export function isInPlugin(item: Pick<LibraryFilterable, 'plugin' | 'plugins'>, plugin: string): boolean {
308
+ return item.plugin === plugin || (item.plugins?.some((m) => m.name === plugin) ?? false);
309
+ }
310
+
311
+ /**
312
+ * The item as the plugin page should show it: a LINK whose grant is missing
313
+ * gets the note in the tools' grammar — "Needs setup", and "share with plugin
314
+ * members" for someone who can edit the skill's rules — because until the
315
+ * grant is back, the plugin's members cannot read it. In ORANGE (`urgent`),
316
+ * not amber: it locks other people out, and the sidebar count for the plugin
317
+ * is the same colour. Healthy links are untouched.
318
+ */
319
+ export function withLinkHealth<T extends LibraryFilterable & { status: AttentionStatus; canWrite?: boolean }>(
320
+ item: T,
321
+ plugin: string,
322
+ ): T {
323
+ const membership = (item.plugins as { name: string; linked?: boolean; granted?: boolean }[] | undefined)?.find(
324
+ (m) => m.name === plugin,
325
+ );
326
+ if (!membership?.linked || membership.granted !== false) return item;
327
+ // One amber note at a time, and the card's own comes first: a skill whose
328
+ // tools need setup, or one under review, already says what to do — the
329
+ // broken link is reported once that is settled, not in its place.
330
+ if (item.status.state !== 'ok') return item;
331
+ return {
332
+ ...item,
333
+ status: {
334
+ state: 'urgent',
335
+ text: item.canWrite ? 'Needs setup: share with plugin members' : 'Needs setup',
336
+ hint: `The skill's access rules no longer name ${plugin}'s members. Repair the link from the skill page.`,
337
+ },
338
+ };
339
+ }
340
+
341
+ /**
342
+ * Where an item that reaches `plugin` by LINK actually lives — the folder
343
+ * holding it, which is what the card's Linked pill names on hover.
344
+ *
345
+ * Null for an item the plugin's own folder holds, and for one that is not in
346
+ * the plugin at all: an inline card has nothing to disclose, and a page that
347
+ * pilled every card would be saying nothing with three more words.
348
+ *
349
+ * The answer is the MANIFEST'S ROOT, not the item's parent folder: the pill
350
+ * discloses the place somebody linked, and a manifest may name a whole shelf
351
+ * (`Skills/Testing`, which HOLDS the skill folder) or one skill folder
352
+ * outright (`Skills/Testing/test-shared-linking`, which IS it). Dropping the
353
+ * path's last segment gets the first case right and the second wrong — it
354
+ * would answer `Skills/Testing` for a skill whose shelf nobody linked. A tool
355
+ * is the same question asked of a file. Deepest root wins, as everywhere else
356
+ * a path is attributed to a place.
357
+ *
358
+ * No roots is the degraded read — the plugins endpoint failed, or its summary
359
+ * has not arrived — and the parent folder stands in, which is where the item
360
+ * lives in every case but the one above.
361
+ */
362
+ export function linkedHomeOf(
363
+ item: Pick<LibraryFilterable, 'plugins'> & { path: string },
364
+ plugin: string,
365
+ linkedRoots: readonly string[] = [],
366
+ ): string | null {
367
+ const membership = (item.plugins as { name: string; linked?: boolean }[] | undefined)?.find(
368
+ (m) => m.name === plugin,
369
+ );
370
+ if (!membership?.linked) return null;
371
+ // `skillUnderRoot` is the one containment rule for a linked root — a tool
372
+ // under the root is under it the same way a skill is.
373
+ let root: string | null = null;
374
+ for (const candidate of linkedRoots) {
375
+ if (!skillUnderRoot(item.path, candidate)) continue;
376
+ if (root === null || candidate.length > root.length) root = candidate;
377
+ }
378
+ if (root !== null) return root;
379
+ const cut = item.path.lastIndexOf('/');
380
+ // A path with no parent (nothing this catalog serves, but the slice would
381
+ // otherwise silently answer with the empty string) names itself.
382
+ return cut > 0 ? item.path.slice(0, cut) : item.path;
244
383
  }
245
384
 
246
- /** Sidebar selection narrows; the query matches name/description within it. */
385
+ /** The distinct plugin names an item belongs to. */
386
+ export function pluginsOfItem(item: Pick<LibraryFilterable, 'plugin' | 'plugins'>): string[] {
387
+ const names = new Set<string>();
388
+ if (item.plugin !== null) names.add(item.plugin);
389
+ for (const m of item.plugins ?? []) names.add(m.name);
390
+ return [...names];
391
+ }
392
+
393
+ /**
394
+ * Whether `item` is in `team`'s slice — by the id the server named. A skill
395
+ * is named among the team's skills, a tool among its tools; an item without
396
+ * an id, or a team the server did not list, is a no.
397
+ */
398
+ export function isInTeam(
399
+ item: Pick<LibraryFilterable, 'kind' | 'id'>,
400
+ team: Pick<TeamAccess, 'skills' | 'tools'> | undefined,
401
+ ): boolean {
402
+ if (!team || item.id === undefined) return false;
403
+ return (item.kind === 'skill' ? team.skills : team.tools).includes(item.id);
404
+ }
405
+
406
+ /**
407
+ * Sidebar selection narrows; the query matches name/description within it.
408
+ * `teams` is what the team lens slices by — the server's per-group access
409
+ * (`GET /api/teams`); without it the team lens is empty, never everything.
410
+ */
247
411
  export function filterLibraryItems<T extends LibraryFilterable>(
248
- items: T[],
412
+ items: readonly T[],
249
413
  filter: LibraryFilter,
250
414
  query: string,
415
+ teams: readonly TeamAccess[] = [],
251
416
  ): T[] {
252
417
  const q = query.trim().toLowerCase();
418
+ const team = filter.kind === 'team' ? teams.find((t) => t.name === filter.group) : undefined;
253
419
  return items.filter((item) => {
254
420
  if (q && !item.name.toLowerCase().includes(q) && !item.description.toLowerCase().includes(q)) {
255
421
  return false;
@@ -260,9 +426,11 @@ export function filterLibraryItems<T extends LibraryFilterable>(
260
426
  case 'owned':
261
427
  return item.owned;
262
428
  case 'group':
263
- return item.plugin === filter.plugin;
429
+ return isInPlugin(item, filter.plugin);
430
+ case 'team':
431
+ return isInTeam(item, team);
264
432
  case 'ungrouped':
265
- return item.plugin === null;
433
+ return isUngrouped(item);
266
434
  }
267
435
  });
268
436
  }
@@ -279,8 +447,9 @@ export function pluginCounts<T extends LibraryFilterable>(
279
447
  ): { plugin: string; count: number }[] {
280
448
  const counts = new Map<string, number>();
281
449
  for (const item of items) {
282
- if (item.plugin === null) continue;
283
- counts.set(item.plugin, (counts.get(item.plugin) ?? 0) + 1);
450
+ // A linked skill counts for every plugin that links it, like the plugin
451
+ // index's own totals.
452
+ for (const name of pluginsOfItem(item)) counts.set(name, (counts.get(name) ?? 0) + 1);
284
453
  }
285
454
  return [...counts.entries()]
286
455
  .map(([plugin, count]) => ({ plugin, count }))
@@ -35,8 +35,11 @@ function library(over: Partial<LibraryContextValue> = {}): LibraryContextValue {
35
35
  error: null,
36
36
  skills: [],
37
37
  pendingSkills: [],
38
+ pendingTools: [],
38
39
  tools: [],
39
40
  ownedSkills: new Set(),
41
+ writableSkills: new Set(),
42
+ ownedTools: new Set(),
40
43
  allowedToolsBySkill: new Map(),
41
44
  crs: [],
42
45
  myCrNumbers: new Set(),
@@ -45,6 +48,9 @@ function library(over: Partial<LibraryContextValue> = {}): LibraryContextValue {
45
48
  pluginSummaries: [],
46
49
  pluginsLoading: false,
47
50
  pluginsError: null,
51
+ teams: [],
52
+ teamsLoading: false,
53
+ teamsError: null,
48
54
  reloadPlugins: vi.fn(),
49
55
  ...over,
50
56
  };
@@ -136,7 +142,7 @@ beforeEach(() => {
136
142
  resetOnboardingForTests();
137
143
  setSidebarCollapsed(false, true);
138
144
  serviceMocks.createPlugin.mockReset();
139
- serviceMocks.createPlugin.mockResolvedValue({ folder: 'Design' });
145
+ serviceMocks.createPlugin.mockResolvedValue({ folder: 'Design', name: 'design' });
140
146
  serviceMocks.createEmptySkill.mockReset();
141
147
  serviceMocks.createEmptySkill.mockResolvedValue({
142
148
  repoRelativePath: 'Plugins/personal-u1/weekly-report/SKILL.md',
@@ -174,6 +180,7 @@ describe('creator welcome routing', () => {
174
180
  name: 'roadmap',
175
181
  description: 'Keeps the roadmap current.',
176
182
  owned: true,
183
+ canWrite: true,
177
184
  status: { state: 'ok', text: 'Ready' },
178
185
  plugin: null,
179
186
  path: 'Skills/roadmap',
@@ -244,13 +251,14 @@ describe('creator welcome actions', () => {
244
251
  await user.type(screen.getByRole('textbox', { name: 'Plugin name' }), 'Design');
245
252
  await user.click(screen.getByRole('button', { name: 'Create plugin' }));
246
253
 
247
- await waitFor(() => expect(serviceMocks.createPlugin).toHaveBeenCalledWith('Design'));
254
+ await waitFor(() => expect(serviceMocks.createPlugin).toHaveBeenCalledWith('Design', ''));
248
255
  // The navigation is the LAST link of the create chain (create -> refresh
249
256
  // indexes -> navigate), so it is the settled state to wait for; asserting
250
257
  // it immediately races the refresh microtasks and flakes under CI load.
251
258
  await waitFor(() =>
259
+ // The new plugin's page is addressed by its identity, not its folder.
252
260
  expect(screen.getByLabelText('pathname')).toHaveTextContent(
253
- '/skills-and-tools/plugins/Design',
261
+ '/skills-and-tools/plugins/design',
254
262
  ),
255
263
  );
256
264
  expect(data.reload).toHaveBeenCalledOnce();