@bevel-software/platform-core-frontend 0.14.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/THIRD-PARTY-NOTICES.md +2 -2
  2. package/package.json +3 -3
  3. package/src/core/CoreAppShell.tsx +34 -26
  4. package/src/core/__tests__/AppChrome.test.tsx +0 -3
  5. package/src/core/__tests__/bootstrap.test.ts +33 -1
  6. package/src/core/__tests__/events.test.ts +43 -0
  7. package/src/core/bootstrap.ts +38 -1
  8. package/src/core/events.ts +85 -3
  9. package/src/core/registry.ts +1 -1
  10. package/src/lib/__tests__/api.test.ts +38 -0
  11. package/src/lib/__tests__/email.test.ts +44 -0
  12. package/src/lib/api.ts +19 -2
  13. package/src/lib/email.ts +37 -1
  14. package/src/lib/utils.ts +2 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.add-row-picking.test.tsx +141 -0
  16. package/src/modules/access/__tests__/ManageAccessDialog.chip-truncation.test.tsx +204 -0
  17. package/src/modules/access/__tests__/ManageAccessDialog.download-read.test.tsx +234 -0
  18. package/src/modules/access/__tests__/ManageAccessDialog.edited-row-visible.test.tsx +160 -0
  19. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +2 -2
  20. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +166 -0
  21. package/src/modules/access/__tests__/ManageAccessDialog.restrict.test.tsx +510 -0
  22. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-axes.test.tsx +299 -0
  23. package/src/modules/access/__tests__/ManageAccessDialog.row-menu-width.test.tsx +226 -0
  24. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +781 -76
  25. package/src/modules/access/__tests__/ManageAccessDialog.unknown-email.test.tsx +314 -0
  26. package/src/modules/access/__tests__/manage-access-affordance.test.ts +14 -0
  27. package/src/modules/access/__tests__/plugin-token.test.ts +21 -0
  28. package/src/modules/access/__tests__/tailwindDeclarations.ts +210 -0
  29. package/src/modules/access/api.ts +192 -10
  30. package/src/modules/access/components/ManageAccessDialog.tsx +1337 -570
  31. package/src/modules/access/manage-access-affordance.ts +17 -0
  32. package/src/modules/admin/__tests__/AddMemberInput.test.tsx +297 -0
  33. package/src/modules/admin/__tests__/AdminRolesPage.capabilities.test.tsx +2 -2
  34. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +189 -0
  35. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +1 -1
  36. package/src/modules/admin/__tests__/ConnectionKeysPage.test.tsx +266 -0
  37. package/src/modules/admin/__tests__/DirectoryGroupsPage.suggest.test.tsx +182 -0
  38. package/src/modules/admin/__tests__/DirectoryGroupsPage.test.tsx +165 -14
  39. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +401 -4
  40. package/src/modules/admin/__tests__/group-members-path.test.ts +27 -0
  41. package/src/modules/admin/components/AddMemberInput.tsx +268 -0
  42. package/src/modules/admin/components/AdminRolesPage.tsx +97 -132
  43. package/src/modules/admin/components/ConnectionKeysPage.tsx +269 -0
  44. package/src/modules/admin/components/DirectoryGroupsPage.tsx +91 -39
  45. package/src/modules/admin/components/UserAccountsPage.tsx +271 -37
  46. package/src/modules/admin/components/connection-keys-grouping.ts +43 -0
  47. package/src/modules/admin/components/group-members-path.ts +32 -0
  48. package/src/modules/admin/services/connection-keys.api.ts +47 -0
  49. package/src/modules/admin/services/roles.api.ts +12 -1
  50. package/src/modules/auth/__tests__/AccountPage.test.tsx +50 -2
  51. package/src/modules/auth/components/AccountPage.tsx +73 -54
  52. package/src/modules/auth/components/LoginScreen.tsx +1 -0
  53. package/src/modules/auth/services/account.api.ts +78 -4
  54. package/src/modules/change-requests/__tests__/ChangeRequestDialog.access-rules.test.tsx +144 -0
  55. package/src/modules/change-requests/__tests__/ChangeRequestDialog.binary.test.tsx +422 -0
  56. package/src/modules/change-requests/__tests__/ChangeRequestDialog.brings-itself-up-to-date.test.tsx +431 -0
  57. package/src/modules/change-requests/__tests__/ChangeRequestDialog.fork-point.test.tsx +193 -0
  58. package/src/modules/change-requests/__tests__/ChangeRequestDialog.initial-file.test.tsx +142 -0
  59. package/src/modules/change-requests/__tests__/ChangeRequestDialog.moved.test.tsx +202 -0
  60. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +205 -13
  61. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +271 -0
  62. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +208 -0
  63. package/src/modules/change-requests/__tests__/apply-outcome-for-every-viewer.test.tsx +286 -0
  64. package/src/modules/change-requests/__tests__/propose.concurrent.test.ts +273 -0
  65. package/src/modules/change-requests/__tests__/readFailure.test.ts +122 -0
  66. package/src/modules/change-requests/__tests__/useCrFileDiffs.test.tsx +238 -0
  67. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +56 -1
  68. package/src/modules/change-requests/__tests__/useForkPointFile.test.tsx +79 -0
  69. package/src/modules/change-requests/components/BranchFilePreview.tsx +357 -0
  70. package/src/modules/change-requests/components/ChangeBox.tsx +31 -2
  71. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +862 -72
  72. package/src/modules/change-requests/components/CrFileTree.tsx +74 -58
  73. package/src/modules/change-requests/components/FileChangeBoxes.tsx +19 -15
  74. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +41 -7
  75. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +181 -23
  76. package/src/modules/change-requests/hooks/useFileOnBranch.ts +70 -7
  77. package/src/modules/change-requests/hooks/useForkPointFile.ts +77 -0
  78. package/src/modules/change-requests/services/change-requests.api.ts +57 -1
  79. package/src/modules/change-requests/services/denied-file.api.ts +53 -0
  80. package/src/modules/change-requests/services/propose.api.ts +97 -8
  81. package/src/modules/change-requests/utils/approval.ts +15 -0
  82. package/src/modules/change-requests/utils/author.ts +32 -0
  83. package/src/modules/change-requests/utils/readFailure.ts +110 -0
  84. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +20 -0
  85. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +65 -1
  86. package/src/modules/git/components/FileHistoryPanel.tsx +5 -0
  87. package/src/modules/git/components/GitSyncFailedBanner.tsx +68 -5
  88. package/src/modules/git/components/PullRequestsForMe.tsx +51 -24
  89. package/src/modules/git/services/__tests__/error-messages.test.ts +29 -0
  90. package/src/modules/git/services/error-messages.ts +12 -0
  91. package/src/modules/git/services/pr-prompts.ts +5 -5
  92. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +401 -0
  93. package/src/modules/layout/__tests__/SidebarFooterGrid.test.tsx +286 -0
  94. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +61 -0
  95. package/src/modules/layout/components/AppLayout.tsx +2 -0
  96. package/src/modules/layout/components/MobileChatLayout.tsx +4 -1
  97. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +4 -1
  98. package/src/modules/layout/components/SidebarFrame.tsx +109 -4
  99. package/src/modules/library/__tests__/AddToPluginDialog.test.tsx +171 -5
  100. package/src/modules/library/__tests__/DeleteToolDialog.test.tsx +356 -0
  101. package/src/modules/library/__tests__/IntegrationsSetupReminder.test.tsx +60 -0
  102. package/src/modules/library/__tests__/LibraryCard.test.tsx +91 -10
  103. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +242 -107
  104. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +104 -99
  105. package/src/modules/library/__tests__/LinkSkillPanel.test.tsx +136 -0
  106. package/src/modules/library/__tests__/LockedPluginView.test.tsx +103 -7
  107. package/src/modules/library/__tests__/NewPluginDialog.test.tsx +18 -8
  108. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +79 -3
  109. package/src/modules/library/__tests__/PersonalPluginPage.test.tsx +201 -0
  110. package/src/modules/library/__tests__/PluginExtras.test.tsx +115 -9
  111. package/src/modules/library/__tests__/PluginJoinRequests.test.tsx +60 -1
  112. package/src/modules/library/__tests__/PluginPage.test.tsx +453 -7
  113. package/src/modules/library/__tests__/PluginsSidebar.contextmenu.test.tsx +17 -57
  114. package/src/modules/library/__tests__/PluginsSidebar.test.tsx +161 -97
  115. package/src/modules/library/__tests__/PluginsSidebarMenu.test.tsx +16 -0
  116. package/src/modules/library/__tests__/SharedViaPlugins.test.tsx +106 -0
  117. package/src/modules/library/__tests__/SkillPage.test.tsx +391 -78
  118. package/src/modules/library/__tests__/SkillsTree.test.tsx +461 -0
  119. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +582 -71
  120. package/src/modules/library/__tests__/ToolPage.test.tsx +94 -4
  121. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +279 -21
  122. package/src/modules/library/__tests__/auth-harness.tsx +9 -9
  123. package/src/modules/library/__tests__/card-row-menu.test.tsx +320 -0
  124. package/src/modules/library/__tests__/library-data.mapping.test.tsx +98 -0
  125. package/src/modules/library/__tests__/library-data.stale.test.tsx +183 -0
  126. package/src/modules/library/__tests__/library-data.test.ts +7 -0
  127. package/src/modules/library/__tests__/library-paths.test.ts +75 -0
  128. package/src/modules/library/__tests__/link-membership.test.ts +129 -0
  129. package/src/modules/library/__tests__/name-with-badges.test.tsx +273 -0
  130. package/src/modules/library/__tests__/newSkillMarkdown.test.ts +30 -0
  131. package/src/modules/library/__tests__/owner-pill.test.tsx +357 -0
  132. package/src/modules/library/__tests__/pending-tools.test.tsx +400 -0
  133. package/src/modules/library/__tests__/plugin-entries.test.ts +122 -0
  134. package/src/modules/library/__tests__/plugin-summary.test.ts +67 -0
  135. package/src/modules/library/__tests__/status.test.ts +82 -2
  136. package/src/modules/library/__tests__/tools.api.test.ts +44 -1
  137. package/src/modules/library/__tests__/useJoinRequests.test.tsx +46 -0
  138. package/src/modules/library/components/AccessRequestsBanner.tsx +85 -47
  139. package/src/modules/library/components/AddDialogTabs.tsx +103 -0
  140. package/src/modules/library/components/AddToPluginDialog.tsx +107 -18
  141. package/src/modules/library/components/IntegrationsSetupReminder.tsx +59 -0
  142. package/src/modules/library/components/ItemActionsMenu.tsx +288 -0
  143. package/src/modules/library/components/LibraryCard.tsx +149 -34
  144. package/src/modules/library/components/LibraryLayout.tsx +120 -247
  145. package/src/modules/library/components/LibraryPage.tsx +172 -39
  146. package/src/modules/library/components/LinkSkillPanel.tsx +169 -0
  147. package/src/modules/library/components/LockedPluginView.tsx +63 -35
  148. package/src/modules/library/components/NameWithBadges.tsx +164 -0
  149. package/src/modules/library/components/NewPluginDialog.tsx +19 -5
  150. package/src/modules/library/components/PageActions.tsx +31 -9
  151. package/src/modules/library/components/{PendingSkillReview.tsx → PendingItemReview.tsx} +14 -7
  152. package/src/modules/library/components/PersonalAddDialog.tsx +68 -18
  153. package/src/modules/library/components/PersonalPluginPage.tsx +123 -23
  154. package/src/modules/library/components/PluginExtras.tsx +143 -18
  155. package/src/modules/library/components/PluginIndexRow.tsx +47 -12
  156. package/src/modules/library/components/PluginPage.tsx +234 -38
  157. package/src/modules/library/components/PluginRows.tsx +286 -0
  158. package/src/modules/library/components/PluginsSidebar.tsx +271 -238
  159. package/src/modules/library/components/PluginsSidebarMenu.tsx +26 -1
  160. package/src/modules/library/components/RenamePluginDialog.tsx +136 -0
  161. package/src/modules/library/components/ShareButton.tsx +17 -0
  162. package/src/modules/library/components/SkillsTree.tsx +204 -0
  163. package/src/modules/library/components/StatusDot.tsx +1 -0
  164. package/src/modules/library/components/TeamRoute.tsx +15 -0
  165. package/src/modules/library/components/__tests__/upload-notices-once-per-page.test.tsx +144 -0
  166. package/src/modules/library/components/plugin-page-parts.tsx +132 -23
  167. package/src/modules/library/components/skill-page/SharedViaPlugins.tsx +212 -0
  168. package/src/modules/library/components/skill-page/SkillFilePane.tsx +5 -0
  169. package/src/modules/library/components/skill-page/SkillPage.tsx +337 -121
  170. package/src/modules/library/components/tool-page/DeleteToolDialog.tsx +218 -0
  171. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +79 -178
  172. package/src/modules/library/components/tool-page/ToolPage.tsx +116 -17
  173. package/src/modules/library/components/tool-page/ToolVarRow.tsx +42 -41
  174. package/src/modules/library/hooks/__tests__/useLibraryData.test.ts +98 -0
  175. package/src/modules/library/hooks/useJoinRequests.ts +48 -18
  176. package/src/modules/library/hooks/useLibraryData.ts +92 -19
  177. package/src/modules/library/routes/LibraryRoutes.tsx +14 -11
  178. package/src/modules/library/routes/WorkspaceItemRoute.tsx +229 -82
  179. package/src/modules/library/routes/library-paths.ts +46 -35
  180. package/src/modules/library/services/library.api.ts +89 -17
  181. package/src/modules/library/services/plugins.api.ts +161 -9
  182. package/src/modules/library/services/teams.api.ts +15 -0
  183. package/src/modules/library/services/tools.api.ts +78 -0
  184. package/src/modules/library/state/library-data.tsx +268 -37
  185. package/src/modules/library/utils/personal-plugin.ts +13 -15
  186. package/src/modules/library/utils/plugin-entries.ts +134 -0
  187. package/src/modules/library/utils/plugin-summary.ts +102 -0
  188. package/src/modules/library/utils/status.ts +204 -35
  189. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +11 -3
  190. package/src/modules/onboarding/__tests__/onboarding.test.tsx +853 -760
  191. package/src/modules/onboarding/agent-clients.ts +55 -23
  192. package/src/modules/onboarding/components/ConnectAgentPill.tsx +5 -1
  193. package/src/modules/onboarding/components/WelcomePage.tsx +98 -62
  194. package/src/modules/pr/services/pr-merge.api.ts +2 -1
  195. package/src/modules/review/components/MarkdownDiffViewer.tsx +53 -8
  196. package/src/modules/review/components/ReviewPanel.tsx +15 -17
  197. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +64 -0
  198. package/src/modules/review/components/__tests__/ReviewPanel.test.tsx +25 -1
  199. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +454 -117
  200. package/src/modules/secrets-vault/components/SecretsPage.tsx +48 -7
  201. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +84 -5
  202. package/src/modules/secrets-vault/components/__tests__/ConnectToolsPage.test.tsx +425 -0
  203. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +417 -82
  204. package/src/modules/secrets-vault/components/__tests__/ToolSecretsPanel.test.tsx +105 -0
  205. package/src/modules/secrets-vault/components/__tests__/connect-lists-what-the-banner-counted.test.tsx +407 -0
  206. package/src/modules/secrets-vault/probe/SavedKeyProbeResult.tsx +98 -0
  207. package/src/modules/secrets-vault/probe/__tests__/probe-verdict.test.ts +160 -0
  208. package/src/modules/secrets-vault/probe/probe-verdict.ts +108 -0
  209. package/src/modules/secrets-vault/probe/useSavedKeyProbe.ts +228 -0
  210. package/src/modules/secrets-vault/services/connect.api.ts +36 -5
  211. package/src/modules/secrets-vault/utils/connect-status.ts +98 -0
  212. package/src/modules/settings/components/ClaudeConnectionCard.tsx +154 -0
  213. package/src/modules/settings/components/ClaudeConnectionFields.tsx +23 -0
  214. package/src/modules/settings/components/DeploymentPage.tsx +16 -22
  215. package/src/modules/settings/components/MarketplaceSection.tsx +152 -0
  216. package/src/modules/settings/components/__tests__/ClaudeConnectionCard.test.tsx +63 -0
  217. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +74 -1
  218. package/src/modules/settings/components/__tests__/MarketplaceSection.test.tsx +325 -0
  219. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +5 -5
  220. package/src/modules/settings/services/github-facade.api.ts +66 -0
  221. package/src/modules/settings/settings-nav-items.tsx +10 -2
  222. package/src/modules/setup/__tests__/setup.oidc.test.tsx +172 -0
  223. package/src/modules/setup/__tests__/setup.probe-refusal.test.tsx +123 -0
  224. package/src/modules/setup/__tests__/setup.test.tsx +615 -4
  225. package/src/modules/setup/__tests__/useSetupStatus.test.tsx +130 -0
  226. package/src/modules/setup/components/SetupGate.tsx +16 -16
  227. package/src/modules/setup/components/SetupScreen.tsx +711 -40
  228. package/src/modules/setup/hooks/useSetupStatus.ts +93 -0
  229. package/src/modules/setup/services/setup.api.ts +218 -3
  230. package/src/modules/setup/utils/__tests__/root-folders.test.ts +72 -0
  231. package/src/modules/setup/utils/root-folders.ts +46 -0
  232. package/src/modules/toolbar/assets/claude-setup/01-add-manually.webp +0 -0
  233. package/src/modules/toolbar/assets/claude-setup/02-add-configuration.webp +0 -0
  234. package/src/modules/toolbar/assets/claude-setup/03-connect-account.webp +0 -0
  235. package/src/modules/toolbar/assets/claude-setup/04-pick-instance.webp +0 -0
  236. package/src/modules/toolbar/assets/claude-setup/05-plugins-add.webp +0 -0
  237. package/src/modules/toolbar/assets/claude-setup/06-add-marketplace.webp +0 -0
  238. package/src/modules/toolbar/assets/claude-setup/07-paste-url-sync.webp +0 -0
  239. package/src/modules/toolbar/assets/claude-setup/08-install-plugins.webp +0 -0
  240. package/src/modules/toolbar/assets/claude-setup/09-select-repository.webp +0 -0
  241. package/src/modules/toolbar/assets/claude-setup/10-connector-not-added.webp +0 -0
  242. package/src/modules/toolbar/assets/claude-setup/11-add-custom-connector.webp +0 -0
  243. package/src/modules/toolbar/assets/claude-setup/README.md +68 -0
  244. package/src/modules/toolbar/components/AgentInstructionsCard.tsx +296 -0
  245. package/src/modules/toolbar/components/ClaudeMarketplaceCarousel.tsx +107 -0
  246. package/src/modules/toolbar/components/ClaudeRegistrationSteps.tsx +127 -0
  247. package/src/modules/toolbar/components/CoworkSetupSteps.tsx +100 -0
  248. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +395 -124
  249. package/src/modules/toolbar/components/ScreenshotStep.tsx +77 -0
  250. package/src/modules/toolbar/components/SetupCarousel.tsx +177 -0
  251. package/src/modules/toolbar/components/__tests__/AgentInstructionsCard.test.tsx +370 -0
  252. package/src/modules/toolbar/components/__tests__/ExternalAgentAccessPage.test.tsx +659 -36
  253. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +2 -2
  254. package/src/modules/toolbar/components/__tests__/claude-setup-shots.test.ts +104 -0
  255. package/src/modules/toolbar/components/claude-connector-slide.tsx +38 -0
  256. package/src/modules/toolbar/components/claude-setup-shots.ts +167 -0
  257. package/src/modules/toolbar/components/deployment-address.ts +29 -0
  258. package/src/modules/toolbar/components/setup-step-parts.tsx +35 -0
  259. package/src/modules/toolbar/services/__tests__/agent-instructions.api.test.ts +89 -0
  260. package/src/modules/toolbar/services/agent-instructions.api.ts +167 -0
  261. package/src/modules/toolbar/services/external-api-keys.api.ts +8 -0
  262. package/src/modules/workflow/state/ChangeRequestStaleBinder.tsx +43 -0
  263. package/src/modules/workflow/state/EventBusProvider.tsx +122 -11
  264. package/src/modules/workflow/state/__tests__/EventBusProvider.storage.test.tsx +87 -0
  265. package/src/modules/workflow/state/__tests__/EventBusProvider.watch.test.tsx +223 -0
  266. package/src/modules/workflow/state/event-bus.context.ts +10 -0
  267. package/src/modules/workspace/__tests__/testFixtures.ts +6 -3
  268. package/src/modules/workspace/components/FileExplorer.tsx +1527 -367
  269. package/src/modules/workspace/components/FileRoute.tsx +376 -22
  270. package/src/modules/workspace/components/FileViewer.tsx +166 -45
  271. package/src/modules/workspace/components/KbDocumentShell.tsx +50 -6
  272. package/src/modules/workspace/components/KbPageHeader.tsx +120 -55
  273. package/src/modules/workspace/components/TreeActionConfirm.tsx +350 -0
  274. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +2473 -129
  275. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +768 -16
  276. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +332 -12
  277. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +39 -0
  278. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +33 -20
  279. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +4 -5
  280. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +13 -4
  281. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +4 -3
  282. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +8 -14
  283. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +75 -16
  284. package/src/modules/workspace/components/renderers/KbImage.tsx +180 -0
  285. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +22 -6
  286. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +48 -22
  287. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +4 -5
  288. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +4 -3
  289. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +4 -3
  290. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +12 -0
  291. package/src/modules/workspace/components/renderers/__tests__/DownloadFileButton.test.tsx +57 -9
  292. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.test.tsx +13 -1
  293. package/src/modules/workspace/components/renderers/__tests__/ImageRenderer.test.tsx +163 -0
  294. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +237 -0
  295. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +108 -14
  296. package/src/modules/workspace/components/renderers/__tests__/PptxRenderer.test.tsx +14 -1
  297. package/src/modules/workspace/components/renderers/__tests__/XlsxRenderer.test.tsx +16 -1
  298. package/src/modules/workspace/components/renderers/__tests__/rendererSelection.test.tsx +66 -1
  299. package/src/modules/workspace/components/renderers/index.ts +53 -2
  300. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +25 -4
  301. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +40 -0
  302. package/src/modules/workspace/hooks/__tests__/useImageRevision.test.tsx +174 -0
  303. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +179 -1
  304. package/src/modules/workspace/hooks/__tests__/useWorkspaceImageResolver.test.tsx +122 -0
  305. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +892 -7
  306. package/src/modules/workspace/hooks/useImageRevision.ts +101 -0
  307. package/src/modules/workspace/hooks/useMergedWorkspaceTree.ts +89 -0
  308. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +55 -0
  309. package/src/modules/workspace/hooks/useWorkspaceState.ts +438 -66
  310. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +279 -3
  311. package/src/modules/workspace/routing/kb-routes.ts +207 -30
  312. package/src/modules/workspace/services/__tests__/workspace.api.test.ts +57 -1
  313. package/src/modules/workspace/services/workspace.api.ts +57 -4
  314. package/src/modules/workspace/state/__tests__/applied-request-clears-pending.test.tsx +343 -0
  315. package/src/modules/workspace/state/__tests__/upload-lands-where-it-was-dropped.test.tsx +158 -0
  316. package/src/modules/workspace/state/open-change-requests.tsx +100 -12
  317. package/src/modules/workspace/state/workspace.context.ts +130 -16
  318. package/src/modules/workspace/utils/__tests__/file-trace.test.ts +73 -0
  319. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +234 -5
  320. package/src/modules/workspace/utils/__tests__/pasteLink.test.ts +76 -0
  321. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +364 -0
  322. package/src/modules/workspace/utils/__tests__/uploadError.test.ts +35 -0
  323. package/src/modules/workspace/utils/file-trace.ts +50 -0
  324. package/src/modules/workspace/utils/fileTree.ts +126 -52
  325. package/src/modules/workspace/utils/frontmatter.ts +8 -4
  326. package/src/modules/workspace/utils/pasteLink.ts +90 -0
  327. package/src/modules/workspace/utils/treeConfirm.ts +338 -0
  328. package/src/modules/workspace/utils/uploadError.ts +29 -0
  329. package/src/shared/__tests__/marketplace-url.test.ts +59 -0
  330. package/src/shared/components/Badge.tsx +3 -1
  331. package/src/shared/components/Banner.tsx +5 -1
  332. package/src/shared/components/Button.tsx +16 -2
  333. package/src/shared/components/Dialog.tsx +27 -11
  334. package/src/shared/components/Menu.tsx +13 -1
  335. package/src/shared/components/PageShell.tsx +13 -8
  336. package/src/shared/components/__tests__/primitives.test.tsx +116 -2
  337. package/src/shared/components/__tests__/useFocusHandoff.test.tsx +192 -0
  338. package/src/shared/components/index.ts +2 -0
  339. package/src/shared/components/useDismissableMenu.ts +32 -10
  340. package/src/shared/components/useFocusHandoff.ts +51 -0
  341. package/src/shared/components/useLatestRef.ts +28 -0
  342. package/src/shared/markdown/Markdown.tsx +12 -3
  343. package/src/shared/markdown/__tests__/escapeSpacesInLinkDestinations.test.ts +39 -0
  344. package/src/shared/markdown/hrefs.ts +50 -0
  345. package/src/shared/marketplace-url.ts +118 -0
  346. package/src/shared/mcp/ChatGptInstallLink.tsx +3 -3
  347. package/src/shared/mcp/ConnectionInstructions.tsx +38 -27
  348. package/src/shared/mcp/__tests__/connect-snippets.test.ts +3 -3
  349. package/src/shared/mcp/connect-snippets.ts +14 -9
  350. package/src/shared/mcp/index.ts +1 -1
  351. package/src/shared/theme/__tests__/header-band.test.ts +197 -0
  352. package/src/shared/theme/header.ts +75 -0
  353. package/src/shared/theme/measure.ts +7 -4
  354. package/src/shared/theme/tokens.css +34 -0
  355. package/src/modules/library/__tests__/PluginsIndexPage.test.tsx +0 -363
  356. package/src/modules/library/__tests__/PluginsSidebar.locked.test.tsx +0 -97
  357. package/src/modules/library/components/PluginsIndexPage.tsx +0 -265
  358. package/src/modules/update-check/__tests__/UpdateBanner.test.tsx +0 -126
  359. package/src/modules/update-check/components/UpdateBanner.tsx +0 -92
  360. package/src/modules/update-check/services/update-check.api.ts +0 -24
@@ -26,7 +26,7 @@ function LocationProbe() {
26
26
  return <div aria-label="pathname">{location.pathname}</div>;
27
27
  }
28
28
 
29
- function renderDialog(existing: string[] = ['GTM', 'Finance']) {
29
+ function renderDialog(existing: string[] = ['GTM', 'Finance'], parent?: string) {
30
30
  const onCreated = vi.fn();
31
31
  const onClose = vi.fn();
32
32
  render(
@@ -36,7 +36,7 @@ function renderDialog(existing: string[] = ['GTM', 'Finance']) {
36
36
  <Route
37
37
  path="*"
38
38
  element={
39
- <NewPluginDialog existing={existing} onClose={onClose} onCreated={onCreated} />
39
+ <NewPluginDialog existing={existing} parent={parent} onClose={onClose} onCreated={onCreated} />
40
40
  }
41
41
  />
42
42
  </Routes>
@@ -56,10 +56,11 @@ function renderDialog(existing: string[] = ['GTM', 'Finance']) {
56
56
  describe('NewPluginDialog', () => {
57
57
  beforeEach(() => {
58
58
  pluginsMock.createPlugin.mockReset();
59
- // A folder name that DIFFERS from the input, so a dialog that navigates
60
- // with the typed name instead of the server's answer fails here.
59
+ // A folder AND an identity that both DIFFER from the input, so a dialog
60
+ // that navigates with the typed name — or with the folder — fails here.
61
61
  pluginsMock.createPlugin.mockImplementation(async (name: string) => ({
62
62
  folder: `${name}-canonical`,
63
+ name: `${name.toLowerCase()}-id`,
63
64
  }));
64
65
  });
65
66
 
@@ -73,11 +74,20 @@ describe('NewPluginDialog', () => {
73
74
  fireEvent.change(field(), { target: { value: ' Design ' } });
74
75
  fireEvent.click(submit());
75
76
 
76
- // Trimmed — the endpoint owns everything after the name.
77
- await waitFor(() => expect(pluginsMock.createPlugin).toHaveBeenCalledWith('Design'));
78
- // The route is built from the SERVER's folder, not the typed name.
79
- await waitFor(() => expect(pathname()).toBe('/skills-and-tools/plugins/Design-canonical'));
77
+ // Trimmed — the endpoint owns everything after the name. No parent: the root.
78
+ await waitFor(() => expect(pluginsMock.createPlugin).toHaveBeenCalledWith('Design', ''));
79
+ // The route is built from the SERVER's identity — not the typed name, not the folder.
80
+ await waitFor(() => expect(pathname()).toBe('/skills-and-tools/plugins/design-id'));
80
81
  expect(onCreated).toHaveBeenCalledTimes(1);
82
+ expect(screen.queryByText(/This one goes in/)).toBeNull();
83
+ });
84
+
85
+ it('makes the plugin inside the folder it was opened from, and says so', async () => {
86
+ const { field, submit } = renderDialog(['GTM'], 'Teams/EU');
87
+ expect(screen.getByText(/This one goes in/)).toHaveTextContent('Teams/EU/');
88
+ fireEvent.change(field(), { target: { value: 'Design' } });
89
+ fireEvent.click(submit());
90
+ await waitFor(() => expect(pluginsMock.createPlugin).toHaveBeenCalledWith('Design', 'Teams/EU'));
81
91
  });
82
92
 
83
93
  it('refuses a name that is already taken, whoever can see it', () => {
@@ -1,6 +1,6 @@
1
1
  import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
2
2
  import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
3
- import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
+ import { render, screen, fireEvent, waitFor, within } from '@testing-library/react';
4
4
  import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
5
5
  import {
6
6
  WorkspaceContext,
@@ -115,7 +115,9 @@ describe('PersonalAddDialog', () => {
115
115
  const { field } = renderDialog();
116
116
  expect(field()).toBeInTheDocument();
117
117
  expect(screen.getByRole('button', { name: 'Copy prompt' })).toBeInTheDocument();
118
- expect(screen.getByText(/Yours alone until you add it to a plugin/)).toBeInTheDocument();
118
+ expect(
119
+ within(screen.getByRole('tabpanel')).getByText(/Yours alone until you add it to a plugin/),
120
+ ).toBeInTheDocument();
119
121
  });
120
122
 
121
123
  it('creates the skill as PERSONAL. Destination resolution belongs to the api layer', async () => {
@@ -171,7 +173,81 @@ describe('PersonalAddDialog', () => {
171
173
  expect(screen.queryByRole('textbox', { name: 'Skill name' })).not.toBeInTheDocument();
172
174
  expect(screen.getByRole('button', { name: 'Copy prompt' })).toBeInTheDocument();
173
175
  expect(screen.getByText(/Tell your agent what you need/)).toBeInTheDocument();
174
- expect(screen.getByText(/Yours alone until you add it to a plugin/)).toBeInTheDocument();
176
+ expect(
177
+ within(screen.getByRole('tabpanel')).getByText(/Yours alone until you add it to a plugin/),
178
+ ).toBeInTheDocument();
175
179
  expect(apiMock.createEmptySkill).not.toHaveBeenCalled();
176
180
  });
177
181
  });
182
+
183
+ // Both panels stay mounted and the inactive one is hidden, so the Skills half
184
+ // never loses a half-typed name to a tab click. Text assertions are therefore
185
+ // scoped to the visible panel — the note about landing in your own list is
186
+ // worded identically on both tabs.
187
+ describe('PersonalAddDialog: Skills and Tools tabs', () => {
188
+ const SKILL_PROMPT =
189
+ 'Help me build a new skill or tool at Bevel. Keep it to myself for now. It goes in my own list, not a plugin.';
190
+ const TOOL_PROMPT =
191
+ 'Help me build a new tool at Bevel. Keep it to myself for now. It goes in my own list, not a plugin.';
192
+ const writeText = vi.fn<(text: string) => Promise<void>>();
193
+
194
+ /** The visible tabpanel. Role queries skip the hidden one. */
195
+ const panel = () => screen.getByRole('tabpanel');
196
+
197
+ beforeEach(() => {
198
+ writeText.mockReset();
199
+ writeText.mockResolvedValue(undefined);
200
+ Object.defineProperty(navigator, 'clipboard', { value: { writeText }, configurable: true });
201
+ });
202
+
203
+ afterEach(() => {
204
+ Reflect.deleteProperty(navigator, 'clipboard');
205
+ });
206
+
207
+ it('opens on an unchanged Skills tab', () => {
208
+ renderDialog();
209
+ expect(screen.getAllByRole('tab').map((t) => t.textContent)).toEqual(['Skills', 'Tools']);
210
+ expect(screen.getByRole('tab', { name: 'Skills' })).toHaveAttribute('aria-selected', 'true');
211
+ expect(panel()).toHaveAccessibleName('Skills');
212
+ expect(within(panel()).getByText(SKILL_PROMPT)).toBeInTheDocument();
213
+ expect(screen.getByText(TOOL_PROMPT)).not.toBeVisible();
214
+ expect(screen.getByRole('heading', { name: 'Add a skill or tool' })).toBeInTheDocument();
215
+ });
216
+
217
+ it('explains tools without a form, and copies the tool prompt', async () => {
218
+ renderDialog();
219
+ fireEvent.click(screen.getByRole('tab', { name: 'Tools' }));
220
+
221
+ expect(panel()).toHaveAccessibleName('Tools');
222
+ expect(within(panel()).getByText(TOOL_PROMPT)).toBeInTheDocument();
223
+ expect(screen.getByText(SKILL_PROMPT)).not.toBeVisible();
224
+ expect(
225
+ within(panel()).getByText(/Yours alone until you add it to a plugin/),
226
+ ).toBeInTheDocument();
227
+ expect(
228
+ within(panel()).getByText(
229
+ 'To connect an MCP server, add it to the mcp.json in your own folder.',
230
+ ),
231
+ ).toBeInTheDocument();
232
+ expect(
233
+ within(panel()).getByText(
234
+ 'To call an API without an MCP server, add a .tool manual describing it under software.bevel.hexis/tools/ in your own folder.',
235
+ ),
236
+ ).toBeInTheDocument();
237
+ expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
238
+
239
+ fireEvent.click(screen.getByRole('button', { name: 'Copy prompt' }));
240
+ await waitFor(() => expect(writeText).toHaveBeenCalledWith(TOOL_PROMPT));
241
+ expect(apiMock.createEmptySkill).not.toHaveBeenCalled();
242
+ });
243
+
244
+ it('keeps a typed skill name across a tab round trip', () => {
245
+ const { field } = renderDialog();
246
+ fireEvent.change(field(), { target: { value: 'scratch' } });
247
+
248
+ fireEvent.click(screen.getByRole('tab', { name: 'Tools' }));
249
+ fireEvent.click(screen.getByRole('tab', { name: 'Skills' }));
250
+
251
+ expect(field()).toHaveValue('scratch');
252
+ });
253
+ });
@@ -0,0 +1,201 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, within } from '@testing-library/react';
3
+ import { MemoryRouter } from 'react-router-dom';
4
+ import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
5
+ import {
6
+ WorkspaceContext,
7
+ type WorkspaceContextValue,
8
+ } from '../../workspace/state/workspace.context';
9
+ import { AdminContext, type AdminContextValue } from '../../admin/state/admin.context';
10
+ import type { LibraryData } from '../hooks/useLibraryData';
11
+
12
+ /**
13
+ * Your own space — the items in no plugin folder, given the page every plugin
14
+ * gets.
15
+ *
16
+ * What this file owes is the distinction the page's docstring draws: the SPACE
17
+ * has nothing to share, because it is defined as the items in no folder and
18
+ * there is no `access.md` to point a dialog at — so no Share in the title row,
19
+ * still. A SKILL on it is a folder of its own with its own rules, which is
20
+ * exactly the standalone skill the skill page shares, so its card carries the
21
+ * same menu it carries everywhere else. A tool does not: what a tool shares is
22
+ * decided at the plugin that carries it, and here there is no plugin at all.
23
+ */
24
+
25
+ const dataMock = vi.hoisted(() => ({ useLibraryData: vi.fn() }));
26
+ vi.mock('../hooks/useLibraryData', () => ({ useLibraryData: dataMock.useLibraryData }));
27
+ vi.mock('../services/plugins.api', () => ({ listPlugins: vi.fn().mockResolvedValue([]) }));
28
+ vi.mock('../services/teams.api', () => ({ listTeams: vi.fn().mockResolvedValue([]) }));
29
+ vi.mock('../../access/api', async (importOriginal) => ({
30
+ ...(await importOriginal<typeof import('../../access/api')>()),
31
+ fetchFileAccessBatch: vi.fn(async (_ws: string, paths: string[]) => ({
32
+ results: Object.fromEntries(paths.map((p) => [p, true])),
33
+ })),
34
+ }));
35
+ // The dialog fetches on mount; stubbed at the component so this stays on the
36
+ // page's judgement — WHICH directory it opens on — as `PluginPage.test` does.
37
+ vi.mock('../../access/components/ManageAccessDialog', () => ({
38
+ ManageAccessDialog: ({
39
+ entry,
40
+ workspaceId,
41
+ onManageAncestor,
42
+ }: {
43
+ entry: { relativePath: string; type: string };
44
+ workspaceId?: string;
45
+ onManageAncestor?(entry: { name: string; relativePath: string; type: string }): void;
46
+ }) => (
47
+ // Which branch the rules are read and written on, and whether a grant the
48
+ // skill inherits can be managed where it lives, are both the page's to
49
+ // hand over — so the stub surfaces both.
50
+ <div
51
+ role="dialog"
52
+ aria-label={`Manage access ${entry.type} ${entry.relativePath}`}
53
+ data-workspace={workspaceId}
54
+ >
55
+ {onManageAncestor && (
56
+ <button
57
+ type="button"
58
+ onClick={() =>
59
+ onManageAncestor({
60
+ name: 'personal-juan',
61
+ relativePath: 'knowledge-base/Plugins/personal-juan',
62
+ type: 'directory',
63
+ })
64
+ }
65
+ >
66
+ Manage personal-juan →
67
+ </button>
68
+ )}
69
+ </div>
70
+ ),
71
+ }));
72
+
73
+ import { LibraryProvider } from '../state/library-data';
74
+ import { LibraryToastProvider } from '../state/toast';
75
+ import { PersonalPluginPage } from '../components/PersonalPluginPage';
76
+
77
+ const admin = {
78
+ isAdmin: false,
79
+ unreadCount: 0,
80
+ lastSeen: null,
81
+ markSeen: vi.fn(),
82
+ refresh: vi.fn(),
83
+ rolesConfigCorrupted: false,
84
+ rolesConfigErrors: [],
85
+ runRolesRecovery: vi.fn(),
86
+ } as unknown as AdminContextValue;
87
+
88
+ const workspace = {
89
+ workspaceId: 'target-company-state',
90
+ kbDirName: 'knowledge-base',
91
+ } as unknown as WorkspaceContextValue;
92
+
93
+ /** One skill and one tool, both in no plugin folder — what this page lists. */
94
+ const CATALOG: LibraryData = {
95
+ loading: false,
96
+ error: null,
97
+ // A personal shelf (`Plugins/personal-<uid>`) is the skill path this page is
98
+ // about: the catalog never lists it as a plugin, and it is not under the
99
+ // shared `Skills/` root either, so `isUngrouped` says yes to it and to
100
+ // nothing else.
101
+ skills: [{ name: 'rfi', description: 'Answers an RFI.', path: 'Plugins/personal-juan/rfi' }],
102
+ pendingSkills: [],
103
+ pendingTools: [],
104
+ tools: [
105
+ {
106
+ slug: 'weather',
107
+ name: 'Weather',
108
+ path: 'Tools/weather.tool',
109
+ type: 'http',
110
+ setup: null,
111
+ canWrite: true,
112
+ variables: [],
113
+ },
114
+ ],
115
+ ownedSkills: new Set(['rfi']),
116
+ writableSkills: new Set(['rfi']),
117
+ ownedTools: new Set(['weather']),
118
+ allowedToolsBySkill: new Map(),
119
+ crs: [],
120
+ myCrNumbers: new Set<number>(),
121
+ reload: vi.fn(),
122
+ } as unknown as LibraryData;
123
+
124
+ /** `ambient` is the branch the app happens to have OPEN — the default one
125
+ * everywhere but the access test, which is about the page not following it. */
126
+ function renderPage(ambient: WorkspaceContextValue = workspace) {
127
+ render(
128
+ <MemoryRouter initialEntries={['/skills-and-tools/yours']}>
129
+ <AdminContext.Provider value={admin}>
130
+ <WorkspaceContext.Provider value={ambient}>
131
+ <LibraryToastProvider>
132
+ <LibraryProvider>
133
+ <PersonalPluginPage />
134
+ </LibraryProvider>
135
+ </LibraryToastProvider>
136
+ </WorkspaceContext.Provider>
137
+ </AdminContext.Provider>
138
+ </MemoryRouter>,
139
+ );
140
+ }
141
+
142
+ beforeEach(() => {
143
+ vi.clearAllMocks();
144
+ dataMock.useLibraryData.mockReturnValue(CATALOG);
145
+ });
146
+
147
+ describe('your own space', () => {
148
+ it("shares a skill on the skill's own folder, though the space itself has none to share", async () => {
149
+ renderPage();
150
+
151
+ // The title row still offers no Share: there is no folder behind the page.
152
+ expect(screen.queryByRole('button', { name: 'Share' })).toBeNull();
153
+
154
+ fireEvent.click(await screen.findByRole('button', { name: 'Actions for rfi' }));
155
+ expect(
156
+ within(screen.getByRole('menu'))
157
+ .getAllByRole('menuitem')
158
+ .map((i) => i.textContent),
159
+ ).toEqual(['Open', 'Share']);
160
+
161
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Share' }));
162
+ expect(
163
+ await screen.findByRole('dialog', {
164
+ name: 'Manage access directory knowledge-base/Plugins/personal-juan/rfi',
165
+ }),
166
+ ).toBeInTheDocument();
167
+ });
168
+
169
+ /**
170
+ * Two things the skill page's Share does that a card's has to do as well, or
171
+ * the same dialog behaves differently depending on where it was opened from:
172
+ * it edits the DEFAULT branch (the one the catalog was read from — a grant
173
+ * spliced into an open change-request branch is a rule nobody merges), and
174
+ * it offers the walk up to a folder above the skill, without which an
175
+ * inherited grant is read-only here and editable on the skill's own page.
176
+ */
177
+ it("edits the default branch's rules, and can walk up to the folder above the skill", async () => {
178
+ renderPage({ ...workspace, workspaceId: 'a-change-request-branch' } as WorkspaceContextValue);
179
+
180
+ fireEvent.click(await screen.findByRole('button', { name: 'Actions for rfi' }));
181
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Share' }));
182
+
183
+ const dialog = await screen.findByRole('dialog');
184
+ expect(dialog.getAttribute('data-workspace')).toBe(encodeURIComponent(DEFAULT_BRANCH));
185
+ expect(dialog.getAttribute('data-workspace')).not.toBe('a-change-request-branch');
186
+
187
+ fireEvent.click(screen.getByRole('button', { name: 'Manage personal-juan →' }));
188
+ expect(
189
+ await screen.findByRole('dialog', {
190
+ name: 'Manage access directory knowledge-base/Plugins/personal-juan',
191
+ }),
192
+ ).toBeInTheDocument();
193
+ });
194
+
195
+ it('leaves the tool card alone', async () => {
196
+ renderPage();
197
+
198
+ expect(await screen.findByRole('button', { name: 'Actions for rfi' })).toBeInTheDocument();
199
+ expect(screen.queryByRole('button', { name: 'Actions for Weather' })).toBeNull();
200
+ });
201
+ });
@@ -14,10 +14,11 @@ import {
14
14
  * branch (no request at all), the fetch only when it sits elsewhere.
15
15
  */
16
16
 
17
- const apiMock = vi.hoisted(() => ({ listFiles: vi.fn() }));
17
+ const apiMock = vi.hoisted(() => ({ listFiles: vi.fn(), readFile: vi.fn() }));
18
18
  vi.mock('../../workspace/services/workspace.api', async (importOriginal) => ({
19
19
  ...(await importOriginal<object>()),
20
20
  listFiles: apiMock.listFiles,
21
+ readFile: apiMock.readFile,
21
22
  }));
22
23
 
23
24
  const navigateMock = vi.hoisted(() => vi.fn());
@@ -26,7 +27,7 @@ vi.mock('react-router-dom', async (importOriginal) => ({
26
27
  useNavigate: () => navigateMock,
27
28
  }));
28
29
 
29
- import { ClientExtensionsSection } from '../components/PluginExtras';
30
+ import { ClientExtensionsSection, ManifestSection } from '../components/PluginExtras';
30
31
 
31
32
  const dir = (name: string, children: FileTreeEntry[]): FileTreeEntry =>
32
33
  ({ name, relativePath: name, type: 'directory', children }) as FileTreeEntry;
@@ -58,9 +59,88 @@ function renderSection(workspace: Partial<WorkspaceContextValue>, folder = 'GTM'
58
59
 
59
60
  beforeEach(() => {
60
61
  apiMock.listFiles.mockReset();
62
+ apiMock.readFile.mockReset();
61
63
  navigateMock.mockReset();
62
64
  });
63
65
 
66
+ describe('ManifestSection', () => {
67
+ const MANIFEST = '{"name":"gtm","version":"1.2.0","extensions":{"software.bevel.hexis":{"skills":["Skills/Sales"]}}}';
68
+
69
+ it('is closed by default and reads nothing until opened; open, it shows the manifest laid out as JSON', async () => {
70
+ apiMock.readFile.mockResolvedValue(MANIFEST);
71
+ render(
72
+ <MemoryRouter>
73
+ <ManifestSection kbDirName="knowledge-base" folder="GTM" managed canWrite={false} />
74
+ </MemoryRouter>,
75
+ );
76
+ const header = screen.getByRole('button', { name: /^Manifest plugin\.json$/ });
77
+ expect(header).toHaveAttribute('aria-expanded', 'false');
78
+ expect(apiMock.readFile).not.toHaveBeenCalled();
79
+
80
+ fireEvent.click(header);
81
+ expect(header).toHaveAttribute('aria-expanded', 'true');
82
+ expect(apiMock.readFile).toHaveBeenCalledWith(
83
+ encodeURIComponent(DEFAULT_BRANCH),
84
+ 'knowledge-base/Plugins/GTM/plugin.json',
85
+ );
86
+ await waitFor(() => expect(screen.getByText(/"version": "1\.2\.0"/)).toBeInTheDocument());
87
+ // A reader gets no editor link.
88
+ expect(screen.queryByRole('button', { name: 'Edit the manifest' })).not.toBeInTheDocument();
89
+ });
90
+
91
+ it("reads the bundle dialect's file for an unmanaged plugin, and offers no editor even to a writer", async () => {
92
+ apiMock.readFile.mockResolvedValue('{"name":"example"}');
93
+ render(
94
+ <MemoryRouter>
95
+ <ManifestSection kbDirName="knowledge-base" folder="functional/cluster/example" managed={false} canWrite />
96
+ </MemoryRouter>,
97
+ );
98
+ fireEvent.click(screen.getByRole('button', { name: /^Manifest plugin\.bundle\.json$/ }));
99
+ expect(apiMock.readFile).toHaveBeenCalledWith(
100
+ encodeURIComponent(DEFAULT_BRANCH),
101
+ 'knowledge-base/Plugins/functional/cluster/example/plugin.bundle.json',
102
+ );
103
+ await waitFor(() => expect(screen.getByText(/"name": "example"/)).toBeInTheDocument());
104
+ expect(screen.queryByRole('button', { name: 'Edit the manifest' })).not.toBeInTheDocument();
105
+ });
106
+
107
+ it('a writer gets "Edit the manifest", which asks for the raw file by state', async () => {
108
+ apiMock.readFile.mockResolvedValue(MANIFEST);
109
+ render(
110
+ <MemoryRouter>
111
+ <ManifestSection kbDirName="knowledge-base" folder="GTM" managed canWrite />
112
+ </MemoryRouter>,
113
+ );
114
+ fireEvent.click(screen.getByRole('button', { name: /^Manifest plugin\.json$/ }));
115
+ fireEvent.click(await screen.findByRole('button', { name: 'Edit the manifest' }));
116
+ expect(navigateMock).toHaveBeenLastCalledWith(
117
+ expect.stringContaining('Plugins/GTM/plugin.json'),
118
+ { state: { rawFile: true } },
119
+ );
120
+ });
121
+
122
+ it('shows the file as written when it is not JSON, and says so when it cannot be read', async () => {
123
+ apiMock.readFile.mockResolvedValue('not json {');
124
+ const { unmount } = render(
125
+ <MemoryRouter>
126
+ <ManifestSection kbDirName="knowledge-base" folder="GTM" managed canWrite={false} />
127
+ </MemoryRouter>,
128
+ );
129
+ fireEvent.click(screen.getByRole('button', { name: /^Manifest plugin\.json$/ }));
130
+ await waitFor(() => expect(screen.getByText('not json {')).toBeInTheDocument());
131
+ unmount();
132
+
133
+ apiMock.readFile.mockRejectedValue(new Error('403'));
134
+ render(
135
+ <MemoryRouter>
136
+ <ManifestSection kbDirName="knowledge-base" folder="GTM" managed canWrite={false} />
137
+ </MemoryRouter>,
138
+ );
139
+ fireEvent.click(screen.getByRole('button', { name: /^Manifest plugin\.json$/ }));
140
+ await waitFor(() => expect(screen.getByText("Couldn't read plugin.json.")).toBeInTheDocument());
141
+ });
142
+ });
143
+
64
144
  describe('ClientExtensionsSection', () => {
65
145
  it('reuses the context tree when the workspace sits on the default branch — no fetch', async () => {
66
146
  renderSection({ workspaceId: encodeURIComponent(DEFAULT_BRANCH), fileTree: TREE });
@@ -79,16 +159,42 @@ describe('ClientExtensionsSection', () => {
79
159
  });
80
160
 
81
161
  /**
82
- * The fileTree can carry workspace/KB-clone wrapper levels above the kb dir
83
- * (`findKbRoot` exists for exactly this shape). The section must find the
84
- * plugin's namespace dirs through them, not assume the root's direct child
85
- * is the kb dir.
162
+ * A `Plugins/` that is not the checkout's is not this deployment's. The
163
+ * section used to reach the kb dir by descending the tree until the names
164
+ * looked right, which found one under a wrapper level — and, on staging,
165
+ * found a stray beside the checkout instead of the checkout itself.
86
166
  */
87
- it('finds the namespace dirs through wrapper levels above the kb dir', async () => {
167
+ it('reads no Plugins outside the checkout, wrapped or strewn beside it', async () => {
88
168
  const wrapped = dir('root', [dir('workspace-clone', TREE.children ?? [])]);
89
- renderSection({ workspaceId: encodeURIComponent(DEFAULT_BRANCH), fileTree: wrapped });
169
+ const { unmount } = renderSection({
170
+ workspaceId: encodeURIComponent(DEFAULT_BRANCH),
171
+ fileTree: wrapped,
172
+ });
173
+ await waitFor(() => expect(screen.queryByText('com.example.client/')).not.toBeInTheDocument());
174
+ unmount();
175
+
176
+ const strewn = dir('root', [
177
+ dir('Plugins', [dir('GTM', [dir('com.example.stray', [dir('hooks', [file('planted.js')])])])]),
178
+ ...(TREE.children ?? []),
179
+ ]);
180
+ renderSection({ workspaceId: encodeURIComponent(DEFAULT_BRANCH), fileTree: strewn });
90
181
  expect(await screen.findByText('com.example.client/')).toBeInTheDocument();
91
- expect(screen.getByRole('button', { name: 'hooks/on-save.js' })).toBeInTheDocument();
182
+ expect(screen.queryByText('com.example.stray/')).not.toBeInTheDocument();
183
+ });
184
+
185
+ it('finds the namespace dirs of a plugin nested below the root — the folder is a path, walked a segment at a time', async () => {
186
+ const nested: FileTreeEntry = dir('root', [
187
+ dir('knowledge-base', [
188
+ dir('Plugins', [dir('teams', [dir('deep', [dir('com.example.client', [dir('hooks', [file('on-open.js')])])])])]),
189
+ ]),
190
+ ]);
191
+ renderSection({ workspaceId: encodeURIComponent(DEFAULT_BRANCH), fileTree: nested }, 'teams/deep');
192
+ expect(await screen.findByText('com.example.client/')).toBeInTheDocument();
193
+ fireEvent.click(screen.getByRole('button', { name: 'hooks/on-open.js' }));
194
+ expect(navigateMock).toHaveBeenCalledWith(
195
+ expect.stringContaining('/knowledge-base/Plugins/teams/deep/com.example.client/hooks/on-open.js'),
196
+ expect.anything(),
197
+ );
92
198
  });
93
199
 
94
200
  /**
@@ -1,5 +1,5 @@
1
1
  import { describe, it, expect, beforeEach, vi } from 'vitest';
2
- import { render, screen, fireEvent, waitFor } from '@testing-library/react';
2
+ import { render, screen, fireEvent, waitFor, within } from '@testing-library/react';
3
3
  import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
4
4
  import type { JoinRequest } from '../services/plugins.api';
5
5
 
@@ -175,4 +175,63 @@ describe('PluginJoinRequests', () => {
175
175
  await waitFor(() => expect(pluginsMock.listJoinRequests).toHaveBeenCalled());
176
176
  expect(container.querySelector('[role="alert"]')).toBeNull();
177
177
  });
178
+
179
+ /**
180
+ * The answers sit where the question is. Accept and Decline used to sit on
181
+ * separate lines, and Manage access was a button on a line of its own.
182
+ */
183
+ describe('layout', () => {
184
+ /** The line (flex row) a control sits on. */
185
+ const lineOf = (el: HTMLElement) => el.closest('div.flex-wrap') as HTMLElement;
186
+
187
+ it('puts Accept then Decline at the end of the line naming the requester', async () => {
188
+ renderBanner();
189
+ const text = await screen.findByText(/Ali Baba asked for access to GTM/);
190
+ const accept = screen.getByRole('button', { name: 'Grant read to Ali Baba' });
191
+ const decline = screen.getByRole('button', { name: 'Decline the request from Ali Baba' });
192
+ expect(lineOf(accept)).toBe(lineOf(text));
193
+ expect(lineOf(decline)).toBe(lineOf(text));
194
+ expect(accept.compareDocumentPosition(decline) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
195
+ expect(text).toHaveTextContent('Ali Baba asked for access to GTM: read');
196
+ });
197
+
198
+ it('with several proposals, each proposal line ends in its own Accept and the request line in Decline', async () => {
199
+ pluginsMock.listJoinRequests.mockResolvedValue([
200
+ request({
201
+ proposals: [
202
+ ...request().proposals,
203
+ {
204
+ verb: 'write',
205
+ id: 'user:juan@bevel.software',
206
+ principal: { kind: 'user', email: 'juan@bevel.software', displayName: 'Juan Viera' },
207
+ label: 'Juan Viera',
208
+ },
209
+ ],
210
+ }),
211
+ ]);
212
+ renderBanner();
213
+ const requestLine = lineOf(await screen.findByText('Ali Baba asked for access to GTM.'));
214
+ expect(within(requestLine).getAllByRole('button').map((b) => b.getAttribute('aria-label'))).toEqual([
215
+ 'Decline the request from Ali Baba',
216
+ ]);
217
+ const ali = screen.getByRole('button', { name: 'Grant read to Ali Baba' });
218
+ const juan = screen.getByRole('button', { name: 'Grant write to Juan Viera' });
219
+ expect(lineOf(ali)).not.toBe(requestLine);
220
+ expect(lineOf(juan)).not.toBe(lineOf(ali));
221
+ expect(lineOf(juan)).toHaveTextContent('Juan Viera: write');
222
+ });
223
+
224
+ it('Manage access is a text link closing the last line, and opens the plugin folder', async () => {
225
+ const { onManage } = renderBanner();
226
+ const accept = await screen.findByRole('button', { name: 'Grant read to Ali Baba' });
227
+ const manage = screen.getByRole('button', { name: 'Manage access' });
228
+ // Not a line of its own: it shares the requester's line, after the answers.
229
+ expect(lineOf(manage)).toBe(lineOf(accept));
230
+ const decline = screen.getByRole('button', { name: 'Decline the request from Ali Baba' });
231
+ expect(decline.compareDocumentPosition(manage) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
232
+ expect(manage.className).toContain('underline');
233
+ fireEvent.click(manage);
234
+ expect(onManage).toHaveBeenCalledWith('Plugins/GTM');
235
+ });
236
+ });
178
237
  });