@atelierai/uco 1.0.7 → 1.0.8

package/vendor/plugin/com.atelierai.unity.copilot/Editor/Scripts/Startup.Editor.cs

@@ -1,201 +1,201 @@
-/*
-┌──────────────────────────────────────────────────────────────────┐
-│  Author: Ivan Murzak (https://github.com/IvanMurzak)             │
-│  Repository: GitHub (https://github.com/IvanMurzak/Unity-MCP)    │
-│  Copyright (c) 2025 Ivan Murzak                                  │
-│  Licensed under the Apache License, Version 2.0.                 │
-│  See the LICENSE file in the project root for more information.  │
-└──────────────────────────────────────────────────────────────────┘
-*/
-
-#nullable enable
-using com.AtelierAI.Unity.Copilot.Runtime.Utils;
-using com.AtelierAI.Unity.Copilot.Editor.Utils;
-using com.AtelierAI.Uco.Framework;
-using Microsoft.Extensions.Logging;
-using UnityEditor;
-using UnityEngine;
-
-namespace com.AtelierAI.Unity.Copilot.Editor
-{
-    public static partial class Startup
-    {
-        static void SubscribeOnEditorEvents()
-        {
-            Application.unloading += OnApplicationUnloading;
-            Application.quitting += OnApplicationQuitting;
-
-            AssemblyReloadEvents.beforeAssemblyReload += OnBeforeAssemblyReload;
-            AssemblyReloadEvents.afterAssemblyReload += OnAfterAssemblyReload;
-
-            // Handle Play mode state changes to ensure reconnection after exiting Play mode
-            EditorApplication.playModeStateChanged += OnPlayModeStateChanged;
-        }
-        static void OnApplicationUnloading() => TryDisconnectAndCleanup(nameof(OnApplicationUnloading));
-        static void OnApplicationQuitting() => TryDisconnectAndCleanup(nameof(OnApplicationQuitting));
-        static void OnBeforeAssemblyReload()
-        {
-            EditorToolExecutionScheduler.Shared.InvalidateInstance();
-            EditorOperationOwnerRegistry.InvalidateGeneration();
-            UnityAuthoringSafetyReloadGuard.InvalidateConfirmationPlans();
-            TryDisconnectAndCleanup(nameof(OnBeforeAssemblyReload));
-        }
-
-        /// <summary>
-        /// Safely disconnects and cleans up the MCP plugin instance.
-        /// Catches exceptions to prevent blocking Unity's shutdown/reload process.
-        /// </summary>
-        /// <param name="callerName">Name of the calling method for logging.</param>
-        /// <param name="onlyIfConnected">If true, only disconnects when in Connected state.
-        /// This prevents issues when cancelling in-progress connection attempts during assembly reload.
-        /// Note: Log collector disposal always occurs regardless of this flag.</param>
-        static void TryDisconnectAndCleanup(string callerName, bool onlyIfConnected = false)
-        {
-            if (!UnityCopilotPluginEditor.HasInstance)
-            {
-                _logger.LogDebug("{class} {method} triggered: No UnityCopilotPluginEditor instance to disconnect",
-                    nameof(Startup), callerName);
-                return;
-            }
-
-            _logger.LogInformation("{method} triggered", callerName);
-
-            var plugin = UnityCopilotPluginEditor.Instance;
-            if (plugin.HasMcpPluginInstance)
-            {
-                var connectionState = UnityCopilotPluginEditor.ConnectionState.CurrentValue;
-
-                // When onlyIfConnected is true, skip disconnect unless we have an established connection.
-                // This prevents hanging when cancelling in-progress connection attempts (Connecting/Reconnecting states).
-                if (onlyIfConnected && connectionState != ConnectionState.Connected)
-                {
-                    _logger.LogTrace("Skipping {method} - not connected (state: {state})",
-                        nameof(plugin.DisconnectImmediate), connectionState);
-                }
-                else
-                {
-                    try
-                    {
-                        plugin.DisconnectImmediate();
-                    }
-                    catch (System.Exception e)
-                    {
-                        _logger.LogWarning(e, "{class} {method}: Exception during disconnect (non-blocking): {message}",
-                            nameof(Startup), callerName, e.Message);
-                    }
-                }
-            }
-
-            try
-            {
-                plugin.DisposeLogCollector();
-            }
-            catch (System.Exception e)
-            {
-                _logger.LogWarning(e, "{class} {method}: Exception during log collector disposal (non-blocking): {message}",
-                    nameof(Startup), callerName, e.Message);
-            }
-
-            if (UnityCopilotPluginRuntime.HasInstance)
-            {
-                try
-                {
-                    UnityCopilotPluginRuntime.DisposeInstance();
-                }
-                catch (System.Exception e)
-                {
-                    _logger.LogWarning(e, "{class} {method}: Exception during runtime plugin disposal (non-blocking): {message}",
-                        nameof(Startup), callerName, e.Message);
-                }
-            }
-        }
-        static void OnAfterAssemblyReload()
-        {
-            var isCi = EnvironmentUtils.IsCi();
-            var isBatchMode = EnvironmentUtils.IsBatchMode();
-            var keepConnected = UnityCopilotPluginEditor.KeepConnected;
-            // COCli-13: batchmode launches (offline builds, command-line
-            // automation) skip the connection retry loop unless the
-            // configuration explicitly keeps the server running — connection
-            // warnings would otherwise pollute BuildReport output.
-            var connectionAllowed = keepConnected || (!isCi && !isBatchMode);
-
-            _logger.LogInformation("{method} triggered - BuildAndStart with connectionAllowed: {connectionAllowed} (isCi: {isCi}, isBatchMode: {isBatchMode}, keepConnected: {keepConnected})",
-                nameof(OnAfterAssemblyReload), connectionAllowed, isCi, isBatchMode, keepConnected);
-
-            UnityCopilotPluginEditor.Instance.BuildMcpPluginIfNeeded();
-            UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
-
-            if (connectionAllowed)
-                UnityCopilotPluginEditor.ConnectIfNeeded();
-        }
-
-        static void OnPlayModeStateChanged(PlayModeStateChange state)
-        {
-            if (!UnityCopilotPluginEditor.HasInstance)
-            {
-                _logger.LogDebug("{class} {method} triggered: No UnityCopilotPluginEditor instance available. State: {state}",
-                    nameof(Startup), nameof(OnPlayModeStateChanged), state);
-                return;
-            }
-
-            // Log Play mode state changes for debugging
-            _logger.LogInformation("Play mode state changed: {state}", state);
-
-            switch (state)
-            {
-                case PlayModeStateChange.ExitingPlayMode:
-                    // Dispose the runtime plugin instance created by Initialize().Build().
-                    // This handles the no-domain-reload case; TryDisconnectAndCleanup covers the domain-reload case.
-                    _logger.LogTrace("Exiting Play mode - disposing runtime plugin instance if present");
-                    if (UnityCopilotPluginRuntime.HasInstance)
-                        UnityCopilotPluginRuntime.DisposeInstance();
-                    break;
-
-                case PlayModeStateChange.EnteredEditMode:
-                    // Unity has returned to Edit mode - ensure connection is re-established
-                    // if the configuration expects it to be connected
-                    var isCi = EnvironmentUtils.IsCi();
-                    var isBatchMode = EnvironmentUtils.IsBatchMode();
-                    var keepConnected = UnityCopilotPluginEditor.KeepConnected;
-                    _logger.LogTrace("Entered Edit mode - KeepConnected: {keepConnected}, IsCi: {isCi}, IsBatchMode: {isBatchMode}",
-                        keepConnected, isCi, isBatchMode);
-
-                    if ((isCi || isBatchMode) && !keepConnected)
-                    {
-                        _logger.LogTrace("Skipping reconnection in CI/batchmode environment (KeepConnected is false)");
-                        break;
-                    }
-
-                    _logger.LogTrace("Scheduling reconnection after Play mode exit");
-
-                    // Small delay to ensure Unity is fully settled in Edit mode
-                    EditorApplication.delayCall += () =>
-                    {
-                        _logger.LogTrace("Initiating delayed reconnection after Play mode exit");
-
-                        UnityCopilotPluginEditor.Instance.BuildMcpPluginIfNeeded();
-                        UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
-                        UnityCopilotPluginEditor.ConnectIfNeeded();
-                    };
-
-                    // No delay, immediate reconnection for the case if Unity Editor in background
-                    // (has no focus)
-                    _logger.LogTrace("Initiating reconnection after Play mode exit");
-
-                    UnityCopilotPluginEditor.Instance.BuildMcpPluginIfNeeded();
-                    UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
-                    UnityCopilotPluginEditor.ConnectIfNeeded();
-                    break;
-
-                case PlayModeStateChange.ExitingEditMode:
-                    _logger.LogTrace("Exiting Edit mode to enter Play mode");
-                    break;
-
-                case PlayModeStateChange.EnteredPlayMode:
-                    _logger.LogTrace("Entered Play mode");
-                    break;
-            }
-        }
-    }
-}
+/*
+┌──────────────────────────────────────────────────────────────────┐
+│  Author: Ivan Murzak (https://github.com/IvanMurzak)             │
+│  Repository: GitHub (https://github.com/IvanMurzak/Unity-MCP)    │
+│  Copyright (c) 2025 Ivan Murzak                                  │
+│  Licensed under the Apache License, Version 2.0.                 │
+│  See the LICENSE file in the project root for more information.  │
+└──────────────────────────────────────────────────────────────────┘
+*/
+
+#nullable enable
+using com.AtelierAI.Unity.Copilot.Runtime.Utils;
+using com.AtelierAI.Unity.Copilot.Editor.Utils;
+using com.AtelierAI.Uco.Framework;
+using Microsoft.Extensions.Logging;
+using UnityEditor;
+using UnityEngine;
+
+namespace com.AtelierAI.Unity.Copilot.Editor
+{
+    public static partial class Startup
+    {
+        static void SubscribeOnEditorEvents()
+        {
+            Application.unloading += OnApplicationUnloading;
+            Application.quitting += OnApplicationQuitting;
+
+            AssemblyReloadEvents.beforeAssemblyReload += OnBeforeAssemblyReload;
+            AssemblyReloadEvents.afterAssemblyReload += OnAfterAssemblyReload;
+
+            // Handle Play mode state changes to ensure reconnection after exiting Play mode
+            EditorApplication.playModeStateChanged += OnPlayModeStateChanged;
+        }
+        static void OnApplicationUnloading() => TryDisconnectAndCleanup(nameof(OnApplicationUnloading));
+        static void OnApplicationQuitting() => TryDisconnectAndCleanup(nameof(OnApplicationQuitting));
+        static void OnBeforeAssemblyReload()
+        {
+            EditorToolExecutionScheduler.Shared.InvalidateInstance();
+            EditorOperationOwnerRegistry.InvalidateGeneration();
+            UnityAuthoringSafetyReloadGuard.InvalidateConfirmationPlans();
+            TryDisconnectAndCleanup(nameof(OnBeforeAssemblyReload));
+        }
+
+        /// <summary>
+        /// Safely disconnects and cleans up the Uco plugin instance.
+        /// Catches exceptions to prevent blocking Unity's shutdown/reload process.
+        /// </summary>
+        /// <param name="callerName">Name of the calling method for logging.</param>
+        /// <param name="onlyIfConnected">If true, only disconnects when in Connected state.
+        /// This prevents issues when cancelling in-progress connection attempts during assembly reload.
+        /// Note: Log collector disposal always occurs regardless of this flag.</param>
+        static void TryDisconnectAndCleanup(string callerName, bool onlyIfConnected = false)
+        {
+            if (!UnityCopilotPluginEditor.HasInstance)
+            {
+                _logger.LogDebug("{class} {method} triggered: No UnityCopilotPluginEditor instance to disconnect",
+                    nameof(Startup), callerName);
+                return;
+            }
+
+            _logger.LogInformation("{method} triggered", callerName);
+
+            var plugin = UnityCopilotPluginEditor.Instance;
+            if (plugin.HasUcoPluginInstance)
+            {
+                var connectionState = UnityCopilotPluginEditor.ConnectionState.CurrentValue;
+
+                // When onlyIfConnected is true, skip disconnect unless we have an established connection.
+                // This prevents hanging when cancelling in-progress connection attempts (Connecting/Reconnecting states).
+                if (onlyIfConnected && connectionState != ConnectionState.Connected)
+                {
+                    _logger.LogTrace("Skipping {method} - not connected (state: {state})",
+                        nameof(plugin.DisconnectImmediate), connectionState);
+                }
+                else
+                {
+                    try
+                    {
+                        plugin.DisconnectImmediate();
+                    }
+                    catch (System.Exception e)
+                    {
+                        _logger.LogWarning(e, "{class} {method}: Exception during disconnect (non-blocking): {message}",
+                            nameof(Startup), callerName, e.Message);
+                    }
+                }
+            }
+
+            try
+            {
+                plugin.DisposeLogCollector();
+            }
+            catch (System.Exception e)
+            {
+                _logger.LogWarning(e, "{class} {method}: Exception during log collector disposal (non-blocking): {message}",
+                    nameof(Startup), callerName, e.Message);
+            }
+
+            if (UnityCopilotPluginRuntime.HasInstance)
+            {
+                try
+                {
+                    UnityCopilotPluginRuntime.DisposeInstance();
+                }
+                catch (System.Exception e)
+                {
+                    _logger.LogWarning(e, "{class} {method}: Exception during runtime plugin disposal (non-blocking): {message}",
+                        nameof(Startup), callerName, e.Message);
+                }
+            }
+        }
+        static void OnAfterAssemblyReload()
+        {
+            var isCi = EnvironmentUtils.IsCi();
+            var isBatchMode = EnvironmentUtils.IsBatchMode();
+            var keepConnected = UnityCopilotPluginEditor.KeepConnected;
+            // COCli-13: batchmode launches (offline builds, command-line
+            // automation) skip the connection retry loop unless the
+            // configuration explicitly keeps the server running — connection
+            // warnings would otherwise pollute BuildReport output.
+            var connectionAllowed = keepConnected || (!isCi && !isBatchMode);
+
+            _logger.LogInformation("{method} triggered - BuildAndStart with connectionAllowed: {connectionAllowed} (isCi: {isCi}, isBatchMode: {isBatchMode}, keepConnected: {keepConnected})",
+                nameof(OnAfterAssemblyReload), connectionAllowed, isCi, isBatchMode, keepConnected);
+
+            UnityCopilotPluginEditor.Instance.BuildUcoPluginIfNeeded();
+            UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
+
+            if (connectionAllowed)
+                UnityCopilotPluginEditor.ConnectIfNeeded();
+        }
+
+        static void OnPlayModeStateChanged(PlayModeStateChange state)
+        {
+            if (!UnityCopilotPluginEditor.HasInstance)
+            {
+                _logger.LogDebug("{class} {method} triggered: No UnityCopilotPluginEditor instance available. State: {state}",
+                    nameof(Startup), nameof(OnPlayModeStateChanged), state);
+                return;
+            }
+
+            // Log Play mode state changes for debugging
+            _logger.LogInformation("Play mode state changed: {state}", state);
+
+            switch (state)
+            {
+                case PlayModeStateChange.ExitingPlayMode:
+                    // Dispose the runtime plugin instance created by Initialize().Build().
+                    // This handles the no-domain-reload case; TryDisconnectAndCleanup covers the domain-reload case.
+                    _logger.LogTrace("Exiting Play mode - disposing runtime plugin instance if present");
+                    if (UnityCopilotPluginRuntime.HasInstance)
+                        UnityCopilotPluginRuntime.DisposeInstance();
+                    break;
+
+                case PlayModeStateChange.EnteredEditMode:
+                    // Unity has returned to Edit mode - ensure connection is re-established
+                    // if the configuration expects it to be connected
+                    var isCi = EnvironmentUtils.IsCi();
+                    var isBatchMode = EnvironmentUtils.IsBatchMode();
+                    var keepConnected = UnityCopilotPluginEditor.KeepConnected;
+                    _logger.LogTrace("Entered Edit mode - KeepConnected: {keepConnected}, IsCi: {isCi}, IsBatchMode: {isBatchMode}",
+                        keepConnected, isCi, isBatchMode);
+
+                    if ((isCi || isBatchMode) && !keepConnected)
+                    {
+                        _logger.LogTrace("Skipping reconnection in CI/batchmode environment (KeepConnected is false)");
+                        break;
+                    }
+
+                    _logger.LogTrace("Scheduling reconnection after Play mode exit");
+
+                    // Small delay to ensure Unity is fully settled in Edit mode
+                    EditorApplication.delayCall += () =>
+                    {
+                        _logger.LogTrace("Initiating delayed reconnection after Play mode exit");
+
+                        UnityCopilotPluginEditor.Instance.BuildUcoPluginIfNeeded();
+                        UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
+                        UnityCopilotPluginEditor.ConnectIfNeeded();
+                    };
+
+                    // No delay, immediate reconnection for the case if Unity Editor in background
+                    // (has no focus)
+                    _logger.LogTrace("Initiating reconnection after Play mode exit");
+
+                    UnityCopilotPluginEditor.Instance.BuildUcoPluginIfNeeded();
+                    UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
+                    UnityCopilotPluginEditor.ConnectIfNeeded();
+                    break;
+
+                case PlayModeStateChange.ExitingEditMode:
+                    _logger.LogTrace("Exiting Edit mode to enter Play mode");
+                    break;
+
+                case PlayModeStateChange.EnteredPlayMode:
+                    _logger.LogTrace("Entered Play mode");
+                    break;
+            }
+        }
+    }
+}

package/vendor/plugin/com.atelierai.unity.copilot/Editor/Scripts/Startup.cs

@@ -1,67 +1,67 @@
-/*
-┌──────────────────────────────────────────────────────────────────┐
-│  Author: Ivan Murzak (https://github.com/IvanMurzak)             │
-│  Repository: GitHub (https://github.com/IvanMurzak/Unity-MCP)    │
-│  Copyright (c) 2025 Ivan Murzak                                  │
-│  Licensed under the Apache License, Version 2.0.                 │
-│  See the LICENSE file in the project root for more information.  │
-└──────────────────────────────────────────────────────────────────┘
-*/
-
-#nullable enable
-using com.AtelierAI.Unity.Copilot.Editor.UI;
-using com.AtelierAI.Unity.Copilot.Editor.Utils;
-using com.AtelierAI.Unity.Copilot.Utils;
-using Microsoft.Extensions.Logging;
-using UnityEditor;
-using UnityEngine;
-using ILogger = Microsoft.Extensions.Logging.ILogger;
-
-namespace com.AtelierAI.Unity.Copilot.Editor
-{
-    [InitializeOnLoad]
-    public static partial class Startup
-    {
-        static readonly ILogger _logger = UnityLoggerFactory.LoggerFactory.CreateLogger(nameof(Startup));
-
-        static Startup()
-        {
-            if (!UnityProcessGuard.ShouldInitialize(AssetDatabase.IsAssetImportWorkerProcess()))
-            {
-                return;
-            }
-
-            EditorOperationOwners.RegisterAndReconcile();
-            UnityCopilotPluginEditor.Instance.BuildMcpPluginIfNeeded();
-            UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
-
-            // Informational notice — historically the plugin treated a space in the project
-            // path as a hard error, but in practice the modern startup pipeline (structured
-            // ProcessStartInfo, JSON/TOML client configs with quoted command strings,
-            // Path.Combine-based file IO) handles spaces correctly. We keep a one-shot
-            // warning so users have a breadcrumb if they hit a third-party tool that does
-            // not tolerate spaces in paths.
-            if (Application.dataPath.Contains(" "))
-                Debug.LogWarning("Unity Copilot: project path contains spaces. The plugin will start normally; if any specific workflow misbehaves with this path, please report it so we can fix the underlying issue.");
-
-            SubscribeOnEditorEvents();
-
-            // Initialize sub-systems
-            API.Tool_Tests.Init();
-            UpdateChecker.Init();
-            PackageUtils.Init();
-        }
-    }
-
-    /// <summary>
-    /// Asset Import Workers inherit the main Editor's environment variables but
-    /// must never create their own MCP plugin/server lifecycle. A worker bridge
-    /// advertises the same project instance ID, cannot complete normal Editor
-    /// registration, and can otherwise displace the main Editor connection.
-    /// </summary>
-    internal static class UnityProcessGuard
-    {
-        internal static bool ShouldInitialize(bool isAssetImportWorkerProcess)
-            => !isAssetImportWorkerProcess;
-    }
-}
+/*
+┌──────────────────────────────────────────────────────────────────┐
+│  Author: Ivan Murzak (https://github.com/IvanMurzak)             │
+│  Repository: GitHub (https://github.com/IvanMurzak/Unity-MCP)    │
+│  Copyright (c) 2025 Ivan Murzak                                  │
+│  Licensed under the Apache License, Version 2.0.                 │
+│  See the LICENSE file in the project root for more information.  │
+└──────────────────────────────────────────────────────────────────┘
+*/
+
+#nullable enable
+using com.AtelierAI.Unity.Copilot.Editor.UI;
+using com.AtelierAI.Unity.Copilot.Editor.Utils;
+using com.AtelierAI.Unity.Copilot.Utils;
+using Microsoft.Extensions.Logging;
+using UnityEditor;
+using UnityEngine;
+using ILogger = Microsoft.Extensions.Logging.ILogger;
+
+namespace com.AtelierAI.Unity.Copilot.Editor
+{
+    [InitializeOnLoad]
+    public static partial class Startup
+    {
+        static readonly ILogger _logger = UnityLoggerFactory.LoggerFactory.CreateLogger(nameof(Startup));
+
+        static Startup()
+        {
+            if (!UnityProcessGuard.ShouldInitialize(AssetDatabase.IsAssetImportWorkerProcess()))
+            {
+                return;
+            }
+
+            EditorOperationOwners.RegisterAndReconcile();
+            UnityCopilotPluginEditor.Instance.BuildUcoPluginIfNeeded();
+            UnityCopilotPluginEditor.Instance.AddUnityLogCollectorIfNeeded(() => new BufferedFileLogStorage());
+
+            // Informational notice — historically the plugin treated a space in the project
+            // path as a hard error, but in practice the modern startup pipeline (structured
+            // ProcessStartInfo, JSON/TOML client configs with quoted command strings,
+            // Path.Combine-based file IO) handles spaces correctly. We keep a one-shot
+            // warning so users have a breadcrumb if they hit a third-party tool that does
+            // not tolerate spaces in paths.
+            if (Application.dataPath.Contains(" "))
+                Debug.LogWarning("Unity Copilot: project path contains spaces. The plugin will start normally; if any specific workflow misbehaves with this path, please report it so we can fix the underlying issue.");
+
+            SubscribeOnEditorEvents();
+
+            // Initialize sub-systems
+            API.Tool_Tests.Init();
+            UpdateChecker.Init();
+            PackageUtils.Init();
+        }
+    }
+
+    /// <summary>
+    /// Asset Import Workers inherit the main Editor's environment variables but
+    /// must never create their own Uco plugin/server lifecycle. A worker bridge
+    /// advertises the same project instance ID, cannot complete normal Editor
+    /// registration, and can otherwise displace the main Editor connection.
+    /// </summary>
+    internal static class UnityProcessGuard
+    {
+        internal static bool ShouldInitialize(bool isAssetImportWorkerProcess)
+            => !isAssetImportWorkerProcess;
+    }
+}