openstudio-standards 0.2.12.rc4 → 0.2.13.rc3

data/lib/openstudio-standards/prototypes/common/objects/Prototype.radiant_system_controls.rb

@@ -25,8 +25,14 @@ class Standard
 
     zone_name = zone.name.to_s.gsub(/[ +-.]/, '_')
     zone_timestep = model.getTimestep.numberOfTimestepsPerHour
-    coil_cooling_radiant = radiant_loop.coolingCoil.to_CoilCoolingLowTempRadiantVarFlow.get
-    coil_heating_radiant = radiant_loop.heatingCoil.to_CoilHeatingLowTempRadiantVarFlow.get
+
+    if model.version < OpenStudio::VersionString.new('3.1.1')
+      coil_cooling_radiant = radiant_loop.coolingCoil.to_CoilCoolingLowTempRadiantVarFlow.get
+      coil_heating_radiant = radiant_loop.heatingCoil.to_CoilHeatingLowTempRadiantVarFlow.get
+    else
+      coil_cooling_radiant = radiant_loop.coolingCoil.get.to_CoilCoolingLowTempRadiantVarFlow.get
+      coil_heating_radiant = radiant_loop.heatingCoil.get.to_CoilHeatingLowTempRadiantVarFlow.get
+    end
 
     #####
     # List of schedule objects used to hold calculation results
@@ -311,7 +317,7 @@ class Standard
       OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', "Zone #{zone.name} does not have floor surfaces; cannot add radiant system.")
       return false
     end
-    zone_floor = surfaces.sort_by { |s| s.grossArea }[-1]
+    zone_floor = surfaces.max_by(&:grossArea)
     zone_srf_temp = OpenStudio::Model::EnergyManagementSystemSensor.new(model, 'Surface Inside Face Temperature')
     zone_srf_temp.setName("#{zone_name}_Srf_Temp")
     zone_srf_temp.setKeyName(zone_floor.name.get)

data/lib/openstudio-standards/prototypes/common/objects/Prototype.refrigeration.rb

@@ -122,13 +122,13 @@ class Standard
     if props['restocking_schedule']
       if props['restocking_schedule'].downcase == 'always off'
         # restocking_sch = model.alwaysOffDiscreteSchedule
-        ref_case.resetRefrigeratedCaseRestockingSchedule()
+        ref_case.resetRefrigeratedCaseRestockingSchedule
       else
         restocking_sch = model_add_schedule(model, props['restocking_schedule'])
         ref_case.setRefrigeratedCaseRestockingSchedule(restocking_sch)
       end
     else
-      ref_case.resetRefrigeratedCaseRestockingSchedule()
+      ref_case.resetRefrigeratedCaseRestockingSchedule
     end
 
     if props['case_category']
@@ -315,20 +315,20 @@ class Standard
     if props['restocking_schedule']
       if props['restocking_schedule'].downcase == 'always off'
         # restocking_sch = model.alwaysOffDiscreteSchedule
-        ref_walkin.resetRestockingSchedule()
+        ref_walkin.resetRestockingSchedule
       else
         restocking_sch = model_add_schedule(model, props['restocking_schedule'])
         ref_walkin.setRestockingSchedule(restocking_sch)
       end
     else
-      ref_walkin.resetRestockingSchedule()
+      ref_walkin.resetRestockingSchedule
     end
 
     ref_walkin.setLightingSchedule(model_add_schedule(model, lightingschedule))
     ref_walkin.setZoneBoundaryStockingDoorOpeningScheduleFacingZone(model_add_schedule(model, 'door_wi_sched'))
 
     ref_walkin_addprops = ref_walkin.additionalProperties
-    ref_walkin_addprops.setFeature("motor_category", props['motor_category'] )
+    ref_walkin_addprops.setFeature('motor_category', props['motor_category'])
 
     # Add doorway protection
     if props['doorway_protection_type']
@@ -382,9 +382,11 @@ class Standard
     model.getThermalZones.each do |zone|
       space_type = thermal_zone_majority_space_type(zone)
       next if space_type.empty?
+
       space_type = space_type.get
       next if space_type.standardsSpaceType.empty?
       next if space_type.standardsBuildingType.empty?
+
       stds_spc_type = space_type.standardsSpaceType.get
       stds_bldg_type = space_type.standardsBuildingType.get
       case "#{stds_bldg_type} #{stds_spc_type}"
@@ -446,9 +448,11 @@ class Standard
     model.getThermalZones.each do |zone|
       space_type = thermal_zone_majority_space_type(zone)
       next if space_type.empty?
+
       space_type = space_type.get
       next if space_type.standardsSpaceType.empty?
       next if space_type.standardsBuildingType.empty?
+
       stds_spc_type = space_type.standardsSpaceType.get
       stds_bldg_type = space_type.standardsBuildingType.get
       case "#{stds_bldg_type} #{stds_spc_type}"
@@ -866,6 +870,7 @@ class Standard
       zone = model_get_zones_from_spaces_on_system(model, case_)[0]
       ref_case = model_add_refrigeration_case(model, zone, case_['case_type'], size_category)
       return false if ref_case.nil?
+
       ########################################
       # Defrost schedule
       defrost_sch = OpenStudio::Model::ScheduleRuleset.new(model)
@@ -903,6 +908,7 @@ class Standard
         zone = model_get_zones_from_spaces_on_system(model, walkin)[0]
         ref_walkin = model_add_refrigeration_walkin(model, zone, size_category, walkin['walkin_type'])
         return false if ref_walkin.nil?
+
         ########################################
         # Defrost schedule
         defrost_sch = OpenStudio::Model::ScheduleRuleset.new(model)

data/lib/openstudio-standards/prototypes/common/objects/Prototype.utilities.rb

@@ -225,6 +225,18 @@ class Standard
     return cop
   end
 
+  # Convert from COP to SEER
+  # @ref [References::USDOEPrototypeBuildings]
+  #
+  # @param cop [Double] COP
+  # @return [Double] Seasonal Energy Efficiency Ratio
+  def cop_to_seer_cooling_no_fan(cop)
+    delta = 0.3796**2 - 4.0 * 0.0076 * cop
+    seer = (-delta**0.5 + 0.3796) / (2.0 * 0.0076)
+
+    return seer
+  end
+
   # Convert from SEER to COP (with fan) for cooling coils
   # per the method specified in 90.1-2013 Appendix G
   #
@@ -237,6 +249,19 @@ class Standard
     return cop
   end
 
+  # Convert from COP to SEER (with fan) for cooling coils
+  # per the method specified in 90.1-2013 Appendix G
+  #
+  # @param seer [Double] seasonal energy efficiency ratio (SEER)
+  # @return [Double] Coefficient of Performance (COP)
+  def cop_to_seer_cooling_with_fan(cop)
+    eer = cop_to_eer(cop)
+    delta = 1.1088**2 - 4.0 * 0.0182 * eer
+    seer = (1.1088 - delta**0.5) / (2.0 * 0.0182)
+
+    return seer
+  end
+
   # Convert from COP_H to COP (no fan) for heat pump heating coils
   # @ref [References::ASHRAE9012013] Appendix G
   #
@@ -274,18 +299,6 @@ class Standard
     return cop
   end
 
-  # Convert from COP to SEER
-  # @ref [References::USDOEPrototypeBuildings]
-  #
-  # @param cop [Double] COP
-  # @return [Double] Seasonal Energy Efficiency Ratio
-  def cop_to_seer(cop)
-    delta = 0.3796**2 - 4.0 * 0.0076 * cop
-    seer = (-delta**0.5 + 0.3796) / (2.0 * 0.0076)
-
-    return seer
-  end
-
   # Convert from EER to COP
   # @ref [References::USDOEPrototypeBuildings] If capacity is not supplied, use DOE Prototype Building method.
   # @ref [References::ASHRAE9012013] If capacity is supplied, use the 90.1-2013 method
@@ -904,7 +917,6 @@ class Standard
   end
 
   def true?(obj)
-    obj.to_s.downcase == "true"
+    obj.to_s.downcase == 'true'
   end
-
 end

data/lib/openstudio-standards/prototypes/common/prototype_metaprogramming.rb

@@ -4,42 +4,43 @@
 require 'json'
 
 def create_class_array
-  prototype_buildings = [
-      'FullServiceRestaurant',
-      'Hospital',
-      'HighriseApartment',
-      'LargeHotel',
-      'LargeOffice',
-      'MediumOffice',
-      'MidriseApartment',
-      'Outpatient',
-      'PrimarySchool',
-      'QuickServiceRestaurant',
-      'RetailStandalone',
-      'SecondarySchool',
-      'SmallHotel',
-      'SmallOffice',
-      'RetailStripmall',
-      'Warehouse',
-      'SuperMarket',
-      'SmallDataCenterLowITE',
-      'SmallDataCenterHighITE',
-      'LargeDataCenterLowITE',
-      'LargeDataCenterHighITE',
-      'SmallOfficeDetailed',
-      'MediumOfficeDetailed',
-      'LargeOfficeDetailed',
-      'Laboratory',
-      'College',
-      'TallBuilding',
-      'SuperTallBuilding'
-  ]
+  prototype_buildings = ['FullServiceRestaurant',
+                         'Hospital',
+                         'HighriseApartment',
+                         'LargeHotel',
+                         'LargeOffice',
+                         'MediumOffice',
+                         'MidriseApartment',
+                         'Outpatient',
+                         'PrimarySchool',
+                         'QuickServiceRestaurant',
+                         'RetailStandalone',
+                         'SecondarySchool',
+                         'SmallHotel',
+                         'SmallOffice',
+                         'RetailStripmall',
+                         'Warehouse',
+                         'SuperMarket',
+                         'SmallDataCenterLowITE',
+                         'SmallDataCenterHighITE',
+                         'LargeDataCenterLowITE',
+                         'LargeDataCenterHighITE',
+                         'SmallOfficeDetailed',
+                         'MediumOfficeDetailed',
+                         'LargeOfficeDetailed',
+                         'Laboratory',
+                         'College',
+                         'CourtHouse',
+                         'TallBuilding',
+                         'SuperTallBuilding']
 
   templates = {
     'ASHRAE9012004' => '90.1-2004',
     'ASHRAE9012007' => '90.1-2007',
     'ASHRAE9012010' => '90.1-2010',
     'ASHRAE9012013' => '90.1-2013',
+    'ASHRAE9012016' => '90.1-2016',
+    'ASHRAE9012019' => '90.1-2019',
     'DOERef1980to2004' => 'DOE Ref 1980-2004',
     'DOERefPre1980' => 'DOE Ref Pre-1980',
     'NRELZNEReady2017' => 'NREL ZNE Ready 2017'
@@ -269,227 +270,248 @@ end
     end
   end
 
-
   return class_array
 end
 
 def create_deer_class_array
   prototype_buildings = [
-      'Asm',
-      'ECC',
-      'EPr',
-      'ERC',
-      'ESe',
-      'EUn',
-      'Gro',
-      'Hsp',
-      'Nrs',
-      'Htl',
-      'Mtl',
-      'MBT',
-      'MLI',
-      'OfL',
-      'OfS',
-      'RFF',
-      'RSD',
-      'Rt3',
-      'RtL',
-      'RtS',
-      'SCn',
-      'SUn',
-      'WRf',
-      'GHs',
-      'DMo',
-      'MFm',
-      'SFm'
+    'Asm',
+    'ECC',
+    'EPr',
+    'ERC',
+    'ESe',
+    'EUn',
+    'Gro',
+    'Hsp',
+    'Nrs',
+    'Htl',
+    'Mtl',
+    'MBT',
+    'MLI',
+    'OfL',
+    'OfS',
+    'RFF',
+    'RSD',
+    'Rt3',
+    'RtL',
+    'RtS',
+    'SCn',
+    'SUn',
+    'WRf',
+    'GHs',
+    'DMo',
+    'MFm',
+    'SFm'
   ]
 
   # Only a subset of building type and HVAC type combinations are valid
   building_to_hvac_systems = {
-      'Asm' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'ECC' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG',
-          'WLHP'],
-      'EPr' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'WLHP'],
-      'ERC' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'ESe' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG',
-          'WLHP'],
-      'EUn' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG'],
-      'Gro' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'Hsp' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG'],
-      'Nrs' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'FPFC',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG'],
-      'Htl' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG',
-          'WLHP'],
-      'Mtl' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'MBT' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG',
-          'WLHP'],
-      'MFm' => [
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'MLI' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'OfL' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG',
-          'WLHP'],
-      'OfS' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG',
-          'WLHP'],
-      'RFF' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'RSD' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'Rt3' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF',
-          'PVVE',
-          'PVVG',
-          'SVVE',
-          'SVVG',
-          'WLHP'],
-      'RtL' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'RtS' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'SCn' => [
-          'DXEH',
-          'DXGF',
-          'DXHP',
-          'NCEH',
-          'NCGF'],
-      'SUn' => ['Unc'],
-      'WRf' => ['DXGF']
+    'Asm' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'ECC' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG',
+      'WLHP'
+    ],
+    'EPr' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'WLHP'
+    ],
+    'ERC' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'ESe' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG',
+      'WLHP'
+    ],
+    'EUn' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG'
+    ],
+    'Gro' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'Hsp' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG'
+    ],
+    'Nrs' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'FPFC',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG'
+    ],
+    'Htl' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG',
+      'WLHP'
+    ],
+    'Mtl' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'MBT' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG',
+      'WLHP'
+    ],
+    'MFm' => [
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'MLI' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'OfL' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG',
+      'WLHP'
+    ],
+    'OfS' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG',
+      'WLHP'
+    ],
+    'RFF' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'RSD' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'Rt3' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF',
+      'PVVE',
+      'PVVG',
+      'SVVE',
+      'SVVG',
+      'WLHP'
+    ],
+    'RtL' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'RtS' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'SCn' => [
+      'DXEH',
+      'DXGF',
+      'DXHP',
+      'NCEH',
+      'NCGF'
+    ],
+    'SUn' => ['Unc'],
+    'WRf' => ['DXGF']
   }
-  
+
   templates = {
     'DEERPRE1975' => 'DEER Pre-1975',
     'DEER1985' => 'DEER 1985',
@@ -519,8 +541,9 @@ end
     # Example class DEER1985AsmDXGF
     prototype_buildings.each do |building_type|
       next if building_to_hvac_systems[building_type].nil?
+
       building_to_hvac_systems[building_type].each do |hvac_system|
-      class_array << "
+        class_array << "
   # This class represents a prototypical #{template} #{building_type} #{hvac_system}.
   class #{template}#{building_type}#{hvac_system} < #{template}
   @@building_type = \"#{building_type}\"
@@ -648,9 +671,9 @@ end
 
 def create_cbes_class_array
   prototype_buildings = [
-      'MediumOffice',
-      'RetailStandalone',
-      'SmallOffice'
+    'MediumOffice',
+    'RetailStandalone',
+    'SmallOffice'
   ]
 
   templates = {
@@ -678,7 +701,7 @@ end
     # Create Building Specific classes for each building.
     # Example class CBESPre1978_MediumOffice
     prototype_buildings.each do |building_type|
-        class_array << "
+      class_array << "
   # This class represents a prototypical #{template} #{building_type}.
   class #{template}#{building_type} < #{template}
   @@building_type = \"#{building_type}\"
@@ -827,7 +850,7 @@ end
 
 def save_meta_classes_to_file
   filepath = "#{File.dirname(__FILE__)}/do_not_edit_metaclasses.rb"
-  File.open(filepath, 'w') {|f| create_class_array.each {|item| f << item}}
+  File.open(filepath, 'w') { |f| create_class_array.each { |item| f << item } }
 end
 
 def remove_meta_class_file