openstudio-standards 0.2.12.rc4 → 0.2.13.rc3

data/lib/openstudio-standards/standards/necb/NECB2017/necb_2017.rb

@@ -46,4 +46,33 @@ class NECB2017 < NECB2015
     return @standards_data
   end
 
+  def set_lighting_per_area_led_lighting(space_type:, definition:, lighting_per_area_led_lighting:, lights_scale:)
+
+    # puts "#{space_type.name.to_s} - 'space_height' - #{space_height.to_s}"
+    #TODO: Note that 'occ_sens_lpd_frac' in this function has been removed for NECB2015 and 2017.
+    # ##### Since Atrium's LPD for LED lighting depends on atrium's height, the height of the atrium (if applicable) should be found.
+    standards_space_type = space_type.standardsSpaceType.is_initialized ? space_type.standardsSpaceType.get : nil #Sara
+    if standards_space_type.include? 'Atrium' # TODO: Note that since none of the archetypes has Atrium, this was tested for 'Dining'. #Atrium
+      puts "#{standards_space_type} - has atrium"  # space_type.name.to_s
+      # puts space_height
+      if get_max_space_height_for_space_type(space_type: space_type) < 12.0
+        # TODO: Regarding the below equations, identify which version of ASHRAE 90.1 was used in NECB2017.
+        atrium_lpd_eq_smaller_12_intercept = 0
+        atrium_lpd_eq_smaller_12_slope = 1.06
+        atrium_lpd_eq_larger_12_intercept = 4.3
+        atrium_lpd_eq_larger_12_slope = 0.71
+        lighting_per_area_led_lighting_atrium = (atrium_lpd_eq_smaller_12_intercept + atrium_lpd_eq_smaller_12_slope * space_height) * 0.092903 # W/ft2
+      else # i.e. get_max_space_height_for_space_type >= 12.0
+        lighting_per_area_led_lighting_atrium = (atrium_lpd_eq_larger_12_intercept + atrium_lpd_eq_larger_12_slope * space_height) * 0.092903 # W/ft2
+      end
+      puts "#{standards_space_type} - has lighting_per_area_led_lighting_atrium - #{lighting_per_area_led_lighting_atrium}"
+      lighting_per_area_led_lighting = lighting_per_area_led_lighting_atrium
+    end
+    lighting_per_area_led_lighting *= lights_scale
+
+    definition.setWattsperSpaceFloorArea(OpenStudio.convert(lighting_per_area_led_lighting.to_f, 'W/ft^2', 'W/m^2').get)
+
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.SpaceType', "#{space_type.name} set LPD to #{lighting_per_area_led_lighting} W/ft^2.")
+  end
+
 end

data/lib/openstudio-standards/standards/oeesc/oeesc_2014/oeesc_2014.rb

@@ -15,5 +15,4 @@ class OEESC2014 < OEESC
   def load_standards_database(data_directories = [])
     super([__dir__] + data_directories)
   end
-
 end

data/lib/openstudio-standards/standards/standard.rb

@@ -27,13 +27,15 @@ class Standard
   #
   # @param name [String] the name of the Standard to build.
   #   valid choices are: DOE Pre-1980, DOE 1980-2004, 90.1-2004,
-  #   90.1-2007, 90.1-2010, 90.1-2013, NREL ZNE Ready 2017, NECB2011
+  #   90.1-2007, 90.1-2010, 90.1-2013, 90.1-2016, 90.1-2019,
+  #   NREL ZNE Ready 2017, NECB2011
   # @example Create a new Standard object by name
   #   standard = Standard.build('NECB2011')
   def self.build(name)
     if STANDARDS_LIST[name].nil?
       raise "ERROR: Did not find a class called '#{name}' to create in #{JSON.pretty_generate(STANDARDS_LIST)}"
     end
+
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.standard', "Using OpenStudio Standards version #{OpenstudioStandards::VERSION} with template #{name}.")
     return STANDARDS_LIST[name].new
   end
@@ -73,7 +75,6 @@ class Standard
     return lookup_name
   end
 
-
   # Loads the openstudio standards dataset for this standard.
   # For standards subclassed from other standards, the lowest-level
   # data will override data supplied at a higher level.
@@ -101,7 +102,7 @@ class Standard
           data.each_pair do |key, objs|
             # Override the template in inherited files to match the instantiated template
             objs.each do |obj|
-              if obj.has_key?('template')
+              if obj.key?('template')
                 obj['template'] = template
               end
             end
@@ -115,13 +116,13 @@ class Standard
         end
       else
         OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.standard', "Loading JSON files from #{data_dir}")
-        files = Dir.glob("#{data_dir}/data/*.json").select {|e| File.file? e}
+        files = Dir.glob("#{data_dir}/data/*.json").select { |e| File.file? e }
         files.each do |file|
           data = JSON.parse(File.read(file))
           data.each_pair do |key, objs|
             # Override the template in inherited files to match the instantiated template
             objs.each do |obj|
-              if obj.has_key?('template')
+              if obj.key?('template')
                 obj['template'] = template
               end
             end

data/lib/openstudio-standards/utilities/Add_template_field_to_json.rb

@@ -9,7 +9,7 @@ class Add_template_field_to_json
   # Name of file you want this script to produce:
   out_json_file = './necb_hvac_system_selection_type_mod.json'
   # What template version do you want to add:
-  template_version = {"template" => "NECB2011"}
+  template_version = { 'template' => 'NECB2011' }
   # Open the json file and put the data in data_tables:
   file = File.read(in_json_file)
   data_tables = JSON.parse(file)
@@ -18,5 +18,5 @@ class Add_template_field_to_json
     data_tables['tables'][0]['table'][index] = template_version.merge(data_table)
   end
   # Save the modified hash to a the file and location defined in out_json_file
-  File.open(out_json_file,"w") { |each_file| each_file.write(JSON.pretty_generate(data_tables)) }
-end
+  File.open(out_json_file, 'w') { |each_file| each_file.write(JSON.pretty_generate(data_tables)) }
+end

data/lib/openstudio-standards/utilities/convert_surfaces_to_adiabatic_necb_8426.rb

@@ -2,7 +2,7 @@ require_relative 'minitest_helper'
 require_relative 'create_doe_prototype_helper'
 require 'json'
 
-$LOAD_PATH.unshift File.expand_path('../../../../openstudio-standards/lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../../openstudio-standards/lib', __dir__)
 def run_dir(test_name)
   # always generate test output in specially named 'output' directory so result files are not made part of the measure
   "#{File.dirname(__FILE__)}/output/#{test_name}"
@@ -40,30 +40,29 @@ def calculate_max_delta_t(adj_DaySchedule, cur_DaySchedule)
   #  elsif (cur_DaySchedule.nil? and cur_DaySchedule.nil?)
   #    return nil
   #  end
-  if (cur_DaySchedule.nil? or adj_DaySchedule.nil?)
-    raise ("cur_DaySchedule or adj_DaySchedule is nil")
+  if cur_DaySchedule.nil? || adj_DaySchedule.nil?
+    raise 'cur_DaySchedule or adj_DaySchedule is nil'
     return nil
   end
-  
+
   0.upto(23) do |hour|
-    time = OpenStudio::Time.new(0,hour,0,0)
+    time = OpenStudio::Time.new(0, hour, 0, 0)
     difference = (cur_DaySchedule.getValue(time) - adj_DaySchedule.getValue(time)).abs
     max = difference if difference > max
   end
   return max
-
 end
 
-#returns -999 if current surface does not have heating OR cooling schedule
-#returns -997 if all adjacent surfaces does not have BOTH heating AND cooling
-#returns nil if the surface does not have adjacent surface
+# returns -999 if current surface does not have heating OR cooling schedule
+# returns -997 if all adjacent surfaces does not have BOTH heating AND cooling
+# returns nil if the surface does not have adjacent surface
 def get_schedule_max_delta_t(model, surface)
-  #find spaces that share that surface. 
-  #load the schedules for every day type of the year. for both spaces. If the space is does not have a heating schedule..assume the temperature is the -10C always for now. 
-  #iterate through every hour. and determine delta T
-  # Store the max delta T. 
+  # find spaces that share that surface.
+  # load the schedules for every day type of the year. for both spaces. If the space is does not have a heating schedule..assume the temperature is the -10C always for now.
+  # iterate through every hour. and determine delta T
+  # Store the max delta T.
   # end iteration
-  #return max deltaT
+  # return max deltaT
   cur_space = nil
   delta_t = -998
   adjacent_surface_found = false
@@ -74,52 +73,54 @@ def get_schedule_max_delta_t(model, surface)
     end
   end
   if cur_space.nil?
-    raise ("Surface: [#{surface.name}] does not belong to any space")
+    raise "Surface: [#{surface.name}] does not belong to any space"
   end
+
   model.getSpaces.each do |space|
     if space == surface.space.get
       next
     end
-    surf = BTAP::Geometry::Surfaces::get_surfaces_from_spaces([space])
+
+    surf = BTAP::Geometry::Surfaces.get_surfaces_from_spaces([space])
     surf.each do |surf|
       unless surf.adjacentSurface.empty?
         adj_surface = surf.adjacentSurface.get
         if adj_surface == surface
           adjacent_surface_found = true
-          unless space.thermalZone().empty?
-            adj_surface_thermal_zone = space.thermalZone().get
-            cur_surface_thermal_zone = cur_space.thermalZone().get
+          unless space.thermalZone.empty?
+            adj_surface_thermal_zone = space.thermalZone.get
+            cur_surface_thermal_zone = cur_space.thermalZone.get
             unless adj_surface_thermal_zone.thermostatSetpointDualSetpoint.empty?
               adj_thermostat = adj_surface_thermal_zone.thermostatSetpointDualSetpoint.get
               cur_thermostat = cur_surface_thermal_zone.thermostatSetpointDualSetpoint.get
-              #if current surface does not have a thermostat schedule, then it will return -999 instead of nil because nil is reserved for surfaces without adjacent surface
-              if (cur_thermostat.getHeatingSchedule().empty? or cur_thermostat.getCoolingSchedule().empty?)
+              # if current surface does not have a thermostat schedule, then it will return -999 instead of nil because nil is reserved for surfaces without adjacent surface
+              if cur_thermostat.getHeatingSchedule.empty? || cur_thermostat.getCoolingSchedule.empty?
                 return -999
               end
-              #after this point current surface should have BOTH heating and cooling schedule
-              #if adjacent surface does not have a heating OR cooling schedule it will be skipped
-              if (adj_thermostat.getHeatingSchedule().empty? or adj_thermostat.getCoolingSchedule().empty?)
+              # after this point current surface should have BOTH heating and cooling schedule
+              # if adjacent surface does not have a heating OR cooling schedule it will be skipped
+              if adj_thermostat.getHeatingSchedule.empty? || adj_thermostat.getCoolingSchedule.empty?
                 next
               else
                 atleast_one_adjacent_surface_has_schedule = true
               end
-                
-              startDate = OpenStudio::Date.new(OpenStudio::MonthOfYear.new(1), 1,2009)
-              endDate = OpenStudio::Date.new(OpenStudio::MonthOfYear.new(1), 7,2009)
-              
-              adj_surface_heating_day_schedule_array = adj_thermostat.getHeatingSchedule().get.to_ScheduleRuleset.get.getDaySchedules(startDate,endDate) unless adj_thermostat.getHeatingSchedule().empty?
-              adj_surface_cooling_day_schedule_array = adj_thermostat.getCoolingSchedule().get.to_ScheduleRuleset.get.getDaySchedules(startDate,endDate) unless adj_thermostat.getCoolingSchedule().empty?
-              cur_surface_heating_day_schedule_array = cur_thermostat.getHeatingSchedule().get.to_ScheduleRuleset.get.getDaySchedules(startDate,endDate) unless cur_thermostat.getHeatingSchedule().empty?
-              cur_surface_cooling_day_schedule_array = cur_thermostat.getCoolingSchedule().get.to_ScheduleRuleset.get.getDaySchedules(startDate,endDate) unless cur_thermostat.getCoolingSchedule().empty?
+
+              startDate = OpenStudio::Date.new(OpenStudio::MonthOfYear.new(1), 1, 2009)
+              endDate = OpenStudio::Date.new(OpenStudio::MonthOfYear.new(1), 7, 2009)
+
+              adj_surface_heating_day_schedule_array = adj_thermostat.getHeatingSchedule.get.to_ScheduleRuleset.get.getDaySchedules(startDate, endDate) unless adj_thermostat.getHeatingSchedule.empty?
+              adj_surface_cooling_day_schedule_array = adj_thermostat.getCoolingSchedule.get.to_ScheduleRuleset.get.getDaySchedules(startDate, endDate) unless adj_thermostat.getCoolingSchedule.empty?
+              cur_surface_heating_day_schedule_array = cur_thermostat.getHeatingSchedule.get.to_ScheduleRuleset.get.getDaySchedules(startDate, endDate) unless cur_thermostat.getHeatingSchedule.empty?
+              cur_surface_cooling_day_schedule_array = cur_thermostat.getCoolingSchedule.get.to_ScheduleRuleset.get.getDaySchedules(startDate, endDate) unless cur_thermostat.getCoolingSchedule.empty?
               delta_t = -998
-              heating_delta_t =  []
+              heating_delta_t = []
               cooling_delta_t = []
-              1.upto(7) { |i|
-                puts "mee mee mee"
-                puts calculate_max_delta_t(adj_surface_heating_day_schedule_array[i-1],cur_surface_heating_day_schedule_array[i-1])
-                heating_delta_t << calculate_max_delta_t(adj_surface_heating_day_schedule_array[i-1],cur_surface_heating_day_schedule_array[i-1])
-                cooling_delta_t << calculate_max_delta_t(adj_surface_cooling_day_schedule_array[i-1],cur_surface_cooling_day_schedule_array[i-1])
-              }
+              1.upto(7) do |i|
+                puts 'mee mee mee'
+                puts calculate_max_delta_t(adj_surface_heating_day_schedule_array[i - 1], cur_surface_heating_day_schedule_array[i - 1])
+                heating_delta_t << calculate_max_delta_t(adj_surface_heating_day_schedule_array[i - 1], cur_surface_heating_day_schedule_array[i - 1])
+                cooling_delta_t << calculate_max_delta_t(adj_surface_cooling_day_schedule_array[i - 1], cur_surface_cooling_day_schedule_array[i - 1])
+              end
               delta_t = [heating_delta_t.max, cooling_delta_t.max].max
               puts "delta_t: #{delta_t}"
             end
@@ -128,7 +129,7 @@ def get_schedule_max_delta_t(model, surface)
       end
     end
   end
-  #adjacent_surface_found ? (atleast_one_adjacent_surface_has_schedule ? (return delta_t) : (return -997)) : (return nil)
+  # adjacent_surface_found ? (atleast_one_adjacent_surface_has_schedule ? (return delta_t) : (return -997)) : (return nil)
   if adjacent_surface_found
     if atleast_one_adjacent_surface_has_schedule
       return delta_t
@@ -139,7 +140,7 @@ def get_schedule_max_delta_t(model, surface)
     return nil
   end
 end
-#LargeOffice
+# LargeOffice
 class TestNECBSurfaces8426Custom < CreateDOEPrototypeBuildingTest
   building_types = [
     'LargeOffice',
@@ -149,10 +150,10 @@ class TestNECBSurfaces8426Custom < CreateDOEPrototypeBuildingTest
     'PrimarySchool'
   ]
 
-  templates = [ 'NECB 2011']
+  templates = ['NECB 2011']
   climate_zones = ['NECB HDD Method']
   epw_files = [
-    #  'CAN_BC_Vancouver.718920_CWEC.epw',#  CZ 5 - Gas HDD = 3019 
+    #  'CAN_BC_Vancouver.718920_CWEC.epw',#  CZ 5 - Gas HDD = 3019
     #  'CAN_ON_Toronto.716240_CWEC.epw', #CZ 6 - Gas HDD = 4088
     #  'CAN_PQ_Sherbrooke.716100_CWEC.epw', #CZ 7a - Electric HDD = 5068
     #  'CAN_YT_Whitehorse.719640_CWEC.epw', #CZ 7b - FuelOil1 HDD = 6946
@@ -166,39 +167,38 @@ class TestNECBSurfaces8426Custom < CreateDOEPrototypeBuildingTest
       unless File.exist?(run_dir(test_name))
         FileUtils.mkdir_p(run_dir(test_name))
       end
-      #assert(File.exist?(run_dir(test_name)))
+      # assert(File.exist?(run_dir(test_name)))
 
       if File.exist?(report_path(test_name))
         FileUtils.rm(report_path(test_name))
       end
 
-      #assert(File.exist?(model_in_path))
+      # assert(File.exist?(model_in_path))
 
       if File.exist?(model_out_path(test_name))
         FileUtils.rm(model_out_path(test_name))
       end
       output_folder = "#{File.dirname(__FILE__)}/output/#{test_name}"
       model = OpenStudio::Model::Model.new
-      model.create_prototype_building(building,'NECB 2011','NECB HDD Method',weather,output_folder)
+      model.create_prototype_building(building, 'NECB 2011', 'NECB HDD Method', weather, output_folder)
       BTAP::Environment::WeatherFile.new(weather).set_weather_file(model)
       model.getSpaces.each do |space|
-        #puts space.name
+        # puts space.name
         hash[:"Space: #{space.name}"] = {}
         hash[:"Space: #{space.name}"][:"With Adjacent Surface"] = {}
         hash[:"Space: #{space.name}"][:"No Adjacent surface"] = []
-        surfaces = BTAP::Geometry::Surfaces::get_surfaces_from_spaces([space])
+        surfaces = BTAP::Geometry::Surfaces.get_surfaces_from_spaces([space])
         surfaces.each do |surface|
           max_delta_t = get_schedule_max_delta_t(model, surface)
-          unless max_delta_t.nil?
-            hash[:"Space: #{space.name}"][:"With Adjacent Surface"][:"#{surface.name}"] = max_delta_t
-          else
+          if max_delta_t.nil?
             hash[:"Space: #{space.name}"][:"No Adjacent surface"] << surface.name
+          else
+            hash[:"Space: #{space.name}"][:"With Adjacent Surface"][:"#{surface.name}"] = max_delta_t
           end
         end
       end
-      #model.save(model_out_path(test_name), true)
-      File.open("#{output_folder}/max_delta_t.json", 'w') {|f| f.write(JSON.pretty_generate(hash)) }
+      # model.save(model_out_path(test_name), true)
+      File.open("#{output_folder}/max_delta_t.json", 'w') { |f| f.write(JSON.pretty_generate(hash)) }
     end
   end
-    
 end

data/lib/openstudio-standards/utilities/generate_prototype_database.rb

@@ -26,8 +26,8 @@ nrel_building_types = [
 
 ]
 
-templates = ['90.1-2004', '90.1-2007', '90.1-2010', '90.1-2013', 'DOE Ref Pre-1980', 'DOE Ref 1980-2004', 'NECB2011']
-new_templates = ['ASHRAE9012004', 'ASHRAE9012007', 'ASHRAE9012010', 'ASHRAE9012013', 'DOERefPre1980', 'DOERef1980to2004', 'NECB2011']
+templates = ['90.1-2004', '90.1-2007', '90.1-2010', '90.1-2013', '90.1-2016', '90.1-2019', 'DOE Ref Pre-1980', 'DOE Ref 1980-2004', 'NECB2011']
+new_templates = ['ASHRAE9012004', 'ASHRAE9012007', 'ASHRAE9012010', 'ASHRAE9012013', 'ASHRAE9012016', 'ASHRAE9012019', 'DOERefPre1980', 'DOERef1980to2004', 'NECB2011']
 
 array = []
 Dir.glob('/home/osdev/openstudio-standards/openstudio-standards/data/geometry/archetypes//**/*.json').each do |filename|

data/lib/openstudio-standards/utilities/generate_space_types.rb

@@ -1,8 +1,8 @@
 require_relative '../../../test/helpers/minitest_helper'
 require_relative '../../../test/helpers/create_doe_prototype_helper'
 
-['NECB2011','NECB2015'].each do |template|
+['NECB2011', 'NECB2015'].each do |template|
   model = OpenStudio::Model::Model.new
   Standard.build(template).add_all_spacetypes_to_model(model)
-  BTAP::FileIO::save_osm(model, File.join(File.dirname(__FILE__), "output", "#{template}_space_types.osm"))
-end
+  BTAP::FileIO.save_osm(model, File.join(File.dirname(__FILE__), 'output', "#{template}_space_types.osm"))
+end

data/lib/openstudio-standards/utilities/logging.rb

@@ -1,14 +1,13 @@
-
 # Open a log for the library
-$OPENSTUDIO_LOG = OpenStudio::StringStreamLogSink.new # rubocop:disable Style/GlobalVars
-$OPENSTUDIO_LOG.setLogLevel(OpenStudio::Debug) # rubocop:disable Style/GlobalVars
+$OPENSTUDIO_LOG = OpenStudio::StringStreamLogSink.new
+$OPENSTUDIO_LOG.setLogLevel(OpenStudio::Debug)
 
 # Log the info, warning, and error messages to a runner.
 # runner @param [Runner] The Measure runner to add the messages to
 # debug @param [Boolean] If true, include the debug messages in the log
 # @return [Runner] The same Measure runner, with messages from the openstudio-standards library added
 def log_messages_to_runner(runner, debug = false)
-  $OPENSTUDIO_LOG.logMessages.each do |msg| # rubocop:disable Style/GlobalVars
+  $OPENSTUDIO_LOG.logMessages.each do |msg|
     # DLM: you can filter on log channel here for now
     if /openstudio.*/ =~ msg.logChannel # /openstudio\.model\..*/
       # Skip certain messages that are irrelevant/misleading
@@ -44,7 +43,7 @@ def log_messages_to_file(file_path, debug = false)
   messages = []
 
   File.open(file_path, 'w') do |file|
-    $OPENSTUDIO_LOG.logMessages.each do |msg| # rubocop:disable Style/GlobalVars
+    $OPENSTUDIO_LOG.logMessages.each do |msg|
       # DLM: you can filter on log channel here for now
       if /openstudio.*/ =~ msg.logChannel # /openstudio\.model\..*/
         # Skip certain messages that are irrelevant/misleading
@@ -87,7 +86,7 @@ end
 def get_logs(log_type = OpenStudio::Error)
   errors = []
 
-  $OPENSTUDIO_LOG.logMessages.each do |msg| # rubocop:disable Style/GlobalVars
+  $OPENSTUDIO_LOG.logMessages.each do |msg|
     if /openstudio.*/ =~ msg.logChannel
       # Skip certain messages that are irrelevant/misleading
       next if msg.logMessage.include?('UseWeatherFile') || # 'UseWeatherFile' is not yet a supported option for YearDescription
@@ -99,6 +98,7 @@ def get_logs(log_type = OpenStudio::Error)
               msg.logMessage.include?('has multiple parents') || # Bogus errors about curves having multiple parents
               msg.logMessage.include?('does not have an Output') || # Warning from EMS translation
               msg.logMessage.include?('Prior to OpenStudio 2.6.2, this field was returning a double, it now returns an Optional double') # Warning about OS API change
+
       # Only fail on the errors
       if msg.logLevel == log_type
         errors << "[#{msg.logChannel}] #{msg.logMessage}"
@@ -110,5 +110,5 @@ def get_logs(log_type = OpenStudio::Error)
 end
 
 def reset_log
-  $OPENSTUDIO_LOG.resetStringStream # rubocop:disable Style/GlobalVars
+  $OPENSTUDIO_LOG.resetStringStream
 end

data/lib/openstudio-standards/utilities/necb_to_epw_map.rb

@@ -1,18 +1,18 @@
-require ('json')
+require 'json'
 
 def distance(loc1, loc2)
-  rad_per_deg = Math::PI/180 # PI / 180
+  rad_per_deg = Math::PI / 180 # PI / 180
   rkm = 6371 # Earth radius in kilometers
   rm = rkm * 1000 # Radius in meters
 
-  dlat_rad = (loc2[0]-loc1[0]) * rad_per_deg # Delta, converted to rad
-  dlon_rad = (loc2[1]-loc1[1]) * rad_per_deg
+  dlat_rad = (loc2[0] - loc1[0]) * rad_per_deg # Delta, converted to rad
+  dlon_rad = (loc2[1] - loc1[1]) * rad_per_deg
 
-  lat1_rad, lon1_rad = loc1.map {|i| i * rad_per_deg}
-  lat2_rad, lon2_rad = loc2.map {|i| i * rad_per_deg}
+  lat1_rad, lon1_rad = loc1.map { |i| i * rad_per_deg }
+  lat2_rad, lon2_rad = loc2.map { |i| i * rad_per_deg }
 
-  a = Math.sin(dlat_rad/2)**2 + Math.cos(lat1_rad) * Math.cos(lat2_rad) * Math.sin(dlon_rad/2)**2
-  c = 2 * Math::atan2(Math::sqrt(a), Math::sqrt(1-a))
+  a = Math.sin(dlat_rad / 2)**2 + Math.cos(lat1_rad) * Math.cos(lat2_rad) * Math.sin(dlon_rad / 2)**2
+  c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1 - a))
   rm * c # Delta in meters
 end
 
@@ -26,18 +26,18 @@ JSON.parse(File.read(epw_data_file_path)).each do |epw|
   necb_closest = nil
   JSON.parse(File.read(necb_data_file_path))['necb_2015_table_c1']['table'].each do |necb|
     next if necb['lat_long'].nil?
+
     d = distance([epw['latitude'].to_f, epw['longitude']], necb['lat_long'])
     if min_distance > d
       min_distance = d
       necb_closest = necb
     end
   end
-  array_of_hashes << {'epw_file' => epw['file'],
-                      'necb_location' => "#{necb_closest['city']},#{necb_closest['province']}" ,
-                      "hdd_difference" => (epw['hdd18'].to_f - necb_closest['degree_days_below_18_c'].to_f),
-                      'distance_km' => '%.2f' % (min_distance/1000.0),
-                      'hdd18' => necb_closest['degree_days_below_18_c']
-                      }
+  array_of_hashes << { 'epw_file' => epw['file'],
+                       'necb_location' => "#{necb_closest['city']},#{necb_closest['province']}",
+                       'hdd_difference' => (epw['hdd18'].to_f - necb_closest['degree_days_below_18_c'].to_f),
+                       'distance_km' => format('%.2f', (min_distance / 1000.0)),
+                       'hdd18' => necb_closest['degree_days_below_18_c'] }
 end
 File.write("#{File.dirname(__FILE__)}/../standards/necb/NECB2011/data/epw_file_to_necb_hdd_map.json", JSON.pretty_generate(array_of_hashes))
 

data/lib/openstudio-standards/utilities/os_sim_extract.rb

@@ -14,35 +14,35 @@ class OS_sim_extract
     area_scale_factor = nil
     epw_file = nil
     outdoor_air = false
-    data_table["measures"].each do |measure|
-      if measure["name"] == "btap_create_necb_prototype_building_scale"
-        building_type = measure["arguments"]["building_type"]
-        template_version = measure["arguments"]["template"]
-        area_scale_factor = measure["arguments"]["area_scale_factor"]
-        epw_file = measure["arguments"]["epw_file"]
-      elsif measure["display_name"] == "BTAPIdealAirLoadsOptionsEplus"
+    data_table['measures'].each do |measure|
+      if measure['name'] == 'btap_create_necb_prototype_building_scale'
+        building_type = measure['arguments']['building_type']
+        template_version = measure['arguments']['template']
+        area_scale_factor = measure['arguments']['area_scale_factor']
+        epw_file = measure['arguments']['epw_file']
+      elsif measure['display_name'] == 'BTAPIdealAirLoadsOptionsEplus'
         outdoor_air = true
       end
     end
     extract_hash = {
-        :conditioned_floor_area => data_table["building"]["conditioned_floor_area_m2"],
-        :exterior_area => data_table["building"]["exterior_area_m2"],
-        :volume => data_table["building"]["volume"],
-        :hdd => data_table["geography"]["hdd"],
-        :cdd => data_table["geography"]["cdd"],
-        :heating_gj => data_table["end_uses"]["heating_gj"],
-        :cooling_gj => data_table["end_uses"]["cooling_gj"],
-        :ep_conditioned_floor_area_m2 => data_table["code_metrics"]["ep_conditioned_floor_area_m2"],
-        :os_conditioned_floor_area_m2 => data_table["code_metrics"]["os_conditioned_floor_area_m2"],
-        :building_tedi_gj_per_m2 => data_table["code_metrics"]["building_tedi_gj_per_m2"],
-        :building_medi_gj_per_m2 => data_table["code_metrics"]["building_medi_gj_per_m2"],
-        :building_type => building_type,
-        :template_version => template_version,
-        :epw_file => epw_file,
-        :area_scale_factor => area_scale_factor,
-        :outdoor_air => outdoor_air
+      conditioned_floor_area: data_table['building']['conditioned_floor_area_m2'],
+      exterior_area: data_table['building']['exterior_area_m2'],
+      volume: data_table['building']['volume'],
+      hdd: data_table['geography']['hdd'],
+      cdd: data_table['geography']['cdd'],
+      heating_gj: data_table['end_uses']['heating_gj'],
+      cooling_gj: data_table['end_uses']['cooling_gj'],
+      ep_conditioned_floor_area_m2: data_table['code_metrics']['ep_conditioned_floor_area_m2'],
+      os_conditioned_floor_area_m2: data_table['code_metrics']['os_conditioned_floor_area_m2'],
+      building_tedi_gj_per_m2: data_table['code_metrics']['building_tedi_gj_per_m2'],
+      building_medi_gj_per_m2: data_table['code_metrics']['building_medi_gj_per_m2'],
+      building_type: building_type,
+      template_version: template_version,
+      epw_file: epw_file,
+      area_scale_factor: area_scale_factor,
+      outdoor_air: outdoor_air
     }
     output_array << extract_hash
   end
-  File.open(out_json_file,"w") {|each_file| each_file.write(JSON.pretty_generate(output_array))}
-end
+  File.open(out_json_file, 'w') { |each_file| each_file.write(JSON.pretty_generate(output_array)) }
+end