cosmos 4.5.2 → 5.0.2.pre.beta2

data/lib/cosmos/packets/parsers/limits_response_parser.rb

@@ -1,15 +1,23 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 module Cosmos
-
   class LimitsResponseParser
     # @param parser [ConfigParser] Configuration parser
     # @param item [Packet] The current item
@@ -30,6 +38,7 @@ module Cosmos
       if cmd_or_tlm == PacketConfig::COMMAND
         raise @parser.error("LIMITS_RESPONSE only applies to telemetry items")
       end
+
       @usage = "LIMITS_RESPONSE <RESPONSE CLASS FILENAME> <RESPONSE SPECIFIC OPTIONS>"
       @parser.verify_num_parameters(1, nil, @usage)
     end
@@ -39,6 +48,7 @@ module Cosmos
       # require should be performed in target.txt
       klass = @parser.parameters[0].filename_to_class_name.to_class
       raise @parser.error("#{@parser.parameters[0].filename_to_class_name} class not found. Did you require the file in target.txt?", @usage) unless klass
+
       if @parser.parameters[1]
         item.limits.response = klass.new(*@parser.parameters[1..(@parser.parameters.length - 1)])
       else
@@ -47,6 +57,5 @@ module Cosmos
     rescue Exception => err
       raise @parser.error(err, @usage)
     end
-
   end
 end # module Cosmos

data/lib/cosmos/packets/parsers/packet_item_parser.rb

@@ -1,12 +1,21 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'cosmos/packets/packet_item'
 
@@ -41,11 +50,13 @@ module Cosmos
       elsif @parser.keyword.include?('PARAMETER') && cmd_or_tlm == PacketConfig::TELEMETRY
         raise @parser.error("PARAMETER types are only valid with COMMAND", @usage)
       end
+
       # The usage is formatted with brackets <XXX> around each option so
       # count the number of open brackets to determine the number of options
       max_options = @usage.count("<")
       # The last two options (description and endianness) are optional
-      @parser.verify_num_parameters(max_options-2, max_options, @usage)
+      @parser.verify_num_parameters(max_options - 2, max_options, @usage)
+      @parser.verify_parameters_underscores(1) # Item name is the 1st parameter
     end
 
     def create_packet_item(packet, cmd_or_tlm)
@@ -91,6 +102,7 @@ module Cosmos
 
     def get_bit_offset
       return 0 if append?
+
       Integer(@parser.parameters[1])
     rescue => err # In case Integer fails
       raise @parser.error(err, @usage)
@@ -104,15 +116,16 @@ module Cosmos
     end
 
     def get_array_size
-      return nil unless (@parser.keyword.include?('ARRAY'))
+      return nil unless @parser.keyword.include?('ARRAY')
+
       index = append? ? 3 : 4
       array_bit_size = Integer(@parser.parameters[index])
       items = array_bit_size / get_bit_size()
       if items >= BIG_ARRAY_SIZE
         warning = "Performance Issue!\n"\
-          "In #{@parser.filename}:#{@parser.line_number} your definition of:\n"\
-          "#{@parser.line}\n"\
-          "creates an array with #{items} elements. Consider creating a BLOCK if this is binary data."
+                  "In #{@parser.filename}:#{@parser.line_number} your definition of:\n"\
+                  "#{@parser.line}\n"\
+                  "creates an array with #{items} elements. Consider creating a BLOCK if this is binary data."
         Logger.warn(warning)
         @warnings << warning
       end
@@ -124,8 +137,8 @@ module Cosmos
     def get_endianness(packet)
       params = @parser.parameters
       max_options = @usage.count("<")
-      if params[max_options-1]
-        endianness = params[max_options-1].to_s.upcase.intern
+      if params[max_options - 1]
+        endianness = params[max_options - 1].to_s.upcase.intern
         if endianness != :BIG_ENDIAN and endianness != :LITTLE_ENDIAN
           raise @parser.error("Invalid endianness #{endianness}. Must be BIG_ENDIAN or LITTLE_ENDIAN.", @usage)
         end
@@ -137,14 +150,17 @@ module Cosmos
 
     def get_range
       return nil if @parser.keyword.include?('ARRAY')
+
       data_type = get_data_type()
       return nil if data_type == :STRING or data_type == :BLOCK
 
       index = append? ? 3 : 4
       min = ConfigParser.handle_defined_constants(
-        @parser.parameters[index].convert_to_value, get_data_type(), get_bit_size())
+        @parser.parameters[index].convert_to_value, get_data_type(), get_bit_size()
+      )
       max = ConfigParser.handle_defined_constants(
-        @parser.parameters[index+1].convert_to_value, get_data_type(), get_bit_size())
+        @parser.parameters[index + 1].convert_to_value, get_data_type(), get_bit_size()
+      )
       min..max
     end
 
@@ -156,21 +172,23 @@ module Cosmos
       if data_type == :STRING or data_type == :BLOCK
         # If the default value is 0x<data> (no quotes), it is treated as
         # binary data.  Otherwise, the default value is considered to be a string.
-        if (@parser.parameters[index].upcase.start_with?("0X")         and
-            !@parser.line.include?("\"#{@parser.parameters[index]}\"") and
-            !@parser.line.include?("\'#{@parser.parameters[index]}\'"))
+        if @parser.parameters[index].upcase.start_with?("0X") and
+           !@parser.line.include?("\"#{@parser.parameters[index]}\"") and
+           !@parser.line.include?("\'#{@parser.parameters[index]}\'")
           return @parser.parameters[index].hex_to_byte_string
         else
           return @parser.parameters[index]
         end
       else
         return ConfigParser.handle_defined_constants(
-          @parser.parameters[index+2].convert_to_value, get_data_type(), get_bit_size())
+          @parser.parameters[index + 2].convert_to_value, get_data_type(), get_bit_size()
+        )
       end
     end
 
     def get_id_value
       return nil unless @parser.keyword.include?('ID_')
+
       data_type = get_data_type
       if @parser.keyword.include?('ITEM')
         index = append? ? 3 : 4
@@ -182,12 +200,13 @@ module Cosmos
       if data_type == :DERIVED
         raise @parser.error("DERIVED data type not allowed for Identifier")
       end
+
       @parser.parameters[index]
     end
 
     def get_description
       max_options = @usage.count("<")
-      @parser.parameters[max_options-2] if @parser.parameters[max_options-2]
+      @parser.parameters[max_options - 2] if @parser.parameters[max_options - 2]
     end
 
     # There are many different usages of the ITEM and PARAMETER keywords so
@@ -242,6 +261,7 @@ module Cosmos
 
     def id_usage
       return '' unless @parser.keyword.include?("ID")
+
       if @parser.keyword.include?("PARAMETER")
         "<DEFAULT AND ID VALUE> "
       else

data/lib/cosmos/packets/parsers/packet_parser.rb

@@ -1,17 +1,25 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'cosmos/packets/packet'
 
 module Cosmos
-
   class PacketParser
     # @param parser [ConfigParser] Configuration parser
     # @param target_name [String] The name of the target to create the packet
@@ -64,6 +72,7 @@ module Cosmos
     def verify_parameters
       @usage = "#{@parser.keyword} <TARGET NAME> <PACKET NAME> <ENDIANNESS: BIG_ENDIAN/LITTLE_ENDIAN> <DESCRIPTION (Optional)>"
       @parser.verify_num_parameters(3, 4, @usage)
+      @parser.verify_parameters_underscores(2) # Packet name is the 2nd parameter
     end
 
     def create_command(target_name, commands, warnings)
@@ -76,7 +85,7 @@ module Cosmos
       PacketParser.finish_create_telemetry(packet, telemetry, latest_data, warnings)
     end
 
-    #private
+    # private
 
     def create_packet(target_name)
       params = @parser.parameters
@@ -87,6 +96,7 @@ module Cosmos
       if endianness != :BIG_ENDIAN and endianness != :LITTLE_ENDIAN
         raise @parser.error("Invalid endianness #{params[2]}. Must be BIG_ENDIAN or LITTLE_ENDIAN.", @usage)
       end
+
       Packet.new(target_name, packet_name, endianness, description)
     end
 
@@ -104,6 +114,7 @@ module Cosmos
     def self.finish_create_command(packet, commands, warnings)
       warning = PacketParser.check_for_duplicate('Command', commands, packet)
       warnings << warning if warning
+      packet.define_reserved_items()
       commands[packet.target_name] ||= {}
       packet
     end
@@ -119,6 +130,5 @@ module Cosmos
       end
       packet
     end
-
   end
 end

data/lib/cosmos/packets/parsers/processor_parser.rb

@@ -1,17 +1,25 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'cosmos/processors'
 
 module Cosmos
-
   class ProcessorParser
     # @param parser [ConfigParser] Configuration parser
     # @param packet [Packet] The current packet
@@ -32,6 +40,7 @@ module Cosmos
       if cmd_or_tlm == PacketConfig::COMMAND
         raise @parser.error("PROCESSOR only applies to telemetry packets")
       end
+
       @usage = "PROCESSOR <PROCESSOR NAME> <PROCESSOR CLASS FILENAME> <PROCESSOR SPECIFIC OPTIONS>"
       @parser.verify_num_parameters(2, nil, @usage)
     end
@@ -41,12 +50,14 @@ module Cosmos
       # require should be performed in target.txt
       klass = @parser.parameters[1].filename_to_class_name.to_class
       raise @parser.error("#{@parser.parameters[1].filename_to_class_name} class not found. Did you require the file in target.txt?", @usage) unless klass
+
       if @parser.parameters[2]
         processor = klass.new(*@parser.parameters[2..(@parser.parameters.length - 1)])
       else
         processor = klass.new
       end
       raise ArgumentError, "processor must be a Cosmos::Processor but is a #{processor.class}" unless Cosmos::Processor === processor
+
       processor.name = get_processor_name()
       packet.processors[processor.name] = processor
     rescue Exception => err
@@ -58,6 +69,5 @@ module Cosmos
     def get_processor_name
       @parser.parameters[0].to_s.upcase
     end
-
   end
 end # module Cosmos

data/lib/cosmos/packets/parsers/state_parser.rb

@@ -1,17 +1,25 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'cosmos/packets/packet_item'
 
 module Cosmos
-
   class StateParser
     # @param parser [ConfigParser] Configuration parser
     # @param packet [Packet] The current packet
@@ -22,6 +30,7 @@ module Cosmos
     def self.parse(parser, packet, cmd_or_tlm, item, warnings)
       raise parser.error("Items with LIMITS can't define STATE") if item.limits.values
       raise parser.error("Items with UNITS can't define STATE") if item.units
+
       @parser = StateParser.new(parser)
       @parser.verify_parameters(cmd_or_tlm)
       @parser.create_state(packet, cmd_or_tlm, item, warnings)
@@ -109,10 +118,10 @@ module Cosmos
       unless PacketItem::STATE_COLORS.include? color
         raise @parser.error("Invalid state color #{color}. Must be one of #{PacketItem::STATE_COLORS.join(' ')}.", @usage)
       end
+
       item.limits.enabled = true
       item.state_colors ||= {}
       item.state_colors[get_state_name()] = color
     end
-
   end
 end # module Cosmos

data/lib/cosmos/packets/parsers/xtce_converter.rb

@@ -1,12 +1,21 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'nokogiri'
 require 'cosmos/packets/parsers/xtce_parser'
@@ -57,9 +66,9 @@ module Cosmos
         # Create the xtce file for this target
         builder = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
           xml['xtce'].SpaceSystem("xmlns:xtce" => "http://www.omg.org/space/xtce",
-            "xmlns:xsi" => "http://www.w3.org/2001/XMLSchema-instance",
-            "name" => target_name,
-            "xsi:schemaLocation" => "http://www.omg.org/space/xtce http://www.omg.org/spec/XTCE/20061101/06-11-06.xsd") do
+                                  "xmlns:xsi" => "http://www.w3.org/2001/XMLSchema-instance",
+                                  "name" => target_name,
+                                  "xsi:schemaLocation" => "http://www.omg.org/space/xtce http://www.omg.org/spec/XTCE/20061101/06-11-06.xsd") do
             create_telemetry(xml, telemetry, target_name)
             create_commands(xml, commands, target_name)
           end # SpaceSystem
@@ -133,6 +142,7 @@ module Cosmos
               xml['xtce'].ArgumentList do
                 packet.sorted_items.each do |item|
                   next if item.data_type == :DERIVED
+
                   to_xtce_item(item, 'Argument', xml)
                 end
               end # ArgumentList
@@ -164,6 +174,7 @@ module Cosmos
       items.each do |packet_name, packet|
         packet.sorted_items.each do |item|
           next if item.data_type == :DERIVED
+
           unique[item.name] ||= []
           unique[item.name] << item
         end
@@ -193,6 +204,7 @@ module Cosmos
         packed = packet.packed?
         packet.sorted_items.each do |item|
           next if item.data_type == :DERIVED
+
           # TODO: Handle nonunique item names
           if item.array_size
             # Requiring parameterRef for argument arrays appears to be a defect in the schema
@@ -262,6 +274,7 @@ module Cosmos
 
     def to_xtce_limits(item, xml)
       return unless item.limits && item.limits.values
+
       item.limits.values.each do |limits_set, limits_values|
         if limits_set == :DEFAULT
           xml['xtce'].DefaultAlarm do
@@ -297,6 +310,7 @@ module Cosmos
             item.states.each do |state_name, state_value|
               # Skip the special COSMOS 'ANY' enumerated state
               next if state_value == 'ANY'
+
               xml['xtce'].Enumeration(:value => state_value, :label => state_name)
             end
           end
@@ -401,7 +415,7 @@ module Cosmos
     def to_xtce_endianness(item, xml)
       if item.endianness == :LITTLE_ENDIAN and item.bit_size > 8
         xml['xtce'].ByteOrderList do
-          (((item.bit_size - 1)/ 8) + 1).times do |byte_significance|
+          (((item.bit_size - 1) / 8) + 1).times do |byte_significance|
             xml['xtce'].Byte(:byteSignificance => byte_significance)
           end
         end

data/lib/cosmos/packets/parsers/xtce_parser.rb

@@ -1,18 +1,26 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'nokogiri'
 require 'ostruct'
 
 module Cosmos
-
   class XtceParser
     attr_accessor :current_target_name
 
@@ -41,7 +49,7 @@ module Cosmos
         cmd_or_tlm_hash[target_name].length.times do |i|
           cmd_or_tlm_hash[target_name].delete(names_to_remove[i])
         end
-        packets.reverse.each do |packet|
+        packets.reverse_each do |packet|
           cmd_or_tlm_hash[target_name][packet.packet_name] = packet
         end
       end
@@ -75,10 +83,10 @@ module Cosmos
 
       # Remove abstract
       if @commands[@current_target_name]
-        @commands[@current_target_name].delete_if {|packet_name, packet| packet.abstract}
+        @commands[@current_target_name].delete_if { |packet_name, packet| packet.abstract }
       end
       if @telemetry[@current_target_name]
-        @telemetry[@current_target_name].delete_if {|packet_name, packet| packet.abstract}
+        @telemetry[@current_target_name].delete_if { |packet_name, packet| packet.abstract }
       end
 
       # Reverse order of packets for the target so ids work correctly
@@ -89,7 +97,7 @@ module Cosmos
     end
 
     # Add current packet into hash if it exists
-    def finish_packet()
+    def finish_packet
       if @current_packet
         @warnings += @current_packet.check_bit_offsets
         set_packet_endianness()
@@ -105,8 +113,11 @@ module Cosmos
 
     def set_packet_endianness
       item_endianness = @current_packet.sorted_items.collect do |item|
+        # Ignore COSMOS reserved items
+        next if Packet::RESERVED_ITEM_NAMES.include?(item.name)
+
         # Strings and Blocks endianness don't matter so ignore them
-        item.endianness if (item.data_type != :STRING && item.data_type != :BLOCK)
+        item.endianness if item.data_type != :STRING && item.data_type != :BLOCK
       end
       # Compact to get rid of nils from skipping Strings and Blocks
       # Uniq to get rid of duplicates which results in an array of 1 or 2 items
@@ -137,7 +148,7 @@ module Cosmos
       element.attributes.each do |att_name, att|
         current_type[att.name] = att.value
       end
-      if element.name =~ /Argument/
+      if /Argument/.match?(element.name)
         @argument_types[element["name"]] = current_type
       else
         @parameter_types[element["name"]] = current_type
@@ -322,6 +333,13 @@ module Cosmos
         end
         @current_type.sizeInBits = 8 unless element.attributes['sizeInBits']
 
+        case element.attributes['byteOrder'].to_s
+        when 'mostSignificantByteFirst'
+          @current_type.endianness = :BIG_ENDIAN
+        when 'leastSignificantByteFirst'
+          @current_type.endianness = :LITTLE_ENDIAN
+        end
+
       when 'Parameter'
         @current_parameter = OpenStruct.new
         element.attributes.each do |att_name, att|
@@ -446,12 +464,14 @@ module Cosmos
 
     def get_object_types(element)
       array_type = nil
-      if element.name =~ /Parameter/
+      if /Parameter/.match?(element.name)
         # Look up the parameter and parameter type
         parameter = @parameters[element['parameterRef']]
         raise "parameterRef #{element['parameterRef']} not found" unless parameter
+
         parameter_type = @parameter_types[parameter.parameterTypeRef]
         raise "parameterTypeRef #{parameter.parameterTypeRef} not found" unless parameter_type
+
         if element.name == 'ArrayParameterRefEntry'
           array_type = parameter_type
           parameter_type = @parameter_types[array_type.arrayTypeRef]
@@ -466,17 +486,22 @@ module Cosmos
           # Requiring parameterRef for argument arrays appears to be a defect in the schema
           argument = @arguments[element['parameterRef']]
           raise "parameterRef #{element['parameterRef']} not found" unless argument
+
           argument_type = @argument_types[argument.argumentTypeRef]
           raise "argumentTypeRef #{argument.argumentTypeRef} not found" unless argument_type
+
           array_type = argument_type
           argument_type = @argument_types[array_type.arrayTypeRef]
           raise "arrayTypeRef #{array_type.arrayTypeRef} not found" unless argument_type
+
           refName = 'parameterRef'
         else
           argument = @arguments[element['argumentRef']]
           raise "argumentRef #{element['argumentRef']} not found" unless argument
+
           argument_type = @argument_types[argument.argumentTypeRef]
           raise "argumentTypeRef #{argument.argumentTypeRef} not found" unless argument_type
+
           refName = 'argumentRef'
         end
         object = argument
@@ -559,12 +584,13 @@ module Cosmos
 
     def set_min_max_default(item, type, data_type)
       return unless @current_cmd_or_tlm == PacketConfig::COMMAND
-        # Need to set min, max, and default
+
+      # Need to set min, max, and default
       if data_type == :INT || data_type == :UINT
         if data_type == :INT
-          item.range = (-(2 ** (Integer(type.sizeInBits) - 1)))..((2 ** (Integer(type.sizeInBits) - 1)) - 1)
+          item.range = (-(2**(Integer(type.sizeInBits) - 1)))..((2**(Integer(type.sizeInBits) - 1)) - 1)
         else
-          item.range = 0..((2 ** Integer(type.sizeInBits)) - 1)
+          item.range = 0..((2**Integer(type.sizeInBits)) - 1)
         end
         if type.minInclusive && type.maxInclusive
           item.range = Integer(type.minInclusive)..Integer(type.maxInclusive)
@@ -616,6 +642,7 @@ module Cosmos
 
     def set_limits(item, type)
       return unless @current_cmd_or_tlm == PacketConfig::TELEMETRY
+
       if type.limits
         item.limits.enabled = true
         values = {}
@@ -637,6 +664,7 @@ module Cosmos
 
     def xtce_recurse_element(element, &block)
       return unless yield(element)
+
       element.children.each do |child_element|
         xtce_recurse_element(child_element, &block)
       end