passagemath-singular 10.6.31rc3__cp314-cp314-musllinux_1_2_x86_64.whl

sage/algebras/quatalg/quaternion_algebra.py

@@ -0,0 +1,4778 @@
+# sage_setup: distribution = sagemath-singular
+"""
+Quaternion Algebras
+
+AUTHORS:
+
+- Jon Bobber (2009): rewrite
+
+- William Stein (2009): rewrite
+
+- Julian Rueth (2014-03-02): use UniqueFactory for caching
+
+- Peter Bruin (2021): do not require the base ring to be a field
+
+- Lorenz Panny (2022): :meth:`QuaternionOrder.isomorphism_to`,
+  :meth:`QuaternionFractionalIdeal_rational.minimal_element`
+
+- Sebastian A. Spindler (2024): extend ramification functionality to number fields,
+  adapt :meth:`QuaternionAlgebra_ab.maximal_order` to allow for extension of an order
+
+- Eloi Torrents (2024): construct quaternion algebras over number fields from ramification
+
+This code is partly based on Sage code by David Kohel from 2005.
+
+TESTS:
+
+Pickling test::
+
+    sage: Q.<i,j,k> = QuaternionAlgebra(QQ,-5,-2)
+    sage: Q == loads(dumps(Q))
+    True
+"""
+
+# ****************************************************************************
+#       Copyright (C) 2009 William Stein <wstein@gmail.com>
+#       Copyright (C) 2009 Jonathan Bober <jwbober@gmail.com>
+#       Copyright (C) 2014 Julian Rueth <julian.rueth@fsfe.org>
+#       Copyright (C) 2021 Peter Bruin <P.J.Bruin@math.leidenuniv.nl>
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 2 of the License, or
+# (at your option) any later version.
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
+from operator import itemgetter
+
+from sage.arith.misc import (hilbert_conductor_inverse,
+                             hilbert_symbol,
+                             gcd,
+                             kronecker as kronecker_symbol,
+                             prime_divisors,
+                             valuation)
+from sage.misc.lazy_import import lazy_import
+from sage.rings.real_mpfr import RR
+from sage.rings.integer import Integer
+from sage.rings.integer_ring import ZZ
+from sage.rings.finite_rings.finite_field_constructor import GF
+from sage.rings.ideal import Ideal_fractional
+from sage.rings.rational_field import RationalField, QQ
+from sage.rings.infinity import infinity
+from sage.rings.number_field.number_field_base import NumberField
+from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
+from sage.rings.polynomial.polynomial_ring import polygen
+from sage.rings.power_series_ring import PowerSeriesRing
+from sage.structure.category_object import normalize_names
+from sage.structure.parent import Parent
+from sage.matrix.matrix_space import MatrixSpace
+from sage.matrix.constructor import diagonal_matrix, matrix
+from sage.structure.sequence import Sequence
+from sage.structure.element import RingElement
+from sage.structure.factory import UniqueFactory
+from sage.modules.free_module import FreeModule
+from sage.modules.free_module_element import vector
+from sage.quadratic_forms.quadratic_form import QuadraticForm
+
+
+from .quaternion_algebra_element import (
+    QuaternionAlgebraElement_abstract,
+    QuaternionAlgebraElement_generic,
+    QuaternionAlgebraElement_rational_field,
+    QuaternionAlgebraElement_number_field)
+from . import quaternion_algebra_cython
+
+
+lazy_import('sage.modular.modsym.p1list', 'P1List')
+
+from sage.misc.cachefunc import cached_method
+from sage.misc.functional import is_odd
+
+from sage.categories.algebras import Algebras
+from sage.categories.number_fields import NumberFields
+
+from sage.structure.richcmp import richcmp_method
+
+########################################################
+# Constructor
+########################################################
+
+
+class QuaternionAlgebraFactory(UniqueFactory):
+    r"""
+    Construct a quaternion algebra.
+
+    INPUT:
+
+    There are four input formats:
+
+    - ``QuaternionAlgebra(a, b)``, where `a` and `b` can be coerced to
+      units in a common field `K` of characteristic different from 2.
+
+    - ``QuaternionAlgebra(K, a, b)``, where `K` is a ring in which 2
+      is a unit and `a` and `b` are units of `K`.
+
+    - ``QuaternionAlgebra(D)``, where `D \ge 1` is a squarefree
+      integer.  This constructs a quaternion algebra of discriminant
+      `D` over `K = \QQ`.  Suitable nonzero rational numbers `a`, `b`
+      as above are deduced from `D`.
+
+    - ``QuaternionAlgebra(K, primes, inv_archimedean)``, where `K` is a
+      number field or `\QQ`, ``primes`` is a list of prime ideals of `K`
+      and ``inv_archimedean`` is a list of local invariants (`0` or
+      `\frac{1}{2}`) specifying the ramification at the (infinite) real
+      places of `K`. This constructs a quaternion algebra ramified exactly
+      at the places given by ``primes`` and those (algebraic) real
+      embeddings of `K` indexed in ``K.embeddings(AA)`` by ``l`` with
+      ``inv_archimedean[l] = 1/2``.
+
+    OUTPUT:
+
+    The quaternion algebra `(a, b)_K` over `K` generated by `i`, `j`
+    subject to `i^2 = a`, `j^2 = b`, and `ji = -ij`.
+
+    EXAMPLES:
+
+    ``QuaternionAlgebra(a, b)`` -- return the quaternion algebra
+    `(a, b)_K`, where the base ring `K` is a suitably chosen field
+    containing `a` and `b`::
+
+        sage: QuaternionAlgebra(-2,-3)
+        Quaternion Algebra (-2, -3) with base ring Rational Field
+        sage: QuaternionAlgebra(GF(5)(2), GF(5)(3))
+        Quaternion Algebra (2, 3) with base ring Finite Field of size 5
+        sage: QuaternionAlgebra(2, GF(5)(3))
+        Quaternion Algebra (2, 3) with base ring Finite Field of size 5
+        sage: QuaternionAlgebra(QQ[sqrt(2)](-1), -5)                                    # needs sage.symbolic
+        Quaternion Algebra (-1, -5) with base ring Number Field in sqrt2
+         with defining polynomial x^2 - 2 with sqrt2 = 1.414213562373095?
+        sage: QuaternionAlgebra(sqrt(-1), sqrt(-3))                                     # needs sage.symbolic
+        Quaternion Algebra (I, sqrt(-3)) with base ring Symbolic Ring
+        sage: QuaternionAlgebra(1r,1)
+        Quaternion Algebra (1, 1) with base ring Rational Field
+        sage: A.<t> = ZZ[]
+        sage: QuaternionAlgebra(-1, t)
+        Quaternion Algebra (-1, t) with base ring
+         Fraction Field of Univariate Polynomial Ring in t over Integer Ring
+
+    Python ints and floats may be passed to the
+    ``QuaternionAlgebra(a, b)`` constructor, as may all pairs of
+    nonzero elements of a domain not of characteristic 2.
+
+    The following tests address the issues raised in :issue:`10601`::
+
+        sage: QuaternionAlgebra(1r,1)
+        Quaternion Algebra (1, 1) with base ring Rational Field
+        sage: QuaternionAlgebra(1,1.0r)
+        Quaternion Algebra (1.00000000000000, 1.00000000000000) with base ring
+         Real Field with 53 bits of precision
+        sage: QuaternionAlgebra(0,0)
+        Traceback (most recent call last):
+        ...
+        ValueError: defining elements of quaternion algebra (0, 0)
+        are not invertible in Rational Field
+        sage: QuaternionAlgebra(GF(2)(1),1)
+        Traceback (most recent call last):
+        ...
+        ValueError: 2 is not invertible in Finite Field of size 2
+        sage: a = PermutationGroupElement([1,2,3])                                      # needs sage.groups
+        sage: QuaternionAlgebra(a, a)                                                   # needs sage.groups
+        Traceback (most recent call last):
+        ...
+        ValueError: a and b must be elements of a ring with characteristic not 2
+
+    ``QuaternionAlgebra(K, a, b)`` -- return the quaternion algebra
+    defined by `(a, b)` over the ring `K`::
+
+        sage: QuaternionAlgebra(QQ, -7, -21)
+        Quaternion Algebra (-7, -21) with base ring Rational Field
+        sage: QuaternionAlgebra(QQ[sqrt(2)], -2,-3)                                     # needs sage.rings.number_field sage.symbolic
+        Quaternion Algebra (-2, -3) with base ring Number Field in sqrt2
+         with defining polynomial x^2 - 2 with sqrt2 = 1.414213562373095?
+
+    ``QuaternionAlgebra(D)`` -- `D` is a squarefree integer; return a
+    rational quaternion algebra of discriminant `D`::
+
+        sage: QuaternionAlgebra(1)
+        Quaternion Algebra (-1, 1) with base ring Rational Field
+        sage: QuaternionAlgebra(2)
+        Quaternion Algebra (-1, -1) with base ring Rational Field
+        sage: QuaternionAlgebra(7)
+        Quaternion Algebra (-1, -7) with base ring Rational Field
+        sage: QuaternionAlgebra(2*3*5*7)
+        Quaternion Algebra (-22, 210) with base ring Rational Field
+
+    ``QuaternionAlgebra(K, primes, inv_archimedean)`` -- return the
+    quaternion algebra over `K` with the ramification specified by
+    ``primes`` and ``inv_archimedean``::
+
+        sage: QuaternionAlgebra(QQ, [(2), (3)], [0])
+        Quaternion Algebra (-1, 3) with base ring Rational Field
+        sage: QuaternionAlgebra(QQ, [(2), (3)], [1/2])
+        Traceback (most recent call last):
+        ...
+        ValueError: quaternion algebra over the rationals must have an even number of ramified places
+
+        sage: x = polygen(ZZ, 'x')
+        sage: K.<w> = NumberField(x^2-x-1)
+        sage: P = K.prime_above(2)
+        sage: Q = K.prime_above(3)
+        sage: A = QuaternionAlgebra(K, [P,Q], [0,0])
+        sage: A.discriminant()
+        Fractional ideal (6)
+        sage: A = QuaternionAlgebra(K, [P,Q], [1/2,0])
+        Traceback (most recent call last):
+        ...
+        ValueError: quaternion algebra over a number field must have an even number of ramified places
+
+    The construction via ramification fails if the base field is not
+    a number field::
+
+        sage: QuaternionAlgebra(RR, [], [])
+        Traceback (most recent call last):
+        ...
+        ValueError: quaternion algebra construction via ramification only works over a number field
+
+    The list of local invariants must specify the ramification data
+    at all real places of the number field `K`::
+
+        sage: QuaternionAlgebra(QuadraticField(5), [], [0])
+        Traceback (most recent call last):
+        ...
+        ValueError: must specify ramification at all real places of the number field
+
+    The list of local invariants specifying the ramification at the
+    real places may only contain `0` and `\frac{1}{2}`::
+
+        sage: QuaternionAlgebra(QuadraticField(5), [], [0,1])
+        Traceback (most recent call last):
+        ...
+        ValueError: list of local invariants specifying ramification should contain only 0 and 1/2
+
+    Similarly, the list of finite ramified places must consist
+    of primes or prime ideals of the number field `K`::
+
+        sage: QuaternionAlgebra(QuadraticField(5), ['water',2], [])
+        Traceback (most recent call last):
+        ...
+        ValueError: quaternion algebra constructor requires a list of primes specifying the ramification
+
+    If the coefficients `a` and `b` in the definition of the quaternion
+    algebra are not integral, then a slower generic type is used for
+    arithmetic::
+
+        sage: type(QuaternionAlgebra(-1,-3).0)
+        <... 'sage.algebras.quatalg.quaternion_algebra_element.QuaternionAlgebraElement_rational_field'>
+        sage: type(QuaternionAlgebra(-1,-3/2).0)
+        <... 'sage.algebras.quatalg.quaternion_algebra_element.QuaternionAlgebraElement_generic'>
+
+    Make sure caching is sane::
+
+        sage: A = QuaternionAlgebra(2,3); A
+        Quaternion Algebra (2, 3) with base ring Rational Field
+        sage: B = QuaternionAlgebra(GF(5)(2),GF(5)(3)); B
+        Quaternion Algebra (2, 3) with base ring Finite Field of size 5
+        sage: A is QuaternionAlgebra(2,3)
+        True
+        sage: B is QuaternionAlgebra(GF(5)(2),GF(5)(3))
+        True
+        sage: Q = QuaternionAlgebra(2); Q
+        Quaternion Algebra (-1, -1) with base ring Rational Field
+        sage: Q is QuaternionAlgebra(QQ,-1,-1)
+        True
+        sage: Q is QuaternionAlgebra(-1,-1)
+        True
+        sage: Q.<ii,jj,kk> = QuaternionAlgebra(15); Q.variable_names()
+        ('ii', 'jj', 'kk')
+        sage: QuaternionAlgebra(15).variable_names()
+        ('i', 'j', 'k')
+
+    TESTS:
+
+    Verify that bug found when working on :issue:`12006` involving coercing
+    invariants into the base field is fixed::
+
+        sage: Q = QuaternionAlgebra(-1,-1); Q
+        Quaternion Algebra (-1, -1) with base ring Rational Field
+        sage: parent(Q._a)
+        Rational Field
+        sage: parent(Q._b)
+        Rational Field
+
+    Check that construction via ramification yields the correct algebra,
+    i.e. that the differences between Sage and PARI are accounted for::
+
+        sage: x = polygen(ZZ, 'x')
+        sage: K.<v> = NumberField(-3*x^5 - 11*x^4 - 4*x^3 + 1)
+        sage: inv_arch = [1/2, 0, 1/2]
+        sage: emb_arch = K.embeddings(AA)[0:3:2]
+        sage: ram = QuaternionAlgebra(K, [], inv_arch).ramified_places()
+        sage: ram[0] == [] and ram[1] == emb_arch
+        True
+
+    Also check that the required Sage-PARI permutation is the correct way
+    around, i.e. that it does not need to be replaced by its inverse::
+
+        sage: x = polygen(ZZ, 'x')
+        sage: K.<j> = NumberField(5*x^4 - 50*x^2 + 5)
+        sage: P = K.prime_above(2)
+        sage: Q = K.prime_above(5)
+        sage: inv_arch = [1/2, 1/2, 0, 0]
+        sage: emb_arch = K.embeddings(AA)[0:2]
+        sage: ram = QuaternionAlgebra(K, [P,Q], inv_arch).ramified_places()
+        sage: set(ram[0]) == set([P,Q]) and ram[1] == emb_arch
+        True
+
+    """
+    def create_key(self, arg0, arg1=None, arg2=None, names='i,j,k'):
+        """
+        Create a key that uniquely determines a quaternion algebra.
+
+        TESTS::
+
+            sage: QuaternionAlgebra.create_key(-1,-1)
+            (Rational Field, -1, -1, ('i', 'j', 'k'))
+        """
+        # QuaternionAlgebra(D)
+        if arg1 is None and arg2 is None:
+            K = QQ
+            D = Integer(arg0)
+            a, b = hilbert_conductor_inverse(D)
+            a = QQ(a)
+            b = QQ(b)
+
+        elif arg2 is None:
+            # If arg0 or arg1 are Python data types, coerce them
+            # to the relevant Sage types. This is a bit inelegant.
+            L = []
+            for a in [arg0, arg1]:
+                if isinstance(a, RingElement):
+                    L.append(a)
+                elif isinstance(a, int):
+                    L.append(Integer(a))
+                elif isinstance(a, float):
+                    L.append(RR(a))
+                else:
+                    raise ValueError("a and b must be elements of a ring with characteristic not 2")
+
+            # QuaternionAlgebra(a, b)
+            v = Sequence(L)
+            K = v.universe().fraction_field()
+            a = K(v[0])
+            b = K(v[1])
+
+        elif isinstance(arg1, list) and isinstance(arg2, list):
+            # QuaternionAlgebra(K, primes, inv_archimedean)
+            K = arg0
+            if K not in NumberFields():
+                raise ValueError("quaternion algebra construction via ramification only works over a number field")
+            if not set(arg2).issubset(set([0, QQ((1,2))])):
+                raise ValueError("list of local invariants specifying ramification should contain only 0 and 1/2")
+
+            # Check that the finite ramification is given by prime ideals
+            try:
+                if isinstance(K, RationalField):
+                    primes = set(ZZ.ideal(p) for p in arg1)
+                else:
+                    primes = set(K.ideal(p) for p in arg1)
+                assert all(p.is_prime() for p in primes)
+            except (AssertionError, TypeError, NameError):
+                raise ValueError("quaternion algebra constructor requires a list of primes specifying the ramification")
+
+            if isinstance(K, RationalField):
+                # Construct the quaternion algebra via ramification over the rationals
+                if len(arg2) > 1 or (len(arg2) == 1 and is_odd(len(primes) + 2*arg2[0])):
+                    raise ValueError("quaternion algebra over the rationals must have an even number of ramified places")
+                D = ZZ.ideal_monoid().prod(primes).gen()
+                a, b = hilbert_conductor_inverse(D)
+                a = QQ(a)
+                b = QQ(b)
+
+            else:
+                # Construct the quaternion algebra via ramification over a number field
+                if len(arg2) != len(K.real_places()):
+                    raise ValueError("must specify ramification at all real places of the number field")
+                if is_odd(len(primes) + 2 * sum(arg2)):
+                    raise ValueError("quaternion algebra over a number field must have an even number of ramified places")
+
+                from sage.combinat.words.word import Word
+                from sage.rings.qqbar import AA
+
+                # We want to compute the correct quaternion algebra over K with PARI
+                # As PARI computes an alternative representation of K given by an integral
+                # and monic defining polynomial, we precompute this representation and then
+                # permute the local invariants (using an isomorphism between the representations)
+                x = polygen(QQ, 'x')
+                g = K.pari_polynomial().sage({'x': x})
+                alpha = g.roots(ring=K, multiplicities=False)[0]
+
+                # Compute the number field PARI actually uses, together with isomorphisms to and from K
+                L, to_K, from_K = K.change_generator(alpha)
+
+                # This computation of the permutation relies on the fact that both
+                # Sage and PARI sort real roots of polynomials in increasing order
+                v = K.gen()
+                vals_embed = [sigma(from_K(v)) for sigma in L.embeddings(AA)]
+                perm = Word(vals_embed).standard_permutation()
+
+                # Transfer the primes to PARI and permute the local invariants
+                fin_places_pari = [I.pari_prime() for I in primes]
+                inv_arch_pari = [arg2[i-1] for i in perm]
+
+                # Compute the correct quaternion algebra over L in PARI
+                A = L.__pari__().alginit([2, [fin_places_pari, [QQ((1,2))] * len(fin_places_pari)],
+                                          inv_arch_pari], flag=0)
+
+                # Obtain representation of A in terms of invariants in L
+                a_L = L(A.algsplittingfield().disc()[1])
+                b_L = L(A.algb())
+
+                # Finally, transfer the result to K
+                a = to_K(a_L)
+                b = to_K(b_L)
+        else:
+            # QuaternionAlgebra(K, a, b)
+            K = arg0
+            a = K(arg1)
+            b = K(arg2)
+
+        if not K(2).is_unit():
+            raise ValueError("2 is not invertible in %s" % K)
+        if not (a.is_unit() and b.is_unit()):
+            raise ValueError("defining elements of quaternion algebra (%s, %s) are not invertible in %s"
+                             % (a, b, K))
+
+        names = normalize_names(3, names)
+        return (K, a, b, names)
+
+    def create_object(self, version, key, **extra_args):
+        """
+        Create the object from the key (extra arguments are ignored). This is
+        only called if the object was not found in the cache.
+
+        TESTS::
+
+            sage: QuaternionAlgebra.create_object("6.0", (QQ, -1, -1, ('i', 'j', 'k')))
+            Quaternion Algebra (-1, -1) with base ring Rational Field
+        """
+        K, a, b, names = key
+        return QuaternionAlgebra_ab(K, a, b, names=names)
+
+
+QuaternionAlgebra = QuaternionAlgebraFactory("QuaternionAlgebra")
+
+########################################################
+# Classes
+########################################################
+
+
+def is_QuaternionAlgebra(A):
+    """
+    Return ``True`` if ``A`` is of the QuaternionAlgebra data type.
+
+    EXAMPLES::
+
+        sage: sage.algebras.quatalg.quaternion_algebra.is_QuaternionAlgebra(QuaternionAlgebra(QQ,-1,-1))
+        doctest:warning...
+        DeprecationWarning: the function is_QuaternionAlgebra is deprecated;
+        use 'isinstance(..., QuaternionAlgebra_abstract)' instead
+        See https://github.com/sagemath/sage/issues/37896 for details.
+        True
+        sage: sage.algebras.quatalg.quaternion_algebra.is_QuaternionAlgebra(ZZ)
+        False
+    """
+    from sage.misc.superseded import deprecation
+    deprecation(37896, "the function is_QuaternionAlgebra is deprecated; use 'isinstance(..., QuaternionAlgebra_abstract)' instead")
+    return isinstance(A, QuaternionAlgebra_abstract)
+
+
+class QuaternionAlgebra_abstract(Parent):
+    def _repr_(self):
+        """
+        EXAMPLES::
+
+            sage: sage.algebras.quatalg.quaternion_algebra.QuaternionAlgebra_abstract(QQ)._repr_()
+            'Quaternion Algebra with base ring Rational Field'
+        """
+        return "Quaternion Algebra with base ring %s" % self.base_ring()
+
+    def ngens(self):
+        """
+        Return the number of generators of the quaternion algebra as a K-vector
+        space, not including 1.
+
+        This value is always 3: the algebra is spanned
+        by the standard basis `1`, `i`, `j`, `k`.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ,-5,-2)
+            sage: Q.ngens()
+            3
+            sage: Q.gens()
+            (i, j, k)
+        """
+        return 3
+
+    @cached_method
+    def basis(self):
+        """
+        Return the fixed basis of ``self``, which is `1`, `i`, `j`, `k`, where
+        `i`, `j`, `k` are the generators of ``self``.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ,-5,-2)
+            sage: Q.basis()
+            (1, i, j, k)
+
+            sage: Q.<xyz,abc,theta> = QuaternionAlgebra(GF(9,'a'),-5,-2)
+            sage: Q.basis()
+            (1, xyz, abc, theta)
+
+        The basis is cached::
+
+            sage: Q.basis() is Q.basis()
+            True
+        """
+        i, j, k = self.gens()
+        return (self.one(), i, j, k)
+
+    @cached_method
+    def inner_product_matrix(self):
+        """
+        Return the inner product matrix associated to ``self``.
+
+        This is the
+        Gram matrix of the reduced norm as a quadratic form on ``self``.
+        The standard basis `1`, `i`, `j`, `k` is orthogonal, so this matrix
+        is just the diagonal matrix with diagonal entries `2`, `-2a`, `-2b`,
+        `2ab`.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-5,-19)
+            sage: Q.inner_product_matrix()
+            [  2   0   0   0]
+            [  0  10   0   0]
+            [  0   0  38   0]
+            [  0   0   0 190]
+        """
+        a, b = self._a, self._b
+        M = diagonal_matrix(self.base_ring(), [2, -2 * a, -2 * b, 2 * a * b])
+        M.set_immutable()
+        return M
+
+    def is_commutative(self) -> bool:
+        """
+        Return ``False`` always, since all quaternion algebras are
+        noncommutative.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -3,-7)
+            sage: Q.is_commutative()
+            False
+        """
+        return False
+
+    def is_division_algebra(self) -> bool:
+        """
+        Check whether this quaternion algebra is a division algebra,
+        i.e. whether every nonzero element in it is invertible.
+
+        Currently only implemented for quaternion algebras
+        defined over a number field.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(QQ,-5,-2).is_division_algebra()
+            True
+            sage: QuaternionAlgebra(2,9).is_division_algebra()
+            False
+            sage: K.<z> = QuadraticField(3)
+            sage: QuaternionAlgebra(K, 1+z, 3-z).is_division_algebra()
+            False
+
+        By checking ramification, the method correctly recognizes division
+        quaternion algebras over a number field even if they have trivial
+        discriminant::
+
+            sage: L = QuadraticField(5)
+            sage: A = QuaternionAlgebra(L, -1, -1)
+            sage: A.discriminant()
+            Fractional ideal (1)
+            sage: A.is_division_algebra()
+            True
+
+        The method is not implemented over arbitrary base rings yet::
+
+            sage: QuaternionAlgebra(RR(2.),1).is_division_algebra()
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: base ring must be rational numbers or a number field
+        """
+        try:
+            return self.ramified_places(inf=True) != ([], [])
+        except ValueError:
+            raise NotImplementedError("base ring must be rational numbers or a number field")
+
+    def is_matrix_ring(self) -> bool:
+        """
+        Check whether this quaternion algebra is isomorphic to the
+        2x2 matrix ring over the base ring.
+
+        Currently only implemented for quaternion algebras
+        defined over a number field.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(QQ,-5,-2).is_matrix_ring()
+            False
+            sage: QuaternionAlgebra(2,9).is_matrix_ring()
+            True
+            sage: K.<z> = QuadraticField(3)
+            sage: QuaternionAlgebra(K, 1+z, 3-z).is_matrix_ring()
+            True
+
+        By checking ramification, the method is able to recognize that
+        quaternion algebras (defined over a number field) with trivial
+        discriminant need not be matrix rings::
+
+            sage: L = QuadraticField(5)
+            sage: A = QuaternionAlgebra(L, -1, -1)
+            sage: A.discriminant()
+            Fractional ideal (1)
+            sage: A.is_matrix_ring()
+            False
+
+        The method is not implemented over arbitrary base rings yet::
+
+            sage: QuaternionAlgebra(RR(2.),1).is_matrix_ring()
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: base ring must be rational numbers or a number field
+        """
+        try:
+            return self.ramified_places(inf=True) == ([], [])
+        except ValueError:
+            raise NotImplementedError("base ring must be rational numbers or a number field")
+
+    def is_exact(self) -> bool:
+        """
+        Return ``True`` if elements of this quaternion algebra are represented
+        exactly, i.e. there is no precision loss when doing arithmetic. A
+        quaternion algebra is exact if and only if its base field is
+        exact.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -3, -7)
+            sage: Q.is_exact()
+            True
+            sage: Q.<i,j,k> = QuaternionAlgebra(Qp(7), -3, -7)
+            sage: Q.is_exact()
+            False
+        """
+        return self.base_ring().is_exact()
+
+    def is_field(self, proof=True) -> bool:
+        """
+        Return ``False`` always, since all quaternion algebras are
+        noncommutative and all fields are commutative.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -3, -7)
+            sage: Q.is_field()
+            False
+        """
+        return False
+
+    def is_finite(self) -> bool:
+        """
+        Return ``True`` if the quaternion algebra is finite as a set.
+
+        Algorithm: A quaternion algebra is finite if and only if the
+        base field is finite.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -3, -7)
+            sage: Q.is_finite()
+            False
+            sage: Q.<i,j,k> = QuaternionAlgebra(GF(5), -3, -7)
+            sage: Q.is_finite()
+            True
+        """
+        return self.base_ring().is_finite()
+
+    def is_integral_domain(self, proof=True) -> bool:
+        """
+        Return ``False`` always, since all quaternion algebras are
+        noncommutative and integral domains are commutative (in Sage).
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -3, -7)
+            sage: Q.is_integral_domain()
+            False
+        """
+        return False
+
+    def is_noetherian(self) -> bool:
+        """
+        Return ``True`` always, since any quaternion algebra is a Noetherian
+        ring (because it is a finitely generated module over a field).
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -3, -7)
+            sage: Q.is_noetherian()
+            True
+        """
+        return True
+
+    def order(self):
+        """
+        Return the number of elements of the quaternion algebra, or
+        ``+Infinity`` if the algebra is not finite.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ, -3, -7)
+            sage: Q.order()
+            +Infinity
+            sage: Q.<i,j,k> = QuaternionAlgebra(GF(5), -3, -7)
+            sage: Q.order()
+            625
+        """
+        return (self.base_ring().order())**4
+
+    def random_element(self, *args, **kwds):
+        """
+        Return a random element of this quaternion algebra.
+
+        The ``args`` and ``kwds`` are passed to the ``random_element`` method
+        of the base ring.
+
+        EXAMPLES::
+
+            sage: g = QuaternionAlgebra(QQ[sqrt(2)], -3, 7).random_element()            # needs sage.symbolic
+            sage: g.parent() is QuaternionAlgebra(QQ[sqrt(2)], -3, 7)                   # needs sage.symbolic
+            True
+            sage: g = QuaternionAlgebra(-3, 19).random_element()
+            sage: g.parent() is QuaternionAlgebra(-3, 19)
+            True
+            sage: g = QuaternionAlgebra(GF(17)(2), 3).random_element()
+            sage: g.parent() is QuaternionAlgebra(GF(17)(2), 3)
+            True
+
+        Specify the numerator and denominator bounds::
+
+            sage: g = QuaternionAlgebra(-3,19).random_element(10^6, 10^6)
+            sage: for h in g:
+            ....:     assert h.numerator() in range(-10^6, 10^6 + 1)
+            ....:     assert h.denominator() in range(10^6 + 1)
+
+            sage: g = QuaternionAlgebra(-3,19).random_element(5, 4)
+            sage: for h in g:
+            ....:     assert h.numerator() in range(-5, 5 + 1)
+            ....:     assert h.denominator() in range(4 + 1)
+        """
+        K = self.base_ring()
+        return self([K.random_element(*args, **kwds) for _ in range(4)])
+
+    @cached_method
+    def free_module(self):
+        """
+        Return the free module associated to ``self`` with inner
+        product given by the reduced norm.
+
+        EXAMPLES::
+
+            sage: A.<t> = LaurentPolynomialRing(GF(3))
+            sage: B = QuaternionAlgebra(A, -1, t)
+            sage: B.free_module()
+            Ambient free quadratic module of rank 4 over the principal ideal domain
+             Univariate Laurent Polynomial Ring in t over Finite Field of size 3
+             Inner product matrix:
+              [2 0 0 0]
+              [0 2 0 0]
+              [0 0 t 0]
+              [0 0 0 t]
+        """
+        return FreeModule(self.base_ring(), 4, inner_product_matrix=self.inner_product_matrix())
+
+    def vector_space(self):
+        """
+        Alias for :meth:`free_module`.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-3,19).vector_space()
+            Ambient quadratic space of dimension 4 over Rational Field
+            Inner product matrix:
+              [   2    0    0    0]
+              [   0    6    0    0]
+              [   0    0  -38    0]
+              [   0    0    0 -114]
+        """
+        return self.free_module()
+
+
+class QuaternionAlgebra_ab(QuaternionAlgebra_abstract):
+    """
+    A quaternion algebra of the form `(a, b)_K`.
+
+    See ``QuaternionAlgebra`` for many more examples.
+
+    INPUT:
+
+    - ``base_ring`` -- a commutative ring `K` in which 2 is invertible
+    - ``a``, ``b`` -- units of `K`
+    - ``names`` -- string (default: ``'i,j,k'``); names of the generators
+
+    OUTPUT:
+
+    The quaternion algebra `(a, b)` over `K` generated by `i` and `j`
+    subject to `i^2 = a`, `j^2 = b`, and `ji = -ij`.
+
+    EXAMPLES::
+
+        sage: QuaternionAlgebra(QQ, -7, -21)  # indirect doctest
+        Quaternion Algebra (-7, -21) with base ring Rational Field
+    """
+    def __init__(self, base_ring, a, b, names='i,j,k'):
+        """
+        Create the quaternion algebra with `i^2 = a`, `j^2 = b`, and
+        `ij = -ji = k`.
+
+        TESTS:
+
+        Test making quaternion elements (using the element constructor)::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ,-1,-2)
+            sage: a = Q(2/3); a
+            2/3
+            sage: type(a)
+            <... 'sage.algebras.quatalg.quaternion_algebra_element.QuaternionAlgebraElement_rational_field'>
+            sage: Q(a)
+            2/3
+            sage: Q([1,2,3,4])
+            1 + 2*i + 3*j + 4*k
+            sage: Q((1,2,3,4))
+            1 + 2*i + 3*j + 4*k
+            sage: Q(-3/5)
+            -3/5
+
+            sage: TestSuite(Q).run()
+
+        The element 2 must be a unit in the base ring::
+
+            sage: Q.<ii,jj,kk> = QuaternionAlgebra(ZZ,-5,-19)
+            Traceback (most recent call last):
+            ...
+            ValueError: 2 is not invertible in Integer Ring
+        """
+        cat = Algebras(base_ring).Division().FiniteDimensional()
+        Parent.__init__(self, base=base_ring, names=names, category=cat)
+        self._a = a
+        self._b = b
+        if isinstance(base_ring, RationalField) and a.denominator() == 1 == b.denominator():
+            self.Element = QuaternionAlgebraElement_rational_field
+        elif (isinstance(base_ring, NumberField) and base_ring.degree() > 2 and base_ring.is_absolute() and
+              a.denominator() == 1 == b.denominator() and base_ring.defining_polynomial().is_monic()):
+            # This QuaternionAlgebraElement_number_field class is not
+            # designed to work with elements of a quadratic field.  To
+            # do that, the main thing would be to implement
+            # __getitem__, etc.  This would maybe give a factor of 2
+            # (or more?) speedup.  Much care must be taken because the
+            # underlying representation of quadratic fields is a bit
+            # tricky.
+            self.Element = QuaternionAlgebraElement_number_field
+        else:
+            self.Element = QuaternionAlgebraElement_generic
+        self._populate_coercion_lists_(coerce_list=[base_ring])
+        self._gens = (self([0, 1, 0, 0]), self([0, 0, 1, 0]), self([0, 0, 0, 1]))
+
+    @cached_method
+    def maximal_order(self, take_shortcuts=True, order_basis=None):
+        r"""
+        Return a maximal order in this quaternion algebra.
+
+        If ``order_basis`` is specified, the resulting maximal order
+        will contain the order of the quaternion algebra given by this
+        basis. The algorithm used is from [Voi2012]_.
+
+        INPUT:
+
+        - ``take_shortcuts`` -- boolean (default: ``True``); if the discriminant is
+          prime and the invariants of the algebra are of a nice form, use
+          Proposition 5.2 of [Piz1980]_.
+
+        - ``order_basis`` -- (default: ``None``) a basis of an
+          order of this quaternion algebra
+
+        OUTPUT: a maximal order in this quaternion algebra
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-1,-7).maximal_order()
+            Order of Quaternion Algebra (-1, -7) with base ring Rational Field
+             with basis (1/2 + 1/2*j, 1/2*i + 1/2*k, j, k)
+
+            sage: QuaternionAlgebra(-1,-1).maximal_order().basis()
+            (1/2 + 1/2*i + 1/2*j + 1/2*k, i, j, k)
+
+            sage: QuaternionAlgebra(-1,-11).maximal_order().basis()
+            (1/2 + 1/2*j, 1/2*i + 1/2*k, j, k)
+
+            sage: QuaternionAlgebra(-1,-3).maximal_order().basis()
+            (1/2 + 1/2*j, 1/2*i + 1/2*k, j, k)
+
+            sage: QuaternionAlgebra(-3,-1).maximal_order().basis()
+            (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+
+            sage: QuaternionAlgebra(-2,-5).maximal_order().basis()
+            (1/2 + 1/2*j + 1/2*k, 1/4*i + 1/2*j + 1/4*k, j, k)
+
+            sage: QuaternionAlgebra(-5,-2).maximal_order().basis()
+            (1/2 + 1/2*i - 1/2*k, 1/2*i + 1/4*j - 1/4*k, i, -k)
+
+            sage: QuaternionAlgebra(-17,-3).maximal_order().basis()
+            (1/2 + 1/2*j, 1/2*i + 1/2*k, -1/3*j - 1/3*k, k)
+
+            sage: QuaternionAlgebra(-3,-17).maximal_order().basis()
+            (1/2 + 1/2*i, 1/2*j - 1/2*k, -1/3*i + 1/3*k, -k)
+
+            sage: QuaternionAlgebra(-17*9,-3).maximal_order().basis()
+            (1, 1/3*i, 1/6*i + 1/2*j, 1/2 + 1/3*j + 1/18*k)
+
+            sage: QuaternionAlgebra(-2, -389).maximal_order().basis()
+            (1/2 + 1/2*j + 1/2*k, 1/4*i + 1/2*j + 1/4*k, j, k)
+
+        If you want bases containing 1, switch off ``take_shortcuts``::
+
+            sage: QuaternionAlgebra(-3,-89).maximal_order(take_shortcuts=False)
+            Order of Quaternion Algebra (-3, -89) with base ring Rational Field
+             with basis (1, 1/2 + 1/2*i, j, 1/2 + 1/6*i + 1/2*j + 1/6*k)
+
+            sage: QuaternionAlgebra(1,1).maximal_order(take_shortcuts=False)    # Matrix ring
+            Order of Quaternion Algebra (1, 1) with base ring Rational Field
+             with basis (1, 1/2 + 1/2*i, j, 1/2*j + 1/2*k)
+
+            sage: QuaternionAlgebra(-22,210).maximal_order(take_shortcuts=False)
+            Order of Quaternion Algebra (-22, 210) with base ring Rational Field
+             with basis (1, i, 1/2*i + 1/2*j, 1/2 + 17/22*i + 1/44*k)
+
+            sage: for d in ( m for m in range(1, 750) if is_squarefree(m) ):        # long time (3s)
+            ....:     A = QuaternionAlgebra(d)
+            ....:     assert A.maximal_order(take_shortcuts=False).is_maximal()
+
+        Specifying an order basis gives an extension of orders::
+
+            sage: A.<i,j,k> = QuaternionAlgebra(-292, -732)
+            sage: alpha = A.random_element()
+            sage: while alpha.is_zero():
+            ....:     alpha = A.random_element()
+            sage: conj = [alpha * b * alpha.inverse() for b in [k,i,j]]
+            sage: order_basis = tuple(conj) + (A.one(),)
+            sage: O = A.quaternion_order(basis=order_basis)
+            sage: R = A.maximal_order(order_basis=order_basis)
+            sage: O <= R and R.is_maximal()
+            True
+
+        We do not support number fields other than the rationals yet::
+
+            sage: K = QuadraticField(5)
+            sage: QuaternionAlgebra(K,-1,-1).maximal_order()
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: maximal order only implemented
+            for rational quaternion algebras
+
+        TESTS:
+
+        Check that :issue:`37417` and the first part of :issue:`37217` are fixed::
+
+            sage: invars = [(-4, -28), (-292, -732), (-48, -564), (-436, -768),
+            ....:           (-752, -708), (885, 545), (411, -710), (-411, 593),
+            ....:           (805, -591), (-921, 353), (409, 96), (394, 873),
+            ....:           (353, -722), (730, 830), (-466, -427), (-213, -630),
+            ....:           (-511, 608), (493, 880), (105, -709), (-213, 530),
+            ....:           (97, 745)]
+            sage: all(QuaternionAlgebra(a, b).maximal_order().is_maximal()
+            ....:     for (a, b) in invars)
+            True
+        """
+        if self.base_ring() != QQ:
+            raise NotImplementedError("maximal order only implemented for "
+                                      "rational quaternion algebras")
+
+        d_A = self.discriminant()
+
+        # The following only works over QQ if the discriminant is prime
+        # and if the invariants are of the special form
+        # (every quaternion algebra of prime discriminant has a representation
+        #  of such a form though)
+        a, b = self.invariants()
+        if (not order_basis and take_shortcuts and d_A.is_prime()
+            and a in ZZ and b in ZZ):
+            a = ZZ(a)
+            b = ZZ(b)
+            i, j, k = self.gens()
+
+            # if necessary, try to swap invariants to match Pizer's paper
+            if (a != -1 and b == -1) or (b == -2) \
+               or (a != -1 and a != -2 and (-a) % 8 != 1):
+                a, b = b, a
+                i, j = j, i
+                k = i * j
+
+            basis = []
+            if (a, b) == (-1, -1):
+                basis = [(1+i+j+k)/2, i, j, k]
+            elif a == -1 and (-b).is_prime() and ((-b) % 4 == 3):
+                basis = [(1+j)/2, (i+k)/2, j, k]
+            elif a == -2 and (-b).is_prime() and ((-b) % 8 == 5):
+                basis = [(1+j+k)/2, (i+2*j+k)/4, j, k]
+            elif (-a).is_prime() and (-b).is_prime():
+                q = -b
+                p = -a
+
+                if q % 4 == 3 and kronecker_symbol(p, q) == -1:
+                    a = 0
+                    while (a * a * p + 1) % q:
+                        a += 1
+                    basis = [(1+j)/2, (i+k)/2, -(j+a*k)/q, k]
+
+            if basis:
+                return self.quaternion_order(basis)
+
+        # The following code should always work (over QQ)
+        # If no order basis is given, start with <1,i,j,k>
+        if not order_basis:
+            order_basis = (self.one(),) + self.gens()
+
+        try:
+            R = self.quaternion_order(order_basis)
+            d_R = R.discriminant()
+        except (TypeError, ValueError):
+            raise ValueError('order_basis is not a basis of an order of the'
+                            ' given quaternion algebra')
+
+        # Since Voight's algorithm only works for a starting basis having 1 as
+        # its first vector, we derive such a basis from the given order basis
+        basis = basis_for_quaternion_lattice(order_basis)
+
+        e_new_gens = []
+
+        # For each prime at which R is not yet maximal, make it bigger
+        for p, _ in d_R.factor():
+            e = basis
+            disc = d_R
+            while disc.valuation(p) > d_A.valuation(p):
+                # Compute a normalized basis at p
+                f = normalize_basis_at_p(list(e), p)
+
+                # Ensure the basis lies in R by clearing denominators
+                # (this may make the order smaller at q != p)
+                # Also saturate the basis (divide out p as far as possible)
+                V = self.base_ring()**4
+                A = matrix(self.base_ring(), 4, 4, [list(g) for g in e])
+
+                e_n = []
+                x_rows = A.solve_left(matrix([V(vec.coefficient_tuple())
+                                              for (vec, val) in f]),
+                                      check=False).rows()
+                denoms = [x.denominator() for x in x_rows]
+                for i in range(4):
+                    vec = f[i][0]
+                    val = f[i][1]
+
+                    v = (val/2).floor()
+                    e_n.append(denoms[i] / p**(v) * vec)
+
+                # for e_n to become p-saturated we still need to sort by
+                # ascending valuation of the quadratic form
+                lst = sorted(zip(e_n, [f[m][1].mod(2) for m in range(4)]),
+                             key=itemgetter(1))
+                e_n = list(next(zip(*lst)))
+
+                # Final step: Enlarge the basis at p
+                if p != 2:
+                    # ensure that v_p(e_n[1]**2) = 0 by swapping basis elements
+                    if ZZ(e_n[1]**2).valuation(p) != 0:
+                        if ZZ(e_n[2]**2).valuation(p) == 0:
+                            e_n[1], e_n[2] = e_n[2], e_n[1]
+                        else:
+                            e_n[1], e_n[3] = e_n[3], e_n[1]
+
+                    a = ZZ(e_n[1]**2)
+                    b = ZZ(e_n[2]**2)
+
+                    if b.valuation(p) > 0:      # if v_p(b) = 0, then already p-maximal
+                        F = ZZ.quo(p)
+                        if F(a).is_square():
+                            x = F(a).sqrt().lift()
+                            if (x**2 - a).mod(p**2) == 0:  # make sure v_p(x**2 - a) = 1
+                                x = x + p
+                            g = 1/p*(x - e_n[1])*e_n[2]
+                            e_n[2] = g
+                            e_n[3] = e_n[1]*g
+
+                else:   # p == 2
+                    t = e_n[1].reduced_trace()
+                    a = -e_n[1].reduced_norm()
+                    b = ZZ(e_n[2]**2)
+
+                    if t.valuation(p) == 0:
+                        if b.valuation(p) > 0:
+                            x = a
+                            if (x**2 - t*x + a).mod(p**2) == 0:  # make sure v_p(...) = 1
+                                x = x + p
+                            g = 1/p*(x - e_n[1])*e_n[2]
+                            e_n[2] = g
+                            e_n[3] = e_n[1]*g
+
+                    else:   # t.valuation(p) > 0
+                        (y, z, w) = maxord_solve_aux_eq(a, b, p)
+                        g = 1/p*(1 + y*e_n[1] + z*e_n[2] + w*e_n[1]*e_n[2])
+                        h = (z*b)*e_n[1] - (y*a)*e_n[2]
+                        e_n[1:4] = [g, h, g * h]
+                        if (1 - a*y**2 - b*z**2 + a*b*w**2).valuation(2) > 2:
+                            e_n = basis_for_quaternion_lattice(list(e) + e_n[1:])
+
+                # e_n now contains elements that locally at p give a bigger order,
+                # but the basis may be messed up at other primes (it might not
+                # even be an order). We will join them all together at the end
+                e = e_n
+
+                # Since e might not define an order at this point, we need to
+                # manually calculate the updated discriminant
+                L = [[x.pair(y) for y in e] for x in e]
+                disc = matrix(QQ, 4, 4, L).determinant().sqrt()
+
+            e_new_gens.extend(e[1:])
+
+        e_new = basis_for_quaternion_lattice(list(basis) + e_new_gens)
+        return self.quaternion_order(e_new)
+
+    def order_with_level(self, level):
+        """
+        Return an order in this quaternion algebra with given level.
+
+        INPUT:
+
+        - ``level`` -- positive integer
+
+        Currently this is only implemented when the base field is the
+        rational numbers and the level is divisible by at most one
+        power of a prime that ramifies in this quaternion algebra.
+
+        EXAMPLES::
+
+            sage: A.<i,j,k> = QuaternionAlgebra(5)
+            sage: level = 2 * 5 * 17
+            sage: O = A.order_with_level(level); O
+            Order of Quaternion Algebra (-2, -5) with base ring Rational Field with basis (1/2 + 1/2*j + 7/2*k, 1/2*i + 19/2*k, j + 7*k, 17*k)
+
+        Check that the order has the right index in the maximal order::
+
+            sage: L = O.free_module()
+            sage: N = A.maximal_order().free_module()
+            sage: L.index_in(N) == level / 5
+            True
+        """
+        if self.base_ring() is not QQ:
+            raise NotImplementedError("base field must be rational numbers")
+
+        if len(self.ramified_primes()) > 1:
+            raise NotImplementedError("currently this algorithm only works when the quaternion algebra is only ramified at one finite prime")
+
+        # The algorithm we use is similar to that in Magma (by David Kohel).
+        level = abs(level)
+        N = self.discriminant()
+        N1 = gcd(level, N)
+        M1 = level // N1
+
+        O = self.maximal_order()
+        # if N1 != 1:
+        #     # we do not know why magma does the following, so we do not do it.
+        #     for p in self.ramified_primes():
+        #         if not (level % p**2):
+        #             raise NotImplementedError("currently sage can only compute orders whose level is divisible by at most one power of any prime that ramifies in the quaternion algebra")
+
+        #     P = O._left_ideal_basis([N1] + [x * y - y * x
+        #                                     for x in self.basis()
+        #                                     for y in self.basis()])
+        #     O = self.quaternion_order(P)
+
+        fact = M1.factor()
+        B = O.basis()
+
+        for (p, r) in fact:
+            a = int(-p) // 2
+            for v in GF(p)**4:
+                x = sum([int(v[i] + a) * B[i] for i in range(4)])
+                D = x.reduced_trace()**2 - 4 * x.reduced_norm()
+                # x = O.random_element((-p/2).floor(), (p/2).ceil())
+                if kronecker_symbol(D, p) == 1:
+                    break
+            X = PolynomialRing(GF(p), 'x').gen()
+            a = ZZ((X**2 - ZZ(x.reduced_trace()) * X + ZZ(x.reduced_norm())).roots()[0][0])
+            I = O._left_ideal_basis([p**r, (x - a)**r])
+            O = O._right_order_from_ideal_basis(I)
+            # right_order returns the RightOrder of I inside O, so we
+            # do not need to do another intersection
+
+        return O
+
+    def invariants(self):
+        """
+        Return the structural invariants `a`, `b` of this quaternion
+        algebra: ``self`` is generated by `i`, `j` subject to
+        `i^2 = a`, `j^2 = b` and `ji = -ij`.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(15)
+            sage: Q.invariants()
+            (-3, 5)
+            sage: i^2
+            -3
+            sage: j^2
+            5
+        """
+        return self._a, self._b
+
+    def __eq__(self, other):
+        """
+        Compare ``self`` and ``other``.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-1,-7) == QuaternionAlgebra(-1,-7)
+            True
+            sage: QuaternionAlgebra(-1,-7) == QuaternionAlgebra(-1,-5)
+            False
+        """
+        if not isinstance(other, QuaternionAlgebra_abstract):
+            return False
+        return (self.base_ring() == other.base_ring() and
+                (self._a, self._b) == (other._a, other._b))
+
+    def __ne__(self, other):
+        """
+        Compare ``self`` and ``other``.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-1,-7) != QuaternionAlgebra(-1,-7)
+            False
+            sage: QuaternionAlgebra(-1,-7) != QuaternionAlgebra(-1,-5)
+            True
+        """
+        return not self.__eq__(other)
+
+    def __hash__(self):
+        """
+        Compute the hash of ``self``.
+
+        EXAMPLES::
+
+            sage: h1 = hash(QuaternionAlgebra(-1,-7))
+            sage: h2 = hash(QuaternionAlgebra(-1,-7))
+            sage: h3 = hash(QuaternionAlgebra(-1,-5))
+            sage: h1  == h2 and h1 != h3
+            True
+        """
+        return hash((self.base_ring(), self._a, self._b))
+
+    def gen(self, i=0):
+        """
+        Return the `i`-th generator of ``self``.
+
+        INPUT:
+
+        - ``i`` -- integer (default: 0)
+
+        EXAMPLES::
+
+            sage: Q.<ii,jj,kk> = QuaternionAlgebra(QQ,-1,-2); Q
+            Quaternion Algebra (-1, -2) with base ring Rational Field
+            sage: Q.gen(0)
+            ii
+            sage: Q.gen(1)
+            jj
+            sage: Q.gen(2)
+            kk
+            sage: Q.gens()
+            (ii, jj, kk)
+        """
+        return self._gens[i]
+
+    def gens(self) -> tuple:
+        """
+        Return the generators of ``self``.
+
+        EXAMPLES::
+
+            sage: Q.<ii,jj,kk> = QuaternionAlgebra(QQ,-1,-2); Q
+            Quaternion Algebra (-1, -2) with base ring Rational Field
+            sage: Q.gens()
+            (ii, jj, kk)
+        """
+        return self._gens
+
+    def _repr_(self):
+        """
+        Print representation.
+
+        TESTS::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(QQ,-5,-2)
+            sage: type(Q)
+            <class 'sage.algebras.quatalg.quaternion_algebra.QuaternionAlgebra_ab_with_category'>
+            sage: Q._repr_()
+            'Quaternion Algebra (-5, -2) with base ring Rational Field'
+            sage: Q
+            Quaternion Algebra (-5, -2) with base ring Rational Field
+            sage: print(Q)
+            Quaternion Algebra (-5, -2) with base ring Rational Field
+            sage: str(Q)
+            'Quaternion Algebra (-5, -2) with base ring Rational Field'
+        """
+        return "Quaternion Algebra (%r, %r) with base ring %s" % (self._a, self._b, self.base_ring())
+
+    def inner_product_matrix(self):
+        """
+        Return the inner product matrix associated to ``self``, i.e. the
+        Gram matrix of the reduced norm as a quadratic form on ``self``.
+        The standard basis `1`, `i`, `j`, `k` is orthogonal, so this matrix
+        is just the diagonal matrix with diagonal entries `1`, `a`, `b`, `ab`.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-5,-19)
+            sage: Q.inner_product_matrix()
+            [  2   0   0   0]
+            [  0  10   0   0]
+            [  0   0  38   0]
+            [  0   0   0 190]
+
+            sage: R.<a,b> = QQ[]; Q.<i,j,k> = QuaternionAlgebra(Frac(R),a,b)
+            sage: Q.inner_product_matrix()
+            [    2     0     0     0]
+            [    0  -2*a     0     0]
+            [    0     0  -2*b     0]
+            [    0     0     0 2*a*b]
+        """
+        a, b = self._a, self._b
+        return diagonal_matrix(self.base_ring(), [2, -2*a, -2*b, 2*a*b])
+
+    def is_definite(self):
+        r"""
+        Check whether this quaternion algebra is definite.
+
+        A quaternion algebra over `\QQ` is definite if it ramifies at the
+        unique real place of `\QQ`, which happens if and only if both of
+        its invariants are negative (see Exercise 2.4(c) in [Voi2021]_).
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(QQ,-5,-2).is_definite()
+            True
+            sage: QuaternionAlgebra(1).is_definite()
+            False
+
+        The method does not make sense over an arbitrary base ring::
+
+            sage: QuaternionAlgebra(RR(2.), 1).is_definite()
+            Traceback (most recent call last):
+            ...
+            ValueError: base field must be rational numbers
+        """
+        if not isinstance(self.base_ring(), RationalField):
+            raise ValueError("base field must be rational numbers")
+        a, b = self.invariants()
+        return a < 0 and b < 0
+
+    def is_totally_definite(self):
+        """
+        Check whether this quaternion algebra is totally definite.
+
+        A quaternion algebra defined over a number field is
+        totally definite if it ramifies at all Archimedean
+        places of its base field. In particular, the base number
+        field has to be totally real (see 14.5.8 in [Voi2021]_).
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(QQ, -5, -2).is_totally_definite()
+            True
+
+            sage: K = QuadraticField(3)
+            sage: QuaternionAlgebra(K, -1, -1).is_totally_definite()
+            True
+
+        We can also use number field elements as invariants::
+
+            sage: x = polygen(ZZ, 'x')
+            sage: F.<a> = NumberField(x^2 - x - 1)
+            sage: QuaternionAlgebra(F, 2*a, F(-1)).is_totally_definite()
+            False
+
+        The method does not make sense over an arbitrary base ring::
+
+            sage: QuaternionAlgebra(RR(2.), 1).is_totally_definite()
+            Traceback (most recent call last):
+            ...
+            ValueError: base field must be rational numbers or a number field
+        """
+        F = self.base_ring()
+        if isinstance(F, RationalField):
+            return self.is_definite()
+
+        if F not in NumberFields():
+            raise ValueError("base field must be rational numbers or a number field")
+
+        from sage.rings.qqbar import AA
+
+        # Since we need the list of real embeddings of the number field (instead
+        # of just the number of them), we avoid a call of the `is_totally_real()`-
+        # method by directly comparing the embedding list's length to the degree
+        E = F.embeddings(AA)
+        return len(E) == F.degree() and all(F.hilbert_symbol(self._a, self._b, e) == -1
+                                            for e in E)
+
+    @cached_method
+    def ramified_places(self, inf=True):
+        r"""
+        Return the places of the base number field at which this
+        quaternion algebra ramifies.
+
+        INPUT:
+
+        - ``inf`` -- bool (default: ``True``)
+
+        OUTPUT:
+
+        The non-Archimedean (AKA finite) places at which this quaternion
+        algebra ramifies, given as
+
+        - elements of `\ZZ` (sorted small to large) if the base field is `\QQ`,
+
+        - integral fractional ideals of the base number field, otherwise.
+
+        Additionally, if ``inf`` is set to ``True``, then the Archimedean
+        (AKA infinite) places at which the quaternion algebra ramifies are
+        also returned, given as
+
+        - the embeddings of `\QQ` into `\RR` if the base field is `\QQ`, or
+
+        - the embeddings of the base number field into the Algebraic Real Field.
+
+        .. NOTE::
+
+            Any Archimedean place at which a quaternion algebra ramifies
+            has to be real (see 14.5.8 in [Voi2021]_).
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(210,-22).ramified_places()
+            ([2, 3, 5, 7], [])
+
+        For a definite quaternion algebra we get ramification at the
+        unique infinite place of `\QQ`::
+
+            sage: QuaternionAlgebra(-1, -1).ramified_places()
+            ([2],
+             [Ring morphism:
+                From: Rational Field
+                To:   Real Field with 53 bits of precision
+                Defn: 1 |--> 1.00000000000000])
+
+        Extending the base field can resolve all ramification::
+
+            sage: F = QuadraticField(-1)
+            sage: QuaternionAlgebra(F, -1, -1).ramified_places()
+            ([], [])
+
+        Extending the base field can also resolve all ramification at finite
+        places while still leaving some ramification at infinite places::
+
+            sage: K = QuadraticField(3)
+            sage: QuaternionAlgebra(K, -1, -1).ramified_places()
+            ([],
+             [Ring morphism:
+                From: Number Field in a with defining polynomial x^2 - 3 with a = 1.732050807568878?
+                To:   Algebraic Real Field
+                Defn: a |--> -1.732050807568878?,
+              Ring morphism:
+                From: Number Field in a with defining polynomial x^2 - 3 with a = 1.732050807568878?
+                To:   Algebraic Real Field
+                Defn: a |--> 1.732050807568878?])
+
+        Extending the base field can also get rid of ramification at infinite
+        places while still leaving some ramification at finite places::
+
+            sage: L = QuadraticField(-15)
+            sage: QuaternionAlgebra(L, -1, -1).ramified_places()
+            ([Fractional ideal (2, 1/2*a + 1/2), Fractional ideal (2, 1/2*a - 1/2)], [])
+
+        We can use number field elements as invariants as well::
+
+            sage: x = polygen(ZZ, 'x')
+            sage: F.<a> = NumberField(x^2 - x - 1)
+            sage: QuaternionAlgebra(F, 2*a, F(-1)).ramified_places()
+            ([Fractional ideal (2)],
+             [Ring morphism:
+                From: Number Field in a with defining polynomial x^2 - x - 1
+                To: Algebraic Real Field
+                Defn: a |--> -0.618033988749895?])
+
+        The method does not make sense over an arbitrary base ring::
+
+            sage: QuaternionAlgebra(RR(2.),1).ramified_places()
+            Traceback (most recent call last):
+            ...
+            ValueError: base field must be rational numbers or a number field
+        """
+        if not isinstance(inf, bool):
+            raise TypeError("inf must be a truth value")
+
+        F = self.base_ring()
+        a = self._a
+        b = self._b
+
+        # The initial choice of primes (for the base field QQ) respectively
+        # of prime ideals (in the number field case) to check ramification
+        # for is based on 12.4.12(a) in [Voi2021]_.
+
+        # For efficiency (and to not convert QQ into a number field manually),
+        # we handle the case F = QQ first
+        if isinstance(F, RationalField):
+            ram_fin = sorted([p for p in set([2]).union(
+                    prime_divisors(a.numerator()), prime_divisors(a.denominator()),
+                    prime_divisors(b.numerator()), prime_divisors(b.denominator()))
+                    if hilbert_symbol(a, b, p) == -1])
+
+            if not inf:
+                return ram_fin
+
+            # The given quaternion algebra ramifies at the unique infinite place
+            # of QQ, by definition, if and only if it is definite
+            if self.is_definite():
+                return ram_fin, QQ.places()
+
+            return ram_fin, []
+
+        # At this point F needs to be a number field
+        # Note: Support for global function fields will be added in a future update
+        if F not in NumberFields():
+            raise ValueError("base field must be rational numbers or a number field")
+
+        # Over the number field F, first compute the finite ramified places
+        ram_fin = [p for p in set(F.primes_above(2)).union(F.primes_above(a),
+                    F.primes_above(b)) if F.hilbert_symbol(a, b, p) == -1]
+
+        if not inf:
+            return ram_fin
+
+        from sage.rings.qqbar import AA
+
+        # At this point the infinite ramified places also need to be computed
+        return ram_fin, [e for e in F.embeddings(AA) if F.hilbert_symbol(a, b, e) == -1]
+
+    @cached_method
+    def ramified_primes(self):
+        r"""
+        Return the (finite) primes of the base number field at
+        which this quaternion algebra ramifies.
+
+        OUTPUT:
+
+        The list of finite primes at which this quaternion algebra ramifies,
+        given as
+
+        - elements of `\ZZ` (sorted small to large) if the base field is `\QQ`,
+
+        - integral fractional ideals of the base number field, otherwise.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-58, -69).ramified_primes()
+            [3, 23, 29]
+
+        Under field extensions, the number of ramified primes can increase
+        or decrease::
+
+            sage: K = QuadraticField(3)
+            sage: L = QuadraticField(-15)
+            sage: QuaternionAlgebra(-1, -1).ramified_primes()
+            [2]
+            sage: QuaternionAlgebra(K, -1, -1).ramified_primes()
+            []
+            sage: QuaternionAlgebra(L, -1, -1).ramified_primes()
+            [Fractional ideal (2, 1/2*a + 1/2), Fractional ideal (2, 1/2*a - 1/2)]
+
+        We can also use number field elements as invariants::
+
+            sage: x = polygen(ZZ, 'x')
+            sage: F.<a> = NumberField(x^2 - x - 1)
+            sage: QuaternionAlgebra(F, 2*a, F(-1)).ramified_primes()
+            [Fractional ideal (2)]
+
+        The method does not make sense over an arbitrary base ring::
+
+            sage: QuaternionAlgebra(RR(2.),1).ramified_primes()
+            Traceback (most recent call last):
+            ...
+            ValueError: base field must be rational numbers or a number field
+        """
+        return self.ramified_places(inf=False)
+
+    @cached_method
+    def discriminant(self):
+        r"""
+        Return the discriminant of this quaternion algebra.
+
+        The discriminant of a quaternion algebra over a number field is the
+        product of the finite places at which the algebra ramifies.
+
+        OUTPUT:
+
+        The discriminant of this quaternion algebra, given as
+
+        - an element of `\ZZ` if the algebra is defined over `\QQ`,
+
+        - an integral fractional ideal of the base number field, otherwise.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(210, -22).discriminant()
+            210
+            sage: QuaternionAlgebra(19).discriminant()
+            19
+            sage: QuaternionAlgebra(-1, -1).discriminant()
+            2
+
+        Some examples over number fields::
+
+            sage: K = QuadraticField(3)
+            sage: L = QuadraticField(-15)
+            sage: QuaternionAlgebra(K, -1, -1).discriminant()
+            Fractional ideal (1)
+            sage: QuaternionAlgebra(L, -1, -1).discriminant()
+            Fractional ideal (2)
+
+        We can also use number field elements as invariants::
+
+            sage: x = polygen(ZZ, 'x')
+            sage: F.<a> = NumberField(x^2 - x - 1)
+            sage: QuaternionAlgebra(F, 2*a, F(-1)).discriminant()
+            Fractional ideal (2)
+
+        The method does not make sense over an arbitrary base ring::
+
+            sage: QuaternionAlgebra(RR(2.),1).discriminant()
+            Traceback (most recent call last):
+            ...
+            ValueError: base field must be rational numbers or a number field
+        """
+        F = self.base_ring()
+        if isinstance(F, RationalField):
+            return ZZ.prod(self.ramified_places(inf=False))
+
+        return F.ideal(F.prod(self.ramified_places(inf=False)))
+
+    def is_isomorphic(self, A) -> bool:
+        r"""
+        Check whether this quaternion algebra is isomorphic to ``A``.
+
+        Currently only implemented for quaternion algebras defined over
+        a number field; based on Main Theorem 14.6.1 in [Voi2021]_,
+        noting that `\QQ` has a unique infinite place.
+
+        INPUT:
+
+        - ``A`` -- a quaternion algebra defined over a number field
+
+        EXAMPLES::
+
+            sage: B = QuaternionAlgebra(-46, -87)
+            sage: A = QuaternionAlgebra(-58, -69)
+            sage: A == B
+            False
+            sage: B.is_isomorphic(A)
+            True
+
+        Checking ramification at both finite and infinite places, the method
+        correctly distinguishes isomorphism classes of quaternion algebras
+        that the discriminant can not distinguish::
+
+            sage: K = QuadraticField(3)
+            sage: A = QuaternionAlgebra(K, -1, -1)
+            sage: B = QuaternionAlgebra(K, 1, -1)
+            sage: A.discriminant() == B.discriminant()
+            True
+            sage: B.is_isomorphic(A)
+            False
+        """
+        if not isinstance(A, QuaternionAlgebra_ab):
+            raise TypeError("A must be a quaternion algebra of the form (a,b)_K")
+
+        F = self.base_ring()
+        if F is not A.base_ring():
+            raise ValueError("both quaternion algebras must be defined over the same ring")
+
+        if isinstance(F, RationalField):
+            return self.ramified_places(inf=False) == A.ramified_places(inf=False)
+
+        try:
+            ram_self = self.ramified_places(inf=True)
+            ram_A = A.ramified_places(inf=True)
+            return set(ram_self[0]) == set(ram_A[0]) and ram_self[1] == ram_A[1]
+        except ValueError:
+            raise NotImplementedError("base field must be rational numbers or a number field")
+
+    def _magma_init_(self, magma):
+        """
+        Return Magma version of this quaternion algebra.
+
+        EXAMPLES::
+
+            sage: Q = QuaternionAlgebra(-1,-1); Q
+            Quaternion Algebra (-1, -1) with base ring Rational Field
+            sage: Q._magma_init_(magma)                                  # optional - magma
+            'QuaternionAlgebra(_sage_[...],-1/1,-1/1)'
+            sage: A = magma(Q); A                                        # optional - magma
+            Quaternion Algebra with base ring Rational Field, defined by i^2 = -1, j^2 = -1
+            sage: A.RamifiedPlaces()                                     # optional - magma
+            [
+            Ideal of Integer Ring generated by 2
+            ]
+
+        A more complicated example involving a quaternion algebra over a number field::
+
+            sage: K.<a> = QQ[sqrt(2)]; Q = QuaternionAlgebra(K,-1,a); Q                 # needs sage.symbolic
+            Quaternion Algebra (-1, sqrt2) with base ring Number Field in sqrt2
+             with defining polynomial x^2 - 2 with sqrt2 = 1.414213562373095?
+            sage: magma(Q)                                              # optional - magma, needs sage.symbolic
+            Quaternion Algebra with base ring Number Field with defining polynomial
+             x^2 - 2 over the Rational Field, defined by i^2 = -1, j^2 = sqrt2
+            sage: Q._magma_init_(magma)                                 # optional - magma, needs sage.symbolic
+            'QuaternionAlgebra(_sage_[...],(_sage_[...]![-1, 0]),(_sage_[...]![0, 1]))'
+        """
+        R = magma(self.base_ring())
+        return 'QuaternionAlgebra(%s,%s,%s)' % (R.name(),
+                                                self._a._magma_init_(magma),
+                                                self._b._magma_init_(magma))
+
+    def quaternion_order(self, basis, check=True):
+        """
+        Return the order of this quaternion order with given basis.
+
+        INPUT:
+
+        - ``basis`` -- list of 4 elements of ``self``
+        - ``check`` -- boolean (default: ``True``)
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-11,-1)
+            sage: Q.quaternion_order([1,i,j,k])
+            Order of Quaternion Algebra (-11, -1) with base ring Rational Field
+             with basis (1, i, j, k)
+
+        We test out ``check=False``::
+
+            sage: Q.quaternion_order([1,i,j,k], check=False)
+            Order of Quaternion Algebra (-11, -1) with base ring Rational Field
+             with basis (1, i, j, k)
+            sage: Q.quaternion_order([i,j,k], check=False)
+            Order of Quaternion Algebra (-11, -1) with base ring Rational Field
+             with basis (i, j, k)
+        """
+        return QuaternionOrder(self, basis, check=check)
+
+    def ideal(self, gens, left_order=None, right_order=None, check=True, **kwds):
+        r"""
+        Return the quaternion ideal with given gens over `\ZZ`.
+
+        Neither a left or right order structure need be specified.
+
+        INPUT:
+
+        - ``gens`` -- list of elements of this quaternion order
+
+        - ``check`` -- boolean (default: ``True``)
+
+        - ``left_order`` -- a quaternion order or ``None``
+
+        - ``right_order`` -- a quaternion order or ``None``
+
+        EXAMPLES::
+
+            sage: R = QuaternionAlgebra(-11,-1)
+            sage: R.ideal([2*a for a in R.basis()])
+            Fractional ideal (2, 2*i, 2*j, 2*k)
+        """
+        gens = [self(g) for g in gens]  # coerce integers etc. into quaternions
+        if self.base_ring() == QQ:
+            return QuaternionFractionalIdeal_rational(self, gens, left_order=left_order, right_order=right_order, check=check)
+        else:
+            raise NotImplementedError("ideal only implemented for quaternion algebras over QQ")
+
+    @cached_method
+    def modp_splitting_data(self, p):
+        r"""
+        Return mod `p` splitting data for this quaternion algebra at
+        the unramified prime `p`.
+
+        This is `2\times 2`
+        matrices `I`, `J`, `K` over the finite field `\GF{p}` such that if
+        the quaternion algebra has generators `i, j, k`, then `I^2 =
+        i^2`, `J^2 = j^2`, `IJ=K` and `IJ=-JI`.
+
+        .. NOTE::
+
+           Currently only implemented when `p` is odd and the base
+           ring is `\QQ`.
+
+        INPUT:
+
+        - ``p`` -- unramified odd prime
+
+        OUTPUT: 2-tuple of matrices over finite field
+
+        EXAMPLES::
+
+            sage: Q = QuaternionAlgebra(-15, -19)
+            sage: Q.modp_splitting_data(7)
+            (
+            [0 6]  [6 1]  [6 6]
+            [1 0], [1 1], [6 1]
+            )
+            sage: Q.modp_splitting_data(next_prime(10^5))
+            (
+            [    0 99988]  [97311     4]  [99999 59623]
+            [    1     0], [13334  2692], [97311     4]
+            )
+            sage: I,J,K = Q.modp_splitting_data(23)
+            sage: I
+            [0 8]
+            [1 0]
+            sage: I^2
+            [8 0]
+            [0 8]
+            sage: J
+            [19  2]
+            [17  4]
+            sage: J^2
+            [4 0]
+            [0 4]
+            sage: I*J == -J*I
+            True
+            sage: I*J == K
+            True
+
+        The following is a good test because of the asserts in the code::
+
+            sage: v = [Q.modp_splitting_data(p) for p in primes(20,1000)]
+
+        Proper error handling::
+
+            sage: Q.modp_splitting_data(5)
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: algorithm for computing local splittings
+            not implemented in general (currently require the first invariant
+            to be coprime to p)
+
+            sage: Q.modp_splitting_data(2)
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: p must be odd
+        """
+        if self.base_ring() != QQ:
+            raise NotImplementedError("must be rational quaternion algebra")
+        p = ZZ(p)
+        if not p.is_prime():
+            raise ValueError("p (=%s) must be prime" % p)
+        if p == 2:
+            raise NotImplementedError("p must be odd")
+        if self.discriminant() % p == 0:
+            raise ValueError("p (=%s) must be an unramified prime" % p)
+
+        i, j, _ = self.gens()
+        F = GF(p)
+        i2 = F(i * i)
+        j2 = F(j * j)
+
+        M = MatrixSpace(F, 2)
+        I = M([0, i2, 1, 0])
+        if i2 == 0:
+            raise NotImplementedError("algorithm for computing local splittings not implemented in general (currently require the first invariant to be coprime to p)")
+        i2inv = ~i2
+        a = None
+        for b in F:
+            if not b:
+                continue
+            c = j2 + i2inv * b*b
+            if c.is_square():
+                a = -c.sqrt()
+                break
+
+        if a is None:
+            # do a fallback search, maybe needed in char 3 sometimes.
+            for J in M:
+                K = I*J
+                if J*J == j2 and K == -J*I:
+                    return I, J, K
+
+        J = M([a, b, (j2 - a * a) / b, -a])
+        K = I * J
+        assert K == -J * I, "bug in that I,J don't skew commute"
+        return I, J, K
+
+    def modp_splitting_map(self, p):
+        r"""
+        Return Python map from the (`p`-integral) quaternion algebra to
+        the set of `2\times 2` matrices over `\GF{p}`.
+
+        INPUT:
+
+        - ``p`` -- prime number
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1, -7)
+            sage: f = Q.modp_splitting_map(13)
+            sage: a = 2+i-j+3*k; b = 7+2*i-4*j+k
+            sage: f(a*b)
+            [12  3]
+            [10  5]
+            sage: f(a)*f(b)
+            [12  3]
+            [10  5]
+        """
+        I, J, K = self.modp_splitting_data(p)
+        F = I.base_ring()
+
+        def phi(q):
+            v = [F(a) for a in q.coefficient_tuple()]
+            return v[0] + I*v[1] + J*v[2] + K*v[3]
+        return phi
+
+
+############################################################
+# Unpickling
+############################################################
+def unpickle_QuaternionAlgebra_v0(*key):
+    """
+    The `0`-th version of pickling for quaternion algebras.
+
+    EXAMPLES::
+
+        sage: Q = QuaternionAlgebra(-5,-19)
+        sage: t = (QQ, -5, -19, ('i', 'j', 'k'))
+        sage: sage.algebras.quatalg.quaternion_algebra.unpickle_QuaternionAlgebra_v0(*t)
+        Quaternion Algebra (-5, -19) with base ring Rational Field
+        sage: loads(dumps(Q)) == Q
+        True
+        sage: loads(dumps(Q)) is Q
+        True
+    """
+    return QuaternionAlgebra(*key)
+
+
+@richcmp_method
+class QuaternionOrder(Parent):
+    """
+    An order in a quaternion algebra.
+
+    EXAMPLES::
+
+        sage: QuaternionAlgebra(-1,-7).maximal_order()
+        Order of Quaternion Algebra (-1, -7) with base ring Rational Field with basis (1/2 + 1/2*j, 1/2*i + 1/2*k, j, k)
+        sage: type(QuaternionAlgebra(-1,-7).maximal_order())
+        <class 'sage.algebras.quatalg.quaternion_algebra.QuaternionOrder_with_category'>
+    """
+    def __init__(self, A, basis, check=True):
+        """
+        INPUT:
+
+        - ``A`` -- a quaternion algebra
+        - ``basis`` -- list of 4 integral quaternions in ``A``
+        - ``check`` -- whether to do type and other consistency checks
+
+        .. WARNING::
+
+            Currently most methods silently assume that the ``A.base_ring()``
+            is ``QQ``.
+
+        EXAMPLES::
+
+            sage: A.<i,j,k> = QuaternionAlgebra(-3,-5)
+            sage: sage.algebras.quatalg.quaternion_algebra.QuaternionOrder(A, [1,i,j,k])
+            Order of Quaternion Algebra (-3, -5) with base ring Rational Field with basis (1, i, j, k)
+            sage: R = sage.algebras.quatalg.quaternion_algebra.QuaternionOrder(A, [1,2*i,2*j,2*k]); R
+            Order of Quaternion Algebra (-3, -5) with base ring Rational Field with basis (1, 2*i, 2*j, 2*k)
+            sage: type(R)
+            <class 'sage.algebras.quatalg.quaternion_algebra.QuaternionOrder_with_category'>
+
+        Over QQ and number fields it is checked whether the given
+        basis actually gives an order (as a module over the maximal order)::
+
+            sage: A.<i,j,k> = QuaternionAlgebra(-1,-1)
+            sage: A.quaternion_order([1,i,j,i-j])
+            Traceback (most recent call last):
+            ...
+            ValueError: basis must have rank 4
+            sage: A.quaternion_order([2,i,j,k])
+            Traceback (most recent call last):
+            ...
+            ValueError: lattice must contain 1
+            sage: A.quaternion_order([1,i/2,j/2,k/2])
+            Traceback (most recent call last):
+            ...
+            ValueError: given lattice must be a ring
+
+            sage: K = QuadraticField(10)
+            sage: A.<i,j,k> = QuaternionAlgebra(K,-1,-1)
+            sage: A.quaternion_order([1,i,j,k])
+            Order of Quaternion Algebra (-1, -1) with base ring Number Field in a
+             with defining polynomial x^2 - 10 with a = 3.162277660168380? with basis (1, i, j, k)
+            sage: A.quaternion_order([1,i/2,j,k])
+            Traceback (most recent call last):
+            ...
+            ValueError: given lattice must be a ring
+
+        TESTS::
+
+            sage: TestSuite(R).run()
+        """
+        if check:
+            # right data type
+            if not isinstance(basis, (list, tuple)):
+                raise TypeError("basis must be a list or tuple")
+            # right length
+            if len(basis) != 4:
+                raise ValueError("basis must have length 4")
+            # coerce to common parent
+            basis = tuple([A(x) for x in basis])
+
+            # has rank 4
+            V = A.base_ring()**4
+            if V.span([V(x.coefficient_tuple()) for x in basis]).dimension() != 4:
+                raise ValueError("basis must have rank 4")
+
+            # The additional checks will work over QQ and over number fields,
+            # but we can't actually do much with an order defined over a number
+            # field
+
+            if A.base_ring() == QQ:     # fast code over QQ
+                M = matrix(QQ, 4, 4, [x.coefficient_tuple() for x in basis])
+                v = M.solve_left(V([1, 0, 0, 0]))
+
+                if v.denominator() != 1:
+                    raise ValueError("lattice must contain 1")
+
+                # check if multiplicatively closed
+                M1 = basis_for_quaternion_lattice(basis)
+                M2 = basis_for_quaternion_lattice(list(basis) + [x * y for x in basis for y in basis])
+                if M1 != M2:
+                    raise ValueError("given lattice must be a ring")
+
+            if A.base_ring() != QQ:     # slow code over number fields (should eventually use PARI's nfhnf)
+                O = None
+                try:
+                    O = A.base_ring().maximal_order()
+                except AttributeError:
+                    pass
+
+                if O:
+                    M = matrix(A.base_ring(), 4, 4, [x.coefficient_tuple()
+                                                     for x in basis])
+                    v = M.solve_left(V([1, 0, 0, 0]))
+
+                    if any(a not in O for a in v):
+                        raise ValueError("lattice must contain 1")
+
+                    # check if multiplicatively closed
+                    Y = matrix(QQ, 16, 4, [(x*y).coefficient_tuple()
+                                           for x in basis for y in basis])
+                    X = M.solve_left(Y)
+                    if any(a not in O for x in X for a in x):
+                        raise ValueError("given lattice must be a ring")
+
+        self.__basis = tuple(basis)
+        self.__quaternion_algebra = A
+        Parent.__init__(self, base=ZZ, facade=(A,),
+                        category=Algebras(ZZ).Facade().FiniteDimensional())
+
+    def _element_constructor_(self, x):
+        """
+        Construct an element of this quaternion order from ``x``,
+        or throw an error if ``x`` is not contained in the order.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1,-19)
+            sage: O = Q.quaternion_order([1,i,j,k])
+            sage: O(1+i)
+            1 + i
+            sage: O(1/2)
+            Traceback (most recent call last):
+            ...
+            TypeError: 1/2 does not lie in Order of Quaternion Algebra (-1, -19)
+            with base ring Rational Field with basis (1, i, j, k)
+
+        TESTS:
+
+        Test for :issue:`32364`::
+
+            sage: 1/5 in O
+            False
+            sage: j/2 in O
+            False
+        """
+        y = self.quaternion_algebra()(x)
+        if y not in self.unit_ideal():
+            raise TypeError(f'{x!r} does not lie in {self!r}')
+        return y
+
+    def one(self):
+        """
+        Return the multiplicative unit of this quaternion order.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-1,-7).maximal_order().one()
+            1
+        """
+        return self.quaternion_algebra().one()
+
+    def gens(self) -> tuple:
+        """
+        Return generators for ``self``.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-1,-7).maximal_order().gens()
+            (1/2 + 1/2*j, 1/2*i + 1/2*k, j, k)
+        """
+        return self.__basis
+
+    def ngens(self):
+        """
+        Return the number of generators (which is 4).
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-1,-7).maximal_order().ngens()
+            4
+        """
+        return 4
+
+    def gen(self, n):
+        """
+        Return the `n`-th generator.
+
+        INPUT:
+
+        - ``n`` -- integer between 0 and 3, inclusive
+
+        EXAMPLES::
+
+            sage: R = QuaternionAlgebra(-11,-1).maximal_order(); R
+            Order of Quaternion Algebra (-11, -1) with base ring Rational Field
+             with basis (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+            sage: R.gen(0)
+            1/2 + 1/2*i
+            sage: R.gen(1)
+            1/2*j - 1/2*k
+            sage: R.gen(2)
+            i
+            sage: R.gen(3)
+            -k
+        """
+        return self.__basis[n]
+
+    def __richcmp__(self, other, op):
+        """
+        Compare this quaternion order to ``other``.
+
+        EXAMPLES::
+
+            sage: R = QuaternionAlgebra(-1, -11).maximal_order()
+            sage: R == R                       # indirect doctest
+            True
+            sage: R == 5
+            False
+            sage: R == QuaternionAlgebra(-1, -7).maximal_order()
+            False
+
+        Orders can be equal even if they are defined by different
+        bases (see :issue:`32245`)::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1, -19)
+            sage: Q.quaternion_order([1,-i,k,j+i*7]) == Q.quaternion_order([1,i,j,k])
+            True
+
+        TESTS::
+
+            sage: B = QuaternionAlgebra(-1, -11)
+            sage: i,j,k = B.gens()
+            sage: O = B.quaternion_order([1,i,j,k])
+            sage: O == O
+            True
+            sage: R = B.quaternion_order([1,i,(i+j)/2,(1+k)/2])
+            sage: O <= R                # indirect doctest
+            True
+            sage: O >= R
+            False
+            sage: O != R
+            True
+            sage: O == R
+            False
+            sage: O != O
+            False
+            sage: O < O
+            False
+            sage: O < R
+            True
+            sage: O <= O
+            True
+            sage: R >= R
+            True
+        """
+        from sage.structure.richcmp import richcmp, op_NE
+        if not isinstance(other, QuaternionOrder):
+            return op == op_NE
+        return richcmp(self.unit_ideal(), other.unit_ideal(), op)
+
+    def __hash__(self):
+        """
+        Compute the hash of ``self``.
+
+        EXAMPLES::
+
+            sage: h1 = hash(QuaternionAlgebra(-1,-7).maximal_order())
+            sage: h2 = hash(QuaternionAlgebra(-1,-7).maximal_order())
+            sage: h3 = hash(QuaternionAlgebra(-1,-5).maximal_order())
+            sage: h1  == h2 and h1 != h3
+            True
+        """
+        return hash((self.__quaternion_algebra, self.__basis))
+
+    def basis(self):
+        """
+        Return fix choice of basis for this quaternion order.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().basis()
+            (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+        """
+        return self.__basis
+
+    def quaternion_algebra(self):
+        """
+        Return ambient quaternion algebra that contains this quaternion order.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().quaternion_algebra()
+            Quaternion Algebra (-11, -1) with base ring Rational Field
+        """
+        return self.__quaternion_algebra
+
+    def _repr_(self):
+        """
+        Return string representation of this order.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order()._repr_()
+            'Order of Quaternion Algebra (-11, -1) with base ring Rational Field with basis (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)'
+            sage: QuaternionAlgebra(-11,-1).maximal_order()
+            Order of Quaternion Algebra (-11, -1) with base ring Rational Field with basis (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+        """
+        return 'Order of %s with basis %s' % (self.quaternion_algebra(), self.basis())
+
+    def random_element(self, *args, **kwds):
+        """
+        Return a random element of this order.
+
+        The args and kwds are passed to the random_element method of
+        the integer ring, and we return an element of the form
+
+        .. MATH::
+
+            ae_1 + be_2 + ce_3 + de_4
+
+        where `e_1`, ..., `e_4` are the basis of this order and `a`,
+        `b`, `c`, `d` are random integers.
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().random_element()  # random
+            -4 - 4*i + j - k
+            sage: QuaternionAlgebra(-11,-1).maximal_order().random_element(-10,10)  # random
+            -9/2 - 7/2*i - 7/2*j - 3/2*k
+        """
+        return sum(ZZ.random_element(*args, **kwds) * b for b in self.basis())
+
+    def intersection(self, other):
+        """
+        Return the intersection of this order with other.
+
+        INPUT:
+
+        - ``other`` -- a quaternion order in the same ambient quaternion algebra
+
+        OUTPUT: a quaternion order
+
+        EXAMPLES::
+
+            sage: R = QuaternionAlgebra(-11,-1).maximal_order()
+            sage: R.intersection(R)
+            Order of Quaternion Algebra (-11, -1) with base ring Rational Field
+             with basis (1/2 + 1/2*i, i, 1/2*j + 1/2*k, k)
+
+        We intersect various orders in the quaternion algebra ramified at 11::
+
+            sage: # needs sage.schemes
+            sage: B = BrandtModule(11,3)
+            sage: R = B.maximal_order(); S = B.order_of_level_N()
+            sage: R.intersection(S)
+            Order of Quaternion Algebra (-1, -11) with base ring Rational Field
+             with basis (1/2 + 1/2*j, 1/2*i + 5/2*k, j, 3*k)
+            sage: R.intersection(S) == S
+            True
+            sage: B = BrandtModule(11,5)
+            sage: T = B.order_of_level_N()
+            sage: S.intersection(T)
+            Order of Quaternion Algebra (-1, -11) with base ring Rational Field
+             with basis (1/2 + 1/2*j, 1/2*i + 23/2*k, j, 15*k)
+        """
+        if not isinstance(other, QuaternionOrder):
+            raise TypeError("other must be a QuaternionOrder")
+
+        A = self.quaternion_algebra()
+        if other.quaternion_algebra() != A:
+            raise ValueError("self and other must be in the same ambient quaternion algebra")
+
+        V = A.base_ring()**4
+
+        B = V.span([V(list(g)) for g in self.basis()], ZZ)
+        C = V.span([V(list(g)) for g in other.basis()], ZZ)
+
+        # todo -- A(list(e)) could be A(e)
+        return QuaternionOrder(A, [A(list(e)) for e in B.intersection(C).basis()])
+
+    @cached_method
+    def free_module(self):
+        r"""
+        Return the free `\ZZ`-module that corresponds to this order
+        inside the vector space corresponding to the ambient
+        quaternion algebra.
+
+        OUTPUT: a free `\ZZ`-module of rank 4
+
+        EXAMPLES::
+
+            sage: R = QuaternionAlgebra(-11,-1).maximal_order()
+            sage: R.basis()
+            (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+            sage: R.free_module()
+            Free module of degree 4 and rank 4 over Integer Ring
+            Echelon basis matrix:
+            [1/2 1/2   0   0]
+            [  0   1   0   0]
+            [  0   0 1/2 1/2]
+            [  0   0   0   1]
+        """
+        V = self.quaternion_algebra().base_ring()**4
+        return V.span([V(list(g)) for g in self.basis()], ZZ)
+
+    def discriminant(self):
+        r"""
+        Return the discriminant of this order.
+
+        This is defined as
+        `\sqrt{ det ( Tr(e_i \bar{e}_j ) ) }`, where `\{e_i\}` is the
+        basis of the order.
+
+        OUTPUT: rational number
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().discriminant()
+            11
+
+            sage: # needs sage.schemes
+            sage: S = BrandtModule(11,5).order_of_level_N()
+            sage: S.discriminant()
+            55
+            sage: type(S.discriminant())
+            <... 'sage.rings.rational.Rational'>
+        """
+        e = self.basis()
+        L = [[x.pair(y) for y in e] for x in e]
+        return matrix(QQ, 4, 4, L).determinant().sqrt()
+
+    def is_maximal(self) -> bool:
+        r"""
+        Check whether the order of ``self`` is maximal in the ambient quaternion algebra.
+
+        Only implemented for quaternion algebras over number fields; for reference,
+        see Theorem 15.5.5 in [Voi2021]_.
+
+        EXAMPLES::
+
+            sage: p = 11
+            sage: B = QuaternionAlgebra(QQ, -1, -p)
+            sage: i, j, k = B.gens()
+            sage: O0_basis = (1, i, (i+j)/2, (1+i*j)/2)
+            sage: O0 = B.quaternion_order(O0_basis)
+            sage: O0.is_maximal()
+            True
+            sage: O1 = B.quaternion_order([1, i, j, i*j])
+            sage: O1.is_maximal()
+            False
+
+        TESTS::
+
+            sage: B = QuaternionAlgebra(GF(13), -1, -11)
+            sage: i, j, k = B.gens()
+            sage: O0_basis = (1, i, j, k)
+            sage: O0 = B.quaternion_order(O0_basis)
+            sage: O0.is_maximal()
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: check for maximality is only implemented for quaternion algebras over number fields
+        """
+        if self.quaternion_algebra().base_ring() not in NumberFields():
+            raise NotImplementedError("check for maximality is only implemented for quaternion algebras over number fields")
+        return self.discriminant() == self.quaternion_algebra().discriminant()
+
+    def _left_ideal_basis(self, gens):
+        """
+        Return a basis for the left ideal of ``self`` with given generators.
+
+        INPUT:
+
+        - ``gens`` -- list of elements of ``self``
+
+        OUTPUT: list of four elements of ``self``
+
+        EXAMPLES::
+
+            sage: A.<i,j,k> = QuaternionAlgebra(-17, -3)
+            sage: A.maximal_order()._left_ideal_basis([i + j, i - j, 2*k, A(3)])
+            [1, i, 1/2 + 1/2*j, 1/2 + 1/2*i + 1/6*j + 1/6*k]
+            sage: A.maximal_order()._left_ideal_basis([3*(i + j), 3*(i - j), 6*k, A(3)])
+            [3, 3*i, 3/2 + 3/2*j, 3/2 + 3/2*i + 1/2*j + 1/2*k]
+        """
+        return basis_for_quaternion_lattice([b * g for b in self.basis() for g in gens])
+
+    def _right_order_from_ideal_basis(self, basis):
+        """
+        Given a basis for a left ideal `I`, return the right order in
+        ``self`` of elements `x` such that `I x` is contained in `I`.
+
+        INPUT:
+
+        - ``basis`` -- basis for an ideal `I`
+
+        EXAMPLES:
+
+            sage: A.<i,j,k> = QuaternionAlgebra(17)
+            sage: O = A.maximal_order()
+            sage: basis = O._left_ideal_basis([1]); basis
+            [1, 1/2 + 1/2*i, j, 1/3*i + 1/2*j + 1/6*k]
+            sage: O._right_order_from_ideal_basis(basis)
+            Order of Quaternion Algebra (-3, -17) with base ring Rational Field with basis (1/2 + 1/6*i + 1/3*k, 1/3*i + 2/3*k, 1/2*j + 1/2*k, k)
+
+            sage: basis = O._left_ideal_basis([i*j - j]); basis
+            [34, 17 + 17*i, 2*j, 17 + 17/3*i + j + 1/3*k]
+            sage: O._right_order_from_ideal_basis(basis)
+            Order of Quaternion Algebra (-3, -17) with base ring Rational Field with basis (1/2 + 1/6*i + 1/3*k, 1/3*i + 2/3*k, 1/2*j + 1/2*k, k)
+        """
+        # Compute matrix of multiplication by each element of the basis.
+        B = self.basis()
+        Z = self.quaternion_algebra()
+        M = MatrixSpace(QQ, 4)
+
+        # I = matrix with rows the given basis for I
+        I = M([list(f) for f in basis])
+
+        # psi = matrix of right multiplication on each basis element
+        psi = [M([list(f * x) for x in Z.basis()]) for f in basis]
+
+        # invert them
+        psi_inv = [x**(-1) for x in psi]
+
+        # apply the four inverses to I
+        W = [I * x for x in psi_inv]
+
+        # The right order is the intersection of the row span of the W with the row span of B.
+        X = M([list(b) for b in B]).row_module(ZZ)
+        for A in W:
+            X = X.intersection(A.row_module(ZZ))
+        C = [Z(list(b)) for b in X.basis()]
+        return Z.quaternion_order(C)
+
+    def left_ideal(self, gens, check=True, *, is_basis=False):
+        r"""
+        Return the left ideal of this order generated by the given generators.
+
+        INPUT:
+
+        - ``gens`` -- list of elements of this quaternion order
+
+        - ``check`` -- boolean (default: ``True``)
+
+        - ``is_basis`` -- boolean (default: ``False``); if ``True`` then
+          ``gens`` must be a `\ZZ`-basis of the ideal
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-11,-1)
+            sage: R = Q.maximal_order()
+            sage: R.left_ideal([a*2 for a in R.basis()], is_basis=True)
+            Fractional ideal (1 + i, 2*i, j + k, 2*k)
+            sage: R.left_ideal([a*(i+j) for a in R.basis()], is_basis=True)
+            Fractional ideal (1/2 + 1/2*i + 1/2*j + 13/2*k, i + j, 6*j + 6*k, 12*k)
+
+        It is also possible to pass a generating set (rather than a basis),
+        or a single generator::
+
+            sage: R.left_ideal([i+j])
+            Fractional ideal (12, 6 + 6*i, i + j, 13/2 + 1/2*i + 1/2*j + 1/2*k)
+            sage: R.left_ideal(i+j)
+            Fractional ideal (12, 6 + 6*i, i + j, 13/2 + 1/2*i + 1/2*j + 1/2*k)
+            sage: R.left_ideal([2, 1+j]) == R*2 + R*(1+j)
+            True
+        """
+        if self.base_ring() is not ZZ:
+            raise NotImplementedError("ideal only implemented for quaternion algebras over QQ")
+        if is_basis:
+            basis = gens
+        else:
+            if gens in self.quaternion_algebra():
+                gens = [gens]
+            basis = tuple(basis_for_quaternion_lattice([b * g for b in self.basis() for g in gens]))
+            check = False
+        return QuaternionFractionalIdeal_rational(self.quaternion_algebra(), basis, left_order=self, check=check)
+
+    def right_ideal(self, gens, check=True, *, is_basis=False):
+        r"""
+        Return the right ideal of this order generated by the given generators.
+
+        INPUT:
+
+        - ``gens`` -- list of elements of this quaternion order
+
+        - ``check`` -- boolean (default: ``True``)
+
+        - ``is_basis`` -- boolean (default: ``False``); if ``True`` then
+          ``gens`` must be a `\ZZ`-basis of the ideal
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-11,-1)
+            sage: R = Q.maximal_order()
+            sage: R.right_ideal([2*a for a in R.basis()], is_basis=True)
+            Fractional ideal (1 + i, 2*i, j + k, 2*k)
+            sage: R.right_ideal([(i+j)*a for a in R.basis()], is_basis=True)
+            Fractional ideal (1/2 + 1/2*i + 1/2*j + 11/2*k, i + j, 6*j + 6*k, 12*k)
+
+        It is also possible to pass a generating set (rather than a basis),
+        or a single generator::
+
+            sage: R.right_ideal([i+j])
+            Fractional ideal (12, 6 + 6*i, i + j, 11/2 + 1/2*i + 1/2*j + 1/2*k)
+            sage: R.right_ideal(i+j)
+            Fractional ideal (12, 6 + 6*i, i + j, 11/2 + 1/2*i + 1/2*j + 1/2*k)
+            sage: R.right_ideal([2, 1+j]) == 2*R + (1+j)*R
+            True
+        """
+        if self.base_ring() is not ZZ:
+            raise NotImplementedError("ideal only implemented for quaternion algebras over QQ")
+        if is_basis:
+            basis = gens
+        else:
+            if gens in self.quaternion_algebra():
+                gens = [gens]
+            basis = tuple(basis_for_quaternion_lattice([g * b for b in self.basis() for g in gens]))
+            check = False
+        return QuaternionFractionalIdeal_rational(self.quaternion_algebra(), basis, right_order=self, check=check)
+
+    @cached_method
+    def unit_ideal(self):
+        """
+        Return the unit ideal in this quaternion order.
+
+        EXAMPLES::
+
+            sage: R = QuaternionAlgebra(-11,-1).maximal_order()
+            sage: I = R.unit_ideal(); I
+            Fractional ideal (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+        """
+        if self.base_ring() is not ZZ:
+            raise NotImplementedError("ideal only implemented for quaternion algebras over QQ")
+        return QuaternionFractionalIdeal_rational(self.quaternion_algebra(), self.basis(), left_order=self, right_order=self, check=False)
+
+    def basis_matrix(self):
+        r"""
+        Return the basis matrix of this quaternion order, for the
+        specific basis returned by :meth:`basis()`.
+
+        OUTPUT: matrix over `\QQ`
+
+        EXAMPLES::
+
+            sage: O = QuaternionAlgebra(-11,-1).maximal_order()
+            sage: O.basis()
+            (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+            sage: O.basis_matrix()
+            [ 1/2  1/2    0    0]
+            [   0    0  1/2 -1/2]
+            [   0    1    0    0]
+            [   0    0    0   -1]
+
+        Note that the returned matrix is *not* necessarily the same as
+        the basis matrix of the :meth:`unit_ideal()`::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1,-11)
+            sage: O = Q.quaternion_order([j,i,-1,k])
+            sage: O.basis_matrix()
+            [ 0  0  1  0]
+            [ 0  1  0  0]
+            [-1  0  0  0]
+            [ 0  0  0  1]
+            sage: O.unit_ideal().basis_matrix()
+            [1 0 0 0]
+            [0 1 0 0]
+            [0 0 1 0]
+            [0 0 0 1]
+        """
+        return matrix(QQ, map(list, self.__basis))
+
+    def __mul__(self, other):
+        """
+        Every order equals its own unit ideal. Overload ideal multiplication
+        and scaling to orders.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1,-11)
+            sage: O = Q.maximal_order()
+            sage: I = O*j; I
+            Fractional ideal (11, 11*i, 11/2 + 1/2*j, 11/2*i + 1/2*k)
+        """
+        return self.unit_ideal() * other
+
+    def __rmul__(self, other):
+        return other * self.unit_ideal()
+
+    def __add__(self, other):
+        """
+        Every order equals its own unit ideal. Overload ideal addition
+        to orders.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1,-11)
+            sage: O = Q.maximal_order()
+            sage: I = O + O*((j-3)/5); I
+            Fractional ideal (1/10 + 3/10*j, 1/10*i + 3/10*k, j, k)
+        """
+        return self.unit_ideal() + other
+
+    def quadratic_form(self):
+        """
+        Return the normalized quadratic form associated to this quaternion order.
+
+        OUTPUT: quadratic form
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: R = BrandtModule(11,13).order_of_level_N()
+            sage: Q = R.quadratic_form(); Q
+            Quadratic form in 4 variables over Rational Field with coefficients:
+            [ 14 253 55 286 ]
+            [ * 1455 506 3289 ]
+            [ * * 55 572 ]
+            [ * * * 1859 ]
+            sage: Q.theta_series(10)
+            1 + 2*q + 2*q^4 + 4*q^6 + 4*q^8 + 2*q^9 + O(q^10)
+        """
+        return self.unit_ideal().quadratic_form()
+
+    def ternary_quadratic_form(self, include_basis=False):
+        r"""
+        Return the ternary quadratic form associated to this order.
+
+        INPUT:
+
+        - ``include_basis`` -- boolean (default: ``False``); if ``True`` also
+          return a basis for the dimension 3 subspace `G`
+
+        OUTPUT: QuadraticForm
+
+        - optional basis for dimension 3 subspace
+
+        This function computes the positive definition quadratic form
+        obtained by letting G be the trace zero subspace of `\ZZ` +
+        2* ``self``, which has rank 3, and restricting the pairing
+        :meth:`QuaternionAlgebraElement_abstract.pair`::
+
+           (x,y) = (x.conjugate()*y).reduced_trace()
+
+        to `G`.
+
+        APPLICATIONS: Ternary quadratic forms associated to an order
+        in a rational quaternion algebra are useful in computing with
+        Gross points, in decided whether quaternion orders have
+        embeddings from orders in quadratic imaginary fields, and in
+        computing elements of the Kohnen plus subspace of modular
+        forms of weight 3/2.
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: R = BrandtModule(11,13).order_of_level_N()
+            sage: Q = R.ternary_quadratic_form(); Q
+            Quadratic form in 3 variables over Rational Field with coefficients:
+            [ 5820 1012 13156 ]
+            [ * 55 1144 ]
+            [ * * 7436 ]
+            sage: factor(Q.disc())
+            2^4 * 11^2 * 13^2
+
+        The following theta series is a modular form of weight 3/2 and level 4*11*13::
+
+            sage: Q.theta_series(100)                                                   # needs sage.schemes
+            1 + 2*q^23 + 2*q^55 + 2*q^56 + 2*q^75 + 4*q^92 + O(q^100)
+        """
+        if self.base_ring() != ZZ:
+            raise NotImplementedError("ternary quadratic form of order only implemented for quaternion algebras over QQ")
+
+        Q = self.quaternion_algebra()
+        # 2*R + ZZ
+        twoR = self.free_module().scale(2)
+        Z = twoR.span([Q(1).coefficient_tuple()], ZZ)
+        S = twoR + Z
+        # Now we intersect with the trace 0 submodule
+        v = [b.reduced_trace() for b in Q.basis()]
+        M = matrix(QQ, 4, 1, v)
+        tr0 = M.kernel()
+        G = tr0.intersection(S)
+        B = [Q(a) for a in G.basis()]
+        m = matrix(QQ, [[x.pair(y) for x in B] for y in B])
+        Q = QuadraticForm(m)
+        if include_basis:
+            return Q, B
+        else:
+            return Q
+
+    def isomorphism_to(self, other, *, conjugator=False, B=10):
+        r"""
+        Compute an isomorphism from this quaternion order `O`
+        to another order `O'` in the same quaternion algebra.
+
+        INPUT:
+
+        - ``conjugator`` -- boolean (default: ``False``); if ``True`` this
+          method returns a single quaternion `\gamma \in O \cap O'`
+          of minimal norm such that `O' = \gamma^{-1} O \gamma`,
+          rather than the ring isomorphism it defines
+
+        - ``B`` -- positive integer; bound on theta series
+          coefficients to rule out non isomorphic orders
+
+        .. NOTE::
+
+            This method is currently only implemented for maximal orders in
+            definite quaternion orders over `\QQ`. For a general algorithm,
+            see [KV2010]_ (Problem ``IsConjugate``).
+
+        EXAMPLES::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(-1, -19)
+            sage: O0 = Quat.quaternion_order([1, i, (i+j)/2, (1+k)/2])
+            sage: O1 = Quat.quaternion_order([1, 667*i, 1/2+j/2+9*i, (222075/2*i+333*j+k/2)/667])
+            sage: iso = O0.isomorphism_to(O1)
+            sage: iso
+            Ring morphism:
+              From: Order of Quaternion Algebra (-1, -19) with base ring Rational Field
+                     with basis (1, i, 1/2*i + 1/2*j, 1/2 + 1/2*k)
+              To:   Order of Quaternion Algebra (-1, -19) with base ring Rational Field
+                     with basis (1, 667*i, 1/2 + 9*i + 1/2*j, 222075/1334*i + 333/667*j + 1/1334*k)
+              Defn: i |--> 629/667*i + 36/667*j - 36/667*k
+                    j |--> -684/667*i + 648/667*j + 19/667*k
+                    k |--> 684/667*i + 19/667*j + 648/667*k
+            sage: iso(1)
+            1
+            sage: iso(i)
+            629/667*i + 36/667*j - 36/667*k
+            sage: iso(i/3)
+            Traceback (most recent call last):
+            ...
+            TypeError: 1/3*i fails to convert into the map's domain ...
+
+        ::
+
+            sage: gamma = O0.isomorphism_to(O1, conjugator=True); gamma
+            -36 + j + k
+            sage: gamma in O0
+            True
+            sage: gamma in O1
+            True
+            sage: O1.unit_ideal() == ~gamma * O0 * gamma
+            True
+
+        TESTS:
+
+        Some random testing::
+
+            sage: q = randrange(1,1000)
+            sage: p = randrange(1,1000)
+            sage: Quat.<i,j,k> = QuaternionAlgebra(-q, -p)
+            sage: O0 = Quat.maximal_order()
+            sage: while True:
+            ....:     b = Quat.random_element()
+            ....:     if gcd(b.reduced_norm(), Quat.discriminant()) == 1:
+            ....:         break
+            sage: O1 = (b * O0).left_order()
+            sage: iso = O0.isomorphism_to(O1); iso
+            Ring ...
+            sage: iso.domain() == O0
+            True
+            sage: iso.codomain() == O1
+            True
+            sage: iso(O0.random_element()) in O1
+            True
+            sage: iso(1) == 1
+            True
+            sage: els = list(O0.basis())
+            sage: els += [O0.random_element() for _ in range(5)]
+            sage: {iso(g).reduced_norm() == g.reduced_norm() for g in els}
+            {True}
+            sage: {iso(g).reduced_trace() == g.reduced_trace() for g in els}
+            {True}
+            sage: {iso(g * h) == iso(g) * iso(h) for g in els for h in els}
+            {True}
+
+        Test edge case::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(419)
+            sage: O = Quat.quaternion_order([1/2 + 3/2*j + k, 1/18*i + 25/9*j + 5/6*k, 3*j + 2*k, 3*k])
+            sage: Oconj = j.inverse() * O * j
+            sage: Oconj = Quat.quaternion_order(Oconj.basis())
+            sage: O.isomorphism_to(Oconj, conjugator=True)
+            j
+
+        Test error cases::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(-1,-11)
+            sage: O = Quat.maximal_order()
+            sage: O.isomorphism_to('potato')
+            Traceback (most recent call last):
+            ...
+            TypeError: not a quaternion order
+
+        ::
+
+            sage: Quat1.<i1,j1,k1> = QuaternionAlgebra(-1,-11)
+            sage: Quat2.<i2,j2,k2> = QuaternionAlgebra(-3,-11)
+            sage: Quat1.discriminant() == Quat2.discriminant()  # isomorphic
+            True
+            sage: O1 = Quat1.maximal_order()
+            sage: O2 = Quat2.maximal_order()
+            sage: O1.isomorphism_to(O2)
+            Traceback (most recent call last):
+            ...
+            TypeError: not an order in the same quaternion algebra
+
+        ::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(7,11)
+            sage: O1 = Quat.maximal_order()
+            sage: O2 = (O1 * (i+j)).right_order()
+            sage: O1.isomorphism_to(O2)
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: only implemented for definite quaternion orders
+
+        ::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(-1,-11)
+            sage: O1 = Quat.quaternion_order([1, i, j, k])
+            sage: O2 = Quat.quaternion_order([1,-i, j,-k])
+            sage: O1.isomorphism_to(O2)
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: only implemented for maximal orders
+
+        ::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(-1,-11)
+            sage: O1 = Quat.quaternion_order([1, i, (i+j)/2, (1+k)/2])
+            sage: O2 = Quat.quaternion_order([1, (2+i+k)/4, (-11*i+2*j+k)/4, (-5*i+k)/3])
+            sage: O1.isomorphism_to(O2)
+            Traceback (most recent call last):
+            ...
+            ValueError: quaternion orders not isomorphic
+
+        ::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(-5, -17)
+            sage: O1 = Quat.quaternion_order([1, i, j, 1/2 + 1/2*i + 1/2*j + 1/2*k])
+            sage: O2 = Quat.quaternion_order([1/2 + 1/2*i + 1/6*j + 13/6*k, i, 1/3*j + 4/3*k, 3*k])
+            sage: O1.isomorphism_to(O2)
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: isomorphism_to was not able to recognize the given orders as isomorphic
+
+        ALGORITHM:
+
+        Find a generator of the principal lattice `N\cdot O\cdot O'`
+        where `N = [O : O cap O']` using
+        :meth:`QuaternionFractionalIdeal_rational.minimal_element()`.
+        An isomorphism is given by conjugation by such an element.
+        Works providing reduced norm of conjugation element is not
+        a ramified prime times a square. To cover cases where it is
+        we repeat the check for orders conjugated by i, j, and k.
+        """
+
+        # Method to find isomorphism, which might not work when O2 is
+        # O1 conjugated by an alpha such that nrd(alpha) is a
+        # ramified prime times a square
+        def attempt_isomorphism(self, other):
+            N = self.intersection(other).free_module().index_in(self.free_module())
+            I = N * self * other
+            gamma = I.minimal_element()
+            if self*gamma != I:
+                return False, None
+            if gamma*other != I:
+                return False, None
+            return True, gamma
+
+        if not isinstance(other, QuaternionOrder):
+            raise TypeError('not a quaternion order')
+        Q = self.quaternion_algebra()
+        if other.quaternion_algebra() != Q:
+            raise TypeError('not an order in the same quaternion algebra')
+
+        if not isinstance(Q.base_ring(), RationalField):
+            raise NotImplementedError('only implemented for orders in a rational quaternion algebra')
+        if not Q.is_definite():
+            raise NotImplementedError('only implemented for definite quaternion orders')
+        if not (self.discriminant() == Q.discriminant() == other.discriminant()):
+            raise NotImplementedError('only implemented for maximal orders')
+
+        # First try a theta series check, up to bound B
+        if self.unit_ideal().theta_series_vector(B) != other.unit_ideal().theta_series_vector(B):
+            raise ValueError('quaternion orders not isomorphic')
+
+        # Want to iterate over elements alpha where the square-free part of nrd(alpha) divides prod(Q.ramified_primes()),
+        # and each time try attempt_isomorphism with the order conjugated by alpha.
+        # But in general finding all such elements alpha is hard,
+        # so we just try 1, i, j, k first.
+        for alpha in [1] + list(Q.gens()):
+            other_conj = other
+            if alpha != 1:
+                other_conj = Q.quaternion_order((alpha * other * alpha.inverse()).basis())
+            found, gamma = attempt_isomorphism(self, other_conj)
+            if found:
+                gamma = gamma * alpha
+                if conjugator:
+                    return gamma
+                else:
+                    ims = [~gamma * gen * gamma for gen in Q.gens()]
+                    return self.hom(ims, other, check=False)
+
+        # We can tell if 1, i, j, k cover all the alpha we need to test,
+        # by checking if we have additional ramified primes which are not the square-free parts of nrd(i), nrd(j) or nrd(k)
+        a, b = -Q.invariants()[0], -Q.invariants()[1]
+        square_free_invariants = [a.squarefree_part(), b.squarefree_part(), (a*b).squarefree_part()]
+        is_result_guaranteed = len([a for a in Q.ramified_primes() if a not in square_free_invariants]) == 0
+
+        if is_result_guaranteed:
+            raise ValueError('quaternion orders not isomorphic')
+
+        # Otherwise, there might be other unknown alpha's giving isomorphism. If so we can't find them.
+        raise NotImplementedError("isomorphism_to was not able to recognize the given orders as isomorphic")
+
+
+class QuaternionFractionalIdeal(Ideal_fractional):
+    pass
+
+
+class QuaternionFractionalIdeal_rational(QuaternionFractionalIdeal):
+    """
+    A fractional ideal in a rational quaternion algebra.
+
+    INPUT:
+
+    - ``left_order`` -- a quaternion order or ``None``
+
+    - ``right_order`` -- a quaternion order or ``None``
+
+    - ``basis`` -- tuple of length 4 of elements in of ambient
+      quaternion algebra whose `\\ZZ`-span is an ideal
+
+    - ``check`` -- boolean (default: ``True``); if ``False``, do no type
+      checking.
+    """
+    def __init__(self, Q, basis, left_order=None, right_order=None, check=True):
+        """
+        EXAMPLES::
+
+            sage: R = QuaternionAlgebra(-11,-1).maximal_order()
+            sage: R.right_ideal(R.basis())
+            Fractional ideal (1, 1/2 + 1/2*i, j, 1/2*j + 1/2*k)
+            sage: R.right_ideal(tuple(R.basis()), check=False, is_basis=True)
+            Fractional ideal (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+
+        TESTS::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().unit_ideal().gens()
+            (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+
+        Check that :issue:`31582` is fixed::
+
+            sage: BrandtModule(23).right_ideals()[0].parent()                           # needs sage.schemes
+            Monoid of ideals of Quaternion Algebra (-1, -23) with base ring Rational Field
+        """
+        if check:
+            if left_order is not None and not isinstance(left_order, QuaternionOrder):
+                raise TypeError("left_order must be a quaternion order or None")
+            if right_order is not None and not isinstance(right_order, QuaternionOrder):
+                raise TypeError("right_order must be a quaternion order or None")
+            if not isinstance(basis, (list, tuple)):
+                raise TypeError("basis must be a list or tuple")
+            basis = tuple([Q(v) for v in
+                           (QQ**4).span([Q(v).coefficient_tuple() for v in basis], ZZ).basis()])
+            if len(basis) != 4:
+                raise ValueError("fractional ideal must have rank 4")
+        self.__left_order = left_order
+        self.__right_order = right_order
+        Ideal_fractional.__init__(self, Q, basis)
+
+    def scale(self, alpha, left=False):
+        r"""
+        Scale the fractional ideal ``self`` by multiplying the basis
+        by ``alpha``.
+
+        INPUT:
+
+        - `\alpha` -- nonzero element of quaternion algebra
+
+        - ``left`` -- boolean (default: ``False``); if ``True`` multiply
+          `\alpha` on the left, otherwise multiply `\alpha` on the right
+
+        OUTPUT: a new fractional ideal
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: B = BrandtModule(5,37); I = B.right_ideals()[0]
+            sage: i,j,k = B.quaternion_algebra().gens(); I
+            Fractional ideal (4, 148*i, 2 + 106*i + 2*j, 2 + 147*i + k)
+            sage: I.scale(i)
+            Fractional ideal (296, 4*i, 2 + 2*i + 2*j, 212 + 2*i + 2*k)
+            sage: I.scale(i, left=True)
+            Fractional ideal (296, 4*i, 294 + 2*i + 2*j, 84 + 2*i + 2*k)
+            sage: I.scale(i, left=False)
+            Fractional ideal (296, 4*i, 2 + 2*i + 2*j, 212 + 2*i + 2*k)
+            sage: i * I.gens()[0]
+            4*i
+            sage: I.gens()[0] * i
+            4*i
+
+        The scaling element must be nonzero::
+
+            sage: B.<i,j,k> = QuaternionAlgebra(419)
+            sage: O = B.quaternion_order([1/2 + 3/2*j, 1/6*i + 2/3*j + 1/2*k, 3*j, k])
+            sage: O * O.zero()
+            Traceback (most recent call last):
+            ...
+            ValueError: the scaling factor must be nonzero
+
+        TESTS:
+
+        Scaling by `1` should not change anything (see :issue:`32245`)::
+
+            sage: I.scale(1) == I                                                       # needs sage.schemes
+            True
+
+        Check that :issue:`32726` is fixed::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1,-19)
+            sage: I = Q.ideal([1,i,j,k])
+            sage: _ = I.left_order(), I.right_order()   # cache
+            sage: span = lambda L: L.basis_matrix().row_module(ZZ)
+            sage: for left in (True,False):
+            ....:     J = I.scale(1+i+j+k, left=left)
+            ....:     Ol, Or = J.left_order(), J.right_order()
+            ....:     [
+            ....:       span(Ol.unit_ideal() * J) <= span(J),
+            ....:       span(J * Or.unit_ideal()) <= span(J),
+            ....:     ]
+            [True, True]
+            [True, True]
+        """
+        Q = self.quaternion_algebra()
+        alpha = Q(alpha)
+        if alpha.is_zero():
+            raise ValueError("the scaling factor must be nonzero")
+        if left:
+            gens = basis_for_quaternion_lattice([alpha * b for b in self.basis()])
+        else:
+            gens = basis_for_quaternion_lattice([b * alpha for b in self.basis()])
+        left_order = self.__left_order if alpha in QQ or not left else None
+        right_order = self.__right_order if alpha in QQ or left else None
+        return Q.ideal(gens, check=False,
+                       left_order=left_order, right_order=right_order)
+
+    def quaternion_algebra(self):
+        """
+        Return the ambient quaternion algebra that contains this fractional ideal.
+
+        This is an alias for `self.ring()`.
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(3, 5).right_ideals()[1]; I
+            Fractional ideal (8, 40*i, 6 + 28*i + 2*j, 4 + 18*i + 2*k)
+            sage: I.quaternion_algebra()
+            Quaternion Algebra (-1, -3) with base ring Rational Field
+        """
+        return self.ring()
+
+    def _compute_order(self, side='left'):
+        r"""
+        Used internally to compute either the left or right order
+        associated to an ideal in a quaternion algebra.
+
+        INPUT:
+
+        - ``side`` -- ``'left'`` or ``'right'``
+
+        OUTPUT: the left order if ``side='left'``; the right order if ``side='right'``
+
+        EXAMPLES::
+
+            sage: R.<i,j,k> = QuaternionAlgebra(-1,-11)
+            sage: I = R.ideal([2 + 2*j + 140*k, 2*i + 4*j + 150*k, 8*j + 104*k, 152*k])
+            sage: Ol = I._compute_order('left'); Ol
+            Order of Quaternion Algebra (-1, -11) with base ring Rational Field
+             with basis (1/2 + 1/2*j + 35*k, 1/4*i + 1/2*j + 75/4*k, j + 32*k, 38*k)
+            sage: Or = I._compute_order('right'); Or
+            Order of Quaternion Algebra (-1, -11) with base ring Rational Field
+             with basis (1/2 + 1/2*j + 16*k, 1/2*i + 11/2*k, j + 13*k, 19*k)
+            sage: Ol.discriminant()
+            209
+            sage: Or.discriminant()
+            209
+            sage: I.left_order() == Ol
+            True
+            sage: I.right_order() == Or
+            True
+
+        ALGORITHM: Let `b_1, b_2, b_3, b_3` be a basis for this
+        fractional ideal `I`, and assume we want to compute the left
+        order of `I` in the quaternion algebra `Q`.  Then
+        multiplication by `b_i` on the right defines a map `B_i:Q \to
+        Q`.  We have
+
+        .. MATH::
+
+           R = B_1^{-1}(I) \cap B_2^{-1}(I) \cap B_3^{-1}(I)\cap B_4^{-1}(I).
+
+        This is because
+
+        .. MATH::
+
+           B_n^{-1}(I) = \{\alpha \in Q : \alpha b_n \in I \},
+
+        and
+
+        .. MATH::
+
+           R = \{\alpha \in Q : \alpha b_n \in I, n=1,2,3,4\}.
+        """
+        if side == 'left':
+            action = 'right'
+        elif side == 'right':
+            action = 'left'
+        else:
+            raise ValueError("side must be 'left' or 'right'")
+        Q = self.quaternion_algebra()
+        if Q.base_ring() != QQ:
+            raise NotImplementedError("computation of left and right orders only implemented over QQ")
+        M = [(~b).matrix(action=action) for b in self.basis()]
+        B = self.basis_matrix()
+        invs = [B * m for m in M]
+        # Now intersect the row spans of each matrix in invs
+        ISB = [Q(v) for v in intersection_of_row_modules_over_ZZ(invs).row_module(ZZ).basis()]
+        return Q.quaternion_order(ISB)
+
+    def left_order(self):
+        """
+        Return the left order associated to this fractional ideal.
+
+        OUTPUT: an order in a quaternion algebra
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: B = BrandtModule(11)
+            sage: R = B.maximal_order()
+            sage: I = R.unit_ideal()
+            sage: I.left_order()
+            Order of Quaternion Algebra (-1, -11) with base ring Rational Field
+             with basis (1/2 + 1/2*j, 1/2*i + 1/2*k, j, k)
+
+        We do a consistency check::
+
+            sage: # needs sage.schemes
+            sage: B = BrandtModule(11,19); R = B.right_ideals()
+            sage: [r.left_order().discriminant() for r in R]
+            [209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209, 209]
+        """
+        if self.__left_order is None:
+            self.__left_order = self._compute_order(side='left')
+        return self.__left_order
+
+    def right_order(self):
+        """
+        Return the right order associated to this fractional ideal.
+
+        OUTPUT: an order in a quaternion algebra
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(389).right_ideals()[1]; I
+            Fractional ideal (8, 8*i, 2 + 6*i + 2*j, 6 + 3*i + k)
+            sage: I.right_order()
+            Order of Quaternion Algebra (-2, -389) with base ring Rational Field
+             with basis (1/2 + 1/2*j + 1/2*k, 1/4*i + 1/2*j + 1/4*k, j, k)
+            sage: I.left_order()
+            Order of Quaternion Algebra (-2, -389) with base ring Rational Field
+             with basis (1/2 + 1/2*j + 3/2*k, 1/8*i + 1/4*j + 9/8*k, j + k, 2*k)
+
+        The following is a big consistency check.  We take reps for
+        all the right ideal classes of a certain order, take the
+        corresponding left orders, then take ideals in the left orders
+        and from those compute the right order again::
+
+            sage: # needs sage.schemes
+            sage: B = BrandtModule(11,19); R = B.right_ideals()
+            sage: O = [r.left_order() for r in R]
+            sage: J = [O[i].left_ideal(R[i].basis()) for i in range(len(R))]
+            sage: len(set(J))
+            18
+            sage: len(set([I.right_order() for I in J]))
+            1
+            sage: J[0].right_order() == B.order_of_level_N()
+            True
+        """
+        if self.__right_order is None:
+            self.__right_order = self._compute_order(side='right')
+        return self.__right_order
+
+    def __repr__(self):
+        """
+        Return string representation of this quaternion fractional ideal.
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(11).right_ideals()[1]
+            sage: type(I)
+            <class 'sage.algebras.quatalg.quaternion_algebra.QuaternionFractionalIdeal_rational'>
+            sage: I.__repr__()
+            'Fractional ideal (8, 8*i, 6 + 4*i + 2*j, 4 + 2*i + 2*k)'
+        """
+        return 'Fractional ideal %s' % (self.gens(),)
+
+    def random_element(self, *args, **kwds):
+        """
+        Return a random element in the rational fractional ideal ``self``.
+
+        EXAMPLES::
+
+            sage: B.<i,j,k> = QuaternionAlgebra(211)
+            sage: I = B.ideal([1, 1/4*j, 20*(i+k), 2/3*i])
+            sage: I.random_element() in I
+            True
+        """
+        return sum(ZZ.random_element(*args, **kwds) * g for g in self.gens())
+
+    def basis(self):
+        """
+        Return a basis for this fractional ideal.
+
+        OUTPUT: tuple
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().unit_ideal().basis()
+            (1/2 + 1/2*i, 1/2*j - 1/2*k, i, -k)
+        """
+        return self.gens()
+
+    def _richcmp_(self, right, op):
+        """
+        Compare this fractional quaternion ideal to ``right``.
+
+        EXAMPLES::
+
+            sage: I = QuaternionAlgebra(-11, -1).maximal_order().unit_ideal()
+            sage: I == I                # indirect doctest
+            True
+            sage: I == 5
+            False
+
+            sage: J = QuaternionAlgebra(-7, -1).maximal_order().unit_ideal()
+            sage: J == I
+            False
+
+        Ideals can be equal even if they are defined by different
+        bases (see :issue:`32245`)::
+
+            sage: I == I.scale(-1)
+            True
+
+            sage: I != I                # indirect doctest
+            False
+
+        TESTS::
+
+            sage: B = QuaternionAlgebra(QQ,-1,-11)
+            sage: i,j,k = B.gens()
+            sage: I = B.ideal([1,i,j,i*j])
+            sage: I == I
+            True
+            sage: O = B.ideal([1,i,(i+j)/2,(1+i*j)/2])
+            sage: I <= O
+            True
+            sage: I >= O
+            False
+            sage: I != O
+            True
+            sage: I == O
+            False
+            sage: I != I
+            False
+            sage: I < I
+            False
+            sage: I < O
+            True
+            sage: I <= I
+            True
+            sage: O >= O
+            True
+        """
+        return self.free_module().__richcmp__(right.free_module(), op)
+
+    def __hash__(self):
+        """
+        Return the hash of ``self``.
+
+        EXAMPLES::
+
+            sage: I = QuaternionAlgebra(-11,-1).maximal_order().unit_ideal()
+            sage: hash(I) == hash(I)
+            True
+
+        TESTS::
+
+            sage: R = QuaternionAlgebra(-11,-1).maximal_order()
+            sage: H = hash(R.right_ideal(R.basis()))
+        """
+        return hash(self.gens())
+
+    @cached_method
+    def basis_matrix(self):
+        r"""
+        Return basis matrix `M` in Hermite normal form for ``self`` as a
+        matrix with rational entries.
+
+        If `Q` is the ambient quaternion algebra, then the `\ZZ`-span of
+        the rows of `M` viewed as linear combinations of Q.basis() =
+        `[1,i,j,k]` is the fractional ideal ``self``.  Also,
+        ``M * M.denominator()`` is an integer matrix in Hermite normal form.
+
+        OUTPUT: matrix over `\QQ`
+
+        EXAMPLES::
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().unit_ideal().basis_matrix()
+            [1/2 1/2   0   0]
+            [  0   1   0   0]
+            [  0   0 1/2 1/2]
+            [  0   0   0   1]
+        """
+        B = quaternion_algebra_cython.rational_matrix_from_rational_quaternions(self.gens())
+        C, d = B._clear_denom()
+        return C.hermite_form() / d
+
+    def reduced_basis(self):
+        r"""
+        Let `I` = ``self`` be a fractional ideal in a (rational) definite
+        quaternion algebra. This function returns an LLL reduced basis of `I`.
+
+        OUTPUT: a tuple of four elements in `I` forming an LLL reduced basis of
+        `I` as a lattice
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: B = BrandtModule(2,37); I = B.right_ideals()[0]
+            sage: I
+            Fractional ideal (4, 148*i, 108*i + 4*j, 2 + 2*i + 2*j + 2*k)
+            sage: I.reduced_basis()
+            (4, 2 + 2*i + 2*j + 2*k, 2 - 14*i + 14*j - 2*k, 2 - 2*i - 14*j + 14*k)
+            sage: l = I.reduced_basis()
+            sage: assert all(l[i].reduced_norm() <= l[i+1].reduced_norm() for i in range(len(l) - 1))
+
+            sage: B = QuaternionAlgebra(next_prime(2**50))
+            sage: O = B.maximal_order()
+            sage: i,j,k = B.gens()
+            sage: alpha = 1/2 - 1/2*i + 3/2*j - 7/2*k
+            sage: I = O*alpha + O*3089622859
+            sage: I.reduced_basis()[0]
+            1/2*i + j + 5/2*k
+        """
+        if not self.quaternion_algebra().is_definite():
+            raise TypeError("the quaternion algebra must be definite")
+
+        U = self.gram_matrix().LLL_gram().transpose()
+        return tuple(sum(c * g for c, g in zip(row, self.basis())) for row in U)
+
+    def theta_series_vector(self, B):
+        r"""
+        Return theta series coefficients of ``self``, as a vector
+        of `B` integers.
+
+        INPUT:
+
+        - ``B`` -- positive integer
+
+        OUTPUT: vector over `\ZZ` with `B` entries
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(37).right_ideals()[1]; I
+            Fractional ideal (8, 8*i, 2 + 6*i + 2*j, 6 + 3*i + k)
+            sage: I.theta_series_vector(5)
+            (1, 0, 2, 2, 6)
+            sage: I.theta_series_vector(10)
+            (1, 0, 2, 2, 6, 4, 8, 6, 10, 10)
+            sage: I.theta_series_vector(5)
+            (1, 0, 2, 2, 6)
+        """
+        B = Integer(B)
+        try:
+            if len(self.__theta_series_vector) >= B:
+                return self.__theta_series_vector[:B]
+        except AttributeError:
+            pass
+        V = FreeModule(ZZ, B)
+        Q = self.quadratic_form()
+        v = V(Q.representation_number_list(B))
+        self.__theta_series_vector = v
+        return v
+
+    @cached_method
+    def quadratic_form(self):
+        """
+        Return the normalized quadratic form associated to this quaternion ideal.
+
+        OUTPUT: quadratic form
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(11).right_ideals()[1]
+            sage: Q = I.quadratic_form(); Q
+            Quadratic form in 4 variables over Rational Field with coefficients:
+            [ 2 0 3 2 ]
+            [ * 2 2 1 ]
+            [ * * 3 2 ]
+            [ * * * 2 ]
+            sage: Q.theta_series(10)
+            1 + 12*q^2 + 12*q^3 + 12*q^4 + 12*q^5 + 24*q^6 + 24*q^7 + 36*q^8 + 36*q^9 + O(q^10)
+            sage: I.theta_series(10)
+            1 + 12*q^2 + 12*q^3 + 12*q^4 + 12*q^5 + 24*q^6 + 24*q^7 + 36*q^8 + 36*q^9 + O(q^10)
+        """
+        # first get the gram matrix
+        gram_matrix = self.gram_matrix()
+        # rescale so that there are no denominators
+        gram_matrix, _ = gram_matrix._clear_denom()
+        # Make sure gcd of all entries is 1.
+        g = gram_matrix.gcd()
+        if g != 1:
+            gram_matrix = gram_matrix / g
+        # now get the quadratic form
+        return QuadraticForm(gram_matrix)
+
+    def minimal_element(self):
+        r"""
+        Return an element in this quaternion ideal of minimal norm.
+
+        If the ideal is a principal lattice, this method can be used
+        to find a generator; see [Piz1980]_, Corollary 1.20.
+
+        EXAMPLES::
+
+            sage: Quat.<i,j,k> = QuaternionAlgebra(-3,-101)
+            sage: O = Quat.maximal_order(); O
+            Order of Quaternion Algebra (-3, -101) with base ring Rational Field with basis (1/2 + 1/2*i, 1/2*j - 1/2*k, -1/3*i + 1/3*k, -k)
+            sage: (O * 5).minimal_element()
+            5
+            sage: alpha = 1/2 + 1/6*i + j + 55/3*k
+            sage: I = O*141 + O*alpha; I.norm()
+            141
+            sage: el = I.minimal_element(); el
+            13/2 - 7/6*i + j + 2/3*k
+            sage: el.reduced_norm()
+            282
+        """
+        if not self.quaternion_algebra().is_definite():
+            raise ValueError('quaternion algebra must be definite')
+        pariqf = self.quadratic_form().__pari__()
+        _, v = pariqf.qfminim(None, None, 1)
+        return sum(ZZ(c) * g for c, g in zip(v, self.basis()))
+
+    def theta_series(self, B, var='q'):
+        r"""
+        Return normalized theta series of ``self``, as a power series over
+        `\ZZ` in the variable ``var``, which is 'q' by default.
+
+        The normalized theta series is by definition
+
+        .. MATH::
+
+            \theta_I(q) = \sum_{x \in I} q^{\frac{N(x)}{N(I)}}.
+
+        INPUT:
+
+        - ``B`` -- positive integer
+        - ``var`` -- string (default: ``'q'``)
+
+        OUTPUT: power series
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(11).right_ideals()[1]; I
+            Fractional ideal (8, 8*i, 6 + 4*i + 2*j, 4 + 2*i + 2*k)
+            sage: I.norm()
+            32
+            sage: I.theta_series(5)
+            1 + 12*q^2 + 12*q^3 + 12*q^4 + O(q^5)
+            sage: I.theta_series(5,'T')
+            1 + 12*T^2 + 12*T^3 + 12*T^4 + O(T^5)
+            sage: I.theta_series(3)
+            1 + 12*q^2 + O(q^3)
+        """
+        try:
+            if self.__theta_series.prec() >= B:
+                if var == self.__theta_series.variable():
+                    return self.__theta_series.add_bigoh(B)
+                else:
+                    p_ring = self._theta_series.parent().change_var(var)
+                    p_ring(self.__theta_series.list()[:B+1])
+        except AttributeError:
+            pass
+        v = self.theta_series_vector(B)
+        p_ring = PowerSeriesRing(ZZ, var)
+        theta = p_ring(v.list()).add_bigoh(B)
+        self.__theta_series = theta
+        return theta
+
+    @cached_method
+    def gram_matrix(self):
+        r"""
+        Return the Gram matrix of this fractional ideal.
+
+        OUTPUT: `4 \times 4` matrix over `\QQ`
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(3,5).right_ideals()[1]; I
+            Fractional ideal (8, 40*i, 6 + 28*i + 2*j, 4 + 18*i + 2*k)
+            sage: I.gram_matrix()
+            [ 256    0  192  128]
+            [   0 6400 4480 2880]
+            [ 192 4480 3328 2112]
+            [ 128 2880 2112 1408]
+        """
+        A = self.gens()
+        two = QQ(2)
+        m = [two * a.pair(b) for b in A for a in A]
+        M44 = MatrixSpace(QQ, 4, 4)
+        return M44(m, coerce=False)
+
+    def norm(self):
+        """
+        Return the reduced norm of this fractional ideal.
+
+        OUTPUT: rational number
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: M = BrandtModule(37)
+            sage: C = M.right_ideals()
+            sage: [I.norm() for I in C]
+            [16, 32, 32]
+
+            sage: # optional - magma
+            sage: (a,b) = M.quaternion_algebra().invariants()
+            sage: magma.eval('A<i,j,k> := QuaternionAlgebra<Rationals() | %s, %s>' % (a,b))
+            ''
+            sage: magma.eval('O := QuaternionOrder(%s)' % str(list(C[0].right_order().basis())))
+            ''
+            sage: [ magma('rideal<O | %s>' % str(list(I.basis()))).Norm() for I in C]
+            [16, 32, 32]
+
+            sage: # needs sage.schemes
+            sage: A.<i,j,k> = QuaternionAlgebra(-1,-1)
+            sage: R = A.ideal([i,j,k,1/2 + 1/2*i + 1/2*j + 1/2*k])      # this is actually an order, so has reduced norm 1
+            sage: R.norm()
+            1
+            sage: [ J.norm() for J in R.cyclic_right_subideals(3) ]     # enumerate maximal right R-ideals of reduced norm 3, verify their norms
+            [3, 3, 3, 3]
+        """
+        G = self.gram_matrix() / QQ(2)
+        r = G.det().abs()
+        assert r.is_square(), "first is bad!"
+        r = r.sqrt()
+        # If we know either the left- or the right order, use that one to compute the norm.
+        R = self.__left_order or self.__right_order or self.left_order()
+        r /= R.discriminant()
+        assert r.is_square(), "second is bad!"
+        return r.sqrt()
+
+    def conjugate(self):
+        """
+        Return the ideal with generators the conjugates of the generators for ``self``.
+
+        OUTPUT: a quaternionic fractional ideal
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(3,5).right_ideals()[1]; I
+            Fractional ideal (8, 40*i, 6 + 28*i + 2*j, 4 + 18*i + 2*k)
+            sage: I.conjugate()
+            Fractional ideal (2 + 2*j + 28*k, 2*i + 4*j + 34*k, 8*j + 32*k, 40*k)
+        """
+        return self.quaternion_algebra().ideal([b.conjugate() for b in self.basis()],
+                                               left_order=self.__right_order,
+                                               right_order=self.__left_order)
+
+    def __mul__(self, right):
+        """
+        Return the product of the fractional ideals ``self`` and ``right``.
+
+        .. NOTE::
+
+           We do not keep track of left or right order structure.
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(3,5).right_ideals()[1]; I
+            Fractional ideal (8, 40*i, 6 + 28*i + 2*j, 4 + 18*i + 2*k)
+            sage: I*I
+            Fractional ideal (32, 160*i, 24 + 112*i + 8*j, 16 + 72*i + 8*k)
+            sage: I*I.conjugate()
+            Fractional ideal (32, 320*i, 16 + 224*i + 16*j, 16 + 232*i + 8*k)
+            sage: I.multiply_by_conjugate(I)
+            Fractional ideal (32, 320*i, 16 + 224*i + 16*j, 16 + 232*i + 8*k)
+        """
+        if isinstance(right, QuaternionOrder):
+            right = right.unit_ideal()
+        if not isinstance(right, QuaternionFractionalIdeal_rational):
+            return self.scale(right, left=False)
+        gens = [a*b for a in self.basis() for b in right.basis()]
+        # if self.__right_order == right.__left_order:
+        #     left_order = self.__left_order
+        #     right_order = right.__right_order
+        basis = tuple(basis_for_quaternion_lattice(gens))
+        A = self.quaternion_algebra()
+        return A.ideal(basis, check=False)
+
+    def __add__(self, other):
+        """
+        Return the sum of the fractional ideals ``self`` and ``other``.
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: I = BrandtModule(11,5).right_ideals()[1]; I
+            Fractional ideal (8, 40*i, 2 + 20*i + 2*j, 4 + 14*i + 2*k)
+            sage: J = BrandtModule(11,5).right_ideals()[2]; J
+            Fractional ideal (8, 40*i, 6 + 20*i + 2*j, 4 + 34*i + 2*k)
+            sage: I + J
+            Fractional ideal (2 + 2*j, 2*i + 6*k, 4*j, 20*k)
+        """
+        if isinstance(other, QuaternionOrder):
+            other = other.unit_ideal()
+        if not isinstance(other, QuaternionFractionalIdeal_rational):
+            raise TypeError("can only add quaternion ideals")
+        return self.quaternion_algebra().ideal(self.basis() + other.basis())
+
+    def _acted_upon_(self, other, on_left):
+        """
+        Scale a quaternion ideal.
+
+        EXAMPLES::
+
+            sage: Q.<i,j,k> = QuaternionAlgebra(-1,-419)
+            sage: O = Q.maximal_order()
+            sage: I = 7*O.unit_ideal() + O.unit_ideal()*(j-1); I
+            Fractional ideal (1/2 + 13/2*j, 1/2*i + 13/2*k, 7*j, 7*k)
+
+        TESTS::
+
+            sage: (5+i-j)*I == I.scale(5+i-j, left=True)
+            True
+            sage: I*(5+i-j) == I.scale(5+i-j, left=False)
+            True
+        """
+        return self.scale(other, left=(not on_left))
+
+    @cached_method
+    def free_module(self):
+        r"""
+        Return the underlying free `\ZZ`-module corresponding to this ideal.
+
+        OUTPUT: free `\ZZ`-module of rank 4 embedded in an ambient `\QQ^4`
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: X = BrandtModule(3,5).right_ideals()
+            sage: X[0]
+            Fractional ideal (4, 20*i, 2 + 8*i + 2*j, 18*i + 2*k)
+            sage: X[0].free_module()
+            Free module of degree 4 and rank 4 over Integer Ring
+            Echelon basis matrix:
+            [ 2  0  2  8]
+            [ 0  2  0 18]
+            [ 0  0  4 16]
+            [ 0  0  0 20]
+            sage: X[0].scale(1/7).free_module()
+            Free module of degree 4 and rank 4 over Integer Ring
+            Echelon basis matrix:
+            [ 2/7    0  2/7  8/7]
+            [   0  2/7    0 18/7]
+            [   0    0  4/7 16/7]
+            [   0    0    0 20/7]
+
+            sage: QuaternionAlgebra(-11,-1).maximal_order().unit_ideal().basis_matrix()
+            [1/2 1/2   0   0]
+            [  0   1   0   0]
+            [  0   0 1/2 1/2]
+            [  0   0   0   1]
+
+        The free module method is also useful since it allows for checking if
+        one ideal is contained in another, computing quotients `I/J`, etc.::
+
+            sage: # needs sage.schemes
+            sage: X = BrandtModule(3,17).right_ideals()
+            sage: I = X[0].intersection(X[2]); I
+            Fractional ideal (2 + 2*j + 164*k, 2*i + 4*j + 46*k, 16*j + 224*k, 272*k)
+            sage: I.free_module().is_submodule(X[3].free_module())
+            False
+            sage: I.free_module().is_submodule(X[1].free_module())
+            True
+            sage: X[0].free_module() / I.free_module()
+            Finitely generated module V/W over Integer Ring with invariants (4, 4)
+
+        This shows that the issue at :issue:`6760` is fixed::
+
+            sage: R.<i,j,k> = QuaternionAlgebra(-1, -13)
+            sage: I = R.ideal([2+i, 3*i, 5*j, j+k]); I
+            Fractional ideal (2 + i, 3*i, j + k, 5*k)
+            sage: I.free_module()
+            Free module of degree 4 and rank 4 over Integer Ring
+            Echelon basis matrix:
+            [2 1 0 0]
+            [0 3 0 0]
+            [0 0 1 1]
+            [0 0 0 5]
+        """
+        return self.basis_matrix().row_module(ZZ)
+
+    def intersection(self, J):
+        """
+        Return the intersection of the ideals ``self`` and `J`.
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: X = BrandtModule(3,5).right_ideals()
+            sage: I = X[0].intersection(X[1]); I
+            Fractional ideal (2 + 6*j + 4*k, 2*i + 4*j + 34*k, 8*j + 32*k, 40*k)
+        """
+        V = self.free_module().intersection(J.free_module())
+        H, d = V.basis_matrix()._clear_denom()
+        A = self.quaternion_algebra()
+        gens = quaternion_algebra_cython.rational_quaternions_from_integral_matrix_and_denom(A, H, d)
+        return A.ideal(gens)
+
+    def multiply_by_conjugate(self, J):
+        """
+        Return product of ``self`` and the conjugate Jbar of `J`.
+
+        INPUT:
+
+        - ``J`` -- a quaternion ideal
+
+        OUTPUT: a quaternionic fractional ideal
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: R = BrandtModule(3,5).right_ideals()
+            sage: R[0].multiply_by_conjugate(R[1])
+            Fractional ideal (32, 160*i, 8 + 112*i + 8*j, 16 + 72*i + 8*k)
+            sage: R[0]*R[1].conjugate()
+            Fractional ideal (32, 160*i, 8 + 112*i + 8*j, 16 + 72*i + 8*k)
+        """
+        Jbar = [b.conjugate() for b in J.basis()]
+        gens = [a * b for a in self.basis() for b in Jbar]
+        basis = tuple(basis_for_quaternion_lattice(gens))
+        R = self.quaternion_algebra()
+        return R.ideal(basis, check=False)
+
+    def pushforward(self, J, side=None):
+        """
+        Compute the ideal which is the pushforward of ``self`` through an ideal ``J``.
+
+        Uses Lemma 2.1.7 of [Ler2022]_. Only works for integral ideals.
+
+        INPUT:
+
+        - ``J`` -- a fractional quaternion ideal with norm coprime to ``self`` and either
+          the same left order or right order as ``self``
+
+        - ``side`` -- string (default: ``None``); set to ``'left'`` or ``'right'`` to
+          perform pushforward of left or right ideals respectively. If ``None`` the side
+          is determined by the matching left or right orders
+
+        OUTPUT: a fractional quaternion ideal
+
+        EXAMPLES::
+
+            sage: B = QuaternionAlgebra(419)
+            sage: i,j,k = B.gens()
+            sage: I1 = B.ideal([1/2 + 3/2*j + 2*k, 1/2*i + j + 3/2*k, 3*j, 3*k])
+            sage: I2 = B.ideal([1/2 + 9/2*j, 1/2*i + 9/2*k, 5*j, 5*k])
+            sage: I1.left_order() == I2.left_order()
+            True
+            sage: I1.pushforward(I2, side='left')
+            Fractional ideal (3, 15*i, 3/2 + 10*i + 1/2*j, 1 + 9/10*i + 1/10*k)
+
+        TESTS::
+
+            sage: B = QuaternionAlgebra(419)
+            sage: i,j,k = B.gens()
+            sage: O0 = B.maximal_order()
+            sage: O0.unit_ideal().pushforward(O0.unit_ideal())
+            Traceback (most recent call last):
+            ...
+            ValueError: self and J have same left and right orders, side of pushforward must be specified
+            sage: O0.unit_ideal().pushforward(O0.unit_ideal(), "left")
+            Fractional ideal (1, i, 1/2 + 1/2*j, 1/2*i + 1/2*k)
+            sage: I1 = B.ideal([1/2 + 3/2*j + 2*k, 1/2*i + j + 3/2*k, 3*j, 3*k])
+            sage: I2 = B.ideal([1/2 + 9/2*j, 1/2*i + 9/2*k, 5*j, 5*k])
+            sage: I1.pushforward(I2)
+            Fractional ideal (3, 15*i, 3/2 + 10*i + 1/2*j, 1 + 9/10*i + 1/10*k)
+            sage: I1.pushforward(I2, side='right')
+            Traceback (most recent call last):
+            ...
+            ValueError: self and J must have the same right orders
+            sage: I1.conjugate().pushforward(I2.conjugate())
+            Fractional ideal (1/2 + 3/2*j + 10*k, 1/10*i + 2*j + 39/10*k, 3*j, 15*k)
+            sage: I1.conjugate().pushforward(I2.conjugate(), side='left')
+            Traceback (most recent call last):
+            ...
+            ValueError: self and J must have the same left orders
+            sage: I1.pushforward(I1, side='left')
+            Traceback (most recent call last):
+            ...
+            ValueError: self and J must have coprime norms
+            sage: I3 = B.ideal([1/2 + 13/2*j + 6*k, 1/2*i + 3*j + 13/2*k, 9*j, 9*k])
+            sage: I3.pushforward(I3*(1/3), side='left')
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: quaternion ideal pushforward not implemented for non-integral ideals
+        """
+        if not isinstance(J, QuaternionFractionalIdeal_rational):
+            raise TypeError("can only pushforward through a quaternion ideal")
+
+        if side == "left":
+            if self.left_order() != J.left_order():
+                raise ValueError("self and J must have the same left orders")
+            if not self.is_integral() or not J.is_integral():
+                raise NotImplementedError("quaternion ideal pushforward not implemented for non-integral ideals")
+            Jnorm = J.norm()
+            if gcd(self.norm(), Jnorm) != 1:
+                raise ValueError("self and J must have coprime norms")
+            return (1 / Jnorm) * (J.conjugate() * self.intersection(J))
+
+        if side == "right":
+            if self.right_order() != J.right_order():
+                raise ValueError("self and J must have the same right orders")
+            return self.conjugate().pushforward(J.conjugate(), side='left').conjugate()
+
+        if side is None:
+            same_left_order = bool(self.left_order() == J.left_order())
+            same_right_order = bool(self.right_order() == J.right_order())
+            if not same_left_order and not same_right_order:
+                raise ValueError("self and J must share a left or right order")
+            if same_left_order and same_right_order:
+                raise ValueError("self and J have same left and right orders, side of pushforward must be specified")
+            if same_left_order:
+                return self.pushforward(J, side='left')
+            return self.pushforward(J, side='right')
+
+        raise ValueError('side must be "left", "right" or None')
+
+    def pullback(self, J, side=None):
+        """
+        Compute the ideal which is the pullback of ``self`` through an ideal ``J``.
+
+        Uses Lemma 2.1.7 of [Ler2022]_. Only works for integral ideals.
+
+        INPUT:
+
+        - ``J`` -- a fractional quaternion ideal with norm coprime to ``self`` and either
+          left order equal to the right order of ``self``, or vice versa
+
+        - ``side`` -- string (default: ``None``); set to ``'left'`` or ``'right'`` to
+          perform pullback of left or right ideals respectively. If ``None`` the side
+          is determined by the matching left and right orders
+
+        OUTPUT: a fractional quaternion ideal
+
+        EXAMPLES::
+
+            sage: B = QuaternionAlgebra(419)
+            sage: i,j,k = B.gens()
+            sage: I1 = B.ideal([1/2 + 3/2*j + 2*k, 1/2*i + j + 3/2*k, 3*j, 3*k])
+            sage: I2 = B.ideal([1/2 + 9/2*j, 1/2*i + 9/2*k, 5*j, 5*k])
+            sage: I3 = I1.pushforward(I2, side='left')
+            sage: I3.left_order() == I2.right_order()
+            True
+            sage: I3.pullback(I2, side='left') == I1
+            True
+
+        TESTS::
+
+            sage: B = QuaternionAlgebra(419)
+            sage: i,j,k = B.gens()
+            sage: O0 = B.maximal_order()
+            sage: O0.unit_ideal().pullback(O0.unit_ideal())
+            Traceback (most recent call last):
+            ...
+            ValueError: self and J have same left and right orders, side of pullback must be specified
+            sage: O0.unit_ideal().pullback(O0.unit_ideal(), "left")
+            Fractional ideal (1/2 + 1/2*j, 1/2*i + 1/2*k, j, k)
+            sage: I1 = B.ideal([1/2 + 3/2*j + 2*k, 1/2*i + j + 3/2*k, 3*j, 3*k])
+            sage: I2 = B.ideal([1/2 + 15/2*j + 2*k, 1/6*i + 43/3*j + 5/2*k, 15*j, 5*k])
+            sage: I2.pullback(I1)
+            Fractional ideal (1/2 + 5/2*j + 2*k, 1/2*i + 3*j + 5/2*k, 5*j, 5*k)
+            sage: I2.pullback(I1, side='right')
+            Traceback (most recent call last):
+            ...
+            ValueError: right order of self should be left order of J
+            sage: I2.conjugate().pullback(I1.conjugate(), side='right')
+            Fractional ideal (1/2 + 5/2*j + 3*k, 1/2*i + 3*j + 5/2*k, 5*j, 5*k)
+            sage: I2.conjugate().pullback(I1.conjugate(), side='left')
+            Traceback (most recent call last):
+            ...
+            ValueError: left order of self should be right order of J
+            sage: I1.pullback(I1.conjugate(), side='left')
+            Traceback (most recent call last):
+            ...
+            ValueError: self and J must have coprime norms
+            sage: I3 = B.ideal([1/2 + 13/2*j + 6*k, 1/2*i + 3*j + 13/2*k, 9*j, 9*k])
+            sage: I3.pullback(I3.conjugate()*(1/3), side='left')
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: quaternion ideal pullback not implemented for non-integral ideals
+        """
+        if not isinstance(J, QuaternionFractionalIdeal_rational):
+            raise TypeError("can only pullback through a quaternion ideal")
+
+        if side == "left":
+            if self.left_order() != J.right_order():
+                raise ValueError("left order of self should be right order of J")
+            if not self.is_integral() or not J.is_integral():
+                raise NotImplementedError("quaternion ideal pullback not implemented for non-integral ideals")
+            N = self.norm()
+            if gcd(N, J.norm()) != 1:
+                raise ValueError("self and J must have coprime norms")
+            return J*self + N*J.left_order()
+
+        if side == "right":
+            if self.right_order() != J.left_order():
+                raise ValueError("right order of self should be left order of J")
+            return self.conjugate().pullback(J.conjugate(), side='left').conjugate()
+
+        if side is None:
+            is_side_left = bool(self.left_order() == J.right_order())
+            is_side_right = bool(self.right_order() == J.left_order())
+            if not is_side_left and not is_side_right:
+                raise ValueError("left order of self must equal right order of J, or vice versa")
+            if is_side_left and is_side_right:
+                raise ValueError("self and J have same left and right orders, side of pullback must be specified")
+            if is_side_left:
+                return self.pullback(J, side='left')
+            return self.pullback(J, side='right')
+
+        raise ValueError('side must be "left", "right" or None')
+
+    def is_equivalent(self, J, B=10, certificate=False, side=None):
+        r"""
+        Check whether ``self`` and ``J`` are equivalent as ideals.
+        Tests equivalence as right ideals by default. Requires the underlying
+        rational quaternion algebra to be definite.
+
+        INPUT:
+
+        - ``J`` -- a fractional quaternion ideal with same order as ``self``
+
+        - ``B`` -- a bound to compute and compare theta series before
+          doing the full equivalence test
+
+        - ``certificate`` -- if ``True`` returns an element alpha such that
+          alpha*J = I or J*alpha = I for right and left ideals respectively
+
+        - ``side`` -- if ``'left'`` performs left equivalence test. If ``'right'
+          ``or ``None`` performs right ideal equivalence test
+
+        OUTPUT: boolean, or (boolean, alpha) if ``certificate`` is ``True``
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: R = BrandtModule(3,5).right_ideals(); len(R)
+            2
+            sage: OO = R[0].left_order()
+            sage: S = OO.right_ideal([3*a for a in R[0].basis()])
+            sage: R[0].is_equivalent(S)
+            doctest:...: DeprecationWarning: is_equivalent is deprecated,
+            please use is_left_equivalent or is_right_equivalent
+            accordingly instead
+            See https://github.com/sagemath/sage/issues/37100 for details.
+            True
+        """
+        from sage.misc.superseded import deprecation
+        deprecation(37100, 'is_equivalent is deprecated, please use is_left_equivalent'
+                            ' or is_right_equivalent accordingly instead')
+        if side == 'left':
+            return self.is_left_equivalent(J, B, certificate)
+        # If None, assume right ideals, for backwards compatibility
+        return self.is_right_equivalent(J, B, certificate)
+
+    def is_left_equivalent(self, J, B=10, certificate=False):
+        r"""
+        Check whether ``self`` and ``J`` are equivalent as left ideals.
+        Requires the underlying rational quaternion algebra to be definite.
+
+        INPUT:
+
+        - ``J`` -- a fractional quaternion left ideal with same order as ``self``
+
+        - ``B`` -- a bound to compute and compare theta series before
+          doing the full equivalence test
+
+        - ``certificate`` -- if ``True`` returns an element alpha such that J*alpha=I
+
+        OUTPUT: boolean, or (boolean, alpha) if ``certificate`` is ``True``
+        """
+        if certificate:
+            is_equiv, cert = self.conjugate().is_right_equivalent(J.conjugate(), B, True)
+            if is_equiv:
+                return True, cert.conjugate()
+            return False, None
+        return self.conjugate().is_right_equivalent(J.conjugate(), B, False)
+
+    def is_right_equivalent(self, J, B=10, certificate=False):
+        r"""
+        Check whether ``self`` and ``J`` are equivalent as right ideals.
+        Requires the underlying rational quaternion algebra to be definite.
+
+        INPUT:
+
+        - ``J`` -- a fractional quaternion right ideal with same order as ``self``
+
+        - ``B`` -- a bound to compute and compare theta series before
+          doing the full equivalence test
+
+        - ``certificate`` -- if ``True`` returns an element alpha such that alpha*J=I
+
+        OUTPUT: boolean, or (boolean, alpha) if ``certificate`` is ``True``
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: R = BrandtModule(3,5).right_ideals(); len(R)
+            2
+            sage: R[0].is_right_equivalent(R[1])
+            False
+            sage: R[0].is_right_equivalent(R[0])
+            True
+            sage: OO = R[0].left_order()
+            sage: S = OO.right_ideal([3*a for a in R[0].basis()])
+            sage: R[0].is_right_equivalent(S, certificate=True)
+            (True, 1/3)
+            sage: -1/3*S == R[0]
+            True
+
+            sage: B = QuaternionAlgebra(101)
+            sage: i,j,k = B.gens()
+            sage: I = B.maximal_order().unit_ideal()
+            sage: beta = B.random_element()
+            sage: while beta.is_zero():
+            ....:       beta = B.random_element()
+            sage: J = beta*I
+            sage: bool, alpha = I.is_right_equivalent(J, certificate=True)
+            sage: bool
+            True
+            sage: alpha*J == I
+            True
+        """
+        if not isinstance(J, QuaternionFractionalIdeal_rational):
+            raise TypeError('J must be a fractional ideal'
+                          ' in a rational quaternion algebra')
+
+        if self.right_order() != J.right_order():
+            raise ValueError('self and J must be right ideals over the same order')
+
+        if not self.quaternion_algebra().is_definite():
+            raise NotImplementedError('equivalence test of ideals not implemented'
+                                    ' for indefinite quaternion algebras')
+
+        # Just test theta series first; if the theta series are
+        # different, the ideals are definitely not equivalent
+        if B > 0 and self.theta_series_vector(B) != J.theta_series_vector(B):
+            if certificate:
+                return False, None
+            return False
+
+        # The theta series are the same, so perhaps the ideals are equivalent
+        # We adapt Prop 1.18 of [Piz1980]_ to right ideals to decide:
+        # 1. Compute I * Jbar
+        IJbar = self.multiply_by_conjugate(J)
+
+        # 2. Determine if there is alpha in I * Jbar with N(alpha) = N(I)*N(J)
+        # Equivalently, we can simply call the principality test on IJbar,
+        # but we rescale by 1/N(J) to make sure this test directly gives back
+        # the correct alpha if a certificate is requested
+        return (1/J.norm()*IJbar).is_principal(certificate)
+
+    def is_principal(self, certificate=False):
+        r"""
+        Check whether ``self`` is principal as a full rank quaternion ideal.
+        Requires the underlying quaternion algebra to be definite.
+        Independent of whether ``self`` is a left or a right ideal.
+
+        INPUT:
+
+        - ``certificate`` -- if ``True`` returns a generator alpha s.t.
+          `I = \alpha O` where `O` is the right order of `I`
+
+        OUTPUT: boolean, or (boolean, alpha) if ``certificate`` is ``True``
+
+        EXAMPLES::
+
+            sage: B.<i,j,k> = QuaternionAlgebra(419)
+            sage: O = B.quaternion_order([1/2 + 3/2*j, 1/6*i + 2/3*j + 1/2*k, 3*j, k])
+            sage: beta = O.random_element()
+            sage: while beta.is_zero():
+            ....:     beta = O.random_element()
+            sage: I = O*beta
+            sage: bool, alpha = I.is_principal(True)
+            sage: bool
+            True
+            sage: I == O*alpha
+            True
+        """
+        if not self.quaternion_algebra().is_definite():
+            raise NotImplementedError('principality test not implemented in'
+                                    ' indefinite quaternion algebras')
+
+        c = self.theta_series_vector(2)[1]
+        if not certificate:
+            return c != 0
+        if certificate and c == 0:
+            return False, None
+
+        # From this point on we know that self is principal, so it suffices to
+        # find an element of minimal norm in self; see [Piz1980]_, Corollary 1.20.
+        return True, self.minimal_element()
+
+    def __contains__(self, x):
+        """
+        Return whether ``x`` is in ``self``.
+
+        EXAMPLES::
+
+            sage: R.<i,j,k> = QuaternionAlgebra(-3, -13)
+            sage: I = R.ideal([2+i, 3*i, 5*j, j+k])
+            sage: 2+i in I
+            True
+            sage: 2+i+j+k in I
+            True
+            sage: 1+i in I
+            False
+            sage: 101*j + k in I
+            True
+        """
+        try:
+            x = self.quaternion_algebra()(x)
+            return self.basis_matrix().transpose().solve_right(vector(x)) in ZZ**4
+        except (ValueError, TypeError):
+            return False
+
+    @cached_method
+    def cyclic_right_subideals(self, p, alpha=None):
+        r"""
+        Let `I` = ``self``. This function returns the right subideals
+        `J` of `I` such that `I/J` is an `\GF{p}`-vector space of
+        dimension 2.
+
+        INPUT:
+
+        - ``p`` -- prime number (see below)
+
+        - ``alpha`` -- (default: ``None``) element of quaternion algebra,
+          which can be used to parameterize the order of the
+          ideals `J`.  More precisely the `J`'s are the right annihilators
+          of `(1,0) \alpha^i` for `i=0,1,2,...,p`
+
+        OUTPUT: list of right ideals
+
+        .. NOTE::
+
+           Currently, `p` must satisfy a bunch of conditions, or a
+           :exc:`NotImplementedError` is raised.  In particular, `p` must
+           be odd and unramified in the quaternion algebra, must be
+           coprime to the index of the right order in the maximal
+           order, and also coprime to the normal of ``self``.  (The Brandt
+           modules code has a more general algorithm in some cases.)
+
+        EXAMPLES::
+
+            sage: # needs sage.schemes
+            sage: B = BrandtModule(2,37); I = B.right_ideals()[0]
+            sage: I.cyclic_right_subideals(3)
+            [Fractional ideal (12, 444*i, 8 + 404*i + 4*j, 2 + 150*i + 2*j + 2*k),
+             Fractional ideal (12, 444*i, 4 + 256*i + 4*j, 10 + 150*i + 2*j + 2*k),
+             Fractional ideal (12, 444*i, 8 + 256*i + 4*j, 6 + 298*i + 2*j + 2*k),
+             Fractional ideal (12, 444*i, 4 + 404*i + 4*j, 6 + 2*i + 2*j + 2*k)]
+            sage: B = BrandtModule(5,389); I = B.right_ideals()[0]
+            sage: C = I.cyclic_right_subideals(3); C
+            [Fractional ideal (12, 4668*i, 10 + 3426*i + 2*j, 6 + 379*i + k),
+             Fractional ideal (12, 4668*i, 2 + 3426*i + 2*j, 6 + 3491*i + k),
+             Fractional ideal (12, 4 + 1556*i, 6 + 942*i + 6*j, 693*i + 2*j + k),
+             Fractional ideal (12, 8 + 1556*i, 6 + 942*i + 6*j, 2 + 1007*i + 4*j + k)]
+            sage: [(I.free_module()/J.free_module()).invariants() for J in C]
+            [(3, 3), (3, 3), (3, 3), (3, 3)]
+            sage: I.scale(3).cyclic_right_subideals(3)
+            [Fractional ideal (36, 14004*i, 30 + 10278*i + 6*j, 18 + 1137*i + 3*k),
+             Fractional ideal (36, 14004*i, 6 + 10278*i + 6*j, 18 + 10473*i + 3*k),
+             Fractional ideal (36, 12 + 4668*i, 18 + 2826*i + 18*j, 2079*i + 6*j + 3*k),
+             Fractional ideal (36, 24 + 4668*i, 18 + 2826*i + 18*j, 6 + 3021*i + 12*j + 3*k)]
+            sage: C = I.scale(1/9).cyclic_right_subideals(3); C
+            [Fractional ideal (4/3, 1556/3*i, 10/9 + 1142/3*i + 2/9*j, 2/3 + 379/9*i + 1/9*k),
+             Fractional ideal (4/3, 1556/3*i, 2/9 + 1142/3*i + 2/9*j, 2/3 + 3491/9*i + 1/9*k),
+             Fractional ideal (4/3, 4/9 + 1556/9*i, 2/3 + 314/3*i + 2/3*j, 77*i + 2/9*j + 1/9*k),
+             Fractional ideal (4/3, 8/9 + 1556/9*i, 2/3 + 314/3*i + 2/3*j, 2/9 + 1007/9*i + 4/9*j + 1/9*k)]
+            sage: [(I.scale(1/9).free_module()/J.free_module()).invariants() for J in C]
+            [(3, 3), (3, 3), (3, 3), (3, 3)]
+            sage: Q.<i,j,k> = QuaternionAlgebra(-2,-5)
+            sage: I = Q.ideal([Q(1),i,j,k])
+            sage: I.cyclic_right_subideals(3)
+            [Fractional ideal (3, 3*i, 2 + j, i + k),
+             Fractional ideal (3, 3*i, 1 + j, 2*i + k),
+             Fractional ideal (3, 2 + i, 3*j, 2*j + k),
+             Fractional ideal (3, 1 + i, 3*j, j + k)]
+
+        The general algorithm is not yet implemented here::
+
+            sage: I.cyclic_right_subideals(3)[0].cyclic_right_subideals(3)              # needs sage.schemes
+            Traceback (most recent call last):
+            ...
+            NotImplementedError: general algorithm not implemented
+            (The given basis vectors must be linearly independent.)
+        """
+        R = self.right_order()
+        Q = self.quaternion_algebra()
+        basis = basis_for_quaternion_lattice(self.basis(), reverse=False)
+        f = Q.modp_splitting_map(p)
+        if alpha is not None:
+            alpha = f(alpha)
+        W = GF(p)**4
+        try:
+            A = W.span_of_basis([W(f(a).list()) for a in basis])
+            scale = 1
+            IB = matrix(map(list, basis))
+        except (ValueError, ZeroDivisionError):
+            # try rescaling the ideal.
+            B, d = matrix(map(list, basis))._clear_denom()
+            g = gcd(B.list())
+            IB = B / g
+            scale = g / d
+            try:
+                A = W.span_of_basis([W(f(Q(a.list())).list()) for a in IB.rows()])
+            except (ValueError, ZeroDivisionError) as msg:
+                # Here we could replace the ideal by an *equivalent*
+                # ideal that works.  This is always possible.
+                # However, I haven't implemented that algorithm yet.
+                raise NotImplementedError("general algorithm not implemented (%s)" % msg)
+
+        Ai = ~A.basis_matrix()
+        AiB = Ai.change_ring(QQ) * IB
+
+        # Do not care about the denominator since we're really working in I/p*I.
+        AiB, _ = AiB._clear_denom()
+
+        pB = p*IB
+        pB, d = pB._clear_denom()
+
+        ans = []
+        Z = matrix(ZZ, 2, 4)
+
+        P1 = P1List(p)
+        if alpha is None:
+            lines = P1
+        else:
+            x = alpha
+            lines = []
+            for _ in range(p + 1):
+                lines.append(P1.normalize(x[0, 0], x[0, 1]))
+                x *= alpha
+
+        for u, v in lines:
+            # The following does:
+            #    z = matrix(QQ,2,4,[0,-v,0,u, -v,0,u,0],check=False) * AiB
+            Z[0, 1] = -v
+            Z[0, 3] = u
+            Z[1, 0] = -v
+            Z[1, 2] = u
+            z = Z * AiB
+            # Now construct submodule of the ideal I spanned by the
+            # linear combinations given by z of the basis for J along
+            # with p*I.
+            G = (d*z).stack(pB)  # have to multiply by d since we divide by it below in the "gens = " line.
+            H = G._hnf_pari(0, include_zero_rows=False)
+            gens = tuple(quaternion_algebra_cython.rational_quaternions_from_integral_matrix_and_denom(Q, H, d))
+            if scale != 1:
+                gens = tuple([scale * gg for gg in gens])
+            J = R.right_ideal(gens, check=False)
+            ans.append(J)
+        return ans
+
+    def is_integral(self) -> bool:
+        r"""
+        Check whether the quaternion fractional ideal ``self`` is integral.
+
+        An ideal in a quaternion algebra is integral if and only if it is
+        contained in its left order. If the left order is already defined
+        this method just checks this definition, otherwise it uses one
+        of the alternative definitions from Lemma 16.2.8 of [Voi2021]_.
+
+        EXAMPLES::
+
+            sage: R.<i,j,k> = QuaternionAlgebra(QQ, -1,-11)
+            sage: I = R.ideal([2 + 2*j + 140*k, 2*i + 4*j + 150*k, 8*j + 104*k, 152*k])
+            sage: I.is_integral()
+            True
+            sage: O = I.left_order()
+            sage: I.is_integral()
+            True
+            sage: I = R.ideal([1/2 + 2*j + 140*k, 2*i + 4*j + 150*k, 8*j + 104*k, 152*k])
+            sage: I.is_integral()
+            False
+        """
+        if self.__left_order is not None:
+            return self.free_module() <= self.left_order().free_module()
+        elif self.__right_order is not None:
+            return self.free_module() <= self.right_order().free_module()
+        else:
+            self_square = self**2
+            return self_square.free_module() <= self.free_module()
+
+    def primitive_decomposition(self):
+        r"""
+        Let `I` = ``self``. If `I` is an integral left `\mathcal{O}`-ideal return its decomposition
+        as an equivalent primitive ideal and an integer such that their product is the initial ideal.
+
+        OUTPUTS: A primitive ideal equivalent to `I`, i.e. an equivalent ideal not contained
+        in `n\mathcal{O}` for any `n>0`, and the smallest integer `g` such that `I \subset g\mathcal{O}`.
+
+        EXAMPLES::
+
+            sage: A.<i,j,k> = QuaternionAlgebra(QQ, -1,-11)
+            sage: I = A.ideal([1/2 + 1/2*i + 1/2*j + 3/2*k, i + k, j + k, 2*k])
+            sage: I.primitive_decomposition()
+            (Fractional ideal (1/2 + 1/2*i + 1/2*j + 3/2*k, i + k, j + k, 2*k), 1)
+            sage: J = A.ideal([7/2 + 7/2*i + 49/2*j + 91/2*k, 7*i + 21*k, 35*j + 35*k, 70*k])
+            sage: Jequiv, g = J.primitive_decomposition()
+            sage: Jequiv*g == J
+            True
+            sage: Jequiv, g
+            (Fractional ideal (10, 5 + 5*i, 3 + j, 13/2 + 7/2*i + 1/2*j + 1/2*k), 7)
+
+        TESTS:
+
+        Check that randomly generated ideals decompose as expected::
+
+            sage: for d in ( m for m in range(400, 750) if is_squarefree(m) ):        # long time (7s)
+            ....:     A = QuaternionAlgebra(d)
+            ....:     O = A.maximal_order()
+            ....:     for _ in range(10):
+            ....:         a = O.random_element()
+            ....:         if not a.is_constant(): # avoids a = 0
+            ....:             I = a*O + a.reduced_norm()*O
+            ....:             if I.is_integral():
+            ....:                 J,g = I.primitive_decomposition()
+            ....:                 assert J*g == I
+            ....:                 assert J.is_primitive()
+        """
+        if not self.is_integral():
+            raise ValueError("primitive ideals are defined only for integral ideals")
+
+        I_basis = self.basis_matrix()
+        O_basis = self.left_order().basis_matrix()
+
+        # Write I in the basis of its left order via rref
+        M = O_basis.solve_left(I_basis)
+        g = Integer(gcd(M.list()))
+
+        # If g is 1 then the ideal is primitive
+        if g.is_one():
+            return self, g
+
+        J = self.scale(1/g)
+
+        return J, g
+
+    def is_primitive(self) -> bool:
+        r"""
+        Check whether the quaternion fractional ideal ``self`` is primitive.
+
+        An integral left `\mathcal{O}`-ideal for some order `\mathcal{O}`
+        is called primitive if for all integers `n > 1` it is not
+        contained in `n\mathcal{O}`.
+
+        EXAMPLES::
+
+            sage: A.<i,j,k> = QuaternionAlgebra(QQ, -1,-11)
+            sage: I = A.ideal([1/2 + 1/2*i + 1/2*j + 3/2*k, i + k, j + k, 2*k])
+            sage: I.is_primitive()
+            True
+            sage: (2*I).is_primitive()
+            False
+        """
+        _, g = self.primitive_decomposition()
+        return g.is_one()
+
+#######################################################################
+# Some utility functions that are needed here and are too
+# specialized to go elsewhere.
+#######################################################################
+
+
+def basis_for_quaternion_lattice(gens, reverse=True):
+    r"""
+    Return a basis for the `\ZZ`-lattice in a quaternion algebra
+    spanned by the given gens.
+
+    INPUT:
+
+    - ``gens`` -- list of elements of a single quaternion algebra
+
+    - ``reverse`` -- when computing the HNF do it on the basis
+      `(k,j,i,1)` instead of `(1,i,j,k)`; this ensures that if
+      ``gens`` are the generators for a fractional ideal (in
+      particular, an order), the first returned basis vector
+      equals the norm of the ideal (in case of an order, `1`)
+
+    EXAMPLES::
+
+        sage: from sage.algebras.quatalg.quaternion_algebra import basis_for_quaternion_lattice
+        sage: A.<i,j,k> = QuaternionAlgebra(-1,-7)
+        sage: basis_for_quaternion_lattice([i+j, i-j, 2*k, A(1/3)])
+        [1/3, 2*i, i + j, 2*k]
+        sage: basis_for_quaternion_lattice([A(1),i,j,k])
+        [1, i, j, k]
+    """
+    if not gens:
+        return []
+    Z, d = quaternion_algebra_cython.integral_matrix_and_denom_from_rational_quaternions(gens, reverse)
+    H = Z._hnf_pari(0, include_zero_rows=False)
+    A = gens[0].parent()
+    return quaternion_algebra_cython.rational_quaternions_from_integral_matrix_and_denom(A, H, d, reverse)
+
+
+def intersection_of_row_modules_over_ZZ(v):
+    r"""
+    Intersect the `\ZZ`-modules with basis matrices the full rank `4 \times 4`
+    `\QQ`-matrices in the list v.
+
+    The returned intersection is
+    represented by a `4 \times 4` matrix over `\QQ`.  This can also be done
+    using modules and intersection, but that would take over twice as long
+    because of overhead, hence this function.
+
+    EXAMPLES::
+
+        sage: a = matrix(QQ,4,[-2, 0, 0, 0, 0, -1, -1, 1, 2, -1/2, 0, 0, 1, 1, -1, 0])
+        sage: b = matrix(QQ,4,[0, -1/2, 0, -1/2, 2, 1/2, -1, -1/2, 1, 2, 1, -2, 0, -1/2, -2, 0])
+        sage: c = matrix(QQ,4,[0, 1, 0, -1/2, 0, 0, 2, 2, 0, -1/2, 1/2, -1, 1, -1, -1/2, 0])
+        sage: v = [a,b,c]
+        sage: from sage.algebras.quatalg.quaternion_algebra import intersection_of_row_modules_over_ZZ
+        sage: M = intersection_of_row_modules_over_ZZ(v); M
+        [   2    0   -1   -1]
+        [  -4    1    1   -3]
+        [  -3 19/2   -1   -4]
+        [   2   -3   -8    4]
+        sage: M2 = a.row_module(ZZ).intersection(b.row_module(ZZ)).intersection(c.row_module(ZZ))
+        sage: M.row_module(ZZ) == M2
+        True
+    """
+    if len(v) <= 0:
+        raise ValueError("v must have positive length")
+    if len(v) == 1:
+        return v[0]
+    elif len(v) == 2:
+        # real work - the base case
+        a, b = v
+        s, _ = a.stack(b)._clear_denom()
+        s = s.transpose()
+        K = s.right_kernel_matrix(algorithm='pari', basis='computed')
+        n = a.nrows()
+        return K.matrix_from_columns(range(n)) * a
+    else:
+        # induct
+        w = intersection_of_row_modules_over_ZZ(v[:2])
+        return intersection_of_row_modules_over_ZZ([w] + v[2:])
+
+
+def normalize_basis_at_p(e, p, B=QuaternionAlgebraElement_abstract.pair):
+    r"""
+    Compute a (at ``p``) normalized basis from the given basis ``e``
+    of a `\ZZ`-module.
+
+    The returned basis is (at ``p``) a `\ZZ_p` basis for the same
+    module, and has the property that with respect to it the quadratic
+    form induced by the bilinear form B is represented as a orthogonal
+    sum of atomic forms multiplied by p-powers.
+
+    If `p \neq 2` this means that the form is diagonal with respect to
+    this basis.
+
+    If `p = 2` there may be additional 2-dimensional subspaces on which
+    the form is represented as `2^e (ax^2 + bxy + cx^2)` with
+    `0 = v_2(b) = v_2(a) \leq v_2(c)`.
+
+    INPUT:
+
+    - ``e`` -- list; basis of a `\ZZ` module
+      (WARNING: will be modified!)
+
+    - ``p`` -- prime for at which the basis should be normalized
+
+    - ``B`` --
+      (default: :meth:`QuaternionAlgebraElement_abstract.pair`)
+      a bilinear form with respect to which to normalize
+
+    OUTPUT:
+
+    - A list containing two-element tuples: The first element of
+      each tuple is a basis element, the second the valuation of
+      the orthogonal summand to which it belongs. The list is sorted
+      by ascending valuation.
+
+    EXAMPLES::
+
+        sage: from sage.algebras.quatalg.quaternion_algebra import normalize_basis_at_p
+        sage: A.<i,j,k> = QuaternionAlgebra(-1, -1)
+        sage: e = [A(1), i, j, k]
+        sage: normalize_basis_at_p(e, 2)
+        [(1, 0), (i, 0), (j, 0), (k, 0)]
+
+        sage: A.<i,j,k> = QuaternionAlgebra(210)
+        sage: e = [A(1), i, j, k]
+        sage: normalize_basis_at_p(e, 2)
+        [(1, 0), (i, 1), (j, 1), (k, 2)]
+
+        sage: A.<i,j,k> = QuaternionAlgebra(286)
+        sage: e = [A(1), k, 1/2*j + 1/2*k, 1/2 + 1/2*i + 1/2*k]
+        sage: normalize_basis_at_p(e, 5)
+        [(1, 0), (1/2*j + 1/2*k, 0), (-5/6*j + 1/6*k, 1), (1/2*i, 1)]
+
+        sage: A.<i,j,k> = QuaternionAlgebra(-1,-7)
+        sage: e = [A(1), k, j, 1/2 + 1/2*i + 1/2*j + 1/2*k]
+        sage: normalize_basis_at_p(e, 2)
+        [(1, 0), (1/2 + 1/2*i + 1/2*j + 1/2*k, 0), (-34/105*i - 463/735*j + 71/105*k, 1),
+         (1/7*i - 8/49*j + 1/7*k, 1)]
+
+    TESTS:
+
+    We check that the second part of :issue:`37217` is fixed::
+
+        sage: A.<i,j,k> = QuaternionAlgebra(-1,-7)
+        sage: e = [A(1), k, j, 1/2 + 1/2*i + 1/2*j + 1/2*k]
+        sage: e_norm = normalize_basis_at_p(e, 2)
+        sage: V = QQ**4
+        sage: V.span([V(x.coefficient_tuple()) for (x,_) in e_norm]).dimension()
+        4
+    """
+
+    N = len(e)
+    if N == 0:
+        return []
+    else:
+        min_m, min_n, min_v = 0, 0, infinity
+
+        # Find two basis vector on which the bilinear form has minimal
+        # p-valuation. If there is more than one such pair, always
+        # prefer diagonal entries over any other and (secondary) take
+        # min_m and then min_n as small as possible
+        for m in range(N):
+            for n in range(m, N):
+                v = B(e[m], e[n]).valuation(p)
+                if v < min_v or (v == min_v and (min_m != min_n) and (m == n)):
+                    min_m, min_n, min_v = m, n, v
+
+        if (min_m == min_n) or p != 2:      # In this case we can diagonalize
+            if min_m == min_n:              # Diagonal entry has minimal valuation
+                f0 = e[min_m]
+            else:
+                f0 = e[min_m] + e[min_n]    # Only off-diagonal entries have min. val., but p!=2
+
+            # Swap with first vector
+            e[0], e[min_m] = e[min_m], e[0]
+
+            # Orthogonalize remaining vectors with respect to f
+            c = B(f0, f0)
+            for l in range(1, N):
+                e[l] = e[l] - B(e[l], f0) / c * f0
+
+            # Recursively normalize remaining vectors
+            f = normalize_basis_at_p(e[1:], p)
+            f.insert(0, (f0, min_v - valuation(p, 2)))
+            return f
+
+        else:   # p = 2 and only off-diagonal entries have min. val., gives 2-dim. block
+            # first diagonal entry should have smaller valuation
+            if B(e[min_m], e[min_m]).valuation(p) > B(e[min_n], e[min_n]).valuation(p):
+                e[min_m], e[min_n] = e[min_n], e[min_m]
+
+            f0 = p**min_v / B(e[min_m], e[min_n]) * e[min_m]
+            f1 = e[min_n]
+
+            # Ensures that (B(f0,f0)/2).valuation(p) <= B(f0,f1).valuation(p)
+            if B(f0, f1).valuation(p) + 1 < B(f0, f0).valuation(p):
+                g = f0
+                f0 += f1
+                f1 = g
+
+            # Make remaining vectors orthogonal to span of f0, f1
+            e[min_m] = e[0]
+            e[min_n] = e[1]
+
+            B00 = B(f0, f0)
+            B11 = B(f1, f1)
+            B01 = B(f0, f1)
+            d = B00 * B11 - B01**2
+            tu = [(B01 * B(f1, e[l]) - B11 * B(f0, e[l]),
+                   B01 * B(f0, e[l]) - B00 * B(f1, e[l])) for l in range(2, N)]
+
+            e[2:N] = [e[l] + tu[l-2][0]/d * f0 + tu[l-2][1]/d * f1 for l in range(2, N)]
+
+            # Recursively normalize remaining vectors
+            f = normalize_basis_at_p(e[2:N], p)
+            return [(f0, min_v), (f1, min_v)] + f
+
+
+def maxord_solve_aux_eq(a, b, p):
+    r"""
+    Given ``a`` and ``b`` and an even prime ideal ``p`` find
+    (y,z,w) with y a unit mod `p^{2e}` such that
+
+    .. MATH::
+
+        1 - ay^2 - bz^2 + abw^2 \equiv 0 mod p^{2e},
+
+    where `e` is the ramification index of `p`.
+
+    Currently only `p=2` is implemented by hardcoding solutions.
+
+    INPUT:
+
+    - ``a`` -- integer with `v_p(a) = 0`
+
+    - ``b`` -- integer with `v_p(b) \in \{0,1\}`
+
+    - ``p`` -- even prime ideal (actually only ``p=ZZ(2)`` is implemented)
+
+    OUTPUT: a tuple `(y, z, w)`
+
+    EXAMPLES::
+
+        sage: from sage.algebras.quatalg.quaternion_algebra import maxord_solve_aux_eq
+        sage: for a in [1,3]:
+        ....:     for b in [1,2,3]:
+        ....:         (y,z,w) = maxord_solve_aux_eq(a, b, 2)
+        ....:         assert mod(y, 4) == 1 or mod(y, 4) == 3
+        ....:         assert mod(1 - a*y^2 - b*z^2 + a*b*w^2, 4) == 0
+    """
+    if p != ZZ(2):
+        raise NotImplementedError("algorithm only implemented over ZZ at the moment")
+
+    v_a = a.valuation(p)
+    v_b = b.valuation(p)
+
+    if v_a != 0:
+        raise RuntimeError("a must have v_p(a)=0")
+    if v_b != 0 and v_b != 1:
+        raise RuntimeError("b must have v_p(b) in {0,1}")
+
+    R = ZZ.quo(ZZ(4))
+    lut = {(R(1), R(1)): (1, 1, 1),
+           (R(1), R(2)): (1, 0, 0),
+           (R(1), R(3)): (1, 0, 0),
+           (R(3), R(1)): (1, 1, 1),
+           (R(3), R(2)): (1, 0, 1),
+           (R(3), R(3)): (1, 1, 1)}
+
+    return lut[(R(a), R(b))]