isaacscript-common 87.4.0 → 87.5.1

package/src/classes/callbacks/PostNPCStateChanged.ts

@@ -8,7 +8,7 @@ import { CustomCallback } from "../private/CustomCallback";
 const v = {
   run: {
     stateMap: new DefaultMap<PtrHash, NPCState, [NPCState]>(
-      (state) => state, // eslint-disable-line isaacscript/strict-enums
+      (state) => state, // eslint-disable-line complete/strict-enums
     ),
   },
 };

package/src/classes/callbacks/PostNewRoomEarly.ts

@@ -21,7 +21,7 @@ export class PostNewRoomEarly extends CustomCallback<ModCallbackCustom.POST_NEW_
 
     this.callbacksUsed = [
       // 19
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_NEW_ROOM, this.postNewRoom],
 
       // 24

package/src/classes/callbacks/PostPlayerChangeType.ts

@@ -15,7 +15,7 @@ const v = {
       PlayerIndex,
       PlayerType,
       [character: PlayerType]
-    >((character: PlayerType) => character), // eslint-disable-line isaacscript/strict-enums
+    >((character: PlayerType) => character), // eslint-disable-line complete/strict-enums
   },
 };
 

package/src/classes/callbacks/PostTransformation.ts

@@ -55,9 +55,7 @@ export class PostTransformation extends CustomCallback<T> {
     for (const playerForm of PLAYER_FORM_VALUES) {
       const hasForm = player.HasPlayerForm(playerForm);
       let storedForm = playerTransformationsMap.get(playerForm);
-      if (storedForm === undefined) {
-        storedForm = false;
-      }
+      storedForm ??= false;
 
       if (hasForm !== storedForm) {
         playerTransformationsMap.set(playerForm, hasForm);

package/src/classes/callbacks/PostTrinketBreak.ts

@@ -55,9 +55,7 @@ export class PostTrinketBreak extends CustomCallback<ModCallbackCustom.POST_TRIN
     for (const trinketType of TRINKETS_THAT_CAN_BREAK) {
       const numTrinketsHeld = player.GetTrinketMultiplier(trinketType);
       let oldNumTrinketsHeld = trinketMap.get(trinketType);
-      if (oldNumTrinketsHeld === undefined) {
-        oldNumTrinketsHeld = 0;
-      }
+      oldNumTrinketsHeld ??= 0;
 
       if (numTrinketsHeld >= oldNumTrinketsHeld) {
         continue;

package/src/classes/features/callbackLogic/CustomGridEntities.ts

@@ -348,7 +348,7 @@ export class CustomGridEntities extends Feature {
    * @public
    */
   @Exported
-  public getCustomGridEntities(): Array<{
+  public getCustomGridEntities(): ReadonlyArray<{
     gridEntity: GridEntity;
     data: GridEntityCustomData;
   }> {

package/src/classes/features/callbackLogic/GameReorderedCallbacks.ts

@@ -60,18 +60,18 @@ export class GameReorderedCallbacks extends Feature {
       [ModCallback.POST_PLAYER_INIT, this.postPlayerInit],
 
       // 15
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_GAME_STARTED, this.postGameStarted],
 
       // 17
       [ModCallback.PRE_GAME_EXIT, this.preGameExit],
 
       // 18
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_NEW_LEVEL, this.postNewLevel],
 
       // 19
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_NEW_ROOM, this.postNewRoom],
     ];
 
@@ -93,9 +93,7 @@ export class GameReorderedCallbacks extends Feature {
 
   // ModCallback.POST_PLAYER_INIT (9)
   private readonly postPlayerInit = (_player: EntityPlayer): void => {
-    if (this.renderFrameRunStarted === null) {
-      this.renderFrameRunStarted = Isaac.GetFrameCount();
-    }
+    this.renderFrameRunStarted ??= Isaac.GetFrameCount();
   };
 
   // ModCallback.POST_GAME_STARTED (15)

package/src/classes/features/callbackLogic/ItemPickupDetection.ts

@@ -5,6 +5,7 @@ import type {
 import { ItemType } from "isaac-typescript-definitions";
 import { ModCallbackCustom } from "../../../enums/ModCallbackCustom";
 import { defaultMapGetPlayer } from "../../../functions/playerDataStructures";
+import { dequeueItem } from "../../../functions/players";
 import { asNumber } from "../../../functions/types";
 import type { PickingUpItem } from "../../../types/PickingUpItem";
 import {
@@ -78,7 +79,7 @@ export class ItemPickupDetection extends Feature {
   private queueNotEmpty(player: EntityPlayer, pickingUpItem: PickingUpItem) {
     const queuedItem = player.QueuedItem.Item;
     if (queuedItem === undefined || queuedItem.Type === ItemType.NULL) {
-      // This should never happen, since the `EntityPlayer.IsItemQueueEmpty` method returned true.
+      // This should never happen, since the `EntityPlayer.IsItemQueueEmpty` method returned false.
       return;
     }
 
@@ -90,7 +91,10 @@ export class ItemPickupDetection extends Feature {
       pickingUpItem.itemType = queuedItem.Type;
       pickingUpItem.subType = queuedItem.ID as CollectibleType | TrinketType;
 
-      this.preItemPickup.fire(player, pickingUpItem);
+      const shouldBeGranted = this.preItemPickup.fire(player, pickingUpItem);
+      if (shouldBeGranted === false) {
+        dequeueItem(player);
+      }
     }
   }
 }

package/src/classes/features/callbackLogic/PlayerReorderedCallbacks.ts

@@ -48,15 +48,15 @@ export class PlayerReorderedCallbacks extends Feature {
 
     this.callbacksUsed = [
       // 4
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_PEFFECT_UPDATE, this.postPEffectUpdate],
 
       // 31
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_PLAYER_UPDATE, this.postPlayerUpdate],
 
       // 32
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_PLAYER_RENDER, this.postPlayerRender],
     ];
 
@@ -125,7 +125,7 @@ export class PlayerReorderedCallbacks extends Feature {
 }
 
 function dequeue(
-  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
+  // eslint-disable-next-line complete/prefer-readonly-parameter-types
   queue: QueueElement[],
   fireFunc: (player: EntityPlayer, renderOffset: Vector) => void,
 ) {

package/src/classes/features/other/CustomPickups.ts

@@ -96,6 +96,7 @@ export class CustomPickups extends Feature {
   // ModCallback.POST_EFFECT_RENDER (56)
   // PICKUP_EFFECT_VARIANT
   private readonly postEffectRenderPickupEffect = (effect: EntityEffect) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
     if (effect.SubType !== PICKUP_EFFECT_SUB_TYPE) {
       return;
     }

package/src/classes/features/other/CustomStages.ts

@@ -300,7 +300,7 @@ export class CustomStages extends Feature {
     const level = game.GetLevel();
     const stage = customStage.baseStage ?? DEFAULT_BASE_STAGE;
     const stageType = customStage.baseStageType ?? DEFAULT_BASE_STAGE_TYPE;
-    level.SetStage(stage, stageType); // eslint-disable-line isaacscript/strict-enums
+    level.SetStage(stage, stageType); // eslint-disable-line complete/strict-enums
 
     return undefined;
   };
@@ -523,7 +523,7 @@ export class CustomStages extends Feature {
         ? DEFAULT_BASE_STAGE
         : (customStage.baseStage as LevelStage);
     if (!firstFloor) {
-      baseStage++; // eslint-disable-line isaacscript/strict-enums
+      baseStage++; // eslint-disable-line complete/strict-enums
     }
 
     const baseStageType: StageType =

package/src/classes/features/other/CustomTrapdoors.ts

@@ -59,7 +59,10 @@ import { CUSTOM_FLOOR_STAGE } from "./customStages/constants";
 
 const DEBUG = false as boolean;
 
-/** This also applies to crawl spaces. The value was determined through trial and error. */
+/**
+ * This also applies to crawl spaces. The value was determined through trial and error to match
+ * vanilla behavior.
+ */
 const TRAPDOOR_OPEN_DISTANCE = 60;
 
 const TRAPDOOR_OPEN_DISTANCE_AFTER_BOSS = TRAPDOOR_OPEN_DISTANCE * 2.5;
@@ -265,16 +268,14 @@ export class CustomTrapdoors extends Feature {
   }
 
   private goToCustomTrapdoorDestination() {
-    if (v.run.customTrapdoorActivated === null) {
-      // This should never happen; provide some sane default values.
-      v.run.customTrapdoorActivated = {
-        destinationName: undefined,
-        destinationStage: LevelStage.BASEMENT_1,
-        destinationStageType: StageType.ORIGINAL,
-        open: true,
-        firstSpawn: true,
-      };
-    }
+    // This should never be null. Regardless, we provide some sane default values.
+    v.run.customTrapdoorActivated ??= {
+      destinationName: undefined,
+      destinationStage: LevelStage.BASEMENT_1,
+      destinationStageType: StageType.ORIGINAL,
+      open: true,
+      firstSpawn: true,
+    };
 
     const destinationFunc = this.getDestinationFunc(
       v.run.customTrapdoorActivated,
@@ -417,6 +418,15 @@ export class CustomTrapdoors extends Feature {
   ): void {
     /** By default, trapdoors will never close if they are already open. */
     if (trapdoorDescription.open) {
+      // Sometimes, the `sprite.Play(TrapdoorAnimation.OPEN_ANIMATION, true)` function does not take
+      // effect. Check for this case.
+      const sprite = gridEntity.GetSprite();
+      const animation = sprite.GetAnimation();
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
+      if (animation === TrapdoorAnimation.CLOSED) {
+        // Try it again.
+        sprite.Play(TrapdoorAnimation.OPEN_ANIMATION, true);
+      }
       return;
     }
 
@@ -752,13 +762,8 @@ export class CustomTrapdoors extends Feature {
       );
     }
 
-    if (destinationStage === undefined) {
-      destinationStage = this.stageHistory.getNextStageWithHistory();
-    }
-
-    if (destinationStageType === undefined) {
-      destinationStageType = this.stageHistory.getNextStageTypeWithHistory();
-    }
+    destinationStage ??= this.stageHistory.getNextStageWithHistory();
+    destinationStageType ??= this.stageHistory.getNextStageTypeWithHistory();
 
     const room = game.GetRoom();
     const roomListIndex = getRoomListIndex();

package/src/classes/features/other/DeployJSONRoom.ts

@@ -162,6 +162,7 @@ export class DeployJSONRoom extends Feature {
     let entity: Entity;
     if (
       entityType === EntityType.PICKUP &&
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
       variant === PickupVariant.COLLECTIBLE
     ) {
       const collectibleType = asCollectibleType(subType);
@@ -174,6 +175,7 @@ export class DeployJSONRoom extends Feature {
     // For some reason, Pitfalls do not spawn with the correct collision classes.
     if (
       entityType === EntityType.PITFALL &&
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
       variant === PitfallVariant.PITFALL
     ) {
       entity.EntityCollisionClass = EntityCollisionClass.ENEMIES;

package/src/classes/features/other/EdenStartingStatsHealth.ts

@@ -130,7 +130,9 @@ export class EdenStartingStatsHealth extends Feature {
    * @public
    */
   @Exported
-  public getEdenStartingCollectibles(player: EntityPlayer): CollectibleType[] {
+  public getEdenStartingCollectibles(
+    player: EntityPlayer,
+  ): readonly CollectibleType[] {
     const collectibleTypes: CollectibleType[] = [];
 
     const activeCollectibleType = mapGetPlayer(

package/src/classes/features/other/ExtraConsoleCommands.ts

@@ -24,7 +24,8 @@ declare let __ISAACSCRIPT_COMMON_EXTRA_CONSOLE_COMMANDS_FEATURE:
 
 /**
  * When you enable this feature, many custom commands will be added to the in-game console. See the
- * [dedicated command list](ExtraConsoleCommandsList) for more information about them.
+ * [dedicated command list](/isaacscript-common/features/ExtraConsoleCommandsList) for more
+ * information about them.
  *
  * Note that in order to avoid conflicts, if two or more mods enable this feature, then the first
  * loaded one will control all of the command logic. When this occurs, a global variable of
@@ -241,10 +242,11 @@ export class ExtraConsoleCommands extends Feature {
   /**
    * Helper function to add a custom console command.
    *
-   * The standard library comes with [many existing console commands](ExtraConsoleCommandsList) that
-   * are useful for debugging, but you can also add your own commands that are useful for your
-   * particular mod. It's easier to add commands to the existing command system than to add your own
-   * logic manually to the `EXECUTE_CMD` callback.
+   * The standard library comes with [many existing console
+   * commands](/isaacscript-common/features/ExtraConsoleCommandsList) that are useful for debugging,
+   * but you can also add your own commands that are useful for your particular mod. It's easier to
+   * add commands to the existing command system than to add your own logic manually to the
+   * `EXECUTE_CMD` callback.
    *
    * This function is intended to be called when your mod is first loading.
    *
@@ -290,8 +292,9 @@ export class ExtraConsoleCommands extends Feature {
   /**
    * Helper function to remove a custom console command.
    *
-   * The standard library comes with [many existing console commands](ExtraConsoleCommandsList) that
-   * are useful for debugging. If you want to disable one of them, use this function.
+   * The standard library comes with [many existing console
+   * commands](/isaacscript-common/features/ExtraConsoleCommandsList) that are useful for debugging.
+   * If you want to disable one of them, use this function.
    *
    * This function is intended to be called when your mod is first loading.
    *
@@ -325,9 +328,10 @@ export class ExtraConsoleCommands extends Feature {
   /**
    * Helper function to remove all custom console commands.
    *
-   * The standard library comes with [many existing console commands](ExtraConsoleCommandsList) that
-   * are useful for debugging. If you want to disable all of them after this feature has already
-   * been initialized, use this function.
+   * The standard library comes with [many existing console
+   * commands](/isaacscript-common/features/ExtraConsoleCommandsList) that are useful for debugging.
+   * If you want to disable all of them after this feature has already been initialized, use this
+   * function.
    *
    * In order to use this function, you must upgrade your mod with
    * `ISCFeature.EXTRA_CONSOLE_COMMANDS`.

package/src/classes/features/other/ModdedElementDetection.ts

@@ -19,17 +19,17 @@ import {
 import { Exported } from "../../../decorators";
 import { Feature } from "../../private/Feature";
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_COLLECTIBLE_TYPE: CollectibleType =
   LAST_VANILLA_COLLECTIBLE_TYPE + 1;
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_TRINKET_TYPE: TrinketType = LAST_VANILLA_TRINKET_TYPE + 1;
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_CARD_TYPE: CardType = LAST_VANILLA_CARD_TYPE + 1;
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_PILL_EFFECT: PillEffect = LAST_VANILLA_PILL_EFFECT + 1;
 
 /**

package/src/classes/features/other/ModdedElementSets.ts

@@ -574,7 +574,7 @@ export class ModdedElementSets extends Feature {
   @Exported
   public getPlayerCollectibleMap(
     player: EntityPlayer,
-  ): Map<CollectibleType, int> {
+  ): ReadonlyMap<CollectibleType, int> {
     const collectibleArray = this.getCollectibleTypes();
 
     const collectibleMap = new Map<CollectibleType, int>();
@@ -603,7 +603,7 @@ export class ModdedElementSets extends Feature {
           }
         }
 
-        collectibleType--; // eslint-disable-line isaacscript/strict-enums
+        collectibleType--; // eslint-disable-line complete/strict-enums
       } while (itemConfigItem !== undefined);
     }
 
@@ -976,7 +976,7 @@ export class ModdedElementSets extends Feature {
   public getPlayerTrinketsWithCacheFlag(
     player: EntityPlayer,
     cacheFlag: CacheFlag,
-  ): Map<TrinketType, int> {
+  ): ReadonlyMap<TrinketType, int> {
     const trinketTypesWithCacheFlag =
       this.getTrinketsTypesWithCacheFlag(cacheFlag);
 

package/src/classes/features/other/PickupIndexCreation.ts

@@ -116,9 +116,7 @@ export class PickupIndexCreation extends Feature {
       v.level.pickupData.getAndSetDefault(roomListIndex);
 
     let pickupIndex = getStoredPickupIndex(pickup, pickupDescriptions);
-    if (pickupIndex === undefined) {
-      pickupIndex = this.getPostAscentPickupIndex(pickup);
-    }
+    pickupIndex ??= this.getPostAscentPickupIndex(pickup);
 
     return pickupIndex;
   }
@@ -186,6 +184,7 @@ export class PickupIndexCreation extends Feature {
    * pickup could re-appear during The Ascent. If this is the case, we store the metadata on a
    * separate map to reference later.
    */
+  // eslint-disable-next-line complete/no-mutable-return
   private getPickupDataMapForCurrentRoom():
     | Map<PickupIndex, PickupDescription>
     | undefined {

package/src/classes/features/other/RunInNFrames.ts

@@ -347,7 +347,7 @@ export class RunInNFrames extends Feature {
 }
 
 function checkExecuteQueuedFunctions(
-  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
+  // eslint-disable-next-line complete/prefer-readonly-parameter-types
   queuedFunctions: QueuedFunction[],
   frameCount: int,
   newNumRoomsEntered: int,
@@ -368,7 +368,7 @@ function checkExecuteQueuedFunctions(
 }
 
 function checkExecuteIntervalFunctions(
-  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
+  // eslint-disable-next-line complete/prefer-readonly-parameter-types
   intervalFunctions: IntervalFunction[],
   frameCount: int,
   newNumRoomsEntered: int,

package/src/classes/features/other/SaveDataManager.ts

@@ -104,7 +104,7 @@ export class SaveDataManager extends Feature {
 
       // 18
       // We want to avoid a needless dependency on the `GameReorderedCallbacks` feature.
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_NEW_LEVEL, this.postNewLevel],
     ];
 

package/src/classes/features/other/customStages/backdrop.ts

@@ -57,7 +57,7 @@ const ROOM_SHAPE_WALL_ANM2_LAYERS = {
 } as const satisfies Record<RoomShape, int>;
 
 // We don't use `as const` since we need the object to be indexable by all `RoomShape`.
-// eslint-disable-next-line isaacscript/require-capital-const-assertions
+// eslint-disable-next-line complete/require-capital-const-assertions
 const ROOM_SHAPE_WALL_EXTRA_ANM2_LAYERS: Readonly<
   Partial<Record<RoomShape, int>>
 > = {

package/src/classes/features/other/extraConsoleCommands/commands.ts

@@ -2,22 +2,22 @@
 
 /*
 eslint "sort-exports/sort-exports": [
-  "error",
+  "warn",
   {
     sortDir: "asc",
   },
 ],
 */
 
-/* eslint "jsdoc/require-jsdoc": "error" */
+/* eslint "jsdoc/require-jsdoc": "warn" */
 
 /**
  * __DOCS_LINE_THAT_WILL_BE_AUTOMATICALLY_REMOVED__
  *
  * This is a list of custom console commands that are included with the standard library. By
  * default, they will not be enabled. You can enable them by upgrading your mod with
- * `ISCFeature.EXTRA_CONSOLE_COMMANDS`. (Also see the [Extra Console Commands](ExtraConsoleCommands)
- * feature documentation.)
+ * `ISCFeature.EXTRA_CONSOLE_COMMANDS`. (Also see the [Extra Console
+ * Commands](/isaacscript-common/features/ExtraConsoleCommands) feature documentation.)
  *
  * As a quality of life feature, you do not have to match the casing of the command. For example,
  * you can type the "addCharges" command as "addcharges", and it will still work the same.
@@ -414,7 +414,7 @@ export function cards(): void {
 
       const worldPosition = gridCoordinatesToWorldPosition(x, y);
       spawnCard(cardType, worldPosition);
-      cardType++; // eslint-disable-line isaacscript/strict-enums
+      cardType++; // eslint-disable-line complete/strict-enums
     }
   }
 }
@@ -1115,7 +1115,7 @@ export function pills(): void {
 
     const worldPosition = gridCoordinatesToWorldPosition(x, y);
     spawnPill(pillColor, worldPosition);
-    pillColor++; // eslint-disable-line isaacscript/strict-enums
+    pillColor++; // eslint-disable-line complete/strict-enums
   }
 
   y = 2;
@@ -1127,7 +1127,7 @@ export function pills(): void {
 
     const worldPosition = gridCoordinatesToWorldPosition(x, y);
     spawnPill(pillColor, worldPosition);
-    pillColor++; // eslint-disable-line isaacscript/strict-enums
+    pillColor++; // eslint-disable-line complete/strict-enums
   }
 
   y = 3;

package/src/classes/features/other/saveDataManager/loadFromDisk.ts

@@ -23,6 +23,11 @@ export function loadFromDisk(
   const jsonString = readSaveDatFile(mod);
   const newSaveData = jsonDecode(jsonString);
 
+  if (newSaveData === undefined) {
+    // Reading the save data failed.
+    return;
+  }
+
   if (SAVE_DATA_MANAGER_DEBUG) {
     log('Converted data from the "save#.dat" to a Lua table.');
   }

package/src/core/constants.ts

@@ -295,7 +295,7 @@ export const ONE_BY_ONE_ROOM_GRID_SIZE = 135;
  * An array representing every valid collectible type quality. Specifically, this is: `[0, 1, 2, 3,
  * 4]`
  */
-// eslint-disable-next-line isaacscript/require-capital-const-assertions
+// eslint-disable-next-line complete/require-capital-const-assertions
 export const QUALITIES: readonly Quality[] = [0, 1, 2, 3, 4];
 export const MAX_QUALITY: Quality = 4;
 

package/src/core/constantsVanilla.ts

@@ -53,7 +53,7 @@ export const VANILLA_COLLECTIBLE_TYPE_RANGE: readonly int[] = iRange(
  *
  * If you need to do O(1) lookups, use the `VANILLA_COLLECTIBLE_TYPES_SET` constant instead.
  */
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 export const VANILLA_COLLECTIBLE_TYPES: readonly CollectibleType[] =
   VANILLA_COLLECTIBLE_TYPE_RANGE.filter((potentialCollectibleType) => {
     const collectibleType = asCollectibleType(potentialCollectibleType);
@@ -93,7 +93,7 @@ export const VANILLA_TRINKET_TYPE_RANGE: readonly int[] = iRange(
  *
  * If you need to do O(1) lookups, use the `VANILLA_TRINKET_TYPES_SET` constant instead.
  */
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 export const VANILLA_TRINKET_TYPES: readonly TrinketType[] =
   VANILLA_TRINKET_TYPE_RANGE.filter((potentialTrinketType) => {
     const trinketType = asTrinketType(potentialTrinketType);
@@ -130,7 +130,7 @@ export const VANILLA_CARD_TYPE_RANGE: readonly int[] = iRange(
  *
  * If you need to do O(1) lookups, use the `VANILLA_CARD_TYPES_SET` constant instead.
  */
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 export const VANILLA_CARD_TYPES: readonly CardType[] =
   VANILLA_CARD_TYPE_RANGE.filter((potentialCardType) => {
     const cardType = asCardType(potentialCardType);
@@ -167,7 +167,7 @@ export const VANILLA_PILL_EFFECT_RANGE: readonly int[] = iRange(
  *
  * If you need to do O(1) lookups, use the `VANILLA_PILL_EFFECT_SET` constant instead.
  */
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 export const VANILLA_PILL_EFFECTS: readonly PillEffect[] =
   VANILLA_PILL_EFFECT_RANGE.filter((potentialPillEffect) => {
     const pillEffect = asPillEffect(potentialPillEffect);

package/src/enums/ModCallbackCustom.ts

@@ -1648,8 +1648,8 @@ export enum ModCallbackCustom {
   POST_PLAYER_COLLECTIBLE_REMOVED,
 
   /**
-   * Fires from the `ENTITY_TAKE_DMG` callback when a player takes fatal damage. Return false to
-   * prevent the fatal damage.
+   * Fires from the `ENTITY_TAKE_DMG` callback when a player takes fatal damage. You can optionally
+   * return false to prevent the fatal damage.
    *
    * Note that this function does properly take into account Guppy's Collar, Broken Ankh, Spirit
    * Shackles, and Mysterious Paper. It also takes into account using The Bible on Satan.
@@ -2450,7 +2450,8 @@ export enum ModCallbackCustom {
 
   /**
    * Fires from the `POST_PEFFECT_UPDATE_REORDERED` callback when an item becomes queued (i.e. when
-   * the player begins to hold the item above their head).
+   * the player begins to hold the item above their head). You can optionally return false if you
+   * want the item to not be granted to the player.
    *
    * Note that this callback will only fire once per Forgotten/Soul pair.
    *
@@ -2464,7 +2465,7 @@ export enum ModCallbackCustom {
    * function preItemPickup(
    *   player: EntityPlayer,
    *   pickingUpItem: PickingUpItem,
-   * ): void {}
+   * ): boolean | undefined {}
    * ```
    */
   PRE_ITEM_PICKUP,