chrome-devtools-frontend 1.0.981004 → 1.0.995227

package/front_end/models/bindings/ContentProviderBasedProject.ts

@@ -118,7 +118,7 @@ export class ContentProviderBasedProject extends Workspace.Workspace.ProjectStor
   rename(
       uiSourceCode: Workspace.UISourceCode.UISourceCode, newName: Platform.DevToolsPath.RawPathString,
       callback:
-          (arg0: boolean, arg1?: string|undefined, arg2?: string|undefined,
+          (arg0: boolean, arg1?: string|undefined, arg2?: Platform.DevToolsPath.UrlString|undefined,
            arg3?: Common.ResourceType.ResourceType|undefined) => void): void {
     const path = uiSourceCode.url();
     this.performRename(path, newName, innerCallback.bind(this));
@@ -137,7 +137,7 @@ export class ContentProviderBasedProject extends Workspace.Workspace.ProjectStor
     }
   }
 
-  excludeFolder(_path: string): void {
+  excludeFolder(_path: Platform.DevToolsPath.UrlString): void {
   }
 
   canExcludeFolder(_path: Platform.DevToolsPath.EncodedPathString): boolean {
@@ -160,7 +160,9 @@ export class ContentProviderBasedProject extends Workspace.Workspace.ProjectStor
   remove(): void {
   }
 
-  performRename(path: string, newName: string, callback: (arg0: boolean, arg1?: string|undefined) => void): void {
+  performRename(
+      path: Platform.DevToolsPath.UrlString, newName: string,
+      callback: (arg0: boolean, arg1?: string|undefined) => void): void {
     callback(false);
   }
 
@@ -173,11 +175,11 @@ export class ContentProviderBasedProject extends Workspace.Workspace.ProjectStor
   }
 
   async findFilesMatchingSearchRequest(
-      searchConfig: Workspace.Workspace.ProjectSearchConfig, filesMathingFileQuery: string[],
+      searchConfig: Workspace.Workspace.ProjectSearchConfig, filesMatchingFileQuery: Platform.DevToolsPath.UrlString[],
       progress: Common.Progress.Progress): Promise<string[]> {
     const result: string[] = [];
-    progress.setTotalWork(filesMathingFileQuery.length);
-    await Promise.all(filesMathingFileQuery.map(searchInContent.bind(this)));
+    progress.setTotalWork(filesMatchingFileQuery.length);
+    await Promise.all(filesMatchingFileQuery.map(searchInContent.bind(this)));
     progress.done();
     return result;
 
@@ -211,14 +213,15 @@ export class ContentProviderBasedProject extends Workspace.Workspace.ProjectStor
     this.addUISourceCode(uiSourceCode);
   }
 
-  addContentProvider(url: string, contentProvider: TextUtils.ContentProvider.ContentProvider, mimeType: string):
-      Workspace.UISourceCode.UISourceCode {
+  addContentProvider(
+      url: Platform.DevToolsPath.UrlString, contentProvider: TextUtils.ContentProvider.ContentProvider,
+      mimeType: string): Workspace.UISourceCode.UISourceCode {
     const uiSourceCode = this.createUISourceCode(url, contentProvider.contentType());
     this.addUISourceCodeWithProvider(uiSourceCode, contentProvider, null, mimeType);
     return uiSourceCode;
   }
 
-  removeFile(path: string): void {
+  removeFile(path: Platform.DevToolsPath.UrlString): void {
     this.#contentProviders.delete(path);
     this.removeUISourceCode(path);
   }

package/front_end/models/bindings/DebuggerLanguagePlugins.ts

@@ -766,7 +766,7 @@ export class DebuggerLanguagePluginManager implements
     rawModuleId: string,
     plugin: DebuggerLanguagePlugin,
     scripts: Array<SDK.Script.Script>,
-    addRawModulePromise: Promise<Array<string>>,
+    addRawModulePromise: Promise<Array<Platform.DevToolsPath.UrlString>>,
   }>;
 
   constructor(
@@ -939,8 +939,8 @@ export class DebuggerLanguagePluginManager implements
     return {rawModuleId, plugin: null};
   }
 
-  uiSourceCodeForURL(debuggerModel: SDK.DebuggerModel.DebuggerModel, url: string): Workspace.UISourceCode.UISourceCode
-      |null {
+  uiSourceCodeForURL(debuggerModel: SDK.DebuggerModel.DebuggerModel, url: Platform.DevToolsPath.UrlString):
+      Workspace.UISourceCode.UISourceCode|null {
     const modelData = this.#debuggerModelToData.get(debuggerModel);
     if (modelData) {
       return modelData.getProject().uiSourceCodeForURL(url);
@@ -970,7 +970,8 @@ export class DebuggerLanguagePluginManager implements
     try {
       const sourceLocations = await plugin.rawLocationToSourceLocation(pluginLocation);
       for (const sourceLocation of sourceLocations) {
-        const uiSourceCode = this.uiSourceCodeForURL(script.debuggerModel, sourceLocation.sourceFileURL);
+        const uiSourceCode = this.uiSourceCodeForURL(
+            script.debuggerModel, sourceLocation.sourceFileURL as Platform.DevToolsPath.UrlString);
         if (!uiSourceCode) {
           continue;
         }
@@ -1068,7 +1069,7 @@ export class DebuggerLanguagePluginManager implements
       const rawModuleId = rawModuleIdForScript(script);
       let rawModuleHandle = this.#rawModuleHandles.get(rawModuleId);
       if (!rawModuleHandle) {
-        const sourceFileURLsPromise = (async(): Promise<string[]> => {
+        const sourceFileURLsPromise = (async(): Promise<Platform.DevToolsPath.UrlString[]> => {
           const console = Common.Console.Console.instance();
           const url = script.sourceURL;
           const symbolsUrl = (script.debugSymbols && script.debugSymbols.externalURL) || '';
@@ -1079,7 +1080,8 @@ export class DebuggerLanguagePluginManager implements
           }
           try {
             const code = (!symbolsUrl && url.startsWith('wasm://')) ? await script.getWasmBytecode() : undefined;
-            const sourceFileURLs = await plugin.addRawModule(rawModuleId, symbolsUrl, {url, code});
+            const sourceFileURLs =
+                await plugin.addRawModule(rawModuleId, symbolsUrl, {url, code}) as Platform.DevToolsPath.UrlString[];
             // Check that the handle isn't stale by now. This works because the code that assigns to
             // `rawModuleHandle` below will run before this code because of the `await` in the preceding
             // line. This is primarily to avoid logging the message below, which would give the developer
@@ -1298,7 +1300,7 @@ class ModelData {
     this.uiSourceCodeToScripts = new Map();
   }
 
-  addSourceFiles(script: SDK.Script.Script, urls: string[]): void {
+  addSourceFiles(script: SDK.Script.Script, urls: Platform.DevToolsPath.UrlString[]): void {
     const initiator = script.createPageResourceLoadInitiator();
     for (const url of urls) {
       let uiSourceCode = this.project.uiSourceCodeForURL(url);
@@ -1316,7 +1318,7 @@ class ModelData {
         this.uiSourceCodeToScripts.set(uiSourceCode, [script]);
 
         const contentProvider = new SDK.CompilerSourceMappingContentProvider.CompilerSourceMappingContentProvider(
-            url as Platform.DevToolsPath.UrlString, Common.ResourceType.resourceTypes.SourceMapScript, initiator);
+            url, Common.ResourceType.resourceTypes.SourceMapScript, initiator);
         const mimeType = Common.ResourceType.ResourceType.mimeFromURL(url) || 'text/javascript';
         this.project.addUISourceCodeWithProvider(uiSourceCode, contentProvider, null, mimeType);
       } else {

package/front_end/models/bindings/DebuggerWorkspaceBinding.ts

@@ -71,6 +71,13 @@ export class DebuggerWorkspaceBinding implements SDK.TargetManager.SDKModelObser
     this.#sourceMappings.push(sourceMapping);
   }
 
+  removeSourceMapping(sourceMapping: DebuggerSourceMapping): void {
+    const index = this.#sourceMappings.indexOf(sourceMapping);
+    if (index !== -1) {
+      this.#sourceMappings.splice(index, 1);
+    }
+  }
+
   private async computeAutoStepRanges(mode: SDK.DebuggerModel.StepMode, callFrame: SDK.DebuggerModel.CallFrame):
       Promise<RawLocationRange[]> {
     function contained(location: SDK.DebuggerModel.Location, range: RawLocationRange): boolean {
@@ -228,7 +235,7 @@ export class DebuggerWorkspaceBinding implements SDK.TargetManager.SDKModelObser
   }
 
   uiSourceCodeForSourceMapSourceURL(
-      debuggerModel: SDK.DebuggerModel.DebuggerModel, url: string,
+      debuggerModel: SDK.DebuggerModel.DebuggerModel, url: Platform.DevToolsPath.UrlString,
       isContentScript: boolean): Workspace.UISourceCode.UISourceCode|null {
     const modelData = this.#debuggerModelToData.get(debuggerModel);
     if (!modelData) {

package/front_end/models/bindings/DefaultScriptMapping.ts

@@ -29,6 +29,7 @@
  */
 
 import * as Common from '../../core/common/common.js';
+import type * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Workspace from '../workspace/workspace.js';
 
@@ -61,6 +62,12 @@ export class DefaultScriptMapping implements DebuggerSourceMapping {
     this.#uiSourceCodeToScriptsMap = new WeakMap();
   }
 
+  static createV8ScriptURL(script: SDK.Script.Script): Platform.DevToolsPath.UrlString {
+    const name = Common.ParsedURL.ParsedURL.extractName(script.sourceURL);
+    const url = 'debugger:///VM' + script.scriptId + (name ? ' ' + name : '') as Platform.DevToolsPath.UrlString;
+    return url;
+  }
+
   static scriptForUISourceCode(uiSourceCode: Workspace.UISourceCode.UISourceCode): SDK.Script.Script|null {
     const scripts = uiSourceCodeToScriptsMap.get(uiSourceCode);
     return scripts ? scripts.values().next().value : null;
@@ -90,8 +97,7 @@ export class DefaultScriptMapping implements DebuggerSourceMapping {
 
   private parsedScriptSource(event: Common.EventTarget.EventTargetEvent<SDK.Script.Script>): void {
     const script = event.data;
-    const name = Common.ParsedURL.ParsedURL.extractName(script.sourceURL);
-    const url = 'debugger:///VM' + script.scriptId + (name ? ' ' + name : '');
+    const url = DefaultScriptMapping.createV8ScriptURL(script);
 
     const uiSourceCode = this.#project.createUISourceCode(url, Common.ResourceType.resourceTypes.Script);
     this.#uiSourceCodeToScriptsMap.set(uiSourceCode, script);

package/front_end/models/bindings/FileUtils.ts

@@ -29,6 +29,7 @@
  */
 
 import type * as Common from '../../core/common/common.js';
+import type * as Platform from '../../core/platform/platform.js';
 import * as Workspace from '../workspace/workspace.js';
 
 export interface ChunkedReader {
@@ -206,13 +207,13 @@ export class ChunkedFileReader implements ChunkedReader {
 
 export class FileOutputStream implements Common.StringOutputStream.OutputStream {
   #writeCallbacks: (() => void)[];
-  #fileName!: string;
+  #fileName!: Platform.DevToolsPath.RawPathString|Platform.DevToolsPath.UrlString;
   #closed?: boolean;
   constructor() {
     this.#writeCallbacks = [];
   }
 
-  async open(fileName: string): Promise<boolean> {
+  async open(fileName: Platform.DevToolsPath.RawPathString|Platform.DevToolsPath.UrlString): Promise<boolean> {
     this.#closed = false;
     this.#writeCallbacks = [];
     this.#fileName = fileName;

package/front_end/models/bindings/IgnoreListManager.ts

@@ -107,7 +107,7 @@ export class IgnoreListManager implements SDK.TargetManager.SDKModelObserver<SDK
     return url ? this.isIgnoreListedURL(url) : false;
   }
 
-  isIgnoreListedURL(url: string, isContentScript?: boolean): boolean {
+  isIgnoreListedURL(url: Platform.DevToolsPath.UrlString, isContentScript?: boolean): boolean {
     if (this.#isIgnoreListedURLCache.has(url)) {
       return Boolean(this.#isIgnoreListedURLCache.get(url));
     }
@@ -187,7 +187,7 @@ export class IgnoreListManager implements SDK.TargetManager.SDKModelObserver<SDK
     }
   }
 
-  private uiSourceCodeURL(uiSourceCode: Workspace.UISourceCode.UISourceCode): string|null {
+  private uiSourceCodeURL(uiSourceCode: Workspace.UISourceCode.UISourceCode): Platform.DevToolsPath.UrlString|null {
     return uiSourceCode.project().type() === Workspace.Workspace.projectTypes.Debugger ? null : uiSourceCode.url();
   }
 
@@ -218,7 +218,7 @@ export class IgnoreListManager implements SDK.TargetManager.SDKModelObserver<SDK
     Common.Settings.Settings.instance().moduleSetting('skipContentScripts').set(false);
   }
 
-  private ignoreListURL(url: string): void {
+  private ignoreListURL(url: Platform.DevToolsPath.UrlString): void {
     const regexPatterns = this.getSkipStackFramesPatternSetting().getAsArray();
     const regexValue = this.urlToRegExpString(url);
     if (!regexValue) {
@@ -239,7 +239,7 @@ export class IgnoreListManager implements SDK.TargetManager.SDKModelObserver<SDK
     this.getSkipStackFramesPatternSetting().setAsArray(regexPatterns);
   }
 
-  private unIgnoreListURL(url: string): void {
+  private unIgnoreListURL(url: Platform.DevToolsPath.UrlString): void {
     let regexPatterns = this.getSkipStackFramesPatternSetting().getAsArray();
     const regexValue = IgnoreListManager.instance().urlToRegExpString(url);
     if (!regexValue) {
@@ -287,7 +287,7 @@ export class IgnoreListManager implements SDK.TargetManager.SDKModelObserver<SDK
     // This method is sniffed in tests.
   }
 
-  private urlToRegExpString(url: string): string {
+  private urlToRegExpString(url: Platform.DevToolsPath.UrlString): string {
     const parsedURL = new Common.ParsedURL.ParsedURL(url);
     if (parsedURL.isAboutBlank() || parsedURL.isDataURL()) {
       return '';

package/front_end/models/bindings/ResourceUtils.ts

@@ -38,7 +38,7 @@ import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as Workspace from '../workspace/workspace.js';
 
-export function resourceForURL(url: string): SDK.Resource.Resource|null {
+export function resourceForURL(url: Platform.DevToolsPath.UrlString): SDK.Resource.Resource|null {
   for (const resourceTreeModel of SDK.TargetManager.TargetManager.instance().models(
            SDK.ResourceTreeModel.ResourceTreeModel)) {
     const resource = resourceTreeModel.resourceForURL(url);
@@ -49,7 +49,7 @@ export function resourceForURL(url: string): SDK.Resource.Resource|null {
   return null;
 }
 
-export function displayNameForURL(url: string): string {
+export function displayNameForURL(url: Platform.DevToolsPath.UrlString): string {
   if (!url) {
     return '';
   }
@@ -88,8 +88,9 @@ export function displayNameForURL(url: string): string {
   return displayName === '/' ? parsedURL.host + '/' : displayName;
 }
 
-export function metadataForURL(target: SDK.Target.Target, frameId: Protocol.Page.FrameId, url: string):
-    Workspace.UISourceCode.UISourceCodeMetadata|null {
+export function metadataForURL(
+    target: SDK.Target.Target, frameId: Protocol.Page.FrameId,
+    url: Platform.DevToolsPath.UrlString): Workspace.UISourceCode.UISourceCodeMetadata|null {
   const resourceTreeModel = target.model(SDK.ResourceTreeModel.ResourceTreeModel);
   if (!resourceTreeModel) {
     return null;

package/front_end/models/emulation/EmulatedDevices.ts

@@ -643,6 +643,10 @@ export interface JSONMode {
 }
 
 const emulatedDevices = [
+  // This is used by a python script to keep this list up-to-date with
+  // chromedriver native code.
+  // See //chrome/test/chromedriver/embed_mobile_devices_in_cpp.py in Chromium.
+  // DEVICE-LIST-BEGIN
   {
     'order': 10,
     'show-by-default': true,
@@ -1653,7 +1657,11 @@ const emulatedDevices = [
   },
   {
     'show-by-default': false,
+    /* DEVICE-LIST-IF-JS */
     'title': i18nLazyString(UIStrings.laptopWithTouch),
+    /* DEVICE-LIST-ELSE
+    'title': 'Laptop with touch',
+    DEVICE-LIST-END-IF */
     'screen': {
       'horizontal': {'width': 1280, 'height': 950},
       'device-pixel-ratio': 1,
@@ -1666,7 +1674,11 @@ const emulatedDevices = [
   },
   {
     'show-by-default': false,
+    /* DEVICE-LIST-IF-JS */
     'title': i18nLazyString(UIStrings.laptopWithHiDPIScreen),
+    /* DEVICE-LIST-ELSE
+    'title': 'Laptop with HiDPI screen',
+    DEVICE-LIST-END-IF */
     'screen': {
       'horizontal': {'width': 1440, 'height': 900},
       'device-pixel-ratio': 2,
@@ -1679,7 +1691,11 @@ const emulatedDevices = [
   },
   {
     'show-by-default': false,
+    /* DEVICE-LIST-IF-JS */
     'title': i18nLazyString(UIStrings.laptopWithMDPIScreen),
+    /* DEVICE-LIST-ELSE
+    'title': 'Laptop with MDPI screen',
+    DEVICE-LIST-END-IF */
     'screen': {
       'horizontal': {'width': 1280, 'height': 800},
       'device-pixel-ratio': 1,
@@ -1719,4 +1735,5 @@ const emulatedDevices = [
         {'platform': 'Android', 'platformVersion': '6.0.1', 'architecture': '', 'model': 'Moto G (4)', 'mobile': true},
     'type': 'phone',
   },
+  // DEVICE-LIST-END
 ];

package/front_end/models/extensions/ExtensionAPI.ts

@@ -28,6 +28,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+import type * as Platform from '../../core/platform/platform.js';
 import type * as PublicAPI from '../../../extension-api/ExtensionAPI'; // eslint-disable-line rulesdir/es_modules_import
 import type * as HAR from '../har/har.js';
 
@@ -151,7 +152,8 @@ export namespace PrivateAPI {
     evaluateOptions?: EvaluateOptions,
   };
   type SetSidebarPageRequest = {command: Commands.SetSidebarPage, id: string, page: string};
-  type OpenResourceRequest = {command: Commands.OpenResource, url: string, lineNumber: number, columnNumber: number};
+  type OpenResourceRequest =
+      {command: Commands.OpenResource, url: Platform.DevToolsPath.UrlString, lineNumber: number, columnNumber: number};
   type SetOpenResourceHandlerRequest = {command: Commands.SetOpenResourceHandler, handlerPresent: boolean};
   type SetThemeChangeHandlerRequest = {command: Commands.SetThemeChangeHandler, handlerPresent: boolean};
   type ReloadRequest = {
@@ -606,7 +608,8 @@ self.injectedExtensionAPI = function(
     },
 
     openResource: function(
-        url: string, lineNumber: number, columnNumber?: number, _callback?: (response: unknown) => unknown): void {
+        url: Platform.DevToolsPath.UrlString, lineNumber: number, columnNumber?: number,
+        _callback?: (response: unknown) => unknown): void {
       const callbackArg = extractCallbackArgument(arguments);
       // Handle older API:
       const columnNumberArg = typeof columnNumber === 'number' ? columnNumber : 0;

package/front_end/models/extensions/ExtensionPanel.ts

@@ -29,6 +29,7 @@
  */
 
 import * as _ProtocolClient from '../../core/protocol_client/protocol_client.js';  // eslint-disable-line @typescript-eslint/no-unused-vars
+import type * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
@@ -127,7 +128,7 @@ export class ExtensionSidebarPane extends UI.View.SimpleView {
   private idInternal: string;
   private extensionView?: ExtensionView;
   private objectPropertiesView?: ExtensionNotifierView;
-  constructor(server: ExtensionServer, panelName: string, title: string, id: string) {
+  constructor(server: ExtensionServer, panelName: string, title: Platform.UIString.LocalizedString, id: string) {
     super(title);
     this.element.classList.add('fill');
     this.panelNameInternal = panelName;

package/front_end/models/extensions/ExtensionServer.ts

@@ -31,8 +31,11 @@
 // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
 /* eslint-disable @typescript-eslint/naming-convention */
 
+// TODO(crbug.com/1253323): Casts to UrlString will be removed from this file when migration to branded types is complete.
+
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
+import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as _ProtocolClient from '../../core/protocol_client/protocol_client.js';  // eslint-disable-line @typescript-eslint/no-unused-vars
 import * as Root from '../../core/root/root.js';
@@ -363,8 +366,8 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     const page = this.expandResourcePath(this.getExtensionOrigin(port), message.page) as string;
     let persistentId = this.getExtensionOrigin(port) + message.title;
     persistentId = persistentId.replace(/\s/g, '');
-    const panelView =
-        new ExtensionServerPanelView(persistentId, message.title, new ExtensionPanel(this, persistentId, id, page));
+    const panelView = new ExtensionServerPanelView(
+        persistentId, i18n.i18n.lockedString(message.title), new ExtensionPanel(this, persistentId, id, page));
     this.clientObjects.set(id, panelView);
     UI.InspectorView.InspectorView.instance().addPanel(panelView);
     return this.status.OK();
@@ -438,7 +441,7 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
       return this.status.E_BADARG('command', `expected ${PrivateAPI.Commands.CreateSidebarPane}`);
     }
     const id = message.id;
-    const sidebar = new ExtensionSidebarPane(this, message.panel, message.title, id);
+    const sidebar = new ExtensionSidebarPane(this, message.panel, i18n.i18n.lockedString(message.title), id);
     this.sidebarPanesInternal.push(sidebar);
     this.clientObjects.set(id, sidebar);
     this.dispatchEventToListeners(Events.SidebarPaneAdded, sidebar);
@@ -500,7 +503,8 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     if (message.command !== PrivateAPI.Commands.OpenResource) {
       return this.status.E_BADARG('command', `expected ${PrivateAPI.Commands.OpenResource}`);
     }
-    const uiSourceCode = Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(message.url);
+    const uiSourceCode =
+        Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(message.url as Platform.DevToolsPath.UrlString);
     if (uiSourceCode) {
       void Common.Revealer.reveal(uiSourceCode.uiLocation(message.lineNumber, message.columnNumber));
       return this.status.OK();
@@ -674,7 +678,7 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     if (message.command !== PrivateAPI.Commands.GetResourceContent) {
       return this.status.E_BADARG('command', `expected ${PrivateAPI.Commands.GetResourceContent}`);
     }
-    const url = (message.url as string);
+    const url = message.url as Platform.DevToolsPath.UrlString;
     const contentProvider = Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(url) ||
         Bindings.ResourceUtils.resourceForURL(url);
     if (!contentProvider) {
@@ -695,9 +699,10 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
       this.dispatchCallback(requestId, port, response);
     }
 
-    const uiSourceCode = Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(url);
+    const uiSourceCode =
+        Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(url as Platform.DevToolsPath.UrlString);
     if (!uiSourceCode || !uiSourceCode.contentType().isDocumentOrScriptOrStyleSheet()) {
-      const resource = SDK.ResourceTreeModel.ResourceTreeModel.resourceForURL(url);
+      const resource = SDK.ResourceTreeModel.ResourceTreeModel.resourceForURL(url as Platform.DevToolsPath.UrlString);
       if (!resource) {
         return this.status.E_NOTFOUND(url);
       }
@@ -1132,7 +1137,7 @@ class ExtensionServerPanelView extends UI.View.SimpleView {
   private readonly name: string;
   private readonly panel: UI.Panel.Panel;
 
-  constructor(name: string, title: string, panel: UI.Panel.Panel) {
+  constructor(name: string, title: Platform.UIString.LocalizedString, panel: UI.Panel.Panel) {
     super(title);
     this.name = name;
     this.panel = panel;

package/front_end/models/issues_manager/AttributionReportingIssue.ts

@@ -11,19 +11,12 @@ import type {MarkdownIssueDescription} from './MarkdownIssueDescription.js';
 export const enum IssueCode {
   PermissionPolicyDisabled = 'AttributionReportingIssue::PermissionPolicyDisabled',
   InvalidAttributionSourceEventId = 'AttributionReportingIssue::InvalidAttributionSourceEventId',
-  InvalidAttributionData = 'AttributionReportingIssue::InvalidAttributionData',
-  MissingAttributionData = 'AttributionReportingIssue::MissingAttributionData',
   AttributionSourceUntrustworthyFrameOrigin = 'AttributionReportingIssue::AttributionSourceUntrustworthyFrameOrigin',
   AttributionSourceUntrustworthyOrigin = 'AttributionReportingIssue::AttributionSourceUntrustworthyOrigin',
   AttributionUntrustworthyFrameOrigin = 'AttributionReportingIssue::AttributionUntrustworthyFrameOrigin',
   AttributionUntrustworthyOrigin = 'AttributionReportingIssue::AttributionUntrustworthyOrigin',
-  AttributionTriggerDataTooLarge = 'AttributionReportingIssue::AttributionTriggerDataTooLarge',
-  AttributionEventSourceTriggerDataTooLarge = 'AttributionReportingIssue::AttributionEventSourceTriggerDataTooLarge',
   InvalidAttributionSourceExpiry = 'AttributionReportingIssue::InvalidAttributionSourceExpiry',
   InvalidAttributionSourcePriority = 'AttributionReportingIssue::InvalidAttributionSourcePriority',
-  InvalidEventSourceTriggerData = 'AttributionReportingIssue::InvalidEventSourceTriggerData',
-  InvalidTriggerPriority = 'AttributionReportingIssue::InvalidTriggerPriority',
-  InvalidTriggerDedupKey = 'AttributionReportingIssue::InvalidTriggerDedupKey',
 }
 
 function getIssueCode(details: Protocol.Audits.AttributionReportingIssueDetails): IssueCode {
@@ -32,29 +25,16 @@ function getIssueCode(details: Protocol.Audits.AttributionReportingIssueDetails)
       return IssueCode.PermissionPolicyDisabled;
     case Protocol.Audits.AttributionReportingIssueType.InvalidAttributionSourceEventId:
       return IssueCode.InvalidAttributionSourceEventId;
-    case Protocol.Audits.AttributionReportingIssueType.InvalidAttributionData:
-      return details.invalidParameter !== undefined ? IssueCode.InvalidAttributionData :
-                                                      IssueCode.MissingAttributionData;
     case Protocol.Audits.AttributionReportingIssueType.AttributionSourceUntrustworthyOrigin:
       return details.frame !== undefined ? IssueCode.AttributionSourceUntrustworthyFrameOrigin :
                                            IssueCode.AttributionSourceUntrustworthyOrigin;
     case Protocol.Audits.AttributionReportingIssueType.AttributionUntrustworthyOrigin:
       return details.frame !== undefined ? IssueCode.AttributionUntrustworthyFrameOrigin :
                                            IssueCode.AttributionUntrustworthyOrigin;
-    case Protocol.Audits.AttributionReportingIssueType.AttributionTriggerDataTooLarge:
-      return IssueCode.AttributionTriggerDataTooLarge;
-    case Protocol.Audits.AttributionReportingIssueType.AttributionEventSourceTriggerDataTooLarge:
-      return IssueCode.AttributionEventSourceTriggerDataTooLarge;
     case Protocol.Audits.AttributionReportingIssueType.InvalidAttributionSourceExpiry:
       return IssueCode.InvalidAttributionSourceExpiry;
     case Protocol.Audits.AttributionReportingIssueType.InvalidAttributionSourcePriority:
       return IssueCode.InvalidAttributionSourcePriority;
-    case Protocol.Audits.AttributionReportingIssueType.InvalidEventSourceTriggerData:
-      return IssueCode.InvalidEventSourceTriggerData;
-    case Protocol.Audits.AttributionReportingIssueType.InvalidTriggerPriority:
-      return IssueCode.InvalidTriggerPriority;
-    case Protocol.Audits.AttributionReportingIssueType.InvalidTriggerDedupKey:
-      return IssueCode.InvalidTriggerDedupKey;
   }
 }
 
@@ -87,16 +67,6 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
             linkTitle: 'attributionsourceeventid attribute',
           }],
         };
-      case IssueCode.InvalidAttributionData:
-        return {
-          file: 'arInvalidAttributionData.md',
-          links: [],
-        };
-      case IssueCode.MissingAttributionData:
-        return {
-          file: 'arMissingAttributionData.md',
-          links: [],
-        };
       case IssueCode.AttributionSourceUntrustworthyFrameOrigin:
         return {
           file: 'arAttributionSourceUntrustworthyFrameOrigin.md',
@@ -128,16 +98,6 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
           file: 'arAttributionUntrustworthyOrigin.md',
           links: [],
         };
-      case IssueCode.AttributionTriggerDataTooLarge:
-        return {
-          file: 'arAttributionTriggerDataTooLarge.md',
-          links: [],
-        };
-      case IssueCode.AttributionEventSourceTriggerDataTooLarge:
-        return {
-          file: 'arAttributionEventSourceTriggerDataTooLarge.md',
-          links: [],
-        };
       case IssueCode.InvalidAttributionSourceExpiry:
         return {
           file: 'arInvalidAttributionSourceExpiry.md',
@@ -156,29 +116,6 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
             linkTitle: 'attributionsourcepriority attribute',
           }],
         };
-      case IssueCode.InvalidEventSourceTriggerData:
-        return {
-          file: 'arInvalidEventSourceTriggerData.md',
-          links: [],
-        };
-      case IssueCode.InvalidTriggerPriority:
-        return {
-          file: 'arInvalidTriggerPriority.md',
-          links: [{
-            link:
-                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#prioritize-specific-conversions',
-            linkTitle: 'Prioritizing specific conversions',
-          }],
-        };
-      case IssueCode.InvalidTriggerDedupKey:
-        return {
-          file: 'arInvalidTriggerDedupKey.md',
-          links: [{
-            link:
-                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#deduplicate-reports',
-            linkTitle: 'Deduplicating reports',
-          }],
-        };
     }
   }
 

package/front_end/models/issues_manager/CookieIssue.ts

@@ -426,6 +426,11 @@ const samePartyCrossPartyContextSet: LazyMarkdownIssueDescription = {
   }],
 };
 
+const attributeValueExceedsMaxSize: LazyMarkdownIssueDescription = {
+  file: 'CookieAttributeValueExceedsMaxSize.md',
+  links: [],
+};
+
 const issueDescriptions: Map<string, LazyMarkdownIssueDescription> = new Map([
   ['CookieIssue::ExcludeSameSiteUnspecifiedTreatedAsLax::ReadCookie', sameSiteUnspecifiedErrorRead],
   ['CookieIssue::ExcludeSameSiteUnspecifiedTreatedAsLax::SetCookie', sameSiteUnspecifiedErrorSet],
@@ -455,4 +460,6 @@ const issueDescriptions: Map<string, LazyMarkdownIssueDescription> = new Map([
   ['CookieIssue::ExcludeContextDowngrade::SetCookie::Insecure', sameSiteExcludeContextDowngradeSet(false)],
   ['CookieIssue::ExcludeInvalidSameParty::SetCookie', sameSiteInvalidSameParty],
   ['CookieIssue::ExcludeSamePartyCrossPartyContext::SetCookie', samePartyCrossPartyContextSet],
+  ['CookieIssue::WarnAttributeValueExceedsMaxSize::ReadCookie', attributeValueExceedsMaxSize],
+  ['CookieIssue::WarnAttributeValueExceedsMaxSize::SetCookie', attributeValueExceedsMaxSize],
 ]);