@woosh/meep-engine 3.1.0 → 3.3.0

package/src/REVIEW_2026_08_06/prior-criticals.md

@@ -1,49 +1,49 @@
-# REVIEW_2026_07_03 §3 "Critical findings" — re-verification against current source
-
-Source root: `H:/git/moh/app/src/mir-engine/meep/src/`
-Verified: 2026-08-06. Line numbers below are **current**, not the ones in the review.
-
-C1/C3/C4/C10/C22 (FIXED) and C5 (OPEN) carried forward from the lead reviewer; C5 re-confirmed with a current line.
-C2 does not exist (intentionally absent from the review).
-
-| ID | Status | Current file:line | Evidence | Spec exists? |
-|---|---|---|---|---|
-| C1 | **FIXED** | `engine/ecs/EntityObserver.js` | carried forward from lead reviewer | — |
-| C3 | **FIXED** | `engine/grid/transform2grid/Transform2GridPositionSystem.js` | carried forward from lead reviewer | — |
-| C4 | **FIXED** | `engine/ecs/attachment/AttachmentSystem.js` | carried forward from lead reviewer | — |
-| C5 | **OPEN** | `engine/graphics/ecs/decal/v2/FPDecalSystem.js:216` | in `unlink()`, after `this.__fp_decal = null;`: `transform.subscribe(this.__update_transform, this);` — identical call to the one in `link()` at :162; no `unsubscribe` anywhere in the file | **No** — `graphics/ecs/decal/v2/Decal.spec.js` exists but does not exercise unlink/transform-change |
-| C6 | **FIXED** | `engine/control/first-person/sensors/FirstPersonSensorsSystem.js:135-136` | `const rx = -Math.cos(yaw);` / `const rz = Math.sin(yaw);` — matches the prescribed fix; comment at :132 now documents the controller convention | **Yes** — `FirstPersonSensorsSystem.spec.js:117` `"side wall on the player's right (world -X at yaw 0) fires wallRight (C6)"`; also referenced from `control/first-person/WallRunScenarios.spec.js:32` |
-| C7 | **FIXED** | `engine/input/ecs/systems/InputControllerSystem.js:106` | `return b.priority - a.priority;` (typo `priotity` gone). Field is now real: `input/ecs/components/InputBinding.js:11` `constructor({ path, listener, exclusive = false, priority = 0 })` and `:36` `this.priority = priority;` | **Yes** — `InputControllerSystem.spec.js:5` `"bindings on the same path dispatch in descending priority order (C7)"` |
-| C8 | **FIXED** | `engine/graphics/particles/particular/group/ParticleGroup.js:467` | `indices.sort((a, b) => a - b);` with comment "sort indices ascending numerically (the compaction below walks the deleted tail block and assumes ascending numeric order)". (File moved: `particular/…` → `graphics/particles/particular/…`) | **Yes** — `ParticleGroup.spec.js:114` `"deleteIndices() compacts correctly when a deleted index >= 10 outranks lower ones (C8)"` |
-| C9 | **FIXED** | `engine/graphics/particles/particular/engine/emitter/ParticlePool.js:507` | `attribute.updateRange.count = n * itemSize;` — and the sibling site at `:177` `attribute.updateRange.count = activeParticleLimit * attribute.itemSize;` | **Yes** — `ParticlePool.spec.js:227` `"writeAttributeForAllArray marks updateRange.count in elements, not particles (C9)"` |
-| C10 | **FIXED** | `engine/graphics/texture/atlas/AtlasLookupTexture.js` | carried forward from lead reviewer | — |
-| C11 | **FIXED** | `engine/graphics/texture/sampler/resize/sampler2d_scale_down_lanczos.js:93-94` | `const rcp_ratio_y = 2 / ratio_y;` / `const rcp_ratio_x = 2 / ratio_x;` | **Yes** — `sampler2d_scale_down_lanczos.spec.js:33` `"non-uniform downscale is transpose-symmetric (C11)"`, written **outside** the still-present `describe.skip("currently broken")` block at :4 (those three legacy tests remain skipped) |
-| C12 | **FIXED** | `engine/ecs/fow/FogOfWar.js:707-713` | `const samplerWidth = this.size.x + 2;` / `const samplerHeight = this.size.y + 2;` / `new Sampler2D(uint8Array, 1, samplerWidth, samplerHeight);` — no transposition | **Yes** — `ecs/fow/FogOfWar.spec.js:16` `"resize builds a sampler with non-transposed dimensions (C12)"` |
-| C13 | **OPEN** | `engine/ecs/terrain/tiles/TerrainTileManager.js:566` | `stitchTile()` still floors: `const gridSize = this.totalSize.clone(); gridSize.divide(this.tileSize); gridSize.floor();` while `initializeTiles()` at `:352-353` creates tiles with `gridSize.divide(time_size); gridSize.ceil();`. The floored `gridSize` then gates every neighbour lookup (`if (x < gridSize.x - 1)` at :577/:586/:593, `if (y < gridSize.y - 1)` at :581), so the partial edge tiles that `ceil` created are never given top/right/bottom neighbours. `computeTileIndex` (:405) and `getRaw` (:422) already use `Math.ceil` — `stitchTile` is the lone floor. | **No** — no spec anywhere in `engine/` matches `stitch`/C13; `ecs/terrain/tiles/TerrainTile.spec.js` exists but does not cover manager-level seam stitching |
-| C14 | **FIXED** | `engine/asset/preloader/AssetPreloader.js:297-301` | `assetLoadFailed` now has the completion check: `//monitor completion (a failure counts toward the level batch, and //may be the last completion in it — see assetLoadSuccess)` then `if ((batchElementLoadedCount + batchElementFailedCount) >= batch_size) { this.on.levelFinished.dispatch(level); }` — mirrors `assetLoadSuccess` at :284. (File moved: `preloader/` → `asset/preloader/`) | **Yes** — `AssetPreloader.spec.js:89` `"a failing asset in an earlier level still advances the preload (C14)"` |
-| C15 | **FIXED** | `engine/navigation/ecs/path_following/PathFollower.js:160-162` | `if (typeof json.loop === "boolean") { this.writeFlag(PathFollowerFlags.Loop, json.loop); }` — and `json.active` is separately routed to `PathFollowerFlags.Active` at :156-158 | **Yes** — `PathFollower.spec.js:8` `"fromJSON reads the loop flag from json.loop, not json.active (C15)"` |
-| C16 | **FIXED** | `engine/animation/curve/actionProcessorOperations/curveActions.js:118-133` | `MoveKeyframeAction.apply` now copies in place: `this.actionContext.refCurve.keys[i].copy(this.curveValueEnd.keys[i]);` with comment "do NOT reassign the live curve's keyframe to the snapshot object … (C16)"; `revert` mirrors it with `.copy(this.curveValueStart.keys[i])`. Snapshots are taken by `.clone()` in the constructor (:110, :113). | **Yes** — `curveActions.spec.js:13` `"MoveKeyframeAction applies end values without aliasing live keyframes to its snapshot (C16)"` |
-| C17 | **OPEN** | `engine/graphics/geometry/MikkT/BuildNeighborsFast.js:116-118` | The B-side edge unpack is still wrong: `const i0_B = temp_edge_B[1];` / `const i1_B = temp_edge_B[2];` / `const edgenum_B = temp_edge_B[2];` — `i1_B` and `edgenum_B` read the **same slot**, and the "flip" comment at :115 is still there. `GetEdge` (`MikkT/GetEdge.js:22-42`) documents the layout as `out[0]=i0, out[1]=i1, out[2]=edgenum`, and the A-side at :85-87 reads it correctly (`temp_edge_A[0]/[1]/[2]`). So the pairing test `if (i0_A === i0_B && i1_A === i1_B …)` at :123 compares a vertex index against an edge number and effectively never matches. | **No** — `MikkT/MikkTSpace.spec.js` only has `'empty geometry'` (:3) and `'single triangle'` (:12); a single triangle has no neighbours, so the pairing path is untested |
-| C18 | **OPEN** | `engine/graphics/geometry/MikkT/GenerateSharedVerticesIndexList.js:79` | Insertion pass still has the precedence bug: `const bin_index = pass * 257 + (_comp_0[i] >> shift) & 0xff;` — `+` binds tighter than `&`, so this masks the whole sum, not just the byte. The **counting** pass at :59 was written correctly (`const index = pass * 257 + ((key >> shift) & 0xff) + 1;`), so counts and insertion now disagree about bin identity. | **No** — no spec references radix sorting or shared-vertex welding; `MikkTSpace.spec.js` does not reach multi-vertex welding |
-| C19 | **FIXED** | `engine/logging/elastic/ElasticSearchLogger.js:61, 82, 141-142` | Field names unified: the config is `this.__flush_timeout = 2000;` (:61) and the handle is `this.__timeout = -1;` (:82). `__prod()` arms it correctly: `} else if (this.__timeout === -1) { this.__timeout = setTimeout(this.__bound_flush, this.__flush_timeout); }`, and `flush()` clears the same field (:95-97). No `__timeout_ms` remains. | **Yes** — `ElasticSearchLogger.spec.js:4` `"logging fewer than flush_size records arms a deferred flush timer (C19)"` |
-| C20 | **FIXED** | `engine/ecs/EntityComponentDataset.js:1881-1882` | `dropData()` now clears both: `this.__entityEventListeners = []; this.__entityAnyEventListeners = [];`. `removeEntity` also purges both (:980-981). | **Yes** — `EntityComponentDataset.spec.js:1019` `"dropData clears any-event listeners so a recycled entity id does not inherit them (C20)"` |
-| C21 | **FIXED** | `engine/ecs/EntityManager.js:357` | Inside `detachDataset()` (:334): `system.handleDatasetDetached(dataset);`. The `handleDatasetAttached` calls remain only on the genuine attach paths (:316 in attach, :714 on system startup). | No dedicated spec found (behaviour is exercised indirectly by the ECS lifecycle suite) |
-| C22 | **FIXED** | `engine/sound/material/concrete/json/serializeSoundMaterialToJSON.js` | carried forward from lead reviewer | — |
-
-## Tally
-
-- **FIXED: 17** — C1, C3, C4, C6, C7, C8, C9, C10, C11, C12, C14, C15, C16, C19, C20, C21, C22
-- **OPEN: 4** — C5, C13, C17, C18
-- **MOVED/UNCLEAR: 0**
-
-Three files moved since the review but were located and verified (no ambiguity about identity):
-
-- `particular/group/ParticleGroup.js` → `graphics/particles/particular/group/ParticleGroup.js`
-- `particular/engine/emitter/ParticlePool.js` → `graphics/particles/particular/engine/emitter/ParticlePool.js`
-- `preloader/AssetPreloader.js` → `asset/preloader/AssetPreloader.js`
-
-## Notes on the OPEN items
-
-- **None of the four OPEN items has a regression spec.** Every FIXED item except C21 shipped with a spec that names its finding ID, so the absence of one is a reliable signal that C5/C13/C17/C18 were never worked.
-- **C17 and C18 are both in `graphics/geometry/MikkT/`** and both sit on the tangent-generation path. The only spec in that directory covers empty geometry and a single triangle — neither case reaches edge pairing or vertex welding.
-- No fix for any of the four is implemented as an `assert.*` (which would not count, since asserts are stripped in production) — the defective lines are plain unguarded logic.
+# REVIEW_2026_07_03 §3 "Critical findings" — re-verification against current source
+
+Source root: `H:/git/moh/app/src/mir-engine/meep/src/`
+Verified: 2026-08-06. Line numbers below are **current**, not the ones in the review.
+
+C1/C3/C4/C10/C22 (FIXED) and C5 (OPEN) carried forward from the lead reviewer; C5 re-confirmed with a current line.
+C2 does not exist (intentionally absent from the review).
+
+| ID | Status | Current file:line | Evidence | Spec exists? |
+|---|---|---|---|---|
+| C1 | **FIXED** | `engine/ecs/EntityObserver.js` | carried forward from lead reviewer | — |
+| C3 | **FIXED** | `engine/grid/transform2grid/Transform2GridPositionSystem.js` | carried forward from lead reviewer | — |
+| C4 | **FIXED** | `engine/ecs/attachment/AttachmentSystem.js` | carried forward from lead reviewer | — |
+| C5 | **OPEN** | `engine/graphics/ecs/decal/v2/FPDecalSystem.js:216` | in `unlink()`, after `this.__fp_decal = null;`: `transform.subscribe(this.__update_transform, this);` — identical call to the one in `link()` at :162; no `unsubscribe` anywhere in the file | **No** — `graphics/ecs/decal/v2/Decal.spec.js` exists but does not exercise unlink/transform-change |
+| C6 | **FIXED** | `engine/control/first-person/sensors/FirstPersonSensorsSystem.js:135-136` | `const rx = -Math.cos(yaw);` / `const rz = Math.sin(yaw);` — matches the prescribed fix; comment at :132 now documents the controller convention | **Yes** — `FirstPersonSensorsSystem.spec.js:117` `"side wall on the player's right (world -X at yaw 0) fires wallRight (C6)"`; also referenced from `control/first-person/WallRunScenarios.spec.js:32` |
+| C7 | **FIXED** | `engine/input/ecs/systems/InputControllerSystem.js:106` | `return b.priority - a.priority;` (typo `priotity` gone). Field is now real: `input/ecs/components/InputBinding.js:11` `constructor({ path, listener, exclusive = false, priority = 0 })` and `:36` `this.priority = priority;` | **Yes** — `InputControllerSystem.spec.js:5` `"bindings on the same path dispatch in descending priority order (C7)"` |
+| C8 | **FIXED** | `engine/graphics/particles/particular/group/ParticleGroup.js:467` | `indices.sort((a, b) => a - b);` with comment "sort indices ascending numerically (the compaction below walks the deleted tail block and assumes ascending numeric order)". (File moved: `particular/…` → `graphics/particles/particular/…`) | **Yes** — `ParticleGroup.spec.js:114` `"deleteIndices() compacts correctly when a deleted index >= 10 outranks lower ones (C8)"` |
+| C9 | **FIXED** | `engine/graphics/particles/particular/engine/emitter/ParticlePool.js:507` | `attribute.updateRange.count = n * itemSize;` — and the sibling site at `:177` `attribute.updateRange.count = activeParticleLimit * attribute.itemSize;` | **Yes** — `ParticlePool.spec.js:227` `"writeAttributeForAllArray marks updateRange.count in elements, not particles (C9)"` |
+| C10 | **FIXED** | `engine/graphics/texture/atlas/AtlasLookupTexture.js` | carried forward from lead reviewer | — |
+| C11 | **FIXED** | `engine/graphics/texture/sampler/resize/sampler2d_scale_down_lanczos.js:93-94` | `const rcp_ratio_y = 2 / ratio_y;` / `const rcp_ratio_x = 2 / ratio_x;` | **Yes** — `sampler2d_scale_down_lanczos.spec.js:33` `"non-uniform downscale is transpose-symmetric (C11)"`, written **outside** the still-present `describe.skip("currently broken")` block at :4 (those three legacy tests remain skipped) |
+| C12 | **FIXED** | `engine/ecs/fow/FogOfWar.js:707-713` | `const samplerWidth = this.size.x + 2;` / `const samplerHeight = this.size.y + 2;` / `new Sampler2D(uint8Array, 1, samplerWidth, samplerHeight);` — no transposition | **Yes** — `ecs/fow/FogOfWar.spec.js:16` `"resize builds a sampler with non-transposed dimensions (C12)"` |
+| C13 | **OPEN** | `engine/ecs/terrain/tiles/TerrainTileManager.js:566` | `stitchTile()` still floors: `const gridSize = this.totalSize.clone(); gridSize.divide(this.tileSize); gridSize.floor();` while `initializeTiles()` at `:352-353` creates tiles with `gridSize.divide(time_size); gridSize.ceil();`. The floored `gridSize` then gates every neighbour lookup (`if (x < gridSize.x - 1)` at :577/:586/:593, `if (y < gridSize.y - 1)` at :581), so the partial edge tiles that `ceil` created are never given top/right/bottom neighbours. `computeTileIndex` (:405) and `getRaw` (:422) already use `Math.ceil` — `stitchTile` is the lone floor. | **No** — no spec anywhere in `engine/` matches `stitch`/C13; `ecs/terrain/tiles/TerrainTile.spec.js` exists but does not cover manager-level seam stitching |
+| C14 | **FIXED** | `engine/asset/preloader/AssetPreloader.js:297-301` | `assetLoadFailed` now has the completion check: `//monitor completion (a failure counts toward the level batch, and //may be the last completion in it — see assetLoadSuccess)` then `if ((batchElementLoadedCount + batchElementFailedCount) >= batch_size) { this.on.levelFinished.dispatch(level); }` — mirrors `assetLoadSuccess` at :284. (File moved: `preloader/` → `asset/preloader/`) | **Yes** — `AssetPreloader.spec.js:89` `"a failing asset in an earlier level still advances the preload (C14)"` |
+| C15 | **FIXED** | `engine/navigation/ecs/path_following/PathFollower.js:160-162` | `if (typeof json.loop === "boolean") { this.writeFlag(PathFollowerFlags.Loop, json.loop); }` — and `json.active` is separately routed to `PathFollowerFlags.Active` at :156-158 | **Yes** — `PathFollower.spec.js:8` `"fromJSON reads the loop flag from json.loop, not json.active (C15)"` |
+| C16 | **FIXED** | `engine/animation/curve/actionProcessorOperations/curveActions.js:118-133` | `MoveKeyframeAction.apply` now copies in place: `this.actionContext.refCurve.keys[i].copy(this.curveValueEnd.keys[i]);` with comment "do NOT reassign the live curve's keyframe to the snapshot object … (C16)"; `revert` mirrors it with `.copy(this.curveValueStart.keys[i])`. Snapshots are taken by `.clone()` in the constructor (:110, :113). | **Yes** — `curveActions.spec.js:13` `"MoveKeyframeAction applies end values without aliasing live keyframes to its snapshot (C16)"` |
+| C17 | **OPEN** | `engine/graphics/geometry/MikkT/BuildNeighborsFast.js:116-118` | The B-side edge unpack is still wrong: `const i0_B = temp_edge_B[1];` / `const i1_B = temp_edge_B[2];` / `const edgenum_B = temp_edge_B[2];` — `i1_B` and `edgenum_B` read the **same slot**, and the "flip" comment at :115 is still there. `GetEdge` (`MikkT/GetEdge.js:22-42`) documents the layout as `out[0]=i0, out[1]=i1, out[2]=edgenum`, and the A-side at :85-87 reads it correctly (`temp_edge_A[0]/[1]/[2]`). So the pairing test `if (i0_A === i0_B && i1_A === i1_B …)` at :123 compares a vertex index against an edge number and effectively never matches. | **No** — `MikkT/MikkTSpace.spec.js` only has `'empty geometry'` (:3) and `'single triangle'` (:12); a single triangle has no neighbours, so the pairing path is untested |
+| C18 | **OPEN** | `engine/graphics/geometry/MikkT/GenerateSharedVerticesIndexList.js:79` | Insertion pass still has the precedence bug: `const bin_index = pass * 257 + (_comp_0[i] >> shift) & 0xff;` — `+` binds tighter than `&`, so this masks the whole sum, not just the byte. The **counting** pass at :59 was written correctly (`const index = pass * 257 + ((key >> shift) & 0xff) + 1;`), so counts and insertion now disagree about bin identity. | **No** — no spec references radix sorting or shared-vertex welding; `MikkTSpace.spec.js` does not reach multi-vertex welding |
+| C19 | **FIXED** | `engine/logging/elastic/ElasticSearchLogger.js:61, 82, 141-142` | Field names unified: the config is `this.__flush_timeout = 2000;` (:61) and the handle is `this.__timeout = -1;` (:82). `__prod()` arms it correctly: `} else if (this.__timeout === -1) { this.__timeout = setTimeout(this.__bound_flush, this.__flush_timeout); }`, and `flush()` clears the same field (:95-97). No `__timeout_ms` remains. | **Yes** — `ElasticSearchLogger.spec.js:4` `"logging fewer than flush_size records arms a deferred flush timer (C19)"` |
+| C20 | **FIXED** | `engine/ecs/EntityComponentDataset.js:1881-1882` | `dropData()` now clears both: `this.__entityEventListeners = []; this.__entityAnyEventListeners = [];`. `removeEntity` also purges both (:980-981). | **Yes** — `EntityComponentDataset.spec.js:1019` `"dropData clears any-event listeners so a recycled entity id does not inherit them (C20)"` |
+| C21 | **FIXED** | `engine/ecs/EntityManager.js:357` | Inside `detachDataset()` (:334): `system.handleDatasetDetached(dataset);`. The `handleDatasetAttached` calls remain only on the genuine attach paths (:316 in attach, :714 on system startup). | No dedicated spec found (behaviour is exercised indirectly by the ECS lifecycle suite) |
+| C22 | **FIXED** | `engine/sound/material/concrete/json/serializeSoundMaterialToJSON.js` | carried forward from lead reviewer | — |
+
+## Tally
+
+- **FIXED: 17** — C1, C3, C4, C6, C7, C8, C9, C10, C11, C12, C14, C15, C16, C19, C20, C21, C22
+- **OPEN: 4** — C5, C13, C17, C18
+- **MOVED/UNCLEAR: 0**
+
+Three files moved since the review but were located and verified (no ambiguity about identity):
+
+- `particular/group/ParticleGroup.js` → `graphics/particles/particular/group/ParticleGroup.js`
+- `particular/engine/emitter/ParticlePool.js` → `graphics/particles/particular/engine/emitter/ParticlePool.js`
+- `preloader/AssetPreloader.js` → `asset/preloader/AssetPreloader.js`
+
+## Notes on the OPEN items
+
+- **None of the four OPEN items has a regression spec.** Every FIXED item except C21 shipped with a spec that names its finding ID, so the absence of one is a reliable signal that C5/C13/C17/C18 were never worked.
+- **C17 and C18 are both in `graphics/geometry/MikkT/`** and both sit on the tangent-generation path. The only spec in that directory covers empty geometry and a single triangle — neither case reaches edge pairing or vertex welding.
+- No fix for any of the four is implemented as an `assert.*` (which would not count, since asserts are stripped in production) — the defective lines are plain unguarded logic.

package/src/REVIEW_2026_08_06/prior-highs.md

@@ -1,138 +1,138 @@
-# REVIEW_2026_07_03 §2 + §4 — re-verification against current source (2026-08-06)
-
-Root: `H:/git/moh/app/src/mir-engine/meep/src/`
-Rule applied: an `assert.*` is stripped in production, so an assert-only guard is **not** a fix.
-
-**Tally: 34 FIXED / 32 OPEN / 1 MOVED-UNCLEAR — 67 items checked.**
-
----
-
-## §4 — ECS core & lifecycle
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `Entity.promiseEvent` uses `removeEventListener` instead of `add` | **FIXED** | `engine/ecs/Entity.js:327` | `this.addEventListener(EventType.EntityRemoved, reject);` — matching `removeEventListener` cleanup at :320 |
-| `BinaryBufferSerializer` entity-id delta ordering guarded only by a stripped assert | **OPEN** | `engine/ecs/storage/BinaryBufferSerializer.js:180` | `assert.ok(entity >= lastEntity, ...)` is still the only guard on `const step = entity - lastEntity;` |
-| `EntityComponentDataset` event dispatch: no `try/finally` around the handler loop → throwing handler skips the proxy-pointer restore (§8 LOW) | **OPEN** | `engine/ecs/EntityComponentDataset.js:2161` (and :2203) | `entityListenersProxyPointer = pointerOffset;` restored after a bare loop in both `dispatchEventListenersByHash` and `dispatchAnyEventListenersByHash` |
-
-## §4 — Graphics: ECS bindings
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `LightBinding` scale handler bound to `rotation.onChanged` | **FIXED** | `engine/graphics/ecs/light/binding/LightBinding.js:51` | `this.__c_transform.scale.onChanged.add(this.__apply_scale, this);` (unlink mirrors at :89) |
-| `WaterSystem.shutdown` dereferences `graphicsEngine.size`; preRender hook leaked | **FIXED** | `engine/graphics/ecs/water/WaterSystem.js:68` | `if (this.__preRenderHook !== null) { this.graphicsEngine.on.preRender.remove(this.__preRenderHook);` — no `.size` deref remains |
-| `auto_set_camera_clipping_planes` reads `old_near/far` after overwriting | **FIXED** | `engine/graphics/ecs/camera/auto_set_camera_clipping_planes.js:45` | `const old_near = camera.near;` captured **before** `camera.near = c.clip_near` (:51) |
-| `set_camera_aspect_ratio` ortho `h = bottom - top` | **FIXED** | `engine/graphics/ecs/camera/set_camera_aspect_ratio.js:25` | `const h = c.top - c.bottom;` |
-| `ForwardPlusRenderingPlugin.shutdown` removes from the wrong signal | **FIXED** | `engine/graphics/render/forward_plus/plugin/ForwardPlusRenderingPlugin.js:81` | `graphics.main_view.on.preRender.remove(this.__prepare_for_render, this);` matches the add at :65 |
-| `sg_hierarchy_compute_bounding_box_via_parent_entity` ignores `entity` | **FIXED** | `engine/graphics/ecs/mesh-v2/sg_hierarchy_compute_bounding_box_via_parent_entity.js:19` | `const sg = ecd.getComponent(entity, ShadedGeometry);` — unioned into `result` at :24 |
-| `SGMeshSystem.update` splices its wait-queue while modulo-indexing | **OPEN** | `engine/graphics/ecs/mesh-v2/aggregate/SGMeshSystem.js:283` | `const index = pointer % l;` with `waiting.splice(index, 1);` at :295 and `l` captured before the loop, never decremented |
-
-## §4 — Graphics: texture / particles / geometry
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `ManagedTextureAtlas` serves stale atlas-evicted patches from a TTL-∞ loader cache | **OPEN** | `engine/graphics/texture/atlas/ManagedTextureAtlas.js:148` | `patch = await this.#patch_loader.get(url);` — `#remove_from_lookup` (:91) never invalidates the loader cache (`DEFAULT_TIME_TO_LIVE = Infinity`) |
-| `CachingTextureAtlas.__evict_all` leaves index 0 | **FIXED** | `engine/graphics/texture/atlas/CachingTextureAtlas.js:153` | `for (let i = this.__cached_patches.length - 1; i >= 0; i--) {` |
-| `sampler2d_scale_down_linear` mis-indexes on non-integer ratios | **OPEN** | `engine/graphics/texture/sampler/resize/sampler2d_scale_down_linear.js:54` | `const row_index = (sampleOffsetY + j) * iW;` with fractional `sampleOffsetY = y * sH`; only `assert.ok(sW >= 1, …)` guards it |
-| `sampler2d_copy_with_margins` uses `width` for a vertical bound | **FIXED** | `engine/graphics/texture/sampler/sampler2d_copy_with_margins.js:138` | `for (y = destinationY + height, yMax = Math.min(destination.height, y + marginBottom); ...` (commit `90bcf672a`) |
-| `SimulationStepCurlNoiseVelocity` shared `this.time` accumulates per emitter | **OPEN** | `engine/graphics/particles/particular/engine/simulator/SimulationStepCurlNoiseVelocity.js:22` | `this.time += this.timeDelta;` on the single shared instance held by `ParticularEngine.steps` |
-| `ParticleEmitter` hash/equals disagree on flags | **FIXED** | `engine/graphics/particles/particular/engine/emitter/ParticleEmitter.js:694` | `&& (this.flags & SERIALIZABLE_FLAGS) === (other.flags & SERIALIZABLE_FLAGS);` — same mask `#computeHash()` folds in at :664 |
-| `ShaderManager` leaks a disposed emitter after a graveyard round-trip | **OPEN** | `engine/graphics/particles/particular/engine/shader/ShaderManager.js:399` | `this.recordGraveyard.set(emitter, entry);` — the `entry.count <= 0` branch never splices the emitter out of `entry.emitters` |
-| `equal_attribute_structure` returns truthy `-1` on name mismatch | **FIXED** | `engine/graphics/geometry/optimization/merge/merge_geometry_hierarchy.js:91` | `if (b_attribute_index === -1) { return false; }`; caller uses `if (!equal_attribute_structure(...)) continue;` |
-| `InstancedMeshGroup.build` stale per-instance colors on shrink+regrow | **FIXED** | `engine/graphics/geometry/instancing/InstancedMeshGroup.js:575` | `newColorArray.fill(255, this.count * 4);` |
-| `bvh32_geometry_nearest` duplicated denormalize block | **FIXED** | `engine/graphics/geometry/buffered/query/bvh32_geometry_nearest.js:189` | `if (vertex_data_normalized) { ax = typed_array_value_denormalize(ax, vertices);` — block appears exactly once |
-| `ensureGeometryBoundingSphere` returns stale `null` on first call | **FIXED** | `engine/graphics/geometry/buffered/ensureGeometryBoundingSphere.js:15` | `boundingSphere = geometry.boundingSphere = new ThreeSphere(...)` — chained assignment before `return boundingSphere;` |
-
-## §4 — Water (broken three ways)
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `WaterShader.js` references r136-removed ShaderChunk symbols | **OPEN** | `engine/graphics/shaders/WaterShader.js:22` | `THREE.ShaderChunk["lights_pars"],` — plus `BRDF_Diffuse_Lambert` (:112, :124) and `linear_to_gamma_fragment` (:142) |
-| `WaterSystem.shutdown` TypeError | **FIXED** | (see bindings table) | — |
-| `Water`/`WaterSystem` never dispose height `DataTexture` / geometry / material | **OPEN** | `engine/graphics/ecs/water/WaterSystem.js:215` | `unlink(component, entity) { component.bvh.unlink();` — no `dispose()` on the `PlaneBufferGeometry` (:187), material (:165), or the `DataTexture` in `Water.updateShaderForTerrain` |
-
-## §4 — Control / input
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `phaseCrossed` misses exactly-on-boundary landings | **FIXED** | `engine/control/first-person/FirstPersonPlayerControllerSystem.js:2022` | `return prev < boundary && next >= boundary;` (inclusive in both branches) |
-| `PointerDevice.observeTap` shared move handler under multi-touch | **OPEN** | `engine/input/devices/PointerDevice.js:121` | `up.addOne(handleUp);` / `move.add(handleMove);` — one closure for all pointer ids; `reset(id)` removes the other pointer's registration |
-| `InputControllerSystem.remove` splices index `-1` | **OPEN** | `engine/input/ecs/systems/InputControllerSystem.js:140` | `this.deferred.splice(i_d, 1);` with no `i_d !== -1` guard |
-| `TouchDevice` never attaches its handlers | **OPEN** | `engine/input/devices/touch/TouchDevice.js:53` | `#eventHandlerGlobalTouchEnd = (event) => {` — no `addEventListener`/attach anywhere in the file |
-
-## §4 — ECS gui / terrain
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `HeadsUpDisplaySystem` `z *= scale.y` | **FIXED** | `engine/ecs/gui/hud/HeadsUpDisplaySystem.js:88` | `z *= transform_scale.z;` |
-| `obtainTileAtWorldPosition2D` dereferences an out-of-bounds tile | **OPEN** | `engine/ecs/terrain/tiles/TerrainTileManager.js:489` | `return this.obtain(tile.gridPosition.x, tile.gridPosition.y);` — `getTileByWorldPosition2D` returns `undefined` out of bounds and there is no guard |
-
-## §4 — Asset loaders
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| 1-bit / sub-8-bit palette PNGs decode to garbage | **OPEN** | `engine/asset/loaders/image/png/PNG.js:199` | `const i = this.colors * this.bitDepth / 8 * (y * this.width + x);` — fractional byte index, no shift/mask unpack (also `getUint8Data_case3` :346) |
-| `SVGAssetLoader` hangs on non-200 | **OPEN** | `engine/asset/loaders/SVGAssetLoader.js:10` | `if (xhr.readyState === xhr.DONE && xhr.status === 200) {` — no `else`, so a 404/500 settles nothing |
-| Worker image decoder detaches a cached `ArrayBuffer` | **FIXED** | `engine/asset/loaders/image/codec/ThreadedImageDecoder.js:52` | `return this.worker.request('decode', [data.buffer]);` — `WorkerProxy.trySendMessage` posts with **no** transfer list, so the buffer is cloned |
-
-## §4 — Animation / navigation / intelligence
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `AnimationTrackPlayback.advance` `%= timeEnd` wrap + repeated `on.ended` | **OPEN** (partly fixed) | `engine/animation/keyed2/AnimationTrackPlayback.js:171` | `newPosition %= this.track.timeEnd;` still ignores `timeStart`. The repeated-`ended` half **is** fixed: `else if (this.position < this.track.timeEnd)` latch at :172 |
-| `estimatePathViaIterativeIntegral` infinite loop | **FIXED** | `engine/graphics/ecs/path/tube/build/estimatePathViaIterativeIntegral.js:28` | `if (!on_path) { break; }` |
-| GLTF CUBICSPLINE tangents missing `/Δt` | **OPEN** | `engine/animation/clip/curve_from_track_data_cubic_tangents.js:30` | `curve.add(Keyframe.from(time, value, inTangent, outTangent));` — no division by the keyframe delta anywhere in the file |
-| Grid A* inadmissible squared-distance heuristic | **FIXED** | `engine/navigation/grid/find_path_on_grid_astar.js:185` | `return Math.abs(dx) + Math.abs(dy);` with a comment naming the old squared-euclidean estimate |
-| `OverrideContextBehavior` double init | **FIXED** | `engine/intelligence/behavior/decorator/OverrideContextBehavior.js:37` | `Behavior.prototype.initialize.call(this, context);` with a comment explaining the deliberate skip of `super.initialize()` |
-| `ConditionalBehavior` abandons a running source without finalizing | **OPEN** | `engine/intelligence/behavior/util/ConditionalBehavior.js:41` | `} else if (s === BehaviorStatus.Failed) { condition.finalize(); return s;` — `this.__source` is never finalized on that branch; file unchanged since before the review |
-
-## §4 — Root engine / UI / logging
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `Ticker.pause()` doesn't pause the clock | **FIXED** | `engine/simulation/Ticker.js:269` | `this.clock.pause();` (commit `53a45db88`) |
-| `Ticker.start()` discards the initial rAF handle | **OPEN** | `engine/simulation/Ticker.js:250` | `requestAnimationFrame(animationFrameCallback);` — handle not stored, so `#isUpdateLoopActive()` is false right after start and `stop()` cannot cancel it (`animate()` then re-arms rAF forever) |
-| `SceneManager.clear()` leaves clock speed-modifiers | **FIXED** | `engine/scene/SceneManager.js:159` | `this.deactivateScene(this.#current_scene);` with a comment on removing the modifiers |
-| ElasticSearchLogger POSTs a JSON array, not NDJSON | **FIXED** | `engine/logging/elastic/ElasticSearchLogger.js:123` | `const body = lines.join('\n') + '\n';` with action lines and a `_bulk` endpoint |
-| ElasticSearchLogger `@timestamp = performance.now()` | **OPEN** | `engine/logging/elastic/ElasticSearchLogger.js:151` | `record.time = performance.now();` written as `'@timestamp': record.time` (:117) |
-| `GraphicsEngine.stop()` leaks framebuffers / listeners | **OPEN** | `engine/graphics/GraphicsEngine.js:642` | `stop() { this.context.detach(); ... }` — no `frameBuffers` teardown and the three `context_monitor.on.lost/restored/failed.add(...)` from `start()` (:521-523) are never removed; `initializeFrameBuffers()` re-`add`s buffers on every start |
-| `GUIEngine.shutdown()` leaks tickers / viewport listeners | **OPEN** | `engine/ui/GUIEngine.js:501` | `shutdown() { this.windows.reset(); ... }` — never calls `this.ticker.stop()` (started at :470) and leaves `engine.gameView.size.process(...)` / `this.cursor.process(...)` bound. Localization listener removal **is** now present (:508) |
-| `set_environment_texture` leaks the PMREM target | **FIXED** | `engine/graphics/GraphicsEngine.js:415` | `if (previous_target !== null) { previous_target.dispose(); }` |
-| `DomElementProcessorManager.unlink` leak | **OPEN** | `engine/ui/bindings/DomElementProcessorManager.js:303` | `unlink() { this.__mutation_observer.disconnect(); ... }` — every `DomElementBinding` in `__element_to_bindings` stays bound (no `binding.unbind()`); file unchanged since 2023. The `preRender` listener removal (:309) **is** paired |
-
-## §4 — Graphics GI (sh3)
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| LPV GI vertex shader walks the tet mesh in object space | **OPEN** | `engine/graphics/sh3/gi/material/space_vertex/build_vertex_shader.js:18` | `lpv_walk_to_tetrahedron(position, nearest_tet, tet, barycentric_coordinates);` — `position` is object space while :12/:14 use `worldPosition.xyz` |
-| Path tracer: texture wrap mode never copied | **FIXED** | `engine/graphics/sh3/path_tracer/material/MaterialConverter.js:59` | `st.wrapS = texture.wrapS;` / `st.wrapT = texture.wrapT;` |
-| Path tracer: tint linearized twice | **OPEN** | `engine/graphics/sh3/path_tracer/material/MaterialConverter.js:111` | `sRGB_to_linear(tint, 0, tint, 0);` — the linear tint is multiplied into the still-sRGB-encoded sampler, whose clone keeps `decode_sRGB = true` (`StandardTexture.js:39, :97`), so it is decoded again at sample time |
-| Path tracer: emissive color / intensity dropped | **OPEN** | `engine/graphics/sh3/path_tracer/material/MaterialConverter.js:96` | `} else if (name === "emissive") { result.emissive = sampler;` — only the map; `material.emissive` / `emissiveIntensity` are never read and `StandardMaterial` has no such field |
-
-## §4 — Network
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| `ServerAuthoritativeServer` default-null `authorize` | **FIXED** | `engine/network/orchestrator/ServerAuthoritativeServer.js:130` | `this.executor.authorize = make_owner_authorization({ world, identity_class, server_peer_id });` — secure by default |
-| Receiver reassembly cap 64 KiB vs sender ~302 KiB | **OPEN** | `engine/network/transport/fragments/FragmentAssembler.js:59` | `max_message_size = 65536,` and `NetworkPeer.js:457` uses `new FragmentAssembler()` with no override, while `packet_size.js:59` gives `MAX_LOGICAL_MESSAGE_BYTES = 1186 * 255 ≈ 302 KiB` |
-
----
-
-## §2 — Recurring patterns
-
-| Item | Status | Current file:line | Evidence |
-|---|---|---|---|
-| §2.1 `Camera.copy` drops fov / clip planes | **FIXED** | `engine/graphics/ecs/camera/Camera.js:127` | `this.fov.copy(other.fov); this.clip_near = other.clip_near; this.clip_far = other.clip_far;` |
-| §2.1 `GridPosition2Transform.copy` drops flags | **OPEN** | `engine/grid/grid2transform/GridPosition2Transform.js:80` | `copy(other) { this.offset.copy(other.offset); return this; }` — `flags` (:18) is never copied |
-| §2.1 `Transform.copy` propagates a cleared auto-update flag | **OPEN** | `engine/ecs/transform/Transform.js:278` | `this.flags = other.flags;` after `this.clearFlag(TransformFlags.AutomaticChangeDetection)` — unchanged since 2023 |
-| §2.2 AnimationGraph JSON state `name` / `tags` dropped | **FIXED** | `writeAnimationGraphDefinitionToJSON.js:73-74`, `readAnimationGraphDefinitionFromJSON.js:89-90` | `name: s.name, tags: s.tags,` written; `state.name = name; state.tags = tags;` read |
-| §2.2 `startingSate` typo | **FIXED** (as a divergence) | `writeAnimationGraphDefinitionToJSON.js:100`, `readAnimationGraphDefinitionFromJSON.js:25` | `startingSate: states.indexOf(graph.startingSate)` / `startingSate = 0` — symmetric write/read plus a round-trip spec; the misspelling survives as the field name only |
-| §2.2 POINT-light `distance` binary-only | **FIXED** | `engine/graphics/ecs/light/Light.js:174` | `if (actual_type === LightType.SPOT \|\| actual_type === LightType.POINT) { result.distance = this.distance.toJSON(); }` with the matching read at :141 |
-| §2.2 `SerializationMetadata` flags truncated to 8 bits | **OPEN** | `engine/ecs/components/SerializationMetadataSerializationAdapter.js:15` | `buffer.writeUint8(value.flags);` / `value.flags = buffer.readUint8();` |
-| §2.2 `Team` sentinel aliasing | **OPEN** | `engine/ecs/team/TeamSerializationAdapter.js:22` | `//TODO it's possible to write encoded Infinity values by accident` — `2147483647` round-trips as `Infinity` (same in `ObservedInteger.toBinaryBuffer`) |
-| §2.2 `ViewportPosition.resolveGuiCollisions` dropped | **FIXED** | `engine/ecs/gui/position/ViewportPosition.js:114` | `resolveGuiCollisions: this.resolveGuiCollisions,` in `toJSON`, read at :103, binary at `ViewportPositionSerializationAdapter.js:21/38` |
-| §2.9 `AnimationClip.repeatCount` 1 vs ∞ | **FIXED** | `engine/ecs/animation/AnimationClip.js:9` / `:86` | field `repeatCount = new ObservedInteger(1);`; `fromJSON` else-branch `this.repeatCount.set(1);` |
-| §2.9 `screenEdgeWidth` 10 vs 0 | **FIXED** | `engine/ecs/gui/position/ViewportPosition.js:46` / `:95` | field `screenEdgeWidth = 10;`; `fromJSON` default `screenEdgeWidth = 10,` |
-| §2.8 `SoundControllerSystem` missing `return` after error | **OPEN** | `engine/sound/ecs/SoundControllerSystem.js:82` | `console.error("Entity " + entity + " has no SoundEmitter to control");` (:68) then `emitter.tracks.add(track);` (:82) |
-| §2.8 `SoundEmitterSystem` missing `return` after error | **MOVED-UNCLEAR** | `engine/sound/ecs/emitter/SoundEmitterSystem.js` | The file now contains no `console.*`/logger call and no `=== undefined` fall-through; the described log-and-fall-through site no longer exists, so the item cannot be mapped to current code |
-| §2.8 `ParticleVolume.fromJSON` missing `return` after error | **FIXED** | `engine/graphics/particles/particular/engine/utils/volume/ParticleVolume.js:336` | `throw new Error(\`Unsupported sampling function type '${sampling_function}', ...\`);` — a real throw, not a log |
+# REVIEW_2026_07_03 §2 + §4 — re-verification against current source (2026-08-06)
+
+Root: `H:/git/moh/app/src/mir-engine/meep/src/`
+Rule applied: an `assert.*` is stripped in production, so an assert-only guard is **not** a fix.
+
+**Tally: 34 FIXED / 32 OPEN / 1 MOVED-UNCLEAR — 67 items checked.**
+
+---
+
+## §4 — ECS core & lifecycle
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `Entity.promiseEvent` uses `removeEventListener` instead of `add` | **FIXED** | `engine/ecs/Entity.js:327` | `this.addEventListener(EventType.EntityRemoved, reject);` — matching `removeEventListener` cleanup at :320 |
+| `BinaryBufferSerializer` entity-id delta ordering guarded only by a stripped assert | **OPEN** | `engine/ecs/storage/BinaryBufferSerializer.js:180` | `assert.ok(entity >= lastEntity, ...)` is still the only guard on `const step = entity - lastEntity;` |
+| `EntityComponentDataset` event dispatch: no `try/finally` around the handler loop → throwing handler skips the proxy-pointer restore (§8 LOW) | **OPEN** | `engine/ecs/EntityComponentDataset.js:2161` (and :2203) | `entityListenersProxyPointer = pointerOffset;` restored after a bare loop in both `dispatchEventListenersByHash` and `dispatchAnyEventListenersByHash` |
+
+## §4 — Graphics: ECS bindings
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `LightBinding` scale handler bound to `rotation.onChanged` | **FIXED** | `engine/graphics/ecs/light/binding/LightBinding.js:51` | `this.__c_transform.scale.onChanged.add(this.__apply_scale, this);` (unlink mirrors at :89) |
+| `WaterSystem.shutdown` dereferences `graphicsEngine.size`; preRender hook leaked | **FIXED** | `engine/graphics/ecs/water/WaterSystem.js:68` | `if (this.__preRenderHook !== null) { this.graphicsEngine.on.preRender.remove(this.__preRenderHook);` — no `.size` deref remains |
+| `auto_set_camera_clipping_planes` reads `old_near/far` after overwriting | **FIXED** | `engine/graphics/ecs/camera/auto_set_camera_clipping_planes.js:45` | `const old_near = camera.near;` captured **before** `camera.near = c.clip_near` (:51) |
+| `set_camera_aspect_ratio` ortho `h = bottom - top` | **FIXED** | `engine/graphics/ecs/camera/set_camera_aspect_ratio.js:25` | `const h = c.top - c.bottom;` |
+| `ForwardPlusRenderingPlugin.shutdown` removes from the wrong signal | **FIXED** | `engine/graphics/render/forward_plus/plugin/ForwardPlusRenderingPlugin.js:81` | `graphics.main_view.on.preRender.remove(this.__prepare_for_render, this);` matches the add at :65 |
+| `sg_hierarchy_compute_bounding_box_via_parent_entity` ignores `entity` | **FIXED** | `engine/graphics/ecs/mesh-v2/sg_hierarchy_compute_bounding_box_via_parent_entity.js:19` | `const sg = ecd.getComponent(entity, ShadedGeometry);` — unioned into `result` at :24 |
+| `SGMeshSystem.update` splices its wait-queue while modulo-indexing | **OPEN** | `engine/graphics/ecs/mesh-v2/aggregate/SGMeshSystem.js:283` | `const index = pointer % l;` with `waiting.splice(index, 1);` at :295 and `l` captured before the loop, never decremented |
+
+## §4 — Graphics: texture / particles / geometry
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `ManagedTextureAtlas` serves stale atlas-evicted patches from a TTL-∞ loader cache | **OPEN** | `engine/graphics/texture/atlas/ManagedTextureAtlas.js:148` | `patch = await this.#patch_loader.get(url);` — `#remove_from_lookup` (:91) never invalidates the loader cache (`DEFAULT_TIME_TO_LIVE = Infinity`) |
+| `CachingTextureAtlas.__evict_all` leaves index 0 | **FIXED** | `engine/graphics/texture/atlas/CachingTextureAtlas.js:153` | `for (let i = this.__cached_patches.length - 1; i >= 0; i--) {` |
+| `sampler2d_scale_down_linear` mis-indexes on non-integer ratios | **OPEN** | `engine/graphics/texture/sampler/resize/sampler2d_scale_down_linear.js:54` | `const row_index = (sampleOffsetY + j) * iW;` with fractional `sampleOffsetY = y * sH`; only `assert.ok(sW >= 1, …)` guards it |
+| `sampler2d_copy_with_margins` uses `width` for a vertical bound | **FIXED** | `engine/graphics/texture/sampler/sampler2d_copy_with_margins.js:138` | `for (y = destinationY + height, yMax = Math.min(destination.height, y + marginBottom); ...` (commit `90bcf672a`) |
+| `SimulationStepCurlNoiseVelocity` shared `this.time` accumulates per emitter | **OPEN** | `engine/graphics/particles/particular/engine/simulator/SimulationStepCurlNoiseVelocity.js:22` | `this.time += this.timeDelta;` on the single shared instance held by `ParticularEngine.steps` |
+| `ParticleEmitter` hash/equals disagree on flags | **FIXED** | `engine/graphics/particles/particular/engine/emitter/ParticleEmitter.js:694` | `&& (this.flags & SERIALIZABLE_FLAGS) === (other.flags & SERIALIZABLE_FLAGS);` — same mask `#computeHash()` folds in at :664 |
+| `ShaderManager` leaks a disposed emitter after a graveyard round-trip | **OPEN** | `engine/graphics/particles/particular/engine/shader/ShaderManager.js:399` | `this.recordGraveyard.set(emitter, entry);` — the `entry.count <= 0` branch never splices the emitter out of `entry.emitters` |
+| `equal_attribute_structure` returns truthy `-1` on name mismatch | **FIXED** | `engine/graphics/geometry/optimization/merge/merge_geometry_hierarchy.js:91` | `if (b_attribute_index === -1) { return false; }`; caller uses `if (!equal_attribute_structure(...)) continue;` |
+| `InstancedMeshGroup.build` stale per-instance colors on shrink+regrow | **FIXED** | `engine/graphics/geometry/instancing/InstancedMeshGroup.js:575` | `newColorArray.fill(255, this.count * 4);` |
+| `bvh32_geometry_nearest` duplicated denormalize block | **FIXED** | `engine/graphics/geometry/buffered/query/bvh32_geometry_nearest.js:189` | `if (vertex_data_normalized) { ax = typed_array_value_denormalize(ax, vertices);` — block appears exactly once |
+| `ensureGeometryBoundingSphere` returns stale `null` on first call | **FIXED** | `engine/graphics/geometry/buffered/ensureGeometryBoundingSphere.js:15` | `boundingSphere = geometry.boundingSphere = new ThreeSphere(...)` — chained assignment before `return boundingSphere;` |
+
+## §4 — Water (broken three ways)
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `WaterShader.js` references r136-removed ShaderChunk symbols | **OPEN** | `engine/graphics/shaders/WaterShader.js:22` | `THREE.ShaderChunk["lights_pars"],` — plus `BRDF_Diffuse_Lambert` (:112, :124) and `linear_to_gamma_fragment` (:142) |
+| `WaterSystem.shutdown` TypeError | **FIXED** | (see bindings table) | — |
+| `Water`/`WaterSystem` never dispose height `DataTexture` / geometry / material | **OPEN** | `engine/graphics/ecs/water/WaterSystem.js:215` | `unlink(component, entity) { component.bvh.unlink();` — no `dispose()` on the `PlaneBufferGeometry` (:187), material (:165), or the `DataTexture` in `Water.updateShaderForTerrain` |
+
+## §4 — Control / input
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `phaseCrossed` misses exactly-on-boundary landings | **FIXED** | `engine/control/first-person/FirstPersonPlayerControllerSystem.js:2022` | `return prev < boundary && next >= boundary;` (inclusive in both branches) |
+| `PointerDevice.observeTap` shared move handler under multi-touch | **OPEN** | `engine/input/devices/PointerDevice.js:121` | `up.addOne(handleUp);` / `move.add(handleMove);` — one closure for all pointer ids; `reset(id)` removes the other pointer's registration |
+| `InputControllerSystem.remove` splices index `-1` | **OPEN** | `engine/input/ecs/systems/InputControllerSystem.js:140` | `this.deferred.splice(i_d, 1);` with no `i_d !== -1` guard |
+| `TouchDevice` never attaches its handlers | **OPEN** | `engine/input/devices/touch/TouchDevice.js:53` | `#eventHandlerGlobalTouchEnd = (event) => {` — no `addEventListener`/attach anywhere in the file |
+
+## §4 — ECS gui / terrain
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `HeadsUpDisplaySystem` `z *= scale.y` | **FIXED** | `engine/ecs/gui/hud/HeadsUpDisplaySystem.js:88` | `z *= transform_scale.z;` |
+| `obtainTileAtWorldPosition2D` dereferences an out-of-bounds tile | **OPEN** | `engine/ecs/terrain/tiles/TerrainTileManager.js:489` | `return this.obtain(tile.gridPosition.x, tile.gridPosition.y);` — `getTileByWorldPosition2D` returns `undefined` out of bounds and there is no guard |
+
+## §4 — Asset loaders
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| 1-bit / sub-8-bit palette PNGs decode to garbage | **OPEN** | `engine/asset/loaders/image/png/PNG.js:199` | `const i = this.colors * this.bitDepth / 8 * (y * this.width + x);` — fractional byte index, no shift/mask unpack (also `getUint8Data_case3` :346) |
+| `SVGAssetLoader` hangs on non-200 | **OPEN** | `engine/asset/loaders/SVGAssetLoader.js:10` | `if (xhr.readyState === xhr.DONE && xhr.status === 200) {` — no `else`, so a 404/500 settles nothing |
+| Worker image decoder detaches a cached `ArrayBuffer` | **FIXED** | `engine/asset/loaders/image/codec/ThreadedImageDecoder.js:52` | `return this.worker.request('decode', [data.buffer]);` — `WorkerProxy.trySendMessage` posts with **no** transfer list, so the buffer is cloned |
+
+## §4 — Animation / navigation / intelligence
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `AnimationTrackPlayback.advance` `%= timeEnd` wrap + repeated `on.ended` | **OPEN** (partly fixed) | `engine/animation/keyed2/AnimationTrackPlayback.js:171` | `newPosition %= this.track.timeEnd;` still ignores `timeStart`. The repeated-`ended` half **is** fixed: `else if (this.position < this.track.timeEnd)` latch at :172 |
+| `estimatePathViaIterativeIntegral` infinite loop | **FIXED** | `engine/graphics/ecs/path/tube/build/estimatePathViaIterativeIntegral.js:28` | `if (!on_path) { break; }` |
+| GLTF CUBICSPLINE tangents missing `/Δt` | **OPEN** | `engine/animation/clip/curve_from_track_data_cubic_tangents.js:30` | `curve.add(Keyframe.from(time, value, inTangent, outTangent));` — no division by the keyframe delta anywhere in the file |
+| Grid A* inadmissible squared-distance heuristic | **FIXED** | `engine/navigation/grid/find_path_on_grid_astar.js:185` | `return Math.abs(dx) + Math.abs(dy);` with a comment naming the old squared-euclidean estimate |
+| `OverrideContextBehavior` double init | **FIXED** | `engine/intelligence/behavior/decorator/OverrideContextBehavior.js:37` | `Behavior.prototype.initialize.call(this, context);` with a comment explaining the deliberate skip of `super.initialize()` |
+| `ConditionalBehavior` abandons a running source without finalizing | **OPEN** | `engine/intelligence/behavior/util/ConditionalBehavior.js:41` | `} else if (s === BehaviorStatus.Failed) { condition.finalize(); return s;` — `this.__source` is never finalized on that branch; file unchanged since before the review |
+
+## §4 — Root engine / UI / logging
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `Ticker.pause()` doesn't pause the clock | **FIXED** | `engine/simulation/Ticker.js:269` | `this.clock.pause();` (commit `53a45db88`) |
+| `Ticker.start()` discards the initial rAF handle | **OPEN** | `engine/simulation/Ticker.js:250` | `requestAnimationFrame(animationFrameCallback);` — handle not stored, so `#isUpdateLoopActive()` is false right after start and `stop()` cannot cancel it (`animate()` then re-arms rAF forever) |
+| `SceneManager.clear()` leaves clock speed-modifiers | **FIXED** | `engine/scene/SceneManager.js:159` | `this.deactivateScene(this.#current_scene);` with a comment on removing the modifiers |
+| ElasticSearchLogger POSTs a JSON array, not NDJSON | **FIXED** | `engine/logging/elastic/ElasticSearchLogger.js:123` | `const body = lines.join('\n') + '\n';` with action lines and a `_bulk` endpoint |
+| ElasticSearchLogger `@timestamp = performance.now()` | **OPEN** | `engine/logging/elastic/ElasticSearchLogger.js:151` | `record.time = performance.now();` written as `'@timestamp': record.time` (:117) |
+| `GraphicsEngine.stop()` leaks framebuffers / listeners | **OPEN** | `engine/graphics/GraphicsEngine.js:642` | `stop() { this.context.detach(); ... }` — no `frameBuffers` teardown and the three `context_monitor.on.lost/restored/failed.add(...)` from `start()` (:521-523) are never removed; `initializeFrameBuffers()` re-`add`s buffers on every start |
+| `GUIEngine.shutdown()` leaks tickers / viewport listeners | **OPEN** | `engine/ui/GUIEngine.js:501` | `shutdown() { this.windows.reset(); ... }` — never calls `this.ticker.stop()` (started at :470) and leaves `engine.gameView.size.process(...)` / `this.cursor.process(...)` bound. Localization listener removal **is** now present (:508) |
+| `set_environment_texture` leaks the PMREM target | **FIXED** | `engine/graphics/GraphicsEngine.js:415` | `if (previous_target !== null) { previous_target.dispose(); }` |
+| `DomElementProcessorManager.unlink` leak | **OPEN** | `engine/ui/bindings/DomElementProcessorManager.js:303` | `unlink() { this.__mutation_observer.disconnect(); ... }` — every `DomElementBinding` in `__element_to_bindings` stays bound (no `binding.unbind()`); file unchanged since 2023. The `preRender` listener removal (:309) **is** paired |
+
+## §4 — Graphics GI (sh3)
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| LPV GI vertex shader walks the tet mesh in object space | **OPEN** | `engine/graphics/sh3/gi/material/space_vertex/build_vertex_shader.js:18` | `lpv_walk_to_tetrahedron(position, nearest_tet, tet, barycentric_coordinates);` — `position` is object space while :12/:14 use `worldPosition.xyz` |
+| Path tracer: texture wrap mode never copied | **FIXED** | `engine/graphics/sh3/path_tracer/material/MaterialConverter.js:59` | `st.wrapS = texture.wrapS;` / `st.wrapT = texture.wrapT;` |
+| Path tracer: tint linearized twice | **OPEN** | `engine/graphics/sh3/path_tracer/material/MaterialConverter.js:111` | `sRGB_to_linear(tint, 0, tint, 0);` — the linear tint is multiplied into the still-sRGB-encoded sampler, whose clone keeps `decode_sRGB = true` (`StandardTexture.js:39, :97`), so it is decoded again at sample time |
+| Path tracer: emissive color / intensity dropped | **OPEN** | `engine/graphics/sh3/path_tracer/material/MaterialConverter.js:96` | `} else if (name === "emissive") { result.emissive = sampler;` — only the map; `material.emissive` / `emissiveIntensity` are never read and `StandardMaterial` has no such field |
+
+## §4 — Network
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| `ServerAuthoritativeServer` default-null `authorize` | **FIXED** | `engine/network/orchestrator/ServerAuthoritativeServer.js:130` | `this.executor.authorize = make_owner_authorization({ world, identity_class, server_peer_id });` — secure by default |
+| Receiver reassembly cap 64 KiB vs sender ~302 KiB | **OPEN** | `engine/network/transport/fragments/FragmentAssembler.js:59` | `max_message_size = 65536,` and `NetworkPeer.js:457` uses `new FragmentAssembler()` with no override, while `packet_size.js:59` gives `MAX_LOGICAL_MESSAGE_BYTES = 1186 * 255 ≈ 302 KiB` |
+
+---
+
+## §2 — Recurring patterns
+
+| Item | Status | Current file:line | Evidence |
+|---|---|---|---|
+| §2.1 `Camera.copy` drops fov / clip planes | **FIXED** | `engine/graphics/ecs/camera/Camera.js:127` | `this.fov.copy(other.fov); this.clip_near = other.clip_near; this.clip_far = other.clip_far;` |
+| §2.1 `GridPosition2Transform.copy` drops flags | **OPEN** | `engine/grid/grid2transform/GridPosition2Transform.js:80` | `copy(other) { this.offset.copy(other.offset); return this; }` — `flags` (:18) is never copied |
+| §2.1 `Transform.copy` propagates a cleared auto-update flag | **OPEN** | `engine/ecs/transform/Transform.js:278` | `this.flags = other.flags;` after `this.clearFlag(TransformFlags.AutomaticChangeDetection)` — unchanged since 2023 |
+| §2.2 AnimationGraph JSON state `name` / `tags` dropped | **FIXED** | `writeAnimationGraphDefinitionToJSON.js:73-74`, `readAnimationGraphDefinitionFromJSON.js:89-90` | `name: s.name, tags: s.tags,` written; `state.name = name; state.tags = tags;` read |
+| §2.2 `startingSate` typo | **FIXED** (as a divergence) | `writeAnimationGraphDefinitionToJSON.js:100`, `readAnimationGraphDefinitionFromJSON.js:25` | `startingSate: states.indexOf(graph.startingSate)` / `startingSate = 0` — symmetric write/read plus a round-trip spec; the misspelling survives as the field name only |
+| §2.2 POINT-light `distance` binary-only | **FIXED** | `engine/graphics/ecs/light/Light.js:174` | `if (actual_type === LightType.SPOT \|\| actual_type === LightType.POINT) { result.distance = this.distance.toJSON(); }` with the matching read at :141 |
+| §2.2 `SerializationMetadata` flags truncated to 8 bits | **OPEN** | `engine/ecs/components/SerializationMetadataSerializationAdapter.js:15` | `buffer.writeUint8(value.flags);` / `value.flags = buffer.readUint8();` |
+| §2.2 `Team` sentinel aliasing | **OPEN** | `engine/ecs/team/TeamSerializationAdapter.js:22` | `//TODO it's possible to write encoded Infinity values by accident` — `2147483647` round-trips as `Infinity` (same in `ObservedInteger.toBinaryBuffer`) |
+| §2.2 `ViewportPosition.resolveGuiCollisions` dropped | **FIXED** | `engine/ecs/gui/position/ViewportPosition.js:114` | `resolveGuiCollisions: this.resolveGuiCollisions,` in `toJSON`, read at :103, binary at `ViewportPositionSerializationAdapter.js:21/38` |
+| §2.9 `AnimationClip.repeatCount` 1 vs ∞ | **FIXED** | `engine/ecs/animation/AnimationClip.js:9` / `:86` | field `repeatCount = new ObservedInteger(1);`; `fromJSON` else-branch `this.repeatCount.set(1);` |
+| §2.9 `screenEdgeWidth` 10 vs 0 | **FIXED** | `engine/ecs/gui/position/ViewportPosition.js:46` / `:95` | field `screenEdgeWidth = 10;`; `fromJSON` default `screenEdgeWidth = 10,` |
+| §2.8 `SoundControllerSystem` missing `return` after error | **OPEN** | `engine/sound/ecs/SoundControllerSystem.js:82` | `console.error("Entity " + entity + " has no SoundEmitter to control");` (:68) then `emitter.tracks.add(track);` (:82) |
+| §2.8 `SoundEmitterSystem` missing `return` after error | **MOVED-UNCLEAR** | `engine/sound/ecs/emitter/SoundEmitterSystem.js` | The file now contains no `console.*`/logger call and no `=== undefined` fall-through; the described log-and-fall-through site no longer exists, so the item cannot be mapped to current code |
+| §2.8 `ParticleVolume.fromJSON` missing `return` after error | **FIXED** | `engine/graphics/particles/particular/engine/utils/volume/ParticleVolume.js:336` | `throw new Error(\`Unsupported sampling function type '${sampling_function}', ...\`);` — a real throw, not a log |