puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,19 +1,19 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  resources = Puppet::Type.type(:resources)
5
4
 
6
5
  # There are still plenty of tests to port over from test/.
7
6
  describe resources do
8
-
9
7
  before :each do
10
8
  described_class.reset_system_users_max_uid!
11
9
  end
12
10
 
13
11
  context "when initializing" do
14
12
  it "should fail if the specified resource type does not exist" do
15
- Puppet::Type.stubs(:type).with { |x| x.to_s.downcase == "resources"}.returns resources
16
- Puppet::Type.expects(:type).with("nosuchtype").returns nil
13
+ allow(Puppet::Type).to receive(:type) do
14
+ expect(x.to_s.downcase).to eq("resources")
15
+ end.and_return(resources)
16
+ expect(Puppet::Type).to receive(:type).with("nosuchtype").and_return(nil)
17
17
  expect { resources.new :name => "nosuchtype" }.to raise_error(Puppet::Error)
18
18
  end
19
19
 
@@ -38,20 +38,20 @@ describe resources do
38
38
  end
39
39
 
40
40
  it "cannot be set to true for a resource type that does not accept ensure" do
41
- instance.resource_type.stubs(:respond_to?).returns true
42
- instance.resource_type.stubs(:validproperty?).returns false
41
+ allow(instance.resource_type).to receive(:respond_to?).and_return(true)
42
+ allow(instance.resource_type).to receive(:validproperty?).and_return(false)
43
43
  expect { instance[:purge] = 'yes' }.to raise_error Puppet::Error
44
44
  end
45
45
 
46
46
  it "cannot be set to true for a resource type that does not have instances" do
47
- instance.resource_type.stubs(:respond_to?).returns false
48
- instance.resource_type.stubs(:validproperty?).returns true
47
+ allow(instance.resource_type).to receive(:respond_to?).and_return(false)
48
+ allow(instance.resource_type).to receive(:validproperty?).and_return(true)
49
49
  expect { instance[:purge] = 'yes' }.to raise_error Puppet::Error
50
50
  end
51
51
 
52
52
  it "can be set to true for a resource type that has instances and can accept ensure" do
53
- instance.resource_type.stubs(:respond_to?).returns true
54
- instance.resource_type.stubs(:validproperty?).returns true
53
+ allow(instance.resource_type).to receive(:respond_to?).and_return(true)
54
+ allow(instance.resource_type).to receive(:validproperty?).and_return(true)
55
55
  expect { instance[:purge] = 'yes' }.to_not raise_error
56
56
  end
57
57
  end
@@ -61,7 +61,7 @@ describe resources do
61
61
  before do
62
62
  @res = Puppet::Type.type(:resources).new :name => :user, :purge => true, :unless_system_user => true
63
63
  @res.catalog = Puppet::Resource::Catalog.new
64
- Puppet::FileSystem.stubs(:exist?).with('/etc/login.defs').returns false
64
+ allow(Puppet::FileSystem).to receive(:exist?).with('/etc/login.defs').and_return(false)
65
65
  end
66
66
 
67
67
  it "should never purge hardcoded system users" do
@@ -73,14 +73,14 @@ describe resources do
73
73
  it "should not purge system users if unless_system_user => true" do
74
74
  user_hash = {:name => 'system_user', :uid => 125, :system => true}
75
75
  user = Puppet::Type.type(:user).new(user_hash)
76
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
76
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
77
77
  expect(@res.user_check(user)).to be_falsey
78
78
  end
79
79
 
80
80
  it "should purge non-system users if unless_system_user => true" do
81
81
  user_hash = {:name => 'system_user', :uid => described_class.system_users_max_uid + 1, :system => true}
82
82
  user = Puppet::Type.type(:user).new(user_hash)
83
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
83
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
84
84
  expect(@res.user_check(user)).to be_truthy
85
85
  end
86
86
 
@@ -89,7 +89,7 @@ describe resources do
89
89
  res.catalog = Puppet::Resource::Catalog.new
90
90
  user_hash = {:name => 'system_user', :uid => 500, :system => true}
91
91
  user = Puppet::Type.type(:user).new(user_hash)
92
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
92
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
93
93
  expect(res.user_check(user)).to be_falsey
94
94
  end
95
95
 
@@ -98,7 +98,7 @@ describe resources do
98
98
  res.catalog = Puppet::Resource::Catalog.new
99
99
  user_hash = {:name => 'Administrator', :uid => 'S-1-5-21-12345-500'}
100
100
  user = Puppet::Type.type(:user).new(user_hash)
101
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
101
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
102
102
  expect(res.user_check(user)).to be_falsey
103
103
  end
104
104
 
@@ -107,7 +107,7 @@ describe resources do
107
107
  res.catalog = Puppet::Resource::Catalog.new
108
108
  user_hash = {:name => 'other', :uid => 'S-1-5-21-12345-1001'}
109
109
  user = Puppet::Type.type(:user).new(user_hash)
110
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
110
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
111
111
  expect(res.user_check(user)).to be_truthy
112
112
  end
113
113
  end
@@ -115,10 +115,10 @@ describe resources do
115
115
  %w(FreeBSD OpenBSD).each do |os|
116
116
  context "on #{os}" do
117
117
  before :each do
118
- Facter.stubs(:value).with(:kernel).returns(os)
119
- Facter.stubs(:value).with(:operatingsystem).returns(os)
120
- Facter.stubs(:value).with(:osfamily).returns(os)
121
- Puppet::FileSystem.stubs(:exist?).with('/etc/login.defs').returns false
118
+ allow(Facter).to receive(:value).with(:kernel).and_return(os)
119
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(os)
120
+ allow(Facter).to receive(:value).with(:osfamily).and_return(os)
121
+ allow(Puppet::FileSystem).to receive(:exist?).with('/etc/login.defs').and_return(false)
122
122
  @res = Puppet::Type.type(:resources).new :name => :user, :purge => true, :unless_system_user => true
123
123
  @res.catalog = Puppet::Resource::Catalog.new
124
124
  end
@@ -126,14 +126,14 @@ describe resources do
126
126
  it "should not purge system users under 1000" do
127
127
  user_hash = {:name => 'system_user', :uid => 999}
128
128
  user = Puppet::Type.type(:user).new(user_hash)
129
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
129
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
130
130
  expect(@res.user_check(user)).to be_falsey
131
131
  end
132
132
 
133
133
  it "should purge users over 999" do
134
134
  user_hash = {:name => 'system_user', :uid => 1000}
135
135
  user = Puppet::Type.type(:user).new(user_hash)
136
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
136
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
137
137
  expect(@res.user_check(user)).to be_truthy
138
138
  end
139
139
  end
@@ -141,8 +141,8 @@ describe resources do
141
141
 
142
142
  context 'with login.defs present' do
143
143
  before :each do
144
- Puppet::FileSystem.expects(:exist?).with('/etc/login.defs').returns true
145
- Puppet::FileSystem.expects(:each_line).with('/etc/login.defs').yields(' UID_MIN 1234 # UID_MIN comment ')
144
+ expect(Puppet::FileSystem).to receive(:exist?).with('/etc/login.defs').and_return(true)
145
+ expect(Puppet::FileSystem).to receive(:each_line).with('/etc/login.defs').and_yield(' UID_MIN 1234 # UID_MIN comment ')
146
146
  @res = Puppet::Type.type(:resources).new :name => :user, :purge => true, :unless_system_user => true
147
147
  @res.catalog = Puppet::Resource::Catalog.new
148
148
  end
@@ -150,14 +150,14 @@ describe resources do
150
150
  it 'should not purge a system user' do
151
151
  user_hash = {:name => 'system_user', :uid => 1233}
152
152
  user = Puppet::Type.type(:user).new(user_hash)
153
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
153
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
154
154
  expect(@res.user_check(user)).to be_falsey
155
155
  end
156
156
 
157
157
  it 'should purge a non-system user' do
158
158
  user_hash = {:name => 'system_user', :uid => 1234}
159
159
  user = Puppet::Type.type(:user).new(user_hash)
160
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
160
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
161
161
  expect(@res.user_check(user)).to be_truthy
162
162
  end
163
163
  end
@@ -172,17 +172,16 @@ describe resources do
172
172
  it "should purge uids that are not in a specified array" do
173
173
  user_hash = {:name => 'special_user', :uid => 25_000}
174
174
  user = Puppet::Type.type(:user).new(user_hash)
175
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
175
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
176
176
  expect(@res.user_check(user)).to be_truthy
177
177
  end
178
178
 
179
179
  it "should not purge uids that are in a specified array" do
180
180
  user_hash = {:name => 'special_user', :uid => 15000}
181
181
  user = Puppet::Type.type(:user).new(user_hash)
182
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
182
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
183
183
  expect(@res.user_check(user)).to be_falsey
184
184
  end
185
-
186
185
  end
187
186
 
188
187
  context "with a single integer uid" do
@@ -194,14 +193,14 @@ describe resources do
194
193
  it "should purge uids that are not specified" do
195
194
  user_hash = {:name => 'special_user', :uid => 25_000}
196
195
  user = Puppet::Type.type(:user).new(user_hash)
197
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
196
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
198
197
  expect(@res.user_check(user)).to be_truthy
199
198
  end
200
199
 
201
200
  it "should not purge uids that are specified" do
202
201
  user_hash = {:name => 'special_user', :uid => 15_000}
203
202
  user = Puppet::Type.type(:user).new(user_hash)
204
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
203
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
205
204
  expect(@res.user_check(user)).to be_falsey
206
205
  end
207
206
  end
@@ -215,14 +214,14 @@ describe resources do
215
214
  it "should purge uids that are not specified" do
216
215
  user_hash = {:name => 'special_user', :uid => 25_000}
217
216
  user = Puppet::Type.type(:user).new(user_hash)
218
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
217
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
219
218
  expect(@res.user_check(user)).to be_truthy
220
219
  end
221
220
 
222
221
  it "should not purge uids that are specified" do
223
222
  user_hash = {:name => 'special_user', :uid => 15_000}
224
223
  user = Puppet::Type.type(:user).new(user_hash)
225
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
224
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
226
225
  expect(@res.user_check(user)).to be_falsey
227
226
  end
228
227
  end
@@ -236,25 +235,24 @@ describe resources do
236
235
  it "should not purge ids in the range" do
237
236
  user_hash = {:name => 'special_user', :uid => 15_000}
238
237
  user = Puppet::Type.type(:user).new(user_hash)
239
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
238
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
240
239
  expect(@res.user_check(user)).to be_falsey
241
240
  end
242
241
 
243
242
  it "should not purge specified ids" do
244
243
  user_hash = {:name => 'special_user', :uid => 16_666}
245
244
  user = Puppet::Type.type(:user).new(user_hash)
246
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
245
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
247
246
  expect(@res.user_check(user)).to be_falsey
248
247
  end
249
248
 
250
249
  it "should purge unspecified ids" do
251
250
  user_hash = {:name => 'special_user', :uid => 17_000}
252
251
  user = Puppet::Type.type(:user).new(user_hash)
253
- user.stubs(:retrieve_resource).returns Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash)
252
+ allow(user).to receive(:retrieve_resource).and_return(Puppet::Resource.new("user", user_hash[:name], :parameters => user_hash))
254
253
  expect(@res.user_check(user)).to be_truthy
255
254
  end
256
255
  end
257
-
258
256
  end
259
257
  end
260
258
 
@@ -264,73 +262,73 @@ describe resources do
264
262
  @catalog = Puppet::Resource::Catalog.new
265
263
  end
266
264
 
267
- context "when dealing with non-purging resources" do
268
- before do
269
- @resources = Puppet::Type.type(:resources).new(:name => 'host')
270
- end
265
+ context "when dealing with non-purging resources" do
266
+ before do
267
+ @resources = Puppet::Type.type(:resources).new(:name => 'host')
268
+ end
271
269
 
272
- it "should not generate any resource" do
273
- expect(@resources.generate).to be_empty
274
- end
270
+ it "should not generate any resource" do
271
+ expect(@resources.generate).to be_empty
275
272
  end
273
+ end
276
274
 
277
- context "when the catalog contains a purging resource" do
278
- before do
279
- @resources = Puppet::Type.type(:resources).new(:name => 'host', :purge => true)
280
- @purgeable_resource = Puppet::Type.type(:host).new(:name => 'localhost', :ip => '127.0.0.1')
281
- @catalog.add_resource @resources
282
- end
275
+ context "when the catalog contains a purging resource" do
276
+ before do
277
+ @resources = Puppet::Type.type(:resources).new(:name => 'host', :purge => true)
278
+ @purgeable_resource = Puppet::Type.type(:host).new(:name => 'localhost', :ip => '127.0.0.1')
279
+ @catalog.add_resource @resources
280
+ end
283
281
 
284
- it "should not generate a duplicate of that resource" do
285
- Puppet::Type.type(:host).stubs(:instances).returns [@host1]
286
- @catalog.add_resource @host1
287
- expect(@resources.generate.collect { |r| r.ref }).not_to include(@host1.ref)
288
- end
282
+ it "should not generate a duplicate of that resource" do
283
+ allow(Puppet::Type.type(:host)).to receive(:instances).and_return([@host1])
284
+ @catalog.add_resource @host1
285
+ expect(@resources.generate.collect { |r| r.ref }).not_to include(@host1.ref)
286
+ end
289
287
 
290
- it "should not include the skipped system users" do
291
- res = Puppet::Type.type(:resources).new :name => :user, :purge => true
292
- res.catalog = Puppet::Resource::Catalog.new
288
+ it "should not include the skipped system users" do
289
+ res = Puppet::Type.type(:resources).new :name => :user, :purge => true
290
+ res.catalog = Puppet::Resource::Catalog.new
293
291
 
294
- root = Puppet::Type.type(:user).new(:name => "root")
295
- Puppet::Type.type(:user).expects(:instances).returns [ root ]
292
+ root = Puppet::Type.type(:user).new(:name => "root")
293
+ expect(Puppet::Type.type(:user)).to receive(:instances).and_return([root])
296
294
 
297
- list = res.generate
295
+ list = res.generate
298
296
 
299
- names = list.collect { |r| r[:name] }
300
- expect(names).not_to be_include("root")
301
- end
297
+ names = list.collect { |r| r[:name] }
298
+ expect(names).not_to be_include("root")
299
+ end
302
300
 
303
- context "when generating a purgeable resource" do
304
- it "should be included in the generated resources" do
305
- Puppet::Type.type(:host).stubs(:instances).returns [@purgeable_resource]
306
- expect(@resources.generate.collect { |r| r.ref }).to include(@purgeable_resource.ref)
307
- end
301
+ context "when generating a purgeable resource" do
302
+ it "should be included in the generated resources" do
303
+ allow(Puppet::Type.type(:host)).to receive(:instances).and_return([@purgeable_resource])
304
+ expect(@resources.generate.collect { |r| r.ref }).to include(@purgeable_resource.ref)
308
305
  end
306
+ end
309
307
 
310
- context "when the instance's do not have an ensure property" do
311
- it "should not be included in the generated resources" do
312
- @no_ensure_resource = Puppet::Type.type(:exec).new(:name => "#{File.expand_path('/usr/bin/env')} echo")
313
- Puppet::Type.type(:host).stubs(:instances).returns [@no_ensure_resource]
314
- expect(@resources.generate.collect { |r| r.ref }).not_to include(@no_ensure_resource.ref)
315
- end
308
+ context "when the instance's do not have an ensure property" do
309
+ it "should not be included in the generated resources" do
310
+ @no_ensure_resource = Puppet::Type.type(:exec).new(:name => "#{File.expand_path('/usr/bin/env')} echo")
311
+ allow(Puppet::Type.type(:host)).to receive(:instances).and_return([@no_ensure_resource])
312
+ expect(@resources.generate.collect { |r| r.ref }).not_to include(@no_ensure_resource.ref)
316
313
  end
314
+ end
317
315
 
318
- context "when the instance's ensure property does not accept absent" do
319
- it "should not be included in the generated resources" do
320
- @no_absent_resource = Puppet::Type.type(:service).new(:name => 'foobar')
321
- Puppet::Type.type(:host).stubs(:instances).returns [@no_absent_resource]
322
- expect(@resources.generate.collect { |r| r.ref }).not_to include(@no_absent_resource.ref)
323
- end
316
+ context "when the instance's ensure property does not accept absent" do
317
+ it "should not be included in the generated resources" do
318
+ @no_absent_resource = Puppet::Type.type(:service).new(:name => 'foobar')
319
+ allow(Puppet::Type.type(:host)).to receive(:instances).and_return([@no_absent_resource])
320
+ expect(@resources.generate.collect { |r| r.ref }).not_to include(@no_absent_resource.ref)
324
321
  end
322
+ end
325
323
 
326
- context "when checking the instance fails" do
327
- it "should not be included in the generated resources" do
328
- @purgeable_resource = Puppet::Type.type(:host).new(:name => 'foobar')
329
- Puppet::Type.type(:host).stubs(:instances).returns [@purgeable_resource]
330
- @resources.expects(:check).with(@purgeable_resource).returns(false)
331
- expect(@resources.generate.collect { |r| r.ref }).not_to include(@purgeable_resource.ref)
332
- end
324
+ context "when checking the instance fails" do
325
+ it "should not be included in the generated resources" do
326
+ @purgeable_resource = Puppet::Type.type(:host).new(:name => 'foobar')
327
+ allow(Puppet::Type.type(:host)).to receive(:instances).and_return([@purgeable_resource])
328
+ expect(@resources).to receive(:check).with(@purgeable_resource).and_return(false)
329
+ expect(@resources.generate.collect { |r| r.ref }).not_to include(@purgeable_resource.ref)
333
330
  end
334
331
  end
332
+ end
335
333
  end
336
334
  end
@@ -1,8 +1,6 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  module ScheduleTesting
5
-
6
4
  def diff(unit, incr, method, count)
7
5
  diff = Time.now.to_i.send(method, incr * count)
8
6
  Time.at(diff)
@@ -19,11 +17,11 @@ module ScheduleTesting
19
17
  def min(method, count)
20
18
  diff(:min, 60, method, count)
21
19
  end
22
-
23
20
  end
24
21
 
25
22
  describe Puppet::Type.type(:schedule) do
26
23
  include ScheduleTesting
24
+
27
25
  before :each do
28
26
  Puppet[:ignoreschedules] = false
29
27
 
@@ -78,7 +76,7 @@ describe Puppet::Type.type(:schedule) do
78
76
 
79
77
  describe Puppet::Type.type(:schedule), "when matching ranges" do
80
78
  before do
81
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 0, 0))
79
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 0, 0))
82
80
  end
83
81
 
84
82
  it "should match when the start time is before the current time and the end time is after the current time" do
@@ -114,7 +112,7 @@ describe Puppet::Type.type(:schedule) do
114
112
 
115
113
  describe Puppet::Type.type(:schedule), "when matching ranges with abbreviated time specifications" do
116
114
  before do
117
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 45, 59))
115
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 45, 59))
118
116
  end
119
117
 
120
118
  it "should match when just an hour is specified" do
@@ -135,7 +133,7 @@ describe Puppet::Type.type(:schedule) do
135
133
 
136
134
  describe Puppet::Type.type(:schedule), "when matching ranges with abbreviated time specifications, edge cases part 1" do
137
135
  before do
138
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 00, 00))
136
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 00, 00))
139
137
  end
140
138
 
141
139
  it "should match when the current time is the start of the range using hours" do
@@ -161,7 +159,7 @@ describe Puppet::Type.type(:schedule) do
161
159
 
162
160
  describe Puppet::Type.type(:schedule), "when matching ranges with abbreviated time specifications, edge cases part 2" do
163
161
  before do
164
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 00, 01))
162
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 00, 01))
165
163
  end
166
164
 
167
165
  it "should match when the current time is just past the start of the range using hours" do
@@ -187,7 +185,7 @@ describe Puppet::Type.type(:schedule) do
187
185
 
188
186
  describe Puppet::Type.type(:schedule), "when matching ranges with abbreviated time specifications, edge cases part 3" do
189
187
  before do
190
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 10, 59, 59))
188
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 10, 59, 59))
191
189
  end
192
190
 
193
191
  it "should not match when the current time is just before the start of the range using hours" do
@@ -217,7 +215,7 @@ describe Puppet::Type.type(:schedule) do
217
215
  # advancing the day properly when we push the ending limit out a day.
218
216
  # For example, adding 1 to 31 would throw an error instead of advancing
219
217
  # the date.
220
- Time.stubs(:now).returns(Time.local(2011, "mar", 31, 22, 30, 0))
218
+ allow(Time).to receive(:now).and_return(Time.local(2011, "mar", 31, 22, 30, 0))
221
219
  end
222
220
 
223
221
  it "should match when the start time is before current time and the end time is the following day" do
@@ -237,7 +235,7 @@ describe Puppet::Type.type(:schedule) do
237
235
  # advancing the day properly when we push the ending limit out a day.
238
236
  # For example, adding 1 to 31 would throw an error instead of advancing
239
237
  # the date.
240
- Time.stubs(:now).returns(Time.local(2011, "mar", 31, 1, 30, 0))
238
+ allow(Time).to receive(:now).and_return(Time.local(2011, "mar", 31, 1, 30, 0))
241
239
  end
242
240
 
243
241
  it "should match when the start time is the day before the current time and the end time is after the current time" do
@@ -261,7 +259,7 @@ describe Puppet::Type.type(:schedule) do
261
259
  @schedule[:period] = :hourly
262
260
  @schedule[:periodmatch] = :distance
263
261
 
264
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 0, 0))
262
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 0, 0))
265
263
  end
266
264
 
267
265
  it "should match when the previous time was an hour ago" do
@@ -282,7 +280,7 @@ describe Puppet::Type.type(:schedule) do
282
280
  @schedule[:period] = :daily
283
281
  @schedule[:periodmatch] = :distance
284
282
 
285
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 0, 0))
283
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 0, 0))
286
284
  end
287
285
 
288
286
  it "should match when the previous time was one day ago" do
@@ -303,7 +301,7 @@ describe Puppet::Type.type(:schedule) do
303
301
  @schedule[:period] = :weekly
304
302
  @schedule[:periodmatch] = :distance
305
303
 
306
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 0, 0))
304
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 0, 0))
307
305
  end
308
306
 
309
307
  it "should match when the previous time was seven days ago" do
@@ -324,7 +322,7 @@ describe Puppet::Type.type(:schedule) do
324
322
  @schedule[:period] = :monthly
325
323
  @schedule[:periodmatch] = :distance
326
324
 
327
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 0, 0))
325
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 0, 0))
328
326
  end
329
327
 
330
328
  it "should match when the previous time was 32 days ago" do
@@ -350,7 +348,7 @@ describe Puppet::Type.type(:schedule) do
350
348
  current = Time.utc(2008, 1, 1, 0, 0, 0)
351
349
  previous = Time.utc(2007, 12, 31, 23, 59, 0)
352
350
 
353
- Time.stubs(:now).returns(current)
351
+ allow(Time).to receive(:now).and_return(current)
354
352
  expect(@schedule).to be_match(previous)
355
353
  end
356
354
 
@@ -358,7 +356,7 @@ describe Puppet::Type.type(:schedule) do
358
356
  current = Time.utc(2009, 2, 1, 12, 59, 0)
359
357
  previous = Time.utc(2009, 2, 1, 12, 0, 0)
360
358
 
361
- Time.stubs(:now).returns(current)
359
+ allow(Time).to receive(:now).and_return(current)
362
360
  expect(@schedule).to_not be_match(previous)
363
361
  end
364
362
  end
@@ -375,7 +373,7 @@ describe Puppet::Type.type(:schedule) do
375
373
  # Now set the previous time to one minute before that
376
374
  previous = current - 60
377
375
 
378
- Time.stubs(:now).returns(current)
376
+ allow(Time).to receive(:now).and_return(current)
379
377
  expect(@schedule).to be_match(previous)
380
378
  end
381
379
 
@@ -387,7 +385,7 @@ describe Puppet::Type.type(:schedule) do
387
385
  # Set the current time to 23:59
388
386
  now = previous + (23 * 3600) + (59 * 60)
389
387
 
390
- Time.stubs(:now).returns(now)
388
+ allow(Time).to receive(:now).and_return(now)
391
389
  expect(@schedule).to_not be_match(previous)
392
390
  end
393
391
  end
@@ -400,7 +398,7 @@ describe Puppet::Type.type(:schedule) do
400
398
 
401
399
  it "should match if the previous time is prior to the most recent Sunday" do
402
400
  now = Time.utc(2010, "nov", 11, 0, 0, 0) # Thursday
403
- Time.stubs(:now).returns(now)
401
+ allow(Time).to receive(:now).and_return(now)
404
402
  previous = Time.utc(2010, "nov", 6, 23, 59, 59) # Sat
405
403
 
406
404
  expect(@schedule).to be_match(previous)
@@ -408,7 +406,7 @@ describe Puppet::Type.type(:schedule) do
408
406
 
409
407
  it "should not match if the previous time is after the most recent Saturday" do
410
408
  now = Time.utc(2010, "nov", 11, 0, 0, 0) # Thursday
411
- Time.stubs(:now).returns(now)
409
+ allow(Time).to receive(:now).and_return(now)
412
410
  previous = Time.utc(2010, "nov", 7, 0, 0, 0) # Sunday
413
411
 
414
412
  expect(@schedule).to_not be_match(previous)
@@ -423,7 +421,7 @@ describe Puppet::Type.type(:schedule) do
423
421
 
424
422
  it "should match when the previous time is prior to the first day of this month" do
425
423
  now = Time.utc(2010, "nov", 8, 00, 59, 59)
426
- Time.stubs(:now).returns(now)
424
+ allow(Time).to receive(:now).and_return(now)
427
425
  previous = Time.utc(2010, "oct", 31, 23, 59, 59)
428
426
 
429
427
  expect(@schedule).to be_match(previous)
@@ -431,7 +429,7 @@ describe Puppet::Type.type(:schedule) do
431
429
 
432
430
  it "should not match when the previous time is after the last day of last month" do
433
431
  now = Time.utc(2010, "nov", 8, 00, 59, 59)
434
- Time.stubs(:now).returns(now)
432
+ allow(Time).to receive(:now).and_return(now)
435
433
  previous = Time.utc(2010, "nov", 1, 0, 0, 0)
436
434
 
437
435
  expect(@schedule).to_not be_match(previous)
@@ -443,7 +441,7 @@ describe Puppet::Type.type(:schedule) do
443
441
  @schedule[:period] = :daily
444
442
  @schedule[:repeat] = 2
445
443
 
446
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 0, 0))
444
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 0, 0))
447
445
  end
448
446
 
449
447
  it "should fail if the periodmatch is 'number'" do
@@ -465,7 +463,7 @@ describe Puppet::Type.type(:schedule) do
465
463
  describe Puppet::Type.type(:schedule), "when matching days of the week" do
466
464
  before do
467
465
  # 2011-05-23 is a Monday
468
- Time.stubs(:now).returns(Time.local(2011, "may", 23, 11, 0, 0))
466
+ allow(Time).to receive(:now).and_return(Time.local(2011, "may", 23, 11, 0, 0))
469
467
  end
470
468
 
471
469
  it "should raise an error if the weekday is 'Someday'" do
@@ -559,7 +557,7 @@ describe Puppet::Type.type(:schedule) do
559
557
  describe Puppet::Type.type(:schedule), "when matching days of week and ranges spanning days, day 1" do
560
558
  before do
561
559
  # Test with ranges and days-of-week both set. 2011-03-31 was a Thursday.
562
- Time.stubs(:now).returns(Time.local(2011, "mar", 31, 22, 30, 0))
560
+ allow(Time).to receive(:now).and_return(Time.local(2011, "mar", 31, 22, 30, 0))
563
561
  end
564
562
 
565
563
  it "should match when the range and day of week matches" do
@@ -591,7 +589,7 @@ describe Puppet::Type.type(:schedule) do
591
589
  before do
592
590
  # 2011-03-31 was a Thursday. As the end-time of a day spanning match, that means
593
591
  # we need to match on Wednesday.
594
- Time.stubs(:now).returns(Time.local(2011, "mar", 31, 1, 30, 0))
592
+ allow(Time).to receive(:now).and_return(Time.local(2011, "mar", 31, 1, 30, 0))
595
593
  end
596
594
 
597
595
  it "should match when the range matches and the day of week should match" do