puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'matchers/include_in_order'
4
3
  require 'puppet_spec/compiler'
@@ -90,7 +89,7 @@ describe Puppet::Transaction do
90
89
  report = Puppet::Transaction::Report.new
91
90
  catalog.retrieval_duration = 5
92
91
 
93
- report.expects(:add_times).with(:config_retrieval, 5)
92
+ expect(report).to receive(:add_times).with(:config_retrieval, 5)
94
93
 
95
94
  Puppet::Transaction.new(catalog, report, nil)
96
95
  end
@@ -102,8 +101,8 @@ describe Puppet::Transaction do
102
101
  it "should process events" do
103
102
  transaction = transaction_with_resource(resource)
104
103
 
105
- transaction.expects(:skip?).with(resource).returns false
106
- transaction.event_manager.expects(:process_events).with(resource)
104
+ expect(transaction).to receive(:skip?).with(resource).and_return(false)
105
+ expect(transaction.event_manager).to receive(:process_events).with(resource)
107
106
 
108
107
  transaction.evaluate
109
108
  end
@@ -112,7 +111,7 @@ describe Puppet::Transaction do
112
111
  it "should mark the resource's status as skipped" do
113
112
  transaction = transaction_with_resource(resource)
114
113
 
115
- transaction.expects(:skip?).with(resource).returns true
114
+ expect(transaction).to receive(:skip?).with(resource).and_return(true)
116
115
 
117
116
  transaction.evaluate
118
117
  expect(transaction.resource_status(resource)).to be_skipped
@@ -120,15 +119,15 @@ describe Puppet::Transaction do
120
119
 
121
120
  it "does not process any scheduled events" do
122
121
  transaction = transaction_with_resource(resource)
123
- transaction.expects(:skip?).with(resource).returns true
124
- transaction.event_manager.expects(:process_events).with(resource).never
122
+ expect(transaction).to receive(:skip?).with(resource).and_return(true)
123
+ expect(transaction.event_manager).not_to receive(:process_events).with(resource)
125
124
  transaction.evaluate
126
125
  end
127
126
 
128
127
  it "dequeues all events scheduled on that resource" do
129
128
  transaction = transaction_with_resource(resource)
130
- transaction.expects(:skip?).with(resource).returns true
131
- transaction.event_manager.expects(:dequeue_all_events_for_resource).with(resource)
129
+ expect(transaction).to receive(:skip?).with(resource).and_return(true)
130
+ expect(transaction.event_manager).to receive(:dequeue_all_events_for_resource).with(resource)
132
131
  transaction.evaluate
133
132
  end
134
133
  end
@@ -137,7 +136,7 @@ describe Puppet::Transaction do
137
136
  describe "when evaluating a skipped resource for corrective change it" do
138
137
  before :each do
139
138
  # Enable persistence during tests
140
- Puppet::Transaction::Persistence.any_instance.stubs(:enabled?).returns(true)
139
+ allow_any_instance_of(Puppet::Transaction::Persistence).to receive(:enabled?).and_return(true)
141
140
  end
142
141
 
143
142
  it "should persist in the transactionstore" do
@@ -149,8 +148,8 @@ describe Puppet::Transaction do
149
148
  expect(transaction.resource_status(resource)).to be_changed
150
149
 
151
150
  transaction = transaction_with_resource(resource)
152
- transaction.expects(:skip?).with(resource).returns true
153
- transaction.event_manager.expects(:process_events).with(resource).never
151
+ expect(transaction).to receive(:skip?).with(resource).and_return(true)
152
+ expect(transaction.event_manager).not_to receive(:process_events).with(resource)
154
153
  transaction.evaluate
155
154
  expect(transaction.resource_status(resource)).to be_skipped
156
155
 
@@ -168,35 +167,35 @@ describe Puppet::Transaction do
168
167
  @status = Puppet::Resource::Status.new(@resource)
169
168
 
170
169
  @transaction = Puppet::Transaction.new(@catalog, nil, Puppet::Graph::RandomPrioritizer.new)
171
- @transaction.event_manager.stubs(:queue_events)
170
+ allow(@transaction.event_manager).to receive(:queue_events)
172
171
  end
173
172
 
174
173
  it "should use its resource harness to apply the resource" do
175
- @transaction.resource_harness.expects(:evaluate).with(@resource)
174
+ expect(@transaction.resource_harness).to receive(:evaluate).with(@resource)
176
175
  @transaction.evaluate
177
176
  end
178
177
 
179
178
  it "should add the resulting resource status to its status list" do
180
- @transaction.resource_harness.stubs(:evaluate).returns(@status)
179
+ allow(@transaction.resource_harness).to receive(:evaluate).and_return(@status)
181
180
  @transaction.evaluate
182
181
  expect(@transaction.resource_status(@resource)).to be_instance_of(Puppet::Resource::Status)
183
182
  end
184
183
 
185
184
  it "should queue any events added to the resource status" do
186
- @transaction.resource_harness.stubs(:evaluate).returns(@status)
187
- @status.expects(:events).returns %w{a b}
188
- @transaction.event_manager.expects(:queue_events).with(@resource, ["a", "b"])
185
+ allow(@transaction.resource_harness).to receive(:evaluate).and_return(@status)
186
+ expect(@status).to receive(:events).and_return(%w{a b})
187
+ expect(@transaction.event_manager).to receive(:queue_events).with(@resource, ["a", "b"])
189
188
  @transaction.evaluate
190
189
  end
191
190
 
192
191
  it "should log and skip any resources that cannot be applied" do
193
- @resource.expects(:properties).raises ArgumentError
192
+ expect(@resource).to receive(:properties).and_raise(ArgumentError)
194
193
  @transaction.evaluate
195
194
  expect(@transaction.report.resource_statuses[@resource.to_s]).to be_failed
196
195
  end
197
196
 
198
197
  it "should report any_failed if any resources failed" do
199
- @resource.expects(:properties).raises ArgumentError
198
+ expect(@resource).to receive(:properties).and_raise(ArgumentError)
200
199
  @transaction.evaluate
201
200
 
202
201
  expect(@transaction).to be_any_failed
@@ -236,8 +235,8 @@ describe Puppet::Transaction do
236
235
  end
237
236
 
238
237
  it "should warn if there are no blockers" do
239
- vertex = stub('vertex')
240
- vertex.expects(:warning).with "appears to have a negative number of dependencies"
238
+ vertex = double('vertex')
239
+ expect(vertex).to receive(:warning).with("appears to have a negative number of dependencies")
241
240
  graph.blockers[vertex] = 0
242
241
 
243
242
  graph.unblock(vertex)
@@ -265,7 +264,7 @@ describe Puppet::Transaction do
265
264
  end
266
265
 
267
266
  it "should yield the resource even if eval_generate is called" do
268
- Puppet::Transaction::AdditionalResourceGenerator.any_instance.expects(:eval_generate).with(resource).returns true
267
+ expect_any_instance_of(Puppet::Transaction::AdditionalResourceGenerator).to receive(:eval_generate).with(resource).and_return(true)
269
268
 
270
269
  yielded = false
271
270
  @transaction.evaluate do |res|
@@ -276,7 +275,7 @@ describe Puppet::Transaction do
276
275
  end
277
276
 
278
277
  it "should prefetch the provider if necessary" do
279
- @transaction.expects(:prefetch_if_necessary).with(resource)
278
+ expect(@transaction).to receive(:prefetch_if_necessary).with(resource)
280
279
 
281
280
  @transaction.evaluate {}
282
281
  end
@@ -309,7 +308,7 @@ describe Puppet::Transaction do
309
308
  dependent = Puppet::Type.type(:notify).new(:name => "hello", :require => resource)
310
309
  @transaction.catalog.add_resource(dependent)
311
310
 
312
- resource.stubs(:suitable?).returns false
311
+ allow(resource).to receive(:suitable?).and_return(false)
313
312
 
314
313
  evaluated = []
315
314
  @transaction.evaluate do |res|
@@ -332,20 +331,20 @@ describe Puppet::Transaction do
332
331
 
333
332
  before :each do
334
333
  catalog.add_resource generator
335
- generator.stubs(:generate).returns generated
334
+ allow(generator).to receive(:generate).and_return(generated)
336
335
  # avoid crude failures because of nil resources that result
337
336
  # from implicit containment and lacking containers
338
- catalog.stubs(:container_of).returns generator
337
+ allow(catalog).to receive(:container_of).and_return(generator)
339
338
  end
340
339
 
341
340
  it "should call 'generate' on all created resources" do
342
- generated.each { |res| res.expects(:generate) }
341
+ generated.each { |res| expect(res).to receive(:generate) }
343
342
 
344
343
  transaction.evaluate
345
344
  end
346
345
 
347
346
  it "should finish all resources" do
348
- generated.each { |res| res.expects(:finish) }
347
+ generated.each { |res| expect(res).to receive(:finish) }
349
348
 
350
349
  transaction.evaluate
351
350
  end
@@ -370,30 +369,29 @@ describe Puppet::Transaction do
370
369
 
371
370
  before :each do
372
371
  generator = Puppet::Transaction::AdditionalResourceGenerator.new(catalog, nil, prioritizer)
373
- Puppet::Transaction::AdditionalResourceGenerator.stubs(:new).returns(generator)
372
+ allow(Puppet::Transaction::AdditionalResourceGenerator).to receive(:new).and_return(generator)
374
373
  end
375
374
 
376
375
  it "should should query the generator for whether resources failed to generate" do
377
376
  relationship_graph = Puppet::Graph::RelationshipGraph.new(prioritizer)
378
- catalog.stubs(:relationship_graph).returns(relationship_graph)
377
+ allow(catalog).to receive(:relationship_graph).and_return(relationship_graph)
379
378
 
380
- sequence = sequence(:traverse_first)
381
- relationship_graph.expects(:traverse).in_sequence(sequence)
382
- generator.expects(:resources_failed_to_generate).in_sequence(sequence)
379
+ expect(relationship_graph).to receive(:traverse).ordered
380
+ expect(generator).to receive(:resources_failed_to_generate).ordered
383
381
 
384
382
  transaction.evaluate
385
383
  end
386
384
 
387
385
  it "should report that resources failed to generate" do
388
- generator.expects(:resources_failed_to_generate).returns(true)
389
- report.expects(:resources_failed_to_generate=).with(true)
386
+ expect(generator).to receive(:resources_failed_to_generate).and_return(true)
387
+ expect(report).to receive(:resources_failed_to_generate=).with(true)
390
388
 
391
389
  transaction.evaluate
392
390
  end
393
391
 
394
392
  it "should not report that resources failed to generate if none did" do
395
- generator.expects(:resources_failed_to_generate).returns(false)
396
- report.expects(:resources_failed_to_generate=).never
393
+ expect(generator).to receive(:resources_failed_to_generate).and_return(false)
394
+ expect(report).not_to receive(:resources_failed_to_generate=)
397
395
 
398
396
  transaction.evaluate
399
397
  end
@@ -405,20 +403,20 @@ describe Puppet::Transaction do
405
403
  let(:spec_exception) { 'spec-exception' }
406
404
 
407
405
  it "should invoke each resource's hook and apply the catalog after no failures" do
408
- resource.expects(:pre_run_check)
406
+ expect(resource).to receive(:pre_run_check)
409
407
 
410
408
  transaction.evaluate
411
409
  end
412
410
 
413
411
  it "should abort the transaction on failure" do
414
- resource.expects(:pre_run_check).raises(Puppet::Error, spec_exception)
412
+ expect(resource).to receive(:pre_run_check).and_raise(Puppet::Error, spec_exception)
415
413
 
416
414
  expect { transaction.evaluate }.to raise_error(Puppet::Error, /Some pre-run checks failed/)
417
415
  end
418
416
 
419
417
  it "should log the resource-specific exception" do
420
- resource.expects(:pre_run_check).raises(Puppet::Error, spec_exception)
421
- resource.expects(:log_exception).with(responds_with(:message, spec_exception))
418
+ expect(resource).to receive(:pre_run_check).and_raise(Puppet::Error, spec_exception)
419
+ expect(resource).to receive(:log_exception).with(have_attributes(message: match(/#{spec_exception}/)))
422
420
 
423
421
  expect { transaction.evaluate }.to raise_error(Puppet::Error)
424
422
  end
@@ -433,61 +431,61 @@ describe Puppet::Transaction do
433
431
  end
434
432
 
435
433
  it "should skip resource with missing tags" do
436
- @transaction.stubs(:missing_tags?).returns(true)
434
+ allow(@transaction).to receive(:missing_tags?).and_return(true)
437
435
  expect(@transaction).to be_skip(@resource)
438
436
  end
439
437
 
440
438
  it "should skip resources tagged with the skip tags" do
441
- @transaction.stubs(:skip_tags?).returns(true)
439
+ allow(@transaction).to receive(:skip_tags?).and_return(true)
442
440
  expect(@transaction).to be_skip(@resource)
443
441
  end
444
442
 
445
443
  it "should skip unscheduled resources" do
446
- @transaction.stubs(:scheduled?).returns(false)
444
+ allow(@transaction).to receive(:scheduled?).and_return(false)
447
445
  expect(@transaction).to be_skip(@resource)
448
446
  end
449
447
 
450
448
  it "should skip resources with failed dependencies" do
451
- @transaction.stubs(:failed_dependencies?).returns(true)
449
+ allow(@transaction).to receive(:failed_dependencies?).and_return(true)
452
450
  expect(@transaction).to be_skip(@resource)
453
451
  end
454
452
 
455
453
  it "should skip virtual resource" do
456
- @resource.stubs(:virtual?).returns true
454
+ allow(@resource).to receive(:virtual?).and_return(true)
457
455
  expect(@transaction).to be_skip(@resource)
458
456
  end
459
457
 
460
458
  it "should skip device only resouce on normal host" do
461
- @resource.stubs(:appliable_to_host?).returns false
462
- @resource.stubs(:appliable_to_device?).returns true
459
+ allow(@resource).to receive(:appliable_to_host?).and_return(false)
460
+ allow(@resource).to receive(:appliable_to_device?).and_return(true)
463
461
  @transaction.for_network_device = false
464
462
  expect(@transaction).to be_skip(@resource)
465
463
  end
466
464
 
467
465
  it "should not skip device only resouce on remote device" do
468
- @resource.stubs(:appliable_to_host?).returns false
469
- @resource.stubs(:appliable_to_device?).returns true
466
+ allow(@resource).to receive(:appliable_to_host?).and_return(false)
467
+ allow(@resource).to receive(:appliable_to_device?).and_return(true)
470
468
  @transaction.for_network_device = true
471
469
  expect(@transaction).not_to be_skip(@resource)
472
470
  end
473
471
 
474
472
  it "should skip host resouce on device" do
475
- @resource.stubs(:appliable_to_host?).returns true
476
- @resource.stubs(:appliable_to_device?).returns false
473
+ allow(@resource).to receive(:appliable_to_host?).and_return(true)
474
+ allow(@resource).to receive(:appliable_to_device?).and_return(false)
477
475
  @transaction.for_network_device = true
478
476
  expect(@transaction).to be_skip(@resource)
479
477
  end
480
478
 
481
479
  it "should not skip resouce available on both device and host when on device" do
482
- @resource.stubs(:appliable_to_host?).returns true
483
- @resource.stubs(:appliable_to_device?).returns true
480
+ allow(@resource).to receive(:appliable_to_host?).and_return(true)
481
+ allow(@resource).to receive(:appliable_to_device?).and_return(true)
484
482
  @transaction.for_network_device = true
485
483
  expect(@transaction).not_to be_skip(@resource)
486
484
  end
487
485
 
488
486
  it "should not skip resouce available on both device and host when on host" do
489
- @resource.stubs(:appliable_to_host?).returns true
490
- @resource.stubs(:appliable_to_device?).returns true
487
+ allow(@resource).to receive(:appliable_to_host?).and_return(true)
488
+ allow(@resource).to receive(:appliable_to_device?).and_return(true)
491
489
  @transaction.for_network_device = false
492
490
  expect(@transaction).not_to be_skip(@resource)
493
491
  end
@@ -500,20 +498,20 @@ describe Puppet::Transaction do
500
498
  @resource.catalog = @catalog
501
499
  @transaction = Puppet::Transaction.new(@catalog, nil, nil)
502
500
 
503
- @transaction.stubs(:ignore_tags?).returns false
501
+ allow(@transaction).to receive(:ignore_tags?).and_return(false)
504
502
  end
505
503
 
506
504
  it "should not be missing tags if tags are being ignored" do
507
- @transaction.expects(:ignore_tags?).returns true
505
+ expect(@transaction).to receive(:ignore_tags?).and_return(true)
508
506
 
509
- @resource.expects(:tagged?).never
507
+ expect(@resource).not_to receive(:tagged?)
510
508
 
511
509
  expect(@transaction).not_to be_missing_tags(@resource)
512
510
  end
513
511
 
514
512
  it "should not be missing tags if the transaction tags are empty" do
515
513
  @transaction.tags = []
516
- @resource.expects(:tagged?).never
514
+ expect(@resource).not_to receive(:tagged?)
517
515
  expect(@transaction).not_to be_missing_tags(@resource)
518
516
  end
519
517
 
@@ -534,14 +532,14 @@ describe Puppet::Transaction do
534
532
 
535
533
  it "should always schedule resources if 'ignoreschedules' is set" do
536
534
  @transaction.ignoreschedules = true
537
- @transaction.resource_harness.expects(:scheduled?).never
535
+ expect(@transaction.resource_harness).not_to receive(:scheduled?)
538
536
 
539
537
  @transaction.evaluate
540
538
  expect(@transaction.resource_status(@resource)).to be_changed
541
539
  end
542
540
 
543
541
  it "should let the resource harness determine whether the resource should be scheduled" do
544
- @transaction.resource_harness.expects(:scheduled?).with(@resource).returns "feh"
542
+ expect(@transaction.resource_harness).to receive(:scheduled?).with(@resource).and_return("feh")
545
543
 
546
544
  @transaction.evaluate
547
545
  end
@@ -559,7 +557,7 @@ describe Puppet::Transaction do
559
557
  end
560
558
 
561
559
  it "should match resources by name, not title" do
562
- resource.provider.class.expects(:prefetch).with("bar" => resource)
560
+ expect(resource.provider.class).to receive(:prefetch).with("bar" => resource)
563
561
 
564
562
  transaction.prefetch_if_necessary(resource)
565
563
  end
@@ -567,13 +565,13 @@ describe Puppet::Transaction do
567
565
  it "should not prefetch a provider which has already been prefetched" do
568
566
  transaction.prefetched_providers[:sshkey][:parsed] = true
569
567
 
570
- resource.provider.class.expects(:prefetch).never
568
+ expect(resource.provider.class).not_to receive(:prefetch)
571
569
 
572
570
  transaction.prefetch_if_necessary(resource)
573
571
  end
574
572
 
575
573
  it "should mark the provider prefetched" do
576
- resource.provider.class.stubs(:prefetch)
574
+ allow(resource.provider.class).to receive(:prefetch)
577
575
 
578
576
  transaction.prefetch_if_necessary(resource)
579
577
 
@@ -587,7 +585,7 @@ describe Puppet::Transaction do
587
585
 
588
586
  catalog.add_resource other
589
587
 
590
- resource.provider.class.expects(:prefetch).with('bar' => resource, 'other' => other)
588
+ expect(resource.provider.class).to receive(:prefetch).with('bar' => resource, 'other' => other)
591
589
 
592
590
  transaction.prefetch_if_necessary(resource)
593
591
  end
@@ -595,38 +593,38 @@ describe Puppet::Transaction do
595
593
  it "should not prefetch a provider which has failed" do
596
594
  transaction.prefetch_failed_providers[:sshkey][:parsed] = true
597
595
 
598
- resource.provider.class.expects(:prefetch).never
596
+ expect(resource.provider.class).not_to receive(:prefetch)
599
597
 
600
598
  transaction.prefetch_if_necessary(resource)
601
599
  end
602
600
 
603
601
  it "should not rescue SystemExit without future_features flag" do
604
602
  Puppet.settings[:future_features] = false
605
- resource.provider.class.expects(:prefetch).raises(SystemExit, "SystemMessage")
603
+ expect(resource.provider.class).to receive(:prefetch).and_raise(SystemExit, "SystemMessage")
606
604
  expect { transaction.prefetch_if_necessary(resource) }.to raise_error(SystemExit, "SystemMessage")
607
605
  end
608
606
 
609
607
  it "should not rescue SystemExit with future_features flag" do
610
608
  Puppet.settings[:future_features] = true
611
- resource.provider.class.expects(:prefetch).raises(SystemExit, "SystemMessage")
609
+ expect(resource.provider.class).to receive(:prefetch).and_raise(SystemExit, "SystemMessage")
612
610
  expect { transaction.prefetch_if_necessary(resource) }.to raise_error(SystemExit, "SystemMessage")
613
611
  end
614
612
 
615
613
  it "should rescue LoadError without future_features flag" do
616
614
  Puppet.settings[:future_features] = false
617
- resource.provider.class.expects(:prefetch).raises(LoadError, "LoadMessage")
615
+ expect(resource.provider.class).to receive(:prefetch).and_raise(LoadError, "LoadMessage")
618
616
  expect { transaction.prefetch_if_necessary(resource) }.not_to raise_error
619
617
  end
620
618
 
621
619
  it "should rescue LoadError with future_features flag" do
622
620
  Puppet.settings[:future_features] = true
623
- resource.provider.class.expects(:prefetch).raises(LoadError, "LoadMessage")
621
+ expect(resource.provider.class).to receive(:prefetch).and_raise(LoadError, "LoadMessage")
624
622
  expect { transaction.prefetch_if_necessary(resource) }.not_to raise_error
625
623
  end
626
624
 
627
625
  describe "and prefetching fails" do
628
626
  before :each do
629
- resource.provider.class.expects(:prefetch).raises(Puppet::Error, "message")
627
+ expect(resource.provider.class).to receive(:prefetch).and_raise(Puppet::Error, "message")
630
628
  end
631
629
 
632
630
  context "without future_features flag" do
@@ -639,7 +637,7 @@ describe Puppet::Transaction do
639
637
  end
640
638
 
641
639
  it "should log the exception during prefetch" do
642
- Puppet.expects(:log_exception).with(anything, "Could not prefetch sshkey provider 'parsed': message")
640
+ expect(Puppet).to receive(:log_exception).with(anything, "Could not prefetch sshkey provider 'parsed': message")
643
641
  expect { transaction.prefetch_if_necessary(resource) }.to raise_error(Puppet::Error, "message")
644
642
  end
645
643
  end
@@ -675,14 +673,14 @@ describe Puppet::Transaction do
675
673
 
676
674
  before :each do
677
675
  catalog.add_resource generator
678
- generator.stubs(:generate).returns generated
679
- catalog.stubs(:container_of).returns generator
676
+ allow(generator).to receive(:generate).and_return(generated)
677
+ allow(catalog).to receive(:container_of).and_return(generator)
680
678
  end
681
679
 
682
680
  it "should not evaluate resources with a failed provider, even if the prefetch is rescued" do
683
681
  #Only the generator resource should be applied, all the other resources are failed, and skipped.
684
682
  catalog.remove_resource resource2
685
- transaction.expects(:apply).once
683
+ expect(transaction).to receive(:apply).once
686
684
 
687
685
  transaction.evaluate
688
686
  end
@@ -701,7 +699,7 @@ describe Puppet::Transaction do
701
699
  catalog.add_resource(new_resource)
702
700
 
703
701
  catalog.remove_resource resource2
704
- transaction.expects(:apply).once
702
+ expect(transaction).to receive(:apply).once
705
703
 
706
704
  transaction.evaluate
707
705
 
@@ -773,10 +771,10 @@ describe Puppet::Transaction do
773
771
 
774
772
  it "should call ::post_resource_eval even if one of the resources fails" do
775
773
  resource = teardown_type.new(:title => "foo", :provider => :teardown_provider)
776
- resource.stubs(:retrieve_resource).raises
774
+ allow(resource).to receive(:retrieve_resource).and_raise
777
775
  catalog.add_resource resource
778
776
 
779
- resource.provider.class.expects(:post_resource_eval)
777
+ expect(resource.provider.class).to receive(:post_resource_eval)
780
778
 
781
779
  transaction.evaluate
782
780
  end
@@ -790,7 +788,7 @@ describe Puppet::Transaction do
790
788
 
791
789
  context "when stop is requested" do
792
790
  before :each do
793
- Puppet::Application.stubs(:stop_requested?).returns(true)
791
+ allow(Puppet::Application).to receive(:stop_requested?).and_return(true)
794
792
  end
795
793
 
796
794
  it 'should return true for :stop_processing?' do
@@ -804,7 +802,7 @@ describe Puppet::Transaction do
804
802
  end
805
803
 
806
804
  it 'should return false for :stop_processing? if Puppet::Application.stop_requested? is false' do
807
- Puppet::Application.stubs(:stop_requested?).returns(false)
805
+ allow(Puppet::Application).to receive(:stop_requested?).and_return(false)
808
806
  expect(@transaction.stop_processing?).to be_falsey
809
807
  end
810
808
 
@@ -812,25 +810,25 @@ describe Puppet::Transaction do
812
810
  before do
813
811
  @resource = Puppet::Type.type(:notify).new :title => "foobar"
814
812
  @catalog.add_resource @resource
815
- @transaction.stubs(:add_dynamically_generated_resources)
813
+ allow(@transaction).to receive(:add_dynamically_generated_resources)
816
814
  end
817
815
 
818
816
  it 'should stop processing if :stop_processing? is true' do
819
- @transaction.stubs(:stop_processing?).returns(true)
820
- @transaction.expects(:eval_resource).never
817
+ allow(@transaction).to receive(:stop_processing?).and_return(true)
818
+ expect(@transaction).not_to receive(:eval_resource)
821
819
  @transaction.evaluate
822
820
  end
823
821
 
824
822
  it 'should continue processing if :stop_processing? is false' do
825
- @transaction.stubs(:stop_processing?).returns(false)
826
- @transaction.expects(:eval_resource).returns(nil)
823
+ allow(@transaction).to receive(:stop_processing?).and_return(false)
824
+ expect(@transaction).to receive(:eval_resource).and_return(nil)
827
825
  @transaction.evaluate
828
826
  end
829
827
  end
830
828
  end
831
829
 
832
830
  it "errors with a dependency cycle for a resource that requires itself" do
833
- Puppet.expects(:err).with(regexp_matches(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m))
831
+ expect(Puppet).to receive(:err).with(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m)
834
832
  expect do
835
833
  apply_compiled_manifest(<<-MANIFEST)
836
834
  notify { cycle: require => Notify[cycle] }
@@ -839,7 +837,7 @@ describe Puppet::Transaction do
839
837
  end
840
838
 
841
839
  it "errors with a dependency cycle for a self-requiring resource also required by another resource" do
842
- Puppet.expects(:err).with(regexp_matches(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m))
840
+ expect(Puppet).to receive(:err).with(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m)
843
841
  expect do
844
842
  apply_compiled_manifest(<<-MANIFEST)
845
843
  notify { cycle: require => Notify[cycle] }
@@ -849,7 +847,7 @@ describe Puppet::Transaction do
849
847
  end
850
848
 
851
849
  it "errors with a dependency cycle for a resource that requires itself and another resource" do
852
- Puppet.expects(:err).with(regexp_matches(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m))
850
+ expect(Puppet).to receive(:err).with(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m)
853
851
  expect do
854
852
  apply_compiled_manifest(<<-MANIFEST)
855
853
  notify { cycle:
@@ -861,7 +859,7 @@ describe Puppet::Transaction do
861
859
  end
862
860
 
863
861
  it "errors with a dependency cycle for a resource that is later modified to require itself" do
864
- Puppet.expects(:err).with(regexp_matches(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m))
862
+ expect(Puppet).to receive(:err).with(/Found 1 dependency cycle:.*\(Notify\[cycle\] => Notify\[cycle\]\)/m)
865
863
  expect do
866
864
  apply_compiled_manifest(<<-MANIFEST)
867
865
  notify { cycle: }
@@ -930,15 +928,16 @@ describe Puppet::Transaction do
930
928
  describe "failed dependency is depended on multiple times" do
931
929
  it "notifies the failed dependency once" do
932
930
  command_string = File.expand_path('/my/command')
933
- Puppet::Util::Execution.stubs(:execute).with([command_string]).raises(Puppet::ExecutionFailure, "Failed")
931
+ allow(Puppet::Util::Execution).to receive(:execute).with([command_string]).and_raise(Puppet::ExecutionFailure, "Failed")
934
932
 
935
- Puppet::Type::Notify.any_instance.expects(:send_log).with(:notice, "Dependency Exec[exec1] has failures: true")
936
- Puppet::Type::Notify.any_instance.expects(:send_log).with(:notice, "Dependency Exec[exec2] has failures: true")
937
- Puppet::Type::Notify.any_instance.expects(:send_log).with(:notice, "Dependency Exec[exec3] has failures: true")
938
- Puppet::Type::Notify.any_instance.expects(:send_log).with(:notice, "Dependency Exec[exec4] has failures: true")
939
- Puppet::Type::Notify.any_instance.expects(:send_log).with(:notice, "Dependency Exec[exec5] has failures: true")
933
+ allow_any_instance_of(Puppet::Type::Notify).to receive(:send_log).with(:notice, "Dependency Exec[exec1] has failures: true")
934
+ allow_any_instance_of(Puppet::Type::Notify).to receive(:send_log).with(:notice, "Dependency Exec[exec2] has failures: true")
935
+ allow_any_instance_of(Puppet::Type::Notify).to receive(:send_log).with(:notice, "Dependency Exec[exec3] has failures: true")
936
+ allow_any_instance_of(Puppet::Type::Notify).to receive(:send_log).with(:notice, "Dependency Exec[exec4] has failures: true")
937
+ allow_any_instance_of(Puppet::Type::Notify).to receive(:send_log).with(:notice, "Dependency Exec[exec5] has failures: true")
940
938
 
941
- Puppet::Type::Notify.any_instance.expects(:send_log).with(:warning, "Skipping because of failed dependencies").times(3)
939
+ times_send_log_with_skipping_called = 0
940
+ allow_any_instance_of(Puppet::Type::Notify).to receive(:send_log) {times_send_log_with_skipping_called += 1; nil}.with(:warning, "Skipping because of failed dependencies")
942
941
 
943
942
  apply_compiled_manifest(<<-MANIFEST)
944
943
  exec { ['exec1', 'exec2', 'exec3', 'exec4', 'exec5']:
@@ -946,10 +945,9 @@ describe Puppet::Transaction do
946
945
  } ->
947
946
  notify { ['notify1', 'notify2', 'notify3']: }
948
947
  MANIFEST
949
-
948
+ expect(times_send_log_with_skipping_called).to eq(3)
950
949
  end
951
950
  end
952
-
953
951
  end
954
952
 
955
953
  describe Puppet::Transaction, " when determining tags" do