puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:package).provider(:aptrpm) do
@@ -11,37 +10,33 @@ describe Puppet::Type.type(:package).provider(:aptrpm) do
11
10
 
12
11
  context "when retrieving ensure" do
13
12
  before(:each) do
14
- Puppet::Util.stubs(:which).with("rpm").returns("/bin/rpm")
15
- pkg.provider.stubs(:which).with("rpm").returns("/bin/rpm")
16
- Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "--version"], {:combine => true, :custom_environment => {}, :failonfail => true}).returns(Puppet::Util::Execution::ProcessOutput.new("4.10.1\n", 0)).at_most_once
13
+ allow(Puppet::Util).to receive(:which).with("rpm").and_return("/bin/rpm")
14
+ allow(pkg.provider).to receive(:which).with("rpm").and_return("/bin/rpm")
15
+ expect(Puppet::Util::Execution).to receive(:execute).with(["/bin/rpm", "--version"], {:combine => true, :custom_environment => {}, :failonfail => true}).and_return(Puppet::Util::Execution::ProcessOutput.new("4.10.1\n", 0)).at_most(:once)
17
16
  end
18
17
 
19
18
  def rpm_args
20
19
  ['-q', 'faff', '--nosignature', '--nodigest', '--qf', "'%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n'"]
21
20
  end
22
21
 
23
- def rpm(args = rpm_args)
24
- pkg.provider.expects(:rpm).with(*args)
25
- end
26
-
27
22
  it "should report purged packages" do
28
- rpm.raises(Puppet::ExecutionFailure, "couldn't find rpm")
23
+ expect(pkg.provider).to receive(:rpm).and_raise(Puppet::ExecutionFailure, "couldn't find rpm")
29
24
  expect(pkg.property(:ensure).retrieve).to eq(:purged)
30
25
  end
31
26
 
32
27
  it "should report present packages correctly" do
33
- rpm.returns("faff-1.2.3-1 0 1.2.3-1 5 i686\n")
28
+ expect(pkg.provider).to receive(:rpm).and_return("faff-1.2.3-1 0 1.2.3-1 5 i686\n")
34
29
  expect(pkg.property(:ensure).retrieve).to eq("1.2.3-1-5")
35
30
  end
36
31
  end
37
32
 
38
33
  it "should try and install when asked" do
39
- pkg.provider.expects(:aptget). with('-q', '-y', 'install', 'faff'). returns(0)
34
+ expect(pkg.provider).to receive(:aptget).with('-q', '-y', 'install', 'faff').and_return(0)
40
35
  pkg.provider.install
41
36
  end
42
37
 
43
38
  it "should try and purge when asked" do
44
- pkg.provider.expects(:aptget).with('-y', '-q', 'remove', '--purge', 'faff').returns(0)
39
+ expect(pkg.provider).to receive(:aptget).with('-y', '-q', 'remove', '--purge', 'faff').and_return(0)
45
40
  pkg.provider.purge
46
41
  end
47
42
  end
@@ -4,15 +4,15 @@ require 'puppet/provider/package'
4
4
  describe Puppet::Provider::Package do
5
5
  it 'returns absent for uninstalled packages when not purgeable' do
6
6
  provider = Puppet::Provider::Package.new
7
- provider.expects(:query).returns nil
8
- provider.class.expects(:feature?).with(:purgeable).returns false
7
+ expect(provider).to receive(:query).and_return(nil)
8
+ expect(provider.class).to receive(:feature?).with(:purgeable).and_return(false)
9
9
  expect(provider.properties[:ensure]).to eq(:absent)
10
10
  end
11
11
 
12
12
  it 'returns purged for uninstalled packages when purgeable' do
13
13
  provider = Puppet::Provider::Package.new
14
- provider.expects(:query).returns nil
15
- provider.class.expects(:feature?).with(:purgeable).returns true
14
+ expect(provider).to receive(:query).and_return(nil)
15
+ expect(provider.class).to receive(:feature?).with(:purgeable).and_return(true)
16
16
  expect(provider.properties[:ensure]).to eq(:purged)
17
17
  end
18
18
  end
@@ -2,41 +2,39 @@ require 'spec_helper'
2
2
 
3
3
  # Note that much of the functionality of the dnf provider is already tested with yum provider tests,
4
4
  # as yum is the parent provider.
5
-
6
5
  describe Puppet::Type.type(:package).provider(:dnf) do
7
6
  context 'default' do
8
7
  (19..21).each do |ver|
9
8
  it "should not be the default provider on fedora#{ver}" do
10
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
11
- Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
12
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("#{ver}")
9
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
10
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
11
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("#{ver}")
13
12
  expect(described_class).to_not be_default
14
13
  end
15
14
  end
16
15
 
17
16
  (22..26).each do |ver|
18
17
  it "should be the default provider on fedora#{ver}" do
19
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
20
- Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
21
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("#{ver}")
18
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
19
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
20
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("#{ver}")
22
21
  expect(described_class).to be_default
23
22
  end
24
23
  end
25
24
 
26
25
  it "should not be the default provider on rhel7" do
27
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
28
- Facter.stubs(:value).with(:operatingsystem).returns(:redhat)
29
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("7")
30
- expect(described_class).to_not be_default
26
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
27
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:redhat)
28
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("7")
29
+ expect(described_class).to_not be_default
31
30
  end
32
31
 
33
32
  it "should be the default provider on rhel8" do
34
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
35
- Facter.stubs(:value).with(:operatingsystem).returns(:redhat)
36
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("8")
37
- expect(described_class).to be_default
33
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
34
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:redhat)
35
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("8")
36
+ expect(described_class).to be_default
38
37
  end
39
-
40
38
  end
41
39
 
42
40
  it_behaves_like 'RHEL package provider', described_class, 'dnf'
@@ -12,7 +12,7 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
12
12
  {:failonfail => true, :combine => true, :custom_environment => {}}
13
13
  end
14
14
  let(:resource_name) { 'package' }
15
- let(:resource) { stub 'resource', :[] => resource_name }
15
+ let(:resource) { double('resource', :[] => resource_name) }
16
16
  let(:provider) { described_class.new(resource) }
17
17
 
18
18
  it "has documentation" do
@@ -23,35 +23,35 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
23
23
  let(:execpipe_args) { args.unshift('myquery') }
24
24
 
25
25
  before do
26
- described_class.stubs(:command).with(:dpkgquery).returns 'myquery'
26
+ allow(described_class).to receive(:command).with(:dpkgquery).and_return('myquery')
27
27
  end
28
28
 
29
29
  it "creates and return an instance for a single dpkg-query entry" do
30
- Puppet::Util::Execution.expects(:execpipe).with(execpipe_args).yields bash_installed_io
30
+ expect(Puppet::Util::Execution).to receive(:execpipe).with(execpipe_args).and_yield(bash_installed_io)
31
31
 
32
- installed = mock 'bash'
33
- described_class.expects(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).returns installed
32
+ installed = double('bash')
33
+ expect(described_class).to receive(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).and_return(installed)
34
34
 
35
35
  expect(described_class.instances).to eq([installed])
36
36
  end
37
37
 
38
38
  it "parses multiple dpkg-query multi-line entries in the output" do
39
- Puppet::Util::Execution.expects(:execpipe).with(execpipe_args).yields all_installed_io
39
+ expect(Puppet::Util::Execution).to receive(:execpipe).with(execpipe_args).and_yield(all_installed_io)
40
40
 
41
- bash = mock 'bash'
42
- described_class.expects(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).returns bash
43
- vim = mock 'vim'
44
- described_class.expects(:new).with(:ensure => "2:7.3.547-6ubuntu5", :error => "ok", :desired => "install", :name => "vim", :status => "installed", :provider => :dpkg).returns vim
41
+ bash = double('bash')
42
+ expect(described_class).to receive(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).and_return(bash)
43
+ vim = double('vim')
44
+ expect(described_class).to receive(:new).with(:ensure => "2:7.3.547-6ubuntu5", :error => "ok", :desired => "install", :name => "vim", :status => "installed", :provider => :dpkg).and_return(vim)
45
45
 
46
46
  expect(described_class.instances).to eq([bash, vim])
47
47
  end
48
48
 
49
49
  it "continues without failing if it encounters bad lines between good entries" do
50
- Puppet::Util::Execution.expects(:execpipe).with(execpipe_args).yields StringIO.new([bash_installed_output, "foobar\n", vim_installed_output].join)
50
+ expect(Puppet::Util::Execution).to receive(:execpipe).with(execpipe_args).and_yield(StringIO.new([bash_installed_output, "foobar\n", vim_installed_output].join))
51
51
 
52
- bash = mock 'bash'
53
- vim = mock 'vim'
54
- described_class.expects(:new).twice.returns(bash, vim)
52
+ bash = double('bash')
53
+ vim = double('vim')
54
+ expect(described_class).to receive(:new).twice.and_return(bash, vim)
55
55
 
56
56
  expect(described_class.instances).to eq([bash, vim])
57
57
  end
@@ -65,15 +65,15 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
65
65
  end
66
66
 
67
67
  def dpkg_query_execution_returns(output)
68
- Puppet::Util::Execution.expects(:execute).with(query_args, execute_options).returns(Puppet::Util::Execution::ProcessOutput.new(output, 0))
68
+ expect(Puppet::Util::Execution).to receive(:execute).with(query_args, execute_options).and_return(Puppet::Util::Execution::ProcessOutput.new(output, 0))
69
69
  end
70
70
 
71
71
  before do
72
- Puppet::Util.stubs(:which).with('/usr/bin/dpkg-query').returns(dpkgquery_path)
72
+ allow(Puppet::Util).to receive(:which).with('/usr/bin/dpkg-query').and_return(dpkgquery_path)
73
73
  end
74
74
 
75
75
  it "considers the package purged if dpkg-query fails" do
76
- Puppet::Util::Execution.expects(:execute).with(query_args, execute_options).raises Puppet::ExecutionFailure.new("eh")
76
+ allow(Puppet::Util::Execution).to receive(:execute).with(query_args, execute_options).and_raise(Puppet::ExecutionFailure.new("eh"))
77
77
 
78
78
  expect(provider.query[:ensure]).to eq(:purged)
79
79
  end
@@ -147,8 +147,8 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
147
147
 
148
148
  def parser_test(dpkg_output_string, gold_hash, number_of_debug_logs = 0)
149
149
  dpkg_query_execution_returns(dpkg_output_string)
150
- Puppet.expects(:warning).never
151
- Puppet.expects(:debug).times(number_of_debug_logs)
150
+ expect(Puppet).not_to receive(:warning)
151
+ expect(Puppet).to receive(:debug).exactly(number_of_debug_logs).times
152
152
 
153
153
  expect(provider.query).to eq(gold_hash)
154
154
  end
@@ -163,8 +163,8 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
163
163
  end
164
164
 
165
165
  it "does not log if execution returns with non-zero exit code" do
166
- Puppet::Util::Execution.expects(:execute).with(query_args, execute_options).raises Puppet::ExecutionFailure.new("failed")
167
- Puppet::expects(:debug).never
166
+ expect(Puppet::Util::Execution).to receive(:execute).with(query_args, execute_options).and_raise(Puppet::ExecutionFailure.new("failed"))
167
+ expect(Puppet).not_to receive(:debug)
168
168
 
169
169
  expect(provider.query).to eq(package_not_found_hash)
170
170
  end
@@ -173,106 +173,106 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
173
173
 
174
174
  context "when installing" do
175
175
  before do
176
- resource.stubs(:[]).with(:source).returns "mypkg"
176
+ allow(resource).to receive(:[]).with(:source).and_return("mypkg")
177
177
  end
178
178
 
179
179
  it "fails to install if no source is specified in the resource" do
180
- resource.expects(:[]).with(:source).returns nil
180
+ expect(resource).to receive(:[]).with(:source).and_return(nil)
181
181
 
182
182
  expect { provider.install }.to raise_error(ArgumentError)
183
183
  end
184
184
 
185
185
  it "uses 'dpkg -i' to install the package" do
186
- resource.expects(:[]).with(:source).returns "mypackagefile"
187
- provider.expects(:unhold)
188
- provider.expects(:dpkg).with { |*command| command[-1] == "mypackagefile" and command[-2] == "-i" }
186
+ expect(resource).to receive(:[]).with(:source).and_return("mypackagefile")
187
+ expect(provider).to receive(:unhold)
188
+ expect(provider).to receive(:dpkg).with(any_args, "-i", "mypackagefile")
189
189
 
190
190
  provider.install
191
191
  end
192
192
 
193
193
  it "keeps old config files if told to do so" do
194
- resource.expects(:[]).with(:configfiles).returns :keep
195
- provider.expects(:unhold)
196
- provider.expects(:dpkg).with { |*command| command[0] == "--force-confold" }
194
+ expect(resource).to receive(:[]).with(:configfiles).and_return(:keep)
195
+ expect(provider).to receive(:unhold)
196
+ expect(provider).to receive(:dpkg).with("--force-confold", any_args)
197
197
 
198
198
  provider.install
199
199
  end
200
200
 
201
201
  it "replaces old config files if told to do so" do
202
- resource.expects(:[]).with(:configfiles).returns :replace
203
- provider.expects(:unhold)
204
- provider.expects(:dpkg).with { |*command| command[0] == "--force-confnew" }
202
+ expect(resource).to receive(:[]).with(:configfiles).and_return(:replace)
203
+ expect(provider).to receive(:unhold)
204
+ expect(provider).to receive(:dpkg).with("--force-confnew", any_args)
205
205
 
206
206
  provider.install
207
207
  end
208
208
 
209
209
  it "ensures any hold is removed" do
210
- provider.expects(:unhold).once
211
- provider.expects(:dpkg)
210
+ expect(provider).to receive(:unhold).once
211
+ expect(provider).to receive(:dpkg)
212
212
  provider.install
213
213
  end
214
214
  end
215
215
 
216
216
  context "when holding or unholding" do
217
- let(:tempfile) { stub 'tempfile', :print => nil, :close => nil, :flush => nil, :path => "/other/file" }
217
+ let(:tempfile) { double('tempfile', :print => nil, :close => nil, :flush => nil, :path => "/other/file") }
218
218
 
219
219
  before do
220
- tempfile.stubs(:write)
221
- Tempfile.stubs(:new).returns tempfile
220
+ allow(tempfile).to receive(:write)
221
+ allow(Tempfile).to receive(:new).and_return(tempfile)
222
222
  end
223
223
 
224
224
  it "installs first if holding" do
225
- provider.stubs(:execute)
226
- provider.expects(:install).once
225
+ allow(provider).to receive(:execute)
226
+ expect(provider).to receive(:install).once
227
227
  provider.hold
228
228
  end
229
229
 
230
230
  it "executes dpkg --set-selections when holding" do
231
- provider.stubs(:install)
232
- provider.expects(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
231
+ allow(provider).to receive(:install)
232
+ expect(provider).to receive(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
233
233
  provider.hold
234
234
  end
235
235
 
236
236
  it "executes dpkg --set-selections when unholding" do
237
- provider.stubs(:install)
238
- provider.expects(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
237
+ allow(provider).to receive(:install)
238
+ expect(provider).to receive(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
239
239
  provider.hold
240
240
  end
241
241
  end
242
242
 
243
243
  it "uses :install to update" do
244
- provider.expects(:install)
244
+ expect(provider).to receive(:install)
245
245
  provider.update
246
246
  end
247
247
 
248
248
  context "when determining latest available version" do
249
249
  it "returns the version found by dpkg-deb" do
250
- resource.expects(:[]).with(:source).returns "myfile"
251
- provider.expects(:dpkg_deb).with { |*command| command[-1] == "myfile" }.returns "package\t1.0"
250
+ expect(resource).to receive(:[]).with(:source).and_return("myfile")
251
+ expect(provider).to receive(:dpkg_deb).with(any_args, "myfile").and_return("package\t1.0")
252
252
  expect(provider.latest).to eq("1.0")
253
253
  end
254
254
 
255
255
  it "warns if the package file contains a different package" do
256
- provider.expects(:dpkg_deb).returns("foo\tversion")
257
- provider.expects(:warning)
256
+ expect(provider).to receive(:dpkg_deb).and_return("foo\tversion")
257
+ expect(provider).to receive(:warning)
258
258
  provider.latest
259
259
  end
260
260
 
261
261
  it "copes with names containing ++" do
262
- resource = stub 'resource', :[] => "package++"
262
+ resource = double('resource', :[] => "package++")
263
263
  provider = described_class.new(resource)
264
- provider.expects(:dpkg_deb).returns "package++\t1.0"
264
+ expect(provider).to receive(:dpkg_deb).and_return("package++\t1.0")
265
265
  expect(provider.latest).to eq("1.0")
266
266
  end
267
267
  end
268
268
 
269
269
  it "uses 'dpkg -r' to uninstall" do
270
- provider.expects(:dpkg).with("-r", resource_name)
270
+ expect(provider).to receive(:dpkg).with("-r", resource_name)
271
271
  provider.uninstall
272
272
  end
273
273
 
274
274
  it "uses 'dpkg --purge' to purge" do
275
- provider.expects(:dpkg).with("--purge", resource_name)
275
+ expect(provider).to receive(:dpkg).with("--purge", resource_name)
276
276
  provider.purge
277
277
  end
278
278
  end
@@ -3,14 +3,14 @@ require 'spec_helper'
3
3
  describe Puppet::Type.type(:package).provider(:freebsd) do
4
4
  before :each do
5
5
  # Create a mock resource
6
- @resource = stub 'resource'
6
+ @resource = double('resource')
7
7
 
8
8
  # A catch all; no parameters set
9
- @resource.stubs(:[]).returns(nil)
9
+ allow(@resource).to receive(:[]).and_return(nil)
10
10
 
11
11
  # But set name and source
12
- @resource.stubs(:[]).with(:name).returns "mypackage"
13
- @resource.stubs(:[]).with(:ensure).returns :installed
12
+ allow(@resource).to receive(:[]).with(:name).and_return("mypackage")
13
+ allow(@resource).to receive(:[]).with(:ensure).and_return(:installed)
14
14
 
15
15
  @provider = subject()
16
16
  @provider.resource = @resource
@@ -23,15 +23,15 @@ describe Puppet::Type.type(:package).provider(:freebsd) do
23
23
 
24
24
  context "when installing" do
25
25
  before :each do
26
- @resource.stubs(:should).with(:ensure).returns(:installed)
26
+ allow(@resource).to receive(:should).with(:ensure).and_return(:installed)
27
27
  end
28
28
 
29
29
  it "should install a package from a path to a directory" do
30
30
  # For better or worse, trailing '/' is needed. --daniel 2011-01-26
31
31
  path = '/path/to/directory/'
32
- @resource.stubs(:[]).with(:source).returns(path)
33
- Puppet::Util.expects(:withenv).once.with({:PKG_PATH => path}).yields
34
- @provider.expects(:pkgadd).once.with("mypackage")
32
+ allow(@resource).to receive(:[]).with(:source).and_return(path)
33
+ expect(Puppet::Util).to receive(:withenv).once.with({:PKG_PATH => path}).and_yield
34
+ expect(@provider).to receive(:pkgadd).once.with("mypackage")
35
35
 
36
36
  expect { @provider.install }.to_not raise_error
37
37
  end
@@ -40,9 +40,9 @@ describe Puppet::Type.type(:package).provider(:freebsd) do
40
40
  it "should install a package via #{protocol}" do
41
41
  # For better or worse, trailing '/' is needed. --daniel 2011-01-26
42
42
  path = "#{protocol}://localhost/"
43
- @resource.stubs(:[]).with(:source).returns(path)
44
- Puppet::Util.expects(:withenv).once.with({:PACKAGESITE => path}).yields
45
- @provider.expects(:pkgadd).once.with('-r', "mypackage")
43
+ allow(@resource).to receive(:[]).with(:source).and_return(path)
44
+ expect(Puppet::Util).to receive(:withenv).once.with({:PACKAGESITE => path}).and_yield
45
+ expect(@provider).to receive(:pkgadd).once.with('-r', "mypackage")
46
46
 
47
47
  expect { @provider.install }.to_not raise_error
48
48
  end
@@ -21,39 +21,43 @@ context Puppet::Type.type(:package).provider(:gem) do
21
21
 
22
22
  context "when installing" do
23
23
  it "should use the path to the gem" do
24
- described_class.stubs(:command).with(:gemcmd).returns "/my/gem"
25
- provider.expects(:execute).with { |args| args[0] == "/my/gem" }.returns ""
24
+ allow(described_class).to receive(:command).with(:gemcmd).and_return("/my/gem")
25
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[0]).to eq("/my/gem") }.and_return("")
26
26
  provider.install
27
27
  end
28
28
 
29
29
  it "should specify that the gem is being installed" do
30
- provider.expects(:execute).with { |args| args[1] == "install" }.returns ""
30
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[1]).to eq("install") }.and_return("")
31
31
  provider.install
32
32
  end
33
33
 
34
34
  it "should specify that documentation should not be included" do
35
- provider.expects(:execute).with { |args| args[2] == "--no-rdoc" }.returns ""
35
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("--no-rdoc") }.and_return("")
36
36
  provider.install
37
37
  end
38
38
 
39
39
  it "should specify that RI should not be included" do
40
- provider.expects(:execute).with { |args| args[3] == "--no-ri" }.returns ""
40
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[3]).to eq("--no-ri") }.and_return("")
41
41
  provider.install
42
42
  end
43
43
 
44
44
  it "should specify the package name" do
45
- provider.expects(:execute).with { |args| args[4] == "myresource" }.returns ""
45
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[4]).to eq("myresource") }.and_return("")
46
46
  provider.install
47
47
  end
48
48
 
49
49
  it "should not append install_options by default" do
50
- provider.expects(:execute).with { |args| args.length == 5 }.returns ""
50
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args.length).to eq(5) }.and_return("")
51
51
  provider.install
52
52
  end
53
53
 
54
54
  it "should allow setting an install_options parameter" do
55
55
  resource[:install_options] = [ '--force', {'--bindir' => '/usr/bin' } ]
56
- provider.expects(:execute).with { |args| args[2] == '--force' && args[3] == '--bindir=/usr/bin' }.returns ''
56
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) do |args|
57
+ expect(args[2]).to eq('--force')
58
+ expect(args[3]).to eq('--bindir=/usr/bin')
59
+ end.and_return('')
60
+
57
61
  provider.install
58
62
  end
59
63
 
@@ -61,7 +65,7 @@ context Puppet::Type.type(:package).provider(:gem) do
61
65
  context "as a normal file" do
62
66
  it "should use the file name instead of the gem name" do
63
67
  resource[:source] = "/my/file"
64
- provider.expects(:execute).with { |args| args[2] == "/my/file" }.returns ""
68
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("/my/file") }.and_return("")
65
69
  provider.install
66
70
  end
67
71
  end
@@ -69,7 +73,7 @@ context Puppet::Type.type(:package).provider(:gem) do
69
73
  context "as a file url" do
70
74
  it "should use the file name instead of the gem name" do
71
75
  resource[:source] = "file:///my/file"
72
- provider.expects(:execute).with { |args| args[2] == "/my/file" }.returns ""
76
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("/my/file") }.and_return("")
73
77
  provider.install
74
78
  end
75
79
  end
@@ -84,7 +88,7 @@ context Puppet::Type.type(:package).provider(:gem) do
84
88
  context "as a non-file and non-puppet url" do
85
89
  it "should treat the source as a gem repository" do
86
90
  resource[:source] = "http://host/my/file"
87
- provider.expects(:execute).with { |args| args[2..4] == ["--source", "http://host/my/file", "myresource"] }.returns ""
91
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2..4]).to eq(["--source", "http://host/my/file", "myresource"]) }.and_return("")
88
92
  provider.install
89
93
  end
90
94
  end
@@ -92,14 +96,14 @@ context Puppet::Type.type(:package).provider(:gem) do
92
96
  context "as a windows path on windows", :if => Puppet.features.microsoft_windows? do
93
97
  it "should treat the source as a local path" do
94
98
  resource[:source] = "c:/this/is/a/path/to/a/gem.gem"
95
- provider.expects(:execute).with { |args| args[2] == "c:/this/is/a/path/to/a/gem.gem" }.returns ""
99
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("c:/this/is/a/path/to/a/gem.gem") }.and_return("")
96
100
  provider.install
97
101
  end
98
102
  end
99
103
 
100
104
  context "with an invalid uri" do
101
105
  it "should fail" do
102
- URI.expects(:parse).raises(ArgumentError)
106
+ expect(URI).to receive(:parse).and_raise(ArgumentError)
103
107
  resource[:source] = "http:::::uppet:/:/my/file"
104
108
  expect { provider.install }.to raise_error(Puppet::Error)
105
109
  end
@@ -112,7 +116,7 @@ context Puppet::Type.type(:package).provider(:gem) do
112
116
  #gemlist is used for retrieving both local and remote version numbers, and there are cases
113
117
  # (particularly local) where it makes sense for it to return an array. That doesn't make
114
118
  # sense for '#latest', though.
115
- provider.class.expects(:gemlist).with({ :justme => 'myresource'}).returns({
119
+ expect(provider.class).to receive(:gemlist).with({:justme => 'myresource'}).and_return({
116
120
  :name => 'myresource',
117
121
  :ensure => ["3.0"],
118
122
  :provider => :gem,
@@ -122,29 +126,29 @@ context Puppet::Type.type(:package).provider(:gem) do
122
126
 
123
127
  it "should list from the specified source repository" do
124
128
  resource[:source] = "http://foo.bar.baz/gems"
125
- provider.class.expects(:gemlist).
129
+ expect(provider.class).to receive(:gemlist).
126
130
  with({:justme => 'myresource', :source => "http://foo.bar.baz/gems"}).
127
- returns({
131
+ and_return({
128
132
  :name => 'myresource',
129
133
  :ensure => ["3.0"],
130
134
  :provider => :gem,
131
135
  })
132
- expect(provider.latest).to eq("3.0")
136
+ expect(provider.latest).to eq("3.0")
133
137
  end
134
138
  end
135
139
 
136
140
  context "#instances" do
137
141
  before do
138
- described_class.stubs(:command).with(:gemcmd).returns "/my/gem"
142
+ allow(described_class).to receive(:command).with(:gemcmd).and_return("/my/gem")
139
143
  end
140
144
 
141
145
  it "should return an empty array when no gems installed" do
142
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns("\n")
146
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return("\n")
143
147
  expect(described_class.instances).to eq([])
144
148
  end
145
149
 
146
150
  it "should return ensure values as an array of installed versions" do
147
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns <<-HEREDOC.gsub(/ /, '')
151
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return(<<-HEREDOC.gsub(/ /, ''))
148
152
  systemu (1.2.0)
149
153
  vagrant (0.8.7, 0.6.9)
150
154
  HEREDOC
@@ -156,7 +160,7 @@ context Puppet::Type.type(:package).provider(:gem) do
156
160
  end
157
161
 
158
162
  it "should ignore platform specifications" do
159
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns <<-HEREDOC.gsub(/ /, '')
163
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return(<<-HEREDOC.gsub(/ /, ''))
160
164
  systemu (1.2.0)
161
165
  nokogiri (1.6.1 ruby java x86-mingw32 x86-mswin32-60, 1.4.4.1 x86-mswin32)
162
166
  HEREDOC
@@ -168,7 +172,7 @@ context Puppet::Type.type(:package).provider(:gem) do
168
172
  end
169
173
 
170
174
  it "should not list 'default: ' text from rubygems''" do
171
- described_class.expects(:execute).with(%w{/my/gem list --local}, anything).returns <<-HEREDOC.gsub(/ /, '')
175
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, anything).and_return(<<-HEREDOC.gsub(/ /, ''))
172
176
  bundler (1.16.1, default: 1.16.0, 1.15.1)
173
177
  HEREDOC
174
178
 
@@ -178,27 +182,27 @@ context Puppet::Type.type(:package).provider(:gem) do
178
182
  end
179
183
 
180
184
  it "should not fail when an unmatched line is returned" do
181
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).
182
- returns(File.read(my_fixture('line-with-1.8.5-warning')))
185
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).
186
+ and_return(File.read(my_fixture('line-with-1.8.5-warning')))
183
187
 
184
188
  expect(described_class.instances.map {|p| p.properties}).
185
- to eq([{:provider=>:gem, :ensure=>["0.3.2"], :name=>"columnize"},
186
- {:provider=>:gem, :ensure=>["1.1.3"], :name=>"diff-lcs"},
187
- {:provider=>:gem, :ensure=>["0.0.1"], :name=>"metaclass"},
188
- {:provider=>:gem, :ensure=>["0.10.5"], :name=>"mocha"},
189
- {:provider=>:gem, :ensure=>["0.8.7"], :name=>"rake"},
190
- {:provider=>:gem, :ensure=>["2.9.0"], :name=>"rspec-core"},
191
- {:provider=>:gem, :ensure=>["2.9.1"], :name=>"rspec-expectations"},
192
- {:provider=>:gem, :ensure=>["2.9.0"], :name=>"rspec-mocks"},
193
- {:provider=>:gem, :ensure=>["0.9.0"], :name=>"rubygems-bundler"},
194
- {:provider=>:gem, :ensure=>["1.11.3.3"], :name=>"rvm"}])
189
+ to eq([{provider: :gem, ensure: ["0.3.2"], name: "columnize"},
190
+ {provider: :gem, ensure: ["1.1.3"], name: "diff-lcs"},
191
+ {provider: :gem, ensure: ["0.0.1"], name: "metaclass"},
192
+ {provider: :gem, ensure: ["0.10.5"], name: "mocha"},
193
+ {provider: :gem, ensure: ["0.8.7"], name: "rake"},
194
+ {provider: :gem, ensure: ["2.9.0"], name: "rspec-core"},
195
+ {provider: :gem, ensure: ["2.9.1"], name: "rspec-expectations"},
196
+ {provider: :gem, ensure: ["2.9.0"], name: "rspec-mocks"},
197
+ {provider: :gem, ensure: ["0.9.0"], name: "rubygems-bundler"},
198
+ {provider: :gem, ensure: ["1.11.3.3"], name: "rvm"}])
195
199
  end
196
200
  end
197
201
 
198
202
  context "listing gems" do
199
203
  context "searching for a single package" do
200
204
  it "searches for an exact match" do
201
- described_class.expects(:execute).with(includes('\Abundler\z'), {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns(File.read(my_fixture('gem-list-single-package')))
205
+ expect(described_class).to receive(:execute).with(include('\Abundler\z'), {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return(File.read(my_fixture('gem-list-single-package')))
202
206
  expected = {:name => 'bundler', :ensure => %w[1.6.2], :provider => :gem}
203
207
  expect(described_class.gemlist({:justme => 'bundler'})).to eq(expected)
204
208
  end
@@ -296,39 +300,43 @@ context Puppet::Type.type(:package).provider(:gem) do
296
300
 
297
301
  context "when uninstalling" do
298
302
  it "should use the path to the gem" do
299
- described_class.stubs(:command).with(:gemcmd).returns "/my/gem"
300
- provider.expects(:execute).with { |args| args[0] == "/my/gem" }.returns ""
303
+ allow(described_class).to receive(:command).with(:gemcmd).and_return("/my/gem")
304
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[0]).to eq("/my/gem") }.and_return("")
301
305
  provider.uninstall
302
306
  end
303
307
 
304
308
  it "should specify that the gem is being uninstalled" do
305
- provider.expects(:execute).with { |args| args[1] == "uninstall" }.returns ""
309
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[1]).to eq("uninstall") }.and_return("")
306
310
  provider.uninstall
307
311
  end
308
312
 
309
313
  it "should specify that the relevant executables should be removed without confirmation" do
310
- provider.expects(:execute).with { |args| args[2] == "--executables" }.returns ""
314
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("--executables") }.and_return("")
311
315
  provider.uninstall
312
316
  end
313
317
 
314
318
  it "should specify that all the matching versions should be removed" do
315
- provider.expects(:execute).with { |args| args[3] == "--all" }.returns ""
319
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[3]).to eq("--all") }.and_return("")
316
320
  provider.uninstall
317
321
  end
318
322
 
319
323
  it "should specify the package name" do
320
- provider.expects(:execute).with { |args| args[4] == "myresource" }.returns ""
324
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[4]).to eq("myresource") }.and_return("")
321
325
  provider.uninstall
322
326
  end
323
327
 
324
328
  it "should not append uninstall_options by default" do
325
- provider.expects(:execute).with { |args| args.length == 5 }.returns ""
329
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args.length).to eq(5) }.and_return("")
326
330
  provider.uninstall
327
331
  end
328
332
 
329
333
  it "should allow setting an uninstall_options parameter" do
330
334
  resource[:uninstall_options] = [ '--ignore-dependencies', {'--version' => '0.1.1' } ]
331
- provider.expects(:execute).with { |args| args[5] == '--ignore-dependencies' && args[6] == '--version=0.1.1' }.returns ''
335
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) do |args|
336
+ expect(args[5]).to eq('--ignore-dependencies')
337
+ expect(args[6]).to eq('--version=0.1.1')
338
+ end.and_return('')
339
+
332
340
  provider.uninstall
333
341
  end
334
342
  end