puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:zfs).provider(:zfs) do
@@ -12,7 +11,7 @@ describe Puppet::Type.type(:zfs).provider(:zfs) do
12
11
  let(:provider) { resource.provider }
13
12
 
14
13
  before do
15
- provider.class.stubs(:which).with('zfs').returns(zfs)
14
+ allow(provider.class).to receive(:which).with('zfs').and_return(zfs)
16
15
  end
17
16
 
18
17
  context ".instances" do
@@ -21,7 +20,7 @@ describe Puppet::Type.type(:zfs).provider(:zfs) do
21
20
  end
22
21
 
23
22
  it "should list instances" do
24
- provider.class.expects(:zfs).with(:list,'-H').returns File.read(my_fixture('zfs-list.out'))
23
+ expect(provider.class).to receive(:zfs).with(:list,'-H').and_return(File.read(my_fixture('zfs-list.out')))
25
24
  instances = provider.class.instances.map { |p| {:name => p.get(:name), :ensure => p.get(:ensure)} }
26
25
  expect(instances.size).to eq(2)
27
26
  expect(instances[0]).to eq({:name => 'rpool', :ensure => :present})
@@ -43,7 +42,7 @@ describe Puppet::Type.type(:zfs).provider(:zfs) do
43
42
 
44
43
  context "#create" do
45
44
  it "should execute zfs create" do
46
- provider.expects(:zfs).with(:create, name)
45
+ expect(provider).to receive(:zfs).with(:create, name)
47
46
 
48
47
  provider.create
49
48
  end
@@ -53,7 +52,7 @@ describe Puppet::Type.type(:zfs).provider(:zfs) do
53
52
  it "should include property #{prop}" do
54
53
  resource[prop] = prop
55
54
 
56
- provider.expects(:zfs).with(:create, '-o', "#{prop}=#{prop}", name)
55
+ expect(provider).to receive(:zfs).with(:create, '-o', "#{prop}=#{prop}", name)
57
56
 
58
57
  provider.create
59
58
  end
@@ -61,14 +60,14 @@ describe Puppet::Type.type(:zfs).provider(:zfs) do
61
60
 
62
61
  it "should use -V for the volsize property" do
63
62
  resource[:volsize] = "10"
64
- provider.expects(:zfs).with(:create, '-V', "10", name)
63
+ expect(provider).to receive(:zfs).with(:create, '-V', "10", name)
65
64
  provider.create
66
65
  end
67
66
  end
68
67
 
69
68
  context "#destroy" do
70
69
  it "should execute zfs destroy" do
71
- provider.expects(:zfs).with(:destroy, name)
70
+ expect(provider).to receive(:zfs).with(:destroy, name)
72
71
 
73
72
  provider.destroy
74
73
  end
@@ -77,13 +76,13 @@ describe Puppet::Type.type(:zfs).provider(:zfs) do
77
76
  context "#exists?" do
78
77
  it "should return true if the resource exists" do
79
78
  #return stuff because we have to slice and dice it
80
- provider.expects(:zfs).with(:list, name)
79
+ expect(provider).to receive(:zfs).with(:list, name)
81
80
 
82
81
  expect(provider).to be_exists
83
82
  end
84
83
 
85
84
  it "should return false if returned values don't match the name" do
86
- provider.expects(:zfs).with(:list, name).raises(Puppet::ExecutionFailure, "Failed")
85
+ expect(provider).to receive(:zfs).with(:list, name).and_raise(Puppet::ExecutionFailure, "Failed")
87
86
 
88
87
  expect(provider).not_to be_exists
89
88
  end
@@ -97,68 +96,74 @@ describe Puppet::Type.type(:zfs).provider(:zfs) do
97
96
  :secondarycache, :setuid, :shareiscsi, :sharenfs, :sharesmb,
98
97
  :snapdir, :version, :volsize, :vscan, :xattr].each do |prop|
99
98
  it "should get #{prop}" do
100
- provider.expects(:zfs).with(:get, '-H', '-o', 'value', prop, name).returns("value\n")
99
+ expect(provider).to receive(:zfs).with(:get, '-H', '-o', 'value', prop, name).and_return("value\n")
101
100
 
102
101
  expect(provider.send(prop)).to eq('value')
103
102
  end
104
103
 
105
104
  it "should set #{prop}=value" do
106
- provider.expects(:zfs).with(:set, "#{prop}=value", name)
105
+ expect(provider).to receive(:zfs).with(:set, "#{prop}=value", name)
107
106
 
108
107
  provider.send("#{prop}=", "value")
109
108
  end
110
109
  end
111
110
  end
111
+
112
112
  describe "zoned" do
113
113
  context "on FreeBSD" do
114
114
  before do
115
- Facter.stubs(:value).with(:operatingsystem).returns("FreeBSD")
115
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return("FreeBSD")
116
116
  end
117
+
117
118
  it "should get 'jailed' property" do
118
- provider.expects(:zfs).with(:get, '-H', '-o', 'value', :jailed, name).returns("value\n")
119
+ expect(provider).to receive(:zfs).with(:get, '-H', '-o', 'value', :jailed, name).and_return("value\n")
119
120
  expect(provider.send("zoned")).to eq('value')
120
121
  end
121
122
 
122
123
  it "should set jalied=value" do
123
- provider.expects(:zfs).with(:set, "jailed=value", name)
124
+ expect(provider).to receive(:zfs).with(:set, "jailed=value", name)
124
125
  provider.send("zoned=", "value")
125
126
  end
126
127
  end
127
128
 
128
129
  context "when not running FreeBSD" do
129
130
  before do
130
- Facter.stubs(:value).with(:operatingsystem).returns("Solaris")
131
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return("Solaris")
131
132
  end
133
+
132
134
  it "should get 'zoned' property" do
133
- provider.expects(:zfs).with(:get, '-H', '-o', 'value', :zoned, name).returns("value\n")
135
+ expect(provider).to receive(:zfs).with(:get, '-H', '-o', 'value', :zoned, name).and_return("value\n")
134
136
  expect(provider.send("zoned")).to eq('value')
135
137
  end
136
138
 
137
139
  it "should set zoned=value" do
138
- provider.expects(:zfs).with(:set, "zoned=value", name)
140
+ expect(provider).to receive(:zfs).with(:set, "zoned=value", name)
139
141
  provider.send("zoned=", "value")
140
142
  end
141
143
  end
142
144
  end
145
+
143
146
  describe "acltype" do
144
147
  context "when available" do
145
148
  it "should get 'acltype' property" do
146
- provider.expects(:zfs).with(:get, '-H', '-o', 'value', :acltype, name).returns("value\n")
149
+ expect(provider).to receive(:zfs).with(:get, '-H', '-o', 'value', :acltype, name).and_return("value\n")
147
150
  expect(provider.send("acltype")).to eq('value')
148
151
  end
152
+
149
153
  it "should set acltype=value" do
150
- provider.expects(:zfs).with(:set, "acltype=value", name)
154
+ expect(provider).to receive(:zfs).with(:set, "acltype=value", name)
151
155
  provider.send("acltype=", "value")
152
156
  end
153
157
  end
154
158
 
155
159
  context "when not available" do
156
160
  it "should get '-' for the acltype property" do
157
- provider.expects(:zfs).with(:get, '-H', '-o', 'value', :acltype, name).raises(RuntimeError, 'not valid')
161
+ expect(provider).to receive(:zfs).with(:get, '-H', '-o', 'value', :acltype, name).and_raise(RuntimeError, 'not valid')
158
162
  expect(provider.send("acltype")).to eq('-')
159
163
  end
164
+
160
165
  it "should not error out when trying to set acltype" do
161
- provider.expects(:zfs).with(:set, "acltype=value", name).raises(RuntimeError, 'not valid')
166
+ expect(provider).to receive(:zfs).with(:set, "acltype=value", name).and_raise(RuntimeError, 'not valid')
162
167
  expect{provider.send("acltype=", "value")}.to_not raise_error
163
168
  end
164
169
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:zone).provider(:solaris) do
@@ -7,19 +6,20 @@ describe Puppet::Type.type(:zone).provider(:solaris) do
7
6
 
8
7
  context "#configure" do
9
8
  it "should add the create args to the create str" do
10
- resource.stubs(:properties).returns([])
9
+ allow(resource).to receive(:properties).and_return([])
11
10
  resource[:create_args] = "create_args"
12
- provider.expects(:setconfig).with("create -b create_args")
11
+ expect(provider).to receive(:setconfig).with("create -b create_args")
13
12
  provider.configure
14
13
  end
14
+
15
15
  it "should add the create args to the create str" do
16
- iptype = stub "property"
17
- iptype.stubs(:name).with().returns(:iptype)
18
- iptype.stubs(:safe_insync?).with(iptype).returns(false)
19
- provider.stubs(:properties).returns({:iptype => iptype})
20
- resource.stubs(:properties).with().returns([iptype])
16
+ iptype = double("property")
17
+ allow(iptype).to receive(:name).with(no_args).and_return(:iptype)
18
+ allow(iptype).to receive(:safe_insync?).with(iptype).and_return(false)
19
+ allow(provider).to receive(:properties).and_return({:iptype => iptype})
20
+ allow(resource).to receive(:properties).with(no_args).and_return([iptype])
21
21
  resource[:create_args] = "create_args"
22
- provider.expects(:setconfig).with("create -b create_args\nset ip-type=shared")
22
+ expect(provider).to receive(:setconfig).with("create -b create_args\nset ip-type=shared")
23
23
  provider.configure
24
24
  end
25
25
  end
@@ -27,13 +27,13 @@ describe Puppet::Type.type(:zone).provider(:solaris) do
27
27
  context "#install" do
28
28
  context "clone" do
29
29
  it "should call zoneadm" do
30
- provider.expects(:zoneadm).with(:install)
30
+ expect(provider).to receive(:zoneadm).with(:install)
31
31
  provider.install
32
32
  end
33
33
 
34
34
  it "with the resource's clone attribute" do
35
35
  resource[:clone] = :clone_argument
36
- provider.expects(:zoneadm).with(:clone, :clone_argument)
36
+ expect(provider).to receive(:zoneadm).with(:clone, :clone_argument)
37
37
  provider.install
38
38
  end
39
39
  end
@@ -41,24 +41,25 @@ describe Puppet::Type.type(:zone).provider(:solaris) do
41
41
  context "not clone" do
42
42
  it "should just install if there are no install args" do
43
43
  # there is a nil check in type.rb:[]= so we cannot directly set nil.
44
- resource.stubs(:[]).with(:clone).returns(nil)
45
- resource.stubs(:[]).with(:install_args).returns(nil)
46
- provider.expects(:zoneadm).with(:install)
44
+ allow(resource).to receive(:[]).with(:clone).and_return(nil)
45
+ allow(resource).to receive(:[]).with(:install_args).and_return(nil)
46
+ expect(provider).to receive(:zoneadm).with(:install)
47
47
  provider.install
48
48
  end
49
49
 
50
50
  it "should add the install args to the command if they exist" do
51
51
  # there is a nil check in type.rb:[]= so we cannot directly set nil.
52
- resource.stubs(:[]).with(:clone).returns(nil)
53
- resource.stubs(:[]).with(:install_args).returns('install args')
54
- provider.expects(:zoneadm).with(:install, ["install", "args"])
52
+ allow(resource).to receive(:[]).with(:clone).and_return(nil)
53
+ allow(resource).to receive(:[]).with(:install_args).and_return('install args')
54
+ expect(provider).to receive(:zoneadm).with(:install, ["install", "args"])
55
55
  provider.install
56
56
  end
57
57
  end
58
58
  end
59
+
59
60
  context "#instances" do
60
61
  it "should list the instances correctly" do
61
- described_class.expects(:adm).with(:list, "-cp").returns("0:dummy:running:/::native:shared")
62
+ expect(described_class).to receive(:adm).with(:list, "-cp").and_return("0:dummy:running:/::native:shared")
62
63
  instances = described_class.instances.map { |p| {:name => p.get(:name), :ensure => p.get(:ensure)} }
63
64
  expect(instances.size).to eq(1)
64
65
  expect(instances[0]).to eq({
@@ -67,23 +68,25 @@ describe Puppet::Type.type(:zone).provider(:solaris) do
67
68
  })
68
69
  end
69
70
  end
71
+
70
72
  context "#setconfig" do
71
73
  it "should correctly set configuration" do
72
- provider.expects(:command).with(:cfg).returns('/usr/sbin/zonecfg')
73
- provider.expects(:exec_cmd).with(:input => "set zonepath=/\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').returns({:out=>'', :exit => 0})
74
+ expect(provider).to receive(:command).with(:cfg).and_return('/usr/sbin/zonecfg')
75
+ expect(provider).to receive(:exec_cmd).with(:input => "set zonepath=/\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').and_return({:out=>'', :exit => 0})
74
76
  provider.setconfig("set zonepath=\/")
75
77
  provider.flush
76
78
  end
77
79
 
78
80
  it "should correctly warn on 'not allowed'" do
79
- provider.expects(:command).with(:cfg).returns('/usr/sbin/zonecfg')
80
- provider.expects(:exec_cmd).with(:input => "set zonepath=/\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').returns({:out=>"Zone z2 already installed; set zonepath not allowed.\n", :exit => 0})
81
+ expect(provider).to receive(:command).with(:cfg).and_return('/usr/sbin/zonecfg')
82
+ expect(provider).to receive(:exec_cmd).with(:input => "set zonepath=/\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').and_return({:out=>"Zone z2 already installed; set zonepath not allowed.\n", :exit => 0})
81
83
  provider.setconfig("set zonepath=\/")
82
84
  expect {
83
85
  provider.flush
84
86
  }.to raise_error(ArgumentError, /Failed to apply configuration/)
85
87
  end
86
88
  end
89
+
87
90
  context "#getconfig" do
88
91
  describe "with a shared iptype zone" do
89
92
  zone_info =<<-EOF
@@ -106,8 +109,9 @@ net:
106
109
  physical: ex0002
107
110
  defrouter not specified
108
111
  EOF
112
+
109
113
  it "should correctly parse zone info" do
110
- provider.expects(:zonecfg).with(:info).returns(zone_info)
114
+ expect(provider).to receive(:zonecfg).with(:info).and_return(zone_info)
111
115
  expect(provider.getconfig).to eq({
112
116
  :brand=>"native",
113
117
  :autoboot=>"true",
@@ -118,6 +122,7 @@ net:
118
122
  })
119
123
  end
120
124
  end
125
+
121
126
  describe "with an exclusive iptype zone" do
122
127
  zone_info =<<-EOF
123
128
  zonename: dummy
@@ -137,8 +142,9 @@ net:
137
142
  physical: net1
138
143
  defrouter not specified
139
144
  EOF
145
+
140
146
  it "should correctly parse zone info" do
141
- provider.expects(:zonecfg).with(:info).returns(zone_info)
147
+ expect(provider).to receive(:zonecfg).with(:info).and_return(zone_info)
142
148
  expect(provider.getconfig).to eq({
143
149
  :brand=>"native",
144
150
  :autoboot=>"true",
@@ -149,78 +155,85 @@ net:
149
155
  })
150
156
  end
151
157
  end
158
+
152
159
  describe "with an invalid or unrecognized config" do
153
160
  it "should produce an error message with provider context when given an invalid config" do
154
161
  erroneous_zone_info =<<-EOF
155
162
  physical: net1'
156
163
  EOF
157
164
 
158
- provider.expects(:zonecfg).with(:info).returns(erroneous_zone_info)
159
- provider.expects('err').with("Ignoring ' physical: net1''")
165
+ expect(provider).to receive(:zonecfg).with(:info).and_return(erroneous_zone_info)
166
+ expect(provider).to receive('err').with("Ignoring ' physical: net1''")
160
167
  provider.getconfig
161
168
  end
162
169
 
163
-
164
170
  it "should produce a debugging message with provider context when given an unrecognized config" do
165
171
  unrecognized_zone_info = "dummy"
166
- provider.expects(:zonecfg).with(:info).returns(unrecognized_zone_info)
167
- provider.expects('debug').with("Ignoring zone output 'dummy'")
172
+ expect(provider).to receive(:zonecfg).with(:info).and_return(unrecognized_zone_info)
173
+ expect(provider).to receive('debug').with("Ignoring zone output 'dummy'")
168
174
  provider.getconfig
169
175
  end
170
176
  end
171
177
  end
178
+
172
179
  context "#flush" do
173
180
  it "should correctly execute pending commands" do
174
- provider.expects(:command).with(:cfg).returns('/usr/sbin/zonecfg')
175
- provider.expects(:exec_cmd).with(:input => "set iptype=shared\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').returns({:out=>'', :exit => 0})
181
+ expect(provider).to receive(:command).with(:cfg).and_return('/usr/sbin/zonecfg')
182
+ expect(provider).to receive(:exec_cmd).with(:input => "set iptype=shared\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').and_return({:out=>'', :exit => 0})
176
183
  provider.setconfig("set iptype=shared")
177
184
  provider.flush
178
185
  end
179
186
 
180
187
  it "should correctly raise error on failure" do
181
- provider.expects(:command).with(:cfg).returns('/usr/sbin/zonecfg')
182
- provider.expects(:exec_cmd).with(:input => "set iptype=shared\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').returns({:out=>'', :exit => 1})
188
+ expect(provider).to receive(:command).with(:cfg).and_return('/usr/sbin/zonecfg')
189
+ expect(provider).to receive(:exec_cmd).with(:input => "set iptype=shared\ncommit\nexit", :cmd => '/usr/sbin/zonecfg -z dummy -f -').and_return({:out=>'', :exit => 1})
183
190
  provider.setconfig("set iptype=shared")
184
191
  expect {
185
192
  provider.flush
186
193
  }.to raise_error(ArgumentError, /Failed to apply/)
187
194
  end
188
195
  end
196
+
189
197
  context "#start" do
190
198
  it "should not require path if sysidcfg is specified" do
191
199
  resource[:path] = '/mypath'
192
200
  resource[:sysidcfg] = 'dummy'
193
- Puppet::FileSystem.stubs(:exist?).with('/mypath/root/etc/sysidcfg').returns true
194
- File.stubs(:directory?).with('/mypath/root/etc').returns true
195
- provider.expects(:zoneadm).with(:boot)
201
+ allow(Puppet::FileSystem).to receive(:exist?).with('/mypath/root/etc/sysidcfg').and_return(true)
202
+ allow(File).to receive(:directory?).with('/mypath/root/etc').and_return(true)
203
+ expect(provider).to receive(:zoneadm).with(:boot)
196
204
  provider.start
197
205
  end
198
206
 
199
207
  it "should require path if sysidcfg is specified" do
200
- resource.stubs(:[]).with(:path).returns nil
201
- resource.stubs(:[]).with(:sysidcfg).returns 'dummy'
208
+ allow(resource).to receive(:[]).with(:path).and_return(nil)
209
+ allow(resource).to receive(:[]).with(:sysidcfg).and_return('dummy')
202
210
  expect {
203
211
  provider.start
204
212
  }.to raise_error(Puppet::Error, /Path is required/)
205
213
  end
206
214
  end
215
+
207
216
  context "#line2hash" do
208
217
  it "should parse lines correctly" do
209
218
  expect(described_class.line2hash('0:dummy:running:/z::native:shared')).to eq({:ensure=>:running, :iptype=>"shared", :path=>"/z", :name=>"dummy", :id=>"0"})
210
219
  end
220
+
211
221
  it "should parse lines correctly(2)" do
212
222
  expect(described_class.line2hash('0:dummy:running:/z:ipkg:native:shared')).to eq({:ensure=>:running, :iptype=>"shared", :path=>"/z", :name=>"dummy", :id=>"0"})
213
223
  end
224
+
214
225
  it "should parse lines correctly(3)" do
215
226
  expect(described_class.line2hash('-:dummy:running:/z:ipkg:native:shared')).to eq({:ensure=>:running, :iptype=>"shared", :path=>"/z", :name=>"dummy"})
216
227
  end
228
+
217
229
  it "should parse lines correctly(3)" do
218
230
  expect(described_class.line2hash('-:dummy:running:/z:ipkg:native:exclusive')).to eq({:ensure=>:running, :iptype=>"exclusive", :path=>"/z", :name=>"dummy"})
219
231
  end
220
232
  end
233
+
221
234
  context "#multi_conf" do
222
235
  it "should correctly add and remove properties" do
223
- provider.stubs(:properties).with().returns({:ip => ['1.1.1.1', '2.2.2.2']})
236
+ allow(provider).to receive(:properties).with(no_args).and_return({:ip => ['1.1.1.1', '2.2.2.2']})
224
237
  should = ['1.1.1.1', '3.3.3.3']
225
238
  p = Proc.new do |a, str|
226
239
  case a
@@ -231,17 +244,18 @@ net:
231
244
  expect(provider.multi_conf(:ip, should, &p)).to eq("rm:2.2.2.2\nadd:3.3.3.3")
232
245
  end
233
246
  end
247
+
234
248
  context "single props" do
235
249
  {:iptype => /set ip-type/, :autoboot => /set autoboot/, :path => /set zonepath/, :pool => /set pool/, :shares => /add rctl/}.each do |p, v|
236
250
  it "#{p.to_s}: should correctly return conf string" do
237
251
  expect(provider.send(p.to_s + '_conf', 'dummy')).to match(v)
238
252
  end
253
+
239
254
  it "#{p.to_s}: should correctly set property string" do
240
- provider.expects((p.to_s + '_conf').intern).returns('dummy')
241
- provider.expects(:setconfig).with('dummy').returns('dummy2')
255
+ expect(provider).to receive((p.to_s + '_conf').intern).and_return('dummy')
256
+ expect(provider).to receive(:setconfig).with('dummy').and_return('dummy2')
242
257
  expect(provider.send(p.to_s + '=', 'dummy')).to eq('dummy2')
243
258
  end
244
-
245
259
  end
246
260
  end
247
261
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:zpool).provider(:zpool) do
@@ -12,13 +11,13 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
12
11
  let(:provider) { resource.provider }
13
12
 
14
13
  before do
15
- provider.class.stubs(:which).with('zpool').returns(zpool)
14
+ allow(provider.class).to receive(:which).with('zpool').and_return(zpool)
16
15
  end
17
16
 
18
17
  context '#current_pool' do
19
18
  it "should call process_zpool_data with the result of get_pool_data only once" do
20
- provider.stubs(:get_pool_data).returns(["foo", "disk"])
21
- provider.expects(:process_zpool_data).with(["foo", "disk"]).returns("stuff").once
19
+ allow(provider).to receive(:get_pool_data).and_return(["foo", "disk"])
20
+ expect(provider).to receive(:process_zpool_data).with(["foo", "disk"]).and_return("stuff").once
22
21
 
23
22
  provider.current_pool
24
23
  provider.current_pool
@@ -31,7 +30,7 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
31
30
  end
32
31
 
33
32
  it "should list instances" do
34
- provider.class.expects(:zpool).with(:list,'-H').returns File.read(my_fixture('zpool-list.out'))
33
+ expect(provider.class).to receive(:zpool).with(:list,'-H').and_return(File.read(my_fixture('zpool-list.out')))
35
34
  instances = provider.class.instances.map { |p| {:name => p.get(:name), :ensure => p.get(:ensure)} }
36
35
  expect(instances.size).to eq(2)
37
36
  expect(instances[0]).to eq({:name => 'rpool', :ensure => :present})
@@ -41,8 +40,8 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
41
40
 
42
41
  context '#flush' do
43
42
  it "should reload the pool" do
44
- provider.stubs(:get_pool_data)
45
- provider.expects(:process_zpool_data).returns("stuff").times(2)
43
+ allow(provider).to receive(:get_pool_data)
44
+ expect(provider).to receive(:process_zpool_data).and_return("stuff").twice
46
45
  provider.current_pool
47
46
  provider.flush
48
47
  provider.current_pool
@@ -153,7 +152,7 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
153
152
  it "should get the #{field} value from the current_pool hash" do
154
153
  pool_hash = {}
155
154
  pool_hash[field] = 'value'
156
- provider.stubs(:current_pool).returns(pool_hash)
155
+ allow(provider).to receive(:current_pool).and_return(pool_hash)
157
156
 
158
157
  expect(provider.send(field)).to eq('value')
159
158
  end
@@ -161,7 +160,7 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
161
160
 
162
161
  describe "when setting the #{field}" do
163
162
  it "should fail if readonly #{field} values change" do
164
- provider.stubs(:current_pool).returns(Hash.new("currentvalue"))
163
+ allow(provider).to receive(:current_pool).and_return(Hash.new("currentvalue"))
165
164
  expect {
166
165
  provider.send((field.to_s + "=").intern, "shouldvalue")
167
166
  }.to raise_error(Puppet::Error, /can\'t be changed/)
@@ -177,14 +176,14 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
177
176
  end
178
177
 
179
178
  it "should call create with the build_vdevs value" do
180
- provider.expects(:zpool).with(:create, name, 'disk1')
179
+ expect(provider).to receive(:zpool).with(:create, name, 'disk1')
181
180
  provider.create
182
181
  end
183
182
 
184
183
  it "should call create with the 'spares' and 'log' values" do
185
184
  resource[:spare] = ['value1']
186
185
  resource[:log] = ['value2']
187
- provider.expects(:zpool).with(:create, name, 'disk1', 'spare', 'value1', 'log', 'value2')
186
+ expect(provider).to receive(:zpool).with(:create, name, 'disk1', 'spare', 'value1', 'log', 'value2')
188
187
  provider.create
189
188
  end
190
189
  end
@@ -192,13 +191,13 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
192
191
  context "when creating mirrors for a zpool" do
193
192
  it "executes 'create' for a single group of mirrored devices" do
194
193
  resource[:mirror] = ["disk1 disk2"]
195
- provider.expects(:zpool).with(:create, name, 'mirror', 'disk1', 'disk2')
194
+ expect(provider).to receive(:zpool).with(:create, name, 'mirror', 'disk1', 'disk2')
196
195
  provider.create
197
196
  end
198
197
 
199
198
  it "repeats the 'mirror' keyword between groups of mirrored devices" do
200
199
  resource[:mirror] = ["disk1 disk2", "disk3 disk4"]
201
- provider.expects(:zpool).with(:create, name, 'mirror', 'disk1', 'disk2', 'mirror', 'disk3', 'disk4')
200
+ expect(provider).to receive(:zpool).with(:create, name, 'mirror', 'disk1', 'disk2', 'mirror', 'disk3', 'disk4')
202
201
  provider.create
203
202
  end
204
203
  end
@@ -206,20 +205,20 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
206
205
  describe "when creating raidz for a zpool" do
207
206
  it "executes 'create' for a single raidz group" do
208
207
  resource[:raidz] = ["disk1 disk2"]
209
- provider.expects(:zpool).with(:create, name, 'raidz1', 'disk1', 'disk2')
208
+ expect(provider).to receive(:zpool).with(:create, name, 'raidz1', 'disk1', 'disk2')
210
209
  provider.create
211
210
  end
212
211
 
213
212
  it "execute 'create' for a single raidz2 group" do
214
213
  resource[:raidz] = ["disk1 disk2"]
215
214
  resource[:raid_parity] = 'raidz2'
216
- provider.expects(:zpool).with(:create, name, 'raidz2', 'disk1', 'disk2')
215
+ expect(provider).to receive(:zpool).with(:create, name, 'raidz2', 'disk1', 'disk2')
217
216
  provider.create
218
217
  end
219
218
 
220
219
  it "repeats the 'raidz1' keyword between each group of raidz devices" do
221
220
  resource[:raidz] = ["disk1 disk2", "disk3 disk4"]
222
- provider.expects(:zpool).with(:create, name, 'raidz1', 'disk1', 'disk2', 'raidz1', 'disk3', 'disk4')
221
+ expect(provider).to receive(:zpool).with(:create, name, 'raidz1', 'disk1', 'disk2', 'raidz1', 'disk3', 'disk4')
223
222
  provider.create
224
223
  end
225
224
  end
@@ -227,24 +226,24 @@ describe Puppet::Type.type(:zpool).provider(:zpool) do
227
226
 
228
227
  context '#delete' do
229
228
  it "should call zpool with destroy and the pool name" do
230
- provider.expects(:zpool).with(:destroy, name)
229
+ expect(provider).to receive(:zpool).with(:destroy, name)
231
230
  provider.destroy
232
231
  end
233
232
  end
234
233
 
235
234
  context '#exists?' do
236
235
  it "should get the current pool" do
237
- provider.expects(:current_pool).returns({:pool => 'somepool'})
236
+ expect(provider).to receive(:current_pool).and_return({:pool => 'somepool'})
238
237
  provider.exists?
239
238
  end
240
239
 
241
240
  it "should return false if the current_pool is absent" do
242
- provider.expects(:current_pool).returns({:pool => :absent})
241
+ expect(provider).to receive(:current_pool).and_return({:pool => :absent})
243
242
  expect(provider).not_to be_exists
244
243
  end
245
244
 
246
245
  it "should return true if the current_pool has values" do
247
- provider.expects(:current_pool).returns({:pool => name})
246
+ expect(provider).to receive(:current_pool).and_return({:pool => name})
248
247
  expect(provider).to be_exists
249
248
  end
250
249
  end