puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/indirector/yaml'
@@ -10,16 +9,14 @@ describe Puppet::Indirector::Yaml do
10
9
  attr_accessor :name
11
10
  end
12
11
 
13
- before :all do
14
- @indirection = stub 'indirection', :name => :my_yaml, :register_terminus_type => nil
15
- Puppet::Indirector::Indirection.expects(:instance).with(:my_yaml).returns(@indirection)
12
+ before :each do
13
+ @indirection = Puppet::Indirector::Indirection.new(nil, :my_yaml)
14
+
16
15
  module MyYaml; end
17
16
  @store_class = class MyYaml::MyType < Puppet::Indirector::Yaml
18
17
  self
19
18
  end
20
- end
21
19
 
22
- before :each do
23
20
  @store = @store_class.new
24
21
 
25
22
  @subject = TestSubject.new
@@ -27,9 +24,13 @@ describe Puppet::Indirector::Yaml do
27
24
 
28
25
  @dir = tmpdir("yaml_indirector")
29
26
  Puppet[:clientyamldir] = @dir
30
- Puppet.run_mode.stubs(:master?).returns false
27
+ allow(Puppet.run_mode).to receive(:master?).and_return(false)
28
+
29
+ @request = double('request', :key => :me, :instance => @subject)
30
+ end
31
31
 
32
- @request = stub 'request', :key => :me, :instance => @subject
32
+ after(:each) do
33
+ @indirection.delete
33
34
  end
34
35
 
35
36
  let(:serverdir) { File.expand_path("/server/yaml/dir") }
@@ -37,25 +38,25 @@ describe Puppet::Indirector::Yaml do
37
38
 
38
39
  describe "when choosing file location" do
39
40
  it "should use the server_datadir if the run_mode is master" do
40
- Puppet.run_mode.stubs(:master?).returns true
41
+ allow(Puppet.run_mode).to receive(:master?).and_return(true)
41
42
  Puppet[:yamldir] = serverdir
42
43
  expect(@store.path(:me)).to match(/^#{serverdir}/)
43
44
  end
44
45
 
45
46
  it "should use the client yamldir if the run_mode is not master" do
46
- Puppet.run_mode.stubs(:master?).returns false
47
+ allow(Puppet.run_mode).to receive(:master?).and_return(false)
47
48
  Puppet[:clientyamldir] = clientdir
48
49
  expect(@store.path(:me)).to match(/^#{clientdir}/)
49
50
  end
50
51
 
51
52
  it "should use the extension if one is specified" do
52
- Puppet.run_mode.stubs(:master?).returns true
53
+ allow(Puppet.run_mode).to receive(:master?).and_return(true)
53
54
  Puppet[:yamldir] = serverdir
54
55
  expect(@store.path(:me,'.farfignewton')).to match(%r{\.farfignewton$})
55
56
  end
56
57
 
57
58
  it "should assume an extension of .yaml if none is specified" do
58
- Puppet.run_mode.stubs(:master?).returns true
59
+ allow(Puppet.run_mode).to receive(:master?).and_return(true)
59
60
  Puppet[:yamldir] = serverdir
60
61
  expect(@store.path(:me)).to match(%r{\.yaml$})
61
62
  end
@@ -89,7 +90,7 @@ describe Puppet::Indirector::Yaml do
89
90
 
90
91
  describe "when storing objects as YAML" do
91
92
  it "should only store objects that respond to :name" do
92
- @request.stubs(:instance).returns Object.new
93
+ allow(@request).to receive(:instance).and_return(Object.new)
93
94
  expect { @store.save(@request) }.to raise_error(ArgumentError)
94
95
  end
95
96
  end
@@ -117,29 +118,29 @@ describe Puppet::Indirector::Yaml do
117
118
 
118
119
  describe "when searching" do
119
120
  it "should return an array of fact instances with one instance for each file when globbing *" do
120
- @request = stub 'request', :key => "*", :instance => @subject
121
- @one = mock 'one'
122
- @two = mock 'two'
123
- @store.expects(:path).with(@request.key,'').returns :glob
124
- Dir.expects(:glob).with(:glob).returns(%w{one.yaml two.yaml})
125
- YAML.expects(:load_file).with("one.yaml").returns @one;
126
- YAML.expects(:load_file).with("two.yaml").returns @two;
121
+ @request = double('request', :key => "*", :instance => @subject)
122
+ @one = double('one')
123
+ @two = double('two')
124
+ expect(@store).to receive(:path).with(@request.key,'').and_return(:glob)
125
+ expect(Dir).to receive(:glob).with(:glob).and_return(%w{one.yaml two.yaml})
126
+ expect(YAML).to receive(:load_file).with("one.yaml").and_return(@one)
127
+ expect(YAML).to receive(:load_file).with("two.yaml").and_return(@two)
127
128
  expect(@store.search(@request)).to contain_exactly(@one, @two)
128
129
  end
129
130
 
130
131
  it "should return an array containing a single instance of fact when globbing 'one*'" do
131
- @request = stub 'request', :key => "one*", :instance => @subject
132
- @one = mock 'one'
133
- @store.expects(:path).with(@request.key,'').returns :glob
134
- Dir.expects(:glob).with(:glob).returns(%w{one.yaml})
135
- YAML.expects(:load_file).with("one.yaml").returns @one;
132
+ @request = double('request', :key => "one*", :instance => @subject)
133
+ @one = double('one')
134
+ expect(@store).to receive(:path).with(@request.key,'').and_return(:glob)
135
+ expect(Dir).to receive(:glob).with(:glob).and_return(%w{one.yaml})
136
+ expect(YAML).to receive(:load_file).with("one.yaml").and_return(@one)
136
137
  expect(@store.search(@request)).to eq([@one])
137
138
  end
138
139
 
139
140
  it "should return an empty array when the glob doesn't match anything" do
140
- @request = stub 'request', :key => "f*ilglobcanfail*", :instance => @subject
141
- @store.expects(:path).with(@request.key,'').returns :glob
142
- Dir.expects(:glob).with(:glob).returns []
141
+ @request = double('request', :key => "f*ilglobcanfail*", :instance => @subject)
142
+ expect(@store).to receive(:path).with(@request.key,'').and_return(:glob)
143
+ expect(Dir).to receive(:glob).with(:glob).and_return([])
143
144
  expect(@store.search(@request)).to eq([])
144
145
  end
145
146
 
@@ -149,15 +150,15 @@ describe Puppet::Indirector::Yaml do
149
150
  end
150
151
 
151
152
  it "should unlink the right yaml file if it exists" do
152
- Puppet::FileSystem.expects(:exist?).with(path).returns true
153
- Puppet::FileSystem.expects(:unlink).with(path)
153
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
154
+ expect(Puppet::FileSystem).to receive(:unlink).with(path)
154
155
 
155
156
  @store.destroy(@request)
156
157
  end
157
158
 
158
159
  it "should not unlink the yaml file if it does not exists" do
159
- Puppet::FileSystem.expects(:exist?).with(path).returns false
160
- Puppet::FileSystem.expects(:unlink).with(path).never
160
+ expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(false)
161
+ expect(Puppet::FileSystem).not_to receive(:unlink).with(path)
161
162
 
162
163
  @store.destroy(@request)
163
164
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/defaults'
@@ -113,7 +112,7 @@ describe Puppet::Indirector, "when registering an indirection" do
113
112
  end
114
113
 
115
114
  it "should pass any provided options to the indirection during initialization" do
116
- Puppet::Indirector::Indirection.expects(:new).with(@thingie, :first, {:some => :options, :indirected_class => 'Thingie'})
115
+ expect(Puppet::Indirector::Indirection).to receive(:new).with(@thingie, :first, {:some => :options, :indirected_class => 'Thingie'})
117
116
  @indirection = @thingie.indirects :first, :some => :options
118
117
  end
119
118
 
@@ -37,10 +37,12 @@ describe "Puppet::InfoService" do
37
37
  @result = Puppet::InfoService.task_data(env_name, mod_name, task_name)
38
38
  end
39
39
  end
40
+
40
41
  describe 'in the happy case' do
41
42
  it 'returns the right set of keys' do
42
43
  expect(@result.keys.sort).to eq([:files, :metadata_file])
43
44
  end
45
+
44
46
  it 'specifies the metadata_file correctly' do
45
47
  task = @mod.tasks[0]
46
48
  expect(@result[:metadata_file]).to eq(task.metadata_file)
@@ -248,7 +250,7 @@ describe "Puppet::InfoService" do
248
250
  it "avoids parsing file more than once when environments have same feature flag set" do
249
251
  # in this version of puppet, all environments are equal in this respect
250
252
  result = Puppet::Pops::Parser::EvaluatingParser.new.parse_file("#{code_dir}/fum.pp")
251
- Puppet::Pops::Parser::EvaluatingParser.any_instance.expects(:parse_file).with("#{code_dir}/fum.pp").returns(result).once
253
+ expect_any_instance_of(Puppet::Pops::Parser::EvaluatingParser).to receive(:parse_file).with("#{code_dir}/fum.pp").once.and_return(result)
252
254
  files_production = ['fum.pp'].map {|f| File.join(code_dir, f) }
253
255
  files_test = files_production
254
256
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/interface'
4
3
  require 'puppet/network/format_handler'
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/interface'
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/interface'
4
3
 
@@ -138,7 +137,7 @@ describe Puppet::Interface::Action do
138
137
  end
139
138
 
140
139
  it "should call #validate_and_clean on the action when invoked" do
141
- face.get_action(:bar).expects(:validate_and_clean).with({}).returns({})
140
+ expect(face.get_action(:bar)).to receive(:validate_and_clean).with({}).and_return({})
142
141
  face.bar 1, :two, 'three'
143
142
  end
144
143
  end
@@ -397,7 +396,7 @@ describe Puppet::Interface::Action do
397
396
 
398
397
  it "should not invoke a decorator if the options are empty" do
399
398
  face.option("--foo FOO") { before_action { |_,_,_| report :before_action } }
400
- face.expects(:report).never
399
+ expect(face).not_to receive(:report)
401
400
  face.bar
402
401
  end
403
402
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/interface'
4
3
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'tmpdir'
@@ -55,13 +54,13 @@ describe Puppet::Interface::FaceCollection do
55
54
  end
56
55
 
57
56
  it "should attempt to load the face if it isn't found" do
58
- subject.expects(:require).once.with('puppet/face/bar')
59
- subject.expects(:require).once.with('puppet/face/0.0.1/bar')
57
+ expect(subject).to receive(:require).once.with('puppet/face/bar')
58
+ expect(subject).to receive(:require).once.with('puppet/face/0.0.1/bar')
60
59
  subject["bar", '0.0.1']
61
60
  end
62
61
 
63
62
  it "should attempt to load the default face for the specified version :current" do
64
- subject.expects(:require).with('puppet/face/fozzie')
63
+ expect(subject).to receive(:require).with('puppet/face/fozzie')
65
64
  subject['fozzie', :current]
66
65
  end
67
66
 
@@ -71,29 +70,37 @@ describe Puppet::Interface::FaceCollection do
71
70
  end
72
71
 
73
72
  it "should attempt to require the face if it is not registered" do
74
- subject.expects(:require).with do |file|
73
+ expect(subject).to receive(:require) do |file|
75
74
  subject.instance_variable_get("@faces")[:bar][SemanticPuppet::Version.parse('0.0.1')] = true
76
- file == 'puppet/face/bar'
75
+ expect(file).to eq('puppet/face/bar')
77
76
  end
77
+
78
78
  expect(subject["bar", '0.0.1']).to be_truthy
79
79
  end
80
80
 
81
81
  it "should return false if the face is not registered" do
82
- subject.stubs(:require).returns(true)
82
+ allow(subject).to receive(:require).and_return(true)
83
83
  expect(subject["bar", '0.0.1']).to be_falsey
84
84
  end
85
85
 
86
86
  it "should return false if the face file itself is missing" do
87
- subject.stubs(:require).
88
- raises(LoadError, 'no such file to load -- puppet/face/bar').then.
89
- raises(LoadError, 'no such file to load -- puppet/face/0.0.1/bar')
87
+ num_calls = 0
88
+ allow(subject).to receive(:require) do
89
+ num_calls += 1
90
+ if num_calls == 1
91
+ raise LoadError.new('no such file to load -- puppet/face/bar')
92
+ else
93
+ raise LoadError.new('no such file to load -- puppet/face/0.0.1/bar')
94
+ end
95
+ end
96
+
90
97
  expect(subject["bar", '0.0.1']).to be_falsey
91
98
  end
92
99
 
93
100
  it "should register the version loaded by `:current` as `:current`" do
94
- subject.expects(:require).with do |file|
101
+ expect(subject).to receive(:require) do |file|
95
102
  subject.instance_variable_get("@faces")[:huzzah]['2.0.1'] = :huzzah_face
96
- file == 'puppet/face/huzzah'
103
+ expect(file).to eq('puppet/face/huzzah')
97
104
  end
98
105
  subject["huzzah", :current]
99
106
  expect(subject.instance_variable_get("@faces")[:huzzah][:current]).to eq(:huzzah_face)
@@ -61,7 +61,7 @@ describe Puppet::Interface do
61
61
  end
62
62
 
63
63
  it "should load actions" do
64
- subject.any_instance.expects(:load_actions)
64
+ expect_any_instance_of(subject).to receive(:load_actions)
65
65
  subject.define(:face_test_load_actions, '0.0.1')
66
66
  end
67
67
 
@@ -121,8 +121,8 @@ describe Puppet::Interface do
121
121
  end
122
122
 
123
123
  it "should try to require faces that are not known" do
124
- subject::FaceCollection.expects(:load_face).with(:foo, :current)
125
- subject::FaceCollection.expects(:load_face).with(:foo, '0.0.1')
124
+ expect(subject::FaceCollection).to receive(:load_face).with(:foo, :current)
125
+ expect(subject::FaceCollection).to receive(:load_face).with(:foo, '0.0.1')
126
126
  expect { subject[:foo, '0.0.1'] }.to raise_error Puppet::Error
127
127
  end
128
128
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/face'
4
3
 
@@ -13,8 +12,8 @@ describe Puppet::Face[:man, :current] do
13
12
  end
14
13
 
15
14
  it "exits with 0 when generating man documentation for each available application" do
16
- Puppet::Util.stubs(:which).with('ronn').returns(nil)
17
- Puppet::Util.stubs(:which).with(pager).returns(pager)
15
+ allow(Puppet::Util).to receive(:which).with('ronn').and_return(nil)
16
+ allow(Puppet::Util).to receive(:which).with(pager).and_return(pager)
18
17
 
19
18
  Puppet::Application.available_application_names.each do |name|
20
19
  next if %w{man face_base indirection_base}.include? name
@@ -23,7 +22,7 @@ describe Puppet::Face[:man, :current] do
23
22
  app = klass.new(Puppet::Util::CommandLine.new('puppet', ['man', name]))
24
23
 
25
24
  expect do
26
- IO.stubs(:popen).with(pager, 'w:UTF-8').yields($stdout)
25
+ allow(IO).to receive(:popen).with(pager, 'w:UTF-8').and_yield($stdout)
27
26
 
28
27
  expect { app.run }.to exit_with(0)
29
28
  end.to_not have_printed(/undefined method `gsub'/)
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet_spec/files'
4
3
  require 'puppet_spec/modules'
@@ -7,7 +6,7 @@ require 'puppet/module_tool/checksums'
7
6
  describe Puppet::Module do
8
7
  include PuppetSpec::Files
9
8
 
10
- let(:env) { mock("environment") }
9
+ let(:env) { double("environment") }
11
10
  let(:path) { "/path" }
12
11
  let(:name) { "mymod" }
13
12
  let(:mod) { Puppet::Module.new(name, path, env) }
@@ -15,12 +14,12 @@ describe Puppet::Module do
15
14
  before do
16
15
  # This is necessary because of the extra checks we have for the deprecated
17
16
  # 'plugins' directory
18
- Puppet::FileSystem.stubs(:exist?).returns false
17
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(false)
19
18
  end
20
19
 
21
20
  it "should have a class method that returns a named module from a given environment" do
22
21
  env = Puppet::Node::Environment.create(:myenv, [])
23
- env.expects(:module).with(name).returns "yep"
22
+ expect(env).to receive(:module).with(name).and_return("yep")
24
23
  Puppet.override(:environments => Puppet::Environments::Static.new(env)) do
25
24
  expect(Puppet::Module.find(name, "myenv")).to eq("yep")
26
25
  end
@@ -28,7 +27,7 @@ describe Puppet::Module do
28
27
 
29
28
  it "should return nil if asked for a named module that doesn't exist" do
30
29
  env = Puppet::Node::Environment.create(:myenv, [])
31
- env.expects(:module).with(name).returns nil
30
+ expect(env).to receive(:module).with(name).and_return(nil)
32
31
  Puppet.override(:environments => Puppet::Environments::Static.new(env)) do
33
32
  expect(Puppet::Module.find(name, "myenv")).to be_nil
34
33
  end
@@ -136,7 +135,7 @@ describe Puppet::Module do
136
135
 
137
136
  describe "when finding unmet dependencies" do
138
137
  before do
139
- Puppet::FileSystem.unstub(:exist?)
138
+ allow(Puppet::FileSystem).to receive(:exist?).and_call_original
140
139
  @modpath = tmpdir('modpath')
141
140
  Puppet.settings[:modulepath] = @modpath
142
141
  end
@@ -163,7 +162,7 @@ describe Puppet::Module do
163
162
  :environment => env
164
163
  )
165
164
 
166
- env.expects(:module_by_forge_name).with('foo/child').returns(child)
165
+ expect(env).to receive(:module_by_forge_name).with('foo/child').and_return(child)
167
166
 
168
167
  expect(parent.unmet_dependencies).to eq([])
169
168
  end
@@ -181,7 +180,7 @@ describe Puppet::Module do
181
180
  :environment => env
182
181
  )
183
182
 
184
- env.expects(:module_by_forge_name).with('baz/foobar').returns(nil)
183
+ expect(env).to receive(:module_by_forge_name).with('baz/foobar').and_return(nil)
185
184
 
186
185
  expect(mod.unmet_dependencies).to eq([{
187
186
  :reason => :missing,
@@ -205,7 +204,7 @@ describe Puppet::Module do
205
204
  :environment => env
206
205
  )
207
206
 
208
- env.expects(:module_by_forge_name).with('baz/foobar=bar').returns(nil)
207
+ expect(env).to receive(:module_by_forge_name).with('baz/foobar=bar').and_return(nil)
209
208
 
210
209
  expect(mod.unmet_dependencies).to eq([{
211
210
  :reason => :missing,
@@ -222,7 +221,7 @@ describe Puppet::Module do
222
221
  ['test_gte_req', 'test_specific_req', 'foobar'].each do |mod_name|
223
222
  mod_dir = "#{@modpath}/#{mod_name}"
224
223
  metadata_file = "#{mod_dir}/metadata.json"
225
- Puppet::FileSystem.stubs(:exist?).with(metadata_file).returns true
224
+ allow(Puppet::FileSystem).to receive(:exist?).with(metadata_file).and_return(true)
226
225
  end
227
226
  mod = PuppetSpec::Modules.create(
228
227
  'test_gte_req',
@@ -488,33 +487,34 @@ describe Puppet::Module do
488
487
  else
489
488
  dirname = filetype.to_s
490
489
  end
490
+
491
491
  it "should be able to return individual #{filetype}" do
492
492
  module_file = File.join(path, dirname, "my/file")
493
- Puppet::FileSystem.expects(:exist?).with(module_file).returns true
493
+ expect(Puppet::FileSystem).to receive(:exist?).with(module_file).and_return(true)
494
494
  expect(mod.send(filetype.to_s.sub(/s$/, ''), "my/file")).to eq(module_file)
495
495
  end
496
496
 
497
497
  it "should consider #{filetype} to be present if their base directory exists" do
498
498
  module_file = File.join(path, dirname)
499
- Puppet::FileSystem.expects(:exist?).with(module_file).returns true
499
+ expect(Puppet::FileSystem).to receive(:exist?).with(module_file).and_return(true)
500
500
  expect(mod.send(filetype.to_s + "?")).to be_truthy
501
501
  end
502
502
 
503
503
  it "should consider #{filetype} to be absent if their base directory does not exist" do
504
504
  module_file = File.join(path, dirname)
505
- Puppet::FileSystem.expects(:exist?).with(module_file).returns false
505
+ expect(Puppet::FileSystem).to receive(:exist?).with(module_file).and_return(false)
506
506
  expect(mod.send(filetype.to_s + "?")).to be_falsey
507
507
  end
508
508
 
509
509
  it "should return nil if asked to return individual #{filetype} that don't exist" do
510
510
  module_file = File.join(path, dirname, "my/file")
511
- Puppet::FileSystem.expects(:exist?).with(module_file).returns false
511
+ expect(Puppet::FileSystem).to receive(:exist?).with(module_file).and_return(false)
512
512
  expect(mod.send(filetype.to_s.sub(/s$/, ''), "my/file")).to be_nil
513
513
  end
514
514
 
515
515
  it "should return the base directory if asked for a nil path" do
516
516
  base = File.join(path, dirname)
517
- Puppet::FileSystem.expects(:exist?).with(base).returns true
517
+ expect(Puppet::FileSystem).to receive(:exist?).with(base).and_return(true)
518
518
  expect(mod.send(filetype.to_s.sub(/s$/, ''), nil)).to eq(base)
519
519
  end
520
520
  end
@@ -529,7 +529,7 @@ describe Puppet::Module do
529
529
 
530
530
  describe "when finding tasks" do
531
531
  before do
532
- Puppet::FileSystem.unstub(:exist?)
532
+ allow(Puppet::FileSystem).to receive(:exist?).and_call_original
533
533
  @modpath = tmpdir('modpath')
534
534
  Puppet.settings[:modulepath] = @modpath
535
535
  end
@@ -570,29 +570,24 @@ describe Puppet::Module do
570
570
  end
571
571
 
572
572
  describe "does the task finding" do
573
- before :each do
574
- Puppet::FileSystem.unstub(:exist?)
575
- Puppet::Module::Task.unstub(:tasks_in_module)
576
- end
577
-
578
573
  let(:mod_name) { 'tasks_test_lazy' }
579
574
  let(:mod_tasks_dir) { File.join(@modpath, mod_name, 'tasks') }
580
575
 
581
576
  it "after the module is initialized" do
582
- Puppet::FileSystem.expects(:exist?).with(mod_tasks_dir).never
583
- Puppet::Module::Task.expects(:tasks_in_module).never
577
+ expect(Puppet::FileSystem).not_to receive(:exist?).with(mod_tasks_dir)
578
+ expect(Puppet::Module::Task).not_to receive(:tasks_in_module)
584
579
  Puppet::Module.new(mod_name, @modpath, env)
585
580
  end
586
581
 
587
582
  it "when the tasks method is called" do
588
- Puppet::Module::Task.expects(:tasks_in_module)
583
+ expect(Puppet::Module::Task).to receive(:tasks_in_module)
589
584
  mod = PuppetSpec::Modules.create(mod_name, @modpath, {:environment => env,
590
585
  :tasks => [['itascanstaccatotask']]})
591
586
  mod.tasks
592
587
  end
593
588
 
594
589
  it "only once for the lifetime of the module object" do
595
- Dir.expects(:glob).with("#{mod_tasks_dir}/*").once.returns ['allalaskataskattacktactics']
590
+ expect(Dir).to receive(:glob).with("#{mod_tasks_dir}/*").once.and_return(['allalaskataskattacktactics'])
596
591
  mod = PuppetSpec::Modules.create(mod_name, @modpath, {:environment => env,
597
592
  :tasks => []})
598
593
  mod.tasks
@@ -604,46 +599,46 @@ end
604
599
 
605
600
  describe Puppet::Module, "when finding matching manifests" do
606
601
  before do
607
- @mod = Puppet::Module.new("mymod", "/a", mock("environment"))
602
+ @mod = Puppet::Module.new("mymod", "/a", double("environment"))
608
603
  @pq_glob_with_extension = "yay/*.xx"
609
604
  @fq_glob_with_extension = "/a/manifests/#{@pq_glob_with_extension}"
610
605
  end
611
606
 
612
607
  it "should return all manifests matching the glob pattern" do
613
- Dir.expects(:glob).with(@fq_glob_with_extension).returns(%w{foo bar})
614
- FileTest.stubs(:directory?).returns false
608
+ expect(Dir).to receive(:glob).with(@fq_glob_with_extension).and_return(%w{foo bar})
609
+ allow(FileTest).to receive(:directory?).and_return(false)
615
610
 
616
611
  expect(@mod.match_manifests(@pq_glob_with_extension)).to eq(%w{foo bar})
617
612
  end
618
613
 
619
614
  it "should not return directories" do
620
- Dir.expects(:glob).with(@fq_glob_with_extension).returns(%w{foo bar})
615
+ expect(Dir).to receive(:glob).with(@fq_glob_with_extension).and_return(%w{foo bar})
621
616
 
622
- FileTest.expects(:directory?).with("foo").returns false
623
- FileTest.expects(:directory?).with("bar").returns true
617
+ expect(FileTest).to receive(:directory?).with("foo").and_return(false)
618
+ expect(FileTest).to receive(:directory?).with("bar").and_return(true)
624
619
  expect(@mod.match_manifests(@pq_glob_with_extension)).to eq(%w{foo})
625
620
  end
626
621
 
627
622
  it "should default to the 'init' file if no glob pattern is specified" do
628
- Puppet::FileSystem.expects(:exist?).with("/a/manifests/init.pp").returns(true)
623
+ expect(Puppet::FileSystem).to receive(:exist?).with("/a/manifests/init.pp").and_return(true)
629
624
 
630
625
  expect(@mod.match_manifests(nil)).to eq(%w{/a/manifests/init.pp})
631
626
  end
632
627
 
633
628
  it "should return all manifests matching the glob pattern in all existing paths" do
634
- Dir.expects(:glob).with(@fq_glob_with_extension).returns(%w{a b})
629
+ expect(Dir).to receive(:glob).with(@fq_glob_with_extension).and_return(%w{a b})
635
630
 
636
631
  expect(@mod.match_manifests(@pq_glob_with_extension)).to eq(%w{a b})
637
632
  end
638
633
 
639
634
  it "should match the glob pattern plus '.pp' if no extension is specified" do
640
- Dir.expects(:glob).with("/a/manifests/yay/foo.pp").returns(%w{yay})
635
+ expect(Dir).to receive(:glob).with("/a/manifests/yay/foo.pp").and_return(%w{yay})
641
636
 
642
637
  expect(@mod.match_manifests("yay/foo")).to eq(%w{yay})
643
638
  end
644
639
 
645
640
  it "should return an empty array if no manifests matched" do
646
- Dir.expects(:glob).with(@fq_glob_with_extension).returns([])
641
+ expect(Dir).to receive(:glob).with(@fq_glob_with_extension).and_return([])
647
642
 
648
643
  expect(@mod.match_manifests(@pq_glob_with_extension)).to eq([])
649
644
  end
@@ -675,7 +670,7 @@ describe Puppet::Module do
675
670
  end
676
671
 
677
672
  it "should cache the license file" do
678
- mymod.expects(:path).once.returns nil
673
+ expect(mymod).to receive(:path).once.and_return(nil)
679
674
  mymod.license_file
680
675
  mymod.license_file
681
676
  end
@@ -685,24 +680,24 @@ describe Puppet::Module do
685
680
  end
686
681
 
687
682
  it "should not have metadata if it has a metadata file and its data is valid but empty json hash" do
688
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns "{}"
683
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return("{}")
689
684
 
690
685
  expect(mymod).not_to be_has_metadata
691
686
  end
692
687
 
693
688
  it "should not have metadata if it has a metadata file and its data is empty" do
694
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns ""
689
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return("")
695
690
 
696
691
  expect(mymod).not_to be_has_metadata
697
692
  end
698
693
 
699
694
  it "should not have metadata if has a metadata file and its data is invalid" do
700
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns "This is some invalid json.\n"
695
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return("This is some invalid json.\n")
701
696
  expect(mymod).not_to be_has_metadata
702
697
  end
703
698
 
704
699
  it "should know if it is missing a metadata file" do
705
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).raises(Errno::ENOENT)
700
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_raise(Errno::ENOENT)
706
701
 
707
702
  expect(mymod).not_to be_has_metadata
708
703
  end
@@ -712,13 +707,13 @@ describe Puppet::Module do
712
707
  end
713
708
 
714
709
  it "should parse its metadata file on initialization if it is present" do
715
- Puppet::Module.any_instance.expects(:load_metadata)
710
+ expect_any_instance_of(Puppet::Module).to receive(:load_metadata)
716
711
 
717
- Puppet::Module.new("yay", "/path", mock("env"))
712
+ Puppet::Module.new("yay", "/path", double("env"))
718
713
  end
719
714
 
720
715
  it "should tolerate failure to parse" do
721
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns(my_fixture('trailing-comma.json'))
716
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return(my_fixture('trailing-comma.json'))
722
717
 
723
718
  expect(mymod.has_metadata?).to be_falsey
724
719
  end
@@ -729,7 +724,7 @@ describe Puppet::Module do
729
724
  end
730
725
 
731
726
  it "should warn about a failure to parse" do
732
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns(my_fixture('trailing-comma.json'))
727
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return(my_fixture('trailing-comma.json'))
733
728
 
734
729
  expect(mymod.has_metadata?).to be_falsey
735
730
  expect(@logs).to have_matching_log(/mymod has an invalid and unparsable metadata\.json file/)
@@ -742,7 +737,7 @@ describe Puppet::Module do
742
737
  end
743
738
 
744
739
  it "should not warn about a failure to parse" do
745
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns(my_fixture('trailing-comma.json'))
740
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return(my_fixture('trailing-comma.json'))
746
741
 
747
742
  expect(mymod.has_metadata?).to be_falsey
748
743
  expect(@logs).to_not have_matching_log(/mymod has an invalid and unparsable metadata\.json file.*/)
@@ -750,7 +745,7 @@ describe Puppet::Module do
750
745
 
751
746
  it "should log debug output about a failure to parse when --debug is on" do
752
747
  Puppet[:log_level] = :debug
753
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns(my_fixture('trailing-comma.json'))
748
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return(my_fixture('trailing-comma.json'))
754
749
 
755
750
  expect(mymod.has_metadata?).to be_falsey
756
751
  expect(@logs).to have_matching_log(/mymod has an invalid and unparsable metadata\.json file.*/)
@@ -763,7 +758,7 @@ describe Puppet::Module do
763
758
  end
764
759
 
765
760
  it "should fail on a failure to parse" do
766
- File.stubs(:read).with(mymod_metadata, {:encoding => 'utf-8'}).returns(my_fixture('trailing-comma.json'))
761
+ allow(File).to receive(:read).with(mymod_metadata, {:encoding => 'utf-8'}).and_return(my_fixture('trailing-comma.json'))
767
762
 
768
763
  expect do
769
764
  expect(mymod.has_metadata?).to be_falsey
@@ -772,8 +767,8 @@ describe Puppet::Module do
772
767
  end
773
768
 
774
769
  def a_module_with_metadata(data)
775
- File.stubs(:read).with("/path/metadata.json", {:encoding => 'utf-8'}).returns data.to_json
776
- Puppet::Module.new("foo", "/path", mock("env"))
770
+ allow(File).to receive(:read).with("/path/metadata.json", {:encoding => 'utf-8'}).and_return(data.to_json)
771
+ Puppet::Module.new("foo", "/path", double("env"))
777
772
  end
778
773
 
779
774
  describe "when loading the metadata file" do
@@ -819,8 +814,8 @@ describe Puppet::Module do
819
814
  EOF
820
815
  end
821
816
 
822
- Puppet::Module.any_instance.stubs(:metadata_file).returns metadata_json
823
- mod = Puppet::Module.new('foo', '/path', mock('env'))
817
+ allow_any_instance_of(Puppet::Module).to receive(:metadata_file).and_return(metadata_json)
818
+ mod = Puppet::Module.new('foo', '/path', double('env'))
824
819
 
825
820
  mod.load_metadata
826
821
  expect(mod.author).to eq(rune_utf8)