puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/agent'
@@ -13,28 +12,29 @@ describe Puppet::Application::Agent do
13
12
  @puppetd = Puppet::Application[:agent]
14
13
 
15
14
  @daemon = Puppet::Daemon.new(nil)
16
- @daemon.stubs(:daemonize)
17
- @daemon.stubs(:start)
18
- @daemon.stubs(:stop)
19
- Puppet::Daemon.stubs(:new).returns(@daemon)
15
+ allow(@daemon).to receive(:daemonize)
16
+ allow(@daemon).to receive(:start)
17
+ allow(@daemon).to receive(:stop)
18
+ allow(Puppet::Daemon).to receive(:new).and_return(@daemon)
20
19
  Puppet[:daemonize] = false
21
20
 
22
- @agent = stub_everything 'agent'
23
- Puppet::Agent.stubs(:new).returns(@agent)
21
+ @agent = double('agent')
22
+ allow(Puppet::Agent).to receive(:new).and_return(@agent)
24
23
 
25
24
  @puppetd.preinit
26
- Puppet::Util::Log.stubs(:newdestination)
25
+ allow(Puppet::Util::Log).to receive(:newdestination)
27
26
 
28
- @ssl_host = stub_everything 'ssl host'
29
- Puppet::SSL::Host.stubs(:new).returns(@ssl_host)
27
+ @ssl_host = double('ssl host')
28
+ allow(@ssl_host).to receive(:wait_for_cert)
29
+ allow(Puppet::SSL::Host).to receive(:new).and_return(@ssl_host)
30
30
 
31
- Puppet::Node.indirection.stubs(:terminus_class=)
32
- Puppet::Node.indirection.stubs(:cache_class=)
33
- Puppet::Node::Facts.indirection.stubs(:terminus_class=)
31
+ allow(Puppet::Node.indirection).to receive(:terminus_class=)
32
+ allow(Puppet::Node.indirection).to receive(:cache_class=)
33
+ allow(Puppet::Node::Facts.indirection).to receive(:terminus_class=)
34
34
 
35
- $stderr.expects(:puts).never
35
+ expect($stderr).not_to receive(:puts)
36
36
 
37
- Puppet.settings.stubs(:use)
37
+ allow(Puppet.settings).to receive(:use)
38
38
  end
39
39
 
40
40
  it "should operate in agent run_mode" do
@@ -59,7 +59,7 @@ describe Puppet::Application::Agent do
59
59
 
60
60
  describe "in preinit" do
61
61
  it "should catch INT" do
62
- Signal.expects(:trap).with { |arg,block| arg == :INT }
62
+ expect(Signal).to receive(:trap).with(:INT)
63
63
 
64
64
  @puppetd.preinit
65
65
  end
@@ -97,7 +97,7 @@ describe Puppet::Application::Agent do
97
97
 
98
98
  describe "when handling options" do
99
99
  before do
100
- @puppetd.command_line.stubs(:args).returns([])
100
+ allow(@puppetd.command_line).to receive(:args).and_return([])
101
101
  end
102
102
 
103
103
  [:enable, :debug, :fqdn, :test, :verbose, :digest].each do |option|
@@ -127,39 +127,39 @@ describe Puppet::Application::Agent do
127
127
  end
128
128
 
129
129
  it "should set waitforcert to 0 with --onetime and if --waitforcert wasn't given" do
130
- @agent.stubs(:run).returns(2)
130
+ allow(@agent).to receive(:run).and_return(2)
131
131
  Puppet[:onetime] = true
132
132
 
133
- @ssl_host.expects(:wait_for_cert).with(0)
133
+ expect(@ssl_host).to receive(:wait_for_cert).with(0)
134
134
 
135
135
  expect { execute_agent }.to exit_with 0
136
136
  end
137
137
 
138
138
  it "should use supplied waitforcert when --onetime is specified" do
139
- @agent.stubs(:run).returns(2)
139
+ allow(@agent).to receive(:run).and_return(2)
140
140
  Puppet[:onetime] = true
141
141
  @puppetd.handle_waitforcert(60)
142
142
 
143
- @ssl_host.expects(:wait_for_cert).with(60)
143
+ expect(@ssl_host).to receive(:wait_for_cert).with(60)
144
144
 
145
145
  expect { execute_agent }.to exit_with 0
146
146
  end
147
147
 
148
148
  it "should use a default value for waitforcert when --onetime and --waitforcert are not specified" do
149
- @ssl_host.expects(:wait_for_cert).with(120)
149
+ expect(@ssl_host).to receive(:wait_for_cert).with(120)
150
150
 
151
151
  execute_agent
152
152
  end
153
153
 
154
154
  it "should use the waitforcert setting when checking for a signed certificate" do
155
155
  Puppet[:waitforcert] = 10
156
- @ssl_host.expects(:wait_for_cert).with(10)
156
+ expect(@ssl_host).to receive(:wait_for_cert).with(10)
157
157
 
158
158
  execute_agent
159
159
  end
160
160
 
161
161
  it "should set the log destination with --logdest" do
162
- Puppet::Log.expects(:newdestination).with("console")
162
+ expect(Puppet::Log).to receive(:newdestination).with("console")
163
163
 
164
164
  @puppetd.handle_logdest("console")
165
165
  end
@@ -171,9 +171,9 @@ describe Puppet::Application::Agent do
171
171
  end
172
172
 
173
173
  it "should parse the log destination from the command line" do
174
- @puppetd.command_line.stubs(:args).returns(%w{--logdest /my/file})
174
+ allow(@puppetd.command_line).to receive(:args).and_return(%w{--logdest /my/file})
175
175
 
176
- Puppet::Util::Log.expects(:newdestination).with("/my/file")
176
+ expect(Puppet::Util::Log).to receive(:newdestination).with("/my/file")
177
177
 
178
178
  @puppetd.parse_options
179
179
  end
@@ -187,25 +187,25 @@ describe Puppet::Application::Agent do
187
187
 
188
188
  describe "during setup" do
189
189
  before :each do
190
- Puppet.stubs(:info)
190
+ allow(Puppet).to receive(:info)
191
191
  Puppet[:libdir] = "/dev/null/lib"
192
- Puppet::Transaction::Report.indirection.stubs(:terminus_class=)
193
- Puppet::Transaction::Report.indirection.stubs(:cache_class=)
194
- Puppet::Resource::Catalog.indirection.stubs(:terminus_class=)
195
- Puppet::Resource::Catalog.indirection.stubs(:cache_class=)
196
- Puppet::Node::Facts.indirection.stubs(:terminus_class=)
197
- Puppet.stubs(:settraps)
192
+ allow(Puppet::Transaction::Report.indirection).to receive(:terminus_class=)
193
+ allow(Puppet::Transaction::Report.indirection).to receive(:cache_class=)
194
+ allow(Puppet::Resource::Catalog.indirection).to receive(:terminus_class=)
195
+ allow(Puppet::Resource::Catalog.indirection).to receive(:cache_class=)
196
+ allow(Puppet::Node::Facts.indirection).to receive(:terminus_class=)
197
+ allow(Puppet).to receive(:settraps)
198
198
  end
199
199
 
200
200
  it "should not run with extra arguments" do
201
- @puppetd.command_line.stubs(:args).returns(%w{disable})
201
+ allow(@puppetd.command_line).to receive(:args).and_return(%w{disable})
202
202
  expect{@puppetd.setup}.to raise_error ArgumentError, /does not take parameters/
203
203
  end
204
204
 
205
205
  describe "with --test" do
206
206
  it "should call setup_test" do
207
207
  @puppetd.options[:test] = true
208
- @puppetd.expects(:setup_test)
208
+ expect(@puppetd).to receive(:setup_test)
209
209
 
210
210
  @puppetd.setup
211
211
  end
@@ -228,13 +228,13 @@ describe Puppet::Application::Agent do
228
228
  end
229
229
 
230
230
  it "should call setup_logs" do
231
- @puppetd.expects(:setup_logs)
231
+ expect(@puppetd).to receive(:setup_logs)
232
232
  @puppetd.setup
233
233
  end
234
234
 
235
235
  describe "when setting up logs" do
236
236
  before :each do
237
- Puppet::Util::Log.stubs(:newdestination)
237
+ allow(Puppet::Util::Log).to receive(:newdestination)
238
238
  end
239
239
 
240
240
  it "should set log level to debug if --debug was passed" do
@@ -253,8 +253,8 @@ describe Puppet::Application::Agent do
253
253
  it "should set console as the log destination with level #{level}" do
254
254
  @puppetd.options[level] = true
255
255
 
256
- Puppet::Util::Log.expects(:newdestination).at_least_once
257
- Puppet::Util::Log.expects(:newdestination).with(:console).once
256
+ allow(Puppet::Util::Log).to receive(:newdestination)
257
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:console).exactly(:once)
258
258
 
259
259
  @puppetd.setup_logs
260
260
  end
@@ -263,16 +263,15 @@ describe Puppet::Application::Agent do
263
263
  it "should set a default log destination if no --logdest" do
264
264
  @puppetd.options[:setdest] = false
265
265
 
266
- Puppet::Util::Log.expects(:setup_default)
266
+ expect(Puppet::Util::Log).to receive(:setup_default)
267
267
 
268
268
  @puppetd.setup_logs
269
269
  end
270
-
271
270
  end
272
271
 
273
272
  it "should print puppet config if asked to in Puppet config" do
274
273
  Puppet[:configprint] = "pluginsync"
275
- Puppet.settings.expects(:print_configs).returns true
274
+ expect(Puppet.settings).to receive(:print_configs).and_return(true)
276
275
  expect { execute_agent }.to exit_with 0
277
276
  end
278
277
 
@@ -280,38 +279,37 @@ describe Puppet::Application::Agent do
280
279
  path = make_absolute('/my/path')
281
280
  Puppet[:modulepath] = path
282
281
  Puppet[:configprint] = "modulepath"
283
- Puppet::Settings.any_instance.expects(:puts).with(path)
282
+ expect_any_instance_of(Puppet::Settings).to receive(:puts).with(path)
284
283
  expect { execute_agent }.to exit_with 0
285
284
  end
286
285
 
287
286
  it "should use :main, :puppetd, and :ssl" do
288
- Puppet.settings.unstub(:use)
289
- Puppet.settings.expects(:use).with(:main, :agent, :ssl)
287
+ expect(Puppet.settings).to receive(:use).with(:main, :agent, :ssl)
290
288
 
291
289
  @puppetd.setup
292
290
  end
293
291
 
294
292
  it "should install a remote ca location" do
295
- Puppet::SSL::Host.expects(:ca_location=).with(:remote)
293
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:remote)
296
294
 
297
295
  @puppetd.setup
298
296
  end
299
297
 
300
298
  it "should install a none ca location in fingerprint mode" do
301
299
  @puppetd.options[:fingerprint] = true
302
- Puppet::SSL::Host.expects(:ca_location=).with(:none)
300
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:none)
303
301
 
304
302
  @puppetd.setup
305
303
  end
306
304
 
307
305
  it "should tell the report handler to use REST" do
308
- Puppet::Transaction::Report.indirection.expects(:terminus_class=).with(:rest)
306
+ expect(Puppet::Transaction::Report.indirection).to receive(:terminus_class=).with(:rest)
309
307
 
310
308
  @puppetd.setup
311
309
  end
312
310
 
313
311
  it "should tell the report handler to cache locally as yaml" do
314
- Puppet::Transaction::Report.indirection.expects(:cache_class=).with(:yaml)
312
+ expect(Puppet::Transaction::Report.indirection).to receive(:cache_class=).with(:yaml)
315
313
 
316
314
  @puppetd.setup
317
315
  end
@@ -327,7 +325,7 @@ describe Puppet::Application::Agent do
327
325
  end
328
326
 
329
327
  it "has an application default :catalog_cache_terminus setting of 'json'" do
330
- Puppet::Resource::Catalog.indirection.expects(:cache_class=).with(:json)
328
+ expect(Puppet::Resource::Catalog.indirection).to receive(:cache_class=).with(:json)
331
329
 
332
330
  @puppetd.initialize_app_defaults
333
331
  @puppetd.setup
@@ -335,7 +333,7 @@ describe Puppet::Application::Agent do
335
333
 
336
334
  it "should tell the catalog cache class based on the :catalog_cache_terminus setting" do
337
335
  Puppet[:catalog_cache_terminus] = "yaml"
338
- Puppet::Resource::Catalog.indirection.expects(:cache_class=).with(:yaml)
336
+ expect(Puppet::Resource::Catalog.indirection).to receive(:cache_class=).with(:yaml)
339
337
 
340
338
  @puppetd.initialize_app_defaults
341
339
  @puppetd.setup
@@ -343,8 +341,7 @@ describe Puppet::Application::Agent do
343
341
 
344
342
  it "should not set catalog cache class if :catalog_cache_terminus is explicitly nil" do
345
343
  Puppet[:catalog_cache_terminus] = nil
346
- Puppet::Resource::Catalog.indirection.unstub(:cache_class=)
347
- Puppet::Resource::Catalog.indirection.expects(:cache_class=).never
344
+ expect(Puppet::Resource::Catalog.indirection).not_to receive(:cache_class=)
348
345
 
349
346
  @puppetd.initialize_app_defaults
350
347
  @puppetd.setup
@@ -356,7 +353,7 @@ describe Puppet::Application::Agent do
356
353
  end
357
354
 
358
355
  it "should create an agent" do
359
- Puppet::Agent.stubs(:new).with(Puppet::Configurer)
356
+ allow(Puppet::Agent).to receive(:new).with(Puppet::Configurer)
360
357
 
361
358
  @puppetd.setup
362
359
  end
@@ -364,7 +361,7 @@ describe Puppet::Application::Agent do
364
361
  [:enable, :disable].each do |action|
365
362
  it "should delegate to enable_disable_client if we #{action} the agent" do
366
363
  @puppetd.options[action] = true
367
- @puppetd.expects(:enable_disable_client).with(@agent)
364
+ expect(@puppetd).to receive(:enable_disable_client).with(@agent)
368
365
 
369
366
  @puppetd.setup
370
367
  end
@@ -374,7 +371,7 @@ describe Puppet::Application::Agent do
374
371
  [:enable, :disable].each do |action|
375
372
  it "should call client.#{action}" do
376
373
  @puppetd.options[action] = true
377
- @agent.expects(action)
374
+ expect(@agent).to receive(action)
378
375
  expect { execute_agent }.to exit_with 0
379
376
  end
380
377
  end
@@ -382,7 +379,7 @@ describe Puppet::Application::Agent do
382
379
  it "should pass the disable message when disabling" do
383
380
  @puppetd.options[:disable] = true
384
381
  @puppetd.options[:disable_message] = "message"
385
- @agent.expects(:disable).with("message")
382
+ expect(@agent).to receive(:disable).with("message")
386
383
 
387
384
  expect { execute_agent }.to exit_with 0
388
385
  end
@@ -390,7 +387,7 @@ describe Puppet::Application::Agent do
390
387
  it "should pass the default disable message when disabling without a message" do
391
388
  @puppetd.options[:disable] = true
392
389
  @puppetd.options[:disable_message] = nil
393
- @agent.expects(:disable).with("reason not specified")
390
+ expect(@agent).to receive(:disable).with("reason not specified")
394
391
 
395
392
  expect { execute_agent }.to exit_with 0
396
393
  end
@@ -405,17 +402,17 @@ describe Puppet::Application::Agent do
405
402
  end
406
403
 
407
404
  it "should daemonize if needed" do
408
- Puppet.features.stubs(:microsoft_windows?).returns false
405
+ allow(Puppet.features).to receive(:microsoft_windows?).and_return(false)
409
406
  Puppet[:daemonize] = true
410
407
 
411
- @daemon.expects(:daemonize)
408
+ expect(@daemon).to receive(:daemonize)
412
409
 
413
410
  execute_agent
414
411
  end
415
412
 
416
413
  it "should wait for a certificate" do
417
414
  @puppetd.options[:waitforcert] = 123
418
- @ssl_host.expects(:wait_for_cert).with(123)
415
+ expect(@ssl_host).to receive(:wait_for_cert).with(123)
419
416
 
420
417
  execute_agent
421
418
  end
@@ -425,12 +422,12 @@ describe Puppet::Application::Agent do
425
422
  @puppetd.options[:waitforcert] = 123
426
423
  @puppetd.options[:digest] = 'MD5'
427
424
 
428
- certificate = mock 'certificate'
429
- certificate.stubs(:digest).with('MD5').returns('ABCDE')
430
- @ssl_host.stubs(:certificate).returns(certificate)
425
+ certificate = double('certificate')
426
+ allow(certificate).to receive(:digest).with('MD5').and_return('ABCDE')
427
+ allow(@ssl_host).to receive(:certificate).and_return(certificate)
431
428
 
432
- @ssl_host.expects(:wait_for_cert).never
433
- @puppetd.expects(:puts).with('ABCDE')
429
+ expect(@ssl_host).not_to receive(:wait_for_cert)
430
+ expect(@puppetd).to receive(:puts).with('ABCDE')
434
431
 
435
432
  execute_agent
436
433
  end
@@ -441,36 +438,35 @@ describe Puppet::Application::Agent do
441
438
  end
442
439
 
443
440
  it "should not setup as an agent" do
444
- @puppetd.expects(:setup_agent).never
441
+ expect(@puppetd).not_to receive(:setup_agent)
445
442
  @puppetd.setup
446
443
  end
447
444
 
448
445
  it "should not create an agent" do
449
- Puppet::Agent.stubs(:new).with(Puppet::Configurer).never
446
+ expect(Puppet::Agent).not_to receive(:new).with(Puppet::Configurer)
450
447
  @puppetd.setup
451
448
  end
452
449
 
453
450
  it "should not daemonize" do
454
- @daemon.expects(:daemonize).never
451
+ expect(@daemon).not_to receive(:daemonize)
455
452
  @puppetd.setup
456
453
  end
457
454
  end
458
455
 
459
456
  describe "when configuring agent for catalog run" do
460
457
  it "should set should_fork as true when running normally" do
461
- Puppet::Agent.expects(:new).with(anything, true)
458
+ expect(Puppet::Agent).to receive(:new).with(anything, true)
462
459
  @puppetd.setup
463
460
  end
464
461
 
465
462
  it "should not set should_fork as false for --onetime" do
466
463
  Puppet[:onetime] = true
467
- Puppet::Agent.expects(:new).with(anything, false)
464
+ expect(Puppet::Agent).to receive(:new).with(anything, false)
468
465
  @puppetd.setup
469
466
  end
470
467
  end
471
468
  end
472
469
 
473
-
474
470
  describe "when running" do
475
471
  before :each do
476
472
  @puppetd.options[:fingerprint] = false
@@ -479,7 +475,7 @@ describe Puppet::Application::Agent do
479
475
  it "should dispatch to fingerprint if --fingerprint is used" do
480
476
  @puppetd.options[:fingerprint] = true
481
477
 
482
- @puppetd.stubs(:fingerprint)
478
+ allow(@puppetd).to receive(:fingerprint)
483
479
 
484
480
  execute_agent
485
481
  end
@@ -487,7 +483,7 @@ describe Puppet::Application::Agent do
487
483
  it "should dispatch to onetime if --onetime is used" do
488
484
  @puppetd.options[:onetime] = true
489
485
 
490
- @puppetd.stubs(:onetime)
486
+ allow(@puppetd).to receive(:onetime)
491
487
 
492
488
  execute_agent
493
489
  end
@@ -495,41 +491,40 @@ describe Puppet::Application::Agent do
495
491
  it "should dispatch to main if --onetime and --fingerprint are not used" do
496
492
  @puppetd.options[:onetime] = false
497
493
 
498
- @puppetd.stubs(:main)
494
+ allow(@puppetd).to receive(:main)
499
495
 
500
496
  execute_agent
501
497
  end
502
498
 
503
499
  describe "with --onetime" do
504
-
505
500
  before :each do
506
- @agent.stubs(:run).returns(:report)
501
+ allow(@agent).to receive(:run).and_return(:report)
507
502
  Puppet[:onetime] = true
508
503
  @puppetd.options[:client] = :client
509
504
  @puppetd.options[:detailed_exitcodes] = false
510
505
  end
511
506
 
512
507
  it "should setup traps" do
513
- @daemon.expects(:set_signal_traps)
508
+ expect(@daemon).to receive(:set_signal_traps)
514
509
 
515
510
  expect { execute_agent }.to exit_with 0
516
511
  end
517
512
 
518
513
  it "should let the agent run" do
519
- @agent.expects(:run).returns(:report)
514
+ expect(@agent).to receive(:run).and_return(:report)
520
515
 
521
516
  expect { execute_agent }.to exit_with 0
522
517
  end
523
518
 
524
519
  it "should run the agent with the supplied job_id" do
525
520
  @puppetd.options[:job_id] = 'special id'
526
- @agent.expects(:run).with(:job_id => 'special id').returns(:report)
521
+ expect(@agent).to receive(:run).with(:job_id => 'special id').and_return(:report)
527
522
 
528
523
  expect { execute_agent }.to exit_with 0
529
524
  end
530
525
 
531
526
  it "should stop the daemon" do
532
- @daemon.expects(:stop).with(:exit => false)
527
+ expect(@daemon).to receive(:stop).with(:exit => false)
533
528
 
534
529
  expect { execute_agent }.to exit_with 0
535
530
  end
@@ -541,14 +536,14 @@ describe Puppet::Application::Agent do
541
536
 
542
537
  it "should exit with agent computed exit status" do
543
538
  Puppet[:noop] = false
544
- @agent.stubs(:run).returns(666)
539
+ allow(@agent).to receive(:run).and_return(666)
545
540
 
546
541
  expect { execute_agent }.to exit_with 666
547
542
  end
548
543
 
549
544
  it "should exit with the agent's exit status, even if --noop is set." do
550
545
  Puppet[:noop] = true
551
- @agent.stubs(:run).returns(666)
546
+ allow(@agent).to receive(:run).and_return(666)
552
547
 
553
548
  expect { execute_agent }.to exit_with 666
554
549
  end
@@ -557,26 +552,26 @@ describe Puppet::Application::Agent do
557
552
 
558
553
  describe "with --fingerprint" do
559
554
  before :each do
560
- @cert = mock 'cert'
555
+ @cert = double('cert')
561
556
  @puppetd.options[:fingerprint] = true
562
557
  @puppetd.options[:digest] = :MD5
563
558
  end
564
559
 
565
560
  it "should fingerprint the certificate if it exists" do
566
- @ssl_host.stubs(:certificate).returns(@cert)
567
- @cert.stubs(:digest).with('MD5').returns "fingerprint"
561
+ allow(@ssl_host).to receive(:certificate).and_return(@cert)
562
+ allow(@cert).to receive(:digest).with('MD5').and_return("fingerprint")
568
563
 
569
- @puppetd.expects(:puts).with "fingerprint"
564
+ expect(@puppetd).to receive(:puts).with("fingerprint")
570
565
 
571
566
  @puppetd.fingerprint
572
567
  end
573
568
 
574
569
  it "should fingerprint the certificate request if no certificate have been signed" do
575
- @ssl_host.stubs(:certificate).returns(nil)
576
- @ssl_host.stubs(:certificate_request).returns(@cert)
577
- @cert.stubs(:digest).with('MD5').returns "fingerprint"
570
+ allow(@ssl_host).to receive(:certificate).and_return(nil)
571
+ allow(@ssl_host).to receive(:certificate_request).and_return(@cert)
572
+ allow(@cert).to receive(:digest).with('MD5').and_return("fingerprint")
578
573
 
579
- @puppetd.expects(:puts).with "fingerprint"
574
+ expect(@puppetd).to receive(:puts).with("fingerprint")
580
575
 
581
576
  @puppetd.fingerprint
582
577
  end
@@ -584,11 +579,11 @@ describe Puppet::Application::Agent do
584
579
 
585
580
  describe "without --onetime and --fingerprint" do
586
581
  before :each do
587
- Puppet.stubs(:notice)
582
+ allow(Puppet).to receive(:notice)
588
583
  end
589
584
 
590
585
  it "should start our daemon" do
591
- @daemon.expects(:start)
586
+ expect(@daemon).to receive(:start)
592
587
 
593
588
  execute_agent
594
589
  end