puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/ssl/certificate'
@@ -15,23 +14,23 @@ describe Puppet::SSL::Certificate do
15
14
 
16
15
  describe "when creating new instances" do
17
16
  it "should fail if given an object that is not an instance of the wrapped class" do
18
- obj = stub 'obj', :is_a? => false
17
+ obj = double('obj', :is_a? => false)
19
18
  expect { @class.from_instance(obj) }.to raise_error(ArgumentError)
20
19
  end
21
20
 
22
21
  it "should fail if a name is not supplied and can't be determined from the object" do
23
- obj = stub 'obj', :is_a? => true
22
+ obj = double('obj', :is_a? => true)
24
23
  expect { @class.from_instance(obj) }.to raise_error(ArgumentError)
25
24
  end
26
25
 
27
26
  it "should determine the name from the object if it has a subject" do
28
- obj = stub 'obj', :is_a? => true, :subject => '/CN=foo'
27
+ obj = double('obj', :is_a? => true, :subject => '/CN=foo')
29
28
 
30
- inst = stub 'base'
31
- inst.expects(:content=).with(obj)
29
+ inst = double('base')
30
+ expect(inst).to receive(:content=).with(obj)
32
31
 
33
- @class.expects(:new).with('foo').returns inst
34
- @class.expects(:name_from_subject).with('/CN=foo').returns('foo')
32
+ expect(@class).to receive(:new).with('foo').and_return(inst)
33
+ expect(@class).to receive(:name_from_subject).with('/CN=foo').and_return('foo')
35
34
 
36
35
  expect(@class.from_instance(obj)).to eq(inst)
37
36
  end
@@ -39,8 +38,8 @@ describe Puppet::SSL::Certificate do
39
38
 
40
39
  describe "when determining a name from a certificate subject" do
41
40
  it "should extract only the CN and not any other components" do
42
- subject = stub 'sub'
43
- Puppet::Util::SSL.expects(:cn_from_subject).with(subject).returns 'host.domain.com'
41
+ subject = double('sub')
42
+ expect(Puppet::Util::SSL).to receive(:cn_from_subject).with(subject).and_return('host.domain.com')
44
43
  expect(@class.name_from_subject(subject)).to eq('host.domain.com')
45
44
  end
46
45
  end
@@ -48,14 +47,14 @@ describe Puppet::SSL::Certificate do
48
47
  describe "when initializing wrapped class from a file with #read" do
49
48
  it "should open the file with ASCII encoding" do
50
49
  path = '/foo/bar/cert'
51
- Puppet::SSL::Base.stubs(:valid_certname).returns(true)
52
- Puppet::FileSystem.expects(:read).with(path, :encoding => Encoding::ASCII).returns("bar")
50
+ allow(Puppet::SSL::Base).to receive(:valid_certname).and_return(true)
51
+ expect(Puppet::FileSystem).to receive(:read).with(path, :encoding => Encoding::ASCII).and_return("bar")
53
52
  @base.read(path)
54
53
  end
55
54
  end
56
55
 
57
56
  describe "#digest_algorithm" do
58
- let(:content) { stub 'content' }
57
+ let(:content) { double('content') }
59
58
  let(:base) {
60
59
  b = Puppet::SSL::Base.new('base')
61
60
  b.content = content
@@ -79,13 +78,13 @@ describe Puppet::SSL::Certificate do
79
78
  'dsaWithSHA1' => 'sha1',
80
79
  }.each do |signature, digest|
81
80
  it "returns '#{digest}' for signature algorithm '#{signature}'" do
82
- content.stubs(:signature_algorithm).returns(signature)
81
+ allow(content).to receive(:signature_algorithm).and_return(signature)
83
82
  expect(base.digest_algorithm).to eq(digest)
84
83
  end
85
84
  end
86
85
 
87
86
  it "raises an error on an unknown signature algorithm" do
88
- content.stubs(:signature_algorithm).returns("nonsense")
87
+ allow(content).to receive(:signature_algorithm).and_return("nonsense")
89
88
  expect {
90
89
  base.digest_algorithm
91
90
  }.to raise_error(Puppet::Error, "Unknown signature algorithm 'nonsense'")
@@ -3,8 +3,7 @@ require 'spec_helper'
3
3
  require 'puppet/ssl/certificate_authority/autosign_command'
4
4
 
5
5
  describe Puppet::SSL::CertificateAuthority::AutosignCommand do
6
-
7
- let(:csr) { stub 'csr', :name => 'host', :to_s => 'CSR PEM goes here' }
6
+ let(:csr) { double('csr', :name => 'host', :to_s => 'CSR PEM goes here') }
8
7
  let(:decider) { Puppet::SSL::CertificateAuthority::AutosignCommand.new('/autosign/command') }
9
8
 
10
9
  it "returns true if the command succeeded" do
@@ -20,11 +19,11 @@ describe Puppet::SSL::CertificateAuthority::AutosignCommand do
20
19
  end
21
20
 
22
21
  def executes_the_command_resulting_in(exitstatus)
23
- Puppet::Util::Execution.expects(:execute).
22
+ expect(Puppet::Util::Execution).to receive(:execute).
24
23
  with(['/autosign/command', 'host'],
25
- has_entries(:stdinfile => anything,
26
- :combine => true,
27
- :failonfail => false)).
28
- returns(Puppet::Util::Execution::ProcessOutput.new('', exitstatus))
24
+ hash_including(:stdinfile => anything,
25
+ :combine => true,
26
+ :failonfail => false)).
27
+ and_return(Puppet::Util::Execution::ProcessOutput.new('', exitstatus))
29
28
  end
30
29
  end
@@ -1,12 +1,11 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/ssl/certificate_authority'
5
4
 
6
5
  shared_examples_for "a normal interface method" do
7
6
  it "should call the method on the CA for each host specified if an array was provided" do
8
- @ca.expects(@method).with("host1")
9
- @ca.expects(@method).with("host2")
7
+ expect(@ca).to receive(@method).with("host1")
8
+ expect(@ca).to receive(@method).with("host2")
10
9
 
11
10
  @applier = Puppet::SSL::CertificateAuthority::Interface.new(@method, :to => %w{host1 host2})
12
11
 
@@ -14,10 +13,10 @@ shared_examples_for "a normal interface method" do
14
13
  end
15
14
 
16
15
  it "should call the method on the CA for all existing certificates if :all was provided" do
17
- @ca.expects(:list).returns %w{host1 host2}
16
+ expect(@ca).to receive(:list).and_return(%w{host1 host2})
18
17
 
19
- @ca.expects(@method).with("host1")
20
- @ca.expects(@method).with("host2")
18
+ expect(@ca).to receive(@method).with("host1")
19
+ expect(@ca).to receive(@method).with("host2")
21
20
 
22
21
  @applier = Puppet::SSL::CertificateAuthority::Interface.new(@method, :to => :all)
23
22
 
@@ -27,8 +26,8 @@ end
27
26
 
28
27
  shared_examples_for "a destructive interface method" do
29
28
  it "calls the method on the CA for each host specified if an array was provided" do
30
- @ca.expects(@method).with("host1")
31
- @ca.expects(@method).with("host2")
29
+ expect(@ca).to receive(@method).with("host1")
30
+ expect(@ca).to receive(@method).with("host2")
32
31
 
33
32
  @applier = Puppet::SSL::CertificateAuthority::Interface.new(@method, :to => %w{host1 host2})
34
33
 
@@ -56,6 +55,7 @@ describe Puppet::SSL::CertificateAuthority::Interface do
56
55
  before do
57
56
  @class = Puppet::SSL::CertificateAuthority::Interface
58
57
  end
58
+
59
59
  describe "when initializing" do
60
60
  it "should set its method using its settor" do
61
61
  instance = @class.new(:generate, :to => :all)
@@ -106,7 +106,7 @@ describe Puppet::SSL::CertificateAuthority::Interface do
106
106
  describe "when applying" do
107
107
  before do
108
108
  # We use a real object here, because :verify can't be stubbed, apparently.
109
- @ca = Object.new
109
+ @ca = double()
110
110
  end
111
111
 
112
112
  describe "with an empty array specified and the method is not list" do
@@ -125,8 +125,8 @@ describe Puppet::SSL::CertificateAuthority::Interface do
125
125
  it "should call :generate on the CA for each host specified" do
126
126
  @applier = @class.new(:generate, :to => %w{host1 host2})
127
127
 
128
- @ca.expects(:generate).with() {|*args| args.first == "host1" }
129
- @ca.expects(:generate).with() {|*args| args.first == "host2" }
128
+ expect(@ca).to receive(:generate).with("host1", any_args)
129
+ expect(@ca).to receive(:generate).with("host2", any_args)
130
130
 
131
131
  @applier.apply(@ca)
132
132
  end
@@ -162,40 +162,40 @@ describe Puppet::SSL::CertificateAuthority::Interface do
162
162
 
163
163
  describe "when run in interactive mode" do
164
164
  before do
165
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).with("csr1").returns @csr1
165
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).with("csr1").and_return(@csr1)
166
166
 
167
- @ca.stubs(:waiting?).returns(%w{csr1})
168
- @ca.stubs(:check_internal_signing_policies).returns(true)
167
+ allow(@ca).to receive(:waiting?).and_return(%w{csr1})
168
+ allow(@ca).to receive(:check_internal_signing_policies).and_return(true)
169
169
  end
170
170
 
171
171
  it "should prompt before signing cert" do
172
172
  @applier = @class.new(:sign, :to => :all, :interactive => true)
173
- @applier.stubs(:format_host).returns("(host info)")
173
+ allow(@applier).to receive(:format_host).and_return("(host info)")
174
174
 
175
- @applier.expects(:puts).
175
+ expect(@applier).to receive(:puts).
176
176
  with("Signing Certificate Request for:\n(host info)")
177
177
 
178
- STDOUT.expects(:print).with("Sign Certificate Request? [y/N] ")
178
+ expect(STDOUT).to receive(:print).with("Sign Certificate Request? [y/N] ")
179
179
 
180
- STDIN.stubs(:gets).returns('y')
181
- @ca.expects(:sign).with("csr1", {})
180
+ allow(STDIN).to receive(:gets).and_return('y')
181
+ expect(@ca).to receive(:sign).with("csr1", {})
182
182
 
183
183
  @applier.apply(@ca)
184
184
  end
185
185
 
186
186
  it "a yes answer can be assumed via options" do
187
187
  @applier = @class.new(:sign, :to => :all, :interactive => true, :yes => true)
188
- @applier.stubs(:format_host).returns("(host info)")
188
+ allow(@applier).to receive(:format_host).and_return("(host info)")
189
189
 
190
- @applier.expects(:puts).
190
+ expect(@applier).to receive(:puts).
191
191
  with("Signing Certificate Request for:\n(host info)")
192
192
 
193
- STDOUT.expects(:print).with("Sign Certificate Request? [y/N] ")
193
+ expect(STDOUT).to receive(:print).with("Sign Certificate Request? [y/N] ")
194
194
 
195
- @applier.expects(:puts).
195
+ expect(@applier).to receive(:puts).
196
196
  with("Assuming YES from `-y' or `--assume-yes' flag")
197
197
 
198
- @ca.expects(:sign).with("csr1", {})
198
+ expect(@ca).to receive(:sign).with("csr1", {})
199
199
 
200
200
  @applier.apply(@ca)
201
201
  end
@@ -203,32 +203,32 @@ describe Puppet::SSL::CertificateAuthority::Interface do
203
203
 
204
204
  describe "and an array of names was provided" do
205
205
  before do
206
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).with("host1").returns @csr1
207
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).with("host2").returns @csr1
206
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).with("host1").and_return(@csr1)
207
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).with("host2").and_return(@csr1)
208
208
  end
209
209
 
210
210
  let(:applier) { @class.new(:sign, @options.merge(:to => %w{host1 host2})) }
211
211
 
212
212
  it "should sign the specified waiting certificate requests" do
213
213
  @options = {:allow_dns_alt_names => false}
214
- applier.stubs(:format_host).returns("")
215
- applier.stubs(:puts)
216
- @ca.stubs(:check_internal_signing_policies).returns(true)
214
+ allow(applier).to receive(:format_host).and_return("")
215
+ allow(applier).to receive(:puts)
216
+ allow(@ca).to receive(:check_internal_signing_policies).and_return(true)
217
217
 
218
- @ca.expects(:sign).with("host1", @options)
219
- @ca.expects(:sign).with("host2", @options)
218
+ expect(@ca).to receive(:sign).with("host1", @options)
219
+ expect(@ca).to receive(:sign).with("host2", @options)
220
220
 
221
221
  applier.apply(@ca)
222
222
  end
223
223
 
224
224
  it "should sign the certificate requests with alt names if specified" do
225
225
  @options = {:allow_dns_alt_names => true}
226
- applier.stubs(:format_host).returns("")
227
- applier.stubs(:puts)
228
- @ca.stubs(:check_internal_signing_policies).returns(true)
226
+ allow(applier).to receive(:format_host).and_return("")
227
+ allow(applier).to receive(:puts)
228
+ allow(@ca).to receive(:check_internal_signing_policies).and_return(true)
229
229
 
230
- @ca.expects(:sign).with("host1", @options)
231
- @ca.expects(:sign).with("host2", @options)
230
+ expect(@ca).to receive(:sign).with("host1", @options)
231
+ expect(@ca).to receive(:sign).with("host2", @options)
232
232
 
233
233
  applier.apply(@ca)
234
234
  end
@@ -236,22 +236,22 @@ describe Puppet::SSL::CertificateAuthority::Interface do
236
236
 
237
237
  describe "and :all was provided" do
238
238
  it "should sign all waiting certificate requests" do
239
- @ca.stubs(:waiting?).returns(%w{cert1 cert2})
240
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).with("cert1").returns @csr1
241
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).with("cert2").returns @csr1
242
- @ca.stubs(:check_internal_signing_policies).returns(true)
239
+ allow(@ca).to receive(:waiting?).and_return(%w{cert1 cert2})
240
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).with("cert1").and_return(@csr1)
241
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).with("cert2").and_return(@csr1)
242
+ allow(@ca).to receive(:check_internal_signing_policies).and_return(true)
243
243
 
244
- @ca.expects(:sign).with("cert1", {})
245
- @ca.expects(:sign).with("cert2", {})
244
+ expect(@ca).to receive(:sign).with("cert1", {})
245
+ expect(@ca).to receive(:sign).with("cert2", {})
246
246
 
247
247
  @applier = @class.new(:sign, :to => :all)
248
- @applier.stubs(:format_host).returns("")
249
- @applier.stubs(:puts)
248
+ allow(@applier).to receive(:format_host).and_return("")
249
+ allow(@applier).to receive(:puts)
250
250
  @applier.apply(@ca)
251
251
  end
252
252
 
253
253
  it "should fail if there are no waiting certificate requests" do
254
- @ca.stubs(:waiting?).returns([])
254
+ allow(@ca).to receive(:waiting?).and_return([])
255
255
 
256
256
  @applier = @class.new(:sign, :to => :all)
257
257
  expect { @applier.apply(@ca) }.to raise_error(Puppet::SSL::CertificateAuthority::Interface::InterfaceError)
@@ -270,35 +270,34 @@ describe Puppet::SSL::CertificateAuthority::Interface do
270
270
  @cert = Puppet::SSL::Certificate.new 'foo'
271
271
  @csr = Puppet::SSL::CertificateRequest.new 'bar'
272
272
 
273
- @cert.stubs(:subject_alt_names).returns signed_alt_names
274
- @cert.stubs(:custom_extensions).returns custom_exts
273
+ allow(@cert).to receive(:subject_alt_names).and_return(signed_alt_names)
274
+ allow(@cert).to receive(:custom_extensions).and_return(custom_exts)
275
275
 
276
- @csr.stubs(:subject_alt_names).returns request_alt_names
277
- @csr.stubs(:custom_attributes).returns custom_attrs
278
- @csr.stubs(:request_extensions).returns ext_requests
276
+ allow(@csr).to receive(:subject_alt_names).and_return(request_alt_names)
277
+ allow(@csr).to receive(:custom_attributes).and_return(custom_attrs)
278
+ allow(@csr).to receive(:request_extensions).and_return(ext_requests)
279
279
 
280
- Puppet::SSL::Certificate.indirection.stubs(:find).returns @cert
281
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).returns @csr
280
+ allow(Puppet::SSL::Certificate.indirection).to receive(:find).and_return(@cert)
281
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).and_return(@csr)
282
282
 
283
- @digest = mock("digest")
284
- @digest.stubs(:to_s).returns("(fingerprint)")
283
+ @digest = double("digest")
284
+ allow(@digest).to receive(:to_s).and_return("(fingerprint)")
285
285
 
286
- @expiration = mock('time')
287
- @expiration.stubs(:iso8601).returns("(expiration)")
288
- @cert.stubs(:expiration).returns(@expiration)
286
+ @expiration = double('time')
287
+ allow(@expiration).to receive(:iso8601).and_return("(expiration)")
288
+ allow(@cert).to receive(:expiration).and_return(@expiration)
289
289
 
290
- @ca.expects(:waiting?).returns %w{host1 host2 host3}
291
- @ca.expects(:list).returns(%w{host4 host5 host6}).at_most(1)
292
- @csr.stubs(:digest).returns @digest
293
- @cert.stubs(:digest).returns @digest
294
- @ca.stubs(:verify)
290
+ allow(@csr).to receive(:digest).and_return(@digest)
291
+ allow(@cert).to receive(:digest).and_return(@digest)
292
+ allow(@ca).to receive(:verify)
295
293
  end
296
294
 
297
295
  describe "and an empty array was provided" do
298
296
  it "should print all certificate requests" do
299
- applier = @class.new(:list, :to => [])
297
+ expect(@ca).to receive(:waiting?).and_return(%w{host1 host2 host3})
298
+ applier = @class.new(:list, :to => [])
300
299
 
301
- applier.expects(:puts).with(<<-OUTPUT.chomp)
300
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
302
301
  "host1" (fingerprint)
303
302
  "host2" (fingerprint)
304
303
  "host3" (fingerprint)
@@ -310,12 +309,13 @@ describe Puppet::SSL::CertificateAuthority::Interface do
310
309
 
311
310
  describe "and :all was provided" do
312
311
  it "should print a string containing all certificate requests and certificates" do
313
- @ca.expects(:list).returns %w{host4 host5 host6}
314
- @ca.stubs(:verify).with("host4").raises(Puppet::SSL::CertificateAuthority::CertificateVerificationError.new(23), "certificate revoked")
312
+ expect(@ca).to receive(:waiting?).and_return(%w{host1 host2 host3})
313
+ expect(@ca).to receive(:list).and_return(%w{host4 host5 host6})
314
+ allow(@ca).to receive(:verify).with("host4").and_raise(Puppet::SSL::CertificateAuthority::CertificateVerificationError.new(23), "certificate revoked")
315
315
 
316
316
  applier = @class.new(:list, :to => :all)
317
317
 
318
- applier.expects(:puts).with(<<-OUTPUT.chomp)
318
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
319
319
  "host1" (fingerprint)
320
320
  "host2" (fingerprint)
321
321
  "host3" (fingerprint)
@@ -330,10 +330,11 @@ describe Puppet::SSL::CertificateAuthority::Interface do
330
330
 
331
331
  describe "and :signed was provided" do
332
332
  it "should print a string containing all signed certificate requests and certificates" do
333
- @ca.expects(:list).returns %w{host4 host5 host6}
333
+ expect(@ca).to receive(:waiting?).and_return(%w{host1 host2 host3})
334
+ expect(@ca).to receive(:list).and_return(%w{host4 host5 host6})
334
335
  applier = @class.new(:list, :to => :signed)
335
336
 
336
- applier.expects(:puts).with(<<-OUTPUT.chomp)
337
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
337
338
  + "host4" (fingerprint)
338
339
  + "host5" (fingerprint)
339
340
  + "host6" (fingerprint)
@@ -343,11 +344,13 @@ describe Puppet::SSL::CertificateAuthority::Interface do
343
344
  end
344
345
 
345
346
  it "should include subject alt names if they are on the certificate request" do
346
- @csr.stubs(:subject_alt_names).returns ["DNS:foo", "DNS:bar"]
347
+ expect(@ca).to receive(:waiting?).and_return(%w{host1 host2 host3})
348
+ expect(@ca).to receive(:list).and_return(%w{host4 host5 host6}).at_most(:once)
349
+ allow(@csr).to receive(:subject_alt_names).and_return(["DNS:foo", "DNS:bar"])
347
350
 
348
351
  applier = @class.new(:list, :to => ['host1'])
349
352
 
350
- applier.expects(:puts).with(<<-OUTPUT.chomp)
353
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
351
354
  "host1" (fingerprint) (alt names: "DNS:foo", "DNS:bar")
352
355
  OUTPUT
353
356
 
@@ -357,9 +360,11 @@ describe Puppet::SSL::CertificateAuthority::Interface do
357
360
 
358
361
  describe "and an array of names was provided" do
359
362
  it "should print all named hosts" do
363
+ expect(@ca).to receive(:waiting?).and_return(%w{host1 host2 host3})
364
+ expect(@ca).to receive(:list).and_return(%w{host4 host5 host6}).at_most(:once)
360
365
  applier = @class.new(:list, :to => %w{host1 host2 host4 host5})
361
366
 
362
- applier.expects(:puts).with(<<-OUTPUT.chomp)
367
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
363
368
  "host1" (fingerprint)
364
369
  "host2" (fingerprint)
365
370
  + "host4" (fingerprint)
@@ -377,24 +382,22 @@ describe Puppet::SSL::CertificateAuthority::Interface do
377
382
  let(:signed_alt_names) { ["DNS:puppet", "DNS:puppet.example.com"] }
378
383
 
379
384
  before do
380
- @ca.unstub(:waiting?)
381
- @ca.unstub(:list)
382
- @ca.expects(:waiting?).returns %w{ext3}
383
- @ca.expects(:list).returns(%w{ext1 ext2}).at_most(1)
385
+ expect(@ca).to receive(:waiting?).and_return(%w{ext3})
386
+ expect(@ca).to receive(:list).and_return(%w{ext1 ext2}).at_most(:once)
384
387
 
385
- @ca.stubs(:verify).with("ext2").
386
- raises(Puppet::SSL::CertificateAuthority::CertificateVerificationError.new(23),
387
- "certificate revoked")
388
+ allow(@ca).to receive(:verify).with("ext2").
389
+ and_raise(Puppet::SSL::CertificateAuthority::CertificateVerificationError.new(23),
390
+ "certificate revoked")
388
391
 
389
- Puppet::SSL::Certificate.indirection.stubs(:find).returns @cert
390
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).returns @csr
392
+ allow(Puppet::SSL::Certificate.indirection).to receive(:find).and_return(@cert)
393
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).and_return(@csr)
391
394
  end
392
395
 
393
396
  describe "using legacy format" do
394
397
  it "should append astrisks to end of line to denote additional information available" do
395
398
  applier = @class.new(:list, :to => %w{ext1 ext2 ext3})
396
399
 
397
- applier.expects(:puts).with(<<-OUTPUT.chomp)
400
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
398
401
  "ext3" (fingerprint) **
399
402
  + "ext1" (fingerprint) (alt names: "DNS:puppet", "DNS:puppet.example.com") **
400
403
  - "ext2" (fingerprint) (certificate revoked)
@@ -406,7 +409,7 @@ describe Puppet::SSL::CertificateAuthority::Interface do
406
409
  it "should append attributes and extensions to end of line when running :verbose" do
407
410
  applier = @class.new(:list, :to => %w{ext1 ext2 ext3}, :verbose => true)
408
411
 
409
- applier.expects(:puts).with(<<-OUTPUT.chomp)
412
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
410
413
  "ext3" (fingerprint) (customAttr: "attrValue", customExt: "reqExtValue")
411
414
  + "ext1" (fingerprint) (expiration) (alt names: "DNS:puppet", "DNS:puppet.example.com", extName: "extValue")
412
415
  - "ext2" (fingerprint) (certificate revoked)
@@ -420,7 +423,7 @@ describe Puppet::SSL::CertificateAuthority::Interface do
420
423
  it "use the same format as :verbose legacy format" do
421
424
  applier = @class.new(:list, :to => %w{ext1 ext2 ext3}, :format => :machine)
422
425
 
423
- applier.expects(:puts).with(<<-OUTPUT.chomp)
426
+ expect(applier).to receive(:puts).with(<<-OUTPUT.chomp)
424
427
  "ext3" (fingerprint) (customAttr: "attrValue", customExt: "reqExtValue")
425
428
  + "ext1" (fingerprint) (expiration) (alt names: "DNS:puppet", "DNS:puppet.example.com", extName: "extValue")
426
429
  - "ext2" (fingerprint) (certificate revoked)
@@ -434,7 +437,7 @@ describe Puppet::SSL::CertificateAuthority::Interface do
434
437
  it "should break attributes and extensions to separate lines" do
435
438
  applier = @class.new(:list, :to => %w{ext1 ext2 ext3}, :format => :human)
436
439
 
437
- applier.expects(:puts).with(<<-OUTPUT)
440
+ expect(applier).to receive(:puts).with(<<-OUTPUT)
438
441
  "ext3"
439
442
  (fingerprint)
440
443
  Status: Request Pending
@@ -464,15 +467,15 @@ OUTPUT
464
467
  describe ":print" do
465
468
  describe "and :all was provided" do
466
469
  it "should print all certificates" do
467
- @ca.expects(:list).returns %w{host1 host2}
470
+ expect(@ca).to receive(:list).and_return(%w{host1 host2})
468
471
 
469
472
  @applier = @class.new(:print, :to => :all)
470
473
 
471
- @ca.expects(:print).with("host1").returns "h1"
472
- @applier.expects(:puts).with "h1"
474
+ expect(@ca).to receive(:print).with("host1").and_return("h1")
475
+ expect(@applier).to receive(:puts).with("h1")
473
476
 
474
- @ca.expects(:print).with("host2").returns "h2"
475
- @applier.expects(:puts).with "h2"
477
+ expect(@ca).to receive(:print).with("host2").and_return("h2")
478
+ expect(@applier).to receive(:puts).with("h2")
476
479
 
477
480
  @applier.apply(@ca)
478
481
  end
@@ -482,11 +485,11 @@ OUTPUT
482
485
  it "should print each named certificate if found" do
483
486
  @applier = @class.new(:print, :to => %w{host1 host2})
484
487
 
485
- @ca.expects(:print).with("host1").returns "h1"
486
- @applier.expects(:puts).with "h1"
488
+ expect(@ca).to receive(:print).with("host1").and_return("h1")
489
+ expect(@applier).to receive(:puts).with("h1")
487
490
 
488
- @ca.expects(:print).with("host2").returns "h2"
489
- @applier.expects(:puts).with "h2"
491
+ expect(@ca).to receive(:print).with("host2").and_return("h2")
492
+ expect(@applier).to receive(:puts).with("h2")
490
493
 
491
494
  @applier.apply(@ca)
492
495
  end
@@ -494,10 +497,10 @@ OUTPUT
494
497
  it "should log any named but not found certificates" do
495
498
  @applier = @class.new(:print, :to => %w{host1 host2})
496
499
 
497
- @ca.expects(:print).with("host1").returns "h1"
498
- @applier.expects(:puts).with "h1"
500
+ expect(@ca).to receive(:print).with("host1").and_return("h1")
501
+ expect(@applier).to receive(:puts).with("h1")
499
502
 
500
- @ca.expects(:print).with("host2").returns nil
503
+ expect(@ca).to receive(:print).with("host2").and_return(nil)
501
504
 
502
505
  expect {
503
506
  @applier.apply(@ca)
@@ -510,33 +513,33 @@ OUTPUT
510
513
  before(:each) do
511
514
  @cert = Puppet::SSL::Certificate.new 'foo'
512
515
  @csr = Puppet::SSL::CertificateRequest.new 'bar'
513
- Puppet::SSL::Certificate.indirection.stubs(:find)
514
- Puppet::SSL::CertificateRequest.indirection.stubs(:find)
515
- Puppet::SSL::Certificate.indirection.stubs(:find).with('host1').returns(@cert)
516
- Puppet::SSL::CertificateRequest.indirection.stubs(:find).with('host2').returns(@csr)
516
+ allow(Puppet::SSL::Certificate.indirection).to receive(:find)
517
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find)
518
+ allow(Puppet::SSL::Certificate.indirection).to receive(:find).with('host1').and_return(@cert)
519
+ allow(Puppet::SSL::CertificateRequest.indirection).to receive(:find).with('host2').and_return(@csr)
517
520
  end
518
521
 
519
522
  it "should fingerprint with the set digest algorithm" do
520
523
  @applier = @class.new(:fingerprint, :to => %w{host1}, :digest => :shaonemillion)
521
- @cert.expects(:digest).with(:shaonemillion).returns("fingerprint1")
524
+ expect(@cert).to receive(:digest).with(:shaonemillion).and_return("fingerprint1")
522
525
 
523
- @applier.expects(:puts).with "host1 fingerprint1"
526
+ expect(@applier).to receive(:puts).with "host1 fingerprint1"
524
527
 
525
528
  @applier.apply(@ca)
526
529
  end
527
530
 
528
531
  describe "and :all was provided" do
529
532
  it "should fingerprint all certificates (including waiting ones)" do
530
- @ca.expects(:list).returns %w{host1}
531
- @ca.expects(:waiting?).returns %w{host2}
533
+ expect(@ca).to receive(:list).and_return(%w{host1})
534
+ expect(@ca).to receive(:waiting?).and_return(%w{host2})
532
535
 
533
536
  @applier = @class.new(:fingerprint, :to => :all)
534
537
 
535
- @cert.expects(:digest).returns("fingerprint1")
536
- @applier.expects(:puts).with "host1 fingerprint1"
538
+ expect(@cert).to receive(:digest).and_return("fingerprint1")
539
+ expect(@applier).to receive(:puts).with("host1 fingerprint1")
537
540
 
538
- @csr.expects(:digest).returns("fingerprint2")
539
- @applier.expects(:puts).with "host2 fingerprint2"
541
+ expect(@csr).to receive(:digest).and_return("fingerprint2")
542
+ expect(@applier).to receive(:puts).with("host2 fingerprint2")
540
543
 
541
544
  @applier.apply(@ca)
542
545
  end
@@ -546,11 +549,11 @@ OUTPUT
546
549
  it "should print each named certificate if found" do
547
550
  @applier = @class.new(:fingerprint, :to => %w{host1 host2})
548
551
 
549
- @cert.expects(:digest).returns("fingerprint1")
550
- @applier.expects(:puts).with "host1 fingerprint1"
552
+ expect(@cert).to receive(:digest).and_return("fingerprint1")
553
+ expect(@applier).to receive(:puts).with("host1 fingerprint1")
551
554
 
552
- @csr.expects(:digest).returns("fingerprint2")
553
- @applier.expects(:puts).with "host2 fingerprint2"
555
+ expect(@csr).to receive(:digest).and_return("fingerprint2")
556
+ expect(@applier).to receive(:puts).with("host2 fingerprint2")
554
557
 
555
558
  @applier.apply(@ca)
556
559
  end