puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  if Puppet.features.telnet?
@@ -7,7 +6,12 @@ if Puppet.features.telnet?
7
6
  describe Puppet::Util::NetworkDevice::Transport::Telnet do
8
7
 
9
8
  before(:each) do
10
- TCPSocket.stubs(:open).returns stub_everything('tcp')
9
+ tcp = double(
10
+ 'tcp',
11
+ :sync= => nil,
12
+ :binmode => nil,
13
+ )
14
+ allow(TCPSocket).to receive(:open).and_return(tcp)
11
15
  @transport = Puppet::Util::NetworkDevice::Transport::Telnet.new()
12
16
  end
13
17
 
@@ -16,7 +20,7 @@ if Puppet.features.telnet?
16
20
  end
17
21
 
18
22
  it "should not open any files" do
19
- File.expects(:open).never
23
+ expect(File).not_to receive(:open)
20
24
  @transport.host = "localhost"
21
25
  @transport.port = 23
22
26
 
@@ -24,7 +28,7 @@ if Puppet.features.telnet?
24
28
  end
25
29
 
26
30
  it "should connect to the given host and port" do
27
- Net::Telnet.expects(:new).with { |args| args["Host"] == "localhost" && args["Port"] == 23 }.returns stub_everything
31
+ expect(Net::Telnet).to receive(:new).with(hash_including("Host" => "localhost", "Port" => 23)).and_return(double("telnet connection"))
28
32
  @transport.host = "localhost"
29
33
  @transport.port = 23
30
34
 
@@ -33,7 +37,7 @@ if Puppet.features.telnet?
33
37
 
34
38
  it "should connect and specify the default prompt" do
35
39
  @transport.default_prompt = "prompt"
36
- Net::Telnet.expects(:new).with { |args| args["Prompt"] == "prompt" }.returns stub_everything
40
+ expect(Net::Telnet).to receive(:new).with(hash_including("Prompt" => "prompt")).and_return(double("telnet connection"))
37
41
  @transport.host = "localhost"
38
42
  @transport.port = 23
39
43
 
@@ -42,29 +46,29 @@ if Puppet.features.telnet?
42
46
 
43
47
  describe "when connected" do
44
48
  before(:each) do
45
- @telnet = stub_everything 'telnet'
46
- Net::Telnet.stubs(:new).returns(@telnet)
49
+ @telnet = double('telnet')
50
+ allow(Net::Telnet).to receive(:new).and_return(@telnet)
47
51
  @transport.connect
48
52
  end
49
53
 
50
54
  it "should send line to the telnet session" do
51
- @telnet.expects(:puts).with("line")
55
+ expect(@telnet).to receive(:puts).with("line")
52
56
  @transport.send("line")
53
57
  end
54
58
 
55
59
  describe "when expecting output" do
56
60
  it "should waitfor output on the telnet session" do
57
- @telnet.expects(:waitfor).with(/regex/)
61
+ expect(@telnet).to receive(:waitfor).with(/regex/)
58
62
  @transport.expect(/regex/)
59
63
  end
60
64
 
61
65
  it "should return telnet session output" do
62
- @telnet.expects(:waitfor).returns("output")
66
+ expect(@telnet).to receive(:waitfor).and_return("output")
63
67
  expect(@transport.expect(/regex/)).to eq("output")
64
68
  end
65
69
 
66
70
  it "should yield telnet session output to the given block" do
67
- @telnet.expects(:waitfor).yields("output")
71
+ expect(@telnet).to receive(:waitfor).and_yield("output")
68
72
  @transport.expect(/regex/) { |out| expect(out).to eq("output") }
69
73
  end
70
74
  end
@@ -72,13 +76,13 @@ if Puppet.features.telnet?
72
76
 
73
77
  describe "when closing" do
74
78
  before(:each) do
75
- @telnet = stub_everything 'telnet'
76
- Net::Telnet.stubs(:new).returns(@telnet)
79
+ @telnet = double('telnet')
80
+ allow(Net::Telnet).to receive(:new).and_return(@telnet)
77
81
  @transport.connect
78
82
  end
79
83
 
80
84
  it "should close the telnet session" do
81
- @telnet.expects(:close)
85
+ expect(@telnet).to receive(:close)
82
86
  @transport.close
83
87
  end
84
88
  end
@@ -1,11 +1,9 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'ostruct'
5
4
  require 'puppet/util/network_device'
6
5
 
7
6
  describe Puppet::Util::NetworkDevice do
8
-
9
7
  before(:each) do
10
8
  @device = OpenStruct.new(:name => "name", :provider => "test", :url => "telnet://admin:password@127.0.0.1", :options => { :debug => false })
11
9
  end
@@ -23,25 +21,25 @@ describe Puppet::Util::NetworkDevice do
23
21
 
24
22
  describe "when initializing the remote network device singleton" do
25
23
  it "should load the network device code" do
26
- Puppet::Util::NetworkDevice.expects(:require)
24
+ expect(Puppet::Util::NetworkDevice).to receive(:require)
27
25
  Puppet::Util::NetworkDevice.init(@device)
28
26
  end
29
27
 
30
28
  it "should create a network device instance" do
31
- Puppet::Util::NetworkDevice.stubs(:require)
32
- Puppet::Util::NetworkDevice::Test::Device.expects(:new).with("telnet://admin:password@127.0.0.1", :debug => false)
29
+ allow(Puppet::Util::NetworkDevice).to receive(:require)
30
+ expect(Puppet::Util::NetworkDevice::Test::Device).to receive(:new).with("telnet://admin:password@127.0.0.1", :debug => false)
33
31
  Puppet::Util::NetworkDevice.init(@device)
34
32
  end
35
33
 
36
34
  it "should raise an error if the remote device instance can't be created" do
37
- Puppet::Util::NetworkDevice.stubs(:require).raises("error")
35
+ allow(Puppet::Util::NetworkDevice).to receive(:require).and_raise("error")
38
36
  expect { Puppet::Util::NetworkDevice.init(@device) }.to raise_error(RuntimeError, /Can't load test for name/)
39
37
  end
40
38
 
41
39
  it "should let caller to access the singleton device" do
42
- device = stub 'device'
43
- Puppet::Util::NetworkDevice.stubs(:require)
44
- Puppet::Util::NetworkDevice::Test::Device.expects(:new).returns(device)
40
+ device = double('device')
41
+ allow(Puppet::Util::NetworkDevice).to receive(:require)
42
+ expect(Puppet::Util::NetworkDevice::Test::Device).to receive(:new).and_return(device)
45
43
  Puppet::Util::NetworkDevice.init(@device)
46
44
 
47
45
  expect(Puppet::Util::NetworkDevice.current).to eq(device)
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/util/package'
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/util/pidlock'
@@ -51,7 +50,7 @@ describe Puppet::Util::Pidlock do
51
50
  end
52
51
 
53
52
  it 'should create an empty lock file even when pid is missing' do
54
- Process.stubs(:pid).returns('')
53
+ allow(Process).to receive(:pid).and_return('')
55
54
  @lock.lock
56
55
  expect(Puppet::FileSystem.exist?(@lock.file_path)).to be_truthy
57
56
  expect(Puppet::FileSystem.read(@lock.file_path)).to be_empty
@@ -59,12 +58,12 @@ describe Puppet::Util::Pidlock do
59
58
 
60
59
  it 'should replace an existing empty lockfile with a pid, given a subsequent lock call made against a valid pid' do
61
60
  # empty pid results in empty lockfile
62
- Process.stubs(:pid).returns('')
61
+ allow(Process).to receive(:pid).and_return('')
63
62
  @lock.lock
64
63
  expect(Puppet::FileSystem.exist?(@lock.file_path)).to be_truthy
65
64
 
66
65
  # next lock call with valid pid kills existing empty lockfile
67
- Process.stubs(:pid).returns(1234)
66
+ allow(Process).to receive(:pid).and_return(1234)
68
67
  @lock.lock
69
68
  expect(Puppet::FileSystem.exist?(@lock.file_path)).to be_truthy
70
69
  expect(Puppet::FileSystem.read(@lock.file_path)).to eq('1234')
@@ -105,7 +104,7 @@ describe Puppet::Util::Pidlock do
105
104
  end
106
105
 
107
106
  it "should remove the lockfile when pid is missing" do
108
- Process.stubs(:pid).returns('')
107
+ allow(Process).to receive(:pid).and_return('')
109
108
  @lock.lock
110
109
  expect(@lock.locked?).to be_falsey
111
110
  expect(Puppet::FileSystem.exist?(@lock.file_path)).to be_falsey
@@ -115,7 +114,7 @@ describe Puppet::Util::Pidlock do
115
114
  describe '#lock_pid' do
116
115
  it 'should return nil if the pid is empty' do
117
116
  # fake pid to get empty lockfile
118
- Process.stubs(:pid).returns('')
117
+ allow(Process).to receive(:pid).and_return('')
119
118
  @lock.lock
120
119
  expect(@lock.lock_pid).to eq(nil)
121
120
  end
@@ -124,15 +123,15 @@ describe Puppet::Util::Pidlock do
124
123
  describe "with a stale lock" do
125
124
  before(:each) do
126
125
  # fake our pid to be 1234
127
- Process.stubs(:pid).returns(1234)
126
+ allow(Process).to receive(:pid).and_return(1234)
128
127
  # lock the file
129
128
  @lock.lock
130
129
  # fake our pid to be a different pid, to simulate someone else
131
130
  # holding the lock
132
- Process.stubs(:pid).returns(6789)
131
+ allow(Process).to receive(:pid).and_return(6789)
133
132
 
134
- Process.stubs(:kill).with(0, 6789)
135
- Process.stubs(:kill).with(0, 1234).raises(Errno::ESRCH)
133
+ allow(Process).to receive(:kill).with(0, 6789)
134
+ allow(Process).to receive(:kill).with(0, 1234).and_raise(Errno::ESRCH)
136
135
  end
137
136
 
138
137
  it "should not be locked" do
@@ -169,15 +168,15 @@ describe Puppet::Util::Pidlock do
169
168
  describe "with another process lock" do
170
169
  before(:each) do
171
170
  # fake our pid to be 1234
172
- Process.stubs(:pid).returns(1234)
171
+ allow(Process).to receive(:pid).and_return(1234)
173
172
  # lock the file
174
173
  @lock.lock
175
174
  # fake our pid to be a different pid, to simulate someone else
176
175
  # holding the lock
177
- Process.stubs(:pid).returns(6789)
176
+ allow(Process).to receive(:pid).and_return(6789)
178
177
 
179
- Process.stubs(:kill).with(0, 6789)
180
- Process.stubs(:kill).with(0, 1234)
178
+ allow(Process).to receive(:kill).with(0, 6789)
179
+ allow(Process).to receive(:kill).with(0, 1234)
181
180
  end
182
181
 
183
182
  it "should be locked" do
@@ -69,55 +69,60 @@ describe Puppet::Util::Plist, :if => Puppet.features.cfpropertylist? do
69
69
 
70
70
  describe "#read_plist_file" do
71
71
  it "calls #convert_cfpropertylist_to_native_types on a plist object when a valid binary plist is read" do
72
- subject.stubs(:read_file_with_offset).with(plist_path, 8).returns(binary_plist_magic_number)
73
- subject.stubs(:new_cfpropertylist).with({:file => plist_path}).returns('plist_object')
74
- subject.expects(:convert_cfpropertylist_to_native_types).with('plist_object').returns('plist_hash')
72
+ allow(subject).to receive(:read_file_with_offset).with(plist_path, 8).and_return(binary_plist_magic_number)
73
+ allow(subject).to receive(:new_cfpropertylist).with({:file => plist_path}).and_return('plist_object')
74
+ expect(subject).to receive(:convert_cfpropertylist_to_native_types).with('plist_object').and_return('plist_hash')
75
75
  expect(subject.read_plist_file(plist_path)).to eq('plist_hash')
76
76
  end
77
+
77
78
  it "returns a valid hash when a valid XML plist is read" do
78
- subject.stubs(:read_file_with_offset).with(plist_path, 8).returns('notbinary')
79
- subject.stubs(:open_file_with_args).with(plist_path, 'r:UTF-8').returns(valid_xml_plist)
79
+ allow(subject).to receive(:read_file_with_offset).with(plist_path, 8).and_return('notbinary')
80
+ allow(subject).to receive(:open_file_with_args).with(plist_path, 'r:UTF-8').and_return(valid_xml_plist)
80
81
  expect(subject.read_plist_file(plist_path)).to eq(valid_xml_plist_hash)
81
82
  end
83
+
82
84
  it "raises a debug message and replaces a bad XML plist doctype should one be encountered" do
83
- subject.stubs(:read_file_with_offset).with(plist_path, 8).returns('notbinary')
84
- subject.stubs(:open_file_with_args).with(plist_path, 'r:UTF-8').returns(bad_xml_doctype)
85
- subject.expects(:new_cfpropertylist).with({:data => good_xml_doctype}).returns('plist_object')
86
- subject.stubs(:convert_cfpropertylist_to_native_types).with('plist_object').returns('plist_hash')
87
- Puppet.expects(:debug).with("Had to fix plist with incorrect DOCTYPE declaration: #{plist_path}")
85
+ allow(subject).to receive(:read_file_with_offset).with(plist_path, 8).and_return('notbinary')
86
+ allow(subject).to receive(:open_file_with_args).with(plist_path, 'r:UTF-8').and_return(bad_xml_doctype)
87
+ expect(subject).to receive(:new_cfpropertylist).with({:data => good_xml_doctype}).and_return('plist_object')
88
+ allow(subject).to receive(:convert_cfpropertylist_to_native_types).with('plist_object').and_return('plist_hash')
89
+ expect(Puppet).to receive(:debug).with("Had to fix plist with incorrect DOCTYPE declaration: #{plist_path}")
88
90
  expect(subject.read_plist_file(plist_path)).to eq('plist_hash')
89
91
  end
92
+
90
93
  it "attempts to read pure xml using plutil when reading an improperly formatted service plist" do
91
- subject.stubs(:read_file_with_offset).with(plist_path, 8).returns('notbinary')
92
- subject.stubs(:open_file_with_args).with(plist_path, 'r:UTF-8').returns(invalid_xml_plist)
93
- Puppet.expects(:debug).with(regexp_matches(/^Failed with CFFormatError/))
94
- Puppet.expects(:debug).with("Plist #{plist_path} ill-formatted, converting with plutil")
95
- Puppet::Util::Execution.expects(:execute)
94
+ allow(subject).to receive(:read_file_with_offset).with(plist_path, 8).and_return('notbinary')
95
+ allow(subject).to receive(:open_file_with_args).with(plist_path, 'r:UTF-8').and_return(invalid_xml_plist)
96
+ expect(Puppet).to receive(:debug).with(/^Failed with CFFormatError/)
97
+ expect(Puppet).to receive(:debug).with("Plist #{plist_path} ill-formatted, converting with plutil")
98
+ expect(Puppet::Util::Execution).to receive(:execute)
96
99
  .with(['/usr/bin/plutil', '-convert', 'xml1', '-o', '-', plist_path],
97
100
  {:failonfail => true, :combine => true})
98
- .returns(Puppet::Util::Execution::ProcessOutput.new(valid_xml_plist, 0))
101
+ .and_return(Puppet::Util::Execution::ProcessOutput.new(valid_xml_plist, 0))
99
102
  expect(subject.read_plist_file(plist_path)).to eq(valid_xml_plist_hash)
100
103
  end
104
+
101
105
  it "returns nil when direct parsing and plutil conversion both fail" do
102
- subject.stubs(:read_file_with_offset).with(plist_path, 8).returns('notbinary')
103
- subject.stubs(:open_file_with_args).with(plist_path, 'r:UTF-8').returns(non_plist_data)
104
- Puppet.expects(:debug).with(regexp_matches(/^Failed with (CFFormatError|NoMethodError)/))
105
- Puppet.expects(:debug).with("Plist #{plist_path} ill-formatted, converting with plutil")
106
- Puppet::Util::Execution.expects(:execute)
106
+ allow(subject).to receive(:read_file_with_offset).with(plist_path, 8).and_return('notbinary')
107
+ allow(subject).to receive(:open_file_with_args).with(plist_path, 'r:UTF-8').and_return(non_plist_data)
108
+ expect(Puppet).to receive(:debug).with(/^Failed with (CFFormatError|NoMethodError)/)
109
+ expect(Puppet).to receive(:debug).with("Plist #{plist_path} ill-formatted, converting with plutil")
110
+ expect(Puppet::Util::Execution).to receive(:execute)
107
111
  .with(['/usr/bin/plutil', '-convert', 'xml1', '-o', '-', plist_path],
108
112
  {:failonfail => true, :combine => true})
109
- .raises(Puppet::ExecutionFailure, 'boom')
113
+ .and_raise(Puppet::ExecutionFailure, 'boom')
110
114
  expect(subject.read_plist_file(plist_path)).to eq(nil)
111
115
  end
116
+
112
117
  it "returns nil when file is a non-plist binary blob" do
113
- subject.stubs(:read_file_with_offset).with(plist_path, 8).returns('notbinary')
114
- subject.stubs(:open_file_with_args).with(plist_path, 'r:UTF-8').returns(binary_data)
115
- Puppet.expects(:debug).with(regexp_matches(/^Failed with (CFFormatError|ArgumentError)/))
116
- Puppet.expects(:debug).with("Plist #{plist_path} ill-formatted, converting with plutil")
117
- Puppet::Util::Execution.expects(:execute)
118
+ allow(subject).to receive(:read_file_with_offset).with(plist_path, 8).and_return('notbinary')
119
+ allow(subject).to receive(:open_file_with_args).with(plist_path, 'r:UTF-8').and_return(binary_data)
120
+ expect(Puppet).to receive(:debug).with(/^Failed with (CFFormatError|ArgumentError)/)
121
+ expect(Puppet).to receive(:debug).with("Plist #{plist_path} ill-formatted, converting with plutil")
122
+ expect(Puppet::Util::Execution).to receive(:execute)
118
123
  .with(['/usr/bin/plutil', '-convert', 'xml1', '-o', '-', plist_path],
119
124
  {:failonfail => true, :combine => true})
120
- .raises(Puppet::ExecutionFailure, 'boom')
125
+ .and_raise(Puppet::ExecutionFailure, 'boom')
121
126
  expect(subject.read_plist_file(plist_path)).to eq(nil)
122
127
  end
123
128
  end
@@ -126,15 +131,17 @@ describe Puppet::Util::Plist, :if => Puppet.features.cfpropertylist? do
126
131
  it "returns a valid hash when a valid XML plist is provided" do
127
132
  expect(subject.parse_plist(valid_xml_plist)).to eq(valid_xml_plist_hash)
128
133
  end
134
+
129
135
  it "raises a debug message and replaces a bad XML plist doctype should one be encountered" do
130
- subject.expects(:new_cfpropertylist).with({:data => good_xml_doctype}).returns('plist_object')
131
- subject.stubs(:convert_cfpropertylist_to_native_types).with('plist_object')
132
- Puppet.expects(:debug).with("Had to fix plist with incorrect DOCTYPE declaration: #{plist_path}")
136
+ expect(subject).to receive(:new_cfpropertylist).with({:data => good_xml_doctype}).and_return('plist_object')
137
+ allow(subject).to receive(:convert_cfpropertylist_to_native_types).with('plist_object')
138
+ expect(Puppet).to receive(:debug).with("Had to fix plist with incorrect DOCTYPE declaration: #{plist_path}")
133
139
  subject.parse_plist(bad_xml_doctype, plist_path)
134
140
  end
141
+
135
142
  it "raises a debug message with malformed plist" do
136
- subject.stubs(:convert_cfpropertylist_to_native_types).with('plist_object')
137
- Puppet.expects(:debug).with(regexp_matches(/^Failed with CFFormatError/))
143
+ allow(subject).to receive(:convert_cfpropertylist_to_native_types).with('plist_object')
144
+ expect(Puppet).to receive(:debug).with(/^Failed with CFFormatError/)
138
145
  subject.parse_plist("<plist><dict><key>Foo</key>")
139
146
  end
140
147
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/util/posix'
@@ -21,16 +20,20 @@ describe Puppet::Util::POSIX do
21
20
  ['group3', ['user1']],
22
21
  ['group4', ['user2']]
23
22
  ].map do |(name, members)|
24
- group_struct = stub("Group #{name}")
25
- group_struct.stubs(:name).returns(name)
26
- group_struct.stubs(:mem).returns(members)
23
+ group_struct = double("Group #{name}")
24
+ allow(group_struct).to receive(:name).and_return(name)
25
+ allow(group_struct).to receive(:mem).and_return(members)
27
26
 
28
27
  group_struct
29
28
  end
30
29
  end
31
30
 
32
31
  before(:each) do
33
- Puppet::Etc.stubs(:group).multiple_yields(*mock_groups)
32
+ etc_stub = receive(:group)
33
+ mock_groups.each do |mock_group|
34
+ etc_stub = etc_stub.and_yield(mock_group)
35
+ end
36
+ allow(Puppet::Etc).to etc_stub
34
37
  end
35
38
 
36
39
  it 'returns the groups of the given user' do
@@ -70,7 +73,7 @@ describe Puppet::Util::POSIX do
70
73
 
71
74
  describe "when retrieving a posix field" do
72
75
  before do
73
- @thing = stub 'thing', :field => "asdf"
76
+ @thing = double('thing', :field => "asdf")
74
77
  end
75
78
 
76
79
  it "should fail if no id was passed" do
@@ -80,23 +83,23 @@ describe Puppet::Util::POSIX do
80
83
  describe "and the id is an integer" do
81
84
  it "should log an error and return nil if the specified id is greater than the maximum allowed ID" do
82
85
  Puppet[:maximum_uid] = 100
83
- Puppet.expects(:err)
86
+ expect(Puppet).to receive(:err)
84
87
 
85
88
  expect(@posix.get_posix_field("asdf", "bar", 200)).to be_nil
86
89
  end
87
90
 
88
91
  it "should use the method return by :methodbyid and return the specified field" do
89
- Etc.expects(:getgrgid).returns @thing
92
+ expect(Etc).to receive(:getgrgid).and_return(@thing)
90
93
 
91
- @thing.expects(:field).returns "myval"
94
+ expect(@thing).to receive(:field).and_return("myval")
92
95
 
93
96
  expect(@posix.get_posix_field(:gr, :field, 200)).to eq("myval")
94
97
  end
95
98
 
96
99
  it "should return nil if the method throws an exception" do
97
- Etc.expects(:getgrgid).raises ArgumentError
100
+ expect(Etc).to receive(:getgrgid).and_raise(ArgumentError)
98
101
 
99
- @thing.expects(:field).never
102
+ expect(@thing).not_to receive(:field)
100
103
 
101
104
  expect(@posix.get_posix_field(:gr, :field, 200)).to be_nil
102
105
  end
@@ -104,17 +107,17 @@ describe Puppet::Util::POSIX do
104
107
 
105
108
  describe "and the id is not an integer" do
106
109
  it "should use the method return by :methodbyid and return the specified field" do
107
- Etc.expects(:getgrnam).returns @thing
110
+ expect(Etc).to receive(:getgrnam).and_return(@thing)
108
111
 
109
- @thing.expects(:field).returns "myval"
112
+ expect(@thing).to receive(:field).and_return("myval")
110
113
 
111
114
  expect(@posix.get_posix_field(:gr, :field, "asdf")).to eq("myval")
112
115
  end
113
116
 
114
117
  it "should return nil if the method throws an exception" do
115
- Etc.expects(:getgrnam).raises ArgumentError
118
+ expect(Etc).to receive(:getgrnam).and_raise(ArgumentError)
116
119
 
117
- @thing.expects(:field).never
120
+ expect(@thing).not_to receive(:field)
118
121
 
119
122
  expect(@posix.get_posix_field(:gr, :field, "asdf")).to be_nil
120
123
  end
@@ -123,32 +126,32 @@ describe Puppet::Util::POSIX do
123
126
 
124
127
  describe "when returning the gid" do
125
128
  before do
126
- @posix.stubs(:get_posix_field)
129
+ allow(@posix).to receive(:get_posix_field)
127
130
  end
128
131
 
129
132
  describe "and the group is an integer" do
130
133
  it "should convert integers specified as a string into an integer" do
131
- @posix.expects(:get_posix_field).with(:group, :name, 100)
134
+ expect(@posix).to receive(:get_posix_field).with(:group, :name, 100)
132
135
 
133
136
  @posix.gid("100")
134
137
  end
135
138
 
136
139
  it "should look up the name for the group" do
137
- @posix.expects(:get_posix_field).with(:group, :name, 100)
140
+ expect(@posix).to receive(:get_posix_field).with(:group, :name, 100)
138
141
 
139
142
  @posix.gid(100)
140
143
  end
141
144
 
142
145
  it "should return nil if the group cannot be found" do
143
- @posix.expects(:get_posix_field).once.returns nil
144
- @posix.expects(:search_posix_field).never
146
+ expect(@posix).to receive(:get_posix_field).once.and_return(nil)
147
+ expect(@posix).not_to receive(:search_posix_field)
145
148
 
146
149
  expect(@posix.gid(100)).to be_nil
147
150
  end
148
151
 
149
152
  it "should use the found name to look up the id" do
150
- @posix.expects(:get_posix_field).with(:group, :name, 100).returns "asdf"
151
- @posix.expects(:get_posix_field).with(:group, :gid, "asdf").returns 100
153
+ expect(@posix).to receive(:get_posix_field).with(:group, :name, 100).and_return("asdf")
154
+ expect(@posix).to receive(:get_posix_field).with(:group, :gid, "asdf").and_return(100)
152
155
 
153
156
  expect(@posix.gid(100)).to eq(100)
154
157
  end
@@ -156,10 +159,10 @@ describe Puppet::Util::POSIX do
156
159
  # LAK: This is because some platforms have a broken Etc module that always return
157
160
  # the same group.
158
161
  it "should use :search_posix_field if the discovered id does not match the passed-in id" do
159
- @posix.expects(:get_posix_field).with(:group, :name, 100).returns "asdf"
160
- @posix.expects(:get_posix_field).with(:group, :gid, "asdf").returns 50
162
+ expect(@posix).to receive(:get_posix_field).with(:group, :name, 100).and_return("asdf")
163
+ expect(@posix).to receive(:get_posix_field).with(:group, :gid, "asdf").and_return(50)
161
164
 
162
- @posix.expects(:search_posix_field).with(:group, :gid, 100).returns "asdf"
165
+ expect(@posix).to receive(:search_posix_field).with(:group, :gid, 100).and_return("asdf")
163
166
 
164
167
  expect(@posix.gid(100)).to eq("asdf")
165
168
  end
@@ -167,30 +170,30 @@ describe Puppet::Util::POSIX do
167
170
 
168
171
  describe "and the group is a string" do
169
172
  it "should look up the gid for the group" do
170
- @posix.expects(:get_posix_field).with(:group, :gid, "asdf")
173
+ expect(@posix).to receive(:get_posix_field).with(:group, :gid, "asdf")
171
174
 
172
175
  @posix.gid("asdf")
173
176
  end
174
177
 
175
178
  it "should return nil if the group cannot be found" do
176
- @posix.expects(:get_posix_field).once.returns nil
177
- @posix.expects(:search_posix_field).never
179
+ expect(@posix).to receive(:get_posix_field).once.and_return(nil)
180
+ expect(@posix).not_to receive(:search_posix_field)
178
181
 
179
182
  expect(@posix.gid("asdf")).to be_nil
180
183
  end
181
184
 
182
185
  it "should use the found gid to look up the nam" do
183
- @posix.expects(:get_posix_field).with(:group, :gid, "asdf").returns 100
184
- @posix.expects(:get_posix_field).with(:group, :name, 100).returns "asdf"
186
+ expect(@posix).to receive(:get_posix_field).with(:group, :gid, "asdf").and_return(100)
187
+ expect(@posix).to receive(:get_posix_field).with(:group, :name, 100).and_return("asdf")
185
188
 
186
189
  expect(@posix.gid("asdf")).to eq(100)
187
190
  end
188
191
 
189
192
  it "should use :search_posix_field if the discovered name does not match the passed-in name" do
190
- @posix.expects(:get_posix_field).with(:group, :gid, "asdf").returns 100
191
- @posix.expects(:get_posix_field).with(:group, :name, 100).returns "boo"
193
+ expect(@posix).to receive(:get_posix_field).with(:group, :gid, "asdf").and_return(100)
194
+ expect(@posix).to receive(:get_posix_field).with(:group, :name, 100).and_return("boo")
192
195
 
193
- @posix.expects(:search_posix_field).with(:group, :gid, "asdf").returns "asdf"
196
+ expect(@posix).to receive(:search_posix_field).with(:group, :gid, "asdf").and_return("asdf")
194
197
 
195
198
  expect(@posix.gid("asdf")).to eq("asdf")
196
199
  end
@@ -199,32 +202,32 @@ describe Puppet::Util::POSIX do
199
202
 
200
203
  describe "when returning the uid" do
201
204
  before do
202
- @posix.stubs(:get_posix_field)
205
+ allow(@posix).to receive(:get_posix_field)
203
206
  end
204
207
 
205
208
  describe "and the group is an integer" do
206
209
  it "should convert integers specified as a string into an integer" do
207
- @posix.expects(:get_posix_field).with(:passwd, :name, 100)
210
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :name, 100)
208
211
 
209
212
  @posix.uid("100")
210
213
  end
211
214
 
212
215
  it "should look up the name for the group" do
213
- @posix.expects(:get_posix_field).with(:passwd, :name, 100)
216
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :name, 100)
214
217
 
215
218
  @posix.uid(100)
216
219
  end
217
220
 
218
221
  it "should return nil if the group cannot be found" do
219
- @posix.expects(:get_posix_field).once.returns nil
220
- @posix.expects(:search_posix_field).never
222
+ expect(@posix).to receive(:get_posix_field).once.and_return(nil)
223
+ expect(@posix).not_to receive(:search_posix_field)
221
224
 
222
225
  expect(@posix.uid(100)).to be_nil
223
226
  end
224
227
 
225
228
  it "should use the found name to look up the id" do
226
- @posix.expects(:get_posix_field).with(:passwd, :name, 100).returns "asdf"
227
- @posix.expects(:get_posix_field).with(:passwd, :uid, "asdf").returns 100
229
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :name, 100).and_return("asdf")
230
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :uid, "asdf").and_return(100)
228
231
 
229
232
  expect(@posix.uid(100)).to eq(100)
230
233
  end
@@ -232,10 +235,10 @@ describe Puppet::Util::POSIX do
232
235
  # LAK: This is because some platforms have a broken Etc module that always return
233
236
  # the same group.
234
237
  it "should use :search_posix_field if the discovered id does not match the passed-in id" do
235
- @posix.expects(:get_posix_field).with(:passwd, :name, 100).returns "asdf"
236
- @posix.expects(:get_posix_field).with(:passwd, :uid, "asdf").returns 50
238
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :name, 100).and_return("asdf")
239
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :uid, "asdf").and_return(50)
237
240
 
238
- @posix.expects(:search_posix_field).with(:passwd, :uid, 100).returns "asdf"
241
+ expect(@posix).to receive(:search_posix_field).with(:passwd, :uid, 100).and_return("asdf")
239
242
 
240
243
  expect(@posix.uid(100)).to eq("asdf")
241
244
  end
@@ -243,30 +246,30 @@ describe Puppet::Util::POSIX do
243
246
 
244
247
  describe "and the group is a string" do
245
248
  it "should look up the uid for the group" do
246
- @posix.expects(:get_posix_field).with(:passwd, :uid, "asdf")
249
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :uid, "asdf")
247
250
 
248
251
  @posix.uid("asdf")
249
252
  end
250
253
 
251
254
  it "should return nil if the group cannot be found" do
252
- @posix.expects(:get_posix_field).once.returns nil
253
- @posix.expects(:search_posix_field).never
255
+ expect(@posix).to receive(:get_posix_field).once.and_return(nil)
256
+ expect(@posix).not_to receive(:search_posix_field)
254
257
 
255
258
  expect(@posix.uid("asdf")).to be_nil
256
259
  end
257
260
 
258
261
  it "should use the found uid to look up the nam" do
259
- @posix.expects(:get_posix_field).with(:passwd, :uid, "asdf").returns 100
260
- @posix.expects(:get_posix_field).with(:passwd, :name, 100).returns "asdf"
262
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :uid, "asdf").and_return(100)
263
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :name, 100).and_return("asdf")
261
264
 
262
265
  expect(@posix.uid("asdf")).to eq(100)
263
266
  end
264
267
 
265
268
  it "should use :search_posix_field if the discovered name does not match the passed-in name" do
266
- @posix.expects(:get_posix_field).with(:passwd, :uid, "asdf").returns 100
267
- @posix.expects(:get_posix_field).with(:passwd, :name, 100).returns "boo"
269
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :uid, "asdf").and_return(100)
270
+ expect(@posix).to receive(:get_posix_field).with(:passwd, :name, 100).and_return("boo")
268
271
 
269
- @posix.expects(:search_posix_field).with(:passwd, :uid, "asdf").returns "asdf"
272
+ expect(@posix).to receive(:search_posix_field).with(:passwd, :uid, "asdf").and_return("asdf")
270
273
 
271
274
  expect(@posix.uid("asdf")).to eq("asdf")
272
275
  end