puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:file).attrclass(:ctime) do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/type/file/ensure'
4
3
 
@@ -15,14 +14,14 @@ describe Puppet::Type::File::Ensure do
15
14
 
16
15
  describe "when retrieving the current state" do
17
16
  it "should return :absent if the file does not exist" do
18
- resource.expects(:stat).returns nil
17
+ expect(resource).to receive(:stat).and_return(nil)
19
18
 
20
19
  expect(property.retrieve).to eq(:absent)
21
20
  end
22
21
 
23
22
  it "should return the current file type if the file exists" do
24
- stat = mock 'stat', :ftype => "directory"
25
- resource.expects(:stat).returns stat
23
+ stat = double('stat', :ftype => "directory")
24
+ expect(resource).to receive(:stat).and_return(stat)
26
25
 
27
26
  expect(property.retrieve).to eq(:directory)
28
27
  end
@@ -31,7 +30,7 @@ describe Puppet::Type::File::Ensure do
31
30
  describe "when testing whether :ensure is in sync" do
32
31
  it "should always be in sync if replace is 'false' unless the file is missing" do
33
32
  property.should = :file
34
- resource.expects(:replace?).returns false
33
+ expect(resource).to receive(:replace?).and_return(false)
35
34
  expect(property.safe_insync?(:link)).to be_truthy
36
35
  end
37
36
 
@@ -89,32 +88,32 @@ describe Puppet::Type::File::Ensure do
89
88
 
90
89
  it "should accept octal mode as fixnum" do
91
90
  resource[:mode] = '0700'
92
- resource.expects(:property_fix)
93
- Dir.expects(:mkdir).with(path, 0700)
91
+ expect(resource).to receive(:property_fix)
92
+ expect(Dir).to receive(:mkdir).with(path, 0700)
94
93
 
95
94
  property.sync
96
95
  end
97
96
 
98
97
  it "should accept octal mode as string" do
99
98
  resource[:mode] = "700"
100
- resource.expects(:property_fix)
101
- Dir.expects(:mkdir).with(path, 0700)
99
+ expect(resource).to receive(:property_fix)
100
+ expect(Dir).to receive(:mkdir).with(path, 0700)
102
101
 
103
102
  property.sync
104
103
  end
105
104
 
106
105
  it "should accept octal mode as string with leading zero" do
107
106
  resource[:mode] = "0700"
108
- resource.expects(:property_fix)
109
- Dir.expects(:mkdir).with(path, 0700)
107
+ expect(resource).to receive(:property_fix)
108
+ expect(Dir).to receive(:mkdir).with(path, 0700)
110
109
 
111
110
  property.sync
112
111
  end
113
112
 
114
113
  it "should accept symbolic mode" do
115
114
  resource[:mode] = "u=rwx,go=x"
116
- resource.expects(:property_fix)
117
- Dir.expects(:mkdir).with(path, 0711)
115
+ expect(resource).to receive(:property_fix)
116
+ expect(Dir).to receive(:mkdir).with(path, 0711)
118
117
 
119
118
  property.sync
120
119
  end
@@ -1,5 +1,3 @@
1
- #! /usr/bin/env ruby
2
-
3
1
  require 'spec_helper'
4
2
 
5
3
  describe Puppet::Type.type(:file).attrclass(:group) do
@@ -19,12 +17,12 @@ describe Puppet::Type.type(:file).attrclass(:group) do
19
17
  before :each do
20
18
  resource[:group] = ['foos', 'bars']
21
19
 
22
- resource.provider.stubs(:name2gid).with('foos').returns 1001
23
- resource.provider.stubs(:name2gid).with('bars').returns 1002
20
+ allow(resource.provider).to receive(:name2gid).with('foos').and_return(1001)
21
+ allow(resource.provider).to receive(:name2gid).with('bars').and_return(1002)
24
22
  end
25
23
 
26
24
  it "should fail if a group's id can't be found by name" do
27
- resource.provider.stubs(:name2gid).returns nil
25
+ allow(resource.provider).to receive(:name2gid).and_return(nil)
28
26
 
29
27
  expect { group.insync?(5) }.to raise_error(/Could not find group foos/)
30
28
  end
@@ -45,13 +43,13 @@ describe Puppet::Type.type(:file).attrclass(:group) do
45
43
  %w[is_to_s should_to_s].each do |prop_to_s|
46
44
  describe "##{prop_to_s}" do
47
45
  it "should use the name of the user if it can find it" do
48
- resource.provider.stubs(:gid2name).with(1001).returns 'foos'
46
+ allow(resource.provider).to receive(:gid2name).with(1001).and_return('foos')
49
47
 
50
48
  expect(group.send(prop_to_s, 1001)).to eq("'foos'")
51
49
  end
52
50
 
53
51
  it "should use the id of the user if it can't" do
54
- resource.provider.stubs(:gid2name).with(1001).returns nil
52
+ allow(resource.provider).to receive(:gid2name).with(1001).and_return(nil)
55
53
 
56
54
  expect(group.send(prop_to_s, 1001)).to eq('1001')
57
55
  end
@@ -1,5 +1,3 @@
1
- #! /usr/bin/env ruby
2
-
3
1
  require 'spec_helper'
4
2
 
5
3
  describe Puppet::Type.type(:file).attrclass(:mode) do
@@ -121,8 +119,8 @@ describe Puppet::Type.type(:file).attrclass(:mode) do
121
119
  it "should retrieve the directory mode from the provider" do
122
120
  Dir.mkdir(path)
123
121
 
124
- mode.expects(:dirmask).with('644').returns '755'
125
- resource.provider.expects(:mode).returns '755'
122
+ expect(mode).to receive(:dirmask).with('644').and_return('755')
123
+ expect(resource.provider).to receive(:mode).and_return('755')
126
124
 
127
125
  expect(mode.retrieve).to eq('755')
128
126
  end
@@ -130,8 +128,8 @@ describe Puppet::Type.type(:file).attrclass(:mode) do
130
128
  it "should retrieve the file mode from the provider" do
131
129
  FileUtils.touch(path)
132
130
 
133
- mode.expects(:dirmask).with('644').returns '644'
134
- resource.provider.expects(:mode).returns '644'
131
+ expect(mode).to receive(:dirmask).with('644').and_return('644')
132
+ expect(resource.provider).to receive(:mode).and_return('644')
135
133
 
136
134
  expect(mode.retrieve).to eq('644')
137
135
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:file).attrclass(:mtime) do
@@ -1,5 +1,3 @@
1
- #! /usr/bin/env ruby
2
-
3
1
  require 'spec_helper'
4
2
 
5
3
  describe Puppet::Type.type(:file).attrclass(:owner) do
@@ -10,19 +8,19 @@ describe Puppet::Type.type(:file).attrclass(:owner) do
10
8
  let(:owner) { resource.property(:owner) }
11
9
 
12
10
  before :each do
13
- Puppet.features.stubs(:root?).returns(true)
11
+ allow(Puppet.features).to receive(:root?).and_return(true)
14
12
  end
15
13
 
16
14
  describe "#insync?" do
17
15
  before :each do
18
16
  resource[:owner] = ['foo', 'bar']
19
17
 
20
- resource.provider.stubs(:name2uid).with('foo').returns 1001
21
- resource.provider.stubs(:name2uid).with('bar').returns 1002
18
+ allow(resource.provider).to receive(:name2uid).with('foo').and_return(1001)
19
+ allow(resource.provider).to receive(:name2uid).with('bar').and_return(1002)
22
20
  end
23
21
 
24
22
  it "should fail if an owner's id can't be found by name" do
25
- resource.provider.stubs(:name2uid).returns nil
23
+ allow(resource.provider).to receive(:name2uid).and_return(nil)
26
24
 
27
25
  expect { owner.insync?(5) }.to raise_error(/Could not find user foo/)
28
26
  end
@@ -43,13 +41,13 @@ describe Puppet::Type.type(:file).attrclass(:owner) do
43
41
  %w[is_to_s should_to_s].each do |prop_to_s|
44
42
  describe "##{prop_to_s}" do
45
43
  it "should use the name of the user if it can find it" do
46
- resource.provider.stubs(:uid2name).with(1001).returns 'foo'
44
+ allow(resource.provider).to receive(:uid2name).with(1001).and_return('foo')
47
45
 
48
46
  expect(owner.send(prop_to_s, 1001)).to eq("'foo'")
49
47
  end
50
48
 
51
49
  it "should use the id of the user if it can't" do
52
- resource.provider.stubs(:uid2name).with(1001).returns nil
50
+ allow(resource.provider).to receive(:uid2name).with(1001).and_return(nil)
53
51
 
54
52
  expect(owner.send(prop_to_s, 1001)).to eq('1001')
55
53
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  [:seluser, :selrole, :seltype, :selrange].each do |param|
@@ -10,26 +9,26 @@ require 'spec_helper'
10
9
  @path = make_absolute("/my/file")
11
10
  @resource = Puppet::Type.type(:file).new :path => @path
12
11
  @sel = property.new :resource => @resource
13
- @sel.stubs(:normalize_selinux_category).with("s0").returns("s0")
14
- @sel.stubs(:normalize_selinux_category).with(nil).returns(nil)
12
+ allow(@sel).to receive(:normalize_selinux_category).with("s0").and_return("s0")
13
+ allow(@sel).to receive(:normalize_selinux_category).with(nil).and_return(nil)
15
14
  end
16
15
 
17
16
  it "retrieve on #{param} should return :absent if the file isn't statable" do
18
- @resource.expects(:stat).returns nil
17
+ expect(@resource).to receive(:stat).and_return(nil)
19
18
  expect(@sel.retrieve).to eq(:absent)
20
19
  end
21
20
 
22
21
  it "should retrieve nil for #{param} if there is no SELinux support" do
23
- stat = stub 'stat', :ftype => "foo"
24
- @resource.expects(:stat).returns stat
25
- @sel.expects(:get_selinux_current_context).with(@path).returns nil
22
+ stat = double('stat', :ftype => "foo")
23
+ expect(@resource).to receive(:stat).and_return(stat)
24
+ expect(@sel).to receive(:get_selinux_current_context).with(@path).and_return(nil)
26
25
  expect(@sel.retrieve).to be_nil
27
26
  end
28
27
 
29
28
  it "should retrieve #{param} if a SELinux context is found with a range" do
30
- stat = stub 'stat', :ftype => "foo"
31
- @resource.expects(:stat).returns stat
32
- @sel.expects(:get_selinux_current_context).with(@path).returns "user_u:role_r:type_t:s0"
29
+ stat = double('stat', :ftype => "foo")
30
+ expect(@resource).to receive(:stat).and_return(stat)
31
+ expect(@sel).to receive(:get_selinux_current_context).with(@path).and_return("user_u:role_r:type_t:s0")
33
32
  expectedresult = case param
34
33
  when :seluser; "user_u"
35
34
  when :selrole; "role_r"
@@ -40,9 +39,9 @@ require 'spec_helper'
40
39
  end
41
40
 
42
41
  it "should retrieve #{param} if a SELinux context is found without a range" do
43
- stat = stub 'stat', :ftype => "foo"
44
- @resource.expects(:stat).returns stat
45
- @sel.expects(:get_selinux_current_context).with(@path).returns "user_u:role_r:type_t"
42
+ stat = double('stat', :ftype => "foo")
43
+ expect(@resource).to receive(:stat).and_return(stat)
44
+ expect(@sel).to receive(:get_selinux_current_context).with(@path).and_return("user_u:role_r:type_t")
46
45
  expectedresult = case param
47
46
  when :seluser; "user_u"
48
47
  when :selrole; "role_r"
@@ -53,13 +52,13 @@ require 'spec_helper'
53
52
  end
54
53
 
55
54
  it "should handle no default gracefully" do
56
- @sel.expects(:get_selinux_default_context).with(@path).returns nil
55
+ expect(@sel).to receive(:get_selinux_default_context).with(@path).and_return(nil)
57
56
  expect(@sel.default).to be_nil
58
57
  end
59
58
 
60
59
  it "should be able to detect matchpathcon defaults" do
61
- @sel.stubs(:debug)
62
- @sel.expects(:get_selinux_default_context).with(@path).returns "user_u:role_r:type_t:s0"
60
+ allow(@sel).to receive(:debug)
61
+ expect(@sel).to receive(:get_selinux_default_context).with(@path).and_return("user_u:role_r:type_t:s0")
63
62
  expectedresult = case param
64
63
  when :seluser; "user_u"
65
64
  when :selrole; "role_r"
@@ -76,15 +75,14 @@ require 'spec_helper'
76
75
 
77
76
  it "should be able to set a new context" do
78
77
  @sel.should = %w{newone}
79
- @sel.expects(:set_selinux_context).with(@path, ["newone"], param)
78
+ expect(@sel).to receive(:set_selinux_context).with(@path, ["newone"], param)
80
79
  @sel.sync
81
80
  end
82
81
 
83
82
  it "should do nothing for safe_insync? if no SELinux support" do
84
83
  @sel.should = %{newcontext}
85
- @sel.expects(:selinux_support?).returns false
84
+ expect(@sel).to receive(:selinux_support?).and_return(false)
86
85
  expect(@sel.safe_insync?("oldcontext")).to eq(true)
87
86
  end
88
87
  end
89
88
  end
90
-
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'uri'
4
3
  require 'puppet/network/http_pool'
@@ -33,7 +32,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
33
32
 
34
33
  describe "#validate" do
35
34
  it "should fail if the set values are not URLs" do
36
- URI.expects(:parse).with('foo').raises RuntimeError
35
+ expect(URI).to receive(:parse).with('foo').and_raise(RuntimeError)
37
36
 
38
37
  expect(lambda { resource[:source] = %w{foo} }).to raise_error(Puppet::Error)
39
38
  end
@@ -96,10 +95,10 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
96
95
 
97
96
  describe "when returning the metadata" do
98
97
  before do
99
- @metadata = stub 'metadata', :source= => nil
100
- resource.stubs(:[]).with(:links).returns :manage
101
- resource.stubs(:[]).with(:source_permissions).returns :use
102
- resource.stubs(:[]).with(:checksum).returns :checksum
98
+ @metadata = double('metadata', :source= => nil)
99
+ allow(resource).to receive(:[]).with(:links).and_return(:manage)
100
+ allow(resource).to receive(:[]).with(:source_permissions).and_return(:use)
101
+ allow(resource).to receive(:[]).with(:checksum).and_return(:checksum)
103
102
  end
104
103
 
105
104
  it "should return already-available metadata" do
@@ -115,18 +114,20 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
115
114
 
116
115
  it "should collect its metadata using the Metadata class if it is not already set" do
117
116
  @source = described_class.new(:resource => resource, :value => @foobar)
118
- Puppet::FileServing::Metadata.indirection.expects(:find).with do |uri, options|
119
- expect(uri).to eq @foobar_uri
120
- expect(options[:environment]).to eq environment
121
- expect(options[:links]).to eq :manage
122
- expect(options[:checksum_type]).to eq :checksum
123
- end.returns @metadata
117
+ expect(Puppet::FileServing::Metadata.indirection).to receive(:find) do |uri, options|
118
+ expect(uri).to eq(@foobar_uri)
119
+ expect(options[:environment]).to eq(environment)
120
+ expect(options[:links]).to eq(:manage)
121
+ expect(options[:checksum_type]).to eq(:checksum)
122
+
123
+ @metadata
124
+ end
124
125
 
125
126
  @source.metadata
126
127
  end
127
128
 
128
129
  it "should use the metadata from the first found source" do
129
- metadata = stub 'metadata', :source= => nil
130
+ metadata = double('metadata', :source= => nil)
130
131
  @source = described_class.new(:resource => resource, :value => [@foobar, @feebooz])
131
132
  options = {
132
133
  :environment => environment,
@@ -134,48 +135,52 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
134
135
  :source_permissions => :use,
135
136
  :checksum_type => :checksum
136
137
  }
137
- Puppet::FileServing::Metadata.indirection.expects(:find).with(@foobar_uri, options).returns nil
138
- Puppet::FileServing::Metadata.indirection.expects(:find).with(@feebooz_uri, options).returns metadata
138
+ expect(Puppet::FileServing::Metadata.indirection).to receive(:find).with(@foobar_uri, options).and_return(nil)
139
+ expect(Puppet::FileServing::Metadata.indirection).to receive(:find).with(@feebooz_uri, options).and_return(metadata)
139
140
  expect(@source.metadata).to equal(metadata)
140
141
  end
141
142
 
142
143
  it "should store the found source as the metadata's source" do
143
- metadata = mock 'metadata'
144
+ metadata = double('metadata')
144
145
  @source = described_class.new(:resource => resource, :value => @foobar)
145
- Puppet::FileServing::Metadata.indirection.expects(:find).with do |uri, options|
146
- expect(uri).to eq @foobar_uri
147
- expect(options[:environment]).to eq environment
148
- expect(options[:links]).to eq :manage
149
- expect(options[:checksum_type]).to eq :checksum
150
- end.returns metadata
151
-
152
- metadata.expects(:source=).with(@foobar_uri)
146
+ expect(Puppet::FileServing::Metadata.indirection).to receive(:find) do |uri, options|
147
+ expect(uri).to eq(@foobar_uri)
148
+ expect(options[:environment]).to eq(environment)
149
+ expect(options[:links]).to eq(:manage)
150
+ expect(options[:checksum_type]).to eq(:checksum)
151
+
152
+ metadata
153
+ end
154
+
155
+ expect(metadata).to receive(:source=).with(@foobar_uri)
153
156
  @source.metadata
154
157
  end
155
158
 
156
159
  it "should fail intelligently if an exception is encountered while querying for metadata" do
157
160
  @source = described_class.new(:resource => resource, :value => @foobar)
158
- Puppet::FileServing::Metadata.indirection.expects(:find).with do |uri, options|
159
- expect(uri).to eq @foobar_uri
160
- expect(options[:environment]).to eq environment
161
- expect(options[:links]).to eq :manage
162
- expect(options[:checksum_type]).to eq :checksum
163
- end.raises RuntimeError
164
-
165
- @source.expects(:fail).raises ArgumentError
161
+ expect(Puppet::FileServing::Metadata.indirection).to receive(:find) do |uri, options|
162
+ expect(uri).to eq(@foobar_uri)
163
+ expect(options[:environment]).to eq(environment)
164
+ expect(options[:links]).to eq(:manage)
165
+ expect(options[:checksum_type]).to eq(:checksum)
166
+ end.and_raise(RuntimeError)
167
+
168
+ expect(@source).to receive(:fail).and_raise(ArgumentError)
166
169
  expect { @source.metadata }.to raise_error(ArgumentError)
167
170
  end
168
171
 
169
172
  it "should fail if no specified sources can be found" do
170
173
  @source = described_class.new(:resource => resource, :value => @foobar)
171
- Puppet::FileServing::Metadata.indirection.expects(:find).with do |uri, options|
172
- expect(uri).to eq @foobar_uri
173
- expect(options[:environment]).to eq environment
174
- expect(options[:links]).to eq :manage
175
- expect(options[:checksum_type]).to eq :checksum
176
- end.returns nil
174
+ expect(Puppet::FileServing::Metadata.indirection).to receive(:find) do |uri, options|
175
+ expect(uri).to eq(@foobar_uri)
176
+ expect(options[:environment]).to eq(environment)
177
+ expect(options[:links]).to eq(:manage)
178
+ expect(options[:checksum_type]).to eq(:checksum)
179
+
180
+ nil
181
+ end
177
182
 
178
- @source.expects(:fail).raises RuntimeError
183
+ expect(@source).to receive(:fail).and_raise(RuntimeError)
179
184
 
180
185
  expect { @source.metadata }.to raise_error(RuntimeError)
181
186
  end
@@ -186,24 +191,23 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
186
191
  end
187
192
 
188
193
  describe "when copying the source values" do
189
-
190
194
  before do
191
- Puppet::Type.type(:file).any_instance.stubs(:file).returns('my/file.pp')
192
- Puppet::Type.type(:file).any_instance.stubs(:line).returns 5
195
+ allow_any_instance_of(Puppet::Type.type(:file)).to receive(:file).and_return('my/file.pp')
196
+ allow_any_instance_of(Puppet::Type.type(:file)).to receive(:line).and_return(5)
193
197
  end
194
198
 
195
199
  before :each do
196
200
  @resource = Puppet::Type.type(:file).new :path => @foobar
197
201
 
198
202
  @source = described_class.new(:resource => @resource)
199
- @metadata = stub 'metadata', :owner => 100, :group => 200, :mode => "173", :checksum => "{md5}asdfasdf", :checksum_type => "md5", :ftype => "file", :source => @foobar
200
- @source.stubs(:metadata).returns @metadata
203
+ @metadata = double('metadata', :owner => 100, :group => 200, :mode => "173", :checksum => "{md5}asdfasdf", :checksum_type => "md5", :ftype => "file", :source => @foobar)
204
+ allow(@source).to receive(:metadata).and_return(@metadata)
201
205
 
202
- Puppet.features.stubs(:root?).returns true
206
+ allow(Puppet.features).to receive(:root?).and_return(true)
203
207
  end
204
208
 
205
209
  it "should not issue an error - except on Windows - if the source mode value is a Numeric" do
206
- @metadata.stubs(:mode).returns 0173
210
+ allow(@metadata).to receive(:mode).and_return(0173)
207
211
  @resource[:source_permissions] = :use
208
212
  if Puppet::Util::Platform.windows?
209
213
  expect { @source.copy_source_values }.to raise_error("Should not have tried to use source owner/mode/group on Windows (file: my/file.pp, line: 5)")
@@ -213,7 +217,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
213
217
  end
214
218
 
215
219
  it "should not issue an error - except on Windows - if the source mode value is a String" do
216
- @metadata.stubs(:mode).returns "173"
220
+ allow(@metadata).to receive(:mode).and_return("173")
217
221
  @resource[:source_permissions] = :use
218
222
  if Puppet::Util::Platform.windows?
219
223
  expect { @source.copy_source_values }.to raise_error("Should not have tried to use source owner/mode/group on Windows (file: my/file.pp, line: 5)")
@@ -223,20 +227,20 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
223
227
  end
224
228
 
225
229
  it "should fail if there is no metadata" do
226
- @source.stubs(:metadata).returns nil
227
- @source.expects(:devfail).raises ArgumentError
230
+ allow(@source).to receive(:metadata).and_return(nil)
231
+ expect(@source).to receive(:devfail).and_raise(ArgumentError)
228
232
  expect { @source.copy_source_values }.to raise_error(ArgumentError)
229
233
  end
230
234
 
231
235
  it "should set :ensure to the file type" do
232
- @metadata.stubs(:ftype).returns "file"
236
+ allow(@metadata).to receive(:ftype).and_return("file")
233
237
 
234
238
  @source.copy_source_values
235
239
  expect(@resource[:ensure]).to eq(:file)
236
240
  end
237
241
 
238
242
  it "should not set 'ensure' if it is already set to 'absent'" do
239
- @metadata.stubs(:ftype).returns "file"
243
+ allow(@metadata).to receive(:ftype).and_return("file")
240
244
 
241
245
  @resource[:ensure] = :absent
242
246
  @source.copy_source_values
@@ -245,8 +249,8 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
245
249
 
246
250
  describe "and the source is a file" do
247
251
  before do
248
- @metadata.stubs(:ftype).returns "file"
249
- Puppet.features.stubs(:microsoft_windows?).returns false
252
+ allow(@metadata).to receive(:ftype).and_return("file")
253
+ allow(Puppet.features).to receive(:microsoft_windows?).and_return(false)
250
254
  end
251
255
 
252
256
  context "when source_permissions is `use`" do
@@ -284,7 +288,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
284
288
 
285
289
  describe "and puppet is not running as root" do
286
290
  before do
287
- Puppet.features.stubs(:root?).returns false
291
+ allow(Puppet.features).to receive(:root?).and_return(false)
288
292
  end
289
293
 
290
294
  it "should not try to set the owner" do
@@ -302,13 +306,13 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
302
306
  context "when source_permissions is `use_when_creating`" do
303
307
  before :each do
304
308
  @resource[:source_permissions] = "use_when_creating"
305
- Puppet.features.expects(:root?).returns true
306
- @source.stubs(:local?).returns(false)
309
+ expect(Puppet.features).to receive(:root?).and_return(true)
310
+ allow(@source).to receive(:local?).and_return(false)
307
311
  end
308
312
 
309
313
  context "when managing a new file" do
310
314
  it "should copy owner and group from local sources" do
311
- @source.stubs(:local?).returns true
315
+ allow(@source).to receive(:local?).and_return(true)
312
316
 
313
317
  @source.copy_source_values
314
318
 
@@ -338,11 +342,11 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
338
342
 
339
343
  context "when managing an existing file" do
340
344
  before :each do
341
- Puppet::FileSystem.stubs(:exist?).with(@resource[:path]).returns(true)
345
+ allow(Puppet::FileSystem).to receive(:exist?).with(@resource[:path]).and_return(true)
342
346
  end
343
347
 
344
348
  it "should not copy owner, group or mode from local sources" do
345
- @source.stubs(:local?).returns true
349
+ allow(@source).to receive(:local?).and_return(true)
346
350
 
347
351
  @source.copy_source_values
348
352
 
@@ -373,12 +377,12 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
373
377
 
374
378
  context "when source_permissions is default" do
375
379
  before :each do
376
- @source.stubs(:local?).returns(false)
377
- Puppet.features.expects(:root?).returns true
380
+ allow(@source).to receive(:local?).and_return(false)
381
+ expect(Puppet.features).to receive(:root?).and_return(true)
378
382
  end
379
383
 
380
384
  it "should not copy owner, group or mode from local sources" do
381
- @source.stubs(:local?).returns true
385
+ allow(@source).to receive(:local?).and_return(true)
382
386
 
383
387
  @source.copy_source_values
384
388
 
@@ -409,19 +413,19 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
409
413
 
410
414
  describe "and the source is a link" do
411
415
  before do
412
- Puppet.features.stubs(:microsoft_windows?).returns false
416
+ allow(Puppet.features).to receive(:microsoft_windows?).and_return(false)
413
417
  end
414
418
 
415
419
  it "should set the target to the link destination" do
416
- @metadata.stubs(:ftype).returns "link"
417
- @metadata.stubs(:links).returns "manage"
418
- @metadata.stubs(:checksum_type).returns nil
419
- @resource.stubs(:[])
420
- @resource.stubs(:[]=)
420
+ allow(@metadata).to receive(:ftype).and_return("link")
421
+ allow(@metadata).to receive(:links).and_return("manage")
422
+ allow(@metadata).to receive(:checksum_type).and_return(nil)
423
+ allow(@resource).to receive(:[])
424
+ allow(@resource).to receive(:[]=)
421
425
 
422
- @metadata.expects(:destination).returns "/path/to/symlink"
426
+ expect(@metadata).to receive(:destination).and_return("/path/to/symlink")
423
427
 
424
- @resource.expects(:[]=).with(:target, "/path/to/symlink")
428
+ expect(@resource).to receive(:[]=).with(:target, "/path/to/symlink")
425
429
  @source.copy_source_values
426
430
  end
427
431
  end
@@ -484,11 +488,10 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
484
488
 
485
489
  before(:each) do
486
490
  metadata = Puppet::FileServing::Metadata.new(path, :source => uri, 'type' => 'file')
487
- #metadata = stub('remote', :ftype => "file", :source => uri)
488
- Puppet::FileServing::Metadata.indirection.stubs(:find).
489
- with(uri,all_of(has_key(:environment), has_key(:links))).returns metadata
490
- Puppet::FileServing::Metadata.indirection.stubs(:find).
491
- with(uri,all_of(has_key(:environment), has_key(:links))).returns metadata
491
+ allow(Puppet::FileServing::Metadata.indirection).to receive(:find).
492
+ with(uri, include(:environment, :links)).and_return(metadata)
493
+ allow(Puppet::FileServing::Metadata.indirection).to receive(:find).
494
+ with(uri, include(:environment, :links)).and_return(metadata)
492
495
  resource[:source] = uri
493
496
  end
494
497
 
@@ -581,52 +584,52 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
581
584
  describe 'from remote source' do
582
585
  let(:source_content) { "source file content\n"*10 }
583
586
  let(:source) { resource.newattr(:source) }
584
- let(:response) { stub_everything('response') }
585
- let(:conn) { mock('connection') }
587
+ let(:response) { double('response', :[] => nil, :body => nil, :message => nil) }
588
+ let(:conn) { double('connection') }
586
589
 
587
590
  before do
588
591
  resource[:backup] = false
589
592
 
590
- response.stubs(:read_body).multiple_yields(*source_content.lines)
591
- conn.stubs(:request_get).yields(response)
593
+ expectation = receive(:read_body)
594
+ source_content.lines.each { |line| expectation = expectation.and_yield(line) }
595
+ allow(response).to expectation
596
+ allow(conn).to receive(:request_get).and_yield(response)
592
597
  end
593
598
 
594
599
  it 'should use an explicit fileserver if source starts with puppet://' do
595
- response.stubs(:code).returns('200')
596
- source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet://somehostname/test/foo', :ftype => 'file')
597
- Puppet::Network::HttpPool.expects(:http_instance).with('somehostname', anything).returns(conn)
600
+ allow(response).to receive(:code).and_return('200')
601
+ allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet://somehostname/test/foo', :ftype => 'file', :content_uri => nil))
602
+ expect(Puppet::Network::HttpPool).to receive(:http_instance).with('somehostname', anything).and_return(conn)
598
603
 
599
604
  resource.write(source)
600
605
  end
601
606
 
602
607
  it 'should use the default fileserver if source starts with puppet:///' do
603
- response.stubs(:code).returns('200')
604
- source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo', :ftype => 'file')
605
- Puppet::Network::HttpPool.expects(:http_instance).with(Puppet.settings[:server], anything).returns(conn)
608
+ allow(response).to receive(:code).and_return('200')
609
+ allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo', :ftype => 'file', :content_uri => nil))
610
+ expect(Puppet::Network::HttpPool).to receive(:http_instance).with(Puppet.settings[:server], anything).and_return(conn)
606
611
 
607
612
  resource.write(source)
608
613
  end
609
614
 
610
615
  it 'should percent encode reserved characters' do
611
- response.stubs(:code).returns('200')
612
- Puppet::Network::HttpPool.stubs(:http_instance).returns(conn)
613
- source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file')
616
+ allow(response).to receive(:code).and_return('200')
617
+ allow(Puppet::Network::HttpPool).to receive(:http_instance).and_return(conn)
618
+ allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file', :content_uri => nil))
614
619
 
615
- conn.unstub(:request_get)
616
- conn.expects(:request_get).with("#{Puppet::Network::HTTP::MASTER_URL_PREFIX}/v3/file_content/test/foo%20bar?environment=myenv&", anything).yields(response)
620
+ expect(conn).to receive(:request_get).with("#{Puppet::Network::HTTP::MASTER_URL_PREFIX}/v3/file_content/test/foo%20bar?environment=myenv&", anything).and_yield(response)
617
621
 
618
622
  resource.write(source)
619
623
  end
620
624
 
621
625
  it 'should request binary content' do
622
- response.stubs(:code).returns('200')
623
- Puppet::Network::HttpPool.stubs(:http_instance).returns(conn)
624
- source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file')
626
+ allow(response).to receive(:code).and_return('200')
627
+ allow(Puppet::Network::HttpPool).to receive(:http_instance).and_return(conn)
628
+ allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file', :content_uri => nil))
625
629
 
626
- conn.unstub(:request_get)
627
- conn.expects(:request_get).with do |_, options|
630
+ expect(conn).to receive(:request_get) do |_, options|
628
631
  expect(options).to include('Accept' => 'application/octet-stream')
629
- end.yields(response)
632
+ end.and_yield(response)
630
633
 
631
634
  resource.write(source)
632
635
  end
@@ -637,25 +640,25 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
637
640
  end
638
641
 
639
642
  before(:each) do
640
- Puppet::Network::HttpPool.stubs(:http_instance).returns(conn)
641
- source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo', :ftype => 'file')
643
+ allow(Puppet::Network::HttpPool).to receive(:http_instance).and_return(conn)
644
+ allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo', :ftype => 'file', :content_uri => nil))
642
645
  end
643
646
 
644
647
  it 'should not write anything if source is not found' do
645
- response.stubs(:code).returns('404')
648
+ allow(response).to receive(:code).and_return('404')
646
649
 
647
650
  expect { resource.write(source) }.to raise_error(Net::HTTPError, /404/)
648
651
  expect(File.read(filename)).to eq('initial file content')
649
652
  end
650
653
 
651
654
  it 'should raise an HTTP error in case of server error' do
652
- response.stubs(:code).returns('500')
655
+ allow(response).to receive(:code).and_return('500')
653
656
 
654
657
  expect { resource.write(source) }.to raise_error(Net::HTTPError, /500/)
655
658
  end
656
659
 
657
660
  context 'and the request was successful' do
658
- before(:each) { response.stubs(:code).returns '200' }
661
+ before(:each) { allow(response).to receive(:code).and_return('200') }
659
662
 
660
663
  it 'should write the contents to the file' do
661
664
  resource.write(source)