puppet 5.5.12-x86-mingw32 → 5.5.13-x86-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet_spec/compiler'
4
3
  require 'puppet/parser/environment_compiler'
@@ -24,9 +23,12 @@ describe "Application instantiation" do
24
23
  Puppet::Parser::EnvironmentCompiler.compile(env, code_id).filter { |r| r.virtual? }
25
24
  end
26
25
 
27
- around :each do |example|
28
- Puppet::Parser::Compiler.any_instance.stubs(:loaders).returns(loaders)
29
- Puppet::Parser::EnvironmentCompiler.any_instance.stubs(:loaders).returns(loaders)
26
+ before(:each) do
27
+ l = loaders
28
+ allow(Puppet::Pops::Loaders).to receive(:new).and_return(l)
29
+ end
30
+
31
+ around(:each) do |example|
30
32
  Puppet.override(:loaders => loaders, :current_environment => env) do
31
33
  Puppet::Type.newtype :cap, :is_capability => true do
32
34
  newparam :name
@@ -400,14 +402,14 @@ EOS
400
402
  }.each do |k,v|
401
403
  it "contains the #{v} (#{k})" do
402
404
  # Mock the connection to Puppet DB
403
- Puppet::Resource::CapabilityFinder.expects(:find).returns(cap)
405
+ expect(Puppet::Resource::CapabilityFinder).to receive(:find).and_return(cap)
404
406
  expect(compiled_catalog.resource(k)).not_to be_nil
405
407
  end
406
408
  end
407
409
 
408
410
  it "does not contain the produced resource (Prod[one])" do
409
411
  # Mock the connection to Puppet DB
410
- Puppet::Resource::CapabilityFinder.expects(:find).returns(cap)
412
+ expect(Puppet::Resource::CapabilityFinder).to receive(:find).and_return(cap)
411
413
  expect(compiled_catalog.resource("Prod[one]")).to be_nil
412
414
  end
413
415
  end
@@ -448,14 +450,14 @@ EOS
448
450
  }.each do |k,v|
449
451
  it "contains the #{v} (#{k})" do
450
452
  # Mock the connection to Puppet DB
451
- Puppet::Resource::CapabilityFinder.expects(:find).returns(cap)
453
+ expect(Puppet::Resource::CapabilityFinder).to receive(:find).and_return(cap)
452
454
  expect(compiled_catalog.resource(k)).not_to be_nil
453
455
  end
454
456
  end
455
457
 
456
458
  it "does not contain the produced resource (Class[prod])" do
457
459
  # Mock the connection to Puppet DB
458
- Puppet::Resource::CapabilityFinder.expects(:find).returns(cap)
460
+ expect(Puppet::Resource::CapabilityFinder).to receive(:find).and_return(cap)
459
461
  expect(compiled_catalog.resource("Class[prod]")).to be_nil
460
462
  end
461
463
  end
@@ -497,7 +499,7 @@ EOS
497
499
  end
498
500
 
499
501
  it "ignores usage of hiera_include() at topscope for classification" do
500
- Puppet.expects(:debug).with(regexp_matches(/Ignoring hiera_include/))
502
+ expect(Puppet).to receive(:debug).with(/Ignoring hiera_include/)
501
503
 
502
504
  expect {
503
505
  compile_to_env_catalog(<<-EOC).to_resource
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/parser/files'
@@ -77,7 +77,7 @@ describe 'function for dynamically creating resources' do
77
77
  it 'should pick up and pass on file and line information' do
78
78
  # mock location as the compile_to_catalog sets Puppet[:code} which does not
79
79
  # have file/line support.
80
- Puppet::Pops::PuppetStack.expects(:top_of_stack).once.returns(['test.pp', 1234])
80
+ expect(Puppet::Pops::PuppetStack).to receive(:top_of_stack).once.and_return(['test.pp', 1234])
81
81
  catalog = compile_to_catalog("create_resources('file', {'/etc/foo'=>{'ensure'=>'present'}})")
82
82
  r = catalog.resource(:file, "/etc/foo")
83
83
  expect(r.file).to eq('test.pp')
@@ -1,4 +1,3 @@
1
- #!/usr/bin/env rspec
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the digest function", :uses_checksums => true do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the 'fail' parser function" do
@@ -10,7 +9,7 @@ describe "the 'fail' parser function" do
10
9
  node = Puppet::Node.new('localhost')
11
10
  compiler = Puppet::Parser::Compiler.new(node)
12
11
  scope = Puppet::Parser::Scope.new(compiler)
13
- scope.stubs(:environment).returns(nil)
12
+ allow(scope).to receive(:environment).and_return(nil)
14
13
  scope
15
14
  end
16
15
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet_spec/files'
4
3
 
@@ -35,9 +34,9 @@ describe "the 'file' function" do
35
34
 
36
35
  it "should read a file from a module path" do
37
36
  with_file_content('file content') do |name|
38
- mod = mock 'module'
39
- mod.stubs(:file).with('myfile').returns(name)
40
- compiler.environment.stubs(:module).with('mymod').returns(mod)
37
+ mod = double('module')
38
+ allow(mod).to receive(:file).with('myfile').and_return(name)
39
+ allow(compiler.environment).to receive(:module).with('mymod').and_return(mod)
41
40
 
42
41
  expect(scope.function_file(['mymod/myfile'])).to eq('file content')
43
42
  end
@@ -54,10 +53,10 @@ describe "the 'file' function" do
54
53
  it "should return the first file if given two files with module paths" do
55
54
  with_file_content('one') do |one|
56
55
  with_file_content('two') do |two|
57
- mod = mock 'module'
58
- compiler.environment.expects(:module).with('mymod').returns(mod)
59
- mod.expects(:file).with('one').returns(one)
60
- mod.stubs(:file).with('two').returns(two)
56
+ mod = double('module')
57
+ expect(compiler.environment).to receive(:module).with('mymod').and_return(mod)
58
+ expect(mod).to receive(:file).with('one').and_return(one)
59
+ allow(mod).to receive(:file).with('two').and_return(two)
61
60
 
62
61
  expect(scope.function_file(['mymod/one','mymod/two'])).to eq('one')
63
62
  end
@@ -67,9 +66,9 @@ describe "the 'file' function" do
67
66
  it "should return the first file if given two files with mixed paths, absolute first" do
68
67
  with_file_content('one') do |one|
69
68
  with_file_content('two') do |two|
70
- mod = mock 'module'
71
- compiler.environment.stubs(:module).with('mymod').returns(mod)
72
- mod.stubs(:file).with('two').returns(two)
69
+ mod = double('module')
70
+ allow(compiler.environment).to receive(:module).with('mymod').and_return(mod)
71
+ allow(mod).to receive(:file).with('two').and_return(two)
73
72
 
74
73
  expect(scope.function_file([one,'mymod/two'])).to eq('one')
75
74
  end
@@ -79,9 +78,9 @@ describe "the 'file' function" do
79
78
  it "should return the first file if given two files with mixed paths, module first" do
80
79
  with_file_content('one') do |one|
81
80
  with_file_content('two') do |two|
82
- mod = mock 'module'
83
- compiler.environment.expects(:module).with('mymod').returns(mod)
84
- mod.stubs(:file).with('two').returns(two)
81
+ mod = double('module')
82
+ expect(compiler.environment).to receive(:module).with('mymod').and_return(mod)
83
+ allow(mod).to receive(:file).with('two').and_return(two)
85
84
 
86
85
  expect(scope.function_file(['mymod/two',one])).to eq('two')
87
86
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet_spec/scope'
4
3
 
@@ -39,25 +38,25 @@ describe "the fqdn_rand function" do
39
38
  end
40
39
 
41
40
  it "should return a specific value with given set of inputs on non-fips enabled host" do
42
- Puppet::Util::Platform.stubs(:fips_enabled?).returns false
41
+ allow(Puppet::Util::Platform).to receive(:fips_enabled?).and_return(false)
43
42
 
44
43
  expect(fqdn_rand(3000, :host => 'dummy.fqdn.net')).to eql(338)
45
44
  end
46
45
 
47
46
  it "should return a specific value with given set of inputs on fips enabled host" do
48
- Puppet::Util::Platform.stubs(:fips_enabled?).returns true
47
+ allow(Puppet::Util::Platform).to receive(:fips_enabled?).and_return(true)
49
48
 
50
49
  expect(fqdn_rand(3000, :host => 'dummy.fqdn.net')).to eql(278)
51
50
  end
52
51
 
53
52
  it "should return a specific value with given seed on a non-fips enabled host" do
54
- Puppet::Util::Platform.stubs(:fips_enabled?).returns false
53
+ allow(Puppet::Util::Platform).to receive(:fips_enabled?).and_return(false)
55
54
 
56
55
  expect(fqdn_rand(5000, :extra_identifier => ['expensive job 33'])).to eql(3374)
57
56
  end
58
57
 
59
58
  it "should return a specific value with given seed on a fips enabled host" do
60
- Puppet::Util::Platform.stubs(:fips_enabled?).returns true
59
+ allow(Puppet::Util::Platform).to receive(:fips_enabled?).and_return(true)
61
60
 
62
61
  expect(fqdn_rand(5000, :extra_identifier => ['expensive job 33'])).to eql(2389)
63
62
  end
@@ -67,7 +66,7 @@ describe "the fqdn_rand function" do
67
66
  extra = args[:extra_identifier] || []
68
67
 
69
68
  scope = create_test_scope_for_node('localhost')
70
- scope.stubs(:[]).with("::fqdn").returns(host)
69
+ allow(scope).to receive(:[]).with("::fqdn").and_return(host)
71
70
 
72
71
  scope.function_fqdn_rand([max] + extra)
73
72
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the generate function" do
@@ -18,7 +17,7 @@ describe "the generate function" do
18
17
 
19
18
  it "accept a fully-qualified path as a command" do
20
19
  command = File.expand_path('/command/foo')
21
- Dir.expects(:chdir).with(File.dirname(command)).returns("yay")
20
+ expect(Dir).to receive(:chdir).with(File.dirname(command)).and_return("yay")
22
21
  expect(scope.function_generate([command])).to eq("yay")
23
22
  end
24
23
 
@@ -41,32 +40,32 @@ describe "the generate function" do
41
40
 
42
41
  it "should execute the generate script with the correct working directory" do
43
42
  command = File.expand_path("/command")
44
- Dir.expects(:chdir).with(File.dirname(command)).returns("yay")
43
+ expect(Dir).to receive(:chdir).with(File.dirname(command)).and_return("yay")
45
44
  expect(scope.function_generate([command])).to eq('yay')
46
45
  end
47
46
 
48
47
  describe "on Windows", :if => Puppet.features.microsoft_windows? do
49
48
  it "should accept the tilde in the path" do
50
49
  command = "C:/DOCUME~1/ADMINI~1/foo.bat"
51
- Dir.expects(:chdir).with(File.dirname(command)).returns("yay")
50
+ expect(Dir).to receive(:chdir).with(File.dirname(command)).and_return("yay")
52
51
  expect(scope.function_generate([command])).to eq('yay')
53
52
  end
54
53
 
55
54
  it "should accept lower-case drive letters" do
56
55
  command = 'd:/command/foo'
57
- Dir.expects(:chdir).with(File.dirname(command)).returns("yay")
56
+ expect(Dir).to receive(:chdir).with(File.dirname(command)).and_return("yay")
58
57
  expect(scope.function_generate([command])).to eq('yay')
59
58
  end
60
59
 
61
60
  it "should accept upper-case drive letters" do
62
61
  command = 'D:/command/foo'
63
- Dir.expects(:chdir).with(File.dirname(command)).returns("yay")
62
+ expect(Dir).to receive(:chdir).with(File.dirname(command)).and_return("yay")
64
63
  expect(scope.function_generate([command])).to eq('yay')
65
64
  end
66
65
 
67
66
  it "should accept forward and backslashes in the path" do
68
67
  command = 'D:\command/foo\bar'
69
- Dir.expects(:chdir).with(File.dirname(command)).returns("yay")
68
+ expect(Dir).to receive(:chdir).with(File.dirname(command)).and_return("yay")
70
69
  expect(scope.function_generate([command])).to eq('yay')
71
70
  end
72
71
 
@@ -86,7 +85,7 @@ describe "the generate function" do
86
85
 
87
86
  it "should accept plus and dash" do
88
87
  command = "/var/folders/9z/9zXImgchH8CZJh6SgiqS2U+++TM/-Tmp-/foo"
89
- Dir.expects(:chdir).with(File.dirname(command)).returns("yay")
88
+ expect(Dir).to receive(:chdir).with(File.dirname(command)).and_return("yay")
90
89
  expect(scope.function_generate([command])).to eq('yay')
91
90
  end
92
91
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the inline_template function" do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the regsubst function" do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the scanf function" do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the shellquote function" do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the split function" do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the sprintf function" do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the 'tag' function" do
@@ -18,7 +17,7 @@ describe "the 'tag' function" do
18
17
 
19
18
  it "should tag the resource with any provided tags" do
20
19
  resource = Puppet::Parser::Resource.new(:file, "/file", :scope => @scope)
21
- @scope.expects(:resource).returns resource
20
+ expect(@scope).to receive(:resource).and_return(resource)
22
21
 
23
22
  @scope.function_tag ["one", "two"]
24
23
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the 'tagged' function" do
@@ -25,7 +24,7 @@ describe "the 'tagged' function" do
25
24
 
26
25
  it 'should be case-insensitive' do
27
26
  resource = Puppet::Parser::Resource.new(:file, "/file", :scope => @scope)
28
- @scope.stubs(:resource).returns resource
27
+ allow(@scope).to receive(:resource).and_return(resource)
29
28
  @scope.function_tag ["one"]
30
29
 
31
30
  expect(@scope.function_tagged(['One'])).to eq(true)
@@ -33,7 +32,7 @@ describe "the 'tagged' function" do
33
32
 
34
33
  it 'should check if all specified tags are included' do
35
34
  resource = Puppet::Parser::Resource.new(:file, "/file", :scope => @scope)
36
- @scope.stubs(:resource).returns resource
35
+ allow(@scope).to receive(:resource).and_return(resource)
37
36
  @scope.function_tag ["one"]
38
37
 
39
38
  expect(@scope.function_tagged(['one', 'two'])).to eq(false)
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the template function" do
@@ -11,21 +10,22 @@ describe "the template function" do
11
10
  let :scope do Puppet::Parser::Scope.new(compiler) end
12
11
 
13
12
  it "concatenates outputs for multiple templates" do
14
- tw1 = stub_everything "template_wrapper1"
15
- tw2 = stub_everything "template_wrapper2"
16
- Puppet::Parser::TemplateWrapper.stubs(:new).returns(tw1,tw2)
17
- tw1.stubs(:file=).with("1")
18
- tw2.stubs(:file=).with("2")
19
- tw1.stubs(:result).returns("result1")
20
- tw2.stubs(:result).returns("result2")
13
+ tw1 = double("template_wrapper1")
14
+ tw2 = double("template_wrapper2")
15
+ allow(Puppet::Parser::TemplateWrapper).to receive(:new).and_return(tw1,tw2)
16
+ allow(tw1).to receive(:file=).with("1")
17
+ allow(tw2).to receive(:file=).with("2")
18
+ allow(tw1).to receive(:result).and_return("result1")
19
+ allow(tw2).to receive(:result).and_return("result2")
21
20
 
22
21
  expect(scope.function_template(["1","2"])).to eq("result1result2")
23
22
  end
24
23
 
25
24
  it "raises an error if the template raises an error" do
26
- tw = stub_everything 'template_wrapper'
27
- Puppet::Parser::TemplateWrapper.stubs(:new).returns(tw)
28
- tw.stubs(:result).raises
25
+ tw = double('template_wrapper')
26
+ allow(tw).to receive(:file=).with("1")
27
+ allow(Puppet::Parser::TemplateWrapper).to receive(:new).and_return(tw)
28
+ allow(tw).to receive(:result).and_raise
29
29
 
30
30
  expect {
31
31
  scope.function_template(["1"])
@@ -90,8 +90,8 @@ describe "the template function" do
90
90
  end
91
91
 
92
92
  def eval_template(content)
93
- Puppet::FileSystem.stubs(:read_preserve_line_endings).with("template").returns(content)
94
- Puppet::Parser::Files.stubs(:find_template).returns("template")
93
+ allow(Puppet::FileSystem).to receive(:read_preserve_line_endings).with("template").and_return(content)
94
+ allow(Puppet::Parser::Files).to receive(:find_template).and_return("template")
95
95
  scope.function_template(['template'])
96
96
  end
97
97
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe "the versioncmp function" do
@@ -25,7 +24,7 @@ describe "the versioncmp function" do
25
24
  end
26
25
 
27
26
  it "should call Puppet::Util::Package.versioncmp (included in scope)" do
28
- Puppet::Util::Package.expects(:versioncmp).with("1.2", "1.3").returns(-1)
27
+ expect(Puppet::Util::Package).to receive(:versioncmp).with("1.2", "1.3").and_return(-1)
29
28
 
30
29
  @scope.function_versioncmp(["1.2", "1.3"])
31
30
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Parser::Functions do
@@ -27,7 +26,7 @@ describe Puppet::Parser::Functions do
27
26
 
28
27
  it "should warn if the function already exists" do
29
28
  Puppet::Parser::Functions.newfunction("name", :type => :rvalue) { |args| }
30
- Puppet.expects(:warning)
29
+ expect(Puppet).to receive(:warning)
31
30
 
32
31
  Puppet::Parser::Functions.newfunction("name", :type => :rvalue) { |args| }
33
32
  end
@@ -49,7 +48,7 @@ describe Puppet::Parser::Functions do
49
48
 
50
49
  describe "when calling function to test function existence" do
51
50
  it "should return false if the function doesn't exist" do
52
- Puppet::Parser::Functions.autoloader.stubs(:load)
51
+ allow(Puppet::Parser::Functions.autoloader).to receive(:load)
53
52
 
54
53
  expect(Puppet::Parser::Functions.function("name")).to be_falsey
55
54
  end
@@ -61,7 +60,7 @@ describe Puppet::Parser::Functions do
61
60
  end
62
61
 
63
62
  it "should try to autoload the function if it doesn't exist yet" do
64
- Puppet::Parser::Functions.autoloader.expects(:load)
63
+ expect(Puppet::Parser::Functions.autoloader).to receive(:load)
65
64
 
66
65
  Puppet::Parser::Functions.function("name")
67
66
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/parser/relationship'
@@ -49,24 +49,24 @@ describe Puppet::Parser::Resource do
49
49
  end
50
50
 
51
51
  it "should get its environment from its scope" do
52
- scope = stub 'scope', :source => stub("source")
53
- scope.expects(:environment).returns("foo").at_least_once
54
- scope.expects(:lookupdefaults).returns({})
52
+ scope = double('scope', :source => double("source"))
53
+ expect(scope).to receive(:environment).and_return("foo").at_least(:once)
54
+ expect(scope).to receive(:lookupdefaults).and_return({})
55
55
  expect(Puppet::Parser::Resource.new("file", "whatever", :scope => scope).environment).to eq("foo")
56
56
  end
57
57
 
58
58
  it "should use the scope's environment as its environment" do
59
- @scope.expects(:environment).returns("myenv").at_least_once
59
+ expect(@scope).to receive(:environment).and_return("myenv").at_least(:once)
60
60
  expect(Puppet::Parser::Resource.new("file", "whatever", :scope => @scope).environment).to eq("myenv")
61
61
  end
62
62
 
63
63
  it "should be isomorphic if it is builtin and models an isomorphic type" do
64
- Puppet::Type.type(:file).expects(:isomorphic?).returns(true)
64
+ expect(Puppet::Type.type(:file)).to receive(:isomorphic?).and_return(true)
65
65
  @resource = expect(Puppet::Parser::Resource.new("file", "whatever", :scope => @scope, :source => @source).isomorphic?).to be_truthy
66
66
  end
67
67
 
68
68
  it "should not be isomorphic if it is builtin and models a non-isomorphic type" do
69
- Puppet::Type.type(:file).expects(:isomorphic?).returns(false)
69
+ expect(Puppet::Type.type(:file)).to receive(:isomorphic?).and_return(false)
70
70
  @resource = expect(Puppet::Parser::Resource.new("file", "whatever", :scope => @scope, :source => @source).isomorphic?).to be_falsey
71
71
  end
72
72
 
@@ -81,9 +81,9 @@ describe Puppet::Parser::Resource do
81
81
  end
82
82
 
83
83
  it "should use a Puppet::Resource for converting to a ral resource" do
84
- trans = mock 'resource', :to_ral => "yay"
84
+ trans = double('resource', :to_ral => "yay")
85
85
  @resource = mkresource
86
- @resource.expects(:copy_as_resource).returns trans
86
+ expect(@resource).to receive(:copy_as_resource).and_return(trans)
87
87
  expect(@resource.to_ral).to eq("yay")
88
88
  end
89
89
 
@@ -125,8 +125,8 @@ describe Puppet::Parser::Resource do
125
125
  describe "when evaluating" do
126
126
  before do
127
127
  @catalog = Puppet::Resource::Catalog.new
128
- source = stub('source')
129
- source.stubs(:module_name)
128
+ source = double('source')
129
+ allow(source).to receive(:module_name)
130
130
  @scope = Puppet::Parser::Scope.new(@compiler, :source => source)
131
131
  @catalog.add_resource(Puppet::Parser::Resource.new("stage", :main, :scope => @scope))
132
132
  end
@@ -134,7 +134,7 @@ describe Puppet::Parser::Resource do
134
134
  it "should evaluate the associated AST definition" do
135
135
  definition = newdefine "mydefine"
136
136
  res = Puppet::Parser::Resource.new("mydefine", "whatever", :scope => @scope, :source => @source, :catalog => @catalog)
137
- definition.expects(:evaluate_code).with(res)
137
+ expect(definition).to receive(:evaluate_code).with(res)
138
138
 
139
139
  res.evaluate
140
140
  end
@@ -142,14 +142,14 @@ describe Puppet::Parser::Resource do
142
142
  it "should evaluate the associated AST class" do
143
143
  @class = newclass "myclass"
144
144
  res = Puppet::Parser::Resource.new("class", "myclass", :scope => @scope, :source => @source, :catalog => @catalog)
145
- @class.expects(:evaluate_code).with(res)
145
+ expect(@class).to receive(:evaluate_code).with(res)
146
146
  res.evaluate
147
147
  end
148
148
 
149
149
  it "should evaluate the associated AST node" do
150
150
  nodedef = newnode("mynode")
151
151
  res = Puppet::Parser::Resource.new("node", "mynode", :scope => @scope, :source => @source, :catalog => @catalog)
152
- nodedef.expects(:evaluate_code).with(res)
152
+ expect(nodedef).to receive(:evaluate_code).with(res)
153
153
  res.evaluate
154
154
  end
155
155
 
@@ -314,19 +314,19 @@ describe Puppet::Parser::Resource do
314
314
  let(:resource) { Puppet::Parser::Resource.new('file', 'whatever', :scope => @scope, :source => @source) }
315
315
 
316
316
  it 'should add all defaults available from the scope' do
317
- @scope.expects(:lookupdefaults).with('File').returns(:owner => param(:owner, 'default', @source))
317
+ expect(@scope).to receive(:lookupdefaults).with('File').and_return(:owner => param(:owner, 'default', @source))
318
318
 
319
319
  expect(resource[:owner]).to eq('default')
320
320
  end
321
321
 
322
322
  it 'should not replace existing parameters with defaults' do
323
- @scope.expects(:lookupdefaults).with('File').returns(:owner => param(:owner, 'replaced', @source))
323
+ expect(@scope).to receive(:lookupdefaults).with('File').and_return(:owner => param(:owner, 'replaced', @source))
324
324
  r = Puppet::Parser::Resource.new('file', 'whatever', :scope => @scope, :source => @source, :parameters => [ param(:owner, 'oldvalue', @source) ])
325
325
  expect(r[:owner]).to eq('oldvalue')
326
326
  end
327
327
 
328
328
  it 'should override defaults with new parameters' do
329
- @scope.expects(:lookupdefaults).with('File').returns(:owner => param(:owner, 'replaced', @source))
329
+ expect(@scope).to receive(:lookupdefaults).with('File').and_return(:owner => param(:owner, 'replaced', @source))
330
330
 
331
331
  resource.set_parameter(:owner, 'newvalue')
332
332
  expect(resource[:owner]).to eq('newvalue')
@@ -336,14 +336,14 @@ describe Puppet::Parser::Resource do
336
336
  newparam = param(:owner, 'default', @source)
337
337
  other = newparam.dup
338
338
  other.value = "other"
339
- newparam.expects(:dup).returns(other)
340
- @scope.expects(:lookupdefaults).with('File').returns(:owner => newparam)
339
+ expect(newparam).to receive(:dup).and_return(other)
340
+ expect(@scope).to receive(:lookupdefaults).with('File').and_return(:owner => newparam)
341
341
 
342
342
  expect(resource[:owner]).to eq('other')
343
343
  end
344
344
 
345
345
  it "should tag with value of default parameter named 'tag'" do
346
- @scope.expects(:lookupdefaults).with('File').returns(:tag => param(:tag, 'the_tag', @source))
346
+ expect(@scope).to receive(:lookupdefaults).with('File').and_return(:tag => param(:tag, 'the_tag', @source))
347
347
 
348
348
  expect(resource.tags).to include('the_tag')
349
349
  end
@@ -356,7 +356,7 @@ describe Puppet::Parser::Resource do
356
356
 
357
357
  it "should do nothing if it has already been finished" do
358
358
  @resource.finish
359
- @resource.expects(:add_scope_tags).never
359
+ expect(@resource).not_to receive(:add_scope_tags)
360
360
  @resource.finish
361
361
  end
362
362
 
@@ -370,9 +370,9 @@ describe Puppet::Parser::Resource do
370
370
 
371
371
  describe "when being tagged" do
372
372
  before do
373
- @scope_resource = stub 'scope_resource', :tags => %w{srone srtwo}
374
- @scope.stubs(:resource).returns @scope_resource
375
- @resource = Puppet::Parser::Resource.new("file", "yay", :scope => @scope, :source => mock('source'))
373
+ @scope_resource = double('scope_resource', :tags => %w{srone srtwo})
374
+ allow(@scope).to receive(:resource).and_return(@scope_resource)
375
+ @resource = Puppet::Parser::Resource.new("file", "yay", :scope => @scope, :source => double('source'))
376
376
  end
377
377
 
378
378
  it "should get tagged with the resource type" do
@@ -384,19 +384,19 @@ describe Puppet::Parser::Resource do
384
384
  end
385
385
 
386
386
  it "should get tagged with each name in the title if the title is a qualified class name" do
387
- resource = Puppet::Parser::Resource.new("file", "one::two", :scope => @scope, :source => mock('source'))
387
+ resource = Puppet::Parser::Resource.new("file", "one::two", :scope => @scope, :source => double('source'))
388
388
  expect(resource.tags).to be_include("one")
389
389
  expect(resource.tags).to be_include("two")
390
390
  end
391
391
 
392
392
  it "should get tagged with each name in the type if the type is a qualified class name" do
393
- resource = Puppet::Parser::Resource.new("one::two", "whatever", :scope => @scope, :source => mock('source'))
393
+ resource = Puppet::Parser::Resource.new("one::two", "whatever", :scope => @scope, :source => double('source'))
394
394
  expect(resource.tags).to be_include("one")
395
395
  expect(resource.tags).to be_include("two")
396
396
  end
397
397
 
398
398
  it "should not get tagged with non-alphanumeric titles" do
399
- resource = Puppet::Parser::Resource.new("file", "this is a test", :scope => @scope, :source => mock('source'))
399
+ resource = Puppet::Parser::Resource.new("file", "this is a test", :scope => @scope, :source => double('source'))
400
400
  expect(resource.tags).not_to be_include("this is a test")
401
401
  end
402
402
 
@@ -426,34 +426,34 @@ describe Puppet::Parser::Resource do
426
426
 
427
427
  it "should fail when the override was not created by a parent class" do
428
428
  @override.source = "source2"
429
- @override.source.expects(:child_of?).with("source1").returns(false)
429
+ expect(@override.source).to receive(:child_of?).with("source1").and_return(false)
430
430
  expect { @resource.merge(@override) }.to raise_error(Puppet::ParseError)
431
431
  end
432
432
 
433
433
  it "should succeed when the override was created in the current scope" do
434
434
  @resource.source = "source3"
435
435
  @override.source = @resource.source
436
- @override.source.expects(:child_of?).with("source3").never
436
+ expect(@override.source).not_to receive(:child_of?).with("source3")
437
437
  params = {:a => :b, :c => :d}
438
- @override.expects(:parameters).returns(params)
439
- @resource.expects(:override_parameter).with(:b)
440
- @resource.expects(:override_parameter).with(:d)
438
+ expect(@override).to receive(:parameters).and_return(params)
439
+ expect(@resource).to receive(:override_parameter).with(:b)
440
+ expect(@resource).to receive(:override_parameter).with(:d)
441
441
  @resource.merge(@override)
442
442
  end
443
443
 
444
444
  it "should succeed when a parent class created the override" do
445
445
  @resource.source = "source3"
446
446
  @override.source = "source4"
447
- @override.source.expects(:child_of?).with("source3").returns(true)
447
+ expect(@override.source).to receive(:child_of?).with("source3").and_return(true)
448
448
  params = {:a => :b, :c => :d}
449
- @override.expects(:parameters).returns(params)
450
- @resource.expects(:override_parameter).with(:b)
451
- @resource.expects(:override_parameter).with(:d)
449
+ expect(@override).to receive(:parameters).and_return(params)
450
+ expect(@resource).to receive(:override_parameter).with(:b)
451
+ expect(@resource).to receive(:override_parameter).with(:d)
452
452
  @resource.merge(@override)
453
453
  end
454
454
 
455
455
  it "should add new parameters when the parameter is not set" do
456
- @source.stubs(:child_of?).returns true
456
+ allow(@source).to receive(:child_of?).and_return(true)
457
457
  @override.set_parameter(:testing, "value")
458
458
  @resource.merge(@override)
459
459
 
@@ -461,7 +461,7 @@ describe Puppet::Parser::Resource do
461
461
  end
462
462
 
463
463
  it "should replace existing parameter values" do
464
- @source.stubs(:child_of?).returns true
464
+ allow(@source).to receive(:child_of?).and_return(true)
465
465
  @resource.set_parameter(:testing, "old")
466
466
  @override.set_parameter(:testing, "value")
467
467
 
@@ -471,7 +471,7 @@ describe Puppet::Parser::Resource do
471
471
  end
472
472
 
473
473
  it "should add values to the parameter when the override was created with the '+>' syntax" do
474
- @source.stubs(:child_of?).returns true
474
+ allow(@source).to receive(:child_of?).and_return(true)
475
475
  param = Puppet::Parser::Resource::Param.new(:name => :testing, :value => "testing", :source => @resource.source)
476
476
  param.add = true
477
477
 
@@ -490,7 +490,7 @@ describe Puppet::Parser::Resource do
490
490
  @resource. set_parameter(:testing, "old_val_1")
491
491
  @resource_2.set_parameter(:testing, "old_val_2")
492
492
 
493
- @source.stubs(:child_of?).returns true
493
+ allow(@source).to receive(:child_of?).and_return(true)
494
494
  param = Puppet::Parser::Resource::Param.new(:name => :testing, :value => "new_val", :source => @resource.source)
495
495
  param.add = true
496
496
  @override.set_parameter(param)
@@ -503,7 +503,7 @@ describe Puppet::Parser::Resource do
503
503
  end
504
504
 
505
505
  it "should promote tag overrides to real tags" do
506
- @source.stubs(:child_of?).returns true
506
+ allow(@source).to receive(:child_of?).and_return(true)
507
507
  param = Puppet::Parser::Resource::Param.new(:name => :tag, :value => "testing", :source => @resource.source)
508
508
 
509
509
  @override.set_parameter(param)
@@ -516,7 +516,7 @@ describe Puppet::Parser::Resource do
516
516
  end
517
517
 
518
518
  it "should be able to be converted to a normal resource" do
519
- @source = stub 'scope', :name => "myscope"
519
+ @source = double('scope', :name => "myscope")
520
520
  @resource = mkresource :source => @source
521
521
  expect(@resource).to respond_to(:copy_as_resource)
522
522
  end
@@ -634,7 +634,7 @@ describe Puppet::Parser::Resource do
634
634
 
635
635
  # part of #629 -- the undef keyword. Make sure 'undef' params get skipped.
636
636
  it "should not include 'undef' parameters when converting itself to a hash" do
637
- resource = Puppet::Parser::Resource.new "file", "/tmp/testing", :source => mock("source"), :scope => @scope
637
+ resource = Puppet::Parser::Resource.new "file", "/tmp/testing", :source => double("source"), :scope => @scope
638
638
  resource[:owner] = :undef
639
639
  resource[:mode] = "755"
640
640
  expect(resource.to_hash[:owner]).to be_nil