openstudio-standards 0.8.3 → 0.8.5.rc1

data/lib/openstudio-standards/standards/Standards.CoilHeatingDXSingleSpeed.rb

@@ -3,113 +3,18 @@ class Standard
 
   include CoilDX
 
-  # Finds capacity in W.  This is the cooling capacity of the paired DX cooling coil.
-  #
-  # @param coil_heating_dx_single_speed [OpenStudio::Model::CoilHeatingDXSingleSpeed] coil heating dx single speed object
-  # @param necb_ref_hp [Boolean] for compatability with NECB ruleset only.
-  # @return [Double] capacity in W to be used for find object
-  def coil_heating_dx_single_speed_find_capacity(coil_heating_dx_single_speed, necb_ref_hp = false)
-    capacity_w = nil
-
-    # Get the paired cooling coil
-    clg_coil = nil
-
-    # Unitary and zone equipment
-    if coil_heating_dx_single_speed.airLoopHVAC.empty?
-      if coil_heating_dx_single_speed.containingHVACComponent.is_initialized
-        containing_comp = coil_heating_dx_single_speed.containingHVACComponent.get
-        if containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.is_initialized
-          clg_coil = containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.get.coolingCoil
-        elsif containing_comp.to_AirLoopHVACUnitarySystem.is_initialized
-          unitary = containing_comp.to_AirLoopHVACUnitarySystem.get
-          if unitary.coolingCoil.is_initialized
-            clg_coil = unitary.coolingCoil.get
-          end
-        end
-        # @todo Add other unitary systems
-      elsif coil_heating_dx_single_speed.containingZoneHVACComponent.is_initialized
-        containing_comp = coil_heating_dx_single_speed.containingZoneHVACComponent.get
-        # PTHP
-        if containing_comp.to_ZoneHVACPackagedTerminalHeatPump.is_initialized
-          pthp = containing_comp.to_ZoneHVACPackagedTerminalHeatPump.get
-          clg_coil = containing_comp.to_ZoneHVACPackagedTerminalHeatPump.get.coolingCoil
-        end
-      end
-    end
-
-    # On AirLoop directly
-    if coil_heating_dx_single_speed.airLoopHVAC.is_initialized
-      air_loop = coil_heating_dx_single_speed.airLoopHVAC.get
-      # Check for the presence of any other type of cooling coil
-      clg_types = ['OS:Coil:Cooling:DX:SingleSpeed',
-                   'OS:Coil:Cooling:DX:TwoSpeed',
-                   'OS:Coil:Cooling:DX:MultiSpeed']
-      clg_types.each do |ct|
-        coils = air_loop.supplyComponents(ct.to_IddObjectType)
-        next if coils.empty?
-
-        clg_coil = coils[0]
-        break # Stop on first DX cooling coil found
-      end
-    end
-
-    # If no paired cooling coil was found,
-    # throw an error and fall back to the heating capacity
-    # of the DX heating coil
-    if clg_coil.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}, the paired DX cooling coil could not be found to determine capacity. Efficiency will incorrectly be based on DX coil's heating capacity.")
-      if coil_heating_dx_single_speed.ratedTotalHeatingCapacity.is_initialized
-        capacity_w = coil_heating_dx_single_speed.ratedTotalHeatingCapacity.get
-      elsif coil_heating_dx_single_speed.autosizedRatedTotalHeatingCapacity.is_initialized
-        capacity_w = coil_heating_dx_single_speed.autosizedRatedTotalHeatingCapacity.get
-      else
-        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name} capacity is not available, cannot apply efficiency standard to paired DX heating coil.")
-        return 0.0
-      end
-      return capacity_w
-    end
-
-    # If a coil was found, cast to the correct type
-    if clg_coil.to_CoilCoolingDXSingleSpeed.is_initialized
-      clg_coil = clg_coil.to_CoilCoolingDXSingleSpeed.get
-      capacity_w = coil_cooling_dx_single_speed_find_capacity(clg_coil)
-    elsif clg_coil.to_CoilCoolingDXTwoSpeed.is_initialized
-      clg_coil = clg_coil.to_CoilCoolingDXTwoSpeed.get
-      capacity_w = coil_cooling_dx_two_speed_find_capacity(clg_coil)
-    elsif clg_coil.to_CoilCoolingDXMultiSpeed.is_initialized
-      clg_coil = clg_coil.to_CoilCoolingDXMultiSpeed.get
-      capacity_w = coil_cooling_dx_multi_speed_find_capacity(clg_coil)
-    end
-
-    # If it's a PTAC or PTHP System, we need to divide the capacity by the potential zone multiplier
-    # because the COP is dependent on capacity, and the capacity should be the capacity of a single zone, not all the zones
-    if ['PTAC', 'PTHP'].include?(coil_dx_subcategory(coil_heating_dx_single_speed))
-      mult = 1
-      comp = coil_heating_dx_single_speed.containingZoneHVACComponent
-      if comp.is_initialized && comp.get.thermalZone.is_initialized
-        mult = comp.get.thermalZone.get.multiplier
-        if mult > 1
-          total_cap = capacity_w
-          capacity_w /= mult
-          OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}, total capacity of #{OpenStudio.convert(total_cap, 'W', 'kBtu/hr').get.round(2)}kBTU/hr was divided by the zone multiplier of #{mult} to give #{capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get.round(2)}kBTU/hr.")
-        end
-      end
-    end
-
-    return capacity_w
-  end
-
   # Finds lookup object in standards and return efficiency
   #
   # @param coil_heating_dx_single_speed [OpenStudio::Model::CoilHeatingDXSingleSpeed] coil heating dx single speed object
   # @param rename [Boolean] if true, object will be renamed to include capacity and efficiency level
   # @param necb_ref_hp [Boolean] for compatability with NECB ruleset only.
+  # @param equipment_type [Boolean] indicate that equipment_type should be in the search criteria.
   # @return [Double] full load efficiency (COP)
   def coil_heating_dx_single_speed_standard_minimum_cop(coil_heating_dx_single_speed, rename = false, necb_ref_hp = false, equipment_type = false)
     coil_efficiency_data = standards_data['heat_pumps_heating']
 
     # Get the capacity
-    capacity_w = coil_heating_dx_single_speed_find_capacity(coil_heating_dx_single_speed, necb_ref_hp)
+    capacity_w = OpenstudioStandards::HVAC.coil_heating_get_paired_coil_cooling_capacity(coil_heating_dx_single_speed)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
@@ -128,7 +33,7 @@ class Standard
         if equipment_type == 'PTHP'
           search_criteria['application'] = coil_dx_packaged_terminal_application(coil_heating_dx_single_speed)
         end
-      elsif !coil_dx_heat_pump?(coil_heating_dx_single_speed) # `coil_dx_heat_pump?` returns false when a DX heating coil is wrapped into a AirloopHVAC:UnitarySystem
+      elsif !OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_heating_dx_single_speed) # `coil_dx_heat_pump?` returns false when a DX heating coil is wrapped into a AirloopHVAC:UnitarySystem
         search_criteria['equipment_type'] = 'Heat Pumps'
       end
       unless (template == 'NECB2011') || (template == 'NECB2015') || (template == 'NECB2017') || (template == 'NECB2020') || (template == 'BTAPPRE1980') ||
@@ -182,7 +87,7 @@ class Standard
       end
 
       min_coph = pthp_cop_coeff_1 - (pthp_cop_coeff_2 * capacity_btu_per_hr / 1000.0)
-      cop = cop_heating_to_cop_heating_no_fan(min_coph, OpenStudio.convert(capacity_btu_per_hr, 'Btu/hr', 'W').get)
+      cop = OpenstudioStandards::HVAC.cop_heating_to_cop_heating_no_fan(min_coph, OpenStudio.convert(capacity_btu_per_hr, 'Btu/hr', 'W').get)
       new_comp_name = "#{coil_heating_dx_single_speed.name} #{capacity_kbtu_per_hr.round} Clg kBtu/hr #{min_coph.round(1)}COPH"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}: #{sub_category} Cooling Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; COPH = #{min_coph.round(2)}")
     end
@@ -190,7 +95,7 @@ class Standard
     # If specified as HSPF
     unless hp_props['minimum_heating_seasonal_performance_factor'].nil?
       min_hspf = hp_props['minimum_heating_seasonal_performance_factor']
-      cop = hspf_to_cop_no_fan(min_hspf)
+      cop = OpenstudioStandards::HVAC.hspf_to_cop_no_fan(min_hspf)
       new_comp_name = "#{coil_heating_dx_single_speed.name} #{capacity_kbtu_per_hr.round} Clg kBtu/hr #{min_hspf.round(1)}HSPF"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{template}: #{coil_heating_dx_single_speed.name}: #{suppl_heating_type} #{sub_category} Cooling Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; HSPF = #{min_hspf}")
     end
@@ -199,7 +104,7 @@ class Standard
     # TODO: assumed to be the same as HSPF for now
     unless hp_props['minimum_heating_seasonal_performance_factor_2'].nil?
       min_hspf = hp_props['minimum_heating_seasonal_performance_factor_2']
-      cop = hspf_to_cop_no_fan(min_hspf)
+      cop = OpenstudioStandards::HVAC.hspf_to_cop_no_fan(min_hspf)
       new_comp_name = "#{coil_heating_dx_single_speed.name} #{capacity_kbtu_per_hr.round} Clg kBtu/hr #{min_hspf.round(1)}HSPF2"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{template}: #{coil_heating_dx_single_speed.name}: #{suppl_heating_type} #{sub_category} Cooling Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; HSPF = #{min_hspf}")
     end
@@ -207,7 +112,7 @@ class Standard
     # If specified as COPH
     unless hp_props['minimum_coefficient_of_performance_heating'].nil?
       min_coph = hp_props['minimum_coefficient_of_performance_heating']
-      cop = cop_heating_to_cop_heating_no_fan(min_coph, OpenStudio.convert(capacity_kbtu_per_hr, 'kBtu/hr', 'W').get)
+      cop = OpenstudioStandards::HVAC.cop_heating_to_cop_heating_no_fan(min_coph, OpenStudio.convert(capacity_kbtu_per_hr, 'kBtu/hr', 'W').get)
       new_comp_name = "#{coil_heating_dx_single_speed.name} #{capacity_kbtu_per_hr.round} Clg kBtu/hr #{min_coph.round(1)}COPH"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{template}: #{coil_heating_dx_single_speed.name}: #{suppl_heating_type} #{sub_category} Cooling Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; COPH = #{min_coph}")
     end
@@ -215,11 +120,19 @@ class Standard
     # If specified as EER
     unless hp_props['minimum_energy_efficiency_ratio'].nil?
       min_eer = hp_props['minimum_energy_efficiency_ratio']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       new_comp_name = "#{coil_heating_dx_single_speed.name} #{capacity_kbtu_per_hr.round} Clg kBtu/hr #{min_eer.round(1)}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{template}: #{coil_heating_dx_single_speed.name}:  #{suppl_heating_type} #{sub_category} Cooling Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
 
+    # If specified as SEER
+    unless hp_props['minimum_seasonal_energy_efficiency_ratio'].nil?
+      min_seer = hp_props['minimum_seasonal_energy_efficiency_ratio']
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
+      new_comp_name = "#{coil_heating_dx_single_speed.name} #{capacity_kbtu_per_hr.round} Clg kBtu/hr #{min_seer.round(1)}SEER"
+      OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{template}: #{coil_heating_dx_single_speed.name}:  #{suppl_heating_type} #{sub_category} Cooling Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
+    end
+
     # Rename
     if rename
       coil_heating_dx_single_speed.setName(new_comp_name)
@@ -243,7 +156,7 @@ class Standard
     equipment_type = coil_efficiency_data[0].keys.include?('equipment_type') ? true : false
 
     # Get the capacity
-    capacity_w = coil_heating_dx_single_speed_find_capacity(coil_heating_dx_single_speed, necb_ref_hp)
+    capacity_w = OpenstudioStandards::HVAC.coil_heating_get_paired_coil_cooling_capacity(coil_heating_dx_single_speed)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
@@ -255,7 +168,7 @@ class Standard
         if ['PTHP'].include?(equipment_type) && template.include?('90.1')
           search_criteria['application'] = coil_dx_packaged_terminal_application(coil_heating_dx_single_speed)
         end
-      elsif !coil_dx_heat_pump?(coil_heating_dx_single_speed) # `coil_dx_heat_pump?` returns false when a DX heating coil is wrapped into a AirloopHVAC:UnitarySystem
+      elsif !OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_heating_dx_single_speed) # `coil_dx_heat_pump?` returns false when a DX heating coil is wrapped into a AirloopHVAC:UnitarySystem
         search_criteria['equipment_type'] = 'Heat Pumps'
       end
       unless (template == 'NECB2011') || (template == 'NECB2015') || (template == 'NECB2017') || (template == 'NECB2020') || (template == 'BTAPPRE1980') ||

data/lib/openstudio-standards/standards/Standards.CoilHeatingGas.rb

@@ -24,7 +24,7 @@ class Standard
     search_criteria = coil_heating_gas_additional_search_criteria(coil_heating_gas, search_criteria)
 
     # Get the capacity, but return false if not available
-    capacity_w = coil_heating_gas_find_capacity(coil_heating_gas)
+    capacity_w = OpenstudioStandards::HVAC.coil_heating_gas_get_capacity(coil_heating_gas)
 
     # Return false if the coil does not have a heating capacity associated with it. Cannot apply the standard if without
     # it.
@@ -56,7 +56,7 @@ class Standard
       # If specified as AFUE
       unless furnace_props['minimum_annual_fuel_utilization_efficiency'].nil?
         min_afue = furnace_props['minimum_annual_fuel_utilization_efficiency']
-        thermal_eff = afue_to_thermal_eff(min_afue)
+        thermal_eff = OpenstudioStandards::HVAC.afue_to_thermal_eff(min_afue)
         new_comp_name = "#{coil_heating_gas.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_afue} AFUE"
         OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingGas', "For #{template}: #{coil_heating_gas.name}: = #{capacity_kbtu_per_hr.round}kBtu/hr; AFUE = #{min_afue}")
       end
@@ -64,7 +64,7 @@ class Standard
       # If specified as combustion efficiency
       unless furnace_props['minimum_combustion_efficiency'].nil?
         min_comb_eff = furnace_props['minimum_combustion_efficiency']
-        thermal_eff = combustion_eff_to_thermal_eff(min_comb_eff)
+        thermal_eff = OpenstudioStandards::HVAC.combustion_eff_to_thermal_eff(min_comb_eff)
         new_comp_name = "#{coil_heating_gas.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_comb_eff} Combustion Eff"
         OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingGas', "For #{template}: #{coil_heating_gas.name}: = #{capacity_kbtu_per_hr.round}kBtu/hr; Combustion Efficiency = #{min_comb_eff}")
       end
@@ -85,24 +85,4 @@ class Standard
 
     return successfully_set_all_properties
   end
-
-  # Retrieves the capacity of an OpenStudio::Model::CoilHeatingGas in watts
-  #
-  # @param coil_heating_gas [OpenStudio::Model::CoilHeatingGas] the gas heating coil
-  # @return [Double, false] a double representing the capacity of the CoilHeatingGas object in watts. If unsuccessful in
-  #   determining the capacity, this function returns false.
-  def coil_heating_gas_find_capacity(coil_heating_gas)
-    capacity_w = nil
-    if coil_heating_gas.nominalCapacity.is_initialized
-      capacity_w = coil_heating_gas.nominalCapacity.get
-    elsif coil_heating_gas.autosizedNominalCapacity.is_initialized
-      capacity_w = coil_heating_gas.autosizedNominalCapacity.get
-    else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingGas', "For #{coil_heating_gas.name} capacity is not available, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
-      return successfully_set_all_properties
-    end
-
-    return capacity_w
-  end
 end

data/lib/openstudio-standards/standards/Standards.CoilHeatingGasMultiStage.rb

@@ -45,28 +45,4 @@ class Standard
       successfully_set_all_properties = false
     end
   end
-
-  # Finds capacity in W
-  #
-  # @param coil_heating_gas_multi_stage [OpenStudio::Model::CoilHeatingGasMultiStage] coil heating gas multi stage object
-  # @return [Double] capacity in W to be used for find object
-  def coil_heating_gas_multi_stage_find_capacity(coil_heating_gas_multi_stage)
-    capacity_w = nil
-    htg_stages = coil_heating_gas_multi_stage.stages
-    if htg_stages.last.nominalCapacity.is_initialized
-      capacity_w = htg_stages.last.nominalCapacity.get
-    elsif (htg_stages.size == 1) && coil_heating_gas_multi_stage.stages[0].autosizedNominalCapacity.is_initialized
-      capacity_w = coil_heating_gas_multi_stage.stages[0].autosizedNominalCapacity.get
-    elsif (htg_stages.size == 2) && coil_heating_gas_multi_stage.stages[1].autosizedNominalCapacity.is_initialized
-      capacity_w = coil_heating_gas_multi_stage.stages[1].autosizedNominalCapacity.get
-    elsif (htg_stages.size == 3) && coil_heating_gas_multi_stage.stages[2].autosizedNominalCapacity.is_initialized
-      capacity_w = coil_heating_gas_multi_stage.stages[2].autosizedNominalCapacity.get
-    elsif (htg_stages.size == 4) && coil_heating_gas_multi_stage.stages[3].autosizedNominalCapacity.is_initialized
-      capacity_w = coil_heating_gas_multi_stage.stages[3].autosizedNominalCapacity.get
-    else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXMultiSpeed', "For #{coil_heating_gas_multi_stage.name} capacity is not available, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
-      return successfully_set_all_properties
-    end
-  end
 end

data/lib/openstudio-standards/standards/Standards.CoilHeatingWaterToAirHeatPumpEquationFit.rb

@@ -1,90 +1,6 @@
 class Standard
   # @!group CoilHeatingWaterToAirHeatPumpEquationFit
 
-  # Finds capacity in W.
-  # This is the cooling capacity of the paired cooling coil.
-  #
-  # @param coil_heating_water_to_air_heat_pump [OpenStudio::Model::CoilHeatingWaterToAirHeatPumpEquationFit] coil heating object
-  # @return [Double] capacity in W to be used for find object
-  def coil_heating_water_to_air_heat_pump_find_capacity(coil_heating_water_to_air_heat_pump)
-    capacity_w = nil
-
-    # Get the paired cooling coil
-    clg_coil = nil
-
-    # Unitary and zone equipment
-    if coil_heating_water_to_air_heat_pump.airLoopHVAC.empty?
-      if coil_heating_water_to_air_heat_pump.containingHVACComponent.is_initialized
-        containing_comp = coil_heating_water_to_air_heat_pump.containingHVACComponent.get
-        if containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.is_initialized
-          clg_coil = containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.get.coolingCoil
-        elsif containing_comp.to_AirLoopHVACUnitarySystem.is_initialized
-          unitary = containing_comp.to_AirLoopHVACUnitarySystem.get
-          if unitary.coolingCoil.is_initialized
-            clg_coil = unitary.coolingCoil.get
-          end
-        end
-      elsif coil_heating_water_to_air_heat_pump.containingZoneHVACComponent.is_initialized
-        containing_comp = coil_heating_water_to_air_heat_pump.containingZoneHVACComponent.get
-        # PTHP
-        if containing_comp.to_ZoneHVACPackagedTerminalHeatPump.is_initialized
-          clg_coil = containing_comp.to_ZoneHVACPackagedTerminalHeatPump.get.coolingCoil
-        # WSHP
-        elsif containing_comp.to_ZoneHVACWaterToAirHeatPump.is_initialized
-          clg_coil = containing_comp.to_ZoneHVACWaterToAirHeatPump.get.coolingCoil
-        end
-      end
-    end
-
-    # On AirLoop directly
-    if coil_heating_water_to_air_heat_pump.airLoopHVAC.is_initialized
-      air_loop = coil_heating_water_to_air_heat_pump.airLoopHVAC.get
-      # Check for the presence of any other type of cooling coil
-      clg_types = ['OS:Coil:Cooling:DX:SingleSpeed',
-                   'OS:Coil:Cooling:DX:TwoSpeed',
-                   'OS:Coil:Cooling:DX:MultiSpeed']
-      clg_types.each do |ct|
-        coils = air_loop.supplyComponents(ct.to_IddObjectType)
-        next if coils.empty?
-
-        clg_coil = coils[0]
-        break # Stop on first cooling coil found
-      end
-    end
-
-    # If no paired cooling coil was found,
-    # throw an error and fall back to the heating capacity of the heating coil
-    if clg_coil.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingWaterToAirHeatPumpEquationFit', "For #{coil_heating_water_to_air_heat_pump.name}, the paired cooling coil could not be found to determine capacity. Efficiency will incorrectly be based on coil's heating capacity.")
-      if coil_heating_water_to_air_heat_pump.ratedTotalHeatingCapacity.is_initialized
-        capacity_w = coil_heating_water_to_air_heat_pump.ratedTotalHeatingCapacity.get
-      elsif coil_heating_water_to_air_heat_pump.autosizedRatedTotalHeatingCapacity.is_initialized
-        capacity_w = coil_heating_water_to_air_heat_pump.autosizedRatedTotalHeatingCapacity.get
-      else
-        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingWaterToAirHeatPumpEquationFit', "For #{coil_heating_water_to_air_heat_pump.name} capacity is not available, cannot apply efficiency standard to paired heating coil.")
-        return 0.0
-      end
-      return capacity_w
-    end
-
-    # If a coil was found, cast to the correct type
-    if clg_coil.to_CoilCoolingDXSingleSpeed.is_initialized
-      clg_coil = clg_coil.to_CoilCoolingDXSingleSpeed.get
-      capacity_w = coil_cooling_dx_single_speed_find_capacity(clg_coil)
-    elsif clg_coil.to_CoilCoolingDXTwoSpeed.is_initialized
-      clg_coil = clg_coil.to_CoilCoolingDXTwoSpeed.get
-      capacity_w = coil_cooling_dx_two_speed_find_capacity(clg_coil)
-    elsif clg_coil.to_CoilCoolingDXMultiSpeed.is_initialized
-      clg_coil = clg_coil.to_CoilCoolingDXMultiSpeed.get
-      capacity_w = coil_cooling_dx_multi_speed_find_capacity(clg_coil)
-    elsif clg_coil.to_CoilCoolingWaterToAirHeatPumpEquationFit.is_initialized
-      clg_coil = clg_coil.to_CoilCoolingWaterToAirHeatPumpEquationFit.get
-      capacity_w = coil_cooling_water_to_air_heat_pump_find_capacity(clg_coil)
-    end
-
-    return capacity_w
-  end
-
   # Finds lookup object in standards and return efficiency
   #
   # @param coil_heating_water_to_air_heat_pump [OpenStudio::Model::CoilHeatingWaterToAirHeatPumpEquationFit] coil heating object
@@ -93,7 +9,7 @@ class Standard
   def coil_heating_water_to_air_heat_pump_standard_minimum_cop(coil_heating_water_to_air_heat_pump, rename = false)
     search_criteria = {}
     search_criteria['template'] = template
-    capacity_w = coil_heating_water_to_air_heat_pump_find_capacity(coil_heating_water_to_air_heat_pump)
+    capacity_w = OpenstudioStandards::HVAC.coil_heating_get_paired_coil_cooling_capacity(coil_heating_water_to_air_heat_pump)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
@@ -136,7 +52,7 @@ class Standard
     # Get the search criteria
     search_criteria = {}
     search_criteria['template'] = template
-    capacity_w = coil_heating_water_to_air_heat_pump_find_capacity(coil_heating_water_to_air_heat_pump)
+    capacity_w = OpenstudioStandards::HVAC.coil_heating_get_paired_coil_cooling_capacity(coil_heating_water_to_air_heat_pump)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
 
     # Look up the efficiency characteristics

data/lib/openstudio-standards/standards/Standards.FanVariableVolume.rb

@@ -3,113 +3,6 @@ class Standard
 
   include Fan
 
-  # Modify the fan curve coefficients to reflect a specific type of control.
-  #
-  # @param fan_variable_volume [OpenStudio::Model::FanVariableVolume] variable volume fan object
-  # @param control_type [String] valid choices are:
-  #   Multi Zone VAV with discharge dampers,
-  #   Multi Zone VAV with VSD and SP Setpoint Reset,
-  #   Multi Zone VAV with AF or BI Riding Curve,
-  #   Multi Zone VAV with AF or BI with Inlet Vanes,
-  #   Multi Zone VAV with FC Riding Curve,
-  #   Multi Zone VAV with FC with Inlet Vanes,
-  #   Multi Zone VAV with Vane-axial with Variable Pitch Blades,
-  #   Multi Zone VAV with VSD and Fixed SP Setpoint,
-  #   Multi Zone VAV with VSD and Static Pressure Reset,
-  #   Single Zone VAV Fan
-  # @return [Boolean] returns true if successful, false if not
-  def fan_variable_volume_set_control_type(fan_variable_volume, control_type)
-    # Determine the coefficients
-    coeff_a = nil
-    coeff_b = nil
-    coeff_c = nil
-    coeff_d = nil
-    min_pct_pwr = nil
-    case control_type
-
-    # add 'Multi Zone VAV with discharge dampers' and change the minimum fan power fraction of "Multi Zone VAV with VSD and Static Pressure Reset"
-    when 'Multi Zone VAV with discharge dampers'
-      coeff_a = 0.18984763
-      coeff_b = 0.31447014
-      coeff_c = 0.49568211
-      coeff_d = 0.0
-      min_pct_pwr = 0.25
-    when 'Multi Zone VAV with VSD and SP Setpoint Reset'
-      coeff_a = 0.04076
-      coeff_b = 0.0881
-      coeff_c = -0.0729
-      coeff_d = 0.9437
-      min_pct_pwr = 0.25
-    when 'Multi Zone VAV with AF or BI Riding Curve'
-      coeff_a = 0.1631
-      coeff_b = 1.5901
-      coeff_c = -0.8817
-      coeff_d = 0.1281
-      min_pct_pwr = 0.7
-    when 'Multi Zone VAV with AF or BI with Inlet Vanes'
-      coeff_a = 0.9977
-      coeff_b = -0.659
-      coeff_c = 0.9547
-      coeff_d = -0.2936
-      min_pct_pwr = 0.5
-    when 'Multi Zone VAV with FC Riding Curve'
-      coeff_a = 0.1224
-      coeff_b = 0.612
-      coeff_c = 0.5983
-      coeff_d = -0.3334
-      min_pct_pwr = 0.3
-    when 'Multi Zone VAV with FC with Inlet Vanes'
-      coeff_a = 0.3038
-      coeff_b = -0.7608
-      coeff_c = 2.2729
-      coeff_d = -0.8169
-      min_pct_pwr = 0.3
-    when 'Multi Zone VAV with Vane-axial with Variable Pitch Blades'
-      coeff_a = 0.1639
-      coeff_b = -0.4016
-      coeff_c = 1.9909
-      coeff_d = -0.7541
-      min_pct_pwr = 0.2
-    when 'Multi Zone VAV with VSD and Fixed SP Setpoint'
-      coeff_a = 0.0013
-      coeff_b = 0.1470
-      coeff_c = 0.9506
-      coeff_d = -0.0998
-      min_pct_pwr = 0.2
-    when 'Multi Zone VAV with VSD and Static Pressure Reset'
-      coeff_a = 0.04076
-      coeff_b = 0.0881
-      coeff_c = -0.0729
-      coeff_d = 0.9437
-      min_pct_pwr = 0.1
-    when 'Single Zone VAV Fan'
-      coeff_a = 0.027828
-      coeff_b = 0.026583
-      coeff_c = -0.087069
-      coeff_d = 1.030920
-      min_pct_pwr = 0.1
-    else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.FanVariableVolume', "Fan control type '#{control_type}' not recognized, fan power coefficients will not be changed.")
-      return false
-    end
-
-    OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.FanVariableVolume', "For #{fan_variable_volume.name}: Set fan curve coefficients to reflect control type of '#{control_type}'.")
-
-    # Set the coefficients
-    fan_variable_volume.setFanPowerCoefficient1(coeff_a)
-    fan_variable_volume.setFanPowerCoefficient2(coeff_b)
-    fan_variable_volume.setFanPowerCoefficient3(coeff_c)
-    fan_variable_volume.setFanPowerCoefficient4(coeff_d)
-
-    # Set the fan minimum power
-    fan_variable_volume.setFanPowerMinimumFlowRateInputMethod('Fraction')
-    fan_variable_volume.setFanPowerMinimumFlowFraction(min_pct_pwr)
-
-    # Append the control type to the fan name
-    # self.setName("#{self.name} #{control_type}")
-    return true
-  end
-
   # Determines whether there is a requirement to have a VSD or some other method to reduce fan power at low part load ratios.
   #
   # @param fan_variable_volume [OpenStudio::Model::FanVariableVolume] variable volume fan object

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -237,13 +237,8 @@ class Standard
       # Modify the internal loads in each space type, keeping user-defined schedules.
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.Model', '*** Changing Lighting Loads ***')
       model.getSpaceTypes.sort.each do |space_type|
-        set_people = false
-        set_lights = true
-        set_electric_equipment = false
-        set_gas_equipment = false
-        set_ventilation = false
-        # For PRM, it only applies lights for now.
-        space_type_apply_internal_loads(space_type, set_people, set_lights, set_electric_equipment, set_gas_equipment, set_ventilation)
+        # For PRM, only apply lights for now
+        space_type_apply_internal_loads(space_type, set_people: false, set_lights: true, set_electric_equipment: false, set_gas_equipment: false, set_ventilation: false)
       end
 
       # Modify the lighting schedule to handle lighting occupancy sensors
@@ -555,7 +550,7 @@ class Standard
           # the PRM-RM; Note that the PRM-RM only suggest to increase
           # air zone air flow, but the zone sizing factor in EnergyPlus
           # increase both air flow and load.
-          umlh = OpenstudioStandards::SqlFile.model_get_annual_occupied_unmet_hours(proposed_model)
+          umlh = OpenstudioStandards::SqlFile.model_get_annual_occupied_unmet_hours(model)
           if umlh > 300
             model.getThermalZones.each do |thermal_zone|
               # Cooling adjustments
@@ -774,10 +769,10 @@ class Standard
       end
 
       # This is only used for the stable baseline (2016 and later)
-if !applicable_zones.nil? && !applicable_zones.include?(zone)
-          # This zone is not part of the current hvac_building_type
-          next
-        end
+      if !applicable_zones.nil? && !applicable_zones.include?(zone)
+        # This zone is not part of the current hvac_building_type
+        next
+      end
 
       # Skip unconditioned zones
       heated = OpenstudioStandards::ThermalZone.thermal_zone_heated?(zone)
@@ -3054,11 +3049,24 @@ if !applicable_zones.nil? && !applicable_zones.include?(zone)
   # @return [OpenStudio::Model::Construction] construction object
   # @todo make return an OptionalConstruction
   def model_add_construction(model, construction_name, construction_props = nil, surface = nil)
+    intended_surface_type = construction_props&.[]('intended_surface_type') || ''
+
     # First check model and return construction if it already exists
     model.getConstructions.sort.each do |construction|
       if construction.name.get.to_s == construction_name
         OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.Model', "Already added construction: #{construction_name}")
-        return construction
+        valid = true
+        if !surface.nil?
+          if intended_surface_type == 'GroundContactFloor' && construction.iddObjectType.valueName != 'OS_Construction_FfactorGroundFloor'
+            valid = false
+          elsif intended_surface_type == 'GroundContactWall' && construction.iddObjectType.valueName != 'OS_Construction_CfactorUndergroundWall'
+            valid = false
+          end
+        end
+        if valid
+          return construction
+        end
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.Model', "Already added construction: '#{construction_name}' but its type '#{construction.iddObjectType.valueName}' is not valid for the intended surface type '#{intended_surface_type}'. A new construction will be created.")
       end
     end
 
@@ -3076,12 +3084,31 @@ if !applicable_zones.nil? && !applicable_zones.include?(zone)
       return OpenStudio::Model::OptionalConstruction.new
     end
 
+    intended_surface_type = data["intended_surface_type"]
+    intended_surface_type ||= ''
+
     # Make a new construction and set the standards details
-    if data['intended_surface_type'] == 'GroundContactFloor' && !surface.nil?
-      construction = OpenStudio::Model::FFactorGroundFloorConstruction.new(model)
-    elsif data['intended_surface_type'] == 'GroundContactWall' && !surface.nil?
-      construction = OpenStudio::Model::CFactorUndergroundWallConstruction.new(model)
-    else
+    is_layered_construction = true
+
+    if intended_surface_type == 'GroundContactFloor' && !surface.nil?
+      if construction_props
+        construction = OpenStudio::Model::FFactorGroundFloorConstruction.new(model)
+        is_layered_construction = false
+      else
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.Model', "Construction properties not specified for '#{construction_name}', cannot create F-Factor Ground Floor Construction.  A regular construction will be created instead, and Surface '#{surface.name}' will be set to use the 'Ground' outside boundary condition (previously '#{surface.outsideBoundaryCondition}').")
+        surface.setOutsideBoundaryCondition('Ground')
+      end
+    elsif intended_surface_type == 'GroundContactWall' && !surface.nil?
+      if construction_props
+        construction = OpenStudio::Model::CFactorUndergroundWallConstruction.new(model)
+        is_layered_construction = false
+      else
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.Model', "Construction properties not specified for '#{construction_name}', cannot create C-Factor Underground Wall Construction.  A regular construction will be created instead, and Surface '#{surface.name}' will be set to use the 'Ground' outside boundary condition (previously '#{surface.outsideBoundaryCondition}').")
+        surface.setOutsideBoundaryCondition('Ground')
+      end
+    end
+
+    if is_layered_construction
       construction = OpenStudio::Model::Construction.new(model)
       # Add the material layers to the construction
       layers = OpenStudio::Model::MaterialVector.new
@@ -3096,8 +3123,6 @@ if !applicable_zones.nil? && !applicable_zones.include?(zone)
     construction.setName(construction_name)
     standards_info = construction.standardsInformation
 
-    intended_surface_type = data['intended_surface_type']
-    intended_surface_type ||= ''
     standards_info.setIntendedSurfaceType(intended_surface_type)
 
     standards_construction_type = data['standards_construction_type']