openstudio-standards 0.8.3 → 0.8.5.rc1

data/lib/openstudio-standards/standards/Standards.CoilCoolingDXSingleSpeed.rb

@@ -3,41 +3,6 @@ class Standard
 
   include CoilDX
 
-  # Finds capacity in W
-  #
-  # @param coil_cooling_dx_single_speed [OpenStudio::Model::CoilCoolingDXSingleSpeed] coil cooling dx single speed object
-  # @param necb_ref_hp [Boolean] for compatability with NECB ruleset only.
-  # @param equipment_type [String] type of equipment that this coil object belongs to.
-  # @return [Double] capacity in W to be used for find object
-  def coil_cooling_dx_single_speed_find_capacity(coil_cooling_dx_single_speed, necb_ref_hp = false, equipment_type = nil)
-    capacity_w = nil
-    if coil_cooling_dx_single_speed.ratedTotalCoolingCapacity.is_initialized
-      capacity_w = coil_cooling_dx_single_speed.ratedTotalCoolingCapacity.get
-    elsif coil_cooling_dx_single_speed.autosizedRatedTotalCoolingCapacity.is_initialized
-      capacity_w = coil_cooling_dx_single_speed.autosizedRatedTotalCoolingCapacity.get
-    else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name} capacity is not available, cannot apply efficiency standard.")
-      return 0.0
-    end
-
-    # If it's a PTAC or PTHP System, we need to divide the capacity by the potential zone multiplier
-    # because the COP is dependent on capacity, and the capacity should be the capacity of a single zone, not all the zones
-    if ['PTAC', 'PTHP'].include?(coil_dx_subcategory(coil_cooling_dx_single_speed)) || ['PTAC', 'PTHP'].include?(equipment_type)
-      mult = 1
-      comp = coil_cooling_dx_single_speed.containingZoneHVACComponent
-      if comp.is_initialized && comp.get.thermalZone.is_initialized
-        mult = comp.get.thermalZone.get.multiplier
-        if mult > 1
-          total_cap = capacity_w
-          capacity_w /= mult
-          OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, total capacity of #{OpenStudio.convert(total_cap, 'W', 'kBtu/hr').get.round(2)}kBTU/hr was divided by the zone multiplier of #{mult} to give #{capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get.round(2)}kBTU/hr.")
-        end
-      end
-    end
-
-    return capacity_w
-  end
-
   # Finds lookup object in standards and return efficiency
   #
   # @param coil_cooling_dx_single_speed [OpenStudio::Model::CoilCoolingDXSingleSpeed] coil cooling dx single speed object
@@ -53,12 +18,13 @@ class Standard
     equipment_type = nil
 
     # Define database
-    if coil_dx_heat_pump?(coil_cooling_dx_single_speed)
+    if OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_single_speed)
       database = standards_data['heat_pumps']
     else
       database = standards_data['unitary_acs']
     end
 
+
     # Additional search criteria
     if database[0].keys.include?('equipment_type') || ((template == 'NECB2011') || (template == 'NECB2015') || (template == 'NECB2017') || (template == 'NECB2020') || (template == 'BTAPPRE1980') ||
       (template == 'BTAP1980TO2010'))
@@ -67,7 +33,7 @@ class Standard
         if ['PTAC', 'PTHP'].include?(equipment_type) && template.include?('90.1')
           search_criteria['application'] = coil_dx_packaged_terminal_application(coil_cooling_dx_single_speed)
         end
-      elsif !coil_dx_heat_pump?(coil_cooling_dx_single_speed)
+      elsif !OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_single_speed)
         search_criteria['equipment_type'] = 'Air Conditioners'
       end
     end
@@ -75,7 +41,12 @@ class Standard
       search_criteria['region'] = nil # non-nil values are currently used for residential products
     end
 
-    capacity_w = coil_cooling_dx_single_speed_find_capacity(coil_cooling_dx_single_speed, necb_ref_hp, equipment_type)
+    if ['PTAC', 'PTHP'].include?(equipment_type) || ['PTAC', 'PTHP'].include?(OpenstudioStandards::HVAC.coil_dx_subcategory(coil_cooling_dx_single_speed))
+      thermal_zone = OpenstudioStandards::HVAC.hvac_component_get_thermal_zone(coil_cooling_dx_single_speed)
+      multiplier = thermal_zone.multiplier if !thermal_zone.nil?
+    end
+    # Get the capacity
+    capacity_w = OpenstudioStandards::HVAC.coil_cooling_dx_single_speed_get_capacity(coil_cooling_dx_single_speed, multiplier: multiplier)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
@@ -105,7 +76,7 @@ class Standard
       eer_calc_cap_btu_per_hr = 7000 if capacity_btu_per_hr < 7000
       eer_calc_cap_btu_per_hr = 15_000 if capacity_btu_per_hr > 15_000
       pthp_eer = pthp_eer_coeff_1 - (pthp_eer_coeff_2 * eer_calc_cap_btu_per_hr / 1000.0)
-      cop = eer_to_cop_no_fan(pthp_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(pthp_eer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{pthp_eer.round(1)}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{pthp_eer.round(1)}")
     end
@@ -123,7 +94,7 @@ class Standard
       eer_calc_cap_btu_per_hr = 7000 if capacity_btu_per_hr < 7000
       eer_calc_cap_btu_per_hr = 15_000 if capacity_btu_per_hr > 15_000
       ptac_eer = ptac_eer_coeff_1 - (ptac_eer_coeff_2 * eer_calc_cap_btu_per_hr / 1000.0)
-      cop = eer_to_cop_no_fan(ptac_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(ptac_eer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{ptac_eer.round(1)}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{ptac_eer.round(1)}")
     end
@@ -151,7 +122,7 @@ class Standard
     # If specified as SEER
     unless ac_props['minimum_seasonal_energy_efficiency_ratio'].nil?
       min_seer = ac_props['minimum_seasonal_energy_efficiency_ratio']
-      cop = seer_to_cop_no_fan(min_seer)
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_seer}SEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{template}: #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
     end
@@ -160,7 +131,7 @@ class Standard
     # TODO: assumed to be the same as SEER for now
     unless ac_props['minimum_seasonal_energy_efficiency_ratio_2'].nil?
       min_seer = ac_props['minimum_seasonal_energy_efficiency_ratio_2']
-      cop = seer_to_cop_no_fan(min_seer)
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_seer}SEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{template}: #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
     end
@@ -168,7 +139,7 @@ class Standard
     # If specified as EER
     unless ac_props['minimum_energy_efficiency_ratio'].nil?
       min_eer = ac_props['minimum_energy_efficiency_ratio']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{template}: #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -177,7 +148,7 @@ class Standard
     # TODO: assumed to be the same as EER for now
     unless ac_props['minimum_energy_efficiency_ratio_2'].nil?
       min_eer = ac_props['minimum_energy_efficiency_ratio_2']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{template}: #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -185,7 +156,7 @@ class Standard
     # If specific as IEER
     if !ac_props['minimum_integrated_energy_efficiency_ratio'].nil? && cop.nil?
       min_ieer = ac_props['minimum_integrated_energy_efficiency_ratio']
-      cop = ieer_to_cop_no_fan(min_ieer)
+      cop = OpenstudioStandards::HVAC.ieer_to_cop_no_fan(min_ieer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_ieer}IEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -193,7 +164,7 @@ class Standard
     # If specified as SEER
     unless ac_props['minimum_seasonal_efficiency'].nil?
       min_seer = ac_props['minimum_seasonal_efficiency']
-      cop = seer_to_cop_no_fan(min_seer)
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_seer}SEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{template}: #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
     end
@@ -201,7 +172,7 @@ class Standard
     # If specified as EER (heat pump)
     unless ac_props['minimum_full_load_efficiency'].nil?
       min_eer = ac_props['minimum_full_load_efficiency']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       new_comp_name = "#{coil_cooling_dx_single_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{template}: #{coil_cooling_dx_single_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -222,7 +193,7 @@ class Standard
   # @return [Hash] hash of coil objects
   def coil_cooling_dx_single_speed_apply_efficiency_and_curves(coil_cooling_dx_single_speed, sql_db_vars_map, necb_ref_hp = false)
     # Get efficiencies data depending on whether it is a unitary AC or a heat pump
-    coil_efficiency_data = if coil_dx_heat_pump?(coil_cooling_dx_single_speed)
+    coil_efficiency_data = if OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_single_speed)
                              standards_data['heat_pumps']
                            else
                              standards_data['unitary_acs']
@@ -240,7 +211,7 @@ class Standard
         if ['PTAC', 'PTHP'].include?(equipment_type) && template.include?('90.1')
           search_criteria['application'] = coil_dx_packaged_terminal_application(coil_cooling_dx_single_speed)
         end
-      elsif !coil_dx_heat_pump?(coil_cooling_dx_single_speed)
+      elsif !OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_single_speed)
         search_criteria['equipment_type'] = 'Air Conditioners'
       end
     end
@@ -249,7 +220,11 @@ class Standard
     end
 
     # Get the capacity
-    capacity_w = coil_cooling_dx_single_speed_find_capacity(coil_cooling_dx_single_speed, necb_ref_hp, equipment_type)
+    if ['PTAC', 'PTHP'].include?(equipment_type) || ['PTAC', 'PTHP'].include?(OpenstudioStandards::HVAC.coil_dx_subcategory(coil_cooling_dx_single_speed))
+      thermal_zone = OpenstudioStandards::HVAC.hvac_component_get_thermal_zone(coil_cooling_dx_single_speed)
+      multiplier = thermal_zone.multiplier if !thermal_zone.nil?
+    end
+    capacity_w = OpenstudioStandards::HVAC.coil_cooling_dx_single_speed_get_capacity(coil_cooling_dx_single_speed, multiplier: multiplier)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 

data/lib/openstudio-standards/standards/Standards.CoilCoolingDXTwoSpeed.rb

@@ -3,24 +3,6 @@ class Standard
 
   include CoilDX
 
-  # Finds capacity in W
-  #
-  # @param coil_cooling_dx_two_speed [OpenStudio::Model::CoilCoolingDXTwoSpeed] coil cooling dx two speed object
-  # @return [Double] capacity in W to be used for find object
-  def coil_cooling_dx_two_speed_find_capacity(coil_cooling_dx_two_speed)
-    capacity_w = nil
-    if coil_cooling_dx_two_speed.ratedHighSpeedTotalCoolingCapacity.is_initialized
-      capacity_w = coil_cooling_dx_two_speed.ratedHighSpeedTotalCoolingCapacity.get
-    elsif coil_cooling_dx_two_speed.autosizedRatedHighSpeedTotalCoolingCapacity.is_initialized
-      capacity_w = coil_cooling_dx_two_speed.autosizedRatedHighSpeedTotalCoolingCapacity.get
-    else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{coil_cooling_dx_two_speed.name} capacity is not available, cannot apply efficiency standard.")
-      return 0.0
-    end
-
-    return capacity_w
-  end
-
   # Finds lookup object in standards and return efficiency
   #
   # @param coil_cooling_dx_two_speed [OpenStudio::Model::CoilCoolingDXTwoSpeed] coil cooling dx two speed object
@@ -31,12 +13,9 @@ class Standard
     cooling_type = search_criteria['cooling_type']
     heating_type = search_criteria['heating_type']
     sub_category = search_criteria['subcategory']
-    capacity_w = coil_cooling_dx_two_speed_find_capacity(coil_cooling_dx_two_speed)
-    capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
-    capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
     # Define database
-    if coil_dx_heat_pump?(coil_cooling_dx_two_speed)
+    if OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_two_speed)
       database = standards_data['heat_pumps']
     else
       database = standards_data['unitary_acs']
@@ -44,13 +23,22 @@ class Standard
 
     # Additional search criteria
     if (database[0].keys.include?('equipment_type') || ((template == 'NECB2011') || (template == 'NECB2015') || (template == 'NECB2017') || (template == 'NECB2020') || (template == 'BTAPPRE1980') ||
-      (template == 'BTAP1980TO2010'))) && !coil_dx_heat_pump?(coil_cooling_dx_two_speed)
+      (template == 'BTAP1980TO2010'))) && !OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_two_speed)
       search_criteria['equipment_type'] = 'Air Conditioners'
     end
     if database[0].keys.include?('region')
       search_criteria['region'] = nil # non-nil values are currently used for residential products
     end
 
+    # Get the capacity
+    if ['PTAC', 'PTHP'].include?(OpenstudioStandards::HVAC.coil_dx_subcategory(coil_cooling_dx_two_speed))
+      thermal_zone = OpenstudioStandards::HVAC.hvac_component_get_thermal_zone(coil_cooling_dx_two_speed)
+      multiplier = thermal_zone.multiplier if !thermal_zone.nil?
+    end
+    capacity_w = OpenstudioStandards::HVAC.coil_cooling_dx_two_speed_get_capacity(coil_cooling_dx_two_speed, multiplier: multiplier)
+    capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
+    capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
+
     # Lookup efficiencies depending on whether it is a unitary AC or a heat pump
     ac_props = nil
     ac_props = model_find_object(database, search_criteria, capacity_btu_per_hr, Date.today)
@@ -73,7 +61,7 @@ class Standard
     # If specified as SEER
     unless ac_props['minimum_seasonal_energy_efficiency_ratio'].nil?
       min_seer = ac_props['minimum_seasonal_energy_efficiency_ratio']
-      cop = seer_to_cop_no_fan(min_seer)
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
       new_comp_name = "#{coil_cooling_dx_two_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_seer}SEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_two_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
     end
@@ -82,7 +70,7 @@ class Standard
     # TODO: assumed to be the same as SEER for now
     unless ac_props['minimum_seasonal_energy_efficiency_ratio_2'].nil?
       min_seer = ac_props['minimum_seasonal_energy_efficiency_ratio_2']
-      cop = seer_to_cop_no_fan(min_seer)
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
       new_comp_name = "#{coil_cooling_dx_two_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_seer}SEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_two_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
     end
@@ -90,7 +78,7 @@ class Standard
     # If specified as EER
     unless ac_props['minimum_energy_efficiency_ratio'].nil?
       min_eer = ac_props['minimum_energy_efficiency_ratio']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       new_comp_name = "#{coil_cooling_dx_two_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_two_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -99,7 +87,7 @@ class Standard
     # TODO: assumed to be the same as EER for now
     unless ac_props['minimum_energy_efficiency_ratio_2'].nil?
       min_eer = ac_props['minimum_energy_efficiency_ratio_2']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       new_comp_name = "#{coil_cooling_dx_two_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_two_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -107,7 +95,7 @@ class Standard
     # If specific as IEER
     if !ac_props['minimum_integrated_energy_efficiency_ratio'].nil? && cop.nil?
       min_ieer = ac_props['minimum_integrated_energy_efficiency_ratio']
-      cop = ieer_to_cop_no_fan(min_ieer)
+      cop = OpenstudioStandards::HVAC.ieer_to_cop_no_fan(min_ieer)
       new_comp_name = "#{coil_cooling_dx_two_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_ieer}IEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_two_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; IEER = #{min_ieer}")
     end
@@ -115,7 +103,7 @@ class Standard
     # If specified as SEER (heat pump)
     unless ac_props['minimum_seasonal_efficiency'].nil?
       min_seer = ac_props['minimum_seasonal_efficiency']
-      cop = seer_to_cop_no_fan(min_seer)
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
       new_comp_name = "#{coil_cooling_dx_two_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_seer}SEER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_two_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
     end
@@ -123,7 +111,7 @@ class Standard
     # If specified as EER (heat pump)
     unless ac_props['minimum_full_load_efficiency'].nil?
       min_eer = ac_props['minimum_full_load_efficiency']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       new_comp_name = "#{coil_cooling_dx_two_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingDXTwoSpeed', "For #{template}: #{coil_cooling_dx_two_speed.name}: #{cooling_type} #{heating_type} #{sub_category} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -146,12 +134,16 @@ class Standard
     search_criteria = coil_dx_find_search_criteria(coil_cooling_dx_two_speed)
 
     # Get the capacity
-    capacity_w = coil_cooling_dx_two_speed_find_capacity(coil_cooling_dx_two_speed)
+    if ['PTAC', 'PTHP'].include?(OpenstudioStandards::HVAC.coil_dx_subcategory(coil_cooling_dx_two_speed))
+      thermal_zone = OpenstudioStandards::HVAC.hvac_component_get_thermal_zone(coil_cooling_dx_two_speed)
+      multiplier = thermal_zone.multiplier if !thermal_zone.nil?
+    end
+    capacity_w = OpenstudioStandards::HVAC.coil_cooling_dx_two_speed_get_capacity(coil_cooling_dx_two_speed, multiplier: multiplier)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
     # Get efficiencies data depending on whether it is a unitary AC or a heat pump
-    coil_efficiency_data = if coil_dx_heat_pump?(coil_cooling_dx_two_speed)
+    coil_efficiency_data = if OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_two_speed)
                              standards_data['heat_pumps']
                            else
                              standards_data['unitary_acs']
@@ -159,7 +151,7 @@ class Standard
 
     # Additional search criteria
     if (coil_efficiency_data[0].keys.include?('equipment_type') || ((template == 'NECB2011') || (template == 'NECB2015') || (template == 'NECB2017') || (template == 'NECB2020') || (template == 'BTAPPRE1980') ||
-      (template == 'BTAP1980TO2010'))) && !coil_dx_heat_pump?(coil_cooling_dx_two_speed)
+      (template == 'BTAP1980TO2010'))) && !OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_cooling_dx_two_speed)
       search_criteria['equipment_type'] = 'Air Conditioners'
     end
     if coil_efficiency_data[0].keys.include?('region')

data/lib/openstudio-standards/standards/Standards.CoilCoolingWaterToAirHeatPumpEquationFit.rb

@@ -1,24 +1,6 @@
 class Standard
   # @!group CoilCoolingWaterToAirHeatPumpEquationFit
 
-  # Finds capacity in W
-  #
-  # @param coil_cooling_water_to_air_heat_pump [OpenStudio::Model::CoilCoolingWaterToAirHeatPumpEquationFit] coil cooling object
-  # @return [Double] capacity in W to be used for find object
-  def coil_cooling_water_to_air_heat_pump_find_capacity(coil_cooling_water_to_air_heat_pump)
-    capacity_w = nil
-    if coil_cooling_water_to_air_heat_pump.ratedTotalCoolingCapacity.is_initialized
-      capacity_w = coil_cooling_water_to_air_heat_pump.ratedTotalCoolingCapacity.get
-    elsif coil_cooling_water_to_air_heat_pump.autosizedRatedTotalCoolingCapacity.is_initialized
-      capacity_w = coil_cooling_water_to_air_heat_pump.autosizedRatedTotalCoolingCapacity.get
-    else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name} capacity is not available, cannot apply efficiency standard.")
-      return 0.0
-    end
-
-    return capacity_w
-  end
-
   # Finds lookup object in standards and return efficiency
   #
   # @param coil_cooling_water_to_air_heat_pump [OpenStudio::Model::CoilCoolingWaterToAirHeatPumpEquationFit] coil cooling object
@@ -34,10 +16,15 @@ class Standard
       heating_type = 'All Other'
       sub_category = 'CRAC'
     end
-    capacity_w = coil_cooling_water_to_air_heat_pump_find_capacity(coil_cooling_water_to_air_heat_pump)
+    capacity_w = OpenstudioStandards::HVAC.coil_cooling_water_to_air_heat_pump_get_capacity(coil_cooling_water_to_air_heat_pump)
+
+    # Check to make sure properties were found
+    if capacity_w.nil? || capacity_w < 1
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot determine capacity.")
+      return nil
+    end
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
-    return nil unless capacity_kbtu_per_hr > 0.0
 
     # Look up the efficiency characteristics
     if computer_room_air_conditioner
@@ -71,7 +58,7 @@ class Standard
     # If specified as EER (heat pump)
     unless coil_props['minimum_full_load_efficiency'].nil?
       min_eer = coil_props['minimum_full_load_efficiency']
-      cop = eer_to_cop_no_fan(min_eer, capacity_w = nil)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer, capacity_w = nil)
       new_comp_name = "#{coil_cooling_water_to_air_heat_pump.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{template}: #{coil_cooling_water_to_air_heat_pump.name}: Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end
@@ -116,7 +103,7 @@ class Standard
     # Get the search criteria
     search_criteria = {}
     search_criteria['template'] = template
-    capacity_w = coil_cooling_water_to_air_heat_pump_find_capacity(coil_cooling_water_to_air_heat_pump)
+    capacity_w = OpenstudioStandards::HVAC.coil_cooling_water_to_air_heat_pump_get_capacity(coil_cooling_water_to_air_heat_pump)
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
 
     # Look up the efficiency characteristics

data/lib/openstudio-standards/standards/Standards.CoilDX.rb

@@ -4,152 +4,6 @@
 module CoilDX
   # @!group CoilDX
 
-  # Finds the subcategory.  Possible choices are:
-  # Single Package, Split System, PTAC, or PTHP
-  #
-  # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
-  #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
-  # @return [String] the coil_dx_subcategory(coil_dx)
-  # @todo Add add split system vs single package to model object
-  def coil_dx_subcategory(coil_dx)
-    sub_category = 'Single Package'
-
-    # Fallback to the name, mainly for library export
-    if coil_dx.name.get.to_s.include?('Single Package')
-      sub_category = 'Single Package'
-    elsif coil_dx.name.get.to_s.include?('Split System') ||
-          coil_dx.name.get.to_s.include?('Central Air Source HP')
-      sub_category = 'Split System'
-    elsif coil_dx.name.get.to_s.include?('Minisplit HP')
-      sub_category = 'Minisplit System'
-    elsif coil_dx.name.get.to_s.include?('CRAC')
-      sub_category = 'CRAC'
-    end
-
-    return sub_category
-  end
-
-  # Determine if it is a heat pump
-  #
-  # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object
-  # @return [Boolean] returns true if it is a heat pump, false if not
-  def coil_dx_heat_pump?(coil_dx)
-    heat_pump = false
-
-    if coil_dx.airLoopHVAC.empty?
-      if coil_dx.containingHVACComponent.is_initialized
-        containing_comp = coil_dx.containingHVACComponent.get
-        if containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.is_initialized
-          heat_pump = true
-        elsif containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.is_initialized
-          htg_coil = containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.get.heatingCoil
-          if htg_coil.to_CoilHeatingDXMultiSpeed.is_initialized then heat_pump = true end
-        end
-      elsif coil_dx.containingZoneHVACComponent.is_initialized
-        containing_comp = coil_dx.containingZoneHVACComponent.get
-        # PTHP
-        if containing_comp.to_ZoneHVACPackagedTerminalHeatPump.is_initialized
-          heat_pump = true
-        end
-        # @todo Add other zone hvac systems
-      end
-    else
-      if !coil_dx.airLoopHVAC.get.supplyComponents('OS:Coil:Heating:DX:SingleSpeed'.to_IddObjectType).empty? ||
-         !coil_dx.airLoopHVAC.get.supplyComponents('OS:Coil:Heating:DX:VariableSpeed'.to_IddObjectType).empty?
-        heat_pump = true
-      end
-    end
-
-    return heat_pump
-  end
-
-  # Determine the heating type.
-  # Possible choices are: Electric Resistance or None, All Other
-  #
-  # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
-  #   CoilCoolingDXSingleSpeed, CoilCoolingDXTwoSpeed, CoilCoolingDXMultiSpeed
-  # @param necb_ref_hp [Boolean] for compatability with NECB ruleset only.
-  # @return [String] the heating type
-  def coil_dx_heating_type(coil_dx, necb_ref_hp = false)
-    htg_type = nil
-
-    # If Unitary or Zone HVAC (could be a unitary system on an air loop)
-    if coil_dx.airLoopHVAC.empty?
-      if coil_dx.containingHVACComponent.is_initialized
-        containing_comp = coil_dx.containingHVACComponent.get
-        if containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.is_initialized
-          htg_type = 'Electric Resistance or None'
-        elsif containing_comp.to_AirLoopHVACUnitarySystem.is_initialized
-          htg_coil = containing_comp.to_AirLoopHVACUnitarySystem.get.heatingCoil
-          if containing_comp.name.to_s.include? 'Minisplit'
-            htg_type = 'All Other'
-          elsif htg_coil.is_initialized
-            htg_coil = htg_coil.get
-            if htg_coil.to_CoilHeatingElectric.is_initialized || htg_coil.to_CoilHeatingDXMultiSpeed.is_initialized
-              htg_type = 'Electric Resistance or None'
-            elsif htg_coil.to_CoilHeatingGas.is_initialized || htg_coil.to_CoilHeatingGasMultiStage.is_initialized || htg_coil.to_CoilHeatingWater.is_initialized
-              htg_type = 'All Other'
-            end
-          else
-            htg_type = 'Electric Resistance or None'
-          end
-        elsif containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.is_initialized
-          htg_coil = containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.get.heatingCoil
-          supp_htg_coil = containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAirMultiSpeed.get.supplementalHeatingCoil
-          if htg_coil.to_CoilHeatingDXMultiSpeed.is_initialized || supp_htg_coil.to_CoilHeatingElectric.is_initialized
-            htg_type = 'Electric Resistance or None'
-          elsif htg_coil.to_CoilHeatingGas.is_initialized || htg_coil.to_CoilHeatingGasMultiStage.is_initialized || htg_coil.to_CoilHeatingWater.is_initialized
-            htg_type = 'All Other'
-          end
-        end
-        # @todo Add other unitary systems
-      elsif coil_dx.containingZoneHVACComponent.is_initialized
-        containing_comp = coil_dx.containingZoneHVACComponent.get
-        # PTAC
-        if containing_comp.to_ZoneHVACPackagedTerminalAirConditioner.is_initialized
-          htg_coil = containing_comp.to_ZoneHVACPackagedTerminalAirConditioner.get.heatingCoil
-          if htg_coil.to_CoilHeatingElectric.is_initialized
-            htg_type = 'Electric Resistance or None'
-          elsif htg_coil.to_CoilHeatingGas.is_initialized || htg_coil.to_CoilHeatingGasMultiStage.is_initialized || htg_coil.to_CoilHeatingWater.is_initialized
-            htg_type = 'All Other'
-          end
-        # PTHP
-        elsif containing_comp.to_ZoneHVACPackagedTerminalHeatPump.is_initialized
-          htg_type = 'Electric Resistance or None'
-        end
-        # @todo Add other zone hvac systems
-      end
-    end
-
-    # If on an AirLoop
-    if coil_dx.airLoopHVAC.is_initialized
-      air_loop = coil_dx.airLoopHVAC.get
-      htg_type = if !air_loop.supplyComponents('OS:Coil:Heating:Gas'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:Water'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:DX:SingleSpeed'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:DX:MultiSpeed'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:DX:VariableSpeed'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:Gas:MultiStage'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:Desuperheater'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:WaterToAirHeatPump:EquationFit'.to_IddObjectType).empty?
-                   'All Other'
-                 elsif !air_loop.supplyComponents('OS:Coil:Heating:Electric'.to_IddObjectType).empty?
-                   'Electric Resistance or None'
-                 else
-                   'Electric Resistance or None'
-                 end
-    end
-
-    return htg_type
-  end
-
   # Finds the search criteria
   #
   # @param coil_dx [OpenStudio::Model::StraightComponent] coil cooling object, allowable types:
@@ -173,20 +27,24 @@ module CoilDX
                                         'AirCooled'
                                       end
 
-    # Subcategory
-    search_criteria['subcategory'] = coil_dx_subcategory(coil_dx)
+    # Get the coil subcategory
+    search_criteria['subcategory'] = OpenstudioStandards::HVAC.coil_dx_subcategory(coil_dx)
 
     # Add the heating type to the search criteria
-    case coil_dx.iddObjectType.valueName.to_s
-    when 'OS_Coil_Cooling_DX_SingleSpeed',
-         'OS_Coil_Cooling_DX_TwoSpeed',
-         'OS_Coil_Cooling_DX_VariableSpeed',
-         'OS_Coil_Cooling_DX_MultiSpeed',
-         'OS_AirConditioner_VariableRefrigerantFlow'
-      htg_type = coil_dx_heating_type(coil_dx, necb_ref_hp)
-      unless htg_type.nil?
-        search_criteria['heating_type'] = htg_type
+    htg_type = OpenstudioStandards::HVAC.coil_dx_heating_type(coil_dx)
+    unless htg_type.nil?
+      search_criteria['heating_type'] = htg_type
+    end
+
+    # The heating side of unitary heat pumps don't have a heating type as part of the search
+    if coil_dx.to_CoilHeatingDXSingleSpeed.is_initialized &&
+      OpenstudioStandards::HVAC.coil_dx_heat_pump?(coil_dx) &&
+       coil_dx.airLoopHVAC.empty? && coil_dx.containingHVACComponent.is_initialized
+      containing_comp = coil_dx.containingHVACComponent.get
+      if containing_comp.to_AirLoopHVACUnitaryHeatPumpAirToAir.is_initialized
+        search_criteria['heating_type'] = nil
       end
+      # @todo Add other unitary systems
     end
 
     # Get the equipment type

data/lib/openstudio-standards/standards/Standards.CoilHeatingDXMultiSpeed.rb

@@ -161,7 +161,7 @@ class Standard
     # If specified as SEER
     unless hp_props['minimum_seasonal_energy_efficiency_ratio'].nil?
       min_seer = hp_props['minimum_seasonal_energy_efficiency_ratio']
-      cop = seer_to_cop_no_fan(min_seer)
+      cop = OpenstudioStandards::HVAC.seer_to_cop_no_fan(min_seer)
       coil_heating_dx_multi_speed.setName("#{coil_heating_dx_multi_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_seer}SEER")
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXMultiSpeed', "For #{template}: #{coil_heating_dx_multi_speed.name}: #{suppl_heating_type} #{subcategory} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; SEER = #{min_seer}")
     end
@@ -169,7 +169,7 @@ class Standard
     # If specified as EER
     unless hp_props['minimum_energy_efficiency_ratio'].nil?
       min_eer = hp_props['minimum_energy_efficiency_ratio']
-      cop = eer_to_cop_no_fan(min_eer)
+      cop = OpenstudioStandards::HVAC.eer_to_cop_no_fan(min_eer)
       coil_heating_dx_multi_speed.setName("#{coil_heating_dx_multi_speed.name} #{capacity_kbtu_per_hr.round}kBtu/hr #{min_eer}EER")
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXMultiSpeed', "For #{template}: #{coil_heating_dx_multi_speed.name}:  #{suppl_heating_type} #{subcategory} Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; EER = #{min_eer}")
     end