foodcritic 15.0.0 → 15.1.0

data/spec/functional/fc038_spec.rb

@@ -1,28 +0,0 @@
-require "spec_helper"
-
-describe "FC038" do
-
-  context "on chef 12.6.4 with a cookbook that locks an apt_package" do
-    foodcritic_command("--chef-version", "13.6.4 ", "--no-progress", ".")
-    recipe_file <<-EOH
-    apt_package 'foo' do
-      action :lock
-    end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  # todo: update this when we introduce a new action
-  # we can't actually test this since we haven't introduced any new actions
-  # in the chef 13 cycle
-
-  # context "on chef 12.15.19 with a cookbook that locks an apt_package" do
-  #   foodcritic_command("--chef-version", "12.15.19", "--no-progress", ".")
-  #   recipe_file <<-EOH
-  #   apt_package 'foo' do
-  #     action :lock
-  #   end
-  #   EOH
-  #   it { is_expected.to violate_rule }
-  # end
-end

data/spec/functional/fc040_spec.rb

@@ -1,156 +0,0 @@
-require "spec_helper"
-
-describe "FC040" do
-  context "with a recipe that contains an execute resource named 'git pull'" do
-    recipe_file <<-EOH
-  execute 'git pull' do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource named 'git clone'" do
-    recipe_file <<-EOH
-  execute 'git clone' do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource named 'git fetch'" do
-    recipe_file <<-EOH
-  execute 'git fetch' do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource named 'git checkout'" do
-    recipe_file <<-EOH
-  execute 'git checkout' do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource named 'git reset --hard'" do
-    recipe_file <<-EOH
-  execute 'git reset --hard' do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource named 'git show'" do
-    recipe_file <<-EOH
-  execute 'git show' do
-    action :run
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource named 'echo 'bob' && git show'" do
-    recipe_file <<-EOH
-  execute "echo 'bob' && git show" do
-    action :run
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'git clone https://github.com/git/git.git'" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git clone https://github.com/git/git.git'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'git clone --depth 10 https://github.com/git/git.git'" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git clone --depth 10 https://github.com/git/git.git'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'get checkout master'" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git checkout master'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'git reset --hard'" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git reset hard'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'git pull" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git pull'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'git fetch origin'" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git fetch origin'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'git status && git pull   '" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git status && git pull'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'git show'" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'git show'
-    action :run
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run 'curl http://github.com/  '" do
-    recipe_file <<-EOH
-  execute "a git command" do
-    command 'curl http://github.com/  '
-    action :run
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc041_spec.rb

@@ -1,121 +0,0 @@
-require "spec_helper"
-
-describe "FC041" do
-  context "with a recipe that contains an execute resource to run curl" do
-    recipe_file <<-EOH
-  execute 'curl "http://www.chef.io/"' do
-    action :run
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run which curl" do
-    recipe_file <<-EOH
-  execute 'which curl' do
-    action :run
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run wget" do
-    recipe_file <<-EOH
-  execute 'wget "http://www.chef.io/"' do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run sudo wget" do
-    recipe_file <<-EOH
-  execute 'sudo wget "http://www.chef.io/"' do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to curl with -o" do
-    recipe_file <<-EOH
-  execute "curl 'http://example.org/' -o foo" do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to curl with a post request" do
-    recipe_file <<-EOH
-  execute "curl -X POST 'http://example.org/'" do
-    action :run
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to curl with --output" do
-    recipe_file <<-EOH
-  execute "curl 'http://example.org/' --output foo" do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to curl with --output" do
-    recipe_file <<-EOH
-  execute "curl 'http://example.org/' --output foo" do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to curl then redirect stdout" do
-    recipe_file <<-EOH
-  execute "curl 'http://example.org/' > foo" do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to curl then redirect stdout/stderr" do
-    recipe_file <<-EOH
-  execute "curl 'http://example.org/' &> foo" do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource to run something & wget" do
-    recipe_file <<-EOH
-  execute "mkdir bob && wget 'http://example.org/'" do
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource with command run sudo wget" do
-    recipe_file <<-EOH
-  execute 'my command' do
-    command 'sudo wget "http://www.chef.io/"'
-    action :run
-  end
-  EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that contains an execute resource with command run which curl" do
-    recipe_file <<-EOH
-  execute 'my command' do
-    command 'which curl'
-  end
-  EOH
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc042_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC042" do
-  context "with a cookbook with a single recipe that uses require_recipe" do
-    recipe_file "require_recipe 'my_recipe::default'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that uses include_recipe" do
-    recipe_file "include_recipe 'my_recipe::default'"
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc043_spec.rb

@@ -1,28 +0,0 @@
-require "spec_helper"
-
-describe "FC043" do
-  context "with a cookbook that has no notifications" do
-    recipe_file <<-EOH
-      cookbook_file "something"
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a resource that notifies a service to restart" do
-    recipe_file <<-EOH
-    template "/etc/apache.conf" do
-      notifies :start, "service[apache]"
-    end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a resource that uses the old notification syntax" do
-    recipe_file <<-EOH
-    template "/etc/www/configures-apache.conf" do
-      notifies :restart, resources(:service => "apache")
-    end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc045_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC045" do
-  context "with a cookbook with a metadata file that includes the name keyword" do
-    metadata_file "name 'food'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that doesn't include the name keyword" do
-    metadata_file
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook without a metadata file" do
-    recipe_file
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc048_spec.rb

@@ -1,67 +0,0 @@
-require "spec_helper"
-
-describe "FC048" do
-  context "with a recipe that uses simple backticks" do
-    recipe_file "`ls`"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses %x and  containing a variable" do
-    recipe_file '`#{cmd}`'
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses %x and curly brackets" do
-    recipe_file "%x{ls}"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses %x and square brackets" do
-    recipe_file "%x[ls]"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses %x and curly brackets containing a variable" do
-    recipe_file '%x{#{cmd} some_dir}'
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses system without parantheses" do
-    recipe_file 'system "ls"'
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses system without parantheses and a variable" do
-    recipe_file "system cmd"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses system with parantheses" do
-    recipe_file 'system("ls")'
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses system with parantheses and a variable" do
-    recipe_file "system(cmd)"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses Mixlib::ShellOut" do
-    recipe_file "Mixlib::ShellOut.new('ls').run_command"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that uses shell_out" do
-    recipe_file "shell_out('ls')"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a recipe that specifies system in a user resource" do
-    recipe_file <<-EOF
-    user 'foo' do
-      system true
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc049_spec.rb

@@ -1,56 +0,0 @@
-require "spec_helper"
-
-describe "FC049" do
-  foodcritic_command("--no-progress", "-R", "roles")
-
-  context "with webserver.rb" do
-    context "with name webserver" do
-      file "roles/webserver.rb", 'name "webserver"'
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name apache" do
-      file "roles/webserver.rb", 'name "apache"'
-      it { is_expected.to violate_rule }
-    end
-
-    context "with a string expression in the name" do
-      file "roles/webserver.rb", 'name "ap#{ache}"'
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with multiple names" do
-      file "roles/webserver.rb", "name 'apache'\nname 'webserver'"
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with multiple mismatched names" do
-      file "roles/webserver.rb", "name 'webserver'\nname 'apache'"
-      it { is_expected.to violate_rule }
-    end
-  end
-
-  context "with webserver.json" do
-    context "with name webserver" do
-      file "roles/webserver.json", '{"name": "webserver"}'
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name apache" do
-      file "roles/webserver.json", '{"name": "apache"}'
-      it { is_expected.to_not violate_rule }
-    end
-  end
-
-  context "in -B mode" do
-    foodcritic_command("--no-progress", "-B", "roles")
-    file "roles/webserver.rb", 'name "apache"'
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "in normal mode" do
-    foodcritic_command("--no-progress", "roles")
-    file "roles/webserver.rb", 'name "apache"'
-    it { is_expected.to_not violate_rule }
-  end
-end