foodcritic 15.0.0 → 15.1.0

data/spec/functional/fc010_spec.rb

@@ -1,32 +0,0 @@
-require "spec_helper"
-
-describe "FC010" do
-  context "with a cookbook with a recipe that attempts to perform a search with invalid syntax" do
-    recipe_file <<-EOH
-    search(:node, 'run_list:recipe[foo::bar]') do |matching_node|
-      puts matching_node.to_s
-    end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that attempts to perform a search with valid syntax" do
-    recipe_file <<-EOH
-    search(:node, 'run_list:recipe\\[foo\\:\\:bar\\]') do |matching_node|
-      puts matching_node.to_s
-    end
-    EOH
-
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that attempts to perform a search with a subexpression" do
-    recipe_file <<-EOH
-    search(:node, "roles:\#{node['foo']['role']}") do |matching_node|
-      puts matching_node.to_s
-    end
-    EOH
-
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc011_spec.rb

@@ -1,20 +0,0 @@
-require "spec_helper"
-
-describe "FC011" do
-  context "with a cookbook with a README.md file" do
-    metadata_file "name 'mycookbook'"
-    file("README.md")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook without a README.md file" do
-    metadata_file "name 'mycookbook'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a README.rdoc file" do
-    metadata_file "name 'mycookbook'"
-    file("README.rdoc")
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc013_spec.rb

@@ -1,39 +0,0 @@
-require "spec_helper"
-
-describe "FC013" do
-  context "with a cookbook that downloads a file to /tmp" do
-    recipe_file <<-EOH
-      remote_file "/tmp/large-file.tar.gz" do
-        source "http://www.example.org/large-file.tar.gz"
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook that downloads a file to /tmp with an expression" do
-    recipe_file <<-'EOH'
-      remote_file "/tmp/#{the_file}" do
-        source "http://www.example.org/large-file.tar.gz"
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook that downloads a file to a users home directory" do
-    recipe_file <<-EOH
-      remote_file "/home/ernie/large-file.tar.gz" do
-        source "http://www.example.org/large-file.tar.gz"
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook that downloads a file to the Chef file cache" do
-    recipe_file <<-'EOH'
-      remote_file '#{Chef::Config[:file_cache_path]}/large-file.tar.gz' do
-        source "http://www.example.org/large-file.tar.gz"
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc015_spec.rb

@@ -1,19 +0,0 @@
-require "spec_helper"
-
-describe "FC015" do
-  context "with a cookbook that contains a definition" do
-    definition_file <<-EOH
-    define :apache_site, :enable => true do
-      log "I am a definition"
-    end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook that does not contain a definition" do
-    recipe_file <<-EOH
-      cookbook_file "/etc/foo"
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc016_spec.rb

@@ -1,57 +0,0 @@
-require "spec_helper"
-
-describe "FC016" do
-
-  context "with a cookbook with a LWRP that includes a default_action" do
-    resource_file <<-EOH
-      actions :create, :remove
-      default_action :create
-
-      attribute :name, String, name_attribute: true
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that includes a non-DSL default_action" do
-    resource_file <<-EOH
-      actions :create, :remove,
-
-      def initialize(*args)
-        super
-        @action = :create
-      end
-
-      attribute :name, String, name_attribute: true
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that does not include a default_action" do
-    resource_file <<-EOH
-      actions :create, :remove,
-
-      attribute :name, String, name_attribute: true
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a custom resource that includes a property" do
-    resource_file <<-EOH
-      property :name, String, name_property: true
-
-      action :create do
-        cookbook_file "/etc/something"
-      end
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a custom resource that includes only an action" do
-    resource_file <<-EOH
-      action :create do
-        cookbook_file "/etc/something"
-      end
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc025_spec.rb

@@ -1,60 +0,0 @@
-require "spec_helper"
-
-describe "FC025" do
-  context "with a recipe that does a blockless gem_package install" do
-    recipe_file <<-EOH
-      gem_package 'foo'
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a recipe that does a gem_package install" do
-    recipe_file <<-EOH
-      gem_package 'foo' do
-        action :install
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a recipe that does a gem_package install with a nothing action" do
-    recipe_file <<-EOH
-      gem_package 'foo' do
-        action :nothing
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a recipe that does a compile_time gem install from an array" do
-    recipe_file <<-EOH
-    %w{bencode i18n transmission-simple}.each do |pkg|
-      r = gem_package pkg do
-        action :nothing
-      end
-      r.run_action(:install)
-    end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that does a compile_time gem install" do
-    recipe_file <<-EOH
-    r = gem_package "activesupport" do
-      version '2.3.11'
-      action :nothing
-    end
-    r.run_action(:install)
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that does a compile_time gem upgrade" do
-    recipe_file <<-EOH
-    r = gem_package "activesupport" do
-      version '2.3.11'
-      action :nothing
-    end
-    r.run_action(:upgrade)
-    EOH
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc026_spec.rb

@@ -1,66 +0,0 @@
-require "spec_helper"
-
-describe "FC026" do
-  context "with a recipe that has a bracketed conditional that shouldn't be in a block" do
-    recipe_file <<-EOH
-      file 'foo' do
-        not_if { "ls foo" }
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that has a conditional that shouldn't be in a block" do
-    recipe_file <<-EOH
-      file 'foo' do
-        not_if do "ls foo" end
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that has a conditional with a variable that shouldn't be in a block" do
-    recipe_file <<-EOH
-      file 'foo' do
-        only_if { "ls \#{node['foo']['path']}" }
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that has a conditional with a method that shouldn't be in a block" do
-    recipe_file <<-EOH
-      file 'foo' do
-        not_if { "ls \#{foo.method()}" }
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that has a conditional of foo.bar" do
-    recipe_file <<-EOH
-      file 'foo' do
-        only_if { foo.bar }
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a recipe that has a conditional of foo.to_s" do
-    recipe_file <<-EOH
-      file 'foo' do
-        not_if { foo.to_s }
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a recipe that has a conditional of File.exists?('/etc/foo')" do
-    recipe_file <<-EOH
-      file 'foo' do
-        not_if { File.exists?("/etc/foo") }
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc028_spec.rb

@@ -1,93 +0,0 @@
-require "spec_helper"
-
-describe "FC028" do
-  context "with a cookbook with a single recipe that calls platform? without parentheses for a single platform" do
-    recipe_file "platform? 'ubuntu'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls platform? without parentheses for two platforms" do
-    recipe_file "platform?('ubuntu','windows')"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls platform? with parentheses for a single platform" do
-    recipe_file "platform?('ubuntu')"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls platform? with parentheses for two platforms" do
-    recipe_file "platform?('ubuntu', 'windows')"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that compares a value against node.platform" do
-    recipe_file "node.platform == 'ubuntu'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that uses checks a value against node.platform" do
-    recipe_file "node.platform == 'ubuntu'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls node.platform? without a parentheses" do
-    recipe_file "node.platform? 'ubuntu'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls node.platform? with a parentheses" do
-    recipe_file "node.platform?('ubuntu')"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls node.platform? with a parentheses for 2 platforms" do
-    recipe_file "node.platform?('ubuntu', 'windows')"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls platform_family? without parentheses for a single platform family" do
-    recipe_file "platform_family? 'debian'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls platform_family? without parentheses for two plaform families" do
-    recipe_file "platform_family?('debian','windows')"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls platform_family? with parentheses for a single plaform family" do
-    recipe_file "platform_family?('debian')"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls platform_family? with parentheses for two plaform families" do
-    recipe_file "platform_family?('debian', 'windows')"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that compares a value against node.platform_family" do
-    recipe_file "node.platform_family == 'debian'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that uses checks a value against node.platform_family" do
-    recipe_file "node.platform_family == 'debian'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls node.platform_family? without a parentheses" do
-    recipe_file "node.platform_family? 'debian'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls node.platform_family? with a parentheses" do
-    recipe_file "node.platform_family?('debian')"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a single recipe that calls node.platform_family? with a parentheses for 2 plaform families" do
-    recipe_file "node.platform_family?('debian', 'windows')"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc029_spec.rb

@@ -1,33 +0,0 @@
-require "spec_helper"
-
-describe "FC029" do
-  context "with a cookbook with a metadata file that doesn't contain the recipe keyword" do
-    metadata_file("name 'example'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that contains contain the recipe keyword with the cookbook name only" do
-    metadata_file("name 'example'\nrecipe 'example', 'Installs Example'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that contains the recipe keyword with the cookbook::recipe format name" do
-    metadata_file("name 'example'\nrecipe 'example::default', 'Installs Example'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that contains the recipe keyword and lacks the cookbook name" do
-    metadata_file("name 'example'\nrecipe 'default', 'Installs Example'")
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that contains the recipe keyword and stores full recipe name as a var" do
-    metadata_file("name 'example'\nvar = 'example::default'\nrecipe my_var, 'Installs Example'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that contains the recipe keyword and stores part of the recipe name as a var" do
-    metadata_file('name "example"\nvar = "example"\nrecipe "#{my_var}::default", "Installs Example"')
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc031_spec.rb

@@ -1,14 +0,0 @@
-require "spec_helper"
-
-describe "FC031" do
-  context "with a cookbook with a metadata file" do
-    metadata_file
-    recipe_file
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook without a metadata file" do
-    recipe_file
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc037_spec.rb

@@ -1,75 +0,0 @@
-require "spec_helper"
-
-describe "FC037" do
-  context "with a resource that notifies using an action that is a string" do
-    recipe_file <<-EOF
-    file '/tmp/b.txt' do
-      content 'content'
-      notifies 'restart', 'service[httpd]', :delayed
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a resource that notifies using an action as a symbol" do
-    recipe_file <<-EOF
-    file '/tmp/a.txt' do
-      content 'content'
-      notifies :restart, 'service[httpd]', :delayed
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a resource that notifies using an action as a :'symbol'" do
-    recipe_file <<-EOF
-    file '/tmp/a.txt' do
-      content 'content'
-      notifies :'restart', 'service[httpd]', :delayed
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a resource that notifies using an action that is an attribute" do
-    recipe_file <<-EOF
-    file '/tmp/a.txt' do
-      content 'content'
-      notifies node['foo']['bar'], 'service[httpd]', :delayed
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a resource that notifies using an action that is a resource property" do
-    recipe_file <<-EOF
-    file '/tmp/a.txt' do
-      content 'content'
-      notifies new_resource.bob, 'service[httpd]', :delayed
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a resource that notifies using an action that is a variable" do
-    recipe_file <<-EOF
-      file '/tmp/a.txt' do
-        content 'content'
-        notifies foo, 'service[httpd]', :delayed
-      end
-      EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a resource that notifies with a variable in a loop" do
-    recipe_file <<-EOF
-      file '/tmp/a.txt' do
-        content 'content'
-        Array(node['foo']['bar']).each do |action|
-          notifies action, 'service[httpd]', :delayed
-        end
-      end
-      EOF
-    it { is_expected.not_to violate_rule }
-  end
-end