foodcritic 15.0.0 → 15.1.0

data/spec/functional/fc067_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC067" do
-  context "with a cookbook with a metadata file that does not specify supports" do
-    metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a supported platform (anything)" do
-    metadata_file "supports 'some_os'"
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc068_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC068" do
-  context "with a cookbook with a metadata file that does not specify the license" do
-    metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a license (anything)" do
-    metadata_file "license 'My Super Cool License'"
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc069_spec.rb

@@ -1,38 +0,0 @@
-require "spec_helper"
-
-describe "FC069" do
-  context "with a cookbook with a metadata file that specifies a license generated by knife cookbook create" do
-    metadata_file "license 'Apache 2.0'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a license generated by chef generate cookbook" do
-    metadata_file "license 'apache_2'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a valid SPDX license" do
-    metadata_file "license 'Apache-2.0'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies ChefDK's non-SPDX all rights reserved string" do
-    metadata_file "license 'All Rights Reserved'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies ChefDK's non-SPDX all rights reserved string with a different casing" do
-    metadata_file "license 'All rights reserved'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a license with parens" do
-    metadata_file "license('Apache-2.0')"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that does not specifiy a license" do
-    metadata_file
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc070_spec.rb

@@ -1,65 +0,0 @@
-require "spec_helper"
-
-describe "FC070" do
-  context "with a cookbook with a metadata file specifying a single valid supports statement" do
-    metadata_file "supports 'ubuntu'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file specifying multiple valid supports statements" do
-    metadata_file "%w(ubuntu debian fedora).each do |plat|\nsupports plat\nend"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file specifying a single invalid supports statement" do
-    metadata_file "supports 'aws'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file specifying multiple invalid supports statements" do
-    metadata_file "%w(aws oel rhel).each do |plat|\nsupports plat\nend"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file specifying a mix of valid and invalid supports statements" do
-    metadata_file "%w(aws oracle scientific).each do |plat|\nsupports plat\nend"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file specifying a valid supports platform, but uppercase" do
-    metadata_file "supports 'UBUNTU'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file specifying a valid supports platform, but with a version string" do
-    metadata_file "supports 'ubuntu >= 16.04'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file specifying valid platforms from an array with leading whitespace" do
-    metadata_file <<-'EOH'
-    %w(
-      amazon
-      centos
-      debian
-      fedora
-      redhat
-      scientific
-      oracle
-      ubuntu
-    ).each do |os|
-      supports os
-    end
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a word list and a version constraint" do
-    metadata_file <<-EOH
-      %w{ redhat centos scientific amazon }.each do |os|
-        supports os, ">= 5.0"
-      end
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc071_spec.rb

@@ -1,36 +0,0 @@
-require "spec_helper"
-
-describe "FC071" do
-  context "with a cookbook with a LICENSE file" do
-    metadata_file "name 'mycookbook'"
-    file("LICENSE")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook without a LICENSE file" do
-    metadata_file "name 'mycookbook'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook without a LICENSE file but with license of 'All Rights Reserved'" do
-    metadata_file "license 'All Rights Reserved'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook without a LICENSE file but with license of 'all rights reserved'" do
-    metadata_file "license 'all rights reserved'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook without a LICENSE file, using a sub folder" do
-    subject { foodcritic_command("--no-progress", "mycookbook/") }
-    file "mycookbook/metadata.rb"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook without a LICENSE file but with license of 'All Rights Reserved', using a sub folder" do
-    subject { foodcritic_command("--no-progress", "mycookbook/") }
-    file "mycookbook/metadata.rb", "license 'All Rights Reserved'"
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc072_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC072" do
-  context "with a cookbook with a metadata file that contains an attribute keyword" do
-    metadata_file "attribute 'something/something',\n    display_name: 'something tuneable',\n    description: 'This tunes something',\n    default: 'none'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that doesn't contain an attribute keyword" do
-    metadata_file
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc073_spec.rb

@@ -1,56 +0,0 @@
-require "spec_helper"
-
-describe "FC073" do
-  context "with an empty cookbook" do
-    metadata_file
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with only attributes/default.rb" do
-    metadata_file
-    attributes_file
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with only attributes.rb" do
-    metadata_file
-    file "attributes.rb"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with both attributes.rb and attributes/default.rb" do
-    metadata_file
-    file "attributes.rb"
-    attributes_file
-    it { is_expected.to violate_rule.in("attributes/default.rb") }
-  end
-
-  context "with only recipes/default.rb" do
-    metadata_file
-    recipe_file
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with only recipe.rb" do
-    metadata_file
-    file "recipe.rb"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with both recipe.rb and recipes/default.rb" do
-    metadata_file
-    file "recipe.rb"
-    recipe_file
-    it { is_expected.to violate_rule.in("recipes/default.rb") }
-  end
-
-  context "with all four" do
-    metadata_file
-    file "attributes.rb"
-    file "recipe.rb"
-    attributes_file
-    recipe_file
-    it { is_expected.to violate_rule.in("attributes/default.rb") }
-    it { is_expected.to violate_rule.in("recipes/default.rb") }
-  end
-end

data/spec/functional/fc074_spec.rb

@@ -1,39 +0,0 @@
-require "spec_helper"
-
-describe "FC074" do
-
-  context "with a cookbook with a LWRP that includes a default_action" do
-    resource_file <<-EOH
-      actions :create, :remove
-      default_action :create
-
-      attribute :name, String, name_attribute: true
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that includes a non-DSL default_action" do
-    resource_file <<-EOH
-      actions :create, :remove,
-
-      def initialize(*args)
-        super
-        @action = :create
-      end
-
-      attribute :name, String, name_attribute: true
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a custom resource" do
-    resource_file <<-EOH
-      property :name, String, name_property: true
-
-      action :create do
-        cookbook_file "/etc/something"
-      end
-    EOH
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc075_spec.rb

@@ -1,41 +0,0 @@
-require "spec_helper"
-
-describe "FC075" do
-
-  context "with a cookbook with recipe that uses node.save" do
-    recipe_file "node.save"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with recipe that doesn't use node.save" do
-    recipe_file
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with recipe that includes node['save']" do
-    recipe_file("node['save']")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a library that uses node.save" do
-    library_file <<-EOH
-      module CookbookHelper
-        def some_method
-          node.save
-        end
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a custom resource that uses node.save" do
-    resource_file <<-EOH
-      property :name, String, name_property: true
-
-      action :create do
-        node.save
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc076_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC076" do
-  context "with a cookbook with a metadata file that does contain the conflicts keyword" do
-    metadata_file "conflicts 'runit'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that does not contain the conflicts keyword" do
-    metadata_file
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc077_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC077" do
-  context "with a cookbook with a metadata file that does contain the replaces keyword" do
-    metadata_file "replaces 'runit'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that does not contain the replaces keyword" do
-    metadata_file
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc078_spec.rb

@@ -1,35 +0,0 @@
-require "spec_helper"
-
-describe "FC078" do
-  context "with a cookbook with a metadata file that specifies" do
-    context "a license generated by knife cookbook create" do
-      metadata_file "license 'Apache 2.0'"
-      it { is_expected.to violate_rule }
-    end
-
-    context "a license generated by chef generate cookbook" do
-      metadata_file "license 'apache_2'"
-      it { is_expected.to violate_rule }
-    end
-
-    context "a valid OSI-approved open source license in SPDX format" do
-      metadata_file "license 'Apache-2.0'"
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "ChefDK's non-SPDX all rights reserved string" do
-      metadata_file "license 'All Rights Reserved'"
-      it { is_expected.to violate_rule }
-    end
-
-    context "a license with parens" do
-      metadata_file "license('Apache-2.0')"
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "no license" do
-      metadata_file
-      it { is_expected.to violate_rule }
-    end
-  end
-end

data/spec/functional/fc079_spec.rb

@@ -1,21 +0,0 @@
-require "spec_helper"
-
-describe "FC079" do
-  context "with a cookbook with a recipe that includes an easy_install_package resource" do
-    recipe_file <<-EOF
-      easy_install_package "foo" do
-        action :install
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that doesn't include an easy_install_package resource" do
-    recipe_file <<-EOF
-      package "foo" do
-        action :install
-      end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc080_spec.rb

@@ -1,68 +0,0 @@
-require "spec_helper"
-
-describe "FC080" do
-  context "with a cookbook with a recipe that includes a user resource using supports" do
-    recipe_file <<-EOF
-      user 'betty' do
-        action :create
-        supports({
-          manage_home: true,
-          non_unique: true
-        })
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes a user resource using supports w/o parens" do
-    recipe_file <<-EOF
-      user 'betty' do
-        action :create
-        supports manage_home: true
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes a user resource not using supports" do
-    recipe_file <<-EOF
-      user username do
-        shell '/bin/false'
-        home  deploy_path
-        system true
-        action :create
-      end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes a resource with supports" do
-    recipe_file <<-EOF
-      service 'foo' do
-        action :start
-        supports :restart
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes a user resource and other supports uses" do
-    recipe_file <<-EOF
-      user 'foo' do
-        system true
-        action :create
-      end
-
-      def supports(thing)
-        puts thing
-      end
-
-      supports('something')
-
-      service 'foo' do
-        supports restart: true, status: true
-        action [:enable, :start]
-      end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end