foodcritic 15.0.0 → 15.1.0

data/features/046_check_for_assign_unless_nil_attributes.feature

@@ -1,21 +0,0 @@
-Feature: Check for attributes using assign unless nil
-
-  In order to avoid attributes being assigned unexpected values
-  As a developer
-  I want to identify attributes that attempt to use assign unless nil (||=)
-
-  Scenario Outline: Attribute assignments
-    Given a cookbook attributes file with assignment <assignment>
-     When I check the cookbook
-     Then the attribute assignment uses assign unless nil warning 046 <show_warning> be displayed against the attributes file
-  Examples:
-    | assignment                          | show_warning |
-    | default['somevalue'] = []           | should not   |
-    | default['somevalue'] = foo \|\| bar | should not   |
-    | default['somevalue'] \|\|= []       | should       |
-    | default[:somevalue] = []            | should not   |
-    | default[:somevalue] = foo \|\| bar  | should not   |
-    | default[:somevalue] \|\|= []        | should       |
-    | default.somevalue = []              | should not   |
-    | default.somevalue = foo \|\| bar    | should not   |
-    | default.somevalue \|\|= []          | should       |

data/features/047_check_for_attribute_assignment_without_precedence.feature

@@ -1,49 +0,0 @@
-Feature: Check for attribute assignment without specified precedence
-
-  In order to ensure that my cookbooks continue to work with Chef 11+
-  As a developer
-  I want to identify node attribute assignment that does not specify the attribute precedence
-
-  Scenario Outline: Attribute assignment
-    Given a cookbook attributes file with assignment <assignment>
-     When I check the cookbook
-     Then the attribute assignment without precedence warning 047 <show_warning> be displayed against the attributes file
-  Examples:
-    | assignment                          | show_warning |
-    | node[:foo] = 'bar'                  | should       |
-    | node['foo'] = 'bar'                 | should       |
-    | node['foo'] = a_var                 | should       |
-    | a_var = node['foo']                 | should not   |
-    | node['foo']['bar'] = 'baz'          | should       |
-    | node['foo']['bar']['baz'] = 'fizz'  | should       |
-    | node.foo = 'bar'                    | should       |
-    | node.normal.foo = 'bar'             | should not   |
-    | node.normal['foo'] = 'bar'          | should not   |
-    | node.default['foo'] = 'bar'         | should not   |
-    | node.force_default['foo'] = 'bar'   | should not   |
-    | node.default!['foo'] = 'bar'        | should not   |
-    | node.set['foo'] = 'bar'             | should not   |
-    | node.override['foo'] = 'bar'        | should not   |
-    | node.override!['foo'] = 'bar'       | should not   |
-    | node.force_override['foo'] = 'bar'  | should not   |
-    | node.automatic_attrs['foo'] = 'bar' | should not   |
-    | node['foos'] << 'bar'               | should       |
-    | node['foo']['bars'] << 'baz'        | should       |
-    | foo = node['bar']                   | should not   |
-    | baz << node['foo']['bars']          | should not   |
-    | node.run_state['foo'] = bar         | should not   |
-    | foo[:bar] << node['baz']            | should not   |
-    | node.default['foo'] << bar          | should not   |
-    | node.default_unless['foo'] = 'bar'  | should not   |
-    | node.normal_unless['foo'] = 'bar'   | should not   |
-    | node.set_unless['foo'] = 'bar'      | should not   |
-    | node.override_unless['foo'] = 'bar' | should not   |
-
-  Scenario Outline: Attribute assignment in recipe
-    Given a cookbook recipe file with assignment <assignment>
-     When I check the cookbook
-     Then the attribute assignment without precedence warning 047 <show_warning> be displayed
-  Examples:
-    | assignment                 | show_warning |
-    | node[:foo] = 'bar'         | should       |
-    | node.normal['foo'] = 'bar' | should not   |

data/features/051_check_for_template_partial_loops.feature

@@ -1,40 +0,0 @@
-Feature: Check for template partial includes cycle
-
-  In order to avoid failures at converge time
-  As a developer
-  I want to identify when a template uses partials that would loop
-
-  Scenario: Template without includes
-    Given a cookbook recipe that refers to a template
-    When I check the cookbook
-    Then the template partials loop indefinitely warning 051 should not be displayed against the templates
-
-  Scenario: Template includes do not cycle
-    Given a template that includes a partial
-     When I check the cookbook
-     Then the template partials loop indefinitely warning 051 should not be displayed against the templates
-
-  Scenario: Template includes contain cycle
-    Given a template that includes a partial that includes the original template again
-     When I check the cookbook
-     Then the template partials loop indefinitely warning 051 should be displayed against the templates
-
-  Scenario: Relative partial
-    Given a template that includes a partial with a relative subdirectory path
-     When I check the cookbook
-     Then the template partials loop indefinitely warning 051 should not be displayed against the templates
-
-  Scenario: Missing partial
-    Given a template that includes a missing partial with a relative subdirectory path
-     When I check the cookbook
-     Then the template partials loop indefinitely warning 051 should not be displayed against the templates
-
-  Scenario Outline: Template directory contains binary files
-    Given a template directory that contains a binary file <file> that is not valid UTF-8
-     When I check the cookbook
-     Then the template partials loop indefinitely warning 051 should not be displayed against the templates
-
-  Examples:
-    | file        |
-    | .DS_Store   |
-    | foo.erb.swp |

data/features/build_framework_support.feature

@@ -1,109 +0,0 @@
-@build
-Feature: Build framework support
-
-In order to make it as easy as possible to lint my cookbook
-As a developer
-I want to be able to invoke the lint tool from my build
-
-  Scenario: List rake tasks
-    Given a cookbook that has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task with no block
-     When I list the available build tasks
-     Then the lint task will be listed
-
-  Scenario: List rake tasks - modified name
-    Given a cookbook that has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task specifying a different name
-     When I list the available build tasks
-     Then the lint task will be listed under the different name
-
-  Scenario Outline: Rakefile with no lint task
-    Given a cookbook that has <problems> problems
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines no lint task
-     When I run the build
-     Then the build will <build_outcome> with no warnings
-  Examples:
-    | problems | build_outcome |
-    | no       | succeed       |
-    | style    | succeed       |
-
-  Scenario Outline: Lint task with no block
-    Given a cookbook that has <problems> problems
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task with no block
-     When I run the build
-     Then the build will <build_outcome> with warnings <warnings>
-  Examples:
-    | problems           | build_outcome | warnings    |
-    | no                 | succeed       |             |
-    | style              | succeed       | FC002       |
-    | correctness        | fail          | FC006       |
-    | style,correctness  | fail          | FC002,FC006 |
-
-  Scenario Outline: Lint task with empty block
-    Given a cookbook that has <problems> problems
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task with an empty block
-     When I run the build
-     Then the build will <build_outcome> with warnings <warnings>
-  Examples:
-    | problems           | build_outcome | warnings    |
-    | no                 | succeed       |             |
-    | style              | succeed       | FC002       |
-    | style,correctness  | fail          | FC002,FC006 |
-
-  Scenario Outline: Specify rule tags to fail on
-    Given a cookbook that has <problems> problems
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task with a block setting options to <options>
-     When I run the build
-     Then the build will <build_outcome> with warnings <warnings>
-  Examples:
-    | problems           | options                                      | build_outcome | warnings    |
-    | no                 |                                              | succeed       |             |
-    | style,correctness  | {:fail_tags => []}                           | succeed       | FC002,FC006 |
-    | correctness        | {:fail_tags => ['correctness']}              | fail          | FC006       |
-    | style              | {:fail_tags => ['correctness,style']}        | fail          | FC002       |
-    | style,correctness  | {:fail_tags => [], :tags => ['correctness']} | succeed       | FC006       |
-
-  @context
-  Scenario: Specify that contexts should be shown
-    Given a cookbook with a single recipe that reads node attributes via symbols,strings
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task with a block setting options to {:context => true}
-      When I run the build
-      Then the recipe filename should be displayed
-      And the attribute consistency warning 019 should be displayed below
-      And the line number and line of code that triggered the warning should be displayed
-
-  Scenario Outline: Specify paths to lint
-    Given a cookbook that has <problems> problems
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task specifying files to lint as <files>
-     When I run the build
-     Then the build will <build_outcome> with warnings <warnings>
-  Examples:
-    | problems     | files                                       | build_outcome | warnings |
-    | no           | ['recipes/default.rb']                      | succeed       |          |
-    | correctness  | ['recipes/default.rb']                      | fail          | FC006    |
-    | no           | ['recipes/default.rb', 'recipes/server.rb'] | succeed       |          |
-    | correctness  | ['recipes/default.rb', 'recipes/server.rb'] | fail          | FC006    |
-
-  Scenario: Exclude tests
-    Given a cookbook that has style problems
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task with no block
-      And unit tests under a top-level test directory
-     When I run the build
-     Then no warnings will be displayed against the tests
-      And the build will succeed with warnings FC002
-
-  Scenario: Exclude vendored gems
-    Given a cookbook that has style problems
-      And the cookbook has a Gemfile that includes rake and foodcritic
-      And a Rakefile that defines a lint task with no block
-      And the gems have been vendored
-     When I run the build
-     Then no warnings will be displayed against the tests
-      And the build will succeed with warnings FC002

data/features/checking_all_types_of_file.feature

@@ -1,40 +0,0 @@
-Feature: Checking all types of files
-
-In order to run foodcritic rules
-As a developer
-I want to be able to check all types of files
-
-  Scenario: Checking recipe
-    Given a cookbook with a recipe file with an interpolated name
-    When I check the cookbook
-    Then the string interpolation warning 002 should be displayed
-
-  Scenario: Checking attribute
-    Given a cookbook with an attribute file with an interpolated name
-    When I check the cookbook
-    Then the string interpolation warning 002 should be displayed against the attributes file
-
-  Scenario: Checking metadata
-    Given a cookbook with a metadata file with an interpolated name
-    When I check the cookbook
-    Then the string interpolation warning 002 should be displayed against the metadata file
-
-  Scenario: Checking provider
-    Given a cookbook with a provider file with an interpolated name
-    When I check the cookbook
-    Then the string interpolation warning 002 should be displayed against the provider file
-
-  Scenario: Checking resource
-    Given a cookbook with a resource file with an interpolated name
-    When I check the cookbook
-    Then the string interpolation warning 002 should be displayed against the resource file
-
-  Scenario: Checking library
-    Given a cookbook with a library file with an interpolated name
-    When I check the cookbook
-    Then the string interpolation warning 002 should be displayed against the libraries file
-
-  Scenario: Checking definition
-    Given a cookbook with a definition file with an interpolated name
-    When I check the cookbook
-    Then the string interpolation warning 002 should be displayed against the definition file

data/features/choose_rules_to_apply.feature

@@ -1,47 +0,0 @@
-Feature: Choose rules to apply
-
-  In order to remove warnings that are not appropriate for my usage of Chef
-  As a developer
-  I want to be able to filter the rules applied based on tags associated with each rule
-
-  Scenario Outline: Specified tags on command line
-    Given a cookbook that matches rules <cookbook_matches>
-    When I check the cookbook specifying tags <tag_arguments>
-    Then the warnings shown should be <warnings_shown>
-
-  Examples:
-    | cookbook_matches  | tag_arguments                      | warnings_shown    |
-    | FC002,FC004,FC005 |                                    | FC002,FC004,FC005 |
-    | FC002             | -t FC002                           | FC002             |
-    | FC002,FC004,FC005 | --tags FC002                       | FC002             |
-    | FC002,FC004,FC005 | --tags fc002                       |                   |
-    | FC002,FC004,FC005 | --tags FC006                       |                   |
-    | FC002,FC004,FC005 | --tags ~FC002                      | FC004,FC005       |
-    |                   | --tags FC002                       |                   |
-    | FC002,FC004,FC005 | --tags @FC002                      |                   |
-    | FC002,FC004,FC005 | --tags style                       | FC002             |
-    | FC002,FC004,FC005 | --tags FC002 --tags FC004          |                   |
-    | FC002,FC004,FC005 | --tags portability --tags services | FC004             |
-    | FC002,FC004,FC005 | --tags style,services,portability  | FC002,FC004       |
-
-  Scenario Outline: Specified tags in cookbook .foodcritic file
-    Given a cookbook that matches rules <cookbook_matches>
-    When the cookbook directory has a .foodcritic file specifying tags <tag_file>
-    And I check the cookbook specifying tags <tag_arguments>
-    Then the warnings shown should be <warnings_shown>
-
-  Examples:
-    | cookbook_matches  | tag_file          | tag_arguments  | warnings_shown    |
-    | FC002,FC004       |                   |                | FC002,FC004       |
-    | FC002             | FC002             |                | FC002             |
-    | FC002             | ~FC002            | --tags FC002   | FC002             |
-    | FC002             | fc002             |                |                   |
-    | FC002,FC004       | FC005             |                |                   |
-    | FC002,FC004       | FC005             | -t FC002       | FC002             |
-    | FC002,FC004       | ~FC002            |                | FC004             |
-    | FC002,FC004       | ~FC002            | -t FC002       | FC002             |
-    |                   | FC002             |                |                   |
-    | FC002,FC004       | @FC002            |                |                   |
-    | FC002,FC004       | style             |                | FC002             |
-    | FC002,FC004       | FC002             |                |                   |
-    | FC002,FC004       | style,portability |                | FC002,FC004       |

data/features/command_line_help.feature

@@ -1,58 +0,0 @@
-Feature: Command line help
-
-  In order to be able to learn about the options available for checking my cookbooks
-  As a developer
-  I want to be able to interactively get help on the options from the command line
-
-  Scenario: No arguments
-    Given I have installed the lint tool
-     When I run it on the command line with no arguments
-     Then the simple usage text should be displayed along with a non-zero exit code
-
-  Scenario: Non-existent cookbook directory
-    Given I have installed the lint tool
-     When I run it on the command line specifying a cookbook that does not exist
-     Then the simple usage text should be displayed along with a non-zero exit code
-
-  Scenario: Non-existent role directory
-    Given I have installed the lint tool
-     When I run it on the command line specifying a role directory that does not exist
-     Then the simple usage text should be displayed along with a non-zero exit code
-
-  Scenario: Non-existent environment directory
-    Given I have installed the lint tool
-     When I run it on the command line specifying an environment directory that does not exist
-     Then the simple usage text should be displayed along with a non-zero exit code
-
-  Scenario: Command help
-    Given I have installed the lint tool
-     When I run it on the command line with the help option
-     Then the simple usage text should be displayed along with a zero exit code
-
-  Scenario: Display version
-    Given I have installed the lint tool
-     When I run it on the command line with the version option
-     Then the current version should be displayed
-
-  Scenario: Future verbose option
-    Given I have installed the lint tool
-     When I run it on the command line with the unimplemented verbose option
-     Then the simple usage text should be displayed along with a non-zero exit code
-
-  Scenario: Unimplemented option
-    Given I have installed the lint tool
-     When I run it on the command line with the unimplemented -Z option
-     Then the simple usage text should be displayed along with a non-zero exit code
-
-  Scenario: Future verbose option plus arguments
-    Given a cookbook that has style problems
-      And I have installed the lint tool
-     When I run it on the command line with the unimplemented -v option with an argument
-     Then the simple usage text should be displayed along with a non-zero exit code
-     Then the style warning 002 should not be displayed
-      And the current version should not be displayed
-
-  Scenario: Refer to the man page
-    Given access to the man page documentation
-     When I compare the man page options against the usage options
-     Then all options should be documented in the man page

data/features/continuous_integration_support.feature

@@ -1,33 +0,0 @@
-Feature: Continuous Integration Support
-
-  In order to be able to quickly identify problems with my cookbooks
-  As a developer
-  I want to be able to fail the build for a subset of warnings
-
-  Scenario: Command help
-    Given I have installed the lint tool
-     When I run it on the command line with the help option
-     Then the usage text should include an option for specifying tags that will fail the build
-
-  Scenario Outline: Fail the build for certain tags
-    Given a cookbook that matches rules <cookbook_matches>
-    When I check the cookbook specifying tags <tag_arguments>
-    Then the warnings shown should be <warnings_shown>
-     And the build status should be <build_status>
-
-  Examples:
-    | cookbook_matches  | tag_arguments                 | warnings_shown    | build_status |
-    | FC002,FC004       |                               | FC002,FC004       | failed       |
-    | FC002,FC004       | -t style                      | FC002             | failed       |
-    | FC002,FC004       | -t style -f ~any              | FC002             | successful   |
-    | FC002,FC004       | -f FC005                      | FC002,FC004       | successful   |
-    | FC002,FC004       | -f FC004                      | FC002,FC004       | failed       |
-    | FC002,FC004       | --epic-fail FC002             | FC002,FC004       | failed       |
-    | FC002,FC005       | -f ~any                       | FC002,FC005       | successful   |
-    | FC002,FC005       | -f any -f ~FC014              | FC002,FC005       | failed       |
-    | FC002,FC005       | -f any,~FC014                 | FC002,FC005       | failed       |
-    | FC002,FC005       | -f ~FC002                     | FC002,FC005       | failed       |
-    | FC002,FC005       | -f any -f ~FC002              | FC002,FC005       | failed       |
-    | FC002             | -f any,~FC002                 | FC002             | failed       |
-    | FC002,FC005       | -f any,~FC002                 | FC002,FC005       | failed       |
-    | FC002,FC005       | -f ~FC002 -f ~FC004           | FC002,FC005       | failed       |

data/features/exclude_paths_to_lint.feature

@@ -1,12 +0,0 @@
-Feature: Exclude paths from being linted
-
-  In order to avoid linting some paths that are not really from the cookbook
-  As a developer
-  I want to be able to exclude some files or directories from the passed paths
-
-  Scenario: Exclude a non cookbook directory
-    Given a cookbook that has style problems
-      And unit tests under a top-level test directory
-     When I check the cookbook excluding the test directory
-     Then no warnings will be displayed against the tests
-      And the style warning 002 should be displayed

data/features/ignore_via_line_comments.feature

@@ -1,69 +0,0 @@
-Feature: Ignoring rules on per line basis
-
-  To ignore specific warnings on some lines
-  As a developer
-  I want to add an ignore comment
-
-  Scenario Outline: Ignoring
-    Given a file resource declared with the mode 644 with comment <comment>
-    When I check the cookbook
-    Then the warning 006 should <shown>
-  Examples:
-    | comment                      | shown        |
-    |                              | be shown     |
-    | #                            | be shown     |
-    | # foo bar baz                | be shown     |
-    | # ~FC006                     | not be shown |
-    | # ~FC006 is a false positive | not be shown |
-    | #~FC006                      | not be shown |
-    | #~FC022                      | be shown     |
-    | #       ~FC006               | not be shown |
-    | # ~FC006,~FC009              | not be shown |
-    | # ~FC006 ~FC009              | not be shown |
-    | # ~FC006,  ~FC009            | not be shown |
-    | # ~FC009                     | be shown     |
-    | # FC006                      | be shown     |
-    | # ~ FC006                    | be shown     |
-    | # fc006                      | be shown     |
-    | # ~006                       | be shown     |
-    | # ~style                     | be shown     |
-    | # ~files                     | not be shown |
-
-  Scenario Outline: Ignoring cookbook level rules
-    Given a cookbook with a single recipe that triggers FC019 with comment <comment>
-      And metadata
-    When I check the cookbook
-    Then the attribute consistency warning 019 should <shown>
-    Examples:
-      | comment | shown        |
-      |         | be shown     |
-      | #~FC019 | be not shown |
-
-  Scenario Outline: Multiple warnings
-    Given a file with multiple errors on one line with comment <comment>
-    When I check the cookbook
-    Then the warnings shown should be <warnings>
-  Examples:
-    | comment         | warnings    |
-    |                 | FC002,FC039 |
-    | # ~FC002,~FC007 | FC039       |
-    | # ~FC002,~FC039 |             |
-    | # ~FC002        | FC039       |
-
-  Scenario Outline: Ignoring role rules
-    Given a ruby role that triggers FC049 with comment <comment>
-     When I check the role directory
-     Then the role name does not match file name warning 049 should <shown>
-  Examples:
-    | comment | shown        |
-    |         | be shown     |
-    | #~FC049 | not be shown |
-
-  Scenario Outline: Ignoring environment rules
-    Given a ruby environment that triggers FC050 with comment <comment>
-     When I check the environment directory
-     Then the invalid environment name warning 050 should <shown>
-  Examples:
-    | comment | shown        |
-    |         | be shown     |
-    | #~FC050 | not be shown |