foodcritic 15.0.0 → 15.1.0

data/spec/functional/fc094_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC094" do
-  context "with a cookbook with a custom resource that includes node['filesystem2']" do
-    resource_file "node['filesystem2']"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes node['filesystem2']" do
-    recipe_file "node['filesystem2']"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes node['filesystem2']" do
-    library_file "node['filesystem2']"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc095_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC095" do
-  context "with a cookbook with a custom resource that includes node['cloud_v2']" do
-    resource_file "node['cloud_v2']"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes node['cloud_v2']" do
-    recipe_file "node['cloud_v2']"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes node['cloud_v2']" do
-    library_file "node['cloud_v2']"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc096_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC096" do
-  context "with a cookbook with a custom resource that includes node['virtualization']['uri']" do
-    resource_file "node['virtualization']['uri']"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes node['virtualization']['uri']" do
-    recipe_file "node['virtualization']['uri']"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes node['virtualization']['uri']" do
-    library_file "node['virtualization']['uri']"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc097_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC097" do
-  context "with a cookbook with a custom resource that includes Chef::Mixin::LanguageIncludeAttribute" do
-    resource_file "include Chef::Mixin::LanguageIncludeAttribute"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes Chef::Mixin::LanguageIncludeAttribute" do
-    recipe_file "include Chef::Mixin::LanguageIncludeAttribute"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::Mixin::LanguageIncludeAttribute" do
-    library_file "include Chef::Mixin::LanguageIncludeAttribute"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc098_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC098" do
-  context "with a cookbook with a custom resource that includes Chef::Mixin::RecipeDefinitionDSLCore" do
-    resource_file "include Chef::Mixin::RecipeDefinitionDSLCore"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes Chef::Mixin::RecipeDefinitionDSLCore" do
-    recipe_file "include Chef::Mixin::RecipeDefinitionDSLCore"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::Mixin::RecipeDefinitionDSLCore" do
-    library_file "include Chef::Mixin::RecipeDefinitionDSLCore"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc099_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC099" do
-  context "with a cookbook with a custom resource that includes Chef::Mixin::LanguageIncludeRecipe" do
-    resource_file "include Chef::Mixin::LanguageIncludeRecipe"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes Chef::Mixin::LanguageIncludeRecipe" do
-    recipe_file "include Chef::Mixin::LanguageIncludeRecipe"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::Mixin::LanguageIncludeRecipe" do
-    library_file "include Chef::Mixin::LanguageIncludeRecipe"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc100_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC100" do
-  context "with a cookbook with a custom resource that includes Chef::Mixin::Language" do
-    resource_file "include Chef::Mixin::Language"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes Chef::Mixin::Language" do
-    recipe_file "include Chef::Mixin::Language"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::Mixin::Language" do
-    library_file "include Chef::Mixin::Language"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc101_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe "FC101" do
-  context "with a cookbook with a recipe that includes an deploy resource" do
-    recipe_file <<-EOF
-      deploy 'private_repo' do
-        repo 'git@github.com:acctname/private-repo.git'
-        user 'ubuntu'
-        deploy_to '/tmp/private_code'
-        ssh_wrapper '/tmp/private_code/wrap-ssh4git.sh'
-        action :deploy
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that doesn't include an deploy resource" do
-    recipe_file <<-EOF
-      package "foo"
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc102_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC102" do
-  context "with a cookbook with a custom resource that includes Chef::DSL::Recipe::FullDSL" do
-    resource_file "include Chef::DSL::Recipe::FullDSL"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes Chef::DSL::Recipe::FullDSL" do
-    recipe_file "include Chef::DSL::Recipe::FullDSL"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::DSL::Recipe::FullDSL" do
-    library_file "include Chef::DSL::Recipe::FullDSL"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc103_spec.rb

@@ -1,30 +0,0 @@
-require "spec_helper"
-
-describe "FC103" do
-  context "with a cookbook with a custom resource that uses the :uninstall resource in chocolatey_package" do
-    resource_file <<-EOF
-    chocolatey_package 'name' do
-      action :uninstall
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that uses the :uninstall resource in chocolatey_package" do
-    recipe_file <<-EOF
-    chocolatey_package 'name' do
-      action :uninstall
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that uses the :uninstall resource in chocolatey_package" do
-    library_file <<-EOF
-    chocolatey_package 'name' do
-      action :uninstall
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc104_spec.rb

@@ -1,54 +0,0 @@
-require "spec_helper"
-
-describe "FC104" do
-  context "with a cookbook with a recipe where ruby_block specifies a create action" do
-    recipe_file <<-EOF
-    ruby_block 'puts' do
-      block do
-        puts "test test test"
-      end
-      action :create
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe where ruby_block specifies a run action" do
-    recipe_file <<-EOF
-    ruby_block 'puts' do
-      block do
-        puts "test test test"
-      end
-      action :run
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a recipe that notifies :create on a ruby_block" do
-    recipe_file <<-EOF
-    file 'foo' do
-      notifies :create, 'ruby_block[bar]', :delayed
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that notifies :run on a ruby_block" do
-    recipe_file <<-EOF
-    file 'foo' do
-      notifies :run, 'ruby_block[bar]', :delayed
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a recipe that has a non-ruby_block resource with :create action" do
-    recipe_file <<-EOF
-    directory 'foo' do
-      action :create
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc105_spec.rb

@@ -1,36 +0,0 @@
-require "spec_helper"
-
-describe "FC105" do
-  context "with a cookbook with a custom resource that includes an erl_call resource" do
-    resource_file <<-EOF
-    erl_call 'list names' do
-      code 'net_adm:names().'
-      distributed true
-      node_name 'chef@latte'
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes an erl_call resource" do
-    recipe_file <<-EOF
-    erl_call 'list names' do
-      code 'net_adm:names().'
-      distributed true
-      node_name 'chef@latte'
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes an erl_call resource" do
-    library_file <<-EOF
-    erl_call 'list names' do
-      code 'net_adm:names().'
-      distributed true
-      node_name 'chef@latte'
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc106_spec.rb

@@ -1,21 +0,0 @@
-require "spec_helper"
-
-describe "FC106" do
-  context "with a cookbook with a recipe that uses hash in a launchd resource" do
-    recipe_file <<-EOF
-    launchd 'foo' do
-      hash {}
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that uses plist_hash in a launchd  resource" do
-    library_file <<-EOF
-    launchd 'foo' do
-      plist_hash {}
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc107_spec.rb

@@ -1,22 +0,0 @@
-require "spec_helper"
-
-describe "FC107" do
-  context "with a cookbook with a recipe that uses uses epic_fail in a resource" do
-    recipe_file <<-EOF
-    chocolatey_package 'name' do
-      epic_fail true
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that uses uses ignore_failure in a resource" do
-    library_file <<-EOF
-    chocolatey_package 'name' do
-      action :install
-      ignore_failure true
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc108_spec.rb

@@ -1,43 +0,0 @@
-require "spec_helper"
-
-describe "FC108" do
-  context "with a cookbook with a custom resource that defines a name property" do
-    resource_file <<-EOF
-    property :name, String, name_property: true
-
-        action :create do
-        end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a custom resource that does not defines a name property" do
-    recipe_file <<-EOF
-    property :not_name, String, name_property: true
-
-    action :create do
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a custom resource where a property contains a name variable" do
-    recipe_file <<-EOF
-    property :home, String, default: lazy { ::File.join('/home/', name) }
-
-    action :create do
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a custom resource where a property contains a name symbol" do
-    recipe_file <<-EOF
-    property :foo, Symbol, default: :name
-
-    action :create do
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc109_spec.rb

@@ -1,22 +0,0 @@
-require "spec_helper"
-
-describe "FC109" do
-  context "with a cookbook with a package resource that defines a provider" do
-    resource_file <<-EOF
-    package 'foo' do
-      provider Chef::Provider::Package::Rpm
-      action :install
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a package resource that doesn't define a provider" do
-    resource_file <<-EOF
-    package 'foo' do
-      action :install
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc110_spec.rb

@@ -1,21 +0,0 @@
-require "spec_helper"
-
-describe "FC110" do
-  context "with a cookbook with a script resource that uses command" do
-    resource_file <<-EOF
-    bash 'foo' do
-      command 'cat /etc/passwd'
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a script resource that uses code" do
-    resource_file <<-EOF
-    bash 'foo' do
-      code 'cat /etc/passwd'
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc111_spec.rb

@@ -1,17 +0,0 @@
-require "spec_helper"
-
-describe "FC111" do
-  context "with a cookbook with a search that uses the deprecated sort flag" do
-    resource_file <<-EOF
-    search(:node, 'role:web', :sort => true)
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a search that does not use sort" do
-    resource_file <<-EOF
-    search(:node, 'role:web')
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end