foodcritic 15.0.0 → 15.1.0

data/features/support/env.rb

@@ -1,19 +0,0 @@
-begin
-  require "simplecov"
-  SimpleCov.start do
-    add_filter "/features/"
-  end
-rescue LoadError
-  warn "warning: simplecov gem not found; skipping coverage"
-end
-
-require "aruba/cucumber"
-require "foodcritic"
-
-require "minitest/spec"
-
-MiniTest::Spec.new(nil)
-
-Before do
-  @aruba_timeout_seconds = 300
-end

data/man/foodcritic.1.ronn

@@ -1,76 +0,0 @@
-foodcritic(1) -- lint tool for chef cookbooks
-=============================================
-
-## SYNOPSIS
-
-`foodcritic` [<options>...] <cookbook>...
-
-`foodcritic` [<options>...] --list
-
-
-## DESCRIPTION
-
-`foodcritic` makes it easier to flag problems in your Chef cookbooks that will
-cause Chef to blow up when you attempt to converge.
-This is about faster feedback.
-
-Each `cookbook` path specified will be examined for common problems and
-poor style.
-
-
-## OPTIONS
-
- * `-t`, `--tags` <TAGS>:
-   Only check against rules with the specified tags. Prefix
-   tags with a tilde `~` to exclude rules.
-
- * `-l`, `--list`:
-   Do not perform a lint check; instead simply list the 
-   rules that would be enabled based on the defaults and 
-   the rule selection options (-t, -I)
-
- * `-f`, `--epic-fail` <TAGS>:
-   Exit non-zero if any of the specified tags are matched.
-   Use the pseudo-tag `any` to fail if any tag is matched.
-
- * `-c`, `--chef-version` <VERSION>:
-   Only check against rules valid for this version of Chef.
-
- * `-B`, `--cookbook-path`:
-   Cookbook path(s) to check.
-
- * `-C`, `--`[`no-`]`context`:
-   Show lines matched against rather than the default summary.
-
- * `-E`, `--environment-path`:
-   Environment path(s) to check.
-
- * `-I`, `--include` <PATH>:
-   Additional rule file path(s) to load.
-
- * `-R`, `--role-path`:
-   Role path(s) to check.
-
- * `-S`, `--search-grammar` <PATH>:
-   Specify grammar to use when validating search syntax.
-   (Default: the grammar of any installed Chef)
-
- * `-V`, `--version`:
-   Display the foodcritic version.
-
- * `-X`, `--exclude` <PATH>:
-   Exclude path(s) from being linted.
-
-## RETURN VALUES
-
-By default, `foodcritic` will always return `0`.
-
-If `--epic-fail` is specified, then `foodcritic` will return `3` if any tags are matched.
-
-## COPYRIGHT
-
-`foodcritic` is Copyright 2011 by Andrew Crump.
-
-## SEE ALSO
-
-chef(1)

data/spec/functional/fc001_spec.rb

@@ -1,72 +0,0 @@
-require "spec_helper"
-
-describe "FC001" do
-  context "with a cookbook with a single recipe that reads node attributes via symbols" do
-    recipe_file "log node[:foo]\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with a cookbook with a single recipe that references the node run_state" do
-    recipe_file "node.run_state[:foo]\n"
-    it { is_expected.not_to violate_rule("FC001") }
-  end
-
-  context "with a cookbook with a single recipe that accesses multiple node attributes via symbols" do
-    recipe_file "node[:foo] = 'bar'\nnode[:testing] = 'bar'\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with a cookbook with a single recipe that assigns node attributes accessed via symbols to a local variable" do
-    recipe_file "baz = node[:foo]\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with a cookbook with a single recipe that accesses nested node attributes via symbols" do
-    recipe_file "node[:foo][:foo2] = 'bar'\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with a cookbook with a single recipe that reads node attributes via strings" do
-    recipe_file "log node['foo']\n"
-    it { is_expected.to_not violate_rule("FC001") }
-  end
-
-  context "with a cookbook with a single recipe that searches based on a node attribute accessed via strings" do
-    recipe_file %Q{remote = search(:node, "name:\#{node['drbd']['remote_host']}")[0]\n}
-    it { is_expected.to_not violate_rule("FC001") }
-  end
-
-  context "with a cookbook with a single recipe that passes node attributes accessed via symbols to a template" do
-    recipe_file <<-EOH
-      template "/etc/foo" do
-        source "foo.erb"
-        variables({
-          :port => node[:foo][:port],
-          :user => node[:foo][:user]
-        })
-      end
-    EOH
-    it { is_expected.to violate_rule("FC001").in("recipes/default.rb:4") }
-    it { is_expected.to violate_rule("FC001").in("recipes/default.rb:5") }
-  end
-
-  context "with a cookbook that declares default attributes via symbols" do
-    attributes_file "default[:apache][:dir] = '/etc/apache2'\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with a cookbook that declares override attributes via symbols" do
-    attributes_file "override[:apache][:dir] = '/etc/apache2'\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with a cookbook that declares set attributes via symbols" do
-    attributes_file "set[:apache][:dir] = '/etc/apache2'\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with a cookbook that declares normal attributes via symbols" do
-    attributes_file "normal[:apache][:dir] = '/etc/apache2'\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-end

data/spec/functional/fc004_spec.rb

@@ -1,84 +0,0 @@
-require "spec_helper"
-
-describe "FC004" do
-  context "using a execute to run a service init script" do
-    recipe_file <<-EOH
-      execute 'service stuff' do
-        command '/etc/init.d/foo start'
-        action :run
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "using a execute to run a invoke-rc.d" do
-    recipe_file <<-EOH
-      execute 'service stuff' do
-        command 'invoke-rc.d foo restart'
-        action :run
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  %w{reload start stop restart}.each do |command|
-    context "using a execute to run an upstart #{command} command" do
-      recipe_file <<-EOH
-        execute 'service stuff' do
-          command "#{command} foo"
-          action :run
-        end
-      EOH
-      it { is_expected.to violate_rule }
-    end
-
-    context "using a execute to run the upstart service command to #{command}" do
-      recipe_file <<-EOH
-        execute 'service stuff' do
-          command "service foo #{command}"
-          action :run
-        end
-      EOH
-      it { is_expected.to violate_rule }
-    end
-
-    context "using a execute to run systemcl to #{command}" do
-      recipe_file <<-EOH
-        execute 'service stuff' do
-          command "systemctl #{command} foo"
-          action :run
-        end
-      EOH
-      it { is_expected.to violate_rule }
-    end
-  end
-
-  context "using a execute to run a windows start command" do
-    recipe_file <<-EOH
-      execute 'Run setup' do
-        command 'start /wait my_setup.exe --silent'
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "using a execute to run systemctl daemon-reload" do
-    recipe_file <<-EOH
-      execute 'Run setup' do
-        command 'systemctl daemon-reload'
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "using a execute to run check the contents of an init script" do
-    recipe_file <<-EOH
-      execute "Configure the scheduler" do
-          user "root"
-          command 'sed -i "s/\([^/]\)ondemand/\1performace/g" /etc/init.d/ondemand'
-          notifies :start, "service[ondemand]"
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc007_spec.rb

@@ -1,127 +0,0 @@
-require "spec_helper"
-
-describe "FC007" do
-  metadata_file "name 'test'\ndepends 'dep'"
-  context "with an undeclared dependency" do
-    recipe_file 'include_recipe "foo"'
-
-    it { is_expected.to violate_rule }
-
-    context "with parens" do
-      recipe_file 'include_recipe("foo")'
-      it { is_expected.to violate_rule }
-    end
-
-    context "with ::default" do
-      recipe_file 'include_recipe "foo::default"'
-      it { is_expected.to violate_rule }
-    end
-
-    context "with parens and ::default" do
-      recipe_file 'include_recipe("foo::default")'
-      it { is_expected.to violate_rule }
-    end
-
-    # context 'with a partial expression' do
-    #   recipe_file 'include_recipe "foo::#{something}"'
-    #   it { pending; is_expected.to violate_rule }
-    # end
-  end
-
-  context "with a declared dependency" do
-    recipe_file 'include_recipe "dep"'
-
-    it { is_expected.to_not violate_rule }
-
-    context "with parens" do
-      recipe_file 'include_recipe("dep")'
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with ::default" do
-      recipe_file 'include_recipe "dep::default"'
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with parens and ::default" do
-      recipe_file 'include_recipe("dep::default")'
-      it { is_expected.to_not violate_rule }
-    end
-
-    # context 'with a partial expression' do
-    #   recipe_file 'include_recipe "dep::#{something}"'
-    #   it { pending; is_expected.to_not violate_rule }
-    # end
-  end
-  context "with an unknowable include_recipe" do
-    context "with a node attribute" do
-      recipe_file 'include_recipe node["foo"]'
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with a variable" do
-      recipe_file "include_recipe something"
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with a string expression" do
-      recipe_file 'include_recipe "#{something}"'
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with a parial string expression" do
-      recipe_file 'include_recipe "#{something}::default"'
-      it { is_expected.to_not violate_rule }
-    end
-  end
-
-  context "with an include from the same cookbook" do
-    recipe_file 'include_recipe "test::other"'
-    it { is_expected.to_not violate_rule }
-
-    context "with the shorthand syntax" do
-      recipe_file 'include_recipe "::other"'
-      it { is_expected.to_not violate_rule }
-    end
-  end
-
-  context "with multiple includes" do
-    recipe_file "include_recipe 'test::other'\ninclude_recipe 'foo'"
-    it { is_expected.to violate_rule.in("recipes/default.rb:2") }
-  end
-
-  context "with multiple dependencies" do
-    shared_examples "multiple includes" do
-      context "with declared includes" do
-        recipe_file %Q{include_recipe 'one'\ninclude_recipe "two"\ninclude_recipe 'three::default'}
-        it { is_expected.to_not violate_rule }
-      end
-
-      context "with undeclared includes" do
-        recipe_file %Q{include_recipe 'one'\ninclude_recipe "other"\ninclude_recipe 'foo::default'}
-        it { is_expected.to violate_rule.in("recipes/default.rb:2") }
-        it { is_expected.to violate_rule.in("recipes/default.rb:2") }
-      end
-    end
-
-    context "using multiple depends" do
-      metadata_file "name 'test'\ndepends 'one'\ndepends 'two'\ndepends 'three'"
-      it_behaves_like "multiple includes"
-    end
-
-    context "using a word array and a one-line block" do
-      metadata_file "name 'test'\n%w{one two three}.each {|d| depends d }"
-      it_behaves_like "multiple includes"
-    end
-
-    context "using a word array and a multi-line block" do
-      metadata_file "name 'test'\n%w{one two three}.each do |d|\n  depends d\nend"
-      it_behaves_like "multiple includes"
-    end
-
-    context "using a non-standard word array" do
-      metadata_file "name 'test'\n%w|one two three|.each {|d| depends d }"
-      it_behaves_like "multiple includes"
-    end
-  end
-end

data/spec/functional/fc008_spec.rb

@@ -1,33 +0,0 @@
-require "spec_helper"
-
-describe "FC008" do
-  context "with a cookbook with a metadata file containing boilerplate maintainer from knife CLI" do
-    metadata_file "maintainer 'YOUR_COMPANY_NAME'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file containing boilerplate maintainer from chef CLI" do
-    metadata_file "maintainer 'The Authors'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file containing boilerplate maintainer_email from knife CLI" do
-    metadata_file "maintainer_email 'YOUR_EMAIL'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file containing boilerplate maintainer_email from chef CLI" do
-    metadata_file "maintainer_email 'you@example.com'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file containing non-boilerplate maintainer and maintainer_email" do
-    metadata_file "maintainer 'John Smith'\nmaintainer_email 'john@smith.com'"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file not containing maintainer or maintainer_email" do
-    metadata_file
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc009_spec.rb

@@ -1,37 +0,0 @@
-require "spec_helper"
-
-describe "FC009" do
-  context "on chef 14.2.0 with a cookbook that uses ifconfig attributes introduced in 14.0" do
-    foodcritic_command("--chef-version", "14.2.0", "--no-progress", ".")
-    recipe_file <<-EOH
-      ifconfig 'foo' do
-        family 'inet'
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "on chef 13.12.3 with a cookbook that uses ifconfig attributes introduced in 14.0" do
-    foodcritic_command("--chef-version", "13.12.3", "--no-progress", ".")
-    recipe_file <<-EOH
-      ifconfig 'foo' do
-        family 'inet'
-      end
-    EOH
-    it { is_expected.to violate_rule }
-  end
-
-  context "when the resource attribute is actually a raise" do
-    recipe_file <<-EOH
-      package package_name do
-        provider case node["platform_family"]
-                 when "debian"; Chef::Provider::Package::Dpkg
-                 when "rhel"; Chef::Provider::Package::Rpm
-                 else
-                  raise RuntimeError("I don't know how to install chef-server packages for this platform family")
-                 end
-      end
-    EOH
-    it { is_expected.not_to violate_rule }
-  end
-end