foodcritic 15.0.0 → 15.1.0

data/spec/functional/fc081_spec.rb

@@ -1,25 +0,0 @@
-require "spec_helper"
-
-describe "FC081" do
-  context "with a cookbook with a metadata file that depends on partial_search cookbook" do
-    metadata_file <<-META
-     name 'my_cookbook'
-     depends 'partial_search'
-     META
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that depends on partial_search cookbook and others" do
-    metadata_file <<-META
-     name 'my_cookbook'
-     depends 'partial_search'
-     depends 'windows'
-     META
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that depends on no cookbooks" do
-    metadata_file "name 'my_cookbook'"
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc082_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe "FC082" do
-  context "with a cookbook with a recipe that sets an attribute with node.set" do
-    recipe_file "node.set['foo']['bar'] = baz"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that sets an attribute with node.set_unless" do
-    recipe_file "node.set_unless['foo']['bar'] = baz"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that sets an attribute with node.normal" do
-    recipe_file "node.normal['foo']['bar'] = baz"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a recipe that reads a value using node.set" do
-    recipe_file "foo = node.set['foo']"
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc083_spec.rb

@@ -1,34 +0,0 @@
-require "spec_helper"
-
-describe "FC083" do
-  context "with a cookbook with a recipe that includes a execute resource specifying path" do
-    recipe_file <<-EOF
-      execute 'food' do
-        path '/some/path'
-        command 'build.sh'
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes a execute resource not specifying path" do
-    recipe_file <<-EOF
-      execute 'food' do
-        command 'build.sh'
-      end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that doesn't include an execute resource" do
-    recipe_file <<-EOF
-      directory '/tmp/something' do
-        owner 'root'
-        group 'root'
-        mode '0755'
-        action :create
-      end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc084_spec.rb

@@ -1,49 +0,0 @@
-require "spec_helper"
-
-describe "FC084" do
-  context "with a cookbook with a recipe that includes Chef::REST" do
-    recipe_file 'Chef::REST::RESTRequest.new(:GET, "http://foo.com", nil).call'
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::REST" do
-    recipe_file <<-EOF
-      def response
-        response = Chef::REST::RESTRequest.new(:GET, 'http://foo.com', nil).call
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that includes Chef::REST" do
-    recipe_file <<-EOF
-      action :doit do
-        Chef::REST::RESTRequest.new(:GET, 'http://foo.com', nil).call
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a recipe that includes Chef::ServerAPI" do
-    recipe_file "server_conn = Chef::ServerAPI.new"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::ServerAPI" do
-    recipe_file <<-EOF
-      def server_conn
-        server_conn = Chef::ServerAPI.new
-      end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that includes Chef::ServerAPI" do
-    recipe_file <<-EOF
-      action :doit do
-        Chef::ServerAPI.new
-      end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc085_spec.rb

@@ -1,77 +0,0 @@
-require "spec_helper"
-
-describe "FC085" do
-  context "with a cookbook with a custom resource that converges with new_resource.updated_by_last_action" do
-    resource_file <<-EOF
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-
-      new_resource.updated_by_last_action(true)
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that converges with @new_resource.updated_by_last_action" do
-    provider_file <<-EOF
-    use_inline_resources
-
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-
-      @new_resource.updated_by_last_action(true)
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that converges with new_resource.updated_by_last_action in a method" do
-    provider_file <<-EOF
-    def update_me(new_resource)
-      new_resource.updated_by_last_action(true)
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a custom resource that relies on resources for convergence" do
-    resource_file <<-EOF
-    action :create do
-      file "the_file" do
-        template "/etc/something.conf" do
-          notifies :restart, "service[something]"
-        end
-      end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that relies on resources for convergence" do
-    provider_file <<-EOF
-    use_inline_resources
-
-    action :create do
-      file "the_file" do
-        template "/etc/something.conf" do
-          notifies :restart, "service[something]"
-        end
-      end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that calls foo.updated_by_last_action" do
-    provider_file <<-EOF
-    use_inline_resources
-
-    action :create do
-      foo.updated_by_last_action(true)
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-end

data/spec/functional/fc086_spec.rb

@@ -1,45 +0,0 @@
-require "spec_helper"
-
-describe "FC086" do
-  context "with a recipe that uses Chef::EncryptedDataBagItem.load" do
-    recipe_file 'Chef::EncryptedDataBagItem.load("users", "tsmith", key)'
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses Chef::DataBagItem.load" do
-    recipe_file 'Chef::DataBagItem.load("users", "tsmith")'
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a resource that uses Chef::EncryptedDataBagItem.load" do
-    resource_file <<-EOF
-      action :create do
-        data = Chef::EncryptedDataBagItem.load("users", "tsmith", key)
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a resource that uses Chef::DataBagItem.load" do
-    resource_file <<-EOF
-      action :create do
-        data = Chef::DataBagItem.load("users", "tsmith")
-      end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that uses data_bag_item" do
-    recipe_file "data_bag_item('bag', 'item', IO.read('secret_file').strip)"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a recipe that uses other Chef::EncryptedDataBagItem methods" do
-    recipe_file <<-EOF
-     data_bag_item('bag', 'item', Chef::EncryptedDataBagItem.load_secret('secret_file'))
-     encrypted_item = Chef::EncryptedDataBagItem.encrypt_data_bag_item(original_item, Chef::EncryptedDataBagItem.load_secret)
-     bag = Chef::DataBagItem.new
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc087_spec.rb

@@ -1,43 +0,0 @@
-require "spec_helper"
-
-describe "FC087" do
-  context "with a cookbook with a library that maps platforms with Chef::Platform.set" do
-    library_file <<-EOF
-    Chef::Platform.set platform: :amazon, resource: :mysql_chef_gem, provider: Chef::Provider::MysqlChefGem::Mysql
-    Chef::Platform.set platform: :centos, version: '< 7.0', resource: :mysql_chef_gem, provider: Chef::Provider::MysqlChefGem::Mysql
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that maps providers with Chef::Platform.provider_for_resource" do
-    library_file <<-EOF
-      provider = Chef::Platform.provider_for_resource(resource, :create)
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that maps providers with Chef::Platform.provider_for_resource" do
-    library_file <<-EOF
-      provider = Chef::Platform.find_provider("ubuntu", "16.04", resource)
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library that includes Chef::Platform.foo" do
-    library_file <<-EOF
-    module AuditD
-      module Helper
-        def auditd_package_name_for(platform_family)
-          case platform_family
-          when 'rhel', 'fedora'
-            'audit'
-          else
-            'auditd'
-          end
-        end
-      end
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc088_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC088" do
-  context "with a cookbook with a library that uses Chef::Mixin::Command" do
-    library_file "include Chef::Mixin::Command"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a resource that uses Chef::Mixin::Command" do
-    resource_file "include Chef::Mixin::Command"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a resource that uses Bob::Mixin::Command" do
-    resource_file "include Bob::Mixin::Command"
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc089_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe "FC089" do
-  context "with a cookbook with a library that uses Chef::ShellOut" do
-    library_file "include Chef::ShellOut"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a resource that uses Chef::ShellOut" do
-    resource_file "include Chef::ShellOut"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a resource that uses Miblib::Shellout" do
-    resource_file "include Mixlib::Shellout"
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a resource that uses Chef::Mixin::ShellOut" do
-    resource_file "include Chef::Mixin::ShellOut"
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc091_spec.rb

@@ -1,38 +0,0 @@
-require "spec_helper"
-
-describe "FC091" do
-  context "with a cookbook with a custom resource that uses attributes" do
-    resource_file <<-EOF
-    attribute :source,                String, name_attribute: true
-    attribute :headers,               Hash,   default: {}
-
-    action :create do
-      puts "something"
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a custom resource that uses properties" do
-    resource_file <<-EOF
-    property :source,                String, name_property: true
-    property :headers,               Hash,   default: {}
-
-    action :create do
-      puts "something"
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that uses attributes" do
-    resource_file <<-EOF
-    attribute :source,                String, name_attribute: true
-    attribute :headers,               Hash,   default: {}
-
-    actions :create
-    default_action :create
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc092_spec.rb

@@ -1,31 +0,0 @@
-require "spec_helper"
-
-describe "FC092" do
-  context "with a cookbook with a custom resource that defines actions" do
-    resource_file <<-EOF
-    actions :create
-
-    action :create do
-      puts "something"
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a custom resource that doesn't define actions" do
-    resource_file <<-EOF
-    action :create do
-      puts "something"
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a LWRP that defines actions" do
-    resource_file <<-EOF
-    actions :create
-    default_action :create
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc093_spec.rb

@@ -1,27 +0,0 @@
-require "spec_helper"
-
-describe "FC093" do
-  context "with a README.md file containing generated TODO item" do
-    readme_file <<-EOF
-    # cookbook
-
-    TODO: Enter the cookbook description here.
-    EOF
-    metadata_file <<-META
-    name 'cookbook'
-    META
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a README.md without generated TODO item" do
-    readme_file <<-EOF
-    # cookbook
-
-    Some description.
-    EOF
-    metadata_file <<-META
-    name 'cookbook'
-    META
-    it { is_expected.not_to violate_rule }
-  end
-end