foodcritic 15.0.0 → 15.1.0

data/spec/functional/fc112_spec.rb

@@ -1,17 +0,0 @@
-require "spec_helper"
-
-describe "FC112" do
-  context "with a cookbook with a resource that uses dsl_name" do
-    library_file <<-EOF
-    my_resource = MyResource.dsl_name
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a resource that uses resource_name" do
-    library_file <<-EOF
-    my_resource = MyResource.resource_name
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc113_spec.rb

@@ -1,98 +0,0 @@
-require "spec_helper"
-
-describe "FC113" do
-  context "with a cookbook with a library provider with use_inline_resources" do
-    library_file <<-EOF
-    class MyResources
-      class Site < Chef::Resource::LWRPBase
-        provides :site
-        resource_name :site
-        actions :create
-        attribute :name, :kind_of => String, :name_attribute => true
-      end
-    end
-
-    class MyProviders
-      class Site < Chef::Provider::LWRPBase
-        provides :site
-
-        use_inline_resources
-
-        action :create do
-          file "/tmp/foo.txt"
-        end
-      end
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library provider without use_inline_resources" do
-    library_file <<-EOF
-    class MyResources
-      class Site < Chef::Resource::LWRPBase
-        provides :site
-        resource_name :site
-        actions :create
-        attribute :name, :kind_of => String, :name_attribute => true
-      end
-    end
-
-    class MyProviders
-      class Site < Chef::Provider::LWRPBase
-        provides :site
-
-        action :create do
-          file "/tmp/foo.txt"
-        end
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with plain old library file" do
-    library_file <<-EOF
-    def something
-      puts "I'm just a method"
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with LWRP not using use_inline_resources" do
-    provider_file <<-EOF
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with LWRP using use_inline_resources" do
-    provider_file <<-EOF
-    use_inline_resources
-
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook ignoring the rule" do
-    provider_file <<-EOF.gsub(/^    /, "") # When we drop 2.2 support, this can use <<~EOF.
-    # ~FC059
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc114_spec.rb

@@ -1,31 +0,0 @@
-require "spec_helper"
-
-describe "FC114" do
-  context "with a cookbook that uses the legacy Ohai config" do
-    library_file <<-EOF
-    Ohai::Config[:something]
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook that sets the legacy Ohai config value" do
-    library_file <<-EOF
-    Ohai::Config[:something] = 'something'
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook that uses the new full form Ohai config" do
-    library_file <<-EOF
-    Ohai::Config.ohai[:something] = 'something'
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook that uses the new short form Ohai config" do
-    library_file <<-EOF
-    Ohai.config[:something] = 'something'
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc115_spec.rb

@@ -1,24 +0,0 @@
-require "spec_helper"
-
-describe "FC115" do
-  context "with a resource that requires a name property" do
-    resource_file <<-EOF
-    property :url, String, name_property: true, required: true
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a resource that explicitly doesn't required a name property" do
-    resource_file <<-EOF
-    property :url, String, name_property: true, required: false
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a resource that requires a name property with the name of 'name'" do
-    resource_file <<-EOF
-    property :name, String, name_property: true, required: true
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc116_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC116" do
-  context "with metadata depending on compat_resource" do
-    metadata_file "name 'test'\ndepends 'compat_resource'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with metadata depending on foo" do
-    metadata_file "name 'test'\ndepends 'foo'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with metadata depending on nothing" do
-    metadata_file "name 'test'"
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc117_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe "FC117" do
-  context "with a custom resource that includes kind_of in the property definition" do
-    resource_file <<-EOF
-    property :name, kind_of: String, name_property: true
-
-        action :create do
-        end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a custom resource that does not include kind_of in the property definition" do
-    resource_file <<-EOF
-    property :name, String, name_property: true
-
-        action :create do
-        end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc118_spec.rb

@@ -1,17 +0,0 @@
-require "spec_helper"
-
-describe "FC118" do
-  context "with a property that sets the name_attribute value" do
-    resource_file <<-EOF
-    property :url, String, name_attribute: true
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a property that sets the name_property value" do
-    resource_file <<-EOF
-    property :url, String, name_property: true
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc119_spec.rb

@@ -1,27 +0,0 @@
-require "spec_helper"
-
-describe "FC119" do
-  context "with a windows_task resource that uses the :change action" do
-    recipe_file <<-EOF
-    windows_task 'chef-client' do
-      user 'Administrator'
-      password 'N3wPassW0Rd'
-      command 'chef-client'
-      action :change
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a windows_task resource that uses the :create action" do
-    recipe_file <<-EOF
-    windows_task 'chef-client' do
-      user 'Administrator'
-      password 'N3wPassW0Rd'
-      command 'chef-client'
-      action :create
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc120_spec.rb

@@ -1,21 +0,0 @@
-require "spec_helper"
-
-describe "FC120" do
-  context "with a resource that sets the name property" do
-    recipe_file <<-EOF
-    foo 'bar' do
-      name 'Administrator'
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a resource that does not set the name property" do
-    recipe_file <<-EOF
-    foo 'bar' do
-      foo_name 'Administrator'
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc121_spec.rb

@@ -1,45 +0,0 @@
-# Enable these once we turn FC121 back on
-#
-# require "spec_helper"
-#
-# describe "FC121" do
-#   context "with metadata depending on build-essential" do
-#     metadata_file "name 'test'\ndepends 'build-essential'"
-#     it { is_expected.to violate_rule }
-#   end
-#
-#   context "with metadata depending on swap" do
-#     metadata_file "name 'test'\ndepends 'swap'"
-#     it { is_expected.to violate_rule }
-#   end
-#
-#   context "with metadata depending on dmg" do
-#     metadata_file "name 'test'\ndepends 'dmg'"
-#     it { is_expected.to violate_rule }
-#   end
-#
-#   context "with metadata depending on mac_os_x" do
-#     metadata_file "name 'test'\ndepends 'mac_os_x'"
-#     it { is_expected.to violate_rule }
-#   end
-#
-#   context "with metadata depending on chef_handler" do
-#     metadata_file "name 'test'\ndepends 'chef_handler'"
-#     it { is_expected.to violate_rule }
-#   end
-#
-#   context "with metadata depending on chef_hostname" do
-#     metadata_file "name 'test'\ndepends 'chef_hostname'"
-#     it { is_expected.to violate_rule }
-#   end
-#
-#   context "with metadata depending on foo" do
-#     metadata_file "name 'test'\ndepends 'foo'"
-#     it { is_expected.to_not violate_rule }
-#   end
-#
-#   context "with metadata depending on nothing" do
-#     metadata_file "name 'test'"
-#     it { is_expected.to_not violate_rule }
-#   end
-# end

data/spec/functional/fc122_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC122" do
-  context "with a recipe that includes build-essential" do
-    recipe_file "include_recipe 'build-essential'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that includes build-essential::default" do
-    recipe_file "include_recipe 'build-essential::default'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a recipe that includes build-essential-mycorp" do
-    recipe_file "include_recipe 'build-essential-mycorp'"
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/root_aliases_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "root aliases" do
-  context "with a recipe root alias" do
-    file "recipe.rb", "log node[:foo]\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-
-  context "with an attributes root alias" do
-    file "attributes.rb", "default[:foo] = 1\n"
-    it { is_expected.to violate_rule("FC001") }
-  end
-end

data/spec/regression/cookbooks.txt

@@ -1,83 +0,0 @@
-activemq:5dce4ca5283d2a6252130a2d800b9387a57d6e01
-aix:f40afb959cc5edc3e838072c6c4f817708657f1b
-apparmor:fd09a6fda4f6fc722d4c8d5b8a5c815feda280c0
-apt:ea834265247cc8b507ac37ab3a34a9b44ed27a11
-ark:950ed665bc82c13194cb7c0cac3154a4b73e40c7
-auditd:eff59f9ca300ac0514e8c96769bc3e8e8c22a76a
-aws:a9530561bf559c6db2cb40a93b125607c5ef3efa
-bluepill:1d6422afcbc910e587c9639e4e0a28c72727c90b
-boost:14f30e36040a4fcd038f030d9ee1c7fb29b08b68
-build-essential:0c636536fb1236f792974f3af38f2950a03ed4b2
-chef:dac09eea9fa0d611b7b010160d6b8fa7f4d6ae1e
-chef-client:7fc4472c9913c9cb1762f979e05047a674318ef5
-chef-ingredient:e9c2f58af73d49b5783754757f0a38aa87abd37f
-chef-server:d98b96d69962c7988b9640fe5bee09f771ba8977
-chef-vault:6ad7e34f9b860dc1b339a0c1814214595098e4b0
-chef_client_updater:01b39eaa81f017cebca3ab3a941683eb962d9bd2
-chef_handler:d147ca9644f146b97a2d53324ca344321799b45f
-chef_hostname:24776c9ea403a82b5aecc6b1a4a829e892f4db95
-chef_nginx:1f22dd7b7e04e60a1ea9fd0cc4ab980a4be05d4d
-cron:dce04363b6a02d36f8da88f202cedfae2daa6a2c
-database:1ab3822ca50824fbdc14f7c89341faa7ae1e90cb
-docker:e0f18072406abf1ade70745a7ef7e5529f00c109
-dmg:11caf56f57a1168a891f01f0614a01b879aff624
-drbd:e65b60894b48855163c3a13ead40fb897d66c4b8
-dynect:5ef2328cc612cc4c36882742367af0e2bdbd0367
-erlang:58290537b49b495bc18e7a06d9d7560b4d239582
-fail2ban:7b1939c9bc345f3a449545cb8e7ddb8190a6fe5f
-firewall:81a8db5a868f9f486ba694a7fe8eb969a2ae99d1
-gecode:87dc9114bf79e67b8eea9f2a0c42929040d08e4b
-gems:6f8c222cf8326b5266ca3c68344accbbf8d5c468
-gunicorn:89be74c6b47bdb980ee1d98f9aae6b747f1d11e8
-heartbeat:da496afa31286512a9b977974bec5ff51d6de9d8
-homebrew:f42d8d09d8ae3d45f5bdb680dd52da351cb80e2e
-iis:ab7e4823d375e8eb4f927dee5b7ab0591301cb0e
-iptables:da126cf900af3cc36bf212973bb8d0be69fa2b9f
-jetty:d165775c2c7ce3cc484cbe8c7aadf6649505d078
-jpackage:23e6f4b717620455ee9d29cbf82d9a7ab7fa6e5b
-keepalived:0c8bc5ea5aba93b5bc58ebea8661c1e1762ea463
-kickstart:6523fca008362ed72f8fbb25f0c7af70d563b96d
-logwatch:706174796a3bc1d85d57d3aee792e78cb13570ac
-libarchive:5f21a614017c7cffb3fe7f56185c0b988fad7826
-lvm:57bd5291fbaa41e7a13f25c4553cdacbfc3ad3dd
-maradns:e975ded4303432629ad37234cb7a05c9d6edcf73
-maven:e486321f1e89f7ad2b9700c08fcbc68c32daa599
-memcached:db13b6c4088e93faf995441df4aa856adc84c565
-motd-tail:e01096b73c387a46302f63ae6f838fac94e0ca81
-mysql:1709b1ea22339a0c829cf5ced8c5a7ed4a186615
-ohai:8ad8c92b14d5198ffa5ebd094acd83ba0c5c828c
-openldap:2f21ae90544b4f938e554f914955e3fac1a885de
-openssh:a61b47fb0efbdab731e7929506bb1dc6902f0091
-openssl:7f5b84a942f015191ade6badf65a49f1fe7b05b1
-partial_search:9a96d68a4af2eff1cf5d3e8ed7ff2ede723a09c8
-passenger_apache2:793f7bbaac7a883d5f9ef1414260718e33958ae8
-perl:bd6f978aea0ad7e65a8e6266951476b717a9a074
-php:f3f5db8d823db821ac696f7b52b2a613c1e2f167
-postfix:d7d149e7a7235b2733455e524d86e3a984b9b97c
-powershell:4b175affe1a8a7d091a8ca905a580bf975af5edc
-resolver:105ad0a2fc9c065a7c4455cfc07ab7771b8e0da0
-rsync:41756f404fc39f3ce407cce9fe03294dd907c0fe
-rsyslog:8830d558d2ee3126fef56ea3a25a4f0253ce269f
-runit:92c60395a0727bc4941b58e95a4d67cc163a2b98
-smokeping:db0b62ab6d71a782d378c550d37464f024abe144
-sql_server:d9702f8fc29f208c9e712627cda64ccae2d71321
-ssh_known_hosts:a89f0c32e8e2c408a2e153153cc703f1184c6b72
-stompserver:bf81830bb7783f4198565201c825c23267e1d515
-subversion:cad4c069deca1fbbfb6b8f4d21b6c341cc9c6b55
-sudo:00d024f293afb9df4fea23ba127529d67c1daf14
-tar:8586d01346324f413fea9c4b48a214f5e12d3a49
-tftp:f4016b14eae2c0fe7fb48020bf28039c2de043a4
-tomcat:a99c916e8ec00b2e008c16e8b4aa9adcffbb1056
-transmission:c3d62aa4741a55b693630d9cc48b012ff22d2e7b
-ubuntu:7d21b626873ee397755d59aa222cf7fa681f6e90
-ufw:6bc6de62a84f6fa6f172edf0a490f1a332e89e29
-unicorn:bacbb2400dcb476dd53784aa965fa9329e8c3869
-users:c51c96afca83b382678dc21b8deb25677e6a3d8a
-vcruntime:87ea6e2bb16871ec132f03ca014e481e473f958a
-vim:88e8d018267d2cd5cfa3260ce55a0025f52dae6f
-webpi:6cb4fde9dedf2abc980fa49880753512baa26b23
-whitelist-node-attrs:2d76a2d179096e3ab048547d0d7849238ac2a5d3
-windows:1601558f5fce30bed47bfc6d458a80891e127c61
-wix:422b8da1dcf706bb4742d83abc44a649522afe83
-xml:0b538834aa26c4df5918aa193029d285d7b1d4de
-yum:b1191511b011790b2fc5c35cfbc78d0cc7bbc5b8