foodcritic 15.0.0 → 15.1.0

data/spec/regression/expected/runit.txt

@@ -1,4 +0,0 @@
-FC004: Use a service resource to start and stop services: ./recipes/default.rb:24
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC113: Resource declares deprecated use_inline_resources: ./libraries/provider_runit_service.rb:42

data/spec/regression/expected/smokeping.txt

@@ -1,6 +0,0 @@
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/example_slave.rb:19
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/target.rb:53
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/target.rb:63

data/spec/regression/expected/sql_server.txt

@@ -1,7 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/server.rb:28
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/server.rb:26

data/spec/regression/expected/ssh_known_hosts.txt

@@ -1,6 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/stompserver.txt

@@ -1,6 +0,0 @@
-FC001: Use strings in preference to symbols to access node attributes: ./templates/default/sv-stompserver-run.erb:2
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/subversion.txt

@@ -1,6 +0,0 @@
-FC043: Prefer new notification syntax: ./recipes/server.rb:30
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/sudo.txt

@@ -1,10 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/default.rb:98
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/default.rb:112
-FC089: Prefer Mixlib::Shellout over deprecated Chef::ShellOut: ./providers/default.rb:46

data/spec/regression/expected/tar.txt

@@ -1,10 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC071: Missing LICENSE file: ./LICENSE:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/package.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC113: Resource declares deprecated use_inline_resources: ./providers/extract.rb:26
-FC113: Resource declares deprecated use_inline_resources: ./providers/package.rb:22

data/spec/regression/expected/tftp.txt

@@ -1,6 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/tomcat.txt

@@ -1,18 +0,0 @@
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC116: Cookbook depends on the deprecated compat_resource cookbook: ./metadata.rb:1
-FC117: Do not use kind_of in custom resource properties: ./resources/install.rb:7
-FC117: Do not use kind_of in custom resource properties: ./resources/install.rb:8
-FC117: Do not use kind_of in custom resource properties: ./resources/install.rb:9
-FC117: Do not use kind_of in custom resource properties: ./resources/install.rb:10
-FC117: Do not use kind_of in custom resource properties: ./resources/install.rb:12
-FC117: Do not use kind_of in custom resource properties: ./resources/install.rb:13
-FC117: Do not use kind_of in custom resource properties: ./resources/service_systemd.rb:23
-FC117: Do not use kind_of in custom resource properties: ./resources/service_systemd.rb:24
-FC117: Do not use kind_of in custom resource properties: ./resources/service_systemd.rb:28
-FC117: Do not use kind_of in custom resource properties: ./resources/service_sysv_init.rb:16
-FC117: Do not use kind_of in custom resource properties: ./resources/service_sysv_init.rb:17
-FC117: Do not use kind_of in custom resource properties: ./resources/service_sysv_init.rb:21
-FC117: Do not use kind_of in custom resource properties: ./resources/service_upstart.rb:10
-FC117: Do not use kind_of in custom resource properties: ./resources/service_upstart.rb:11
-FC117: Do not use kind_of in custom resource properties: ./resources/service_upstart.rb:15

data/spec/regression/expected/transmission.txt

@@ -1,13 +0,0 @@
-FC016: LWRP does not declare a default action: ./resources/torrent_file.rb:1
-FC024: Consider adding platform equivalents: ./recipes/default.rb:42
-FC025: Prefer chef_gem to compile-time gem install: ./recipes/default.rb:25
-FC025: Prefer chef_gem to compile-time gem install: ./recipes/default.rb:31
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/torrent_file.rb:53
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/torrent_file.rb:58
-FC122: Use the build_essential resource instead of the recipe: ./recipes/source.rb:21

data/spec/regression/expected/ubuntu.txt

@@ -1,5 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/ufw.txt

@@ -1,12 +0,0 @@
-FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:1
-FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:2
-FC019: Access node attributes in a consistent manner: ./attributes/default.rb:1
-FC019: Access node attributes in a consistent manner: ./attributes/default.rb:2
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/default.rb:34
-FC120: Do not set the name property directly on a resource: ./recipes/default.rb:69

data/spec/regression/expected/unicorn.txt

@@ -1,7 +0,0 @@
-FC015: Consider converting definition to a Custom Resource: ./definitions/unicorn_config.rb:1
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/users.txt

@@ -1,12 +0,0 @@
-FC009: Resource attribute not recognised: ./providers/manage.rb:78
-FC047: Attribute assignment does not specify precedence: ./providers/manage.rb:55
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/manage.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC080: User resource uses deprecated supports property: ./providers/manage.rb:87
-FC080: User resource uses deprecated supports property: ./providers/manage.rb:89
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/manage.rb:39
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/manage.rb:143

data/spec/regression/expected/vcruntime.txt

@@ -1,8 +0,0 @@
-FC009: Resource attribute not recognised: ./recipes/vc10.rb:24
-FC009: Resource attribute not recognised: ./recipes/vc11.rb:24
-FC009: Resource attribute not recognised: ./recipes/vc12.rb:24
-FC009: Resource attribute not recognised: ./recipes/vc14.rb:24
-FC009: Resource attribute not recognised: ./recipes/vc6.rb:24
-FC009: Resource attribute not recognised: ./recipes/vc9.rb:24
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/vim.txt

@@ -1,7 +0,0 @@
-FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:20
-FC001: Use strings in preference to symbols to access node attributes: ./recipes/default.rb:33
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/webpi.txt

@@ -1,7 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/product.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/product.rb:33

data/spec/regression/expected/whitelist-node-attrs.txt

@@ -1,7 +0,0 @@
-FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:20
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/windows.txt

@@ -1,35 +0,0 @@
-FC002: Avoid string interpolation where not required: ./libraries/registry_helper.rb:99
-FC002: Avoid string interpolation where not required: ./libraries/registry_helper.rb:173
-FC002: Avoid string interpolation where not required: ./libraries/windows_privileged.rb:42
-FC002: Avoid string interpolation where not required: ./libraries/windows_privileged.rb:56
-FC018: LWRP uses deprecated notification syntax: ./providers/shortcut.rb:54
-FC048: Prefer shell_out helper method to shelling out with Ruby: ./providers/task.rb:106
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/auto_run.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/batch.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/feature.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/package.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/path.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/reboot.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/registry.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/shortcut.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/task.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/zipfile.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/feature_base.rb:9
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/feature_base.rb:19
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/batch.rb:42
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/package.rb:48
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/package.rb:59
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/package.rb:68
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pagefile.rb:63
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pagefile.rb:75
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/registry.rb:70
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:38
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:50
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:68
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:79
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/zipfile.rb:41

data/spec/regression/expected/wix.txt

@@ -1,5 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/xml.txt

@@ -1,7 +0,0 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/ruby.rb:27
-FC122: Use the build_essential resource instead of the recipe: ./recipes/ruby.rb:28

data/spec/regression/expected/yum.txt

@@ -1,15 +0,0 @@
-FC009: Resource attribute not recognised: ./recipes/epel.rb:27
-FC038: Invalid resource action: ./recipes/epel.rb:27
-FC043: Prefer new notification syntax: ./providers/key.rb:60
-FC043: Prefer new notification syntax: ./providers/repository.rb:94
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
-FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
-FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/key.rb:1
-FC074: LWRP should use DSL to define resource's default action: ./resources/repository.rb:1
-FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/key.rb:76
-FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/repository.rb:41
-FC104: Use the :run action in ruby_block instead of :create: ./providers/repository.rb:94

data/spec/regression/regression_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe "regression test" do
-  command("#{File.expand_path("../../../bin/foodcritic", __FILE__)} --no-progress --tags any .", allow_error: true)
-
-  File.readlines(File.expand_path("../cookbooks.txt", __FILE__)).each do |line|
-    name, ref = line.strip.split(":")
-
-    context "with cookbook #{name}", "regression_#{name}" => true do
-      before do
-        command("git clone -q https://github.com/chef-cookbooks/#{name}.git .")
-        command("git checkout -q #{ref}")
-      end
-
-      it "should match expected output" do
-        expected_output = File.readlines(File.expand_path("../expected/#{name}.txt", __FILE__))
-        expected_output.each do |expected_line|
-          expect(subject.stdout).to include expected_line
-        end
-      end
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,132 +0,0 @@
-require "shellwords"
-
-require "rspec_command"
-require "simplecov"
-
-SimpleCov.start do
-  add_filter "/spec/"
-end
-
-module FunctionalHelpers
-  extend RSpec::Matchers::DSL
-
-  matcher :violate_rule do |rule_id = nil|
-    match do |cmd|
-      if location
-        cmd.stdout =~ /^#{expected}:.*: \.\/#{location}/
-      else
-        cmd.stdout =~ /^#{expected}:/
-      end
-    end
-    chain :in, :location
-    failure_message do |cmd|
-      "expected a violation of rule #{expected}#{location && " in #{location}"}, output was:\n#{cmd.stdout}"
-    end
-    failure_message_when_negated do |cmd|
-      "expected no violation of rule #{expected}#{location && " in #{location}"}, output was:\n#{cmd.stdout}"
-    end
-    # Override the default behavior from RSpec for the expected value, use
-    # define_method insetad of def so we can see the _rule_id variable in closure.
-    define_method(:expected) do
-      # Fill in the top-level example group description as the rule ID if not specified.
-      rule_id || method_missing(:class).parent_groups.last.description
-    end
-  end
-
-  def foodcritic_command(*args)
-    output = StringIO.new
-    error = StringIO.new
-    begin
-      # Don't use the block form of chdir because for some reason it can't be
-      # nested.
-      cwd = Dir.pwd
-      Dir.chdir(temp_path)
-      $stderr = error
-      exitstatus = FoodCritic::CommandLine.main(args, output)
-    ensure
-      $stderr = STDERR
-      Dir.chdir(cwd)
-    end
-    RSpecCommand::OutputString.new(output.string, error.string).tap do |out|
-      out.define_singleton_method(:exitstatus) { exitstatus }
-    end
-  end
-
-  module ClassMethods
-    def foodcritic_command(*args)
-      metadata[:foodcritic_command] = true
-      subject do |example|
-        foodcritic_command(*args)
-      end
-    end
-
-    def attributes_file(*args, &block)
-      file("attributes/default.rb", *args, &block)
-    end
-
-    def resource_file(*args, &block)
-      file("resources/my_resource.rb", *args, &block)
-    end
-
-    def provider_file(*args, &block)
-      file("providers/my_resource.rb", *args, &block)
-    end
-
-    def definition_file(*args, &block)
-      file("definitions/my_definition.rb", *args, &block)
-    end
-
-    def library_file(*args, &block)
-      file("libraries/helper.rb", *args, &block)
-    end
-
-    def recipe_file(*args, &block)
-      file("recipes/default.rb", *args, &block)
-    end
-
-    def metadata_file(*args, &block)
-      file("metadata.rb", *args, &block)
-    end
-
-    def readme_file(*args, &block)
-      file("README.md", *args, &block)
-    end
-
-    def included(klass)
-      super
-      klass.extend ClassMethods
-      # Set a default subject command, can be overridden if needed.
-      klass.foodcritic_command("--no-progress", ".")
-    end
-  end
-
-  extend ClassMethods
-end
-
-RSpec.configure do |config|
-  # Basic configuraiton
-  config.run_all_when_everything_filtered = true
-  config.filter_run(:focus) unless ENV["CI"]
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = "random"
-
-  # Set some metadata based on test folders.
-  config.define_derived_metadata(file_path: %r{spec/unit}) do |metadata|
-    metadata[:unit] = true
-  end
-  config.define_derived_metadata(file_path: %r{spec/functional}) do |metadata|
-    metadata[:functional] = true
-  end
-  config.define_derived_metadata(file_path: %r{spec/regression}) do |metadata|
-    metadata[:regression] = true
-  end
-
-  config.include RSpecCommand
-  config.include FunctionalHelpers, functional: true
-end
-
-require_relative "../lib/foodcritic"

data/spec/unit/api_spec.rb

@@ -1,1939 +0,0 @@
-require "spec_helper"
-
-describe FoodCritic::Api do
-
-  def parse_ast(str)
-    api.send(:build_xml, Ripper::SexpBuilder.new(str).parse)
-  end
-
-  def self.ast(str)
-    let(:ast) { parse_ast(str) }
-  end
-
-  let(:api) { Object.new.extend(FoodCritic::Api) }
-
-  describe :exposed_api do
-    let(:ignorable_methods) do
-      api.class.ancestors.map { |a| a.public_methods }.flatten.sort.uniq
-    end
-    it "exposes the expected api to rule authors" do
-      expect(api.public_methods.sort - ignorable_methods).to eq [
-        :attribute_access,
-        :chef_dsl_methods,
-        :chef_node_methods,
-        :cookbook_base_path,
-        :cookbook_maintainer,
-        :cookbook_maintainer_email,
-        :cookbook_name,
-        :declared_dependencies,
-        :ensure_file_exists,
-        :field,
-        :field_value,
-        :file_match,
-        :find_resources,
-        :gem_version,
-        :included_recipes,
-        :json_file_to_hash,
-        :literal_searches,
-        :match,
-        :metadata_field,
-        :notifications,
-        :read_ast,
-        :resource_action?,
-        :resource_attribute,
-        :resource_attribute?,
-        :resource_attributes,
-        :resource_attributes_by_type,
-        :resource_name,
-        :resource_type,
-        :resources_by_type,
-        :ruby_code?,
-        :searches,
-        :standard_cookbook_subdirs,
-        :supported_platforms,
-        :template_file,
-        :template_paths,
-        :templates_included,
-        :valid_query?,
-      ]
-    end
-  end
-
-  describe "#attribute_access" do
-    let(:ast) { double() }
-    it "returns empty if the provided ast does not support XPath" do
-      expect(api.attribute_access(nil, type: :vivified)).to be_empty
-    end
-    it "returns empty if the provided ast has no matches" do
-      expect(ast).to receive(:xpath).with(kind_of(String), kind_of(FoodCritic::Api::AttFilter)).and_return([]).exactly(3).times
-      [:vivified, :string, :symbol].each do |access_type|
-        expect(api.attribute_access(ast, type: access_type)).to be_empty
-      end
-    end
-    it "raises if the specified node type is not recognised" do
-      allow(ast).to receive(:xpath)
-      expect { api.attribute_access(ast, type: :cymbals) }.to raise_error ArgumentError
-    end
-    it "does not raise if the specified node type is valid" do
-      expect(ast).to receive(:xpath).with(/field/, FoodCritic::Api::AttFilter).and_return([])
-      expect(ast).to receive(:xpath).with(/symbol/, FoodCritic::Api::AttFilter).and_return([])
-      expect(ast).to receive(:xpath).with(/tstring_content/, FoodCritic::Api::AttFilter).and_return([])
-      [:vivified, :symbol, :string].each do |access_type|
-        api.attribute_access(ast, type: access_type)
-      end
-    end
-    it "returns vivified attributes access" do
-      call = double()
-      expect(call).to receive(:xpath).with(/args_add_block/).and_return([])
-      expect(call).to receive(:xpath).with(/ident/).and_return(%w{node bar})
-      expect(call).to receive(:xpath).with(/@value/).and_return("foo")
-      expect(ast).to receive(:xpath).with(kind_of(String), kind_of(FoodCritic::Api::AttFilter)).and_return([call])
-      expect(api.attribute_access(ast, type: :vivified)).to eq [call]
-    end
-    it "doesn't flag searching for a node by name as symbol access" do
-      ast = parse_ast(%q{baz = search(:node, "name:#{node['foo']['bar']}")[0]})
-      expect(api.attribute_access(ast, type: :symbol)).to be_empty
-    end
-    describe :ignoring_attributes do
-      it "doesn't ignore run_state by default for backwards compatibility" do
-        ast = parse_ast("node.run_state['bar'] = 'baz'")
-        expect(api.attribute_access(ast)).to_not be_empty
-      end
-      it "allows run_state to be ignored" do
-        ast = parse_ast("node.run_state['bar'] = 'baz'")
-        expect(api.attribute_access(ast, ignore: ["run_state"])).to be_empty
-      end
-      it "allows run_state to be ignored (symbols access)" do
-        ast = parse_ast("node.run_state[:bar] = 'baz'")
-        expect(api.attribute_access(ast, ignore: ["run_state"])).to be_empty
-      end
-      it "allows any attribute to be ignored" do
-        ast = parse_ast("node['bar'] = 'baz'")
-        expect(api.attribute_access(ast, ignore: ["bar"])).to be_empty
-      end
-      it "allows any attribute to be ignored (symbols access)" do
-        ast = parse_ast("node[:bar] = 'baz'")
-        expect(api.attribute_access(ast, ignore: ["bar"])).to be_empty
-      end
-      it "allows any attribute to be ignored (dot access)" do
-        ast = parse_ast("node.bar = 'baz'")
-        expect(api.attribute_access(ast, ignore: ["bar"])).to be_empty
-      end
-      it "includes the children of attributes" do
-        ast = parse_ast("node['foo']['bar'] = 'baz'")
-        expect(api.attribute_access(ast).map { |a| a["value"] }).to eq %w{foo bar}
-      end
-      it "does not include children of removed attributes" do
-        ast = parse_ast("node['foo']['bar'] = 'baz'")
-        expect(api.attribute_access(ast, ignore: ["foo"])).to be_empty
-      end
-      it "coerces ignore values to enumerate them" do
-        ast = parse_ast("node.run_state['bar'] = 'baz'")
-        expect(api.attribute_access(ast, ignore: "run_state")).to be_empty
-      end
-      it "can ignore multiple attributes" do
-        ast = parse_ast(%q{
-          node['bar'] = 'baz'
-          node.foo = 'baz'
-        })
-        expect(api.attribute_access(ast, ignore: %w{foo bar})).to be_empty
-      end
-    end
-  end
-
-  describe "#metadata_field" do
-    file "metadata.rb", 'name "YOUR_COOKBOOK_NAME"'
-
-    it "returns the 'name' value when passed a metadata file and the name field" do
-      expect(api.metadata_field(temp_path, "name")).to eq "YOUR_COOKBOOK_NAME"
-    end
-
-    it "it raises if a invalid field is requested" do
-      expect { api.metadata_field(temp_path, "bogus_field") }.to raise_error RuntimeError
-    end
-
-    it "it raises if a invalid file is requested" do
-      expect { api.metadata_field("/invalid", "name") }.to raise_error RuntimeError
-    end
-  end
-
-  describe "#cookbook_base_path" do
-    file "templates/defaults/test.erb"
-
-    context "with a metadata.rb" do
-      file "metadata.rb"
-
-      it "returns the cookbook dir when passed the path itself" do
-        expect(api.cookbook_base_path(temp_path)).to eq temp_path
-      end
-
-      it "returns the cookbook dir when passed a nested directory" do
-        expect(api.cookbook_base_path("#{temp_path}/templates/defaults/test.erb")).to eq temp_path
-      end
-    end
-
-    context "with a metadata.json" do
-      file "metadata.json"
-
-      it "returns the cookbook dir when passed the path itself" do
-        expect(api.cookbook_base_path(temp_path)).to eq temp_path
-      end
-
-      it "returns the cookbook dir when passed a nested directory" do
-        expect(api.cookbook_base_path("#{temp_path}/templates/defaults/test.erb")).to eq temp_path
-      end
-    end
-
-    context "with complex nested folders with metadata.rb" do
-      file "metadata.rb"
-      file "templates/metadata.rb"
-
-      it "returns the cookbook dir when path contains cookbook like names" do
-        expect(api.cookbook_base_path("#{temp_path}/templates/defaults/test.erb")).to eq "#{temp_path}/templates"
-      end
-    end
-  end
-
-  describe "#cookbook_name" do
-    it "raises if passed a nil" do
-      expect { api.cookbook_name(nil) }.to raise_error ArgumentError
-    end
-    it "raises if passed an empty string" do
-      expect { api.cookbook_name("") }.to raise_error ArgumentError
-    end
-    it "returns the cookbook name when passed a recipe" do
-      recipe_path = "cookbooks/apache2/recipes/default.rb"
-      expect(api.cookbook_name(recipe_path)).to eq "apache2"
-    end
-    it "returns the cookbook name when passed the cookbook metadata" do
-      expect(api.cookbook_name("cookbooks/apache2/metadata.rb")).to eq "apache2"
-    end
-    it "returns the cookbook name when passed a template" do
-      erb_path = "cookbooks/apache2/templates/default/a2ensite.erb"
-      expect(api.cookbook_name(erb_path)).to eq "apache2"
-    end
-    context "with a metadata.rb" do
-      file "metadata.rb", 'name "YOUR_COOKBOOK_NAME"'
-      it "returns the cookbook name when passed the cookbook metadata with a name field" do
-        expect(api.cookbook_name(temp_path)).to eq "YOUR_COOKBOOK_NAME"
-      end
-    end
-  end
-
-  describe "#cookbook_maintainer" do
-    it "raises if passed a nil" do
-      expect { api.cookbook_maintainer(nil) }.to raise_error ArgumentError
-    end
-    it "raises if passed an empty string" do
-      expect { api.cookbook_maintainer("") }.to raise_error ArgumentError
-    end
-    it "raises if the path does not exist" do
-      expect { api.cookbook_maintainer("/invalid") }.to raise_error RuntimeError
-    end
-    context "with a metadata.rb" do
-      file "metadata.rb", 'maintainer "YOUR_COMPANY_NAME"'
-      it "returns the cookbook maintainer when passed the cookbook metadata" do
-        expect(api.cookbook_maintainer(temp_path)).to eq "YOUR_COMPANY_NAME"
-      end
-      it "returns the cookbook maintainer when passed a recipe" do
-        expect(api.cookbook_maintainer("#{temp_path}/recipes/default.rb")).to eq "YOUR_COMPANY_NAME"
-      end
-      it "returns the cookbook maintainer when passed a template" do
-        expect(api.cookbook_maintainer("#{temp_path}/templates/default/mock.erb")).to eq "YOUR_COMPANY_NAME"
-      end
-    end
-  end
-
-  describe "#cookbook_maintainer_email" do
-    it "raises if passed a nil" do
-      expect { api.cookbook_maintainer_email(nil) }.to raise_error ArgumentError
-    end
-    it "raises if passed an empty string" do
-      expect { api.cookbook_maintainer_email("") }.to raise_error ArgumentError
-    end
-    it "raises if the path does not exist" do
-      expect { api.cookbook_maintainer_email("/invalid") }.to raise_error RuntimeError
-    end
-    context "with a metadata.rb" do
-      file "metadata.rb", 'maintainer_email "YOUR_EMAIL"'
-      it "returns the cookbook maintainer_email when passed the cookbook metadata" do
-        expect(api.cookbook_maintainer_email(temp_path)).to eq "YOUR_EMAIL"
-      end
-      it "returns the cookbook maintainer_email when passed a recipe" do
-        expect(api.cookbook_maintainer_email("#{temp_path}/recipes/default.rb")).to eq "YOUR_EMAIL"
-      end
-      it "returns the cookbook maintainer_email when passed a template" do
-        expect(api.cookbook_maintainer_email("#{temp_path}/templates/default/mock.erb")).to eq "YOUR_EMAIL"
-      end
-    end
-  end
-
-  describe "#declared_dependencies" do
-    let(:ast) { nil }
-    subject { api.declared_dependencies(ast) }
-    context "with an invalid options" do
-      it { expect { subject }.to raise_error ArgumentError }
-    end
-    context "with no dependencies" do
-      ast 'name "cook"'
-      it { is_expected.to eq [] }
-    end
-    context "with a simple dependency" do
-      ast 'depends "one"'
-      it { is_expected.to eq %w{one} }
-    end
-    context "with multiple simple dependencies" do
-      ast %Q{depends "one"\ndepends 'two'\ndepends('three')}
-      it { is_expected.to eq %w{one two three} }
-    end
-    context "using a word array and a one-line block" do
-      ast "%w{one two three}.each {|d| depends d }"
-      it { is_expected.to eq %w{one two three} }
-    end
-    context "using a word array and a multi-line block" do
-      ast "%w{one two three}.each do |d|\n  depends d\nend"
-      it { is_expected.to eq %w{one two three} }
-    end
-    context "using a non-standard word array" do
-      ast "%w|one two three|.each {|d| depends d }"
-      it { is_expected.to eq %w{one two three} }
-    end
-  end
-
-  describe "#field" do
-    describe :simple_ast do
-      let(:ast) { parse_ast('name "webserver"') }
-      it "raises if the field name is nil" do
-        expect { api.field(ast, nil) }.to raise_error ArgumentError
-      end
-      it "raises if the field name is empty" do
-        expect { api.field(ast, "") }.to raise_error ArgumentError
-      end
-      it "returns empty if the field is not present" do
-        expect(api.field(ast, :common_name)).to be_empty
-      end
-      it "accepts a string for the field name" do
-        expect(api.field(ast, "name")).to_not be_empty
-      end
-      it "accepts a symbol for the field name" do
-        expect(api.field(ast, :name)).to_not be_empty
-      end
-    end
-    it "returns fields when the value is an embedded string expression" do
-      ast = parse_ast(%q{
-        name "#{foo}_#{bar}"
-      }.strip)
-      expect(api.field(ast, :name).size).to eq 1
-    end
-    it "returns fields when the value is a method call" do
-      ast = parse_ast(%q{
-        name generate_name
-      }.strip)
-      expect(api.field(ast, :name).size).to eq 1
-    end
-    it "returns both fields if the field is specified twice" do
-      ast = parse_ast(%q{
-        name "webserver"
-        name "database"
-      }.strip)
-      expect(api.field(ast, :name).size).to eq 2
-    end
-  end
-
-  describe "#field_value" do
-    describe :simple_ast do
-      let(:ast) { parse_ast('name "webserver"') }
-      it "raises if the field name is nil" do
-        expect { api.field_value(ast, nil) }.to raise_error ArgumentError
-      end
-      it "raises if the field name is empty" do
-        expect { api.field_value(ast, "") }.to raise_error ArgumentError
-      end
-      it "is falsy if the field is not present" do
-        expect(api.field_value(ast, :common_name)).to be_falsey
-      end
-      it "accepts a string for the field name" do
-        expect(api.field_value(ast, "name")).to eq "webserver"
-      end
-      it "accepts a symbol for the field name" do
-        expect(api.field_value(ast, :name)).to eq "webserver"
-      end
-    end
-    it "is falsy when the value is an embedded string expression" do
-      ast = parse_ast(%q{
-        name "#{foo}_#{bar}"
-      }.strip)
-      expect(api.field_value(ast, :name)).to be_falsey
-    end
-    it "is falsy when the value is a method call" do
-      ast = parse_ast(%q{
-        name generate_name('foo')
-      }.strip)
-      expect(api.field_value(ast, :name)).to be_falsey
-    end
-    it "returns the last value if the field is specified twice" do
-      ast = parse_ast(%q{
-        name "webserver"
-        name "database"
-      }.strip)
-      expect(api.field_value(ast, :name)).to eq "database"
-    end
-  end
-
-  describe "#file_match" do
-    it "includes the provided filename in the match" do
-      expect(api.file_match("foo.rb")[:filename]).to eq "foo.rb"
-    end
-    it "retains the full provided filename path in the match" do
-      expect(api.file_match("foo/bar/foo.rb")[:filename]).to eq "foo/bar/foo.rb"
-    end
-    it "raises an error if the provided filename is nil" do
-      expect { api.file_match(nil) }.to raise_error ArgumentError
-    end
-    it "sets the line and column to the beginning of the file" do
-      match = api.file_match("bar.rb")
-      expect(match[:line]).to eq 1
-      expect(match[:column]).to eq 1
-    end
-  end
-
-  describe "#find_resources" do
-    let(:ast) { double() }
-    it "returns empty unless the ast supports XPath" do
-      expect(api.find_resources(nil)).to be_empty
-    end
-    it "restricts by resource type when provided an array" do
-      expect(ast).to receive(:xpath).with("//method_add_block[command/ident[@value='file' or @value='template']][command/ident/@value != 'action']").and_return(["method_add_block"])
-      api.find_resources(ast, type: %w{file template})
-    end
-    it "restricts by resource type when provided a string" do
-      expect(ast).to receive(:xpath).with("//method_add_block[command/ident[@value='file']][command/ident/@value != 'action']").and_return(["method_add_block"])
-      api.find_resources(ast, type: "file")
-    end
-    it "does not restrict by resource type when not provided" do
-      expect(ast).to receive(:xpath).with("//method_add_block[command/ident][command/ident/@value != 'action']").and_return(["method_add_block"])
-      api.find_resources(ast)
-    end
-    it "allows resource type to be specified as :any" do
-      expect(ast).to receive(:xpath).with("//method_add_block[command/ident][command/ident/@value != 'action']").and_return(["method_add_block"])
-      api.find_resources(ast, type: :any)
-    end
-    it "returns any matches" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(["method_add_block"])
-      expect(api.find_resources(ast)).to eq ["method_add_block"]
-    end
-  end
-
-  describe "#included_recipes" do
-    let(:ast) { double() }
-    it "raises if the ast does not support XPath" do
-      expect { api.included_recipes(nil) }.to raise_error ArgumentError
-    end
-    it "returns an empty hash if there are no included recipes" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
-      expect(api.included_recipes(ast).keys).to be_empty
-    end
-    it "returns a hash keyed by recipe name" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([{ "value" => "foo::bar" }])
-      expect(api.included_recipes(ast).keys).to eq ["foo::bar"]
-    end
-    it "returns a hash where the values are the matching nodes" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([{ "value" => "foo::bar" }])
-      expect(api.included_recipes(ast).values).to eq [[{ "value" => "foo::bar" }]]
-    end
-    it "correctly keys an included recipe specified as a string literal" do
-      ast = parse_ast(%q{
-        include_recipe "foo::default"
-      })
-      expect(api.included_recipes(ast).keys).to eq ["foo::default"]
-    end
-    describe "embedded expression - recipe name" do
-      let(:ast) do
-        parse_ast(%q{
-          include_recipe "foo::#{bar}"
-        })
-      end
-      it "returns the literal string component by default" do
-        expect(api.included_recipes(ast).keys).to eq ["foo::"]
-      end
-      it "returns the literal string part of the AST" do
-        expect(api.included_recipes(ast)["foo::"].first).to respond_to :xpath
-      end
-      it "returns empty if asked to exclude statements with embedded expressions" do
-        expect(api.included_recipes(ast, with_partial_names: false)).to be_empty
-      end
-      it "returns the literals if asked to include statements with embedded expressions" do
-        expect(api.included_recipes(ast, with_partial_names: true).keys).to eq ["foo::"]
-      end
-    end
-    describe "embedded expression - cookbook name" do
-      let(:ast) do
-        parse_ast(%q{
-          include_recipe "#{foo}::bar"
-        })
-      end
-      it "returns the literal string component by default" do
-        expect(api.included_recipes(ast).keys).to eq ["::bar"]
-      end
-      it "returns the literal string part of the AST" do
-        expect(api.included_recipes(ast)["::bar"].first).to respond_to :xpath
-      end
-      it "returns empty if asked to exclude statements with embedded expressions" do
-        expect(api.included_recipes(ast, with_partial_names: false)).to be_empty
-      end
-    end
-    describe "embedded expression - partial cookbook name" do
-      let(:ast) do
-        parse_ast(%q{
-          include_recipe "#{foo}_foo::bar"
-        })
-      end
-      it "returns the literal string component by default" do
-        expect(api.included_recipes(ast).keys).to eq ["_foo::bar"]
-      end
-      it "returns the literal string part of the AST" do
-        expect(api.included_recipes(ast)["_foo::bar"].first).to respond_to :xpath
-      end
-      it "returns empty if asked to exclude statements with embedded expressions" do
-        expect(api.included_recipes(ast, with_partial_names: false)).to be_empty
-      end
-    end
-  end
-
-  describe :AttFilter do
-    describe "#is_att_type" do
-      let(:filter) { FoodCritic::Api::AttFilter.new }
-      it "returns empty if the argument is not enumerable" do
-        expect(filter.is_att_type(nil)).to be_empty
-      end
-      it "filters out values that are not Chef node attribute types" do
-        nodes = %w{node node badger default override ostrich set normal}
-        expect(filter.is_att_type(nodes).uniq.size).to eq 5
-      end
-      it "returns all filtered nodes" do
-        nodes = %w{node node override default normal set set override}
-        expect(filter.is_att_type(nodes)).to eq nodes
-      end
-      it "returns empty if there are no Chef node attribute types" do
-        nodes = %w{squirrel badger pooh tigger}
-        expect(filter.is_att_type(nodes)).to be_empty
-      end
-    end
-  end
-
-  describe "#literal_searches" do
-    let(:ast) { double() }
-    it "returns empty if the AST does not support XPath expressions" do
-      expect(api.literal_searches(nil)).to be_empty
-    end
-    it "returns empty if the AST has no elements" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
-      expect(api.literal_searches(ast)).to be_empty
-    end
-    it "returns the AST elements for each literal search" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(["tstring_content"])
-      expect(api.literal_searches(ast)).to eq ["tstring_content"]
-    end
-  end
-
-  describe "#match" do
-    it "raises if the provided node is nil" do
-      expect { api.match(nil) }.to raise_error ArgumentError
-    end
-    it "raises if the provided node does not support XPath" do
-      expect { api.match(Object.new) }.to raise_error ArgumentError
-    end
-    it "returns nil if there is no nested position node" do
-      node = double()
-      expect(node).to receive(:xpath).with("descendant::pos").and_return([])
-      expect(api.match(node)).to be nil
-    end
-    it "uses the position of the first position node if there are multiple" do
-      node = double()
-      expect(node).to receive(:xpath).with("descendant::pos").and_return([
-        { "name" => "pos", "line" => "1", "column" => "10" },
-        { "name" => "pos", "line" => "3", "column" => "16" }])
-      match = api.match(node)
-      expect(match[:line]).to eq 1
-      expect(match[:column]).to eq 10
-    end
-    describe :matched_node_name do
-      let(:node) do
-        node = double()
-        expect(node).to receive(:xpath).with("descendant::pos").and_return([{ "name" => "pos", "line" => "1", "column" => "10" }])
-        node
-      end
-      it "includes the name of the node in the match" do
-        expect(node).to receive(:name).and_return("command")
-        expect(api.match(node)).to eq({ matched: "command", line: 1,
-                                        column: 10 })
-      end
-      it "sets the matched name to empty if the element does not have a name" do
-        expect(api.match(node)).to eq({ matched: "", line: 1, column: 10 })
-      end
-    end
-  end
-
-  describe "#notifications" do
-    it "returns empty if the provided AST does not support XPath" do
-      expect(api.notifications(nil)).to be_empty
-    end
-    it "returns empty if there are no notifications" do
-      ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-          end
-      })
-      expect(api.notifications(ast)).to be_empty
-    end
-    describe "malformed syntax" do
-      it "returns empty if no notifies value is provided" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies
-          end
-        })
-        expect(api.notifications(ast)).to be_empty
-      end
-      it "returns empty if no subscribes value is provided" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes
-          end
-        })
-        expect(api.notifications(ast)).to be_empty
-      end
-      it "returns empty if only the notifies action is provided" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies :restart
-          end
-        })
-        expect(api.notifications(ast)).to be_empty
-      end
-      it "returns empty if only the subscribes action is provided" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes :restart
-          end
-        })
-        expect(api.notifications(ast)).to be_empty
-      end
-      describe "returns empty if the service name is missing" do
-        it "old-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              notifies :restart, resources(:service)
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "old-style subscriptions" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              subscribes:restart, resources(:service)
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "new-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              notifies :restart, "service"
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "new-style subscriptions" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              subscribes:restart, "service"
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-      end
-      describe "returns empty if the resource type is missing" do
-        it "old-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              notifies :restart, resources("nscd")
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "old-style subscriptions" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              subscribes :restart, resources("nscd")
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "new-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              notifies :restart, "nscd"
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "new-style subscriptions" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              subscribes :restart, "nscd"
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-      end
-      describe "returns empty if the resource name is missing" do
-        it "old-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              notifies :restart, resources(:service)
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "old-style subscriptions" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              subscribes :restart, resources(:service)
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "new-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              notifies :restart, "service[]"
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-        it "new-style subscriptions" do
-          ast = parse_ast(%q{
-            template "/etc/nscd.conf" do
-              source "nscd.conf"
-              owner "root"
-              group "root"
-              subscribes :restart, "service[]"
-            end
-          })
-          expect(api.notifications(ast)).to be_empty
-        end
-      end
-      it "returns empty if the left square bracket is missing" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes :restart, "servicefoo]"
-          end
-        })
-        expect(api.notifications(ast)).to be_empty
-      end
-      it "returns empty if the right square bracket is missing" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes :restart, "service[foo"
-          end
-        })
-        expect(api.notifications(ast)).to be_empty
-      end
-    end
-    it "understands the old-style notifications" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies :restart, resources(:service => "nscd")
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :old,
-        }]
-    end
-    it "understands old-style notifications with :'symbol' literals as action" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies :'soft-restart', resources(:service => "nscd")
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :'soft-restart',
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :old,
-        }]
-    end
-    it "understands old-style notifications with added parentheses" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies(:restart, resources(:service => "nscd"))
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :old,
-        }]
-    end
-    it "understands old-style notifications with ruby 1.9 hash syntax" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies :restart, resources(service: "nscd")
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :old,
-        }]
-    end
-    it "understands the old-style subscriptions" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          subscribes :restart, resources(:service => "nscd")
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :subscribes,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :old,
-        }]
-    end
-    it "understands old-style subscriptions with added parentheses" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          subscribes(:restart, resources(:service => "nscd"))
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :subscribes,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :old,
-        }]
-    end
-    it "understands the new-style notifications" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies :restart, "service[nscd]"
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :new,
-        }]
-    end
-    it "understands new-style notifications with :'symbol' literals as action" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies :'soft-restart', "service[nscd]"
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :'soft-restart',
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :new,
-        }]
-    end
-    it "understands new-style notifications with added parentheses" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies(:restart, "service[nscd]")
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :new,
-        }]
-    end
-    it "understands the new-style subscriptions" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          subscribes :restart, "service[nscd]"
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :subscribes,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :new,
-        }]
-    end
-    it "understands new-style subscriptions with added parentheses" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          subscribes(:restart, "service[nscd]")
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :subscribes,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :delayed,
-          style: :new,
-        }]
-    end
-    describe "supports a resource both notifying and subscribing" do
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies :restart, resources(:service => "nscd")
-            subscribes :create, resources(:template => "/etc/nscd.conf")
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-          {
-            type: :notifies,
-            action: :restart,
-            resource_type: :service,
-            resource_name: "nscd",
-            timing: :delayed,
-            style: :old,
-          },
-          {
-            type: :subscribes,
-            action: :create,
-            resource_type: :template,
-            resource_name: "/etc/nscd.conf",
-            timing: :delayed,
-            style: :old,
-          },
-        ]
-      end
-      it "new-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies :restart, "service[nscd]"
-            subscribes :create, "template[/etc/nscd.conf]"
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-          {
-            type: :notifies,
-            action: :restart,
-            resource_type: :service,
-            resource_name: "nscd",
-            timing: :delayed,
-            style: :new,
-          },
-          {
-            type: :subscribes,
-            action: :create,
-            resource_type: :template,
-            resource_name: "/etc/nscd.conf",
-            timing: :delayed,
-            style: :new,
-          },
-        ]
-      end
-    end
-    it "understands the old-style notifications with timing" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies :restart, resources(:service => "nscd"), :immediately
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :immediate,
-          style: :old,
-        }]
-    end
-    it "understands the old-style subscriptions with timing" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          subscribes :restart, resources(:service => "nscd"), :immediately
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :subscribes,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :immediate,
-          style: :old,
-        }]
-    end
-    it "understands the new-style notifications with timing" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          notifies :restart, "service[nscd]", :immediately
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :notifies,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :immediate,
-          style: :new,
-        }]
-    end
-    it "understands the new-style subscriptions with timing" do
-      ast = parse_ast(%q{
-        template "/etc/nscd.conf" do
-          source "nscd.conf"
-          owner "root"
-          group "root"
-          subscribes :restart, "service[nscd]", :immediately
-        end
-      })
-      expect(api.notifications(ast)).to eq [{
-          type: :subscribes,
-          action: :restart,
-          resource_type: :service,
-          resource_name: "nscd",
-          timing: :immediate,
-          style: :new,
-        }]
-    end
-    describe "can be passed an individual resource" do
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          service "nscd" do
-            action :start
-          end
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies :restart, resources(:service => "nscd")
-          end
-        })
-        expect(api.notifications(api.find_resources(ast, type: :template).first)).to eq [
-          { type: :notifies, action: :restart, resource_type: :service,
-            resource_name: "nscd", timing: :delayed,
-            style: :old },
-        ]
-      end
-      it "old-style subscriptions" do
-        ast = parse_ast(%q{
-          service "nscd" do
-            action :start
-          end
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes :restart, resources(:service => "nscd")
-          end
-        })
-        expect(api.notifications(api.find_resources(ast, type: :template).first)).to eq [
-          { type: :subscribes, action: :restart, resource_type: :service,
-            resource_name: "nscd", timing: :delayed,
-            style: :old },
-        ]
-      end
-      it "new-style notifications" do
-        ast = parse_ast(%q{
-          service "nscd" do
-            action :start
-          end
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies :restart, "service[nscd]"
-          end
-        })
-        expect(api.notifications(api.find_resources(ast, type: :template).first)).to eq [
-          { type: :notifies, action: :restart, resource_type: :service,
-            resource_name: "nscd", timing: :delayed,
-            style: :new },
-        ]
-      end
-      it "new-style subscriptions" do
-        ast = parse_ast(%q{
-          service "nscd" do
-            action :start
-          end
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes :restart, "service[nscd]"
-          end
-        })
-        expect(api.notifications(api.find_resources(ast, type: :template).first)).to eq [
-          { type: :subscribes, action: :restart, resource_type: :service,
-            resource_name: "nscd", timing: :delayed,
-            style: :new },
-        ]
-      end
-    end
-    describe "supports multiple notifications on a single resource" do
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies :stop, resources(:service => "nscd")
-            notifies :start, resources(:service => "nscd")
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-            { type: :notifies, action: :stop, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :old },
-            { type: :notifies, action: :start, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :old },
-          ]
-      end
-      it "old-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes :stop, resources(:service => "nscd")
-            subscribes :start, resources(:service => "nscd")
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-            { type: :subscribes, action: :stop, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :old },
-            { type: :subscribes, action: :start, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :old },
-          ]
-      end
-      it "new-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            notifies :stop, "service[nscd]"
-            notifies :start, "service[nscd]"
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-            { type: :notifies, action: :stop, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :new },
-            { type: :notifies, action: :start, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :new },
-          ]
-      end
-      it "new-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/nscd.conf" do
-            source "nscd.conf"
-            owner "root"
-            group "root"
-            subscribes :stop, "service[nscd]"
-            subscribes :start, "service[nscd]"
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-            { type: :subscribes, action: :stop, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :new },
-            { type: :subscribes, action: :start, resource_type: :service,
-              resource_name: "nscd", timing: :delayed,
-              style: :new },
-          ]
-      end
-    end
-    describe "understands notifications for an execute resource" do
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          template "/tmp/foo.bar" do
-            source "foo.bar.erb"
-            notifies :run, resources(:execute => "foo")
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-           { type: :notifies, action: :run, resource_type: :execute,
-             resource_name: "foo", timing: :delayed,
-             style: :old },
-          ]
-      end
-      it "old-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/tmp/foo.bar" do
-            source "foo.bar.erb"
-            subscribes :run, resources(:execute => "foo")
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-           { type: :subscribes, action: :run, resource_type: :execute,
-             resource_name: "foo", timing: :delayed,
-             style: :old },
-          ]
-      end
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          template "/tmp/foo.bar" do
-            source "foo.bar.erb"
-            notifies :run, "execute[foo]"
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-           { type: :notifies, action: :run, resource_type: :execute,
-             resource_name: "foo", timing: :delayed,
-             style: :new },
-          ]
-      end
-      it "old-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/tmp/foo.bar" do
-            source "foo.bar.erb"
-            subscribes :run, "execute[foo]"
-          end
-        })
-        expect(api.notifications(ast)).to eq [
-           { type: :subscribes, action: :run, resource_type: :execute,
-             resource_name: "foo", timing: :delayed,
-             style: :new },
-          ]
-      end
-    end
-    describe "sets the notification timing to delayed if specified" do
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :run, resources(execute => "robespierre"), :delayed
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :delayed
-      end
-      it "old-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            subscribes :run, resources(execute => "robespierre"), :delayed
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :delayed
-      end
-      it "new-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :run, "execute[robespierre]", :delayed
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :delayed
-      end
-      it "new-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            subscribes :run, "execute[robespierre]", :delayed
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :delayed
-      end
-    end
-    describe "sets the notification timing to immediate if specified as immediate" do
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :run, resources(execute => "robespierre"), :immediate
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-      it "old-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            subscribes :run, resources(execute => "robespierre"), :immediate
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-      it "new-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :run, "execute[robespierre]", :immediate
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-      it "new-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            subscribes :run, "execute[robespierre]", :immediate
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-    end
-
-    describe "sets the notification timing to immediate if specified as immediately" do
-      it "old-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :run, resources(execute => "robespierre"), :immediately
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-      it "old-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            subscribes :run, resources(execute => "robespierre"), :immediately
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-      it "new-style notifications" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :run, "execute[robespierre]", :immediately
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-      it "new-style subscriptions" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            subscribes :run, "execute[robespierre]", :immediately
-          end
-        })
-        expect(api.notifications(ast).first[:timing]).to eq :immediate
-      end
-    end
-    it "passes unrecognised notification timings through unchanged" do
-      ast = parse_ast(%q{
-        template "/etc/foo.conf" do
-          notifies :run, resources(execute => "robespierre"), :forthwith
-        end
-      })
-      expect(api.notifications(ast).first[:timing]).to eq :forthwith
-    end
-    describe "resource names as expressions" do
-      describe "returns the AST for an embedded string" do
-        it "old-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/foo.conf" do
-              notifies :create, resources(:template => "/etc/bar/#{resource}.bar")
-            end
-          })
-          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
-        end
-        it "new-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/foo.conf" do
-              notifies :create, "template[/etc/bar/#{resource}.bar]"
-            end
-          })
-          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
-        end
-        it "new-style notifications - complete resource_name" do
-          ast = parse_ast(%q{
-            template "/etc/foo.conf" do
-              notifies :create, "template[#{template_path}]"
-            end
-          })
-          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
-        end
-      end
-      describe "returns the AST for node attribute" do
-        it "old-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/foo.conf" do
-              notifies :restart, resources(:service => node['foo']['service'])
-            end
-          })
-          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
-        end
-        it "new-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/foo.conf" do
-              notifies :restart, "service[#{node['foo']['service']}]"
-            end
-          })
-          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
-        end
-      end
-      describe "returns the AST for variable reference" do
-        it "old-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/foo.conf" do
-              notifies :restart, resources(:service => my_service)
-            end
-          })
-          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
-        end
-        it "new-style notifications" do
-          ast = parse_ast(%q{
-            template "/etc/foo.conf" do
-              notifies :restart, "service[#{my_service}]"
-            end
-          })
-          expect(api.notifications(ast).first[:resource_name]).to respond_to :xpath
-        end
-      end
-    end
-    describe "mark style of notification" do
-      it "specifies that the notification was in the old style" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :restart, resources(:service => 'foo')
-          end
-        })
-        expect(api.notifications(ast).first[:style]).to eq :old
-      end
-      it "specifies that the notification was in the new style" do
-        ast = parse_ast(%q{
-          template "/etc/foo.conf" do
-            notifies :restart, "service[foo]"
-          end
-        })
-        expect(api.notifications(ast).first[:style]).to eq :new
-      end
-    end
-  end
-
-  describe "#read_ast" do
-    it "raises if the file cannot be read" do
-      expect { api.read_ast(nil) }.to raise_error TypeError
-    end
-  end
-
-  describe "#resource_attribute" do
-    let(:resource) do
-      Class.new do
-        def xpath(str)
-          raise "Not expected"
-        end
-      end.new
-    end
-    it "raises if the resource does not support XPath" do
-      expect { api.resource_attribute(nil, "mode") }.to raise_error ArgumentError
-    end
-    it "raises if the attribute name is empty" do
-      expect { api.resource_attribute(resource, "") }.to raise_error ArgumentError
-    end
-  end
-
-  describe "#resource_attributes" do
-    def str_to_atts(str)
-      api.resource_attributes(api.find_resources(parse_ast(str)).first)
-    end
-    it "raises if the resource does not support XPath" do
-      expect { api.resource_attributes(nil) }.to raise_error ArgumentError
-    end
-    it "returns a string value for a literal string" do
-      atts = str_to_atts(%q{
-        directory "/foo/bar" do
-          owner "root"
-        end
-      })
-      expect(atts["owner"]).to eq "root"
-    end
-    it "returns a truthy value for a literal true" do
-      atts = str_to_atts(%q{
-        directory "/foo/bar" do
-          recursive true
-        end
-      })
-      expect(atts["recursive"]).to be true
-    end
-    it "returns a truthy value for a literal false" do
-      atts = str_to_atts(%q{
-        directory "/foo/bar" do
-          recursive false
-        end
-      })
-      expect(atts["recursive"]).to be false
-    end
-    it "decodes numeric attributes correctly" do
-      atts = str_to_atts(%q{
-        directory "/foo/bar" do
-          owner "root"
-          mode 0755
-        end
-      })
-      expect(atts["mode"]).to eq "0755"
-    end
-    describe "block attributes" do
-      it "includes attributes with brace block values in the result" do
-        atts = str_to_atts(%q{
-          file "/etc/foo" do
-            mode "0600"
-            action :create
-            only_if { File.exists?("/etc/bar") }
-          end
-        })
-        expect(atts["only_if"]).to respond_to :xpath
-        expect(atts["only_if"].name).to eq "brace_block"
-      end
-      it "includes attributes with do block values in the result" do
-        atts = str_to_atts(%q{
-          file "/etc/foo" do
-            mode "0600"
-            action :create
-            only_if do
-              !File.exists?(foo) || (File.exists?(bar) &&
-                File.mtime(baz) < last_changedate)
-            end
-          end
-        })
-        expect(atts["only_if"]).to respond_to :xpath
-        expect(atts["only_if"].name).to eq "do_block"
-      end
-      it "supports multiple block attributes" do
-        atts = str_to_atts(%q{
-          file "/etc/foo" do
-            mode "0600"
-            action :create
-            only_if { false }
-            not_if { true }
-          end
-        })
-        expect(atts["only_if"]).to respond_to :xpath
-        expect(atts["only_if"].name).to eq "brace_block"
-        expect(atts["not_if"]).to respond_to :xpath
-        expect(atts["not_if"].name).to eq "brace_block"
-      end
-      it "doesn't include method calls in ruby blocks" do
-        atts = str_to_atts(%q{
-          ruby_block "example" do
-            block do
-              foo do |bar|
-                Chef::Log.info(bar)
-              end
-            end
-            only_if { true }
-            not_if { false }
-          end
-        })
-        expect(atts.keys).to_not include "foo"
-        expect(atts["block"]).to respond_to :xpath
-        expect(atts["block"].name).to eq "do_block"
-        expect(atts["only_if"]).to respond_to :xpath
-        expect(atts["only_if"].name).to eq "brace_block"
-        expect(atts["not_if"]).to respond_to :xpath
-        expect(atts["not_if"].name).to eq "brace_block"
-      end
-      it "includes notifications in the result" do
-        atts = str_to_atts(%q{
-          template "/etc/httpd.conf" do
-            notifies :restart, "service[apache]"
-          end
-        })
-        expect(atts["notifies"]).to respond_to :xpath
-        expect(atts["notifies"].name).to eq "args_add_block"
-      end
-      it "includes old-style notifications in the result" do
-        atts = str_to_atts(%q{
-          template "/etc/httpd.conf" do
-            notifies :restart, resources(:service => "apache")
-          end
-        })
-        expect(atts["notifies"]).to respond_to :xpath
-        expect(atts["notifies"].name).to eq "args_add_block"
-      end
-    end
-  end
-
-  describe "#resource_attributes_by_type" do
-    it "raises if the ast does not support XPath" do
-      expect { api.resource_attributes_by_type(nil) }.to raise_error ArgumentError
-    end
-    it "returns an empty hash if there are no resources" do
-      ast = double()
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
-      expect(api.resource_attributes_by_type(ast)).to be_empty
-    end
-  end
-
-  describe "#resource_name" do
-    it "raises if the resource does not support XPath" do
-      expect { api.resource_name("foo") }.to raise_error ArgumentError
-    end
-    it "returns the resource name for a resource" do
-      ast = double()
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return("bob")
-      expect(api.resource_name(ast)).to eq "bob"
-    end
-  end
-
-  describe "#resources_by_type" do
-    it "raises if the ast does not support XPath" do
-      expect { api.resources_by_type(nil) }.to raise_error ArgumentError
-    end
-    it "returns an empty hash if there are no resources" do
-      ast = double()
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
-      expect(api.resources_by_type(ast)).to be_empty
-    end
-  end
-
-  describe "#resource_type" do
-    it "raises if the resource does not support XPath" do
-      expect { api.resource_type(nil) }.to raise_error ArgumentError
-    end
-    it "raises if the resource type cannot be determined" do
-      ast = double()
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return("")
-      expect { api.resource_type(ast) }.to raise_error ArgumentError
-    end
-    it "returns the resource type for a resource" do
-      ast = double()
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return("directory")
-      expect(api.resource_type(ast)).to eq "directory"
-    end
-  end
-
-  describe "#ruby_code?" do
-    it "says a nil is not ruby code" do
-      expect(api.ruby_code?(nil)).to be_falsey
-    end
-    it "says an empty string is not ruby code" do
-      expect(api.ruby_code?("")).to be_falsey
-    end
-    it "coerces arguments to a string" do
-      expect(api.ruby_code?(%w{foo bar})).to be_truthy
-    end
-    it "returns true for a snippet of ruby code" do
-      expect(api.ruby_code?("assert api.ruby_code?(nil)")).to be_truthy
-    end
-    it "returns false for a unix command" do
-      expect(api.ruby_code?("find -type f -print")).to be_falsey
-    end
-  end
-
-  describe "#searches" do
-    let(:ast) { double() }
-    it "returns empty if the AST does not support XPath expressions" do
-      expect(api.searches("not-an-ast")).to be_empty
-    end
-    it "returns empty if the AST has no elements" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return([])
-      expect(api.searches(ast)).to be_empty
-    end
-    it "returns the AST elements for each use of search" do
-      expect(ast).to receive(:xpath).with(kind_of(String)).and_return(["ident"])
-      expect(api.searches(ast)).to eq ["ident"]
-    end
-  end
-
-  describe "#standard_cookbook_subdirs" do
-    it "is enumerable" do
-      api.standard_cookbook_subdirs.each { |s| s }
-    end
-    it "is sorted in alphabetical order" do
-      expect(api.standard_cookbook_subdirs).to eq api.standard_cookbook_subdirs.sort
-    end
-    it "includes the directories generated by knife create cookbook" do
-      %w{attributes definitions files libraries providers recipes resources
-         templates}.each do |dir|
-        expect(api.standard_cookbook_subdirs).to include dir
-      end
-    end
-    it "does not include the spec directory" do
-      expect(api.standard_cookbook_subdirs).to_not include "spec"
-    end
-    it "does not include a subdirectory of a subdirectory" do
-      expect(api.standard_cookbook_subdirs).to_not include "default"
-    end
-  end
-
-  describe "#supported_platforms" do
-    subject { api.supported_platforms(ast) }
-
-    context "with no platforms" do
-      ast 'name "supports"'
-      it { is_expected.to eq [] }
-    end
-    context "with supports but no argument" do
-      ast "supports"
-      it { is_expected.to eq [] }
-    end
-    context "with supports using a string expression" do
-      ast 'supports "red#{hat}"'
-      it { is_expected.to eq [] }
-    end
-    context "with supports using a complex string expression" do
-      ast 'supports "red#{hat(foo "bar")}"'
-      it { is_expected.to eq [] }
-    end
-    context "with a single platform" do
-      ast 'supports "redhat"'
-      it { is_expected.to eq [{ platform: "redhat", versions: [] }] }
-    end
-    context "with multiple platforms" do
-      ast "supports 'oracle'\nsupports 'redhat'\nsupports 'scientific'"
-      it do
-        is_expected.to eq [{ platform: "oracle", versions: [] },
-                              { platform: "redhat", versions: [] },
-                              { platform: "scientific", versions: [] }] end
-    end
-    context "with multiple platforms not in alphabetical order" do
-      ast "supports 'redhat'\nsupports 'scientific'\nsupports 'oracle'"
-      it do
-        is_expected.to eq [{ platform: "oracle", versions: [] },
-                              { platform: "redhat", versions: [] },
-                              { platform: "scientific", versions: [] }] end
-    end
-    context "with a version constraint" do
-      ast 'supports "redhat", ">= 6"'
-      it { is_expected.to eq [{ platform: "redhat", versions: [">= 6"] }] }
-    end
-    context "with complex version constraints" do
-      ast %q{
-        supports 'redhat', '> 5.0', '< 7.0'
-        supports 'scientific', '> 5.0', '< 6.0'
-      }
-      it do
-        is_expected.to eq [{ platform: "redhat", versions: ["> 5.0", "< 7.0"] },
-                              { platform: "scientific", versions: ["> 5.0", "< 6.0"] }] end
-    end
-    context "with a symbol platform" do
-      ast "supports :ubuntu"
-      it { is_expected.to eq [{ platform: "ubuntu", versions: [] }] }
-    end
-    context "with a symbol platform with a version constraint" do
-      ast 'supports :ubuntu, ">= 6"'
-      it { is_expected.to eq [{ platform: "ubuntu", versions: [">= 6"] }] }
-    end
-    context "with a word list" do
-      ast "%w{redhat centos fedora}.each {|os| supports os }"
-      it do
-        is_expected.to eq [{ platform: "centos", versions: [] },
-                              { platform: "fedora", versions: [] },
-                              { platform: "redhat", versions: [] }] end
-    end
-    context "with a multi-line word list" do
-      ast %q{
-        %w(
-          redhat
-          centos
-          fedora
-        ).each do |os|
-          supports os
-        end
-      }
-      it do
-        is_expected.to eq [{ platform: "centos", versions: [] },
-                              { platform: "fedora", versions: [] },
-                              { platform: "redhat", versions: [] }] end
-    end
-    context "with both a word list and a non-word list" do
-      ast "supports 'redhat'\n%w{centos fedora}.each {|os| supports os }"
-      it do
-        is_expected.to eq [{ platform: "centos", versions: [] },
-                              { platform: "fedora", versions: [] },
-                              { platform: "redhat", versions: [] }] end
-    end
-  end
-
-  describe "#templates_included" do
-
-    def all_templates
-      [
-        "templates/default/main.erb",
-        "templates/default/included_1.erb",
-        "templates/default/included_2.erb",
-      ]
-    end
-
-    def template_ast(content)
-      parse_ast(FoodCritic::Template::ExpressionExtractor.new.extract(
-        content).map { |e| e[:code] }.join(";"))
-    end
-
-    it "returns the path of the containing template when there are no partials" do
-      ast = parse_ast("<%= foo.erb %>")
-      expect(api).to receive(:read_ast).with("foo.erb").and_return(ast)
-      expect(api.templates_included(["foo.erb"], "foo.erb")).to eq ["foo.erb"]
-    end
-
-    it "returns the path of the containing template and any partials" do
-      main_ast = template_ast('<%= render "included_1.erb" %>
-                                <%= render "included_2.erb" %>')
-      inner_ast = template_ast("<%= @foo %>")
-      expect(api).to receive(:read_ast).with(/main/).and_return(main_ast)
-      expect(api).to receive(:read_ast).and_return(inner_ast).twice
-      expect(api.templates_included(all_templates, "templates/default/main.erb")).to eq [
-        "templates/default/main.erb",
-        "templates/default/included_1.erb",
-        "templates/default/included_2.erb",
-      ]
-    end
-
-    it "doesn't mistake render options for partial template names" do
-      main_ast = template_ast('<%= render "included_1.erb",
-                               :variables => {:foo => "included_2.erb"} %>')
-      inner_ast = template_ast("<%= @foo %>")
-      expect(api).to receive(:read_ast).with(/main/).and_return(main_ast)
-      expect(api).to receive(:read_ast).and_return(inner_ast)
-      expect(api.templates_included(all_templates, "templates/default/main.erb")).to eq [
-        "templates/default/main.erb",
-        "templates/default/included_1.erb",
-      ]
-    end
-
-    it "raises if included partials have cycles" do
-      main_ast = template_ast('<%= render "included_1.erb" %>
-                                <%= render "included_2.erb" %>')
-      loop_ast = template_ast('<%= render "main.erb" %>')
-      inner_ast = template_ast("<%= foo %>")
-      expect(api).to receive(:read_ast).with(/main/).and_return(main_ast).at_least(:once)
-      expect(api).to receive(:read_ast).with(/included_2/).and_return(loop_ast).at_least(:once)
-      expect(api).to receive(:read_ast).and_return(inner_ast).at_least(:once)
-      expect { api.templates_included(all_templates, "templates/default/main.erb") }.to raise_error(FoodCritic::Api::RecursedTooFarError, "templates/default/main.erb")
-    end
-  end
-
-  describe "#json_file_to_hash" do
-
-    it "raises if the filename is not provided" do
-      expect { api.json_file_to_hash }.to raise_error ArgumentError
-    end
-
-    it "raises if the filename is not found" do
-      expect(::File).to receive(:exist?).with("/some/path/with/a/file").and_return(false)
-      expect { api.json_file_to_hash("/some/path/with/a/file") }.to raise_error RuntimeError
-    end
-
-    it "raises if the json is not valid" do
-      expect(::File).to receive(:exist?).with("/some/path/with/a/file").and_return(true)
-      allow(File).to receive(:read).with("/some/path/with/a/file").and_return("I am bogus data")
-      expect { api.json_file_to_hash("/some/path/with/a/file") }.to raise_error RuntimeError
-    end
-  end
-
-end