foodcritic 15.0.0 → 15.1.0

data/spec/functional/fc050_spec.rb

@@ -1,85 +0,0 @@
-require "spec_helper"
-
-describe "FC050" do
-  context "with a role" do
-    foodcritic_command("--no-progress", "-R", "roles")
-    let(:role_name) { "" }
-    file("roles/webserver.rb") { "name '#{role_name}'\nrun_list ['recipe[apache]']" }
-
-    context "with name webserver" do
-      let(:role_name) { "webserver" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name web_server" do
-      let(:role_name) { "web_server" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name web-server" do
-      let(:role_name) { "web-server" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name webserver123" do
-      let(:role_name) { "webserver123" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name Webserver" do
-      let(:role_name) { "Webserver" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name web server" do
-      let(:role_name) { "web server" }
-      it { is_expected.to violate_rule }
-    end
-
-    context "with name webserver%" do
-      let(:role_name) { "webserver%" }
-      it { is_expected.to violate_rule }
-    end
-  end
-
-  context "with an environment" do
-    foodcritic_command("--no-progress", "-E", "environments")
-    let(:environment_name) { "" }
-    file("environments/production.rb") { "name '#{environment_name}'\ncookbook 'apache2'" }
-
-    context "with name production" do
-      let(:environment_name) { "production" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name pre_production" do
-      let(:environment_name) { "pre_production" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name production-eu" do
-      let(:environment_name) { "production-eu" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name production2" do
-      let(:environment_name) { "production2" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name Production" do
-      let(:environment_name) { "Production" }
-      it { is_expected.to_not violate_rule }
-    end
-
-    context "with name EU West" do
-      let(:environment_name) { "EU West" }
-      it { is_expected.to violate_rule }
-    end
-
-    context "with name production (eu-west)" do
-      let(:environment_name) { "production (eu-west)" }
-      it { is_expected.to violate_rule }
-    end
-  end
-end

data/spec/functional/fc052_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC052" do
-  context "with a cookbook with a metadata file that does contain the suggests keyword" do
-    metadata_file "suggests 'runit'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that does not contain the suggests keyword" do
-    metadata_file
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc053_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC053" do
-  context "with a cookbook with a metadata file that does contain the recommends keyword" do
-    metadata_file "recommends 'runit'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that does not contain the recommends keyword" do
-    metadata_file
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc055_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC055" do
-  context "with a cookbook with a metadata file that does not specify a maintainer" do
-    metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a maintainer" do
-    metadata_file "maintainer 'Some Person'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a maintainer as an expression" do
-    metadata_file("maintainer an(expression)")
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc056_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC056" do
-  context "with a cookbook with a metadata file that does not specify a maintainer_email" do
-    metadata_file
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a maintainer_email" do
-    metadata_file "maintainer_email 'foo@example.com'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a maintainer_email as an expression" do
-    metadata_file("maintainer_email an(expression)")
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc058_spec.rb

@@ -1,102 +0,0 @@
-require "spec_helper"
-
-describe "FC058" do
-  context "with a cookbook with a library provider with use_inline_resources and uses def action_create" do
-    library_file <<-EOF
-    class MyResources
-      class Site < Chef::Resource::LWRPBase
-        provides :site
-        resource_name :site
-        actions :create
-        attribute :name, :kind_of => String, :name_attribute => true
-      end
-    end
-
-    class MyProviders
-      class Site < Chef::Provider::LWRPBase
-        provides :site
-
-        use_inline_resources
-
-        def action_create
-          file "/tmp/foo.txt"
-        end
-      end
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a library provider without use_inline_resources and uses def action_create" do
-    library_file <<-EOF
-    class MyResources
-      class Site < Chef::Resource::LWRPBase
-        provides :site
-        resource_name :site
-        actions :create
-        attribute :name, :kind_of => String, :name_attribute => true
-      end
-    end
-
-    class MyProviders
-      class Site < Chef::Provider::LWRPBase
-        provides :site
-
-        def action_create
-          file "/tmp/foo.txt"
-        end
-      end
-    end
-    EOF
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a cookbook that contains a library provider with use_inline_resources" do
-    library_file <<-EOF
-    class MyResources
-      class Site < Chef::Resource::LWRPBase
-        provides :site
-        resource_name :site
-        actions :create
-        attribute :name, :kind_of => String, :name_attribute => true
-      end
-    end
-
-    class MyProviders
-      class Site < Chef::Provider::LWRPBase
-        provides :site
-        use_inline_resources
-
-        action :create do
-          file "/tmp/foo.txt"
-        end
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with a library provider without use_inline_resources" do
-    library_file <<-EOF
-    class MyResources
-      class Site < Chef::Resource::LWRPBase
-        provides :site
-        resource_name :site
-        actions :create
-        attribute :name, :kind_of => String, :name_attribute => true
-      end
-    end
-
-    class MyProviders
-      class Site < Chef::Provider::LWRPBase
-        provides :site
-
-        action :create do
-          file "/tmp/foo.txt"
-        end
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc060_spec.rb

@@ -1,45 +0,0 @@
-require "spec_helper"
-
-describe "FC060" do
-  context "with a cookbook with LWRP with use_inline_resources and with bad action_create" do
-    provider_file <<-EOF
-    use_inline_resources
-
-    def action_create
-      cookbook_file "/etc/something.conf"
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with LWRP without use_inline_resources and with bad action_create" do
-    provider_file <<-EOF
-    def action_create
-      cookbook_file "/etc/something.conf"
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with LWRP without use_inline_resources" do
-    provider_file <<-EOF
-    action :create do
-      cookbook_file "/etc/something.conf"
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with LWRP using use_inline_resources" do
-    provider_file <<-EOF
-    use_inline_resources
-
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc061_spec.rb

@@ -1,48 +0,0 @@
-require "spec_helper"
-
-describe "FC061" do
-  context "with a cookbook with metadata that includes the version keyword and a valid version string" do
-    metadata_file("version '1.2.3'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with metadata that includes the version keyword and a valid version string with double quotes" do
-    metadata_file('version "1.2.3"')
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with metadata that includes the version keyword and a valid x.y version string" do
-    metadata_file("version '1.2'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with metadata that does not include a version keyword" do
-    metadata_file("name 'something'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with metadata that includes the version keyword and an invalid version string" do
-    metadata_file("version 'one'")
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook metadata that includes the version keyword and an invalid single digit version string" do
-    metadata_file("version '1'")
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook metadata that includes the version keyword and an invalid four digit version string" do
-    metadata_file("version '1.2.3.4'")
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook metadata that includes the version keyword that uses string interpolation" do
-    metadata_file('patch = 3\nversion "1.2.#{patch}"')
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook metadata that includes the version keyword that is not a string literal" do
-    metadata_file('v = "1.2.3"\nversion v')
-    it { is_expected.not_to violate_rule }
-  end
-end

data/spec/functional/fc062_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC062" do
-  context "with a cookbook with metadata that includes the version keyword and a valid version string" do
-    metadata_file("version '1.2.3'")
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook with metadata that does not include a version keyword" do
-    metadata_file
-    it { is_expected.to violate_rule }
-  end
-end

data/spec/functional/fc063_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-
-describe "FC063" do
-  context "with a cookbook with a metadata file that depends on itself" do
-    metadata_file "name 'something'\ndepends 'something'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that depends on a cookbook, but not itself" do
-    metadata_file "name 'something'\ndepends 'another_thing'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that doesn't depend on any cookbooks" do
-    metadata_file "name 'something'"
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc064_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC064" do
-  context "with a cookbook with a metadata file that does not specify issues_url" do
-    metadata_file
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a issues_url" do
-    metadata_file "issues_url 'http://wwww.something.com/'"
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc065_spec.rb

@@ -1,13 +0,0 @@
-require "spec_helper"
-
-describe "FC065" do
-  context "with a cookbook with a metadata file that does not specify source_url" do
-    metadata_file
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a source_url" do
-    metadata_file "source_url 'http://wwww.something.com/'"
-    it { is_expected.to_not violate_rule }
-  end
-end

data/spec/functional/fc066_spec.rb

@@ -1,33 +0,0 @@
-require "spec_helper"
-
-describe "FC066" do
-  context "with a cookbook with a metadata file that does not specify chef_version" do
-    metadata_file "name 'my_cookbook'"
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a chef_version" do
-    metadata_file "chef_version '>= 12.1'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a chef_version with a guard" do
-    metadata_file "chef_version '>= 12.1' if defined?(chef_version)"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a chef_version with parens" do
-    metadata_file "chef_version('>= 12.1')"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a chef_version with multiple arguments" do
-    metadata_file "chef_version '>= 12.1', '< 14'"
-    it { is_expected.to_not violate_rule }
-  end
-
-  context "with a cookbook with a metadata file that specifies a chef_version with a splat" do
-    metadata_file "chef_version(*['>= 12.1', '< 14'])"
-    it { is_expected.to_not violate_rule }
-  end
-end