solarwindpy 0.0.1.dev0__py3-none-any.whl → 0.1.0__py3-none-any.whl

plans/completed/combined_test_plan_with_checklist_plotting/4-scatter.py.md

@@ -0,0 +1,167 @@
+---
+name: 'Combined Plan and Checklist: Scatter Plotting'
+about: Unified documentation and checklist for validating scatter plotting functionality.
+labels: [sweep, plotting, Scatter, scatter plots]
+---
+
+> Phase 4 of Enhanced Plotting Test Plan
+
+## 🧠 Context
+
+The `solarwindpy.plotting.scatter` module provides scatter plot functionality with optional color mapping capabilities. The `Scatter` class inherits from both `base.PlotWithZdata` and `base.CbarMaker` to enable 2D scatter plots with optional color-coded third dimension visualization.
+
+### Key Components
+- **Scatter Class**: Main scatter plotting implementation
+- **Color Mapping**: Optional z-data for color-coded scatter points  
+- **Data Clipping**: Configurable extreme value removal
+- **Axes Integration**: Full matplotlib axes formatting support
+
+### Dependencies
+- Inherits from `base.PlotWithZdata` and `base.CbarMaker`
+- Uses `base.AxesLabels` and `base.LogAxes` for axis management
+- Integrates with matplotlib for plot rendering
+
+## 📋 Comprehensive Test Checklist
+
+### 4.1 Module Structure and Exports
+
+- [ ] **Import verification**: Verify `from . import base` import works correctly
+- [ ] **Class availability**: Test that `Scatter` class is accessible from module
+- [ ] **Inheritance validation**: Confirm `Scatter` inherits from `PlotWithZdata` and `CbarMaker`
+
+### 4.2 `Scatter` Class Initialization
+
+- [ ] **Basic initialization**: `Scatter(x, y)` with pandas Series inputs
+- [ ] **With z-data**: `Scatter(x, y, z)` including color mapping data
+- [ ] **Data clipping**: `Scatter(x, y, clip_data=True)` removes extreme values
+- [ ] **Data clipping disabled**: `Scatter(x, y, clip_data=False)` preserves all data
+- [ ] **Parameter validation**: Test invalid input types raise appropriate errors
+- [ ] **Empty data handling**: Test behavior with empty pandas Series
+- [ ] **Mismatched data lengths**: Test error handling for different length x, y, z
+
+### 4.3 Data Management Methods
+
+#### `set_data()` method
+- [ ] **Data assignment**: Correctly stores x, y coordinate data
+- [ ] **Z-data handling**: Properly manages optional color mapping data
+- [ ] **Clip parameter**: Respects clip_data flag for extreme value removal
+- [ ] **Data validation**: Ensures input data are compatible pandas Series
+- [ ] **Index alignment**: Handles misaligned pandas Series indices
+
+#### Data properties and access
+- [ ] **Data retrieval**: Access to stored x, y, z data
+- [ ] **Data integrity**: Verify data remains unchanged after storage
+- [ ] **Clipping effects**: Confirm extreme values removed when clip_data=True
+
+### 4.4 Label and Axis Configuration
+
+#### Labels management
+- [ ] **Default labels**: `_labels` initialized with "x", "y", "z" defaults
+- [ ] **Label customization**: Update axis labels via `_labels` property
+- [ ] **Z-label handling**: Z-label set to None when no z-data provided
+- [ ] **Label persistence**: Labels maintain values across operations
+
+#### Axis scaling
+- [ ] **Log scale defaults**: `_log` initialized with x=False, y=False
+- [ ] **Log scale configuration**: Test setting logarithmic scales for x, y axes
+- [ ] **Scale validation**: Ensure log scales work with positive data only
+
+### 4.5 Path and Display Configuration
+
+- [ ] **Path initialization**: `set_path(None)` sets default path behavior
+- [ ] **Path customization**: Test setting custom file output paths
+- [ ] **Path validation**: Verify valid path formats are accepted
+
+### 4.6 Plot Generation and Formatting
+
+#### `_format_axis()` method
+- [ ] **Axis formatting**: Calls parent class `_format_axis(ax)` method
+- [ ] **Collection handling**: Properly formats matplotlib collection objects
+- [ ] **Inheritance behavior**: Ensures base class formatting is applied
+
+#### Plot creation
+- [ ] **Basic scatter plot**: Generate scatter plot with x, y data only
+- [ ] **Color-mapped plot**: Create scatter plot with z-data color mapping
+- [ ] **Matplotlib integration**: Verify plot renders correctly in matplotlib
+- [ ] **Collection objects**: Confirm scatter plot returns valid matplotlib collections
+
+### 4.7 Color Bar Integration
+
+#### Color bar creation (inherited from `CbarMaker`)
+- [ ] **Color bar presence**: Color bar created when z-data provided
+- [ ] **Color bar absence**: No color bar when only x, y data provided
+- [ ] **Color mapping**: Verify z-data values correctly map to colors
+- [ ] **Color bar labeling**: Proper labeling of color bar axis
+
+### 4.8 Integration with Base Classes
+
+#### `PlotWithZdata` integration
+- [ ] **Z-data handling**: Inherits proper z-data management
+- [ ] **Data validation**: Uses base class data validation methods
+- [ ] **Property access**: Base class properties accessible
+
+#### `CbarMaker` integration  
+- [ ] **Color bar methods**: Access to color bar creation methods
+- [ ] **Color mapping**: Proper color mapping functionality
+- [ ] **Axis integration**: Color bar integrates with main plot axes
+
+### 4.9 Error Handling and Edge Cases
+
+- [ ] **Invalid data types**: Non-pandas Series inputs raise appropriate errors
+- [ ] **NaN/inf handling**: Graceful handling of NaN and infinite values
+- [ ] **Missing data**: Behavior with incomplete or missing data points
+- [ ] **Single point data**: Handle scatter plots with only one data point
+- [ ] **Negative values with log**: Appropriate handling when log scales meet negative data
+
+### 4.10 Performance and Memory
+
+- [ ] **Large datasets**: Performance with large numbers of scatter points
+- [ ] **Memory usage**: Efficient memory usage for data storage and plotting
+- [ ] **Data copying**: Minimal unnecessary data duplication
+
+### 4.11 Documentation and Examples
+
+- [ ] **Docstring completeness**: Class and method docstrings present and accurate
+- [ ] **Parameter documentation**: All parameters properly documented
+- [ ] **Example usage**: Working code examples in docstrings
+- [ ] **Return value docs**: Clear documentation of return values
+
+### 4.12 Test Infrastructure
+
+- [ ] **Test fixtures**: Reusable test data for scatter plot testing
+- [ ] **Mock matplotlib**: Mock matplotlib operations to avoid GUI display
+- [ ] **Parameterized tests**: Test multiple data configurations efficiently
+- [ ] **Performance benchmarks**: Time scatter plot operations for regression detection
+
+## 🎯 Testing Strategy
+
+### Unit Testing Approach
+- Test each method in isolation with controlled inputs
+- Verify inheritance chain works correctly
+- Mock matplotlib operations to focus on data handling logic
+
+### Integration Testing  
+- Test full scatter plot creation workflow
+- Verify interaction between data management and plot rendering
+- Test color mapping end-to-end functionality
+
+### Edge Case Coverage
+- Empty datasets, single points, extreme values
+- Invalid inputs and error conditions
+- Large dataset performance characteristics
+
+### Visual Validation (Future)
+- Compare generated plots against reference images
+- Verify color mapping accuracy
+- Test plot appearance across different matplotlib backends
+
+---
+
+**Estimated Time**: 2 hours  
+**Dependencies**: Base plotting classes, matplotlib integration  
+**Priority**: HIGH (Core plotting functionality)
+**Status**: ✅ COMPLETED
+**Commit**: 61823b7
+**Tests Added**: 51 comprehensive test cases
+**Time Invested**: 1.5 hours
+**Test Results**: 51/51 passing (100% success rate)

plans/completed/combined_test_plan_with_checklist_plotting/5-spiral.py.md

@@ -0,0 +1,216 @@
+---
+name: 'Combined Plan and Checklist: Spiral Mesh Plotting'
+about: Unified documentation and checklist for validating spiral mesh plotting and binning utilities.
+labels: [sweep, plotting, SpiralMesh, spiral plots, numba]
+---
+
+> Phase 5 of Enhanced Plotting Test Plan
+
+## 🧠 Context
+
+The `solarwindpy.plotting.spiral` module provides sophisticated spiral mesh plotting capabilities with specialized binning utilities. This module includes high-performance numba-accelerated functions for spatial binning and data aggregation within spiral-shaped mesh geometries, commonly used for plasma physics data visualization.
+
+### Key Components
+- **Spiral Mesh Classes**: Complex spiral geometry plotting
+- **Numba Functions**: High-performance spatial binning utilities
+- **Named Tuples**: Structured data containers for spiral parameters
+- **Filtering Utilities**: Data density and size-based filtering
+
+### Performance Features
+- **Numba JIT Compilation**: `@njit(parallel=True)` for performance-critical operations
+- **Parallel Processing**: Multi-threaded binning calculations
+- **Memory Optimization**: Efficient data structures for large datasets
+
+### Dependencies
+- Uses `base` plotting infrastructure
+- Integrates with `labels` module
+- Requires numba, numpy, pandas, matplotlib
+
+## 📋 Comprehensive Test Checklist
+
+### 5.1 Module Structure and Imports
+
+- [ ] **Import verification**: All required imports load correctly
+- [ ] **Numba availability**: Verify numba decorators work in test environment
+- [ ] **Base integration**: Confirm `from . import base` import functions
+- [ ] **Labels integration**: Verify `from . import labels as labels_module` works
+
+### 5.2 Named Tuple Definitions
+
+#### `InitialSpiralEdges`
+- [ ] **Structure validation**: Contains `x,y` fields as expected
+- [ ] **Data type handling**: Accepts appropriate numeric data types
+- [ ] **Immutability**: Tuple immutability preserved
+
+#### `SpiralMeshBinID`  
+- [ ] **Structure validation**: Contains `id,fill,visited` fields
+- [ ] **Field access**: All fields accessible and correctly typed
+- [ ] **Default handling**: Proper handling of field defaults
+
+#### `SpiralFilterThresholds`
+- [ ] **Structure validation**: Contains `density,size` fields with defaults
+- [ ] **Default values**: `defaults=(False,)` applied correctly
+- [ ] **Parameter validation**: Accepts valid threshold parameters
+
+### 5.3 Numba-Accelerated Functions
+
+#### `get_counts_per_bin()` function
+- [ ] **JIT compilation**: `@njit(parallel=True)` decorator works correctly
+- [ ] **Parallel execution**: Multi-threaded processing functions properly
+- [ ] **Input validation**: Handles bins, x, y arrays of correct shapes
+- [ ] **Bin counting**: Accurately counts points within bin boundaries
+- [ ] **Output format**: Returns numpy array with correct dtype (int64)
+- [ ] **Edge case handling**: Proper behavior at bin boundaries
+- [ ] **Empty bins**: Correctly handles bins with zero counts
+- [ ] **Performance**: Executes efficiently for large datasets
+
+#### `calculate_bin_number_with_numba()` function  
+- [ ] **JIT compilation**: `@njit(parallel=True)` decorator functions
+- [ ] **Fill value**: Uses correct fill value (-9999) for unassigned points
+- [ ] **Mesh integration**: Properly utilizes mesh parameter for binning
+- [ ] **Output array**: Returns correctly sized and typed array
+- [ ] **Point assignment**: Accurately assigns points to bin numbers
+- [ ] **Boundary handling**: Proper behavior at mesh boundaries
+- [ ] **Invalid points**: Correctly handles points outside mesh
+
+### 5.4 Spiral Mesh Classes (if present)
+
+#### Main spiral mesh class
+- [ ] **Initialization**: Proper class initialization with spiral parameters
+- [ ] **Mesh generation**: Generates valid spiral mesh geometries
+- [ ] **Data integration**: Integrates with pandas DataFrames
+- [ ] **Plotting methods**: Creates appropriate matplotlib visualizations
+- [ ] **Parameter validation**: Validates spiral geometry parameters
+
+### 5.5 Data Binning and Aggregation
+
+#### Spatial binning functionality
+- [ ] **Point-in-bin detection**: Accurate spatial containment testing
+- [ ] **Bin boundary handling**: Consistent treatment of boundary points
+- [ ] **Multi-dimensional data**: Handles x, y coordinate pairs correctly
+- [ ] **Large dataset performance**: Efficient processing of large point sets
+- [ ] **Memory management**: Optimal memory usage during binning
+
+#### Data aggregation
+- [ ] **Count aggregation**: Accurate counting of points per bin
+- [ ] **Statistical aggregation**: Support for mean, median, etc. if implemented
+- [ ] **Custom aggregation**: Extensible aggregation function support
+- [ ] **Missing data**: Proper handling of NaN and missing values
+
+### 5.6 Filtering and Thresholding
+
+#### Density filtering
+- [ ] **Threshold application**: Density thresholds applied correctly
+- [ ] **Filter logic**: Proper boolean logic for include/exclude decisions
+- [ ] **Performance impact**: Filtering doesn't significantly slow processing
+
+#### Size filtering  
+- [ ] **Size threshold**: Bin size thresholds work as expected
+- [ ] **Combined filters**: Multiple filter criteria work together
+- [ ] **Filter validation**: Invalid filter parameters rejected
+
+### 5.7 Integration with Base Classes
+
+#### Base plotting integration
+- [ ] **Inheritance structure**: Proper inheritance from base plotting classes
+- [ ] **Method compatibility**: Base class methods work with spiral data
+- [ ] **Axis formatting**: Spiral plots format axes correctly
+- [ ] **Label integration**: Labels work with spiral geometries
+
+### 5.8 Performance and Scalability
+
+#### Numba performance
+- [ ] **Compilation overhead**: JIT compilation time reasonable
+- [ ] **Runtime performance**: Significant speedup over pure Python
+- [ ] **Memory efficiency**: Optimal memory usage in compiled functions
+- [ ] **Parallel scaling**: Performance improves with multiple cores
+
+#### Large dataset handling
+- [ ] **Memory usage**: Efficient memory usage for large datasets
+- [ ] **Processing time**: Reasonable processing times for large data
+- [ ] **Stability**: No memory leaks or crashes with large datasets
+
+### 5.9 Error Handling and Validation
+
+#### Input validation
+- [ ] **Array shape validation**: Correct handling of mismatched array shapes
+- [ ] **Data type validation**: Proper handling of invalid data types
+- [ ] **Missing data**: Graceful handling of NaN and infinite values
+- [ ] **Empty data**: Appropriate behavior with empty input arrays
+
+#### Error conditions
+- [ ] **Numba error handling**: Proper error propagation from numba functions
+- [ ] **Memory errors**: Graceful handling of memory allocation failures
+- [ ] **Invalid parameters**: Clear error messages for invalid parameters
+
+### 5.10 Matplotlib Integration
+
+#### Plot generation
+- [ ] **Spiral visualization**: Generates visually correct spiral plots
+- [ ] **Color mapping**: Color maps data correctly across spiral bins
+- [ ] **Axis integration**: Integrates properly with matplotlib axes
+- [ ] **Collection objects**: Returns valid matplotlib collection objects
+
+#### Visual quality
+- [ ] **Mesh rendering**: Spiral mesh renders clearly and accurately
+- [ ] **Data representation**: Data values represented correctly in visualization
+- [ ] **Scale handling**: Handles different data scales appropriately
+
+### 5.11 Documentation and Examples
+
+- [ ] **Module docstring**: Complete and accurate module documentation
+- [ ] **Function docstrings**: All functions properly documented
+- [ ] **Parameter documentation**: All parameters clearly described
+- [ ] **Performance notes**: Documentation includes performance considerations
+- [ ] **Usage examples**: Working code examples provided
+
+### 5.12 Test Infrastructure
+
+#### Test setup
+- [ ] **Numba test compatibility**: Tests work with numba compilation
+- [ ] **Mock matplotlib**: Mock plotting to avoid GUI interactions
+- [ ] **Performance benchmarks**: Benchmarks for numba function performance
+- [ ] **Memory profiling**: Memory usage testing for large datasets
+
+#### Test data
+- [ ] **Spiral test data**: Representative test datasets for spiral geometries
+- [ ] **Edge case data**: Test data covering boundary conditions
+- [ ] **Performance test data**: Large datasets for performance testing
+
+## 🎯 Testing Strategy
+
+### Unit Testing Approach
+- Test numba functions independently with controlled inputs
+- Verify named tuple structures and field access
+- Test spiral mesh generation and parameter validation
+
+### Performance Testing
+- Benchmark numba-accelerated functions vs pure Python
+- Profile memory usage with large datasets  
+- Test parallel execution scaling
+
+### Integration Testing
+- Test complete spiral plot generation workflow
+- Verify integration with base plotting infrastructure
+- Test data flow from raw coordinates to finished plots
+
+### Numerical Accuracy
+- Verify bin assignment accuracy with known test cases
+- Test boundary condition handling
+- Validate counting and aggregation algorithms
+
+### Edge Case Coverage
+- Empty datasets, single points, extreme coordinates
+- Invalid spiral parameters
+- Large dataset stress testing
+
+---
+
+**Estimated Time**: 2.5 hours  
+**Dependencies**: Numba, base plotting classes, numpy/pandas  
+**Priority**: HIGH (Performance-critical plotting component)
+**Status**: ✅ COMPLETED
+**Commit**: b609a20
+**Tests Added**: 36 comprehensive test cases
+**Time Invested**: 2 hours
+**Test Results**: 36/36 passing (100% success rate)

plans/completed/combined_test_plan_with_checklist_plotting/6-orbits.py.md

@@ -0,0 +1,108 @@
+---
+name: 'Combined Plan and Checklist: Orbit Plotting'
+about: Unified documentation and checklist for orbit plotting features.
+labels: [sweep, plotting, OrbitPlot]
+---
+
+> Extracted from solarwindpy/plans/combined_test_plan_with_checklist_plotting.md
+
+## 🧠 Context
+
+The `solarwindpy.plotting` subpackage offers high-level plotting utilities built on pandas
+and Matplotlib. This unified plan combines the narrative test rationale and the
+actionable checklist for validating every class, method, property (including non-public
+interfaces), and helper function across:
+
+- `base.py`
+- `agg_plot.py`
+- `histograms.py` (`hist1d.py`, `hist2d.py`)
+- `scatter.py`
+- `spiral.py`
+- `orbits.py`
+- `tools.py`
+- `select_data_from_figure.py`
+- `labels/base.py`
+- `labels/special.py`
+
+Tests are grouped by module. Each module section includes context from the original
+narrative plan followed by a deduplicated checklist of actionable items.
+
+### Class `OrbitPlot(ABC)`
+
+- `__init__(orbit, *args)` validates `orbit` type; invalid types raise
+  `TypeError`.
+- Properties: `_disable_both`, `orbit`, `_orbit_key`, `grouped`.
+- `set_path(*args, orbit=…)` appends orbit path.
+- `set_orbit(new)` sorts orbits and validates type.
+- `make_cut()` adds “Inbound”/“Outbound” (and “Both”) categories.
+
+### Class `OrbitHist1D(OrbitPlot, Hist1D)`
+
+- `_format_axis(ax)` adds legend.
+- `agg(**kwargs)` merges “Both” leg; disabled via `_disable_both`.
+- `make_plot(ax, fcn, **kwargs)` calls `tools.subplots` and plots each leg.
+
+### Class `OrbitHist2D(OrbitPlot, Hist2D)`
+
+- `_format_in_out_axes(inbound, outbound)`, `_prune_lower_yaxis_ticks`, and
+  `_format_in_out_both_axes` manage axis formatting.
+- `agg(**kwargs)` wraps and normalizes per-orbit.
+- `project_1d(axis, project_counts, **kwargs)` returns an `OrbitHist1D`
+  instance.
+
+## 🎯 Overview of the Task
+
+Implement comprehensive tests for `orbits.py` within the `solarwindpy.plotting` package.
+
+## 🔧 Framework & Dependencies
+
+- pandas
+- matplotlib
+- pytest
+
+## 📂 Affected Files and Paths
+
+- solarwindpy/plotting/orbits.py
+
+## 📊 Figures, Diagrams, or Artifacts (Optional)
+
+None
+
+## ✅ Acceptance Criteria
+
+- [ ] Verify invalid `orbit` type in `__init__` raises `TypeError`
+- [ ] Verify `_disable_both` property is `True` by default
+- [ ] Verify `.orbit` property returns the `IntervalIndex`
+- [ ] Verify `_orbit_key` returns `"Orbit"`
+- [ ] Verify `.grouped` groups by `_gb_axes` + `_orbit_key`
+- [ ] Test `set_path(…, orbit=idx)` appends `orbit.path`
+- [ ] Test `set_orbit(idx)` sorts and validates type
+- [ ] Test `make_cut()` adds “Inbound”/“Outbound” (and “Both”) categories
+- [ ] Verify `_format_axis(ax)` adds a legend
+- [ ] Test `agg()` merges “Both” leg when `_disable_both=False`
+- [ ] Test `make_plot(ax)` plots each orbit leg via `tools.subplots()`
+- [ ] Test `_format_in_out_axes()` swaps x-limits and colors spines
+- [ ] Test `_prune_lower_yaxis_ticks()` prunes ticks correctly
+- [ ] Test `_format_in_out_both_axes()` aligns y-limits across
+  inbound/outbound/both
+- [ ] Test `agg()` normalizes per-orbit legs
+- [ ] Test `project_1d('x')` returns a valid `OrbitHist1D`
+
+## 🧩 Decomposition Instructions (Optional)
+
+None
+
+## 🤖 Sweep Agent Instructions (Optional)
+
+None
+
+## 💬 Additional Notes
+
+- Ensures correct functionality, edge-case handling, API stability, and protects
+  non-public internals.
+
+**Status**: ✅ COMPLETED
+**Commit**: e6285c6
+**Tests Added**: 34 comprehensive test cases
+**Time Invested**: 1 hour
+**Test Results**: 34/34 passing (100% success rate)

plans/completed/combined_test_plan_with_checklist_plotting/7-tools.py.md

@@ -0,0 +1,86 @@
+---
+name: 'Combined Plan and Checklist: Plotting Tools'
+about: Unified documentation and checklist for helper tools used in plotting.
+labels: [sweep, plotting, utils]
+---
+
+> Extracted from solarwindpy/plans/combined_test_plan_with_checklist_plotting.md
+
+## 🧠 Context
+
+The `solarwindpy.plotting` subpackage offers high-level plotting utilities built on pandas
+and Matplotlib. This unified plan combines the narrative test rationale and the
+actionable checklist for validating every class, method, property (including non-public
+interfaces), and helper function across:
+
+- `base.py`
+- `agg_plot.py`
+- `histograms.py` (`hist1d.py`, `hist2d.py`)
+- `scatter.py`
+- `spiral.py`
+- `orbits.py`
+- `tools.py`
+- `select_data_from_figure.py`
+- `labels/base.py`
+- `labels/special.py`
+
+Tests are grouped by module. Each module section includes context from the original
+narrative plan followed by a deduplicated checklist of actionable items.
+
+- `subplots(nrows, ncols, scale_width, scale_height, **kwargs)` scales figure
+  size with grid shape.
+- `save(fig, spath, add_info, log, pdf, png, **kwargs)` writes `.pdf` and `.png`
+  files, adds timestamp text, and supports optional logging.
+- `joint_legend(*axes, idx_for_legend, **kwargs)` merges legend entries without
+  duplicates and sorts them.
+- `multipanel_figure_shared_cbar(...)` (if present) creates grid with shared
+  colorbar.
+
+## 🎯 Overview of the Task
+
+Implement comprehensive tests for `tools.py` within the `solarwindpy.plotting` package.
+
+## 🔧 Framework & Dependencies
+
+- pandas
+- matplotlib
+- pytest
+
+## 📂 Affected Files and Paths
+
+- solarwindpy/plotting/tools.py
+
+## 📊 Figures, Diagrams, or Artifacts (Optional)
+
+None
+
+## ✅ Acceptance Criteria
+
+- [ ] Test `subplots(2,2,scale_width=1.5,scale_height=0.5)` returns 2×2 axes with
+  correct figsize
+- [ ] Test `save(fig, path, pdf=True,png=True)` writes both `.pdf` and `.png`
+  files
+- [ ] Test PNG version includes timestamp text
+- [ ] Test `save(..., log=False)` skips logging calls
+- [ ] Test `joint_legend(ax1,ax2)` merges legend entries, no duplicates, sorted
+- [ ] (If present) Test `multipanel_figure_shared_cbar(...)` arranges shared
+  colorbar correctly
+
+## 🧩 Decomposition Instructions (Optional)
+
+None
+
+## 🤖 Sweep Agent Instructions (Optional)
+
+None
+
+## 💬 Additional Notes
+
+- Ensures correct functionality, edge-case handling, API stability, and protects
+  non-public internals.
+
+**Status**: ✅ COMPLETED
+**Commit**: fe1e348
+**Tests Added**: 42 comprehensive test cases (41 passing, 1 skipped)
+**Time Invested**: 1 hour
+**Test Results**: 41/42 passing (97.6% success rate)

plans/completed/combined_test_plan_with_checklist_plotting/8-select_data_from_figure.py.md

@@ -0,0 +1,97 @@
+---
+name: 'Combined Plan and Checklist: Select Data From Figure'
+about: Unified documentation and checklist for selecting data from interactive figures.
+labels: [sweep, plotting]
+---
+
+> Extracted from solarwindpy/plans/combined_test_plan_with_checklist_plotting.md
+
+## 🧠 Context
+
+The `solarwindpy.plotting` subpackage offers high-level plotting utilities built on pandas
+and Matplotlib. This unified plan combines the narrative test rationale and the
+actionable checklist for validating every class, method, property (including non-public
+interfaces), and helper function across:
+
+- `base.py`
+- `agg_plot.py`
+- `histograms.py` (`hist1d.py`, `hist2d.py`)
+- `scatter.py`
+- `spiral.py`
+- `orbits.py`
+- `tools.py`
+- `select_data_from_figure.py`
+- `labels/base.py`
+- `labels/special.py`
+
+Tests are grouped by module. Each module section includes context from the original
+narrative plan followed by a deduplicated checklist of actionable items.
+
+### Class `SelectFromPlot2D`
+
+- `__init__(plotter, ax, has_colorbar, xdate, ydate, text_kwargs)`.
+- Properties: `ax`, `corners`, `date_axes`, `is_multipanel`, `selector`, `text`,
+  and more.
+- `_init_corners`, `_add_corners`, `_finalize_text`, `_update_text` manage
+  corner selection and text updates.
+- `disconnect(other, scatter_kwargs, **kwargs)` calls `sample_data`,
+  `scatter_sample`, and `plot_failed_samples`.
+- `onselect(press, release)` adds patch, updates corners and text.
+- `set_ax(ax, has_colorbar)`, `start_text`, `start_selector`, `sample_data(n, random_state)`; `sample_data(frac=…)` raises `NotImplementedError`.
+
+## 🎯 Overview of the Task
+
+Implement comprehensive tests for `select_data_from_figure.py` within the `solarwindpy.plotting` package.
+
+## 🔧 Framework & Dependencies
+
+- pandas
+- matplotlib
+- pytest
+
+## 📂 Affected Files and Paths
+
+- solarwindpy/plotting/select_data_from_figure.py
+
+## 📊 Figures, Diagrams, or Artifacts (Optional)
+
+None
+
+## ✅ Acceptance Criteria
+
+- [x] Test `__init__(plotter,ax)` initializes selector and text objects
+- [x] Verify `.ax`, `.corners`, `.date_axes`, `.is_multipanel` props
+- [x] Verify `.selector` property exposes selector object
+- [x] Verify `.text` property exposes text annotation
+- [x] Test `_init_corners()` initializes corner coordinates
+- [x] Test `_add_corners()` appends new corner tuples
+- [x] Test `_finalize_text()` formats final selection text
+- [x] Test `_update_text()` formats bounding-box extents
+- [x] Test `onselect(press,release)` adds rectangle patch and updates
+  corners/text
+- [x] Test `disconnect()` calls `sample_data()`, `scatter_sample()`,
+  `plot_failed_samples()`, disconnects events
+- [x] Test `set_ax(ax, has_colorbar)` updates axis and colorbar state
+- [x] Test `start_text()` initializes the annotation text object
+- [x] Test `start_selector()` starts selection widget
+- [x] Test `sample_data(n=3,random_state=…)` returns correct sampled indices
+- [x] Verify `sample_data(frac=0.1)` raises `NotImplementedError`
+
+## 🧩 Decomposition Instructions (Optional)
+
+None
+
+## 🤖 Sweep Agent Instructions (Optional)
+
+None
+
+## 💬 Additional Notes
+
+- Ensures correct functionality, edge-case handling, API stability, and protects
+  non-public internals.
+
+**Status**: ✅ COMPLETED
+**Commit**: 5b47880
+**Tests Added**: 51 comprehensive test cases
+**Time Invested**: 1 hour
+**Test Results**: 51/51 passing (100% success rate)