lighthouse 12.8.2-dev.20251005 → 12.8.2-dev.20251007

package/core/audits/prioritize-lcp-image.js

@@ -1,297 +0,0 @@
-/**
- * @license
- * Copyright 2020 Google LLC
- * SPDX-License-Identifier: Apache-2.0
- */
-
-import {Audit} from './audit.js';
-import * as i18n from '../lib/i18n/i18n.js';
-import {NetworkRequest} from '../lib/network-request.js';
-import {MainResource} from '../computed/main-resource.js';
-import {LanternLargestContentfulPaint} from '../computed/metrics/lantern-largest-contentful-paint.js';
-import {LoadSimulator} from '../computed/load-simulator.js';
-import {LCPImageRecord} from '../computed/lcp-image-record.js';
-
-const UIStrings = {
-  /** Title of a lighthouse audit that tells a user to preload an image in order to improve their LCP time. */
-  title: 'Preload Largest Contentful Paint image',
-  /** Description of a lighthouse audit that tells a user to preload an image in order to improve their LCP time.  */
-  description: 'If the LCP element is dynamically added to the page, you should preload the ' +
-    'image in order to improve LCP. [Learn more about preloading LCP elements](https://web.dev/articles/optimize-lcp#optimize_when_the_resource_is_discovered).',
-};
-
-const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
-
-/**
- * @typedef {LH.Crdp.Network.Initiator['type']|'redirect'|'fallbackToMain'} InitiatorType
- * @typedef {Array<{url: string, initiatorType: InitiatorType}>} InitiatorPath
- */
-
-class PrioritizeLcpImage extends Audit {
-  /**
-   * @return {LH.Audit.Meta}
-   */
-  static get meta() {
-    return {
-      id: 'prioritize-lcp-image',
-      title: str_(UIStrings.title),
-      description: str_(UIStrings.description),
-      supportedModes: ['navigation'],
-      guidanceLevel: 4,
-      requiredArtifacts: ['Trace', 'DevtoolsLog', 'GatherContext', 'URL', 'TraceElements',
-        'SourceMaps'],
-      scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
-    };
-  }
-
-  /**
-   *
-   * @param {LH.Artifacts.NetworkRequest} request
-   * @param {LH.Artifacts.NetworkRequest} mainResource
-   * @param {InitiatorPath} initiatorPath
-   * @return {boolean}
-   */
-  static shouldPreloadRequest(request, mainResource, initiatorPath) {
-    // If it's already preloaded, no need to recommend it.
-    if (request.isLinkPreload) return false;
-    // It's not a request loaded over the network, don't recommend it.
-    if (NetworkRequest.isNonNetworkRequest(request)) return false;
-    // It's already discoverable from the main document (a path of [lcpRecord, mainResource]), don't recommend it.
-    if (initiatorPath.length <= 2) return false;
-    // Finally, return whether or not it belongs to the main frame
-    return request.frameId === mainResource.frameId;
-  }
-
-  /**
-   * @param {LH.Gatherer.Simulation.GraphNode} graph
-   * @param {NetworkRequest} lcpRecord
-   * @return {LH.Gatherer.Simulation.GraphNetworkNode|undefined}
-   */
-  static findLCPNode(graph, lcpRecord) {
-    for (const {node} of graph.traverseGenerator()) {
-      if (node.type !== 'network') continue;
-      if (node.request.requestId === lcpRecord.requestId) {
-        return node;
-      }
-    }
-  }
-
-  /**
-   * Get the initiator path starting with lcpRecord back to mainResource, inclusive.
-   * Navigation redirects *to* the mainResource are not included.
-   * Path returned will always be at least [lcpRecord, mainResource].
-   * @param {NetworkRequest} lcpRecord
-   * @param {NetworkRequest} mainResource
-   * @return {InitiatorPath}
-   */
-  static getLcpInitiatorPath(lcpRecord, mainResource) {
-    /** @type {InitiatorPath} */
-    const initiatorPath = [];
-    let mainResourceReached = false;
-    /** @type {NetworkRequest|undefined} */
-    let request = lcpRecord;
-
-    while (request) {
-      mainResourceReached ||= request.requestId === mainResource.requestId;
-
-      /** @type {InitiatorType} */
-      let initiatorType = request.initiator?.type ?? 'other';
-      // Initiator type usually comes from redirect, but 'redirect' is used for more informative debugData.
-      if (request.initiatorRequest && request.initiatorRequest === request.redirectSource) {
-        initiatorType = 'redirect';
-      }
-      // Sometimes the initiator chain is broken and the best that can be done is stitch
-      // back to the main resource. Note this in the initiatorType.
-      if (!request.initiatorRequest && !mainResourceReached) {
-        initiatorType = 'fallbackToMain';
-      }
-
-      initiatorPath.push({url: request.url, initiatorType});
-
-      // Can't preload before the main resource, so break off initiator path there.
-      if (mainResourceReached) break;
-
-      // Continue up chain, falling back to mainResource if chain is broken.
-      request = request.initiatorRequest || mainResource;
-    }
-
-    return initiatorPath;
-  }
-
-  /**
-   * @param {LH.Artifacts.NetworkRequest} mainResource
-   * @param {LH.Gatherer.Simulation.GraphNode} graph
-   * @param {NetworkRequest|undefined} lcpRecord
-   * @return {{lcpNodeToPreload?: LH.Gatherer.Simulation.GraphNetworkNode, initiatorPath?: InitiatorPath}}
-   */
-  static getLCPNodeToPreload(mainResource, graph, lcpRecord) {
-    if (!lcpRecord) return {};
-    const lcpNode = PrioritizeLcpImage.findLCPNode(graph, lcpRecord);
-    const initiatorPath = PrioritizeLcpImage.getLcpInitiatorPath(lcpRecord, mainResource);
-    if (!lcpNode) return {initiatorPath};
-
-    // eslint-disable-next-line max-len
-    const shouldPreload = PrioritizeLcpImage.shouldPreloadRequest(lcpRecord, mainResource, initiatorPath);
-    const lcpNodeToPreload = shouldPreload ? lcpNode : undefined;
-
-    return {
-      lcpNodeToPreload,
-      initiatorPath,
-    };
-  }
-
-  /**
-   * Computes the estimated effect of preloading the LCP image.
-   * @param {LH.Artifacts.TraceElement} lcpElement
-   * @param {LH.Gatherer.Simulation.GraphNetworkNode|undefined} lcpNode
-   * @param {LH.Gatherer.Simulation.GraphNode} graph
-   * @param {LH.Gatherer.Simulation.Simulator} simulator
-   * @return {{wastedMs: number, results: Array<{node: LH.Audit.Details.NodeValue, url: string, wastedMs: number}>}}
-   */
-  static computeWasteWithGraph(lcpElement, lcpNode, graph, simulator) {
-    if (!lcpNode) {
-      return {
-        wastedMs: 0,
-        results: [],
-      };
-    }
-
-    const modifiedGraph = graph.cloneWithRelationships();
-
-    // Store the IDs of the LCP Node's dependencies for later
-    /** @type {Set<string>} */
-    const dependenciesIds = new Set();
-    for (const node of lcpNode.getDependencies()) {
-      dependenciesIds.add(node.id);
-    }
-
-    /** @type {LH.Gatherer.Simulation.GraphNode|null} */
-    let modifiedLCPNode = null;
-    /** @type {LH.Gatherer.Simulation.GraphNode|null} */
-    let mainDocumentNode = null;
-
-    for (const {node} of modifiedGraph.traverseGenerator()) {
-      if (node.type !== 'network') continue;
-
-      if (node.isMainDocument()) {
-        mainDocumentNode = node;
-      } else if (node.id === lcpNode.id) {
-        modifiedLCPNode = node;
-      }
-    }
-
-    if (!mainDocumentNode) {
-      // Should always find the main document node
-      throw new Error('Could not find main document node');
-    }
-
-    if (!modifiedLCPNode) {
-      // Should always find the LCP node as well or else this function wouldn't have been called
-      throw new Error('Could not find the LCP node');
-    }
-
-    // Preload will request the resource as soon as its discovered in the main document.
-    // Reflect this change in the dependencies in our modified graph.
-    modifiedLCPNode.removeAllDependencies();
-    modifiedLCPNode.addDependency(mainDocumentNode);
-
-    const simulationBeforeChanges = simulator.simulate(graph);
-    const simulationAfterChanges = simulator.simulate(modifiedGraph);
-    const lcpTimingsBefore = simulationBeforeChanges.nodeTimings.get(lcpNode);
-    if (!lcpTimingsBefore) throw new Error('Impossible - node timings should never be undefined');
-    const lcpTimingsAfter = simulationAfterChanges.nodeTimings.get(modifiedLCPNode);
-    if (!lcpTimingsAfter) throw new Error('Impossible - node timings should never be undefined');
-    /** @type {Map<String, LH.Gatherer.Simulation.GraphNode>} */
-    const modifiedNodesById = Array.from(simulationAfterChanges.nodeTimings.keys())
-      .reduce((map, node) => map.set(node.id, node), new Map());
-
-    // Even with preload, the image can't be painted before it's even inserted into the DOM.
-    // New LCP time will be the max of image download and image in DOM (endTime of its deps).
-    let maxDependencyEndTime = 0;
-    for (const nodeId of Array.from(dependenciesIds)) {
-      const node = modifiedNodesById.get(nodeId);
-      if (!node) throw new Error('Impossible - node should never be undefined');
-      const timings = simulationAfterChanges.nodeTimings.get(node);
-      const endTime = timings?.endTime || 0;
-      maxDependencyEndTime = Math.max(maxDependencyEndTime, endTime);
-    }
-
-    const wastedMs = lcpTimingsBefore.endTime -
-      Math.max(lcpTimingsAfter.endTime, maxDependencyEndTime);
-
-    return {
-      wastedMs,
-      results: [{
-        node: Audit.makeNodeItem(lcpElement.node),
-        url: lcpNode.request.url,
-        wastedMs,
-      }],
-    };
-  }
-
-  /**
-   * @param {LH.Artifacts} artifacts
-   * @param {LH.Audit.Context} context
-   * @return {Promise<LH.Audit.Product>}
-   */
-  static async audit(artifacts, context) {
-    const gatherContext = artifacts.GatherContext;
-    const trace = artifacts.Trace;
-    const devtoolsLog = artifacts.DevtoolsLog;
-    const {URL, SourceMaps} = artifacts;
-    const settings = context.settings;
-    const metricData =
-      {trace, devtoolsLog, gatherContext, settings, URL, SourceMaps, simulator: null};
-    const lcpElement = artifacts.TraceElements
-      .find(element => element.traceEventType === 'largest-contentful-paint');
-
-    if (!lcpElement || lcpElement.type !== 'image') {
-      return {score: null, notApplicable: true, metricSavings: {LCP: 0}};
-    }
-
-    const mainResource = await MainResource.request({devtoolsLog, URL}, context);
-    const lanternLCP = await LanternLargestContentfulPaint.request(metricData, context);
-    const simulator = await LoadSimulator.request({devtoolsLog, settings}, context);
-
-    const lcpImageRecord = await LCPImageRecord.request({trace, devtoolsLog}, context);
-    const graph = lanternLCP.pessimisticGraph;
-    // Note: if moving to LCPAllFrames, mainResource would need to be the LCP frame's main resource.
-    const {lcpNodeToPreload, initiatorPath} = PrioritizeLcpImage.getLCPNodeToPreload(mainResource,
-        graph, lcpImageRecord);
-
-    const {results, wastedMs} =
-      PrioritizeLcpImage.computeWasteWithGraph(lcpElement, lcpNodeToPreload, graph, simulator);
-
-    /** @type {LH.Audit.Details.Opportunity['headings']} */
-    const headings = [
-      {key: 'node', valueType: 'node', label: ''},
-      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
-      {key: 'wastedMs', valueType: 'timespanMs', label: str_(i18n.UIStrings.columnWastedMs)},
-    ];
-    const details = Audit.makeOpportunityDetails(headings, results,
-      {overallSavingsMs: wastedMs, sortedBy: ['wastedMs']});
-
-    // If LCP element was an image and had valid network records (regardless of
-    // if it should be preloaded), it will be found first in the `initiatorPath`.
-    // Otherwise path and length will be undefined.
-    if (initiatorPath) {
-      details.debugData = {
-        type: 'debugdata',
-        initiatorPath,
-        pathLength: initiatorPath.length,
-      };
-    }
-
-    return {
-      score: results.length ? 0 : 1,
-      numericValue: wastedMs,
-      numericUnit: 'millisecond',
-      displayValue: wastedMs ? str_(i18n.UIStrings.displayValueMsSavings, {wastedMs}) : '',
-      details,
-      metricSavings: {LCP: wastedMs},
-    };
-  }
-}
-
-export default PrioritizeLcpImage;
-export {UIStrings};

package/core/audits/third-party-summary.d.ts

@@ -1,78 +0,0 @@
-export default ThirdPartySummary;
-export type Summary = {
-    mainThreadTime: number;
-    transferSize: number;
-    blockingTime: number;
-    tbtImpact: number;
-};
-export type URLSummary = {
-    transferSize: number;
-    blockingTime: number;
-    tbtImpact: number;
-    url: string | LH.IcuMessage;
-};
-export type SummaryMaps = {
-    /**
-     * Map of impact summaries for each entity.
-     */
-    byEntity: Map<LH.Artifacts.Entity, Summary>;
-    /**
-     * Map of impact summaries for each URL.
-     */
-    byURL: Map<string, Summary>;
-    /**
-     * Map of URLs under each entity.
-     */
-    urls: Map<LH.Artifacts.Entity, string[]>;
-};
-/**
- * @typedef Summary
- * @property {number} mainThreadTime
- * @property {number} transferSize
- * @property {number} blockingTime
- * @property {number} tbtImpact
- */
-/**
- * @typedef URLSummary
- * @property {number} transferSize
- * @property {number} blockingTime
- * @property {number} tbtImpact
- * @property {string | LH.IcuMessage} url
- */
-/** @typedef SummaryMaps
- * @property {Map<LH.Artifacts.Entity, Summary>} byEntity Map of impact summaries for each entity.
- * @property {Map<string, Summary>} byURL Map of impact summaries for each URL.
- * @property {Map<LH.Artifacts.Entity, string[]>} urls Map of URLs under each entity.
- */
-declare class ThirdPartySummary extends Audit {
-    /**
-     *
-     * @param {Array<LH.Artifacts.NetworkRequest>} networkRecords
-     * @param {Array<LH.Artifacts.TBTImpactTask>} tbtImpactTasks
-     * @param {number} cpuMultiplier
-     * @param {LH.Artifacts.EntityClassification} entityClassification
-     * @return {SummaryMaps}
-     */
-    static getSummaries(networkRecords: Array<LH.Artifacts.NetworkRequest>, tbtImpactTasks: Array<LH.Artifacts.TBTImpactTask>, cpuMultiplier: number, entityClassification: LH.Artifacts.EntityClassification): SummaryMaps;
-    /**
-     * @param {LH.Artifacts.Entity} entity
-     * @param {SummaryMaps} summaries
-     * @return {Array<URLSummary>}
-     */
-    static makeSubItems(entity: LH.Artifacts.Entity, summaries: SummaryMaps): Array<URLSummary>;
-    /**
-     * @param {LH.Artifacts} artifacts
-     * @param {LH.Audit.Context} context
-     * @return {Promise<LH.Audit.Product>}
-     */
-    static audit(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Product>;
-}
-export namespace UIStrings {
-    let title: string;
-    let failureTitle: string;
-    let description: string;
-    let columnThirdParty: string;
-    let displayValue: string;
-}
-import { Audit } from './audit.js';
-//# sourceMappingURL=third-party-summary.d.ts.map

package/core/audits/third-party-summary.js

@@ -1,236 +0,0 @@
-/**
- * @license
- * Copyright 2019 Google LLC
- * SPDX-License-Identifier: Apache-2.0
- */
-
-import {Audit} from './audit.js';
-import {EntityClassification} from '../computed/entity-classification.js';
-import * as i18n from '../lib/i18n/i18n.js';
-import {NetworkRecords} from '../computed/network-records.js';
-import {getJavaScriptURLs, getAttributableURLForTask} from '../lib/tracehouse/task-summary.js';
-import {TBTImpactTasks} from '../computed/tbt-impact-tasks.js';
-
-const UIStrings = {
-  /** Title of a diagnostic audit that provides details about the code on a web page that the user doesn't control (referred to as "third-party code"). This descriptive title is shown to users when the amount is acceptable and no user action is required. */
-  title: 'Minimize third-party usage',
-  /** Title of a diagnostic audit that provides details about the code on a web page that the user doesn't control (referred to as "third-party code"). This imperative title is shown to users when there is a significant amount of page execution time caused by third-party code that should be reduced. */
-  failureTitle: 'Reduce the impact of third-party code',
-  /** Description of a Lighthouse audit that identifies the code on the page that the user doesn't control. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
-  description: 'Third-party code can significantly impact load performance. ' +
-    'Limit the number of redundant third-party providers and try to load third-party code after ' +
-    'your page has primarily finished loading. ' +
-    '[Learn how to minimize third-party impact](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/loading-third-party-javascript/).',
-  /** Label for a table column that displays the name of a third-party provider that potentially links to their website. */
-  columnThirdParty: 'Third-Party',
-  /** Summary text for the result of a Lighthouse audit that identifies the code on a web page that the user doesn't control (referred to as "third-party code"). This text summarizes the number of distinct entities that were found on the page. */
-  displayValue: 'Third-party code blocked the main thread for ' +
-    `{timeInMs, number, milliseconds}\xa0ms`,
-};
-
-const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
-
-// A page passes when all third-party code blocks for less than 250 ms.
-const PASS_THRESHOLD_IN_MS = 250;
-
-/**
- * @typedef Summary
- * @property {number} mainThreadTime
- * @property {number} transferSize
- * @property {number} blockingTime
- * @property {number} tbtImpact
- */
-
-/**
- * @typedef URLSummary
- * @property {number} transferSize
- * @property {number} blockingTime
- * @property {number} tbtImpact
- * @property {string | LH.IcuMessage} url
- */
-
-/** @typedef SummaryMaps
- * @property {Map<LH.Artifacts.Entity, Summary>} byEntity Map of impact summaries for each entity.
- * @property {Map<string, Summary>} byURL Map of impact summaries for each URL.
- * @property {Map<LH.Artifacts.Entity, string[]>} urls Map of URLs under each entity.
- */
-
-class ThirdPartySummary extends Audit {
-  /**
-   * @return {LH.Audit.Meta}
-   */
-  static get meta() {
-    return {
-      id: 'third-party-summary',
-      title: str_(UIStrings.title),
-      failureTitle: str_(UIStrings.failureTitle),
-      description: str_(UIStrings.description),
-      guidanceLevel: 1,
-      scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
-      requiredArtifacts: ['Trace', 'DevtoolsLog', 'URL', 'GatherContext', 'SourceMaps'],
-    };
-  }
-
-  /**
-   *
-   * @param {Array<LH.Artifacts.NetworkRequest>} networkRecords
-   * @param {Array<LH.Artifacts.TBTImpactTask>} tbtImpactTasks
-   * @param {number} cpuMultiplier
-   * @param {LH.Artifacts.EntityClassification} entityClassification
-   * @return {SummaryMaps}
-   */
-  static getSummaries(networkRecords, tbtImpactTasks, cpuMultiplier, entityClassification) {
-    /** @type {Map<string, Summary>} */
-    const byURL = new Map();
-    /** @type {Map<LH.Artifacts.Entity, Summary>} */
-    const byEntity = new Map();
-    const defaultSummary = {mainThreadTime: 0, blockingTime: 0, transferSize: 0, tbtImpact: 0};
-
-    for (const request of networkRecords) {
-      const urlSummary = byURL.get(request.url) || {...defaultSummary};
-      urlSummary.transferSize += request.transferSize;
-      byURL.set(request.url, urlSummary);
-    }
-
-    const jsURLs = getJavaScriptURLs(networkRecords);
-
-    for (const task of tbtImpactTasks) {
-      const attributableURL = getAttributableURLForTask(task, jsURLs);
-
-      const urlSummary = byURL.get(attributableURL) || {...defaultSummary};
-      const taskDuration = task.selfTime * cpuMultiplier;
-      // The amount of time spent on main thread is the sum of all durations.
-      urlSummary.mainThreadTime += taskDuration;
-      // Blocking time is the amount of time spent on the main thread *over* 50ms.
-      // This value is interpolated because not all tasks attributed to this URL are at the top level.
-      //
-      // Note that this is not totally equivalent to the TBT definition since it fails to account for
-      // the FCP&TTI bounds of TBT.
-      urlSummary.blockingTime += task.selfBlockingTime;
-      // TBT impact is similar to blocking time, but it accounts for the FCP&TTI bounds of TBT.
-      urlSummary.tbtImpact += task.selfTbtImpact;
-      byURL.set(attributableURL, urlSummary);
-    }
-
-    // Map each URL's stat to a particular entity.
-    /** @type {Map<LH.Artifacts.Entity, string[]>} */
-    const urls = new Map();
-    for (const [url, urlSummary] of byURL.entries()) {
-      const entity = entityClassification.entityByUrl.get(url);
-      if (!entity) {
-        byURL.delete(url);
-        continue;
-      }
-
-      const entitySummary = byEntity.get(entity) || {...defaultSummary};
-      entitySummary.transferSize += urlSummary.transferSize;
-      entitySummary.mainThreadTime += urlSummary.mainThreadTime;
-      entitySummary.blockingTime += urlSummary.blockingTime;
-      entitySummary.tbtImpact += urlSummary.tbtImpact;
-      byEntity.set(entity, entitySummary);
-
-      const entityURLs = urls.get(entity) || [];
-      entityURLs.push(url);
-      urls.set(entity, entityURLs);
-    }
-
-    return {byURL, byEntity, urls};
-  }
-
-  /**
-   * @param {LH.Artifacts.Entity} entity
-   * @param {SummaryMaps} summaries
-   * @return {Array<URLSummary>}
-   */
-  static makeSubItems(entity, summaries) {
-    const entityURLs = summaries.urls.get(entity) || [];
-    const items = entityURLs
-      .map(url => /** @type {URLSummary} */ ({url, ...summaries.byURL.get(url)}))
-      // Sort by blocking time first, then transfer size to break ties.
-      .sort((a, b) => (b.blockingTime - a.blockingTime) || (b.transferSize - a.transferSize));
-
-    return items;
-  }
-
-  /**
-   * @param {LH.Artifacts} artifacts
-   * @param {LH.Audit.Context} context
-   * @return {Promise<LH.Audit.Product>}
-   */
-  static async audit(artifacts, context) {
-    const settings = context.settings || {};
-    const devtoolsLog = artifacts.DevtoolsLog;
-    const networkRecords = await NetworkRecords.request(devtoolsLog, context);
-    const classifiedEntities = await EntityClassification.request(
-      {URL: artifacts.URL, devtoolsLog}, context);
-    const firstPartyEntity = classifiedEntities.firstParty;
-
-    const metricComputationData = Audit.makeMetricComputationDataInput(artifacts, context);
-    const tbtImpactTasks = await TBTImpactTasks.request(metricComputationData, context);
-
-    const multiplier = settings.throttlingMethod === 'simulate' ?
-      settings.throttling.cpuSlowdownMultiplier : 1;
-
-    const summaries = ThirdPartySummary.getSummaries(
-      networkRecords, tbtImpactTasks, multiplier, classifiedEntities);
-    const overallSummary = {wastedBytes: 0, wastedMs: 0, tbtImpact: 0};
-
-    const results = Array.from(summaries.byEntity.entries())
-      // Don't consider the page we're on to be third-party.
-      // e.g. Facebook SDK isn't a third-party script on facebook.com
-      .filter(([entity]) => !(firstPartyEntity && firstPartyEntity === entity))
-      .map(([entity, stats]) => {
-        overallSummary.wastedBytes += stats.transferSize;
-        overallSummary.wastedMs += stats.blockingTime;
-        overallSummary.tbtImpact += stats.tbtImpact;
-
-        return {
-          ...stats,
-          entity: entity.name,
-          subItems: {
-            type: /** @type {const} */ ('subitems'),
-            items: ThirdPartySummary.makeSubItems(entity, summaries),
-          },
-        };
-      })
-      // Sort by blocking time first, then transfer size to break ties.
-      .sort((a, b) => (b.blockingTime - a.blockingTime) || (b.transferSize - a.transferSize));
-
-    /** @type {LH.Audit.Details.Table['headings']} */
-    const headings = [
-      /* eslint-disable max-len */
-      {key: 'entity', valueType: 'text', label: str_(UIStrings.columnThirdParty), subItemsHeading: {key: 'url', valueType: 'url'}},
-      {key: 'transferSize', granularity: 1, valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize), subItemsHeading: {key: 'transferSize'}},
-      {key: 'blockingTime', granularity: 1, valueType: 'ms', label: str_(i18n.UIStrings.columnBlockingTime), subItemsHeading: {key: 'blockingTime'}},
-      /* eslint-enable max-len */
-    ];
-
-    if (!results.length) {
-      return {
-        score: 1,
-        notApplicable: true,
-        metricSavings: {TBT: 0},
-      };
-    }
-
-    const details = Audit.makeTableDetails(headings, results,
-      {...overallSummary, isEntityGrouped: true});
-
-    const passed = overallSummary.wastedMs <= PASS_THRESHOLD_IN_MS;
-
-    return {
-      score: Number(passed),
-      scoreDisplayMode: passed ? Audit.SCORING_MODES.INFORMATIVE : undefined,
-      displayValue: str_(UIStrings.displayValue, {
-        timeInMs: overallSummary.wastedMs,
-      }),
-      details,
-      metricSavings: {
-        TBT: Math.round(overallSummary.tbtImpact),
-      },
-    };
-  }
-}
-
-export default ThirdPartySummary;
-export {UIStrings};

package/core/audits/uses-rel-preconnect.d.ts

@@ -1,37 +0,0 @@
-export default UsesRelPreconnectAudit;
-declare class UsesRelPreconnectAudit extends Audit {
-    /**
-     * Check if record has valid timing
-     * @param {LH.Artifacts.NetworkRequest} record
-     * @return {boolean}
-     */
-    static hasValidTiming(record: LH.Artifacts.NetworkRequest): boolean;
-    /**
-     * Check is the connection is already open
-     * @param {LH.Artifacts.NetworkRequest} record
-     * @return {boolean}
-     */
-    static hasAlreadyConnectedToOrigin(record: LH.Artifacts.NetworkRequest): boolean;
-    /**
-     * Check is the connection has started before the socket idle time
-     * @param {LH.Artifacts.NetworkRequest} record
-     * @param {LH.Artifacts.NetworkRequest} mainResource
-     * @return {boolean}
-     */
-    static socketStartTimeIsBelowThreshold(record: LH.Artifacts.NetworkRequest, mainResource: LH.Artifacts.NetworkRequest): boolean;
-    /**
-     * @param {LH.Artifacts} artifacts
-     * @param {LH.Audit.Context} context
-     * @return {Promise<LH.Audit.Product>}
-     */
-    static audit(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Product>;
-}
-export namespace UIStrings {
-    let title: string;
-    let description: string;
-    let unusedWarning: string;
-    let crossoriginWarning: string;
-    let tooManyPreconnectLinksWarning: string;
-}
-import { Audit } from './audit.js';
-//# sourceMappingURL=uses-rel-preconnect.d.ts.map