lighthouse 12.8.2-dev.20251005 → 12.8.2-dev.20251007

package/core/config/experimental-config.js

@@ -16,32 +16,7 @@ const config = {
     'autocomplete',
   ],
   categories: {
-    // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
-    // config is awkward - easier to omit the property here. Will defer to default config.
-    'performance': {
-      auditRefs: [
-        // TODO: Remove this when insights aren't hidden by default
-        // Insight audits.
-        {id: 'cache-insight', weight: 0, group: 'insights'},
-        {id: 'cls-culprits-insight', weight: 0, group: 'insights'},
-        {id: 'document-latency-insight', weight: 0, group: 'insights'},
-        {id: 'dom-size-insight', weight: 0, group: 'insights'},
-        {id: 'duplicated-javascript-insight', weight: 0, group: 'insights'},
-        {id: 'font-display-insight', weight: 0, group: 'insights'},
-        {id: 'forced-reflow-insight', weight: 0, group: 'insights'},
-        {id: 'image-delivery-insight', weight: 0, group: 'insights'},
-        {id: 'inp-breakdown-insight', weight: 0, group: 'insights'},
-        {id: 'lcp-breakdown-insight', weight: 0, group: 'insights'},
-        {id: 'lcp-discovery-insight', weight: 0, group: 'insights'},
-        {id: 'legacy-javascript-insight', weight: 0, group: 'insights'},
-        {id: 'modern-http-insight', weight: 0, group: 'insights'},
-        {id: 'network-dependency-tree-insight', weight: 0, group: 'insights'},
-        {id: 'render-blocking-insight', weight: 0, group: 'insights'},
-        {id: 'third-parties-insight', weight: 0, group: 'insights'},
-        {id: 'viewport-insight', weight: 0, group: 'insights'},
-      ],
-    },
-    // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
+    // @ts-expect-error: `title` is required in CategoryJson. setting to the same value as the default
     // config is awkward - easier to omit the property here. Will defer to default config.
     'best-practices': {
       auditRefs: [

package/core/config/filters.js

@@ -4,8 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import log from 'lighthouse-logger';
-
 import {Audit} from '../audits/audit.js';
 
 /** @type {Record<keyof LH.BaseArtifacts, string>} */
@@ -176,20 +174,19 @@ function filterCategoriesByExplicitFilters(categories, onlyCategories) {
 }
 
 /**
- * Logs a warning if any specified onlyCategory is not a known category that can
+ * Throw an error if any specified onlyCategory is not a known category that can
  * be included.
  *
  * @param {LH.Config.ResolvedConfig['categories']} allCategories
  * @param {string[] | null} onlyCategories
  * @return {void}
  */
-function warnOnUnknownOnlyCategories(allCategories, onlyCategories) {
+function errorOnUnknownOnlyCategories(allCategories, onlyCategories) {
   if (!onlyCategories) return;
 
-  for (const onlyCategoryId of onlyCategories) {
-    if (!allCategories?.[onlyCategoryId]) {
-      log.warn('config', `unrecognized category in 'onlyCategories': ${onlyCategoryId}`);
-    }
+  const unknown = onlyCategories.filter(c => !allCategories?.[c]);
+  if (unknown.length) {
+    throw new Error(`unrecognized category in 'onlyCategories': ${unknown.join(', ')}`);
   }
 }
 
@@ -271,7 +268,7 @@ function filterConfigByExplicitFilters(resolvedConfig, filters) {
     throw new Error(`onlyCategories cannot be an empty array.`);
   }
 
-  warnOnUnknownOnlyCategories(resolvedConfig.categories, onlyCategories);
+  errorOnUnknownOnlyCategories(resolvedConfig.categories, onlyCategories);
 
   let baseAuditIds = getAuditIdsInCategories(resolvedConfig.categories, undefined);
   if (onlyCategories) {

package/core/config/lr-desktop-config.js

@@ -18,7 +18,6 @@ const config = {
     emulatedUserAgent: constants.userAgents.desktop,
     skipAudits: [
       // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
-      'uses-http2',
       'modern-http-insight',
       // There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
       'bf-cache',

package/core/config/lr-mobile-config.js

@@ -17,7 +17,6 @@ const config = {
     },
     skipAudits: [
       // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
-      'uses-http2',
       'modern-http-insight',
       // There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
       'bf-cache',

package/core/gather/gatherers/anchor-elements.js

@@ -157,33 +157,17 @@ class AnchorElements extends BaseGatherer {
 
     // DOM.getDocument is necessary for pushNodesByBackendIdsToFrontend to properly retrieve nodeIds if the `DOM` domain was enabled before this gatherer, invoke it to be safe.
     await session.sendCommand('DOM.getDocument', {depth: -1, pierce: true});
-    const anchorsWithEventListeners = anchors.map(async anchor => {
-      const listeners = await getEventListeners(session, anchor.node.devtoolsNodePath);
-
-      /** @type {Set<{type: string}>} */
-      const ancestorListeners = new Set();
-      const splitPath = anchor.node.devtoolsNodePath.split(',');
-      const ancestorListenerPromises = [];
-      while (splitPath.length >= 2) {
-        splitPath.length -= 2;
-        const path = splitPath.join(',');
-        const promise = getEventListeners(session, path).then(listeners => {
-          for (const listener of listeners) {
-            ancestorListeners.add(listener);
-          }
-        }).catch(() => {});
-        ancestorListenerPromises.push(promise);
-      }
-
-      await Promise.all(ancestorListenerPromises);
 
-      return {
-        ...anchor,
-        listeners,
-        ancestorListeners: Array.from(ancestorListeners),
-      };
+    const anchorsWithEventListeners = anchors.map( anchor => {
+      return getEventListeners(session, anchor.node.devtoolsNodePath).then(listeners => {
+        return {
+          ...anchor,
+          listeners,
+        };
+      });
     });
 
+
     const result = await Promise.all(anchorsWithEventListeners);
     await session.sendCommand('DOM.disable');
     return result;

package/core/gather/gatherers/inspector-issues.js

@@ -61,34 +61,7 @@ class InspectorIssues extends BaseGatherer {
     const networkRecords = await NetworkRecords.request(devtoolsLog, context);
 
     /** @type {LH.Artifacts.InspectorIssues} */
-    const artifact = {
-      // TODO(v13): remove empty arrays.
-      attributionReportingIssue: [],
-      blockedByResponseIssue: [],
-      bounceTrackingIssue: [],
-      clientHintIssue: [],
-      contentSecurityPolicyIssue: [],
-      cookieDeprecationMetadataIssue: [],
-      corsIssue: [],
-      deprecationIssue: [],
-      federatedAuthRequestIssue: [],
-      genericIssue: [],
-      heavyAdIssue: [],
-      lowTextContrastIssue: [],
-      mixedContentIssue: [],
-      navigatorUserAgentIssue: [],
-      partitioningBlobURLIssue: [],
-      propertyRuleIssue: [],
-      quirksModeIssue: [],
-      cookieIssue: [],
-      elementAccessibilityIssue: [],
-      sharedArrayBufferIssue: [],
-      sharedDictionaryIssue: [],
-      stylesheetLoadingIssue: [],
-      sriMessageSignatureIssue: [],
-      federatedAuthUserInfoRequestIssue: [],
-      userReidentificationIssue: [],
-    };
+    const artifact = {};
 
     for (const issue of this._issues) {
       const detailsKey = /** @type {keyof LH.Crdp.Audits.InspectorIssueDetails} */(

package/core/gather/gatherers/trace-elements.d.ts

@@ -45,15 +45,6 @@ declare class TraceElements extends BaseGatherer {
      * @return {Promise<TraceElementData|undefined>}
      */
     static getResponsivenessElement(trace: LH.Trace, context: LH.Gatherer.Context): Promise<TraceElementData | undefined>;
-    /**
-     * @param {LH.Trace} trace
-     * @param {LH.Gatherer.Context} context
-     * @return {Promise<{nodeId: number, type: string} | undefined>}
-     */
-    static getLcpElement(trace: LH.Trace, context: LH.Gatherer.Context): Promise<{
-        nodeId: number;
-        type: string;
-    } | undefined>;
     /** @type {LH.Gatherer.GathererMeta<'Trace'|'SourceMaps'>} */
     meta: LH.Gatherer.GathererMeta<"Trace" | "SourceMaps">;
     /** @type {Map<string, string>} */

package/core/gather/gatherers/trace-elements.js

@@ -18,8 +18,6 @@ import {pageFunctions} from '../../lib/page-functions.js';
 import {Sentry} from '../../lib/sentry.js';
 import Trace from './trace.js';
 import {ProcessedTrace} from '../../computed/processed-trace.js';
-import {ProcessedNavigation} from '../../computed/processed-navigation.js';
-import {LighthouseError} from '../../lib/lh-error.js';
 import {Responsiveness} from '../../computed/metrics/responsiveness.js';
 import {CumulativeLayoutShift} from '../../computed/metrics/cumulative-layout-shift.js';
 import {ExecutionContext} from '../driver/execution-context.js';
@@ -276,35 +274,6 @@ class TraceElements extends BaseGatherer {
     return animatedElementData;
   }
 
-  /**
-   * @param {LH.Trace} trace
-   * @param {LH.Gatherer.Context} context
-   * @return {Promise<{nodeId: number, type: string} | undefined>}
-   */
-  static async getLcpElement(trace, context) {
-    let processedNavigation;
-    try {
-      processedNavigation = await ProcessedNavigation.request(trace, context);
-    } catch (err) {
-      // If we were running in timespan mode and there was no paint, treat LCP as missing.
-      if (context.gatherMode === 'timespan' && err.code === LighthouseError.errors.NO_FCP.code) {
-        return;
-      }
-
-      throw err;
-    }
-
-    // Use main-frame-only LCP to match the metric value.
-    const lcpData = processedNavigation.largestContentfulPaintEvt?.args?.data;
-    // These should exist, but trace types are loose.
-    if (lcpData?.nodeId === undefined || !lcpData.type) return;
-
-    return {
-      nodeId: lcpData.nodeId,
-      type: lcpData.type,
-    };
-  }
-
   /**
    * @param {LH.Gatherer.Context} context
    */
@@ -372,19 +341,15 @@ class TraceElements extends BaseGatherer {
 
     const traceEngineData = await TraceElements.getTraceEngineElements(
       traceEngineResult, navigationId);
-    const lcpNodeData = await TraceElements.getLcpElement(trace, context);
     const shiftsData = await TraceElements.getTopLayoutShifts(
       trace, traceEngineResult, context);
     const animatedElementData = await this.getAnimatedElements(mainThreadEvents);
-    const responsivenessElementData = await TraceElements.getResponsivenessElement(trace, context);
 
     /** @type {Map<string, TraceElementData[]>} */
     const backendNodeDataMap = new Map([
       ['trace-engine', traceEngineData],
-      ['largest-contentful-paint', lcpNodeData ? [lcpNodeData] : []],
       ['layout-shift', shiftsData],
       ['animation', animatedElementData],
-      ['responsiveness', responsivenessElementData ? [responsivenessElementData] : []],
     ]);
 
     /** @type {Map<number, LH.Crdp.Runtime.CallFunctionOnResponse | null>} */

package/core/lib/network-request.d.ts

@@ -241,13 +241,6 @@ export class NetworkRequest {
      * LR loses protocol information.
      */
     _updateProtocolForLightrider(): void;
-    /**
-     * TODO(compat): remove M116.
-     * `timing.receiveHeadersStart` was added recently, and will be in M116. Until then,
-     * set it to receiveHeadersEnd, which is close enough, to allow consumers of NetworkRequest
-     * to use the new field without accounting for this backcompat.
-     */
-    _backfillReceiveHeaderStartTiming(): void;
     /**
      * LR gets additional, accurate timing information from its underlying fetch infrastructure.  This
      * is passed in via X-Headers similar to 'X-TotalFetchedSize'.

package/core/lib/network-request.js

@@ -286,7 +286,6 @@ class NetworkRequest {
     }
 
     this._updateResponseHeadersEndTimeIfNecessary();
-    this._backfillReceiveHeaderStartTiming();
     this._updateTransferSizeForLightrider();
     this._updateTimingsForLightrider();
   }
@@ -306,7 +305,6 @@ class NetworkRequest {
     this.localizedFailDescription = data.errorText;
 
     this._updateResponseHeadersEndTimeIfNecessary();
-    this._backfillReceiveHeaderStartTiming();
     this._updateTransferSizeForLightrider();
     this._updateTimingsForLightrider();
   }
@@ -329,7 +327,6 @@ class NetworkRequest {
     this.networkEndTime = data.timestamp * 1000;
 
     this._updateResponseHeadersEndTimeIfNecessary();
-    this._backfillReceiveHeaderStartTiming();
   }
 
   /**
@@ -463,19 +460,6 @@ class NetworkRequest {
     }
   }
 
-  /**
-   * TODO(compat): remove M116.
-   * `timing.receiveHeadersStart` was added recently, and will be in M116. Until then,
-   * set it to receiveHeadersEnd, which is close enough, to allow consumers of NetworkRequest
-   * to use the new field without accounting for this backcompat.
-   */
-  _backfillReceiveHeaderStartTiming() {
-    // Do nothing if a value is already present!
-    if (!this.timing || this.timing.receiveHeadersStart !== undefined) return;
-
-    this.timing.receiveHeadersStart = this.timing.receiveHeadersEnd;
-  }
-
   /**
    * LR gets additional, accurate timing information from its underlying fetch infrastructure.  This
    * is passed in via X-Headers similar to 'X-TotalFetchedSize'.

package/core/lib/proto-preprocessor.js

@@ -22,29 +22,12 @@ function processForProto(lhr) {
   /** @type {LH.Result} */
   const reportJson = JSON.parse(JSON.stringify(lhr));
 
-  // Clean up the configSettings
-  // Note: This is not strictly required for conversion if protobuf parsing is set to
-  // 'ignore unknown fields' in the language of conversion.
+  // Drop these fields as we've omitted them from the proto for simplicity
   if (reportJson.configSettings) {
-    // The settings that are in both proto and LHR
-    const {
-      formFactor,
-      locale,
-      onlyCategories,
-      channel,
-      throttling,
-      screenEmulation,
-      throttlingMethod} = reportJson.configSettings;
-
-    // @ts-expect-error - intentionally only a subset of settings.
-    reportJson.configSettings = {
-      formFactor,
-      locale,
-      onlyCategories,
-      channel,
-      throttling,
-      screenEmulation,
-      throttlingMethod};
+    // @ts-expect-error Removing non-optional field.
+    delete reportJson.configSettings.auditMode;
+    // @ts-expect-error Removing non-optional field.
+    delete reportJson.configSettings.gatherMode;
   }
 
   // Remove runtimeError if it is NO_ERROR