chrome-devtools-frontend 1.0.1367881 → 1.0.1380117

package/front_end/models/trace/handlers/LayoutShiftsHandler.ts

@@ -10,7 +10,7 @@ import * as Types from '../types/types.js';
 import {data as metaHandlerData} from './MetaHandler.js';
 import {ScoreClassification} from './PageLoadMetricsHandler.js';
 import {data as screenshotsHandlerData} from './ScreenshotsHandler.js';
-import {type HandlerName, HandlerState} from './types.js';
+import type {HandlerName} from './types.js';
 
 // We start with a score of zero and step through all Layout Shift records from
 // all renderers. Each record not only tells us which renderer it is, but also
@@ -46,11 +46,13 @@ interface LayoutShifts {
   // We use these to calculate root causes for a given LayoutShift
   // TODO(crbug/41484172): should be readonly
   prePaintEvents: Types.Events.PrePaint[];
+  paintImageEvents: Types.Events.PaintImage[];
   layoutInvalidationEvents: readonly Types.Events.LayoutInvalidationTracking[];
   scheduleStyleInvalidationEvents: readonly Types.Events.ScheduleStyleInvalidationTracking[];
   styleRecalcInvalidationEvents: readonly Types.Events.StyleRecalcInvalidationTracking[];
   renderFrameImplCreateChildFrameEvents: readonly Types.Events.RenderFrameImplCreateChildFrame[];
   domLoadingEvents: readonly Types.Events.DomLoading[];
+  layoutImageUnsizedEvents: readonly Types.Events.LayoutImageUnsized[];
   beginRemoteFontLoadEvents: readonly Types.Events.BeginRemoteFontLoad[];
   scoreRecords: readonly ScoreRecord[];
   // TODO(crbug/41484172): should be readonly
@@ -81,6 +83,7 @@ const scheduleStyleInvalidationEvents: Types.Events.ScheduleStyleInvalidationTra
 const styleRecalcInvalidationEvents: Types.Events.StyleRecalcInvalidationTracking[] = [];
 const renderFrameImplCreateChildFrameEvents: Types.Events.RenderFrameImplCreateChildFrame[] = [];
 const domLoadingEvents: Types.Events.DomLoading[] = [];
+const layoutImageUnsizedEvents: Types.Events.LayoutImageUnsized[] = [];
 const beginRemoteFontLoadEvents: Types.Events.BeginRemoteFontLoad[] = [];
 
 const backendNodeIds = new Set<Protocol.DOM.BackendNodeId>();
@@ -91,6 +94,8 @@ const backendNodeIds = new Set<Protocol.DOM.BackendNodeId>();
 // node of such shift.
 const prePaintEvents: Types.Events.PrePaint[] = [];
 
+const paintImageEvents: Types.Events.PaintImage[] = [];
+
 let sessionMaxScore = 0;
 
 let clsWindowID = -1;
@@ -109,23 +114,15 @@ type ScoreRecord = {
 // Includes drops to 0 when session windows end.
 const scoreRecords: ScoreRecord[] = [];
 
-let handlerState = HandlerState.UNINITIALIZED;
-
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('LayoutShifts Handler was not reset');
-  }
-  handlerState = HandlerState.INITIALIZED;
-}
-
 export function reset(): void {
-  handlerState = HandlerState.UNINITIALIZED;
   layoutShiftEvents.length = 0;
   layoutInvalidationEvents.length = 0;
   scheduleStyleInvalidationEvents.length = 0;
   styleRecalcInvalidationEvents.length = 0;
   prePaintEvents.length = 0;
+  paintImageEvents.length = 0;
   renderFrameImplCreateChildFrameEvents.length = 0;
+  layoutImageUnsizedEvents.length = 0;
   domLoadingEvents.length = 0;
   beginRemoteFontLoadEvents.length = 0;
   backendNodeIds.clear();
@@ -137,10 +134,6 @@ export function reset(): void {
 }
 
 export function handleEvent(event: Types.Events.Event): void {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Handler is not initialized');
-  }
-
   if (Types.Events.isLayoutShift(event) && !event.args.data?.had_recent_input) {
     layoutShiftEvents.push(event);
     return;
@@ -165,9 +158,15 @@ export function handleEvent(event: Types.Events.Event): void {
   if (Types.Events.isDomLoading(event)) {
     domLoadingEvents.push(event);
   }
+  if (Types.Events.isLayoutImageUnsized(event)) {
+    layoutImageUnsizedEvents.push(event);
+  }
   if (Types.Events.isBeginRemoteFontLoad(event)) {
     beginRemoteFontLoadEvents.push(event);
   }
+  if (Types.Events.isPaintImage(event)) {
+    paintImageEvents.push(event);
+  }
 }
 
 function traceWindowFromTime(time: Types.Timing.MicroSeconds): Types.Timing.TraceWindowMicroSeconds {
@@ -251,14 +250,15 @@ export async function finalize(): Promise<void> {
   layoutInvalidationEvents.sort((a, b) => a.ts - b.ts);
   renderFrameImplCreateChildFrameEvents.sort((a, b) => a.ts - b.ts);
   domLoadingEvents.sort((a, b) => a.ts - b.ts);
+  layoutImageUnsizedEvents.sort((a, b) => a.ts - b.ts);
   beginRemoteFontLoadEvents.sort((a, b) => a.ts - b.ts);
+  paintImageEvents.sort((a, b) => a.ts - b.ts);
 
   // Each function transforms the data used by the next, as such the invoke order
   // is important.
   await buildLayoutShiftsClusters();
   buildScoreRecords();
   collectNodes();
-  handlerState = HandlerState.FINALIZED;
 }
 
 async function buildLayoutShiftsClusters(): Promise<void> {
@@ -494,10 +494,6 @@ async function buildLayoutShiftsClusters(): Promise<void> {
 }
 
 export function data(): LayoutShifts {
-  if (handlerState !== HandlerState.FINALIZED) {
-    throw new Error('Layout Shifts Handler is not finalized');
-  }
-
   return {
     clusters,
     sessionMaxScore,
@@ -508,11 +504,13 @@ export function data(): LayoutShifts {
     styleRecalcInvalidationEvents: [],
     renderFrameImplCreateChildFrameEvents,
     domLoadingEvents,
+    layoutImageUnsizedEvents,
     beginRemoteFontLoadEvents,
     scoreRecords,
     // TODO(crbug/41484172): change the type so no need to clone
     backendNodeIds: [...backendNodeIds],
     clustersByNavigationId: new Map(clustersByNavigationId),
+    paintImageEvents,
   };
 }
 

package/front_end/models/trace/handlers/MemoryHandler.test.ts

@@ -13,7 +13,6 @@ describe('MemoryHandler', function() {
 
   it('gathers update counters', async function() {
     const events = await TraceLoader.rawEvents(this, 'web-dev.json.gz');
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of events) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       Trace.Handlers.ModelHandlers.Memory.handleEvent(event);

package/front_end/models/trace/handlers/MemoryHandler.ts

@@ -23,6 +23,9 @@ export function handleEvent(event: Types.Events.Event): void {
   }
 }
 
+export async function finalize(): Promise<void> {
+}
+
 export function data(): MemoryData {
   return {updateCountersByProcess};
 }

package/front_end/models/trace/handlers/MetaHandler.test.ts

@@ -50,7 +50,7 @@ describe('MetaHandler', function() {
         tid: Trace.Types.Events.ThreadID(775),
         ts: Trace.Types.Timing.MicroSeconds(800),
         name: 'navigationStart',
-      } as Trace.Types.Events.NavigationStart,
+      } as Trace.Types.Events.NavigationStartUnreliable,
       {
         ...defaultTraceEvent,
         args: {
@@ -69,27 +69,6 @@ describe('MetaHandler', function() {
     ];
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
-  });
-
-  describe('error handling', function() {
-    it('throws if data is called before finalize', function() {
-      for (const event of baseEvents) {
-        Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
-      }
-
-      assert.throws(() => {
-        Trace.Handlers.ModelHandlers.Meta.data();
-      }, 'Handler is not finalized');
-    });
-
-    it('throws if initialize is called without a reset', function() {
-      // Due to the beforeEach the handler is already initialized, so calling
-      // it a second time should throw an error.
-      assert.throws(() => {
-        Trace.Handlers.ModelHandlers.Meta.initialize();
-      }, 'Handler was not reset');
-    });
   });
 
   describe('browser process ID', function() {
@@ -154,7 +133,6 @@ describe('MetaHandler', function() {
     it('provides a list of main frame only navigations', async function() {
       const events = await TraceLoader.rawEvents(this, 'multiple-navigations-with-iframes.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -183,7 +161,6 @@ describe('MetaHandler', function() {
     it('finds the main frame ID for a trace that started with a page reload', async function() {
       const events = await TraceLoader.rawEvents(this, 'reload-and-trace-page.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -195,7 +172,6 @@ describe('MetaHandler', function() {
     it('tracks the frames for found processes', async function() {
       const events = await TraceLoader.rawEvents(this, 'reload-and-trace-page.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -215,7 +191,6 @@ describe('MetaHandler', function() {
     it('finds the GPU process and GPU Thread', async function() {
       const events = await TraceLoader.rawEvents(this, 'threejs-gpu.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -250,7 +225,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -288,7 +262,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -345,7 +318,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -403,7 +375,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -433,7 +404,6 @@ describe('MetaHandler', function() {
     });
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -455,7 +425,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }

package/front_end/models/trace/handlers/MetaHandler.ts

@@ -6,8 +6,6 @@ import * as Platform from '../../../core/platform/platform.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
-import {HandlerState} from './types.js';
-
 // We track the renderer processes we see in each frame on the way through the trace.
 const rendererProcessesByFrameId: FrameProcessData = new Map();
 
@@ -67,7 +65,6 @@ const eventPhasesOfInterestForTraceBounds = new Set([
   Types.Events.Phase.INSTANT,
 ]);
 
-let handlerState = HandlerState.UNINITIALIZED;
 // Tracks if the trace is a generic trace, which here means that it did not come from athe DevTools Performance Panel recording.
 // We assume a trace is generic, and mark it as not generic if we see any of:
 // - TracingStartedInPage
@@ -104,16 +101,6 @@ export function reset(): void {
   traceStartedTimeFromTracingStartedEvent = Types.Timing.MicroSeconds(-1);
 
   traceIsGeneric = true;
-
-  handlerState = HandlerState.UNINITIALIZED;
-}
-
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('Meta Handler was not reset');
-  }
-
-  handlerState = HandlerState.INITIALIZED;
 }
 
 function updateRendererProcessByFrame(event: Types.Events.Event, frame: Types.Events.TraceFrame): void {
@@ -147,10 +134,6 @@ function updateRendererProcessByFrame(event: Types.Events.Event, frame: Types.Ev
 }
 
 export function handleEvent(event: Types.Events.Event): void {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Meta Handler is not initialized');
-  }
-
   if (traceIsGeneric && CHROME_WEB_TRACE_EVENTS.has(event.name as Types.Events.Name)) {
     traceIsGeneric = false;
   }
@@ -311,9 +294,8 @@ export function handleEvent(event: Types.Events.Event): void {
   // Track all navigation events. Note that there can be navigation start events
   // but where the documentLoaderURL is empty. As far as the trace rendering is
   // concerned, these events are noise so we filter them out here.
-  // (The filtering of empty URLs is done in the
-  // isNavigationStartWithURL check)
-  if (Types.Events.isNavigationStartWithURL(event) && event.args.data) {
+  // (The filtering of empty URLs is done in the isNavigationStart check)
+  if (Types.Events.isNavigationStart(event) && event.args.data) {
     const navigationId = event.args.data.navigationId;
     if (navigationsByNavigationId.has(navigationId)) {
       // We have only ever seen this situation once, in crbug.com/1503982, where the user ran:
@@ -336,10 +318,6 @@ export function handleEvent(event: Types.Events.Event): void {
 }
 
 export async function finalize(): Promise<void> {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Handler is not initialized');
-  }
-
   // We try to set the minimum time by finding the event with the smallest
   // timestamp. However, if we also got a timestamp from the
   // TracingStartedInBrowser event, we should always use that.
@@ -412,8 +390,6 @@ export async function finalize(): Promise<void> {
       mainFrameURL = firstMainFrameNav.args.data.documentLoaderURL;
     }
   }
-
-  handlerState = HandlerState.FINALIZED;
 }
 
 export type MetaHandlerData = {
@@ -464,10 +440,6 @@ export type FrameProcessData =
         Map<Types.Events.ProcessID, {frame: Types.Events.TraceFrame, window: Types.Timing.TraceWindowMicroSeconds}[]>>;
 
 export function data(): MetaHandlerData {
-  if (handlerState !== HandlerState.FINALIZED) {
-    throw new Error('Meta Handler is not finalized');
-  }
-
   return {
     traceBounds: {...traceBounds},
     browserProcessId,

package/front_end/models/trace/handlers/NetworkRequestsHandler.test.ts

@@ -11,29 +11,9 @@ type DataArgsMap = Map<keyof DataArgs, DataArgs[keyof DataArgs]>;
 type DataArgsProcessedDataMap = Map<keyof DataArgsProcessedData, DataArgsProcessedData[keyof DataArgsProcessedData]>;
 
 describe('NetworkRequestsHandler', function() {
-  describe('error handling', () => {
-    it('throws if handleEvent is called before it is initialized', () => {
-      assert.throws(() => {
-        Trace.Handlers.ModelHandlers.NetworkRequests.handleEvent({} as Trace.Types.Events.Event);
-      }, 'Network Request handler is not initialized');
-    });
-
-    it('throws if finalize is called before initialize', async () => {
-      let thrown: Error|null = null;
-      try {
-        await Trace.Handlers.ModelHandlers.NetworkRequests.finalize();
-      } catch (e) {
-        thrown = e as Error;
-      }
-      assert.strictEqual(thrown?.message, 'Network Request handler is not initialized');
-    });
-  });
-
   describe('network requests calculations', () => {
     beforeEach(() => {
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
-      Trace.Handlers.ModelHandlers.NetworkRequests.initialize();
     });
 
     it('calculates network requests correctly', async function() {
@@ -200,8 +180,6 @@ describe('NetworkRequestsHandler', function() {
   describe('parses the change priority request', () => {
     beforeEach(() => {
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
-      Trace.Handlers.ModelHandlers.NetworkRequests.initialize();
     });
 
     it('changes priority of the resouce', async function() {
@@ -232,8 +210,6 @@ describe('NetworkRequestsHandler', function() {
   describe('redirects', () => {
     beforeEach(() => {
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
-      Trace.Handlers.ModelHandlers.NetworkRequests.initialize();
     });
 
     it('calculates redirects correctly (navigations)', async function() {
@@ -306,8 +282,6 @@ describe('NetworkRequestsHandler', function() {
   describe('initiators', () => {
     beforeEach(() => {
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
-      Trace.Handlers.ModelHandlers.NetworkRequests.initialize();
     });
 
     it('calculate the initiator by `initiator` field correctly', async function() {

package/front_end/models/trace/handlers/NetworkRequestsHandler.ts

@@ -8,7 +8,7 @@ import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
 import {data as metaHandlerData} from './MetaHandler.js';
-import {type HandlerName, HandlerState} from './types.js';
+import type {HandlerName} from './types.js';
 
 const MILLISECONDS_TO_MICROSECONDS = 1000;
 const SECONDS_TO_MICROSECONDS = 1000000;
@@ -103,8 +103,6 @@ function firstPositiveValueInList(entries: number[]): number {
   return 0;
 }
 
-let handlerState = HandlerState.UNINITIALIZED;
-
 export function reset(): void {
   requestsById.clear();
   requestsByOrigin.clear();
@@ -113,19 +111,9 @@ export function reset(): void {
   networkRequestEventByInitiatorUrl.clear();
   eventToInitiatorMap.clear();
   webSocketData.clear();
-
-  handlerState = HandlerState.UNINITIALIZED;
-}
-
-export function initialize(): void {
-  handlerState = HandlerState.INITIALIZED;
 }
 
 export function handleEvent(event: Types.Events.Event): void {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Network Request handler is not initialized');
-  }
-
   if (Types.Events.isResourceChangePriority(event)) {
     storeTraceEventWithRequestId(event.args.data.requestId, 'changePriority', event);
     return;
@@ -187,10 +175,6 @@ export function handleEvent(event: Types.Events.Event): void {
 }
 
 export async function finalize(): Promise<void> {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Network Request handler is not initialized');
-  }
-
   const {rendererProcessesByFrame} = metaHandlerData();
   for (const [requestId, request] of requestMap.entries()) {
     // If we have an incomplete set of events here, we choose to drop the network
@@ -271,6 +255,9 @@ export async function finalize(): Promise<void> {
       finalPriority = request.changePriority.args.data.priority;
     }
 
+    // Network timings are complicated.
+    // https://raw.githubusercontent.com/GoogleChrome/lighthouse/main/docs/Network-Timings.svg is generally correct, but.. less so for navigations/redirects/etc.
+
     // Start time
     // =======================
     // The time where the request started, which is either the first willSendRequest
@@ -438,10 +425,10 @@ export async function finalize(): Promise<void> {
               requestId,
               requestingFrameUrl,
               requestMethod: finalSendRequest.args.data.requestMethod,
-              resourceType: finalSendRequest.args.data.resourceType,
+              resourceType: finalSendRequest.args.data.resourceType ?? Protocol.Network.ResourceType.Other,
               statusCode: request.receiveResponse.args.data.statusCode,
               responseHeaders: request.receiveResponse.args.data.headers || [],
-              fetchPriorityHint: finalSendRequest.args.data.fetchPriorityHint,
+              fetchPriorityHint: finalSendRequest.args.data.fetchPriorityHint ?? 'auto',
               initiator: finalSendRequest.args.data.initiator,
               stackTrace: finalSendRequest.args.data.stackTrace,
               timing,
@@ -504,15 +491,9 @@ export async function finalize(): Promise<void> {
     }
   }
   finalizeWebSocketData();
-
-  handlerState = HandlerState.FINALIZED;
 }
 
 export function data(): NetworkRequestData {
-  if (handlerState !== HandlerState.FINALIZED) {
-    throw new Error('Network Request handler is not finalized');
-  }
-
   return {
     byId: requestsById,
     byOrigin: requestsByOrigin,

package/front_end/models/trace/handlers/PageFramesHandler.ts

@@ -39,6 +39,9 @@ export function handleEvent(event: Types.Events.Event): void {
   }
 }
 
+export async function finalize(): Promise<void> {
+}
+
 export interface PageFrameData {
   frames: Map<string, Types.Events.TraceFrame>;
 }

package/front_end/models/trace/handlers/RendererHandler.test.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Components from '../../../panels/timeline/components/components.js';
+import * as Utils from '../../../panels/timeline/utils/utils.js';
 import {describeWithEnvironment} from '../../../testing/EnvironmentHelpers.js';
 import {
   getAllNodes,
@@ -192,7 +192,7 @@ describeWithEnvironment('RendererHandler', function() {
     const isLong = (event: Trace.Types.Events.Event) => Trace.Types.Events.isComplete(event) && event.dur > 1000;
     const isIncluded = (node: Trace.Helpers.TreeHelpers.TraceEntryNode, event: Trace.Types.Events.Event) =>
         (!isRoot(node) || isInstant(event) || isLong(event)) &&
-        Boolean(Components.EntryStyles.getEventStyle(event.name as Trace.Types.Events.Name));
+        Boolean(Utils.EntryStyles.getEventStyle(event.name as Trace.Types.Events.Name));
     assert.strictEqual(prettyPrint(tree, isIncluded), `
 ............
 -RunTask [2.21ms]
@@ -391,7 +391,7 @@ describeWithEnvironment('RendererHandler', function() {
       assert(false, 'Main thread has no tree of events');
     }
     const isIncluded = (_node: Trace.Helpers.TreeHelpers.TraceEntryNode, event: Trace.Types.Events.Event) =>
-        Boolean(Components.EntryStyles.getEventStyle(event.name as Trace.Types.Events.Name));
+        Boolean(Utils.EntryStyles.getEventStyle(event.name as Trace.Types.Events.Name));
     assert.strictEqual(prettyPrint(tree, isIncluded), `
 -RunTask [0.13ms]
 -RunTask [0.005ms]
@@ -663,7 +663,6 @@ describeWithEnvironment('RendererHandler', function() {
       ],
     ]);
 
-    Trace.Handlers.ModelHandlers.Samples.initialize();
     await Trace.Handlers.ModelHandlers.Samples.finalize();
     Trace.Handlers.ModelHandlers.Renderer.buildHierarchy(processes, {filter: {has: () => true}});
 
@@ -796,9 +795,6 @@ describeWithEnvironment('RendererHandler', function() {
       Trace.Handlers.ModelHandlers.Renderer.reset();
       Trace.Handlers.ModelHandlers.Meta.reset();
       Trace.Handlers.ModelHandlers.Samples.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
-      Trace.Handlers.ModelHandlers.Samples.initialize();
-      Trace.Handlers.ModelHandlers.Renderer.initialize();
 
       for (const event of traceEvents) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
@@ -934,7 +930,7 @@ describeWithEnvironment('RendererHandler', function() {
       const onlyLongTasksPredicate =
           (_node: Trace.Helpers.TreeHelpers.TraceEntryNode, event: Trace.Types.Events.Event) =>
               Boolean(event.dur && event.dur > 1000) &&
-          Boolean(Components.EntryStyles.getEventStyle(event.name as Trace.Types.Events.Name));
+          Boolean(Utils.EntryStyles.getEventStyle(event.name as Trace.Types.Events.Name));
       assert.strictEqual(prettyPrint(thread.tree, onlyLongTasksPredicate), `
 .............
 -RunTask [17.269ms]

package/front_end/models/trace/handlers/RendererHandler.ts

@@ -9,7 +9,7 @@ import * as Types from '../types/types.js';
 import {data as auctionWorkletsData} from './AuctionWorkletsHandler.js';
 import {data as metaHandlerData, type FrameProcessData} from './MetaHandler.js';
 import {data as samplesHandlerData} from './SamplesHandler.js';
-import {type HandlerName, HandlerState} from './types.js';
+import type {HandlerName} from './types.js';
 
 /**
  * This handler builds the hierarchy of trace events and profile calls
@@ -37,7 +37,6 @@ let allTraceEntries: Types.Events.Event[] = [];
 
 const completeEventStack: (Types.Events.SyntheticComplete)[] = [];
 
-let handlerState = HandlerState.UNINITIALIZED;
 let config: Types.Configuration.Configuration = Types.Configuration.defaults();
 
 const makeRendererProcess = (): RendererProcess => ({
@@ -71,22 +70,9 @@ export function reset(): void {
   allTraceEntries.length = 0;
   completeEventStack.length = 0;
   compositorTileWorkers.length = 0;
-  handlerState = HandlerState.UNINITIALIZED;
-}
-
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('Renderer Handler was not reset');
-  }
-
-  handlerState = HandlerState.INITIALIZED;
 }
 
 export function handleEvent(event: Types.Events.Event): void {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Renderer Handler is not initialized');
-  }
-
   if (Types.Events.isThreadName(event) && event.args.name?.startsWith('CompositorTileWorker')) {
     compositorTileWorkers.push({
       pid: event.pid,
@@ -115,24 +101,15 @@ export function handleEvent(event: Types.Events.Event): void {
 }
 
 export async function finalize(): Promise<void> {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Renderer Handler is not initialized');
-  }
-
   const {mainFrameId, rendererProcessesByFrame, threadsInProcess} = metaHandlerData();
   assignMeta(processes, mainFrameId, rendererProcessesByFrame, threadsInProcess);
   sanitizeProcesses(processes);
   buildHierarchy(processes);
   sanitizeThreads(processes);
   Helpers.Trace.sortTraceEventsInPlace(allTraceEntries);
-  handlerState = HandlerState.FINALIZED;
 }
 
 export function data(): RendererHandlerData {
-  if (handlerState !== HandlerState.FINALIZED) {
-    throw new Error('Renderer Handler is not finalized');
-  }
-
   return {
     processes: new Map(processes),
     compositorTileWorkers: new Map(gatherCompositorThreads()),

package/front_end/models/trace/handlers/SamplesHandler.test.ts

@@ -14,9 +14,6 @@ async function handleEventsFromTraceFile(context: Mocha.Context|Mocha.Suite|null
   Trace.Handlers.ModelHandlers.Meta.reset();
   Trace.Handlers.ModelHandlers.Samples.reset();
 
-  Trace.Handlers.ModelHandlers.Meta.initialize();
-  Trace.Handlers.ModelHandlers.Samples.initialize();
-
   for (const event of traceEvents) {
     Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     Trace.Handlers.ModelHandlers.Samples.handleEvent(event);
@@ -141,8 +138,6 @@ describeWithEnvironment('SamplesHandler', function() {
       ];
       Trace.Handlers.ModelHandlers.Samples.reset();
 
-      Trace.Handlers.ModelHandlers.Samples.initialize();
-
       for (const event of [mockProfileEvent, ...mockChunks]) {
         Trace.Handlers.ModelHandlers.Samples.handleEvent(event);
       }