chrome-devtools-frontend 1.0.1367881 → 1.0.1380117

package/front_end/models/live-metrics/web-vitals-injected/web-vitals-injected.ts

@@ -98,6 +98,29 @@ window.getNodeForIndex = (index: number): Node|undefined => {
   return nodeList[index];
 };
 
+function limitScripts(loafs: Spec.PerformanceLongAnimationFrameTimingJSON[]):
+    Spec.PerformanceLongAnimationFrameTimingJSON[] {
+  return loafs.map(loaf => {
+    const longestScripts: Spec.PerformanceScriptTimingJSON[] = [];
+    for (const script of loaf.scripts) {
+      if (longestScripts.length < Spec.SCRIPTS_PER_LOAF_LIMIT) {
+        longestScripts.push(script);
+        continue;
+      }
+
+      const shorterIndex = longestScripts.findIndex(s => s.duration < script.duration);
+      if (shorterIndex === -1) {
+        continue;
+      }
+
+      longestScripts[shorterIndex] = script;
+    }
+    longestScripts.sort((a, b) => a.startTime - b.startTime);
+    loaf.scripts = longestScripts;
+    return loaf;
+  });
+}
+
 function initialize(): void {
   sendEventToDevTools({name: 'reset'});
 
@@ -148,18 +171,33 @@ function initialize(): void {
         processingDuration: metric.attribution.processingDuration,
         presentationDelay: metric.attribution.presentationDelay,
       },
-      uniqueInteractionId: Spec.getUniqueInteractionId(metric.entries),
+      startTime: metric.entries[0].startTime,
+      entryGroupId: metric.entries[0].interactionId as Spec.InteractionEntryGroupId,
       interactionType: metric.attribution.interactionType,
     };
     sendEventToDevTools(event);
-  }, {reportAllChanges: true});
+  }, {reportAllChanges: true, durationThreshold: 0});
 
   onEachInteraction(interaction => {
-    const event: Spec.InteractionEvent = {
-      name: 'Interaction',
+    // Multiple `InteractionEntry` events can be emitted for the same `uniqueInteractionId`
+    // However, it is easier to combine these entries in the DevTools client rather than in
+    // this injected code.
+    const event: Spec.InteractionEntryEvent = {
+      name: 'InteractionEntry',
       duration: interaction.value,
-      uniqueInteractionId: Spec.getUniqueInteractionId(interaction.entries),
+      phases: {
+        inputDelay: interaction.attribution.inputDelay,
+        processingDuration: interaction.attribution.processingDuration,
+        presentationDelay: interaction.attribution.presentationDelay,
+      },
+      startTime: interaction.entries[0].startTime,
+      entryGroupId: interaction.entries[0].interactionId as Spec.InteractionEntryGroupId,
+      nextPaintTime: interaction.attribution.nextPaintTime,
       interactionType: interaction.attribution.interactionType,
+      eventName: interaction.entries[0].name,
+      // To limit the amount of events, just get the last 5 LoAFs
+      longAnimationFrameEntries: limitScripts(
+          interaction.attribution.longAnimationFrameEntries.slice(-Spec.LOAF_LIMIT).map(loaf => loaf.toJSON())),
     };
     const node = interaction.attribution.interactionTargetElement;
     if (node) {

package/front_end/models/persistence/EditFileSystemView.ts

@@ -38,14 +38,18 @@ import {Events, IsolatedFileSystemManager} from './IsolatedFileSystemManager.js'
 import type {PlatformFileSystem} from './PlatformFileSystem.js';
 
 const UIStrings = {
+  /**
+   *@description Text in Edit File System View of the Workspace settings in Settings to indicate that the following string is a folder URL
+   */
+  url: 'URL',
   /**
    *@description Text in Edit File System View of the Workspace settings in Settings
    */
-  excludedFolders: 'Excluded folders',
+  excludedFolders: 'Excluded sub-folders',
   /**
    *@description Text to add something
    */
-  add: 'Add',
+  add: 'Add folder',
   /**
    * @description Placeholder text for an area of the UI that shows which folders have been excluded
    * from being show in DevTools. When the user has not yet chosen any folders to exclude, this text
@@ -91,13 +95,13 @@ export class EditFileSystemView extends UI.Widget.VBox implements UI.ListWidget.
       IsolatedFileSystemManager.instance().addEventListener(Events.ExcludedFolderRemoved, this.update, this),
     ];
 
-    const excludedFoldersHeader = this.contentElement.createChild('div', 'file-system-header');
-    excludedFoldersHeader.createChild('div', 'file-system-header-text').textContent =
-        i18nString(UIStrings.excludedFolders);
-    const addButton = UI.UIUtils.createTextButton(
-        i18nString(UIStrings.add), this.addExcludedFolderButtonClicked.bind(this),
-        {className: 'add-button', jslogContext: 'settings.add-excluded-folder'});
-    excludedFoldersHeader.appendChild(addButton);
+    const excludedFoldersHeader = this.contentElement.createChild('div', 'excluded-folder-header');
+    excludedFoldersHeader.createChild('span').textContent = i18nString(UIStrings.url);
+    excludedFoldersHeader.createChild('span', 'excluded-folder-url').textContent = fileSystemPath;
+
+    const excludeSubFoldersText = this.contentElement.createChild('span', 'exclude-subfolders-text');
+    excludeSubFoldersText.textContent = i18nString(UIStrings.excludedFolders);
+
     this.excludedFoldersList = new UI.ListWidget.ListWidget(this);
     this.excludedFoldersList.element.classList.add('file-system-list');
 
@@ -107,6 +111,12 @@ export class EditFileSystemView extends UI.Widget.VBox implements UI.ListWidget.
     this.excludedFoldersList.setEmptyPlaceholder(excludedFoldersPlaceholder);
     this.excludedFoldersList.show(this.contentElement);
 
+    const addButton = UI.UIUtils.createTextButton(
+        i18nString(UIStrings.add), this.addExcludedFolderButtonClicked.bind(this),
+        {className: 'add-button', jslogContext: 'settings.add-excluded-folder'});
+
+    this.contentElement.appendChild(addButton);
+
     this.update();
   }
 

package/front_end/models/persistence/WorkspaceSettingsTab.ts

@@ -4,6 +4,7 @@
 
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
+import * as Cards from '../../ui/components/cards/cards.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
@@ -27,11 +28,11 @@ const UIStrings = {
   /**
    *@description Text of the add button in Workspace Settings Tab of the Workspace settings in Settings
    */
-  addFolder: 'Add folder…',
+  addFolder: 'Add folder',
   /**
    *@description Label element text content in Workspace Settings Tab of the Workspace settings in Settings
    */
-  folderExcludePattern: 'Folder exclude pattern',
+  folderExcludePattern: 'Exclude from workspace',
   /**
    *@description Label for an item to remove something
    */
@@ -42,7 +43,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class WorkspaceSettingsTab extends UI.Widget.VBox {
   containerElement: HTMLElement;
-  private readonly fileSystemsListContainer: HTMLElement;
+  #addButtonContainer: HTMLElement;
   private readonly elementByPath: Map<Platform.DevToolsPath.UrlString, Element>;
   private readonly mappingViewByPath: Map<Platform.DevToolsPath.UrlString, EditFileSystemView>;
 
@@ -51,12 +52,9 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
 
     this.element.setAttribute('jslog', `${VisualLogging.pane('workspace')}`);
 
-    this.element.classList.add('workspace-settings-tab');
-    const header = this.element.createChild('header');
-    UI.UIUtils.createTextChild(header.createChild('h1'), i18nString(UIStrings.workspace));
-
-    this.containerElement = this.element.createChild('div', 'settings-container-wrapper')
-                                .createChild('div', 'settings-tab settings-content settings-container');
+    this.containerElement =
+        this.contentElement.createChild('div', 'settings-card-container-wrapper').createChild('div');
+    this.containerElement.classList.add('settings-card-container');
 
     IsolatedFileSystemManager.instance().addEventListener(
         Events.FileSystemAdded, event => this.fileSystemAdded(event.data), this);
@@ -65,27 +63,31 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
 
     const folderExcludePatternInput = this.createFolderExcludePatternInput();
     folderExcludePatternInput.classList.add('folder-exclude-pattern');
-    this.containerElement.appendChild(folderExcludePatternInput);
-
-    const div = this.containerElement.createChild('div', 'settings-info-message');
-    UI.UIUtils.createTextChild(div, i18nString(UIStrings.mappingsAreInferredAutomatically));
+    const mappingsAreInferredInfo = document.createElement('div');
+    mappingsAreInferredInfo.classList.add('mappings-info');
+    UI.UIUtils.createTextChild(mappingsAreInferredInfo, i18nString(UIStrings.mappingsAreInferredAutomatically));
 
-    this.fileSystemsListContainer = this.containerElement.createChild('div', '');
-
-    const addButton = UI.UIUtils.createTextButton(
-        i18nString(UIStrings.addFolder), this.addFileSystemClicked.bind(this),
-        {jslogContext: 'sources.add-folder-to-workspace'});
-    this.containerElement.appendChild(addButton);
-    this.setDefaultFocusedElement(addButton);
+    const card = new Cards.Card.Card();
+    this.containerElement.appendChild(card);
+    card.data = {
+      heading: i18nString(UIStrings.workspace),
+      content: [folderExcludePatternInput, mappingsAreInferredInfo],
+    };
 
     this.elementByPath = new Map();
-
     this.mappingViewByPath = new Map();
 
     const fileSystems = IsolatedFileSystemManager.instance().fileSystems();
     for (let i = 0; i < fileSystems.length; ++i) {
       this.addItem(fileSystems[i]);
     }
+
+    this.#addButtonContainer = this.containerElement.createChild('div', 'add-button-container');
+    const addButton = UI.UIUtils.createTextButton(
+        i18nString(UIStrings.addFolder), this.addFileSystemClicked.bind(this),
+        {jslogContext: 'sources.add-folder-to-workspace'});
+    addButton.classList.add('add-folder');
+    this.#addButtonContainer.appendChild(addButton);
   }
 
   override wasShown(): void {
@@ -93,19 +95,20 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
     this.registerCSSFiles([workspaceSettingsTabStyles]);
   }
 
-  private createFolderExcludePatternInput(): Element {
-    const p = document.createElement('p');
-    const labelElement = p.createChild('label');
+  private createFolderExcludePatternInput(): HTMLElement {
+    const excludePatternElement = document.createElement('div');
+    excludePatternElement.classList.add('folder-exclude-pattern');
+    const labelElement = excludePatternElement.createChild('label');
     labelElement.textContent = i18nString(UIStrings.folderExcludePattern);
     const folderExcludeSetting = IsolatedFileSystemManager.instance().workspaceFolderExcludePatternSetting();
     const inputElement = UI.UIUtils.createInput('', 'text', folderExcludeSetting.name);
     UI.ARIAUtils.bindLabelToControl(labelElement, inputElement);
-    p.appendChild(inputElement);
+    excludePatternElement.appendChild(inputElement);
     const setValue =
         UI.UIUtils.bindInput(inputElement, folderExcludeSetting.set.bind(folderExcludeSetting), regexValidator, false);
     folderExcludeSetting.addChangeListener(() => setValue.call(null, folderExcludeSetting.get()));
     setValue(folderExcludeSetting.get());
-    return p;
+    return excludePatternElement;
 
     function regexValidator(value: string): {valid: boolean, errorMessage: (string|undefined)} {
       let regex;
@@ -129,41 +132,34 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
             fileSystem) {
       return;
     }
-    const element = this.renderFileSystem(fileSystem);
-    this.elementByPath.set(fileSystem.path(), element);
-
-    this.fileSystemsListContainer.appendChild(element);
-
+    const filename = this.getFilename(fileSystem);
+    const removeButton = UI.UIUtils.createTextButton(
+        i18nString(UIStrings.remove), this.removeFileSystemClicked.bind(this, fileSystem),
+        {jslogContext: 'settings.remove-file-system'});
+
+    const mappingViewContainer = document.createElement('div');
+    mappingViewContainer.classList.add('mapping-view-container');
+    const fileSystemExcludeCard = new Cards.Card.Card();
+    this.containerElement.insertBefore(fileSystemExcludeCard, this.#addButtonContainer);
+    fileSystemExcludeCard.data = {
+      heading: filename,
+      headingIconName: 'folder',
+      headingSuffix: removeButton,
+      content: [mappingViewContainer],
+    };
     const mappingView = new EditFileSystemView(fileSystem.path());
     this.mappingViewByPath.set(fileSystem.path(), mappingView);
     mappingView.element.classList.add('file-system-mapping-view');
-    mappingView.show(element);
+
+    mappingView.show(mappingViewContainer);
+
+    this.elementByPath.set(fileSystem.path(), fileSystemExcludeCard);
   }
 
-  private renderFileSystem(fileSystem: PlatformFileSystem): Element {
+  private getFilename(fileSystem: PlatformFileSystem): string {
     const fileSystemPath = fileSystem.path();
     const lastIndexOfSlash = fileSystemPath.lastIndexOf('/');
-    const folderName = fileSystemPath.substr(lastIndexOfSlash + 1);
-
-    const element = document.createElement('div');
-    element.classList.add('file-system-container');
-    const header = element.createChild('div', 'file-system-header');
-
-    const nameElement = header.createChild('div', 'file-system-name');
-    nameElement.textContent = folderName;
-    UI.ARIAUtils.markAsHeading(nameElement, 2);
-    const path = header.createChild('div', 'file-system-path');
-    path.textContent = fileSystemPath;
-    UI.Tooltip.Tooltip.install(path, fileSystemPath);
-
-    const toolbar = new UI.Toolbar.Toolbar('');
-    const button =
-        new UI.Toolbar.ToolbarButton(i18nString(UIStrings.remove), 'cross', undefined, 'settings.remove-file-system');
-    button.addEventListener(UI.Toolbar.ToolbarButton.Events.CLICK, this.removeFileSystemClicked.bind(this, fileSystem));
-    toolbar.appendToolbarItem(button);
-    header.appendChild(toolbar.element);
-
-    return element;
+    return fileSystemPath.substr(lastIndexOfSlash + 1);
   }
 
   private removeFileSystemClicked(fileSystem: PlatformFileSystem): void {

package/front_end/models/persistence/editFileSystemView.css

@@ -4,20 +4,33 @@
  * found in the LICENSE file.
  */
 
-.file-system-header {
+.excluded-folder-header {
   display: flex;
-  flex-direction: row;
-  align-items: center;
-  flex: auto;
-  margin: 10px 0;
+  flex-direction: column;
+  height: var(--sys-size-16);
+  border-bottom: var(--sys-size-1) solid var(--sys-color-divider);
+  padding: var(--sys-size-5) var(--sys-size-6);
+
+  & > .excluded-folder-url {
+    color: var(--sys-color-on-surface-subtle);
+    overflow: hidden;
+    text-overflow: ellipsis;
+  }
 }
 
-.file-system-header-text {
-  flex: 1 0 auto;
+.exclude-subfolders-text,
+.file-system-list-empty {
+  padding: 0 var(--sys-size-6);
+  height: var(--sys-size-13);
+}
+
+.exclude-subfolders-text {
+  align-items: center;
+  display: flex;
 }
 
 .add-button {
-  margin-left: 10px;
+  padding: var(--sys-size-4) var(--sys-size-6);
   align-self: flex-start;
 }
 
@@ -26,17 +39,12 @@
 }
 
 .file-system-list-empty {
-  flex: auto;
-  height: 30px;
   display: flex;
   align-items: center;
-  justify-content: center;
-  text-align: center;
 }
 
 .file-system-list-item {
-  padding: 3px 5px;
-  height: 30px;
+  height: var(--sys-size-13);
   display: flex;
   align-items: center;
   flex: auto 1 1;
@@ -46,6 +54,18 @@
   flex: 1 1 0;
 }
 
+.list {
+  border: none;
+}
+
+.list-item {
+  padding: 0 var(--sys-size-6);
+}
+
+.editor-buttons {
+  padding: var(--sys-size-4) var(--sys-size-6);
+}
+
 .list-item .file-system-value {
   white-space: nowrap;
   text-overflow: ellipsis;
@@ -57,7 +77,7 @@
   flex: none;
   display: flex;
   flex-direction: row;
-  margin: 6px 5px;
+  margin: var(--sys-size-4) var(--sys-size-6);
   align-items: center;
 }
 

package/front_end/models/persistence/workspaceSettingsTab.css

@@ -4,106 +4,40 @@
  * found in the LICENSE file.
  */
 
-.workspace-settings-tab header {
-  padding: 0 0 6px;
+.mappings-info,
+.folder-exclude-pattern {
+  height: var(--settings-single-item-height);
 }
 
-.workspace-settings-tab header > h1 {
-  font-size: 18px;
-  font-weight: normal;
-  margin: 0;
-  padding-bottom: 3px;
+.mapping-view-container {
+  padding-left: 0;
+  padding-right: 0;
 }
 
-.workspace-settings-tab .settings-content {
-  overflow-y: auto;
-  overflow-x: hidden;
-  margin: 8px 8px 8px 0;
-  padding: 0 4px;
-  flex: auto;
-}
-
-.workspace-settings-tab .settings-container {
-  width: 100%;
-  column-width: 288px;
-}
-
-.workspace-settings-tab .settings-tab.settings-container {
-  column-width: 308px;
-}
-
-.workspace-settings-tab .settings-container-wrapper {
-  position: absolute;
-  top: 31px;
-  left: 0;
-  right: 0;
-  bottom: 0;
-  overflow: auto;
-  padding-top: 9px;
-}
-
-.workspace-settings-tab .settings-tab.settings-content {
-  margin: 0;
-  padding: 0;
-}
-
-.workspace-settings-tab .settings-tab p {
-  margin: 12px 0;
-}
-
-.workspace-settings-tab p.folder-exclude-pattern {
-  display: grid;
-  align-items: center;
-}
-
-.workspace-settings-tab p.folder-exclude-pattern > input {
-  width: 80%;
-  margin-left: 10px;
-}
-
-.workspace-settings-tab .settings-tab .file-system-container {
-  border-top: 1px solid var(--sys-color-divider);
-  padding: 19px 0 10px;
-  margin: 20px 0;
-}
-
-.workspace-settings-tab .settings-tab .file-system-header {
+.folder-exclude-pattern {
   display: flex;
-  flex-direction: row;
   align-items: center;
-}
 
-.workspace-settings-tab .settings-tab .file-system-name {
-  font-weight: bold;
-  flex: none;
-  margin-right: 10px;
-  font-size: 15px;
-  overflow: hidden;
-  text-overflow: ellipsis;
-  max-width: 70%;
+  & > input {
+    flex: 1;
+  }
 }
 
-.workspace-settings-tab .settings-tab .file-system-path {
-  white-space: nowrap;
-  overflow: hidden;
-  text-overflow: ellipsis;
-  flex: auto;
+label {
+  padding-bottom: 0;
 }
 
-.workspace-settings-tab .settings-info-message {
-  background-color: var(--sys-color-neutral-container);
-  border-radius: 5px;
-  padding: 10px;
-  margin: 20px 0;
+.mappings-info {
+  border: none;
 }
 
-.workspace-settings-tab .settings-tab.settings-content.settings-container {
-  column-width: initial;
-  overflow: hidden;
-  padding-bottom: 1px;
-  padding-right: 10px;
+.add-button-container {
+  max-width: var(--sys-size-37);
+  margin-left: var(--sys-size-8);
+  width: 100%;
 
-  > devtools-button {
-    margin: 0 0 3px 5px;
+  & .add-folder {
+    min-width: var(--sys-size-31);
+    max-width: var(--sys-size-37);
   }
 }

package/front_end/models/timeline_model/timeline_model.ts

@@ -1,14 +1,8 @@
 // Copyright 2019 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-import * as TimelineJSProfile from './TimelineJSProfile.js';
-import * as TimelineModelFilter from './TimelineModelFilter.js';
-import * as TimelineProfileTree from './TimelineProfileTree.js';
 import * as TracingLayerTree from './TracingLayerTree.js';
 
 export {
-  TimelineJSProfile,
-  TimelineModelFilter,
-  TimelineProfileTree,
   TracingLayerTree,
 };

package/front_end/models/trace/Processor.test.ts

@@ -139,6 +139,7 @@ describeWithEnvironment('TraceProcessor', function() {
     const baseHandler = {
       data() {},
       handleEvent() {},
+      async finalize() {},
       reset() {},
     };
 
@@ -262,7 +263,7 @@ describeWithEnvironment('TraceProcessor', function() {
             generateInsight: () => {
               throw new Error('forced error');
             },
-            deps: Trace.Insights.InsightRunners.RenderBlocking.deps,
+            deps: Trace.Insights.Models.RenderBlocking.deps,
           },
         };
       });
@@ -277,8 +278,8 @@ describeWithEnvironment('TraceProcessor', function() {
 
       const insights = Array.from(processor.insights.values());
       assert.strictEqual(insights.length, 2);
-      assert(insights[1].data.RenderBlocking instanceof Error, 'RenderBlocking did not throw an error');
-      assert.strictEqual(insights[1].data.RenderBlocking.message, 'forced error');
+      assert(insights[1].model.RenderBlocking instanceof Error, 'RenderBlocking did not throw an error');
+      assert.strictEqual(insights[1].model.RenderBlocking.message, 'forced error');
     });
 
     it('skips insights that are missing one or more dependencies', async function() {
@@ -298,8 +299,8 @@ describeWithEnvironment('TraceProcessor', function() {
       ]);
 
       const insights = Array.from(processor.insights.values());
-      assert.isUndefined(insights[0].data.RenderBlocking);
-      assert.isUndefined(insights[1].data.RenderBlocking);
+      assert.isUndefined(insights[0].model.RenderBlocking);
+      assert.isUndefined(insights[1].model.RenderBlocking);
     });
 
     it('returns insights for a navigation', async function() {
@@ -317,15 +318,15 @@ describeWithEnvironment('TraceProcessor', function() {
       ]);
 
       const insights = Array.from(processor.insights.values());
-      if (insights[0].data.RenderBlocking instanceof Error) {
+      if (insights[0].model.RenderBlocking instanceof Error) {
         throw new Error('RenderBlocking threw an error');
       }
-      if (insights[1].data.RenderBlocking instanceof Error) {
+      if (insights[1].model.RenderBlocking instanceof Error) {
         throw new Error('RenderBlocking threw an error');
       }
 
-      assert.strictEqual(insights[0].data.RenderBlocking.renderBlockingRequests.length, 0);
-      assert.strictEqual(insights[1].data.RenderBlocking.renderBlockingRequests.length, 2);
+      assert.strictEqual(insights[0].model.RenderBlocking.renderBlockingRequests.length, 0);
+      assert.strictEqual(insights[1].model.RenderBlocking.renderBlockingRequests.length, 2);
     });
 
     it('returns insights for multiple navigations', async function() {
@@ -345,23 +346,23 @@ describeWithEnvironment('TraceProcessor', function() {
       ]);
 
       const insights = Array.from(processor.insights.values());
-      if (insights[0].data.RenderBlocking instanceof Error) {
+      if (insights[0].model.RenderBlocking instanceof Error) {
         throw new Error('RenderBlocking threw an error');
       }
-      if (insights[1].data.RenderBlocking instanceof Error) {
+      if (insights[1].model.RenderBlocking instanceof Error) {
         throw new Error('RenderBlocking threw an error');
       }
-      if (insights[2].data.RenderBlocking instanceof Error) {
+      if (insights[2].model.RenderBlocking instanceof Error) {
         throw new Error('RenderBlocking threw an error');
       }
-      if (insights[3].data.RenderBlocking instanceof Error) {
+      if (insights[3].model.RenderBlocking instanceof Error) {
         throw new Error('RenderBlocking threw an error');
       }
 
-      assert.strictEqual(insights[0].data.RenderBlocking.renderBlockingRequests.length, 0);
-      assert.strictEqual(insights[1].data.RenderBlocking.renderBlockingRequests.length, 0);
-      assert.strictEqual(insights[2].data.RenderBlocking.renderBlockingRequests.length, 0);
-      assert.strictEqual(insights[3].data.RenderBlocking.renderBlockingRequests.length, 1);
+      assert.strictEqual(insights[0].model.RenderBlocking.renderBlockingRequests.length, 0);
+      assert.strictEqual(insights[1].model.RenderBlocking.renderBlockingRequests.length, 0);
+      assert.strictEqual(insights[2].model.RenderBlocking.renderBlockingRequests.length, 0);
+      assert.strictEqual(insights[3].model.RenderBlocking.renderBlockingRequests.length, 1);
     });
   });
 });