chrome-devtools-frontend 1.0.1367881 → 1.0.1380117

package/package.json

@@ -1,8 +1,6 @@
 {
   "author": "The Chromium Authors",
-  "bugs": {
-    "url": "https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component:Platform%3EDevTools%20&sort=-opened&colspec=ID%20Stars%20Owner%20Summary%20Modified%20Opened"
-  },
+  "bugs": "https://issues.chromium.org/issues?q=status:open componentid:1457055+",
   "description": "Chrome DevTools UI",
   "homepage": "https://devtools.chrome.com",
   "keywords": [
@@ -44,7 +42,9 @@
     "test": "vpython3 third_party/node/node.py --output scripts/run_on_target.mjs gen/test/run.js"
   },
   "devDependencies": {
-    "@rollup/plugin-node-resolve": "10.0.0",
+    "@rollup/plugin-node-resolve": "15.3.0",
+    "@rollup/plugin-terser": "0.4.4",
+    "@rollup/wasm-node": "4.24.3",
     "@types/chai": "4.3.15",
     "@types/codemirror": "5.60.7",
     "@types/emscripten": "1.39.4",
@@ -59,12 +59,12 @@
     "@types/webidl2": "23.13.6",
     "@typescript-eslint/eslint-plugin": "5.59.8",
     "@typescript-eslint/parser": "5.59.8",
-    "@web/rollup-plugin-import-meta-assets": "1.0.7",
+    "@web/rollup-plugin-import-meta-assets": "2.2.1",
     "chai": "4.3.4",
     "chokidar": "3.5.2",
     "cssnano": "5.1.14",
     "cssnano-preset-lite": "2.1.3",
-    "esbuild": "0.14.13",
+    "esbuild": "0.24.0",
     "escodegen": "2.0.0",
     "eslint": "8.19.0",
     "eslint-plugin-import": "2.25.4",
@@ -89,22 +89,22 @@
     "puppeteer-core": "23.0.2",
     "recast": "0.20.5",
     "rimraf": "3.0.2",
-    "rollup": "2.63.0",
-    "rollup-plugin-sourcemaps": "0.6.2",
-    "rollup-plugin-terser": "7.0.2",
+    "rollup-plugin-sourcemaps2": "0.4.2",
     "sinon": "18.0.0",
     "source-map-support": "0.5.21",
     "stylelint": "14.2.0",
     "stylelint-config-standard": "24.0.0",
     "svgo": "2.8.0",
     "terser": "5.19.1",
+    "ts-lit-plugin": "2.0.2",
     "typescript": "5.6.2",
     "webidl2": "24.2.2",
     "ws": "8.18.0",
     "yargs": "17.3.1"
   },
   "overrides": {
+    "tslib": "2.8.0",
     "ws": "$ws"
   },
-  "version": "1.0.1367881"
+  "version": "1.0.1380117"
 }

package/scripts/build/esbuild.js

@@ -5,12 +5,14 @@
 // @ts-check
 
 const path = require('path');
+const os = require('os');
 
 const devtools_paths = require('../devtools_paths.js');
 const devtools_plugin = require('./devtools_plugin.js');
 
 // esbuild module uses binary in this path.
-process.env.ESBUILD_BINARY_PATH = path.join(devtools_paths.devtoolsRootPath(), 'third_party', 'esbuild', 'esbuild');
+const binaryName = os.type() === 'Windows_NT' ? 'esbuild.exe' : 'esbuild';
+process.env.ESBUILD_BINARY_PATH = path.join(devtools_paths.devtoolsRootPath(), 'third_party', 'esbuild', binaryName);
 
 const entryPoints = [process.argv[2]];
 const outfile = process.argv[3];

package/scripts/build/ninja/bundle.gni

@@ -67,7 +67,7 @@ template("bundle") {
     }
   } else {
     node_action(target_name) {
-      script = "node_modules/rollup/dist/bin/rollup"
+      script = "node_modules/@rollup/wasm-node/dist/bin/rollup"
 
       forward_variables_from(invoker,
                              [
@@ -78,7 +78,7 @@ template("bundle") {
 
       inputs = [
         invoker.entrypoint,
-        devtools_location_prepend + "scripts/build/rollup.config.js",
+        devtools_location_prepend + "scripts/build/rollup.config.mjs",
         devtools_location_prepend + "scripts/build/devtools_plugin.js",
         devtools_location_prepend + "scripts/devtools_paths.js",
       ]
@@ -90,7 +90,7 @@ template("bundle") {
         "--silent",
         "--config",
         rebase_path(
-            devtools_location_prepend + "scripts/build/rollup.config.js",
+            devtools_location_prepend + "scripts/build/rollup.config.mjs",
             root_build_dir),
         "--input",
         rebase_path(invoker.entrypoint, root_build_dir),

package/scripts/build/{rollup.config.js → rollup.config.mjs}

@@ -4,10 +4,10 @@
 
 // @ts-check
 
-import sourcemaps from 'rollup-plugin-sourcemaps';
-import {terser} from 'rollup-plugin-terser';
+import sourcemaps from 'rollup-plugin-sourcemaps2';
+import terser from '@rollup/plugin-terser';
 
-const devtools_plugin = require('./devtools_plugin.js');
+import { devtoolsPlugin } from './devtools_plugin.js';
 
 /** @type {function({configSourcemaps: boolean}): import("rollup").MergedRollupOptions} */
 // eslint-disable-next-line import/no-default-export
@@ -23,7 +23,7 @@ export default commandLineArgs => ({
     {
       name: 'devtools-plugin',
       resolveId(source, importer) {
-        return devtools_plugin.devtoolsPlugin(source, importer);
+        return devtoolsPlugin(source, importer);
       },
     },
     sourcemaps(),

package/scripts/devtools_paths.js

@@ -129,6 +129,15 @@ function litAnalyzerExecutablePath() {
   return path.join(nodeModulesPath(), 'lit-analyzer', 'cli.js');
 }
 
+/**
+ * Computes the path to the toplevel `tsconfig.json`.
+ *
+ * @returns the path to the toplevel `tsconfig.json`.
+ */
+function tsconfigJsonPath() {
+  return path.join(devtoolsRootPath(), 'tsconfig.json');
+}
+
 function downloadedChromeBinaryPath() {
   const paths = {
     linux: path.join('chrome-linux', 'chrome'),
@@ -146,5 +155,6 @@ module.exports = {
   mochaExecutablePath,
   stylelintExecutablePath,
   downloadedChromeBinaryPath,
-  litAnalyzerExecutablePath
+  litAnalyzerExecutablePath,
+  tsconfigJsonPath,
 };

package/scripts/devtools_paths.py

@@ -72,7 +72,8 @@ def typescript_compiler_path():
 
 
 def hosted_mode_script_path():
-    return path.join(devtools_root_path(), 'scripts', 'hosted_mode', 'server.js')
+    return path.join(devtools_root_path(), 'scripts', 'hosted_mode',
+                     'server.js')
 
 
 def esbuild_path():
@@ -94,13 +95,15 @@ def downloaded_chrome_binary_path():
 
 
 def license_checker_path():
-    return path.join(node_modules_path(), 'license-checker', 'bin', 'license-checker')
+    return path.join(node_modules_path(), 'license-checker', 'bin',
+                     'license-checker')
 
 
 def rollup_path():
     return path.join(
         node_modules_path(),
-        'rollup',
+        '@rollup',
+        'wasm-node',
         'dist',
         'bin',
         'rollup',
@@ -116,4 +119,5 @@ def package_json_path():
 
 
 def browser_protocol_path():
-    return path.join(third_party_path(), 'blink', 'public', 'devtools_protocol', 'browser_protocol.pdl')
+    return path.join(third_party_path(), 'blink', 'public',
+                     'devtools_protocol', 'browser_protocol.pdl')

package/scripts/eslint_rules/lib/check_test_definitions.js

@@ -47,7 +47,7 @@ module.exports = {
   create: function(context) {
     return {
       MemberExpression(node) {
-        if ((node.object.name === 'it' || node.object.name === 'describe') &&
+        if ((node.object.name === 'it' || node.object.name === 'describe' || node.object.name === 'itScreenshot') &&
             (node.property.name === 'skip' || node.property.name === 'skipOnPlatforms') &&
             node.parent.type === 'CallExpression') {
           const testNameNode = node.property.name === 'skip' ? node.parent.arguments[0] : node.parent.arguments[1];

package/scripts/eslint_rules/tests/check_test_definitions_test.js

@@ -72,8 +72,11 @@ ruleTester.run('check_e2e_tests', rule, {
     },
     {
       code: `import {describe, it} from '../../shared/mocha-extensions.js';
-      // Explaining comment
-      describe.skipOnPlatforms(['mac'], '[crbug.com/123456]: e2e-test', async () => {
+
+      describe('e2e-test', async () => {
+        // Explaining comment
+        it.skipOnPlatforms(['mac'], '[crbug.com/123456]: e2e-test', async () => {
+        });
       });
       `,
       filename: 'test/e2e/folder/file.ts',
@@ -121,6 +124,16 @@ ruleTester.run('check_e2e_tests', rule, {
       filename: 'test/e2e/folder/file.ts',
       errors: [{message: rule.meta.messages.missingBugId}],
     },
+    {
+      code: `describe('e2e-test', async () => {
+        // Explaining comment
+        itScreenshot.skip(\`normal test \${withVariable}\`, async () => {
+        });
+      });
+      `,
+      filename: 'test/e2e/folder/file.ts',
+      errors: [{message: rule.meta.messages.missingBugId}],
+    },
     {
       code: `import {describe, it} from '../../shared/mocha-extensions.js';
 
@@ -142,7 +155,9 @@ ruleTester.run('check_e2e_tests', rule, {
     },
     {
       code: `import {describe, it} from '../../shared/mocha-extensions.js';
-      describe.skipOnPlatforms(['mac'], 'e2e-test', async () => {
+      describe('e2e-test', async () => {
+        it.skipOnPlatforms(['mac'], 'e2e-test', async () => {
+        });
       });
       `,
       filename: 'test/e2e/folder/file.ts',

package/scripts/tools/update_goldens_v2.py

@@ -64,5 +64,5 @@ def build_parser():
 if __name__ == '__main__':
     main(
         ProjectConfig(platforms=['linux', 'mac', 'win64'],
-                      builder_prefix='devtools_frontend',
+                      builder_prefix='dtf',
                       ignore_failed_builders=True), sys.argv[1:])

package/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "./config/typescript/tsconfig.base.json",
   "compilerOptions": {
+    "allowUmdGlobalAccess": true,
     "lib": [
       "esnext",
       "dom",
@@ -9,7 +10,16 @@
       "webworker.iterable"
     ],
     "outDir": "ignored-for-vscode",
-    "allowUmdGlobalAccess": true
+    "plugins": [
+      {
+        "name": "ts-lit-plugin",
+        "rules": {
+          "no-complex-attribute-binding": "off",
+          "no-missing-import": "error",
+          "no-unknown-tag-name": "error"
+        }
+      }
+    ]
   },
   "include": [
     "front_end/",

package/docs/add_uma_metrics.md

@@ -1,41 +0,0 @@
-# How to add UMA metrics in DevTools frontend
-
-Decide on the metric (an [enumerated histogram](https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#enum-histograms) or an [action](https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/core/host/UserMetrics.ts;l=380) to be logged to generic `DevTools.ActionTaken` histogram)
-
-1. For enumerated histogram (We use this when there are multiple related states that should be analyzed jointly. For example, we might want to know the source of an action like where it is performed from)
-    1. Choose a name for the new histogram prefixed with `DevTools`, for example, `DevTools.ColorPickerOpenedFrom`.
-    2. Decide on the values for the different enums you want to log, for example, `StylesPane` and `SourcesPanel` for `DevTools.ColorPickerOpenedFrom` histogram.
-2. For actions
-    1. Decide on the name of the action, for example, `DeviceModeEnabled`.
-
-## Tracking an enumerated histogram
-
-1. Implement metric collection in devtools-frontend and create a CL. (Example [CL](https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3998783))
-    1. Add the new histogram name to the <code>[EnumeratedHistogram](https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/core/host/InspectorFrontendHostAPI.ts;l=351?q=InspectorFrontendHostAPI.ts)</code> enum.
-    2. Add the same histogram name to the EnumeratedHistogram object in <code>[devtools_compatibility.js](https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/devtools_compatibility.js;l=396?q=devtools_compatibil)</code> file.
-    3. Create a new function in <code>[UserMetrics.ts](https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/core/host/UserMetrics.ts;l=351)</code> with an enum parameter that corresponds to the possible values like <code>colorPickerOpenedFrom(type: ColorPickerOpenedFrom): void</code> that calls <code>InspectorFrontendHostInstance.recordEnumeratedHistogram</code>.
-    4. Call the new function from <code>Host.userMetrics</code> in the places that you want to log the event.
-    5. Create the CL.
-2. Update [histograms.xml](https://source.corp.google.com/h/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/dev/histograms.xml) and [enums.xml](https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/enums.xml;l=26267?q=tools%2Fmetrics%2Fhistograms%2Fenums.xml) in the Chromium codebase.
-    1. Add a new enum in [enums.xml](https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/enums.xml;l=26267?q=tools%2Fmetrics%2Fhistograms%2Fenums.xml) with values corresponding to the values in the frontend with name <code>DevTools&lt;HISTOGRAM_NAME></code> and make sure that enum values 1-1 map to the values you’ve defined in the frontend.
-    2. Add the new histogram definition in [histograms.xml](https://source.corp.google.com/h/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/dev/histograms.xml) and set enum name to be the enum you've defined in the 1st step. Make sure that histogram name is the same with the name you've used in the frontend change.
-    3. Create the CL.
-
-## Tracking an action
-
-1. Implement metric collection in devtools-frontend and create a CL. (Example [CL](https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3998783))
-    1. Add the action you want to track to the <code>[Action](https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/core/host/UserMetrics.ts;l=379)</code> enum in <code>UserMetrics.ts.</code>
-    2. Call <code>Host.userMetrics.actionTaken(Action.YOUR_ACTION)</code> in the places you want to the event.
-    3. Create the CL.
-2. Update enums in the Chromium side in <code>[tools/metrics/histograms/enums.xml](https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/enums.xml;l=26267?q=tools%2Fmetrics%2Fhistograms%2Fenums.xml)</code>.
-    1. Add the new action to the <code>DevToolsAction</code> enum.
-    2. Create the CL.
-
-
-## Metrics Dashboard
-
-After the both CLs are landed we expect your histogram or action data to be available in [UMA](http://uma/p/chrome/timeline_v2). For seeing them:
-
-*   Select the channel you want to dive into.
-*   Select the platforms you are interested in (for us, it is Linux, MacOS, Windows, ChromeOS and Lacros)
-*   Add the metric you want to see: either the histogram name you’ve newly added `DevTools.ColorPickerOpenedFrom` or the generic histogram for action tracking, `DevTools.ActionTaken`.

package/docs/uma_metrics.md

@@ -1,23 +0,0 @@
-# UMA metrics in DevTools frontend
-
-(Googlers only) Generally, the histogram or action data is available in the Timeline category of the [UMA](http://uma/) page.
-
-*   Select the channel you want to dive into.
-*   Select the platforms you are interested in (for us, it is Linux, MacOS, Windows, ChromeOS and Lacros)
-*   Add the metric you want to see, for example the generic histogram for action tracking, `DevTools.ActionTaken`.
-
-## General histograms
-
-* `DevTools.ActionTaken` is a generic histogram for tracking actions performed via the DevTools front-end.
-* `DevTools.PanelShown` counts how often a given panel or tab is shown in the DevTools front-end.
-
-## Histograms for the Workspaces feature
-
-* `DevTools.ActionTaken` records `AddFileSystemToWorkspace` (_Add Filesystem to Workspace_), `RemoveFileSystemFromWorkspace`
-  (_Remove Filesystem from Workspace_) and `FileSystemSourceSelected` (_Filesystem source selected_) according to developer
-  interactions with the _Filesystem_ tab in the _Sources_ panels sidebar.
-* `DevTools.Workspaces.PopulateWallClockTime` records the wall clock time in milliseconds elapsed while populating a project
-  folder in the workspace.
-* `DevTools.SidebarPaneShown` records the `navigator-files` (_Sources - Filesystem_) enum whenever the _Filesystem_ tab is
-  revealed in the _Sources_ panels sidebar.
-

package/front_end/models/timeline_model/TimelineModelFilter.ts

@@ -1,61 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as Trace from '../../models/trace/trace.js';
-
-export abstract class TimelineModelFilter {
-  abstract accept(_event: Trace.Types.Events.Event, parsedTrace?: Trace.Handlers.Types.ParsedTrace): boolean;
-}
-
-export class TimelineVisibleEventsFilter extends TimelineModelFilter {
-  private readonly visibleTypes: Set<string>;
-  constructor(visibleTypes: string[]) {
-    super();
-    this.visibleTypes = new Set(visibleTypes);
-  }
-
-  accept(event: Trace.Types.Events.Event): boolean {
-    if (Trace.Types.Extensions.isSyntheticExtensionEntry(event)) {
-      return true;
-    }
-    return this.visibleTypes.has(TimelineVisibleEventsFilter.eventType(event));
-  }
-
-  static eventType(event: Trace.Types.Events.Event): Trace.Types.Events.Name {
-    // Any blink.console category events are treated as ConsoleTime events
-    if (Trace.Helpers.Trace.eventHasCategory(event, 'blink.console')) {
-      return Trace.Types.Events.Name.CONSOLE_TIME;
-    }
-    // Any blink.user_timing egory events are treated as UserTiming events
-    if (Trace.Helpers.Trace.eventHasCategory(event, 'blink.user_timing')) {
-      return Trace.Types.Events.Name.USER_TIMING;
-    }
-    return event.name as Trace.Types.Events.Name;
-  }
-}
-
-export class TimelineInvisibleEventsFilter extends TimelineModelFilter {
-  #invisibleTypes: Set<Trace.Types.Events.Name>;
-
-  constructor(invisibleTypes: Trace.Types.Events.Name[]) {
-    super();
-    this.#invisibleTypes = new Set(invisibleTypes);
-  }
-
-  accept(event: Trace.Types.Events.Event): boolean {
-    return !this.#invisibleTypes.has(TimelineVisibleEventsFilter.eventType(event));
-  }
-}
-
-export class ExclusiveNameFilter extends TimelineModelFilter {
-  #excludeNames: Set<Trace.Types.Events.Name>;
-  constructor(excludeNames: Trace.Types.Events.Name[]) {
-    super();
-    this.#excludeNames = new Set(excludeNames);
-  }
-
-  accept(event: Trace.Types.Events.Event): boolean {
-    return !this.#excludeNames.has(event.name as Trace.Types.Events.Name);
-  }
-}