chrome-devtools-frontend 1.0.1367881 → 1.0.1380117

package/front_end/panels/timeline/utils/IgnoreList.test.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as Common from '../../../core/common/common.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as Bindings from '../../../models/bindings/bindings.js';
 import * as Trace from '../../../models/trace/trace.js';
@@ -51,4 +52,89 @@ describeWithMockConnection('isIgnoreListedEntry', () => {
     await resolver.install();
     assert.isTrue(Utils.IgnoreList.isIgnoreListedEntry(profileCallWithMappings));
   });
+
+  it('ignores entries with a url in the source map\'s ignoreList field when the user enables known third party ignoring',
+     async () => {
+       const {ignoreListedURL, scriptId} = await loadCodeLocationResolvingScenario();
+
+       // This matches the location mapping added to the sourcemap.
+       const LINE_NUMBER = 3;
+       const COLUMN_NUMBER = 0;
+
+       const profileCallWithMappings =
+           makeProfileCall('function', 10, 100, Trace.Types.Events.ProcessID(1), Trace.Types.Events.ThreadID(1));
+       profileCallWithMappings.callFrame = {
+         lineNumber: LINE_NUMBER,
+         columnNumber: COLUMN_NUMBER,
+         functionName: 'ignore',
+         scriptId,
+         url: ignoreListedURL,
+       };
+
+       const workersData: Trace.Handlers.ModelHandlers.Workers.WorkersData = {
+         workerSessionIdEvents: [],
+         workerIdByThread: new Map(),
+         workerURLById: new Map(),
+       };
+       const traceWithMappings = {
+         Samples: makeMockSamplesHandlerData([profileCallWithMappings]),
+         Workers: workersData,
+       } as Trace.Handlers.Types.ParsedTrace;
+       const resolver = new Utils.SourceMapsResolver.SourceMapsResolver(traceWithMappings);
+       await resolver.install();
+       assert.isTrue(Utils.IgnoreList.isIgnoreListedEntry(profileCallWithMappings));
+       const ignoreKnownThirdPartySetting =
+           Common.Settings.Settings.instance().moduleSetting('automatically-ignore-list-known-third-party-scripts');
+       const ignoreKnownThirdPartySettingValue = ignoreKnownThirdPartySetting.get();
+
+       ignoreKnownThirdPartySetting.set(true);
+       assert.isTrue(Utils.IgnoreList.isIgnoreListedEntry(profileCallWithMappings));
+
+       ignoreKnownThirdPartySetting.set(false);
+       assert.isFalse(Utils.IgnoreList.isIgnoreListedEntry(profileCallWithMappings));
+
+       // restore to the original value.
+       ignoreKnownThirdPartySetting.set(ignoreKnownThirdPartySettingValue);
+     });
+  it('ignores entries belonging to content script when the user enables content script ignoring', async () => {
+    const {contentScriptURL, contentScriptId: scriptId} = await loadCodeLocationResolvingScenario();
+
+    const LINE_NUMBER = 0;
+    const COLUMN_NUMBER = 0;
+
+    const profileCallWithContentScript =
+        makeProfileCall('function', 10, 100, Trace.Types.Events.ProcessID(1), Trace.Types.Events.ThreadID(1));
+    profileCallWithContentScript.callFrame = {
+      lineNumber: LINE_NUMBER,
+      columnNumber: COLUMN_NUMBER,
+      functionName: '',
+      scriptId,
+      url: contentScriptURL,
+    };
+
+    const workersData: Trace.Handlers.ModelHandlers.Workers.WorkersData = {
+      workerSessionIdEvents: [],
+      workerIdByThread: new Map(),
+      workerURLById: new Map(),
+    };
+    const traceWithMappings = {
+      Samples: makeMockSamplesHandlerData([profileCallWithContentScript]),
+      Workers: workersData,
+    } as Trace.Handlers.Types.ParsedTrace;
+    const resolver = new Utils.SourceMapsResolver.SourceMapsResolver(traceWithMappings);
+    await resolver.install();
+    assert.isTrue(Utils.IgnoreList.isIgnoreListedEntry(profileCallWithContentScript));
+
+    const ignoreContentScriptSetting = Common.Settings.Settings.instance().moduleSetting('skip-content-scripts');
+    const ignoreContentScriptSettingValue = ignoreContentScriptSetting.get();
+
+    ignoreContentScriptSetting.set(true);
+    assert.isTrue(Utils.IgnoreList.isIgnoreListedEntry(profileCallWithContentScript));
+
+    ignoreContentScriptSetting.set(false);
+    assert.isFalse(Utils.IgnoreList.isIgnoreListedEntry(profileCallWithContentScript));
+
+    // restore to the original value.
+    ignoreContentScriptSetting.set(ignoreContentScriptSettingValue);
+  });
 });

package/front_end/panels/timeline/utils/IgnoreList.ts

@@ -15,10 +15,17 @@ export function isIgnoreListedEntry(entry: Trace.Types.Events.Event): boolean {
   const rawUrl = entry.callFrame.url as Platform.DevToolsPath.UrlString;
 
   const sourceMappedData = SourceMapsResolver.resolvedCodeLocationForEntry(entry);
-  const resolvedUrl = sourceMappedData?.devtoolsLocation?.uiSourceCode.url();
-  return resolvedUrl ? isIgnoreListedURL(resolvedUrl) : isIgnoreListedURL(rawUrl);
+  const script = sourceMappedData?.script;
+  const uiSourceCode = sourceMappedData?.devtoolsLocation?.uiSourceCode;
+  const resolvedUrl = uiSourceCode?.url();
+  const isKnownThirdParty = uiSourceCode?.isKnownThirdParty();
+  const isContentScript = script?.isContentScript();
+  const ignoreListOptions: Bindings.IgnoreListManager.IgnoreListGeneralRules = {isContentScript, isKnownThirdParty};
+  const urlToUse = resolvedUrl || rawUrl;
+  return isIgnoreListedURL(urlToUse, ignoreListOptions);
 }
 
-export function isIgnoreListedURL(url: Platform.DevToolsPath.UrlString): boolean {
-  return Bindings.IgnoreListManager.IgnoreListManager.instance().isUserIgnoreListedURL(url);
+export function isIgnoreListedURL(
+    url: Platform.DevToolsPath.UrlString, options?: Bindings.IgnoreListManager.IgnoreListGeneralRules): boolean {
+  return Bindings.IgnoreListManager.IgnoreListManager.instance().isUserIgnoreListedURL(url, options);
 }

package/front_end/panels/timeline/utils/NetworkRequest.ts

@@ -22,7 +22,7 @@ export function createTimelineNetworkRequest(syntheticNetworkRequest: Trace.Type
 }
 
 // Add a wrapper class here.
-// The reason is the `Reveal in Network panel` option is handled by the context menu provider, which will add this
+// The reason is the `Open in Network panel` option is handled by the context menu provider, which will add this
 // option for all supporting types. And there are a lot of context menu providers that support
 // `SDK.NetworkRequest.NetworkRequest`, for example `Override content` by PersistenceActions, but we so far just want
 // the one to reveal in network panel, so add a new class which will only be supported by Network panel. Also we want to

package/front_end/panels/timeline/utils/SourceMapsResolver.test.ts

@@ -28,8 +28,14 @@ import * as Utils from './utils.js';
 const MINIFIED_FUNCTION_NAME = 'minified';
 const AUTHORED_FUNCTION_NAME = 'someFunction';
 
-export async function loadCodeLocationResolvingScenario():
-    Promise<{authoredScriptURL: string, genScriptURL: string, scriptId: Protocol.Runtime.ScriptId}> {
+export async function loadCodeLocationResolvingScenario(): Promise<{
+  authoredScriptURL: string,
+  genScriptURL: string,
+  scriptId: Protocol.Runtime.ScriptId,
+  ignoreListedURL: string,
+  contentScriptURL: string,
+  contentScriptId: Protocol.Runtime.ScriptId,
+}> {
   const target = createTarget();
 
   const targetManager = SDK.TargetManager.TargetManager.instance();
@@ -43,32 +49,59 @@ export async function loadCodeLocationResolvingScenario():
   });
 
   const backend = new MockProtocolBackend();
+
+  // The following mock data creates a source mapping from two authored
+  // scripts to a single complied script. One of the sources
+  // (ignored.ts) is marked as ignore listed in the source map.
   const sourceRoot = 'http://example.com';
   const scriptInfo = {
     url: `${sourceRoot}/test.out.js`,
-    content: 'function f(x) {\n  console.log(x);\n}\n',
+    content: 'function f(x) {\n  console.log(x);\n}\nfunction ignore(y){\n console.log(y);\n}',
   };
-  const authoredScripName = 'test.ts';
-  const authoredScriptURL = `${sourceRoot}/${authoredScripName}`;
-
+  const authoredScriptName = 'test.ts';
+  const ignoredScriptName = 'ignored.ts';
+  const authoredScriptURL = `${sourceRoot}/${authoredScriptName}`;
+  const ignoreListedScriptURL = `${sourceRoot}/${ignoredScriptName}`;
+  const sourceMap = encodeSourceMap(
+      [
+        `0:9 => ${authoredScriptName}:0:1`,
+        `1:0 => ${authoredScriptName}:4:0`,
+        `1:2 => ${authoredScriptName}:4:2`,
+        `2:0 => ${authoredScriptName}:2:0`,
+        `3:0 => ${ignoredScriptName}:3:0`,
+      ],
+      sourceRoot);
+  sourceMap.sources = [authoredScriptURL, ignoreListedScriptURL];
+  sourceMap.ignoreList = [1];
   const sourceMapInfo = {
     url: `${scriptInfo.url}.map`,
-    content: encodeSourceMap(
-        [
-          `0:9 => ${authoredScripName}:0:1`,
-          `1:0 => ${authoredScripName}:4:0`,
-          `1:2 => ${authoredScripName}:4:2`,
-          `2:0 => ${authoredScripName}:2:0`,
-        ],
-        sourceRoot),
+    content: sourceMap,
+  };
+
+  // The following mock data creates content script
+  const contentScriptInfo = {
+    url: `${sourceRoot}/content-script.js`,
+    content: 'console.log("content script loaded");',
+    isContentScript: true,
   };
-  const [, script] = await Promise.all([
-    debuggerWorkspaceBinding.waitForUISourceCodeAdded(
-        `${sourceRoot}/test.ts` as Platform.DevToolsPath.UrlString, target),
+
+  // Load mock data in devtools
+  const [, , script, , contentScript] = await Promise.all([
+    debuggerWorkspaceBinding.waitForUISourceCodeAdded(authoredScriptURL as Platform.DevToolsPath.UrlString, target),
+    debuggerWorkspaceBinding.waitForUISourceCodeAdded(ignoreListedScriptURL as Platform.DevToolsPath.UrlString, target),
     backend.addScript(target, scriptInfo, sourceMapInfo),
+    debuggerWorkspaceBinding.waitForUISourceCodeAdded(contentScriptInfo.url as Platform.DevToolsPath.UrlString, target),
+    backend.addScript(target, contentScriptInfo, null),
   ]);
 
-  return {authoredScriptURL, scriptId: script.scriptId, genScriptURL: scriptInfo.url};
+  return {
+    authoredScriptURL,
+    scriptId: script.scriptId,
+    genScriptURL: scriptInfo.url,
+    ignoreListedURL: ignoreListedScriptURL,
+    contentScriptURL: contentScriptInfo.url,
+    contentScriptId: contentScript.scriptId,
+  };
 }
 
 function parsedTraceFromProfileCalls(profileCalls: Trace.Types.Events.SyntheticProfileCall[]):

package/front_end/panels/timeline/utils/SourceMapsResolver.ts

@@ -13,6 +13,7 @@ import * as Workspace from '../../../models/workspace/workspace.js';
 type ResolvedCodeLocationData = {
   name: string|null,
   devtoolsLocation: Workspace.UISourceCode.UILocation|null,
+  script: SDK.Script.Script|null,
 };
 export class SourceMappingsUpdated extends Event {
   static readonly eventName = 'sourcemappingsupdated';
@@ -178,6 +179,7 @@ export class SourceMapsResolver extends EventTarget {
           node.setFunctionName(resolvedFunctionName);
 
           const debuggerModel = target.model(SDK.DebuggerModel.DebuggerModel);
+          const script = debuggerModel?.scriptForId(node.scriptId) || null;
           const location = debuggerModel &&
               new SDK.DebuggerModel.Location(
                   debuggerModel, node.callFrame.scriptId, node.callFrame.lineNumber, node.callFrame.columnNumber);
@@ -187,7 +189,7 @@ export class SourceMapsResolver extends EventTarget {
           updatedMappings ||= Boolean(uiLocation);
 
           SourceMapsResolver.storeResolvedNodeDataForEntry(
-              pid, tid, node.callFrame, {name: resolvedFunctionName, devtoolsLocation: uiLocation});
+              pid, tid, node.callFrame, {name: resolvedFunctionName, devtoolsLocation: uiLocation, script});
         }
       }
     }

package/front_end/panels/timeline/utils/utils.ts

@@ -1,6 +1,9 @@
 // Copyright 2024 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
+import * as AICallTree from './AICallTree.js';
+import * as EntryName from './EntryName.js';
+import * as EntryStyles from './EntryStyles.js';
 import * as Helpers from './Helpers.js';
 import * as IgnoreList from './IgnoreList.js';
 import * as ImageCache from './ImageCache.js';
@@ -8,6 +11,9 @@ import * as NetworkRequest from './NetworkRequest.js';
 import * as SourceMapsResolver from './SourceMapsResolver.js';
 
 export {
+  AICallTree,
+  EntryName,
+  EntryStyles,
   Helpers,
   IgnoreList,
   ImageCache,

package/front_end/panels/utils/utils.ts

@@ -6,8 +6,13 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as SDK from '../../core/sdk/sdk.js';
 import * as Formatter from '../../models/formatter/formatter.js';
+import * as Persistence from '../../models/persistence/persistence.js';
+import type * as Workspace from '../../models/workspace/workspace.js';
 import type * as Diff from '../../third_party/diff/diff.js';
 import * as DiffView from '../../ui/components/diff_view/diff_view.js';
+import * as IconButton from '../../ui/components/icon_button/icon_button.js';
+import * as UI from '../../ui/legacy/legacy.js';
+import * as Snippets from '../snippets/snippets.js';
 
 const UIStrings = {
   /**
@@ -71,10 +76,20 @@ export class PanelUtils {
     let iconElement: HTMLElement;
 
     if (PanelUtils.isFailedNetworkRequest(request)) {
-      const iconData = {
-        iconName: 'cross-circle-filled',
-        color: 'var(--icon-error)',
-      };
+      let iconData = undefined;
+      // Failed prefetch network requests are displayed as warnings instead of errors.
+      if (request.resourceType() === Common.ResourceType.resourceTypes.Prefetch) {
+        iconData = {
+          iconName: 'warning-filled',
+          color: 'var(--icon-warning)',
+        };
+      } else {
+        iconData = {
+          iconName: 'cross-circle-filled',
+          color: 'var(--icon-error)',
+        };
+      }
+
       iconElement = PanelUtils.createIconElement(iconData, type.title());
       iconElement.classList.add('icon');
 
@@ -210,6 +225,43 @@ export class PanelUtils {
     return {iconName: 'file-generic', color: 'var(--icon-default)'};
   }
 
+  static getIconForSourceFile(uiSourceCode: Workspace.UISourceCode.UISourceCode):
+      IconButton.FileSourceIcon.FileSourceIcon {
+    const binding = Persistence.Persistence.PersistenceImpl.instance().binding(uiSourceCode);
+    const networkPersistenceManager = Persistence.NetworkPersistenceManager.NetworkPersistenceManager.instance();
+    let iconType = 'document';
+    let hasDotBadge = false;
+    let isDotPurple = false;
+    if (binding) {
+      if (Snippets.ScriptSnippetFileSystem.isSnippetsUISourceCode(binding.fileSystem)) {
+        iconType = 'snippet';
+      }
+      hasDotBadge = true;
+      isDotPurple = networkPersistenceManager.project() === binding.fileSystem.project();
+    } else if (networkPersistenceManager.isActiveHeaderOverrides(uiSourceCode)) {
+      hasDotBadge = true;
+      isDotPurple = true;
+    } else {
+      if (Snippets.ScriptSnippetFileSystem.isSnippetsUISourceCode(uiSourceCode)) {
+        iconType = 'snippet';
+      }
+    }
+
+    const icon = new IconButton.FileSourceIcon.FileSourceIcon(iconType);
+    icon.data = {
+      contentType: uiSourceCode.contentType().name(),
+      hasDotBadge,
+      isDotPurple,
+    };
+
+    if (binding) {
+      UI.Tooltip.Tooltip.install(
+          icon, Persistence.PersistenceUtils.PersistenceUtils.tooltipForUISourceCode(uiSourceCode));
+    }
+
+    return icon;
+  }
+
   static async formatCSSChangesFromDiff(diff: Diff.Diff.DiffArray): Promise<string> {
     const indent = '  ';
     const {originalLines, currentLines, rows} = DiffView.DiffView.buildDiffRows(diff);

package/front_end/services/trace_bounds/TraceBounds.ts

@@ -169,6 +169,11 @@ export class BoundsManager extends EventTarget {
       return;
     }
 
+    if (newWindow.min === existingWindow.min && newWindow.max === existingWindow.max) {
+      // New bounds are identical to the old ones so no action required.
+      return;
+    }
+
     if (!options.ignoreMiniMapBounds) {
       // Ensure that the setTimelineVisibleWindow can never go outside the bounds of the minimap bounds.
       newWindow.min =
@@ -178,7 +183,8 @@ export class BoundsManager extends EventTarget {
     }
 
     if (newWindow.min === existingWindow.min && newWindow.max === existingWindow.max) {
-      // New bounds are identical to the old ones so no action required.
+      // If, after we adjust for the minimap bounds, the new window matches the
+      // old one, we can exit as no action is required.
       return;
     }
 

package/front_end/testing/ContextMenuHelpers.ts

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 import * as UI from '../ui/legacy/legacy.js';
 
-function getMenu(action: () => void): UI.ContextMenu.ContextMenu {
+export function getMenu(action: () => void): UI.ContextMenu.ContextMenu {
   const sandbox = sinon.createSandbox();
 
   const contextMenuShow = sandbox.stub(UI.ContextMenu.ContextMenu.prototype, 'show').resolves();

package/front_end/testing/EnvironmentHelpers.ts

@@ -133,6 +133,8 @@ const REGISTERED_EXPERIMENTS = [
   Root.Runtime.ExperimentName.TIMELINE_ENHANCED_TRACES,
   Root.Runtime.ExperimentName.EXTENSION_STORAGE_VIEWER,
   Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
+  Root.Runtime.ExperimentName.TIMELINE_DIM_UNRELATED_EVENTS,
+  Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
 ];
 
 export async function initializeGlobalVars({reset = true} = {}) {
@@ -220,6 +222,8 @@ export async function initializeGlobalVars({reset = true} = {}) {
         Common.Settings.SettingCategory.EMULATION, 'emulation.touch', '', Common.Settings.SettingType.ENUM),
     createSettingValue(
         Common.Settings.SettingCategory.EMULATION, 'emulation.idle-detection', '', Common.Settings.SettingType.ENUM),
+    createSettingValue(
+        Common.Settings.SettingCategory.EMULATION, 'emulation.cpu-pressure', '', Common.Settings.SettingType.ENUM),
     createSettingValue(
         Common.Settings.SettingCategory.GRID, 'show-grid-line-labels', 'none', Common.Settings.SettingType.ENUM),
     createSettingValue(Common.Settings.SettingCategory.GRID, 'extend-grid-lines', true),
@@ -516,24 +520,24 @@ export function getGetHostConfigStub(config: Root.Runtime.HostConfig): sinon.Sin
       enabled: false,
       ...config.devToolsFreestyler,
     } as Root.Runtime.HostConfigFreestyler,
-    devToolsExplainThisResourceDogfood: {
+    devToolsAiAssistanceNetworkAgent: {
       modelId: '',
       temperature: -1,
       enabled: false,
-      ...config.devToolsExplainThisResourceDogfood,
-    } as Root.Runtime.HostConfigExplainThisResourceDogfood,
-    devToolsAiAssistanceFileAgentDogfood: {
+      ...config.devToolsAiAssistanceNetworkAgent,
+    } as Root.Runtime.HostConfigAiAssistanceNetworkAgent,
+    devToolsAiAssistanceFileAgent: {
       modelId: '',
       temperature: -1,
       enabled: false,
-      ...config.devToolsAiAssistanceFileAgentDogfood,
-    } as Root.Runtime.HostConfigAiAssistanceFileAgentDogfood,
-    devToolsAiAssistancePerformanceAgentDogfood: {
+      ...config.devToolsAiAssistanceFileAgent,
+    } as Root.Runtime.HostConfigAiAssistanceFileAgent,
+    devToolsAiAssistancePerformanceAgent: {
       modelId: '',
       temperature: -1,
       enabled: false,
-      ...config.devToolsAiAssistancePerformanceAgentDogfood,
-    } as Root.Runtime.HostConfigAiAssistancePerformanceAgentDogfood,
+      ...config.devToolsAiAssistancePerformanceAgent,
+    } as Root.Runtime.HostConfigAiAssistancePerformanceAgent,
     devToolsVeLogging: {
       enabled: true,
       testing: false,
@@ -542,6 +546,11 @@ export function getGetHostConfigStub(config: Root.Runtime.HostConfig): sinon.Sin
       enabled: false,
       ...config.devToolsPrivacyUI,
     } as Root.Runtime.HostConfigPrivacyUI,
+    devToolsEnableOriginBoundCookies: {
+      portBindingEnabled: false,
+      schemeBindingEnabled: false,
+      ...config.devToolsEnableOriginBoundCookies,
+    } as Root.Runtime.HostConfigEnableOriginBoundCookies,
     isOffTheRecord: false,
   });
 }

package/front_end/testing/InsightHelpers.ts

@@ -30,9 +30,9 @@ export function createContextForNavigation(
   };
 }
 
-export function getInsightOrError<InsightName extends keyof Trace.Insights.Types.InsightResults>(
+export function getInsightOrError<InsightName extends keyof Trace.Insights.Types.InsightModels>(
     insightName: InsightName, insights: Trace.Insights.Types.TraceInsightSets,
-    navigation?: Trace.Types.Events.NavigationStart): Trace.Insights.Types.InsightResults[InsightName] {
+    navigation?: Trace.Types.Events.NavigationStart): Trace.Insights.Types.InsightModels[InsightName] {
   let key;
   if (navigation) {
     if (!navigation.args.data?.navigationId) {
@@ -48,13 +48,13 @@ export function getInsightOrError<InsightName extends keyof Trace.Insights.Types
     throw new Error('missing navInsights');
   }
 
-  const insight = insightSets.data[insightName];
+  const insight = insightSets.model[insightName];
   if (insight instanceof Error) {
     throw insight;
   }
 
   // For some reason typescript won't narrow the type by removing Error, so do it manually.
-  return insight as Trace.Insights.Types.InsightResults[InsightName];
+  return insight as Trace.Insights.Types.InsightModels[InsightName];
 }
 
 export function getFirstOrError<T>(iterator: IterableIterator<T>): T {

package/front_end/testing/NetworkHelpers.ts

@@ -0,0 +1,38 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Common from '../core/common/common.js';
+import * as Network from '../panels/network/network.js';
+import * as Coordinator from '../ui/components/render_coordinator/render_coordinator.js';
+
+import {
+  registerNoopActions,
+} from './EnvironmentHelpers.js';
+
+const coordinator = Coordinator.RenderCoordinator.RenderCoordinator.instance();
+
+export async function createNetworkPanelForMockConnection(): Promise<Network.NetworkPanel.NetworkPanel> {
+  registerNoopActions(['network.toggle-recording', 'network.clear']);
+
+  const dummyStorage = new Common.Settings.SettingsStorage({});
+  for (const settingName
+           of ['network-color-code-resource-types', 'network.group-by-frame', 'network-record-film-strip-setting']) {
+    Common.Settings.registerSettingExtension({
+      settingName,
+      settingType: Common.Settings.SettingType.BOOLEAN,
+      defaultValue: false,
+    });
+  }
+  Common.Settings.Settings.instance({
+    forceNew: true,
+    syncedStorage: dummyStorage,
+    globalStorage: dummyStorage,
+    localStorage: dummyStorage,
+  });
+  const networkPanel = Network.NetworkPanel.NetworkPanel.instance({forceNew: true, displayScreenshotDelay: 0});
+  networkPanel.markAsRoot();
+  networkPanel.show(document.body);
+  await coordinator.done();
+  return networkPanel;
+}

package/front_end/testing/StorageItemsViewHelpers.ts

@@ -0,0 +1,24 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import type * as DataGrid from '../ui/legacy/components/data_grid/data_grid.js';
+
+export function getCellElementFromNodeAndColumnId<T>(
+    dataGrid: DataGrid.DataGrid.DataGridImpl<T>, node: DataGrid.DataGrid.DataGridNode<T>, columnId: string): Element|
+    null {
+  const column = dataGrid.columns[columnId];
+  const cellIndex = dataGrid.visibleColumnsArray.indexOf(column);
+  return node.element()?.children[cellIndex] || null;
+}
+
+export function selectNodeByKey<T>(
+    dataGrid: DataGrid.DataGrid.DataGridImpl<T>, key: string|null): DataGrid.DataGrid.DataGridNode<T>|null {
+  for (const node of dataGrid.rootNode().children) {
+    if (node?.data?.key === key) {
+      node.select();
+      return node;
+    }
+  }
+  return null;
+}

package/front_end/testing/TraceHelpers.ts

@@ -542,9 +542,11 @@ export function getBaseTraceParseModelData(overrides: Partial<ParsedTrace> = {})
       styleRecalcInvalidationEvents: [],
       renderFrameImplCreateChildFrameEvents: [],
       domLoadingEvents: [],
+      layoutImageUnsizedEvents: [],
       beginRemoteFontLoadEvents: [],
       scoreRecords: [],
       backendNodeIds: [],
+      paintImageEvents: [],
     },
     Meta: {
       traceBounds: {
@@ -607,7 +609,7 @@ export function getBaseTraceParseModelData(overrides: Partial<ParsedTrace> = {})
       performanceMeasures: [],
       timestampEvents: [],
     },
-    LargestImagePaint: new Map(),
+    LargestImagePaint: {imageByDOMNodeId: new Map(), lcpRequestByNavigation: new Map()},
     LargestTextPaint: new Map(),
     AuctionWorklets: {
       worklets: new Map(),
@@ -709,3 +711,11 @@ export function microsecondsTraceWindow(min: number, max: number): Trace.Types.T
       max as Trace.Types.Timing.MicroSeconds,
   );
 }
+
+export function microseconds(x: number): Trace.Types.Timing.MicroSeconds {
+  return Trace.Types.Timing.MicroSeconds(x);
+}
+
+export function milliseconds(x: number): Trace.Types.Timing.MilliSeconds {
+  return Trace.Types.Timing.MilliSeconds(x);
+}

package/front_end/third_party/additional_readme_paths.json

@@ -5,6 +5,7 @@
   "chromium",
   "csp_evaluator",
   "diff",
+  "json5",
   "i18n",
   "intl-messageformat",
   "lighthouse",

package/front_end/third_party/codemirror.next/chunk/angular.js

@@ -1,2 +1,2 @@
-import{s as O,t as r,j as e,p as t,L as n,a,b as o,h as i,E as p}from"./codemirror.js";const l=new p((O=>{let r=O.pos;for(;;){if(10==O.next){O.advance();break}if(123==O.next&&123==O.peek(1)||O.next<0)break;O.advance()}O.pos>r&&O.acceptToken(1)}));function Q(O,r,e){return new p((t=>{let n=t.pos;for(;t.next!=O&&t.next>=0&&(e||38!=t.next&&(123!=t.next||123!=t.peek(1)));)t.advance();t.pos>n&&t.acceptToken(r)}))}const S=Q(39,33,!1),s=Q(34,34,!1),u=Q(39,35,!0),q=Q(34,36,!0),P=o.deserialize({version:14,states:"(jOVOqOOOeQpOOOvO!bO'#CaOOOP'#Cx'#CxQVOqOOO!OQpO'#CfO!WQpO'#ClO!]QpO'#CrO!bQpO'#CsOOQO'#Cv'#CvQ!gQpOOQ!lQpOOQ!qQpOOOOOV,58{,58{O!vOpO,58{OOOP-E6v-E6vO!{QpO,59QO#TQpO,59QOOQO,59W,59WO#YQpO,59^OOQO,59_,59_O#_QpOOO#_QpOOO#gQpOOOOOV1G.g1G.gO#oQpO'#CyO#tQpO1G.lOOQO1G.l1G.lO#|QpO1G.lOOQO1G.x1G.xO$UO`O'#DUO$ZOWO'#DUOOQO'#Co'#CoQOQpOOOOQO'#Cu'#CuO$`OtO'#CwO$qOrO'#CwOOQO,59e,59eOOQO-E6w-E6wOOQO7+$W7+$WO%SQpO7+$WO%[QpO7+$WOOOO'#Cp'#CpO%aOpO,59pOOOO'#Cq'#CqO%fOpO,59pOOOS'#Cz'#CzO%kOtO,59cOOQO,59c,59cOOOQ'#C{'#C{O%|OrO,59cO&_QpO<<GrOOQO<<Gr<<GrOOQO1G/[1G/[OOOS-E6x-E6xOOQO1G.}1G.}OOOQ-E6y-E6yOOQOAN=^AN=^",stateData:"&d~OvOS~OPROSQOVROWRO~OZTO[XO^VOaUOhWO~OR]OU^O~O[`O^aO~O[bO~O[cO~O[dO~ObeO~ObfO~ObgO~ORhO~O]kOwiO~O[lO~O_mO~OynOzoO~OysOztO~O[uO~O]wOwiO~O_yOwiO~OtzO~Os|O~OSQOV!OOW!OOr!OOy!QO~OSQOV!ROW!ROq!ROz!QO~O_!TOwiO~O]!UO~Oy!VO~Oz!VO~OSQOV!OOW!OOr!OOy!XO~OSQOV!ROW!ROq!ROz!XO~O]!ZO~O",goto:"#dyPPPPPzPPPP!WPPPPP!WPP!Z!^!a!d!dP!g!j!m!p!v#Q#WPPPPPPPP#^SROSS!Os!PT!Rt!SRYPRqeR{nR}oRZPRqfR[PRqgQSOR_SQj`SvjxRxlQ!PsR!W!PQ!StR!Y!SQpeRrf",nodeNames:"⚠ Text Content }} {{ Interpolation InterpolationContent Entity InvalidEntity Attribute BoundAttributeName [ Identifier ] ( ) ReferenceName # Is ExpressionAttributeValue AttributeInterpolation AttributeInterpolation EventName DirectiveName * StatementAttributeValue AttributeName AttributeValue",maxTerm:42,nodeProps:[["openedBy",3,"{{",15,"("],["closedBy",4,"}}",14,")"],["isolate",-4,5,19,25,27,""]],skippedNodes:[0],repeatNodeCount:4,tokenData:"0r~RyOX#rXY$mYZ$mZ]#r]^$m^p#rpq$mqr#rrs%jst&Qtv#rvw&hwx)zxy*byz*xz{+`{}#r}!O+v!O!P-]!P!Q#r!Q![+v![!]+v!]!_#r!_!`-s!`!c#r!c!}+v!}#O.Z#O#P#r#P#Q.q#Q#R#r#R#S+v#S#T#r#T#o+v#o#p/X#p#q#r#q#r0Z#r%W#r%W;'S+v;'S;:j-V;:j;=`$g<%lO+vQ#wTUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rQ$ZSO#q#r#r;'S#r;'S;=`$g<%lO#rQ$jP;=`<%l#rR$t[UQvPOX#rXY$mYZ$mZ]#r]^$m^p#rpq$mq#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR%qTyPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR&XTaPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR&oXUQWPOp'[pq#rq!]'[!]!^#r!^#q'[#q#r(d#r;'S'[;'S;=`)t<%lO'[R'aXUQOp'[pq#rq!]'[!]!^'|!^#q'[#q#r(d#r;'S'[;'S;=`)t<%lO'[R(TTVPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR(gXOp'[pq#rq!]'[!]!^'|!^#q'[#q#r)S#r;'S'[;'S;=`)t<%lO'[P)VUOp)Sq!])S!]!^)i!^;'S)S;'S;=`)n<%lO)SP)nOVPP)qP;=`<%l)SR)wP;=`<%l'[R*RTzPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR*iT^PUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR+PT_PUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR+gThPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR+}b[PUQO}#r}!O+v!O!Q#r!Q![+v![!]+v!]!c#r!c!}+v!}#R#r#R#S+v#S#T#r#T#o+v#o#q#r#q#r$W#r%W#r%W;'S+v;'S;:j-V;:j;=`$g<%lO+vR-YP;=`<%l+vR-dTwPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR-zTUQbPO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR.bTZPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR.xT]PUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR/^VUQO#o#r#o#p/s#p#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR/zTSPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#r~0^TO#q#r#q#r0m#r;'S#r;'S;=`$g<%lO#r~0rOR~",tokenizers:[l,S,s,u,q,0,1],topRules:{Content:[0,2],Attribute:[1,9]},tokenPrec:0}),R=e.parser.configure({top:"SingleExpression"}),$=P.configure({props:[O({Text:r.content,Is:r.definitionOperator,AttributeName:r.attributeName,"AttributeValue ExpressionAttributeValue StatementAttributeValue":r.attributeValue,Entity:r.character,InvalidEntity:r.invalid,"BoundAttributeName/Identifier":r.attributeName,"EventName/Identifier":r.special(r.attributeName),"ReferenceName/Identifier":r.variableName,"DirectiveName/Identifier":r.keyword,"{{ }}":r.brace,"( )":r.paren,"[ ]":r.bracket,"# '*'":r.punctuation})]}),g={parser:R},c={parser:e.parser},b={parser:$.configure({wrap:t(((O,r)=>"InterpolationContent"==O.name?g:null))})},m={parser:$.configure({wrap:t(((O,r)=>{var e;return"InterpolationContent"==O.name?g:"AttributeInterpolation"!=O.name?null:"StatementAttributeValue"==(null===(e=O.node.parent)||void 0===e?void 0:e.name)?c:g})),top:"Attribute"})},v=i();function W(O){return O.configure({wrap:t(f)},"angular")}const d=W(v.language);function f(O,r){switch(O.name){case"Attribute":return/^[*#(\[]|\{\{/.test(r.read(O.from,O.to))?m:null;case"Text":return b}return null}function C(O={}){let r=v;if(O.base){if("html"!=O.base.language.name||!(O.base.language instanceof n))throw new RangeError("The base option must be the result of calling html(...)");r=O.base}return new a(r.language==v.language?d:W(r.language),[r.support,r.language.data.of({closeBrackets:{brackets:["[","{",'"']},indentOnInput:/^\s*[\}\]]$/})])}export{C as angular,d as angularLanguage};
+import{s as O,t as r,j as e,L as t,a as n,b as a,h as o,p as i,E as p}from"./codemirror.js";const l=new p((O=>{let r=O.pos;for(;;){if(10==O.next){O.advance();break}if(123==O.next&&123==O.peek(1)||O.next<0)break;O.advance()}O.pos>r&&O.acceptToken(1)}));function Q(O,r,e){return new p((t=>{let n=t.pos;for(;t.next!=O&&t.next>=0&&(e||38!=t.next&&(123!=t.next||123!=t.peek(1)));)t.advance();t.pos>n&&t.acceptToken(r)}))}const S=Q(39,33,!1),s=Q(34,34,!1),u=Q(39,35,!0),q=Q(34,36,!0),P=a.deserialize({version:14,states:"(jOVOqOOOeQpOOOvO!bO'#CaOOOP'#Cx'#CxQVOqOOO!OQpO'#CfO!WQpO'#ClO!]QpO'#CrO!bQpO'#CsOOQO'#Cv'#CvQ!gQpOOQ!lQpOOQ!qQpOOOOOV,58{,58{O!vOpO,58{OOOP-E6v-E6vO!{QpO,59QO#TQpO,59QOOQO,59W,59WO#YQpO,59^OOQO,59_,59_O#_QpOOO#_QpOOO#gQpOOOOOV1G.g1G.gO#oQpO'#CyO#tQpO1G.lOOQO1G.l1G.lO#|QpO1G.lOOQO1G.x1G.xO$UO`O'#DUO$ZOWO'#DUOOQO'#Co'#CoQOQpOOOOQO'#Cu'#CuO$`OtO'#CwO$qOrO'#CwOOQO,59e,59eOOQO-E6w-E6wOOQO7+$W7+$WO%SQpO7+$WO%[QpO7+$WOOOO'#Cp'#CpO%aOpO,59pOOOO'#Cq'#CqO%fOpO,59pOOOS'#Cz'#CzO%kOtO,59cOOQO,59c,59cOOOQ'#C{'#C{O%|OrO,59cO&_QpO<<GrOOQO<<Gr<<GrOOQO1G/[1G/[OOOS-E6x-E6xOOQO1G.}1G.}OOOQ-E6y-E6yOOQOAN=^AN=^",stateData:"&d~OvOS~OPROSQOVROWRO~OZTO[XO^VOaUOhWO~OR]OU^O~O[`O^aO~O[bO~O[cO~O[dO~ObeO~ObfO~ObgO~ORhO~O]kOwiO~O[lO~O_mO~OynOzoO~OysOztO~O[uO~O]wOwiO~O_yOwiO~OtzO~Os|O~OSQOV!OOW!OOr!OOy!QO~OSQOV!ROW!ROq!ROz!QO~O_!TOwiO~O]!UO~Oy!VO~Oz!VO~OSQOV!OOW!OOr!OOy!XO~OSQOV!ROW!ROq!ROz!XO~O]!ZO~O",goto:"#dyPPPPPzPPPP!WPPPPP!WPP!Z!^!a!d!dP!g!j!m!p!v#Q#WPPPPPPPP#^SROSS!Os!PT!Rt!SRYPRqeR{nR}oRZPRqfR[PRqgQSOR_SQj`SvjxRxlQ!PsR!W!PQ!StR!Y!SQpeRrf",nodeNames:"⚠ Text Content }} {{ Interpolation InterpolationContent Entity InvalidEntity Attribute BoundAttributeName [ Identifier ] ( ) ReferenceName # Is ExpressionAttributeValue AttributeInterpolation AttributeInterpolation EventName DirectiveName * StatementAttributeValue AttributeName AttributeValue",maxTerm:42,nodeProps:[["openedBy",3,"{{",15,"("],["closedBy",4,"}}",14,")"],["isolate",-4,5,19,25,27,""]],skippedNodes:[0],repeatNodeCount:4,tokenData:"0r~RyOX#rXY$mYZ$mZ]#r]^$m^p#rpq$mqr#rrs%jst&Qtv#rvw&hwx)zxy*byz*xz{+`{}#r}!O+v!O!P-]!P!Q#r!Q![+v![!]+v!]!_#r!_!`-s!`!c#r!c!}+v!}#O.Z#O#P#r#P#Q.q#Q#R#r#R#S+v#S#T#r#T#o+v#o#p/X#p#q#r#q#r0Z#r%W#r%W;'S+v;'S;:j-V;:j;=`$g<%lO+vQ#wTUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rQ$ZSO#q#r#r;'S#r;'S;=`$g<%lO#rQ$jP;=`<%l#rR$t[UQvPOX#rXY$mYZ$mZ]#r]^$m^p#rpq$mq#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR%qTyPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR&XTaPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR&oXUQWPOp'[pq#rq!]'[!]!^#r!^#q'[#q#r(d#r;'S'[;'S;=`)t<%lO'[R'aXUQOp'[pq#rq!]'[!]!^'|!^#q'[#q#r(d#r;'S'[;'S;=`)t<%lO'[R(TTVPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR(gXOp'[pq#rq!]'[!]!^'|!^#q'[#q#r)S#r;'S'[;'S;=`)t<%lO'[P)VUOp)Sq!])S!]!^)i!^;'S)S;'S;=`)n<%lO)SP)nOVPP)qP;=`<%l)SR)wP;=`<%l'[R*RTzPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR*iT^PUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR+PT_PUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR+gThPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR+}b[PUQO}#r}!O+v!O!Q#r!Q![+v![!]+v!]!c#r!c!}+v!}#R#r#R#S+v#S#T#r#T#o+v#o#q#r#q#r$W#r%W#r%W;'S+v;'S;:j-V;:j;=`$g<%lO+vR-YP;=`<%l+vR-dTwPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR-zTUQbPO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR.bTZPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR.xT]PUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR/^VUQO#o#r#o#p/s#p#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#rR/zTSPUQO#q#r#q#r$W#r;'S#r;'S;=`$g<%lO#r~0^TO#q#r#q#r0m#r;'S#r;'S;=`$g<%lO#r~0rOR~",tokenizers:[l,S,s,u,q,0,1],topRules:{Content:[0,2],Attribute:[1,9]},tokenPrec:0}),R=e.parser.configure({top:"SingleExpression"}),$=P.configure({props:[O({Text:r.content,Is:r.definitionOperator,AttributeName:r.attributeName,"AttributeValue ExpressionAttributeValue StatementAttributeValue":r.attributeValue,Entity:r.character,InvalidEntity:r.invalid,"BoundAttributeName/Identifier":r.attributeName,"EventName/Identifier":r.special(r.attributeName),"ReferenceName/Identifier":r.variableName,"DirectiveName/Identifier":r.keyword,"{{ }}":r.brace,"( )":r.paren,"[ ]":r.bracket,"# '*'":r.punctuation})]}),g={parser:R},c={parser:e.parser},b={parser:$.configure({wrap:i(((O,r)=>"InterpolationContent"==O.name?g:null))})},m={parser:$.configure({wrap:i(((O,r)=>{var e;return"InterpolationContent"==O.name?g:"AttributeInterpolation"!=O.name?null:"StatementAttributeValue"==(null===(e=O.node.parent)||void 0===e?void 0:e.name)?c:g})),top:"Attribute"})},v=o();function W(O){return O.configure({wrap:i(f)},"angular")}const d=W(v.language);function f(O,r){switch(O.name){case"Attribute":return/^[*#(\[]|\{\{/.test(r.read(O.from,O.to))?m:null;case"Text":return b}return null}function C(O={}){let r=v;if(O.base){if("html"!=O.base.language.name||!(O.base.language instanceof t))throw new RangeError("The base option must be the result of calling html(...)");r=O.base}return new n(r.language==v.language?d:W(r.language),[r.support,r.language.data.of({closeBrackets:{brackets:["[","{",'"']},indentOnInput:/^\s*[\}\]]$/})])}export{C as angular,d as angularLanguage};
 //# sourceMappingURL=angular.js.map